[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

2020-08-05 Thread GitBox 


yangyichao-mango commented on a change in pull request #3385:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r465585345



##
File path: pom.xml
##
@@ -783,12 +783,38 @@
 
**/common/utils/RetryerUtilsTest.java
 
**/common/plugin/FilePluginManagerTest
 
**/common/plugin/PluginClassLoaderTest
+**/dao/AlertDaoTest.java
+
**/dao/datasource/OracleDataSourceTest.java
+
**/dao/datasource/HiveDataSourceTest.java
+

+**/dao/entity/TaskInstanceTest.java
+**/dao/entity/UdfFuncTest.java
 
**/dao/mapper/AccessTokenMapperTest.java
 
**/dao/mapper/AlertGroupMapperTest.java
 **/dao/mapper/CommandMapperTest.java
 
**/dao/mapper/ConnectionFactoryTest.java
 
**/dao/mapper/DataSourceMapperTest.java
-**/dao/entity/UdfFuncTest.java
+
**/dao/mapper/DataSourceUserMapperTest.java

Review comment:
   Please revert the changes and just add your test.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

2020-08-03 Thread GitBox 


yangyichao-mango commented on a change in pull request #3385:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464268239



##
File path: 
dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/ConditionsTaskTest.java
##
@@ -17,7 +17,16 @@
 package org.apache.dolphinscheduler.server.master;

Review comment:
   Hi,
   I checkout to your branch and found that the `ConditionsTaskTest.java` is 
not in the test case includer.
   Please add the test to root pom.
   
![image](https://user-images.githubusercontent.com/29545877/89162341-8328d480-d5a6-11ea-9fec-d895d57e44cc.png)
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

2020-08-03 Thread GitBox 


yangyichao-mango commented on a change in pull request #3385:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464259687



##
File path: 
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java
##
@@ -16,19 +16,18 @@
  */
 package org.apache.dolphinscheduler.dao.entity;
 
-import com.baomidou.mybatisplus.annotation.IdType;
-import com.baomidou.mybatisplus.annotation.TableField;
-import com.fasterxml.jackson.annotation.JsonFormat;
 import org.apache.dolphinscheduler.common.enums.ExecutionStatus;
 import org.apache.dolphinscheduler.common.enums.Flag;
 import org.apache.dolphinscheduler.common.enums.Priority;
 import org.apache.dolphinscheduler.common.enums.TaskType;
 import org.apache.dolphinscheduler.common.model.TaskNode;
-import org.apache.dolphinscheduler.common.utils.*;
+import org.apache.dolphinscheduler.common.utils.JSONUtils;
+
 import com.baomidou.mybatisplus.annotation.IdType;
+import com.baomidou.mybatisplus.annotation.TableField;
 import com.baomidou.mybatisplus.annotation.TableId;
 import com.baomidou.mybatisplus.annotation.TableName;
-import org.apache.dolphinscheduler.common.utils.JSONUtils;
+import com.fasterxml.jackson.annotation.JsonFormat;

Review comment:
   The `JsonFormat` is not unused. Please delete. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

2020-08-03 Thread GitBox 


yangyichao-mango commented on a change in pull request #3385:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464259687



##
File path: 
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java
##
@@ -16,19 +16,18 @@
  */
 package org.apache.dolphinscheduler.dao.entity;
 
-import com.baomidou.mybatisplus.annotation.IdType;
-import com.baomidou.mybatisplus.annotation.TableField;
-import com.fasterxml.jackson.annotation.JsonFormat;
 import org.apache.dolphinscheduler.common.enums.ExecutionStatus;
 import org.apache.dolphinscheduler.common.enums.Flag;
 import org.apache.dolphinscheduler.common.enums.Priority;
 import org.apache.dolphinscheduler.common.enums.TaskType;
 import org.apache.dolphinscheduler.common.model.TaskNode;
-import org.apache.dolphinscheduler.common.utils.*;
+import org.apache.dolphinscheduler.common.utils.JSONUtils;
+
 import com.baomidou.mybatisplus.annotation.IdType;
+import com.baomidou.mybatisplus.annotation.TableField;
 import com.baomidou.mybatisplus.annotation.TableId;
 import com.baomidou.mybatisplus.annotation.TableName;
-import org.apache.dolphinscheduler.common.utils.JSONUtils;
+import com.fasterxml.jackson.annotation.JsonFormat;

Review comment:
   The `JsonFormat` is not unused. Please delete. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

2020-08-03 Thread GitBox 


yangyichao-mango commented on a change in pull request #3385:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464259230



##
File path: 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
##
@@ -391,7 +391,12 @@ private Constants() {
 public static final int RPC_PORT = 50051;
 
 /**
- * forbid running task
+ * task can be run normally
+ */
+public static final String FLOWNODE_RUN_FLAG_NORMAL = "NORMAL";

Review comment:
   Hi,
   Good job, but there is no necessary to add the `FLOWNODE_RUN_FLAG_NORMAL` in 
Constants just for test case.
   If you want to add the constant, you can directly add 
`FLOWNODE_RUN_FLAG_NORMAL` in `ConditionsTaskTest`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org