[GitHub] niclash opened a new pull request #4: Change from AsserttJ to Hamcrest

[GitBox]

niclash opened a new pull request #4: Change from AsserttJ to Hamcrest
URL: https://github.com/apache/incubator-plc4x/pull/4
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Problem running some examples with non US locales

[Christofer Dutz]

Ups ... wrong list ... forget this __


Am 14.02.18, 22:06 schrieb "Christofer Dutz" :

Hi,

I’m currently working though some of the examples and encountered a problem:

Code like this:
nextValue = Double.valueOf(df.format(nextValue));

Seems to not work correctly in Germany as we have a “,” as decimal 
separator and “.” as grouping character.
This results numbers like “10,3” being passed into Double.valueOf which 
causes exceptions.

If I change it to this:

try {
nextValue = df.parse(df.format(nextValue)).doubleValue();
} catch (ParseException e) {
// Ignore ...
}

It seems to do what the original codes intention was.

What would be the cleanest way to solve this problem?

Chris

Problem running some examples with non US locales

[Christofer Dutz]

Hi,

I’m currently working though some of the examples and encountered a problem:

Code like this:
nextValue = Double.valueOf(df.format(nextValue));

Seems to not work correctly in Germany as we have a “,” as decimal separator 
and “.” as grouping character.
This results numbers like “10,3” being passed into Double.valueOf which causes 
exceptions.

If I change it to this:

try {
nextValue = df.parse(df.format(nextValue)).doubleValue();
} catch (ParseException e) {
// Ignore ...
}

It seems to do what the original codes intention was.

What would be the cleanest way to solve this problem?

Chris

Updates ...

[Christofer Dutz]

Hi all,

I know I have been unusually silent for the last few days. Had a lot of things 
going on here so here a short summary:

What I’ve been working on:

  *   Implement some tests for the RawSocket (Which I’m not finished with and 
it turned out to be trickier than expected but looking good)
  *   Finished writing an article about PLC4X and Edgent for German IT 
Magazines IoT Special Edition
  *   Write an article with a focus on Edgent with a part about PLC4X in 
another German IT Magazines IoT Special Edition (Stupid double commitment from 
my side)
  *   Communication with loads of people and companies interested in hearing 
more about PLC4X and eventually even joining our team
  *   Submitted Papers about PLC4X to about 6 conferences

In the next few days I’ll hopefully finish the second article (Hopefully they 
will both spread the word quite well). After that I’m hoping to finish the 
RawSocket tests which means that it actually works through IP routers and 
Gateways.

On 26th of February I’m going to visit a company that sells a S7 simulator and 
we’ll exchange information on some of the S7 protocol details, especially 
symbolic addressing. Here we might be able to help each other greatly. 
Eventually even try to setup and configure the simulator as an Integration-Test 
environment. Super-Maybe even get it running on Linux with Mono.

So far the update from my side … been an extremely busy few weeks … have to 
admit I’m totally excited about the symbolic protocol option. We would be the 
first to support this. No other open-source driver currently supports this 
feature :-)

Chris

Re: [DISCUSS] What assertion mechanism to use: JUnit, AssertJ or Hamcrest

[Christofer Dutz]

Hi,

I currently have a strong tendency to accept Niclas' proposal as soon as he 
creates a pull-request for his changes.
So If I don't hear any objections within the next 1-2 days. I'll merge that.

Chris

Am 12.02.18, 09:51 schrieb "Justin Mclean" :

Hi,

> Even if I like the way AssertJ handles exceptions a bit more than the 
Hamcrest way, I never was particularly fond of never-ending fluent expressions. 
So I would opt for the Hamcrest version.

No strong view either way as any tests are good to have :-) But I have used 
Hamcrest in the past and that’s what I’m familiar with. Niclas’ change looks 
good to me.

Thanks,
Justin

TAC Applications for Apache Con North America 2018 in Montreal now open

[Christofer Dutz]

Seems I was faster with my last email … here comes the official one ;-)

—
The Travel Assistance Committee (TAC) are pleased to announce that travel 
assistance applications for ApacheCon NA 2018 are now open!

We will be supporting ApacheCon NA Montreal, Canada on 24th - 29th September 
2018

TAC exists to help those that would like to attend ApacheCon events, but are 
unable to do so for financial reasons.
For more info on this years applications and qualifying criteria, please visit 
the TAC website at < 
http://www.apache.org/travel/ >. Applications 
are now open and will close 1st May.

Important: Applications close on May 1st, 2018. Applicants have until the 
closing date above to submit their applications (which should contain as much 
supporting material as required to efficiently and accurately process their 
request), this will enable TAC to announce successful awards shortly afterwards.

As usual, TAC expects to deal with a range of applications from a diverse range 
of backgrounds. We therefore encourage (as always) anyone thinking about 
sending in an application to do so ASAP.
We look forward to greeting many of you in Montreal

Kind Regards,
Gavin - (On behalf of the Travel Assistance Committee)
—