[jira] [Created] (SLING-7497) Update Pax Exam to 4.12
Oliver Lietz created SLING-7497: --- Summary: Update Pax Exam to 4.12 Key: SLING-7497 URL: https://issues.apache.org/jira/browse/SLING-7497 Project: Sling Issue Type: Task Components: Testing Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Testing PaxExam 1.0.2 Tika Parsers requires Apache Commons Logging 1.2 API which is not provided by Pax Logging 1.8.4 (used by Pax Exam 4.11, see [PAXEXAM-914|https://ops4j1.jira.com/browse/PAXEXAM-914]). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361229#comment-16361229 ] Julian Reschke commented on SLING-7344: --- [~justinedelson] - absolutely. Is there already a ticket related to that for Jetty? > Jackson Sling Model Exporter needs correct character encoding > - > > Key: SLING-7344 > URL: https://issues.apache.org/jira/browse/SLING-7344 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Chris Millar >Assignee: Justin Edelson >Priority: Major > Fix For: Sling Models Impl 1.4.8 > > Attachments: observe-1.png, observe-2.png, observe-3.png > > > This is a formal ticket of what [~justinedelson] and I discussed earlier in > December 2017. > The Jackson Sling Model Exporter needs to correctly set the character > encoding so content can be correctly handled. It currently defaults out to > ISO-8859-1 which makes displaying localized content impossible. > I have put together a sample project here: > https://github.com/auniverseaway/sling-exporter-sample > This will show how the default JSON get servlet correctly handles the > content, but the Jackson exporter does not. I have also attached screenshots > of the behaviors to this ticket. > It sounded like Justin had ideas on where to solve this, so I will defer to > him on where it should be done. If I can help implement a solution in the > place you want, let me know. Internally, we cannot use the Jackson Exporter > until this is fixed, so it's pretty high priority for me to contribute back > if I can. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7484) Move content from JCR root to /content
[ https://issues.apache.org/jira/browse/SLING-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361116#comment-16361116 ] Oliver Lietz commented on SLING-7484: - Thanks, [~klcodanr]! > Move content from JCR root to /content > -- > > Key: SLING-7484 > URL: https://issues.apache.org/jira/browse/SLING-7484 > Project: Sling > Issue Type: Improvement > Components: Launchpad >Reporter: Oliver Lietz >Assignee: Dan Klco >Priority: Major > Fix For: Launchpad Content 2.0.14 > > > Content (HTML, CSS and images) should be placed in {{/content}} instead of > JCR root ({{/}}). > This issue is related to SLING-6130 (open 2nd point in the list). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation
[ https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert updated SLING-7496: Description: In some cases when a factory configuration is created using the OSGi ConfigAdmin API, the configuration gets a call to {{delete()}} immediately when {{update()}} on the configuration is called. The issue comes down to the fact that the factory prefix is prepended twice to the configuration at some point in the installer, which is then assigned to the resource {{entityId}}. This mismatch causes the initial configuration to receive a delete callback as the system thinks it's no longer there. was: In some cases when factory configuration is created using the OSGi ConfigAdmin API, the configuration gets a call to delete() immediately when update() on the configuration is called. The issue comes down to the fact that the factory prefix is prepended twice to the configuration at some point in the installer, which is then assigned to the resource entityID. This mismatch causes the initial configuration to receive a delete callback as the system thinks it's no longer there. > Factory config deleted with ConfigAdmin immediately after creation > -- > > Key: SLING-7496 > URL: https://issues.apache.org/jira/browse/SLING-7496 > Project: Sling > Issue Type: Bug > Components: Installer >Reporter: David Bosschaert >Priority: Major > Fix For: Installer Configuration Factory 1.1.2 > > > In some cases when a factory configuration is created using the OSGi > ConfigAdmin API, the configuration gets a call to {{delete()}} immediately > when {{update()}} on the configuration is called. > > The issue comes down to the fact that the factory prefix is prepended twice > to the configuration at some point in the installer, which is then assigned > to the resource {{entityId}}. This mismatch causes the initial configuration > to receive a delete callback as the system thinks it's no longer there. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-3343) Sling-Junit-Core Method Name in Test selector is not honoured
[ https://issues.apache.org/jira/browse/SLING-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-3343: --- Assignee: (was: Dan Klco) > Sling-Junit-Core Method Name in Test selector is not honoured > - > > Key: SLING-3343 > URL: https://issues.apache.org/jira/browse/SLING-3343 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: org.apache.sling.testing.tools 1.0.6 >Reporter: Sufyan Haroon >Priority: Major > Labels: bug > Attachments: SLING-3343.diff, SLING-3343.patch, SLING-3343.txt > > > When using method name in test selection in browser, method name is not > honoured. > For Example, > When hitting url like, > /system/sling/junit/com.demo.test.demoTest/methodName.html > and executing the test, all the tests in the class demoTest are execute > instead of just executing the test methodName. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation
David Bosschaert created SLING-7496: --- Summary: Factory config deleted with ConfigAdmin immediately after creation Key: SLING-7496 URL: https://issues.apache.org/jira/browse/SLING-7496 Project: Sling Issue Type: Bug Components: Installer Reporter: David Bosschaert Fix For: Installer Configuration Factory 1.1.2 In some cases when factory configuration is created using the OSGi ConfigAdmin API, the configuration gets a call to delete() immediately when update() on the configuration is called. The issue comes down to the fact that the factory prefix is prepended twice to the configuration at some point in the installer, which is then assigned to the resource entityID. This mismatch causes the initial configuration to receive a delete callback as the system thinks it's no longer there. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7465) Clarify licensing of fonts added to launchpad-content
[ https://issues.apache.org/jira/browse/SLING-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-7465. - Resolution: Fixed Added as proposed in: [https://github.com/apache/sling-org-apache-sling-launchpad-content/commit/28e0ae123ef1069033a5e5a2aea0753290492810] [~bdelacretaz] – please reopen if you think this needs any adjustment. > Clarify licensing of fonts added to launchpad-content > - > > Key: SLING-7465 > URL: https://issues.apache.org/jira/browse/SLING-7465 > Project: Sling > Issue Type: Task > Components: Launchpad >Reporter: Bertrand Delacretaz >Assignee: Dan Klco >Priority: Minor > Fix For: Launchpad Content 2.0.14 > > > Hi Dan, assigning this to you as it's related to your changes in SLING-7379 > (cool stuff BTW!) > Those changes have added fonts under > [https://github.com/apache/sling-org-apache-sling-launchpad-content/tree/master/src/main/frontend/src/fonts] > Do you have licensing information for those fonts? Do we need to add a > LICENSE to that module for them? > If that's needed I think we just need to add a license (and notice if needed) > under appended-resources like in > https://github.com/apache/sling-org-apache-sling-commons-log/tree/master/src/main/appended-resources/META-INF -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7484) Move content from JCR root to /content
[ https://issues.apache.org/jira/browse/SLING-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361094#comment-16361094 ] Dan Klco commented on SLING-7484: - Infrastructure ticket created: https://issues.apache.org/jira/browse/INFRA-16017 > Move content from JCR root to /content > -- > > Key: SLING-7484 > URL: https://issues.apache.org/jira/browse/SLING-7484 > Project: Sling > Issue Type: Improvement > Components: Launchpad >Reporter: Oliver Lietz >Assignee: Dan Klco >Priority: Major > Fix For: Launchpad Content 2.0.14 > > > Content (HTML, CSS and images) should be placed in {{/content}} instead of > JCR root ({{/}}). > This issue is related to SLING-6130 (open 2nd point in the list). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7484) Move content from JCR root to /content
[ https://issues.apache.org/jira/browse/SLING-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361074#comment-16361074 ] Oliver Lietz commented on SLING-7484: - [~klcodanr], renaming module and adjusting artifact id: infra is able to rename Git repositories. > Move content from JCR root to /content > -- > > Key: SLING-7484 > URL: https://issues.apache.org/jira/browse/SLING-7484 > Project: Sling > Issue Type: Improvement > Components: Launchpad >Reporter: Oliver Lietz >Assignee: Dan Klco >Priority: Major > Fix For: Launchpad Content 2.0.14 > > > Content (HTML, CSS and images) should be placed in {{/content}} instead of > JCR root ({{/}}). > This issue is related to SLING-6130 (open 2nd point in the list). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7485) Do not rely on Launchpad Content
[ https://issues.apache.org/jira/browse/SLING-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361061#comment-16361061 ] Oliver Lietz commented on SLING-7485: - Starter/SmokeIT fixed by [~klcodanr]. > Do not rely on Launchpad Content > > > Key: SLING-7485 > URL: https://issues.apache.org/jira/browse/SLING-7485 > Project: Sling > Issue Type: Improvement > Components: Karaf, Launchpad, Testing >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Launchpad Content 2.0.14, Karaf Launchpad Integration > Tests (Oak Tar) 0.0.2, Launchpad Integration Tests 1.0.8, Launchpad Test > Services 2.0.14 > > > ITs should not rely on Launchpad Content but content in Launchpad Test > Services. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7484) Move content from JCR root to /content
[ https://issues.apache.org/jira/browse/SLING-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361039#comment-16361039 ] Dan Klco commented on SLING-7484: - Fixed in the following commits: * [https://github.com/apache/sling-org-apache-sling-launchpad-content/commit/28e0ae123ef1069033a5e5a2aea0753290492810] * [https://github.com/apache/sling-org-apache-sling-auth-form/commit/676a0e8fd71cecfdc0e6e912a92867204c9fa540] * https://github.com/apache/sling-org-apache-sling-starter/commit/ba9f6f657d0e70cdc1c0d8938503c530a46ed9fe > Move content from JCR root to /content > -- > > Key: SLING-7484 > URL: https://issues.apache.org/jira/browse/SLING-7484 > Project: Sling > Issue Type: Improvement > Components: Launchpad >Reporter: Oliver Lietz >Assignee: Dan Klco >Priority: Major > Fix For: Launchpad Content 2.0.14 > > > Content (HTML, CSS and images) should be placed in {{/content}} instead of > JCR root ({{/}}). > This issue is related to SLING-6130 (open 2nd point in the list). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SLING-7484) Move content from JCR root to /content
[ https://issues.apache.org/jira/browse/SLING-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361039#comment-16361039 ] Dan Klco edited comment on SLING-7484 at 2/12/18 4:40 PM: -- Updated the paths in the following commits: * [https://github.com/apache/sling-org-apache-sling-launchpad-content/commit/28e0ae123ef1069033a5e5a2aea0753290492810] * [https://github.com/apache/sling-org-apache-sling-auth-form/commit/676a0e8fd71cecfdc0e6e912a92867204c9fa540] * [https://github.com/apache/sling-org-apache-sling-starter/commit/ba9f6f657d0e70cdc1c0d8938503c530a46ed9fe] was (Author: klcodanr): Fixed in the following commits: * [https://github.com/apache/sling-org-apache-sling-launchpad-content/commit/28e0ae123ef1069033a5e5a2aea0753290492810] * [https://github.com/apache/sling-org-apache-sling-auth-form/commit/676a0e8fd71cecfdc0e6e912a92867204c9fa540] * https://github.com/apache/sling-org-apache-sling-starter/commit/ba9f6f657d0e70cdc1c0d8938503c530a46ed9fe > Move content from JCR root to /content > -- > > Key: SLING-7484 > URL: https://issues.apache.org/jira/browse/SLING-7484 > Project: Sling > Issue Type: Improvement > Components: Launchpad >Reporter: Oliver Lietz >Assignee: Dan Klco >Priority: Major > Fix For: Launchpad Content 2.0.14 > > > Content (HTML, CSS and images) should be placed in {{/content}} instead of > JCR root ({{/}}). > This issue is related to SLING-6130 (open 2nd point in the list). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361002#comment-16361002 ] Justin Edelson commented on SLING-7344: --- {quote}FWIW, there is no "right" approach for text/json, as that media type is undefined. {quote} Please explain this to the Jetty team. > Jackson Sling Model Exporter needs correct character encoding > - > > Key: SLING-7344 > URL: https://issues.apache.org/jira/browse/SLING-7344 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Chris Millar >Assignee: Justin Edelson >Priority: Major > Fix For: Sling Models Impl 1.4.8 > > Attachments: observe-1.png, observe-2.png, observe-3.png > > > This is a formal ticket of what [~justinedelson] and I discussed earlier in > December 2017. > The Jackson Sling Model Exporter needs to correctly set the character > encoding so content can be correctly handled. It currently defaults out to > ISO-8859-1 which makes displaying localized content impossible. > I have put together a sample project here: > https://github.com/auniverseaway/sling-exporter-sample > This will show how the default JSON get servlet correctly handles the > content, but the Jackson exporter does not. I have also attached screenshots > of the behaviors to this ticket. > It sounded like Justin had ideas on where to solve this, so I will defer to > him on where it should be done. If I can help implement a solution in the > place you want, let me know. Internally, we cannot use the Jackson Exporter > until this is fixed, so it's pretty high priority for me to contribute back > if I can. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7485) Do not rely on Launchpad Content
[ https://issues.apache.org/jira/browse/SLING-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360845#comment-16360845 ] Robert Munteanu commented on SLING-7485: [~olli] - this seems to have broken the starter build ( https://builds.apache.org/view/S-Z/view/Sling/job/sling-org-apache-sling-starter-1.8/67/ ) . Can you please look into it? > Do not rely on Launchpad Content > > > Key: SLING-7485 > URL: https://issues.apache.org/jira/browse/SLING-7485 > Project: Sling > Issue Type: Improvement > Components: Karaf, Launchpad, Testing >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Launchpad Content 2.0.14, Karaf Launchpad Integration > Tests (Oak Tar) 0.0.2, Launchpad Integration Tests 1.0.8, Launchpad Test > Services 2.0.14 > > > ITs should not rely on Launchpad Content but content in Launchpad Test > Services. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [DISCUSSION] Rename Launchpad Starter
As there are 3 +1s and no -1s I will start revising the launchpad.content according to the outlined changes. On Fri, Feb 9, 2018 at 5:41 AM, Robert Munteanu wrote: > On Thu, 2018-02-08 at 23:43 -0500, Daniel Klco wrote: > > All, > > > > In https://issues.apache.org/jira/browse/SLING-7484 we're going to be > > moving the existing Launchpad Content into a sub-directory of > > /content to > > enable restricting access to / by default. As part of this, change we > > are > > suggesting: > > > >- Moving all root content to /content/starter > >- Renaming the module to Starter Content > >- Updating references in other bundles such as Starter and Auth > > Forms to > >the new directory > > > > Are there any objects to this approach? > > > > My +1 for the change. > > +1 > > I think overall that we should deploy content ( including samples, > applications ) in as specific locations as possible to prevent > overwriting. > > Thanks, > > Robert >
Re: Making github.com/apache/sling a git repo, moving away old svn mirror (Re: apache/sling as github landing repository)
+1 On Mon, Feb 12, 2018 at 4:25 AM, Bertrand Delacretaz wrote: > On Mon, Feb 12, 2018 at 10:23 AM, Robert Munteanu > wrote: > > ...The basic proposal as I see it would be to add a new 'sling' top-level > > github repo, which means that: > > > > 1. we control what goes in there - README.md most importantly > > 2. old links to sling commits and files will be broken . ... > > +1 > > -Bertrand >
[jira] [Closed] (SLING-7148) Do not fail when disabling or deleting a non existing service user
[ https://issues.apache.org/jira/browse/SLING-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-7148. - > Do not fail when disabling or deleting a non existing service user > -- > > Key: SLING-7148 > URL: https://issues.apache.org/jira/browse/SLING-7148 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: Timothee Maret >Assignee: Karl Pauls >Priority: Major > Fix For: Repoinit JCR 1.1.8 > > > SLING-6984 allows to disable service user. The existing implementation does > throw an exception if the service user to be disabled does not exist. This > prevent to remove the service user for new setups. > This issue is about allowing to disable a non existing user, by simply > logging a warning message rather than throwing an exception. > cc [~bdelacretaz] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7280) Repoinit: add support for empty rep:glob restriction
[ https://issues.apache.org/jira/browse/SLING-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-7280. - > Repoinit: add support for empty rep:glob restriction > > > Key: SLING-7280 > URL: https://issues.apache.org/jira/browse/SLING-7280 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: angela >Assignee: Bertrand Delacretaz >Priority: Major > Fix For: Repoinit JCR 1.1.8 > > > [~bdelacretaz], I was asked by a colleague at Adobe how to create a > _rep:glob_ restriction with an empty string value as it is possible and > documented with Jackrabbit API. I didn't find how to do that and suspect that > it's simply a bug in the repo init. > I would appreciate if you could look into this and fix it. > cc: [~marett] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7454) Move repoinit integration tests to the JCR repoinit module
[ https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-7454. - > Move repoinit integration tests to the JCR repoinit module > -- > > Key: SLING-7454 > URL: https://issues.apache.org/jira/browse/SLING-7454 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Repoinit JCR 1.1.8 > > > Currently those tests are at > [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are > failing. > It makes more sense anyway to move them to the jcr-repoinit module which has > similar dependencies, and in that way they are executed at the right time, > before releasing that module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7227) Repo Init: Add ability to register custom privileges
[ https://issues.apache.org/jira/browse/SLING-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-7227. - > Repo Init: Add ability to register custom privileges > > > Key: SLING-7227 > URL: https://issues.apache.org/jira/browse/SLING-7227 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Reporter: angela >Assignee: Karl Pauls >Priority: Major > Fix For: Repoinit Parser 1.2.2, Repoinit JCR 1.1.8 > > > [~marett], [~bdelacretaz], looking at the repo-init source I couldn't find a > way to register a custom privilege during repo init. I am sure this is an > oversight and hasn't been omitted intentionally. > The corresponding API calls are: > {code} > JackrabbitWorkspace.getPrivilegeManager() > PrivilegeManager.registerPrivilege(String privilegeName, boolean isAbstract, > String[] declaredAggregateNames) > {code} > See also > http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-api/src/main/java/org/apache/jackrabbit/api/JackrabbitWorkspace.java?view=markup > http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authorization/PrivilegeManager.java?view=markup > I would be appreciate if the repo init could have this gap filled. Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7326) Disallow empty strings in repoinit grammar
[ https://issues.apache.org/jira/browse/SLING-7326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-7326. - > Disallow empty strings in repoinit grammar > -- > > Key: SLING-7326 > URL: https://issues.apache.org/jira/browse/SLING-7326 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.2.0 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Repoinit Parser 1.2.2 > > > The JavaCC parser generator warns that the STRING production allowing empty > strings could potentially cause infinite loops. > Empty strings should not be needed in the grammar so far, so we should change > the STRING production to disallow them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7226) Repoinit: support optional intermediate path for user creation
[ https://issues.apache.org/jira/browse/SLING-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-7226. - > Repoinit: support optional intermediate path for user creation > -- > > Key: SLING-7226 > URL: https://issues.apache.org/jira/browse/SLING-7226 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit Parser 1.2.0, Repoinit JCR 1.1.6 >Reporter: angela >Assignee: Bertrand Delacretaz >Priority: Major > Fix For: Repoinit Parser 1.2.2, Repoinit JCR 1.1.8 > > > [~marett], [~bdelacretaz], if I am not mistaken it is currently not possible > to pass the second parameter 'intermediatePath' when creating a service user > using the repo-init. > In the Jackrabbit {{UserManager}} API the call looks as follows: > {code} > UserManager.createSystemUser(String userID, String intermediatePath) > {code} > I would appreciate if both params would be respected by the repo-init and I > don't think it should be a big deal adding this. > Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7423) Upgrade Oak to 1.8
[ https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360681#comment-16360681 ] Oliver Lietz commented on SLING-7423: - [~rombert], see the umbrella issue SLING-7446 and SLING-7438 for Testing PaxExam. Everything is already in place for Oak 1.8 (see branch feature/oak-1.8 in each module involved). > Upgrade Oak to 1.8 > -- > > Key: SLING-7423 > URL: https://issues.apache.org/jira/browse/SLING-7423 > Project: Sling > Issue Type: Sub-task >Affects Versions: JCR Oak Server 1.1.4 >Reporter: Christian Schneider >Assignee: Oliver Lietz >Priority: Major > > The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API > was changed in an incompatible way. We should adapt to these changes. See > below for the changed classes. > 1.6 > import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; > import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent; > import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider; > import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider; > 1.7 > import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> > oak-query-spi > import org.apache.jackrabbit.oak.InitialContent; -> oak-core > import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> > oak-query-spi > import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; > -> oak-core > > Preparing for Oak 1.8 in branch > [feature/oak-1.8|https://github.com/apache/sling-org-apache-sling-jcr-oak-server/tree/feature/oak-1.8]. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7495) Start of online compaction of the repository
Guido Dunker created SLING-7495: --- Summary: Start of online compaction of the repository Key: SLING-7495 URL: https://issues.apache.org/jira/browse/SLING-7495 Project: Sling Issue Type: Improvement Reporter: Guido Dunker There is no information about when the online compaction will be startet. I cannot see any cron pattern or time i could configure. The only way to start the compaction at a given time, is to call the mbean from outside. Please find a way to configure start times like we see in the according AEM software. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7494) FileDataStore Configuration
Guido Dunker created SLING-7494: --- Summary: FileDataStore Configuration Key: SLING-7494 URL: https://issues.apache.org/jira/browse/SLING-7494 Project: Sling Issue Type: Improvement Components: Documentation Reporter: Guido Dunker In the configuration of "Oak Segment Tar NodeStore service" If you activate "Custom blob store" there is no working documentation, how to configure and so activate the component org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore There is only one way i found after experimenting: Create a File sling\config\org\apache\jackrabbit\oak\plugins\blob\datastore\FileDataStore.config with this content for example: minRecordLength=I"100" cacheSize=I"1" path="./sling/repository/datastore" service.pid="org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore" When configuring programmatically, a had also the state "no config", inactive, "edit config" - a contradiction! At http://jackrabbit.apache.org/oak/docs/osgi_config.html there is stated to use ${sling.home}/install folder, but that does not work. Please update your documentation, and/or find a proper way to configure the FileDatastore -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [RESULT][VOTE] Release Apache Sling Repoinit Parser 1.2.2 and Repoinit JCR 1.1.8
Time to call the vote on the Apache Sling Repoinit Parser 1.2.2 and Repoinit JCR 1.1.8 releases. * +1 votes from Bertrand Delacretaz. Carsten Ziegeler, Robert Munteanu, Daniel Klco, and Karl Pauls. * No other votes. The vote is successful. I will make the artifacts available as soon as possible.
Re: [VOTE] Release Apache Sling Repoinit Parser 1.2.2 and Repoinit JCR 1.1.8
+1 regards, Karl On Thu, Feb 1, 2018 at 8:42 PM, Daniel Klco wrote: > +1 > > On Wed, Jan 31, 2018 at 9:55 AM, Robert Munteanu wrote: > >> On Wed, 2018-01-31 at 14:38 +0100, Karl Pauls wrote: >> > Please vote to approve these releases: >> >> +1 >> >> Robert -- Karl Pauls karlpa...@gmail.com
[jira] [Commented] (SLING-7493) HTL must leave external urls untouched
[ https://issues.apache.org/jira/browse/SLING-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360572#comment-16360572 ] Tijmen commented on SLING-7493: --- In addition to the '.aspx' extension that gets rewritten to an '.html' extension, the current implementation also add the '.html' extension to external links if those links contain a forward slash: * [https://www.twitter.com|https://www.google.com/] is unmodified, as expected. * [https://www.twitter.com/TheASF] gets an '.html' extension, this is often unwanted behavior; [https://www.twitter.com/TheASF.html]. * [https://www.twitter.com/TheASF.aspx] loses its existing extension (it is replaced with '.html'), which is often unwanted behavior; [https:///www.twitter.com/TheASF.html|https://issues.apache.org/www.twitter.com/TheASF.html]. > HTL must leave external urls untouched > -- > > Key: SLING-7493 > URL: https://issues.apache.org/jira/browse/SLING-7493 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting HTL Engine 1.0.48-1.3.1 >Reporter: Feike Visser >Priority: Major > > In the current implementation of @ extension option of HTL, also external > urls are changed. > It is very common to have a list with both internal and external urls. >
[jira] [Created] (SLING-7493) HTL must leave external urls untouched
Feike Visser created SLING-7493: --- Summary: HTL must leave external urls untouched Key: SLING-7493 URL: https://issues.apache.org/jira/browse/SLING-7493 Project: Sling Issue Type: Improvement Components: Scripting Affects Versions: Scripting HTL Engine 1.0.48-1.3.1 Reporter: Feike Visser In the current implementation of @ extension option of HTL, also external urls are changed. It is very common to have a list with both internal and external urls.
Re: Making github.com/apache/sling a git repo, moving away old svn mirror (Re: apache/sling as github landing repository)
On Mon, Feb 12, 2018 at 10:23 AM, Robert Munteanu wrote: > ...The basic proposal as I see it would be to add a new 'sling' top-level > github repo, which means that: > > 1. we control what goes in there - README.md most importantly > 2. old links to sling commits and files will be broken . ... +1 -Bertrand
Making github.com/apache/sling a git repo, moving away old svn mirror (Re: apache/sling as github landing repository)
Hi, I usually am reluctant in revisiting old decisions, especially ones that were so discussed, like this one. Some summaries of previous discussion are at [1], [2] . But Alex makes some good points and after the migration I think we should consider whether backwards compatibility of incoming links is worth the limited control we have over github.com/apache/sling, which many times is an entry point for developers. The basic proposal as I see it would be to add a new 'sling' top-level github repo, which means that: 1. we control what goes in there - README.md most importantly 2. old links to sling commits and files will be broken . TBH, I am not sure #2 is such a bad thing, given that I've seen people still link to files in the old repo. Thoughts? Thanks, Robert [1]: https://lists.apache.org/thread.html/9e1ceee36af811ba3d2a0a2baa249 8077281f0d3c1da29747a833ea3@%3Cdev.sling.apache.org%3E [2]: https://issues.apache.org/jira/browse/SLING-7183
Re: apache/sling as github landing repository
Hi Jason, On Sat, 2018-02-10 at 09:24 -0500, Jason E Bailey wrote: > And this would be one of those occasions where I thought I knew what > I was talking about and I was wrong. What I was referencing was > something I was led to believe was submodules but is so convoluted > that I don't want to go there. I can see where submodules would be > really useful in some situations but from what I've been hearing on > this conversation thread it's not a solution. Thanks for coming back to the list, even if the answer is that there is nothing to include in a POC :-) For the record, one additional point to consider with the ASF-hosted infrastructure is that for most cases only actual 'people' can commit, not bots. Infra is pretty strong in their stance in making sure that all check- ins are validated from an IP point of view, and a bot writing in the git repos, even though technically it does not add source code, would need pretty strong arguments in the 'risk vs gain' area. Robert > > - Jason > > On Thu, Feb 8, 2018, at 11:03 AM, Bertrand Delacretaz wrote: > > On Thu, Feb 8, 2018 at 4:27 PM, Jason E Bailey > > wrote: > > > I'll work on standing something up as a POC so that there is > > > something tangible... > > > > Great, thanks! > > > > -Bertrand
[jira] [Commented] (SLING-7423) Upgrade Oak to 1.8
[ https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360458#comment-16360458 ] ASF GitHub Bot commented on SLING-7423: --- cschneider commented on issue #1: SLING-7423 Migrate to Oak 1.8 URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-364863031 Ok . Will work on it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Oak to 1.8 > -- > > Key: SLING-7423 > URL: https://issues.apache.org/jira/browse/SLING-7423 > Project: Sling > Issue Type: Sub-task >Affects Versions: JCR Oak Server 1.1.4 >Reporter: Christian Schneider >Assignee: Oliver Lietz >Priority: Major > > The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API > was changed in an incompatible way. We should adapt to these changes. See > below for the changed classes. > 1.6 > import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; > import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent; > import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider; > import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider; > 1.7 > import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> > oak-query-spi > import org.apache.jackrabbit.oak.InitialContent; -> oak-core > import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> > oak-query-spi > import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; > -> oak-core > > Preparing for Oak 1.8 in branch > [feature/oak-1.8|https://github.com/apache/sling-org-apache-sling-jcr-oak-server/tree/feature/oak-1.8]. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] cschneider commented on issue #1: SLING-7423 Migrate to Oak 1.8
cschneider commented on issue #1: SLING-7423 Migrate to Oak 1.8 URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-364863031 Ok . Will work on it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (SLING-6766) Javadoc: Include package org.apache.sling.adapter.annotations in the Sling javadocs
[ https://issues.apache.org/jira/browse/SLING-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-6766. Resolution: Fixed > Javadoc: Include package org.apache.sling.adapter.annotations in the Sling > javadocs > --- > > Key: SLING-6766 > URL: https://issues.apache.org/jira/browse/SLING-6766 > Project: Sling > Issue Type: Improvement > Components: Commons, Site >Reporter: Konrad Windszus >Assignee: Robert Munteanu >Priority: Major > Attachments: Open_Type.png > > > Currently the javadocs at https://sling.apache.org/apidocs/sling8/ do not > include the package {{org.apache.sling.adapter.annotations}} (being added > with SLING-2313). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-6766) Javadoc: Include package org.apache.sling.adapter.annotations in the Sling javadocs
[ https://issues.apache.org/jira/browse/SLING-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360442#comment-16360442 ] Robert Munteanu commented on SLING-6766: Absolutely [~kwin], I've now pushed the changes. This was intended to give someone else a chance to experience the process, I did not expect to get into so much trouble :| > Javadoc: Include package org.apache.sling.adapter.annotations in the Sling > javadocs > --- > > Key: SLING-6766 > URL: https://issues.apache.org/jira/browse/SLING-6766 > Project: Sling > Issue Type: Improvement > Components: Commons, Site >Reporter: Konrad Windszus >Assignee: Robert Munteanu >Priority: Major > Attachments: Open_Type.png > > > Currently the javadocs at https://sling.apache.org/apidocs/sling8/ do not > include the package {{org.apache.sling.adapter.annotations}} (being added > with SLING-2313). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7423) Upgrade Oak to 1.8
[ https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360423#comment-16360423 ] ASF GitHub Bot commented on SLING-7423: --- rombert commented on issue #1: SLING-7423 Migrate to Oak 1.8 URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-364854311 @cschneider - I guess the steps would be the following - update this bundle - update the launchpad Since the launchpad should only contain releases, we need a vote for this bundle and then to update the launchpad.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Oak to 1.8 > -- > > Key: SLING-7423 > URL: https://issues.apache.org/jira/browse/SLING-7423 > Project: Sling > Issue Type: Sub-task >Affects Versions: JCR Oak Server 1.1.4 >Reporter: Christian Schneider >Assignee: Oliver Lietz >Priority: Major > > The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API > was changed in an incompatible way. We should adapt to these changes. See > below for the changed classes. > 1.6 > import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; > import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent; > import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider; > import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider; > 1.7 > import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> > oak-query-spi > import org.apache.jackrabbit.oak.InitialContent; -> oak-core > import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> > oak-query-spi > import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; > -> oak-core > > Preparing for Oak 1.8 in branch > [feature/oak-1.8|https://github.com/apache/sling-org-apache-sling-jcr-oak-server/tree/feature/oak-1.8]. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] rombert commented on a change in pull request #1: SLING-7423 Migrate to Oak 1.8
rombert commented on a change in pull request #1: SLING-7423 Migrate to Oak 1.8 URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#discussion_r167486967 ## File path: pom.xml ## @@ -208,6 +208,13 @@ slf4j-api provided + + org.slf4j + slf4j-jdk14 Review comment: Does `slf4j-simple` work here as well? I don't strongly prefer either dependency, but since we use `slf4j-simple` in most other places it would be more consistent. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7423) Upgrade Oak to 1.8
[ https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360421#comment-16360421 ] ASF GitHub Bot commented on SLING-7423: --- rombert commented on a change in pull request #1: SLING-7423 Migrate to Oak 1.8 URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#discussion_r167486967 ## File path: pom.xml ## @@ -208,6 +208,13 @@ slf4j-api provided + + org.slf4j + slf4j-jdk14 Review comment: Does `slf4j-simple` work here as well? I don't strongly prefer either dependency, but since we use `slf4j-simple` in most other places it would be more consistent. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Oak to 1.8 > -- > > Key: SLING-7423 > URL: https://issues.apache.org/jira/browse/SLING-7423 > Project: Sling > Issue Type: Sub-task >Affects Versions: JCR Oak Server 1.1.4 >Reporter: Christian Schneider >Assignee: Oliver Lietz >Priority: Major > > The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API > was changed in an incompatible way. We should adapt to these changes. See > below for the changed classes. > 1.6 > import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; > import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent; > import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider; > import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider; > 1.7 > import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> > oak-query-spi > import org.apache.jackrabbit.oak.InitialContent; -> oak-core > import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> > oak-query-spi > import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; > -> oak-core > > Preparing for Oak 1.8 in branch > [feature/oak-1.8|https://github.com/apache/sling-org-apache-sling-jcr-oak-server/tree/feature/oak-1.8]. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7423) Upgrade Oak to 1.8
[ https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360422#comment-16360422 ] ASF GitHub Bot commented on SLING-7423: --- rombert commented on a change in pull request #1: SLING-7423 Migrate to Oak 1.8 URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#discussion_r167487105 ## File path: src/test/java/org/apache/sling/jcr/oak/server/it/SlingOptionsOak18.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sling.jcr.oak.server.it; + +import static org.ops4j.pax.exam.CoreOptions.composite; +import static org.ops4j.pax.exam.CoreOptions.mavenBundle; +import static org.ops4j.pax.exam.cm.ConfigurationAdminOptions.factoryConfiguration; + +import org.apache.sling.testing.paxexam.SlingOptions; +import org.ops4j.pax.exam.Option; + +public class SlingOptionsOak18 extends SlingOptions { Review comment: Is there an option of moving this to the pax-exam utils module? I think it's a lot of testing code which should live elsewhere. @oliverlietz , what do you think of this ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Oak to 1.8 > -- > > Key: SLING-7423 > URL: https://issues.apache.org/jira/browse/SLING-7423 > Project: Sling > Issue Type: Sub-task >Affects Versions: JCR Oak Server 1.1.4 >Reporter: Christian Schneider >Assignee: Oliver Lietz >Priority: Major > > The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API > was changed in an incompatible way. We should adapt to these changes. See > below for the changed classes. > 1.6 > import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; > import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent; > import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider; > import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider; > 1.7 > import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> > oak-query-spi > import org.apache.jackrabbit.oak.InitialContent; -> oak-core > import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> > oak-query-spi > import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; > -> oak-core > > Preparing for Oak 1.8 in branch > [feature/oak-1.8|https://github.com/apache/sling-org-apache-sling-jcr-oak-server/tree/feature/oak-1.8]. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] rombert commented on a change in pull request #1: SLING-7423 Migrate to Oak 1.8
rombert commented on a change in pull request #1: SLING-7423 Migrate to Oak 1.8 URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#discussion_r167487105 ## File path: src/test/java/org/apache/sling/jcr/oak/server/it/SlingOptionsOak18.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sling.jcr.oak.server.it; + +import static org.ops4j.pax.exam.CoreOptions.composite; +import static org.ops4j.pax.exam.CoreOptions.mavenBundle; +import static org.ops4j.pax.exam.cm.ConfigurationAdminOptions.factoryConfiguration; + +import org.apache.sling.testing.paxexam.SlingOptions; +import org.ops4j.pax.exam.Option; + +public class SlingOptionsOak18 extends SlingOptions { Review comment: Is there an option of moving this to the pax-exam utils module? I think it's a lot of testing code which should live elsewhere. @oliverlietz , what do you think of this ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rombert commented on issue #1: SLING-7423 Migrate to Oak 1.8
rombert commented on issue #1: SLING-7423 Migrate to Oak 1.8 URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-364854311 @cschneider - I guess the steps would be the following - update this bundle - update the launchpad Since the launchpad should only contain releases, we need a vote for this bundle and then to update the launchpad.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (SLING-7492) Lots of logs on missing SlingRequestProgressTracker
[ https://issues.apache.org/jira/browse/SLING-7492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomasz updated SLING-7492: -- Description: Constructing a fully correct request that implements HttpServletRequest means that it won't have an attribute of SlingRequestProgressTracker. There is no chance to instantiate it. When developer invokes method processRequest from SlingRequestProcessor using mentioned, created request it writes lots of warnings in logs. That's because constructor of org.apache.sling.engine.impl.request.RequestData contains given lines: Object o = request.getAttribute(RequestProgressTracker.class.getName()); if(o instanceof SlingRequestProgressTracker) { this.requestProgressTracker = (SlingRequestProgressTracker)o; } else { this.log.warn("SlingRequestProgressTracker not found in request attributes"); this.requestProgressTracker = new SlingRequestProgressTracker(request); } Steps to reproduce: # Create new class, let's call it MockRequest, that implements HttpServletRequest. # Create an object of MockRequest. # Instantiate or inject an object of SlingRequestProcessor. # On SlingRequestProcessor object invoke method processRequest(), where, as a request parameter, provide a MockRequest object. # Check logs. You will see lot's of warnings like given one: 26.01.2018 01:25:48.607 *WARN* [pool-331-thread-3] org.apache.sling.engine.impl.request.RequestData SlingRequestProgressTracker not found in request attributes Expected: warnings does not appear in logs or there is a way to avoid them. was: Constructing a fully correct request that implements HttpServletRequest means that it won't have an attribute of SlingRequestProgressTracker. There is no chance to instantiate it. When developer invokes method processRequest from SlingRequestProcessor using mentioned, created request it writes lots of warnings in logs. That's because constructor of org.apache.sling.engine.impl.request.RequestData contains given lines: Object o = request.getAttribute(RequestProgressTracker.class.getName()); if(o instanceof SlingRequestProgressTracker) { this.requestProgressTracker = (SlingRequestProgressTracker)o; } else { this.log.warn("SlingRequestProgressTracker not found in request attributes"); this.requestProgressTracker = new SlingRequestProgressTracker(request); } Steps to reproduce: # Create new class, let's call it MockRequest, that implements HttpServletRequest. # Create an object of MockRequest. # Instantiate or inject an object of SlingRequestProcessor. # On SlingRequestProcessor object invoke method processRequest(), where, as a request parameter, provide a MockRequest object. # Check logs. You will see lot's of warnings like given one: 26.01.2018 01:25:48.607 *WARN* [pool-331-thread-3] org.apache.sling.engine.impl.request.RequestData SlingRequestProgressTracker not found in request attributes Expected: warnings does not appear in logs or there is a way to avoid such logs. > Lots of logs on missing SlingRequestProgressTracker > --- > > Key: SLING-7492 > URL: https://issues.apache.org/jira/browse/SLING-7492 > Project: Sling > Issue Type: Bug >Affects Versions: Engine 2.6.6 > Environment: Using Adobe Experience Manager >Reporter: Tomasz >Priority: Major > > Constructing a fully correct request that implements HttpServletRequest means > that it won't have an attribute of SlingRequestProgressTracker. There is no > chance to instantiate it. > When developer invokes method processRequest from SlingRequestProcessor > using mentioned, created request it writes lots of warnings in logs. > That's because constructor of > org.apache.sling.engine.impl.request.RequestData contains given lines: > Object o = request.getAttribute(RequestProgressTracker.class.getName()); > if(o instanceof SlingRequestProgressTracker) > { this.requestProgressTracker = (SlingRequestProgressTracker)o; } > else > { this.log.warn("SlingRequestProgressTracker not found in request > attributes"); this.requestProgressTracker = new > SlingRequestProgressTracker(request); } > Steps to reproduce: > # Create new class, let's call it MockRequest, that implements > HttpServletRequest. > # Create an object of MockRequest. > # Instantiate or inject an object of SlingRequestProcessor. > # On SlingRequestProcessor object invoke method processRequest(), where, as > a request parameter, provide a MockRequest object. > # Check logs. You will see lot's of warnings like given one: > 26.01.2018 01:25:48.607 *WARN* [pool-331-thread-3] > org.apache.sling.engine.impl.request.RequestData SlingRequestProgressTracker > not found in request attributes > Expected: warnings does not appear in logs or there is a way to avoid them. -- This message was sent by Atlassi
[jira] [Updated] (SLING-7492) Lots of logs on missing SlingRequestProgressTracker
[ https://issues.apache.org/jira/browse/SLING-7492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomasz updated SLING-7492: -- Description: Constructing a fully correct request that implements HttpServletRequest means that it won't have an attribute of SlingRequestProgressTracker. There is no chance to instantiate it. When developer invokes method processRequest from SlingRequestProcessor using mentioned, created request it writes lots of warnings in logs. That's because constructor of org.apache.sling.engine.impl.request.RequestData contains given lines: Object o = request.getAttribute(RequestProgressTracker.class.getName()); if(o instanceof SlingRequestProgressTracker) { this.requestProgressTracker = (SlingRequestProgressTracker)o; } else { this.log.warn("SlingRequestProgressTracker not found in request attributes"); this.requestProgressTracker = new SlingRequestProgressTracker(request); } Steps to reproduce: # Create new class, let's call it MockRequest, that implements HttpServletRequest. # Create an object of MockRequest. # Instantiate or inject an object of SlingRequestProcessor. # On SlingRequestProcessor object invoke method processRequest(), where, as a request parameter, provide a MockRequest object. # Check logs. You will see lot's of warnings like given one: 26.01.2018 01:25:48.607 *WARN* [pool-331-thread-3] org.apache.sling.engine.impl.request.RequestData SlingRequestProgressTracker not found in request attributes Expected: warnings does not appear in logs or there is a way to avoid such logs. was: Constructing a fully correct request that implements HttpServletRequest means that it won't have an attribute of SlingRequestProgressTracker. There is no chance to instantiate it. When developer invokes method processRequest from SlingRequestProcessor using mentioned, created request it writes lots of warnings in logs. That's because constructor of org.apache.sling.engine.impl.request.RequestData contains given lines: Object o = request.getAttribute(RequestProgressTracker.class.getName()); if(o instanceof SlingRequestProgressTracker) { this.requestProgressTracker = (SlingRequestProgressTracker)o; } else { this.log.warn("SlingRequestProgressTracker not found in request attributes"); this.requestProgressTracker = new SlingRequestProgressTracker(request); } Steps to reproduce: # Create new class, let's call it MockRequest, that implements HttpServletRequest. # Create an object of MockRequest. # Instantiate or inject an object of SlingRequestProcessor. # On SlingRequestProcessor object invoke method processRequest(), where, as a request parameter, provide a MockRequest object. # Check logs. You will see lot's of warnings like given one: 26.01.2018 01:25:48.607 *WARN* [pool-331-thread-3] org.apache.sling.engine.impl.request.RequestData SlingRequestProgressTracker not found in request attributes Expected: warnings does not appear in logs or there is a way to avoid such logs. > Lots of logs on missing SlingRequestProgressTracker > --- > > Key: SLING-7492 > URL: https://issues.apache.org/jira/browse/SLING-7492 > Project: Sling > Issue Type: Bug >Affects Versions: Engine 2.6.6 > Environment: Using Adobe Experience Manager >Reporter: Tomasz >Priority: Major > > Constructing a fully correct request that implements HttpServletRequest means > that it won't have an attribute of SlingRequestProgressTracker. There is no > chance to instantiate it. > When developer invokes method processRequest from SlingRequestProcessor > using mentioned, created request it writes lots of warnings in logs. > That's because constructor of > org.apache.sling.engine.impl.request.RequestData contains given lines: > Object o = request.getAttribute(RequestProgressTracker.class.getName()); > if(o instanceof SlingRequestProgressTracker) { > this.requestProgressTracker = (SlingRequestProgressTracker)o; > } > else { > this.log.warn("SlingRequestProgressTracker not found in request > attributes"); > this.requestProgressTracker = new SlingRequestProgressTracker(request); > } > Steps to reproduce: > # Create new class, let's call it MockRequest, that implements > HttpServletRequest. > # Create an object of MockRequest. > # Instantiate or inject an object of SlingRequestProcessor. > # On SlingRequestProcessor object invoke method processRequest(), where, as > a request parameter, provide a MockRequest object. > # Check logs. You will see lot's of warnings like given one: > 26.01.2018 01:25:48.607 *WARN* [pool-331-thread-3] > org.apache.sling.engine.impl.request.RequestData SlingRequestProgressTracker > not found in request attributes > Expected: warnings does not appear in logs or there is a way to avoid such > logs. -- This message was sent by A
[jira] [Created] (SLING-7492) Lots of logs on missing SlingRequestProgressTracker
Tomasz created SLING-7492: - Summary: Lots of logs on missing SlingRequestProgressTracker Key: SLING-7492 URL: https://issues.apache.org/jira/browse/SLING-7492 Project: Sling Issue Type: Bug Affects Versions: Engine 2.6.6 Environment: Using Adobe Experience Manager Reporter: Tomasz Constructing a fully correct request that implements HttpServletRequest means that it won't have an attribute of SlingRequestProgressTracker. There is no chance to instantiate it. When developer invokes method processRequest from SlingRequestProcessor using mentioned, created request it writes lots of warnings in logs. That's because constructor of org.apache.sling.engine.impl.request.RequestData contains given lines: Object o = request.getAttribute(RequestProgressTracker.class.getName()); if(o instanceof SlingRequestProgressTracker) { this.requestProgressTracker = (SlingRequestProgressTracker)o; } else { this.log.warn("SlingRequestProgressTracker not found in request attributes"); this.requestProgressTracker = new SlingRequestProgressTracker(request); } Steps to reproduce: # Create new class, let's call it MockRequest, that implements HttpServletRequest. # Create an object of MockRequest. # Instantiate or inject an object of SlingRequestProcessor. # On SlingRequestProcessor object invoke method processRequest(), where, as a request parameter, provide a MockRequest object. # Check logs. You will see lot's of warnings like given one: 26.01.2018 01:25:48.607 *WARN* [pool-331-thread-3] org.apache.sling.engine.impl.request.RequestData SlingRequestProgressTracker not found in request attributes Expected: warnings does not appear in logs or there is a way to avoid such logs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)