[Bug 481530] Review Request: perl-Fedora-Bugzilla - Access Fedora's Bugzilla

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481530


Chris Weyl  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #5 from Chris Weyl   2009-01-29 02:45:54 EDT 
---
Thanks for the review! :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482985] Renaming review: gentium-fonts to sil-gentium-fonts

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482985


Roozbeh Pournader  changed:

   What|Removed |Added

 Blocks|477335  |477337




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482985] New: Renaming review: gentium-fonts to sil-gentium-fonts

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Renaming review: gentium-fonts to sil-gentium-fonts

https://bugzilla.redhat.com/show_bug.cgi?id=482985

   Summary: Renaming review: gentium-fonts to sil-gentium-fonts
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: rooz...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com,
fedora-fonts-bugs-l...@redhat.com
Depends on: 176096
Blocks: 477335
   Estimated Hours: 0.0
Classification: Fedora
  Clone Of: 481476


Renaming of gentium-fonts to sil-gentium-fonts to comply with
http://fedoraproject.org/wiki/Packaging:FontsPolicy#Naming

New package:
http://roozbeh.fedorapeople.org/sil-gentium-fonts.spec
http://roozbeh.fedorapeople.org/sil-gentium-fonts-1.02-7.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176096] Review Request: gentium-fonts: SIL Gentium fonts

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=176096


Roozbeh Pournader  changed:

   What|Removed |Added

 Blocks||482985




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476471] Review Request: fedora-security-guide - A security guide for Linux

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476471





--- Comment #41 from Jens Petersen   2009-01-29 02:31:04 
EDT ---
> (In reply to comment #39)
> I can hard code the htmlview only but it would most likely break functionality
> in Publican later.  Is this a hard requirement?  It doesn't appear to hurt the
> package as it is an if statement.

You mean the conditional stuff - yeah we can probably live with that if we are
proceeding with pure publican generated spec files.

But htmlview vs xdg-utils stuff should be fully conditionalized not partly like
now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456527] Review Request: sil-gentium-fonts - Gentium Basic Font Family

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456527


Roozbeh Pournader  changed:

   What|Removed |Added

 CC||rooz...@gmail.com




--- Comment #20 from Roozbeh Pournader   2009-01-29 02:30:57 
EDT ---
Please rename the package to sil-gentium-basic-fonts. We already have Gentium,
which will be renamed to sil-gentium-fonts. Updating the CVS request:

New Package CVS Request
===
Package Name: sil-gentium-basic-fonts
Short Description:  Gentium Basic Font Family from SIL
Owners: rbhalera
Branches: devel
InitialCC: fonts-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 466953] Review Request: perl-NOCpulse-Utils - NOCpulse utility packages

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466953





--- Comment #6 from Miroslav Suchy   2009-01-29 02:30:21 EDT 
---
Ough I updated spec, but forgot to update this BZ :(

Updated Spec:
http://miroslav.suchy.cz/fedora/perl-NOCpulse-Utils/perl-NOCpulse-Utils.spec
Update SRPM:
http://miroslav.suchy.cz/fedora/perl-NOCpulse-Utils/perl-NOCpulse-Utils-1.14.11-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 466906] Review Request: perl-NOCpulse-SetID - Provides api for correctly changing user identity

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466906


Miroslav Suchy  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #5 from Miroslav Suchy   2009-01-29 02:18:48 EDT 
---
New Package CVS Request
===
Package Name: perl-NOCpulse-SetID
Short Description: Provides api for correctly changing user identity
Owners: msuchy
Branches: devel F-10 EL-4 EL-5
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482856


Parag AN(पराग)  changed:

   What|Removed |Added

   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222


Fabian Affolter  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #6 from Fabian Affolter   2009-01-29 
01:55:46 EDT ---
Lucian, thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222





--- Comment #7 from Fabian Affolter   2009-01-29 
01:56:23 EDT ---
New Package CVS Request
===
Package Name: nullmodem
Short Description: A utility to loopback pseudo-terminals
Owners: fab
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457955] Review Request: cf-bonveno-fonts - BonvenoCF font

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457955


Jens Petersen  changed:

   What|Removed |Added

 CC||peter...@redhat.com
Summary|Review Request: |Review Request:
   |bonvenocf-fonts - BonvenoCF |cf-bonveno-fonts -
   |font|BonvenoCF font
  Alias|bonvenocf-fonts |cf-bonveno-fonts




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457947] Review Request: oldstandard-sfd-fonts - Old Standard Fonts

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457947


Jens Petersen  changed:

   What|Removed |Added

 Blocks|177841  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482856





--- Comment #5 from Parag AN(पराग)   2009-01-29 01:09:24 
EDT ---
If you are not knowing about cpanspec usage then look at
https://fedoraproject.org/wiki/Perl/cpanspec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482863] Review Request: perl-MooseX-Daemonize - Role for daemonizing your Moose based application

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482863


Parag AN(पराग)  changed:

   What|Removed |Added

   Flag|fedora-review+  |fedora-review?




--- Comment #3 from Parag AN(पराग)   2009-01-29 00:48:37 
EDT ---
Can you please resubmit this package using cpanspec created SPEC file?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482856


Ralf Corsepius  changed:

   What|Removed |Added

 CC||rc040...@freenet.de
   Flag|fedora-review+  |




--- Comment #4 from Ralf Corsepius   2009-01-29 00:42:23 
EDT ---
Revoking approval - This spec file needs to be brushed up.

Issues:
- Clean up the spec file from remnants of cpanspec's template.

- I consider BR:perl-MooseX-Daemonize to be a must.

- %doc is empty. Add at least "Changes" to it.

- This is a noarch package. Remove OPTIMIZE from %build

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482863] Review Request: perl-MooseX-Daemonize - Role for daemonizing your Moose based application

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482863





--- Comment #2 from Parag AN(पराग)   2009-01-29 00:39:37 
EDT ---
Also, make sure to remove OPTIMIZE="$RPM_OPT_FLAGS" from %build as its not
needed for this noarch kind of package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222


Lucian Langa  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #5 from Lucian Langa   2009-01-29 00:39:06 EDT 
---
Looking good.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482856





--- Comment #3 from Parag AN(पराग)   2009-01-29 00:39:35 
EDT ---
Also, make sure to remove OPTIMIZE="$RPM_OPT_FLAGS" from %build as its not
needed for this noarch kind of package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480727





--- Comment #32 from _pjp_   2009-01-29 00:29:54 EDT ---
> seems better now, but I have a question?
> how you will start djbdns?

  Well, for now will have to run it manually. I'm working on making it usable
with the existing /etc/init.d and /sbin/service framework, as that'll be more
intuitive and seamless I guess.

> using something like /service directory ? 
> 
> 3 - should be good to have a svscanboot [UPS] running with upstart, Mamoru is
> the best person to answer about what directory, because /service should not be
> used, may be somthing like /var/run/daemontools?

  I haven't looked at it, but surely would explore about it as well.

So, can I consider daemontools to be approved? May be, I can work on packaging
djbdns now.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965





--- Comment #4 from Parag AN(पराग)   2009-01-29 00:30:13 
EDT ---
(In reply to comment #3)
> Still some issues:
> 
> * The t/DOM.t test fails due to a missing XML::DOM
> => Please add
> BuildRequires: perl(XML::DOM)
> This should let the testsuite succeed.
> 
> * This is a noarch package.
> => No need to pass OPTIMIZE in %build
> Please remove OPTIMIZE.

Thanks for this comment. I thought its ok not to care much for noarch packages.
Thanks will take care to ask to remove OPTIMIZE for perl noarch packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482963] Review Request: perl-Network-IPv4Addr - Network-IPv4Addr Perl module

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482963





--- Comment #5 from Parag AN(पराग)   2009-01-29 00:31:14 
EDT ---
please remove OPTIMIZE="$RPM_OPT_FLAGS" from %build as this is noarch package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 466906] Review Request: perl-NOCpulse-SetID - Provides api for correctly changing user identity

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466906


Dennis Gilmore  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #4 from Dennis Gilmore   2009-01-29 00:25:59 EDT 
---
sorry for dropping the ball on this.

Builds in mock
source matches upstream.
rpmlint is silent.
sane Requires/Provides

approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Ralf Corsepius  changed:

   What|Removed |Added

 CC||rc040...@freenet.de




--- Comment #3 from Ralf Corsepius   2009-01-29 00:17:37 
EDT ---
Still some issues:

* The t/DOM.t test fails due to a missing XML::DOM
=> Please add
BuildRequires: perl(XML::DOM)
This should let the testsuite succeed.

* This is a noarch package.
=> No need to pass OPTIMIZE in %build
Please remove OPTIMIZE.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482863] Review Request: perl-MooseX-Daemonize - Role for daemonizing your Moose based application

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482863


Parag AN(पराग)  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #1 from Parag AN(पराग)   2009-01-29 00:13:02 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1090309
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
24ff349f0e2e09ca89e8ecbc73b0dc65  MooseX-Daemonize-0.08.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave 
All tests successful.
Files=9, Tests=82, 18 wallclock secs ( 0.06 usr  0.02 sys +  3.84 cusr  0.25
csys =  4.17 CPU)
+ Package perl-MooseX-Daemonize-0.08-1.fc11 =>
  Provides: perl(MooseX::Daemonize) = 0.08 perl(MooseX::Daemonize::Core) = 0.01
perl(MooseX::Daemonize::Pid) = 0.01 perl(MooseX::Daemonize::Pid::File) = 0.01
perl(MooseX::Daemonize::WithPidFile) = 0.01 perl(Test::MooseX::Daemonize) =
0.03 perl(Test::MooseX::Daemonize::Testable)
Requires: perl(Moose) perl(Moose::Role) perl(Moose::Util::TypeConstraints)
perl(MooseX::Daemonize::Pid::File) perl(MooseX::Getopt)
perl(MooseX::Getopt::OptionTypeMap) perl(MooseX::Types::Path::Class)
perl(POSIX) perl(Sub::Exporter) perl(Test::Builder) perl(strict)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480727





--- Comment #31 from _pjp_   2009-01-29 00:07:10 EDT ---
> the package maintaner need's to fix the bugs :-)

  Right I know, I could be an upstream for this and djbdns as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476471] Review Request: fedora-security-guide - A security guide for Linux

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476471


Bug 476471 depends on bug 482968, which changed state.

Bug 482968 Summary: Source0 missing from SPEC file
https://bugzilla.redhat.com/show_bug.cgi?id=482968

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480727


_pjp_  changed:

   What|Removed |Added

 Blocks|182235  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482963] Review Request: perl-Network-IPv4Addr - Network-IPv4Addr Perl module

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482963


Dennis Gilmore  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #2 from Dennis Gilmore   2009-01-29 00:02:31 EDT 
---
Thanks for the review

New Package CVS Request
===
Package Name: perl-Network-IPv4Addr
Short Description: Network-IPv4Addr Perl module
Owners: dgilmore
Branches: F-9 EL-5 F-10
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482856


Parag AN(पराग)  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #1 from Parag AN(पराग)   2009-01-29 00:02:09 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1090311
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7878a0155d9f2c582e14696c2115867e  MooseX-POE-0.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave 
All tests successful.
Files=7, Tests=185,  3 wallclock secs ( 0.05 usr  0.01 sys +  3.09 cusr  0.19
csys =  3.34 CPU)
+ Package  perl-MooseX-POE-0.1-1.fc11 =>
Provides: perl(MooseX::POE) = 0.100 perl(MooseX::POE::Aliased)
perl(MooseX::POE::Exporter) perl(MooseX::POE::Meta::Class)
perl(MooseX::POE::Meta::Class::Trait) perl(MooseX::POE::Meta::Instance)
perl(MooseX::POE::Meta::Role) perl(MooseX::POE::Meta::Trait)
perl(MooseX::POE::Object) = 0.050 perl(MooseX::POE::Object::Deferred)
perl(MooseX::POE::Role) perl(MooseX::POE::SweetArgs) perl(ooseX::POE) = 0.01
Requires: perl(B) perl(Filter::Simple) perl(Moose) perl(Moose::Exporter)
perl(Moose::Role) perl(MooseX::POE::Exporter) perl(MooseX::POE::Meta::Class)
perl(MooseX::POE::Meta::Role) perl(MooseX::POE::Object) perl(MooseX::POE::Role)
perl(POE) perl(Scalar::Util) perl(Sub::Exporter) perl(Sub::Name)
perl(metaclass) perl(overload) perl(strict) perl(warnings)

Suggestions:-
1) you can add BR:perl-MooseX-Daemonize to enable one more test.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482963] Review Request: perl-Network-IPv4Addr - Network-IPv4Addr Perl module

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482963





--- Comment #4 from Dennis Gilmore   2009-01-29 00:03:26 EDT 
---
New Package CVS Request
===
Package Name: perl-Network-IPv4Addr
Short Description: Network-IPv4Addr Perl module
Owners: ausil
Branches: F-9 EL-5 F-10
InitialCC: perl-sig

use the right account name.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482856





--- Comment #2 from Parag AN(पराग)   2009-01-29 00:06:36 
EDT ---
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482963] Review Request: perl-Network-IPv4Addr - Network-IPv4Addr Perl module

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482963


Dennis Gilmore  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #3 from Dennis Gilmore   2009-01-29 00:02:51 EDT 
---
CVS Done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476471] Review Request: fedora-security-guide - A security guide for Linux

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476471


Bug 476471 depends on bug 482972, which changed state.

Bug 482972 Summary: .desktop file not created
https://bugzilla.redhat.com/show_bug.cgi?id=482972

   What|Old Value   |New Value

 Status|NEW |CLOSED
 Resolution||WONTFIX



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Dennis Gilmore  changed:

   What|Removed |Added

 CC||dgilm...@redhat.com




--- Comment #2 from Dennis Gilmore   2009-01-28 23:39:55 
EDT ---
I honestly do not know why DOM.pm is removed. i picked up the spec from
spacewalk and cleaned it up.  lets add it back.

Spec URL: http://ausil.us/packages/perl-XML-Generator.spec
SRPM URL: http://ausil.us/packages/perl-XML-Generator-1.01-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476471] Review Request: fedora-security-guide - A security guide for Linux

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476471


Eric Christensen  changed:

   What|Removed |Added

 Depends on||482972




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476471] Review Request: fedora-security-guide - A security guide for Linux

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476471





--- Comment #40 from Eric Christensen   2009-01-28 
22:55:45 EDT ---
(In reply to comment #38)
I have filed a bug against Publican for the Source0 entry (482968).  I cannot
hard code this in as I previously though.

Am also trying to figure out how to populate the .desktop file with the proper
options as I know it shows up on the computer with the proper icons and such. 
Will file a bug if I can't figure it out.


(In reply to comment #39)
I can hard code the htmlview only but it would most likely break functionality
in Publican later.  Is this a hard requirement?  It doesn't appear to hurt the
package as it is an if statement.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482963] Review Request: perl-Network-IPv4Addr - Network-IPv4Addr Perl module

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482963


Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+




--- Comment #1 from Parag AN(पराग)   2009-01-28 22:45:15 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1090313
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
1c4a9278ada5557a4895ee44b0312888  Network-IPv4Addr-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok
+ Package perl-Network-IPv4Addr-0.05-12.fc11 =>
  Provides: perl(Network::IPv4Addr) = 0.05
  Requires: /usr/bin/perl perl(AutoLoader) perl(Carp) perl(Exporter)
perl(Getopt::Long) perl(Network::IPv4Addr) perl(strict) perl(vars)

Suggestions:
1) Use complete source url as
http://search.cpan.org/CPAN/authors/id/F/FR/FRAJULAC/Network-IPv4Addr-0.05.tar.gz


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




--- Comment #1 from Parag AN(पराग)   2009-01-28 22:38:13 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1090315
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8f9e6ba2595b07997efac1377c5484e9  XML-Generator-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=97,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.09 cusr  0.02
csys =  0.15 CPU)
+ Package perl-XML-Generator-1.01-1.fc11 =>
  Provides:  perl(XML::Generator) = 1.01 perl(XML::Generator::cdata)
perl(XML::Generator::comment) perl(XML::Generator::final)
perl(XML::Generator::overload) perl(XML::Generator::pi)
perl(XML::Generator::pretty) perl(XML::Generator::util)
 Requires: perl(Carp) perl(base) perl(constant) perl(overload) perl(strict)
perl(vars)

Any reason for removing DOM.pm?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476471] Review Request: fedora-security-guide - A security guide for Linux

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476471


Eric Christensen  changed:

   What|Removed |Added

 Depends on||482968




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481411] Review Request: perl-Test-Email - Test email contents

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481411


Ralf Corsepius  changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481594


Michael Stahnke  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #8 from Michael Stahnke   2009-01-28 22:05:26 
EDT ---
New Package CVS Request
===
Package Name: python-pygooglechart
Short Description: A complete Python wrapper for the Google Chart API
Owners: stahnma
Branches: F9, F10, EL4, EL5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482965] New: Review Request: perl-XML-Generator - perl XML generator

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-XML-Generator - perl XML generator

https://bugzilla.redhat.com/show_bug.cgi?id=482965

   Summary: Review Request: perl-XML-Generator - perl XML
generator
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: den...@ausil.us
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://ausil.us/packages/perl-XML-Generator.spec
SRPM URL: http://ausil.us/packages/perl-XML-Generator-1.01-1.fc10.src.rpm
Description: 
perl module for generating XML documents

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482963] New: Review Request: perl-Network-IPv4Addr - Network-IPv4Addr Perl module

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Network-IPv4Addr - Network-IPv4Addr Perl module

https://bugzilla.redhat.com/show_bug.cgi?id=482963

   Summary: Review Request: perl-Network-IPv4Addr -
Network-IPv4Addr Perl module
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: den...@ausil.us
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://ausil.us/packages/perl-Network-IPv4Addr.spec
SRPM URL: http://ausil.us/packages/perl-Network-IPv4Addr-0.05-12.fc10.src.rpm
Description: 
Network::IPv4Addr provides functions for parsing IPv4 addresses both
in traditional address/netmask format and in the new CIDR format.
There are also methods for calculating the network and broadcast
address and also to see check if a given address is in a specific
network.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478759] Review Request: perl-SystemPerl - SystemPerl Perl module

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478759


wsny...@wsnyder.org changed:

   What|Removed |Added

 CC||wsny...@wsnyder.org

Bug 478759 depends on bug 476386, which changed state.

Bug 476386 Summary: Review Request: perl-verilog  - Verilog parsing routines
https://bugzilla.redhat.com/show_bug.cgi?id=476386

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE



--- Comment #5 from wsny...@wsnyder.org  2009-01-28 20:38:08 EDT ---
Chitlesh notified me of this thread.

The src/ prefix is because many users have multiple versions of SystemPerl
installed (generally in a repository) and just point to the one they want.

Lane has a the right solution for the present version, as makefiles etc
also have the src/ path hardcoded.  If there's a strong objection to the
extra src/ in the path, I can add a new envvariable that will set the location.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468516


wsny...@wsnyder.org changed:

   What|Removed |Added

 CC||wsny...@wsnyder.org




--- Comment #28 from wsny...@wsnyder.org  2009-01-28 20:40:55 EDT ---
Chitlesh notified me of this thread.

The src/ prefix is because many users have multiple versions of SystemPerl
installed (generally in a repository) and just point to the one they want.

Lane has a the right solution for the present version, as makefiles etc
also have the src/ path hardcoded.  If there's a strong objection to the
extra src/ in the path, I can add a new envvariable that will set the location.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482863] Review Request: perl-MooseX-Daemonize - Role for daemonizing your Moose based application

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482863


Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482856


Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480727





--- Comment #30 from Itamar Reis Peixoto   2009-01-28 
20:14:13 EDT ---
(In reply to comment #28)
>Hi, I've made the changes. Please have a look at the following

seems better now, but I have a question ?

how you will start djbdns ?

using something like /service directory ? 

3 - should be good to have a svscanboot [UPS] running with upstart, Mamoru is
the best person to answer about what directory, because /service should not be
used, may be somthing like /var/run/daemontools  ?


UPS ->
https://bugs.launchpad.net/ubuntu/+source/daemontools-installer/+bug/66615

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480727





--- Comment #29 from Itamar Reis Peixoto   2009-01-28 
20:11:01 EDT ---
> * I can't spot any license (I am not sure, but haven't there been some legal
> issues with DJB's works?). Blocking FE-LEGAL.

you can remove FE-LEGAL

http://www.redhat.com/archives/fedora-legal-list/2007-November/msg00023.html


> Finally: Does this package still have an active upstream? 
> I thought, DJB discontinued all his works.

the package maintaner need's to fix the bugs :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 464045] Review Request: sreadahead - Super Read Ahead

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464045


Kyle McMartin  changed:

   What|Removed |Added

 CC||kmcmar...@redhat.com




--- Comment #10 from Kyle McMartin   2009-01-28 19:56:55 
EDT ---
http://kyle.fedorapeople.org/sreadahead/
|`- http://kyle.fedorapeople.org/sreadahead/sreadahead.spec
`-- http://kyle.fedorapeople.org/sreadahead/sreadahead-1.0-1.fc10.src.rpm

Please let me know if I made a hash of the specfile. I'd like us to get this
and the hooks for it into F11.

I'm not willing to merge the patch for the open tracing yet, as we would
effectively be "guaranteeing" a userspace interface (not that debugfs really
provides these assurances.) and I'd like to wait and see what actually gets
merged upstream...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474980] Review Request: ovm - Open Verification Methodology : IEEE 1800 SystemVerilog standard

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474980





--- Comment #17 from manuel wolfshant   2009-01-28 
19:54:40 EDT ---
Unfortunately I cannot attend FESCo's IRC meetings due to overlapping with
personal matters, but I must stand on Chitlesh's side here (ref #14 )) and
support him.

I for one would have loved to use a rpm for OVM at the time that I deployed the
software in the company I work for (see #3). And no, except for a few minor
tools, the game around real EDA has no open-source players, all big boys use
products from one of the three major players in the market. Stalling even the
few available open source packages because in this moment there is no free tool
to use them is just an administrative block and with no support in any of the
guidelines I know of.

Note that this is the exact opposite case of games with free engines but
encumbered game data (which was downloaded at install time from links outside
our repos): this time we have free content but no free engine to use it with.
Pushing the content _might_ speed up the engine and harm no one; on the
contrary we would once again be the leader of the movement. No content at all
will definitely not help anyone.  It's like saying "Look, we have free oranges
! Take as many as you want !" but you reply "No, I will not eat your oranges
unless someone provides a free knife for peeling them, too !" Or in a geeky
speak, "Here, have some free beer !" "No, thank you, I cannot accept it, I have
no free bottle opener!"


And for what it's worth: 10 days ago I had the opportunity to attend a meeting
with a manager working for one of the top 3 EDA tools manufacturers mentioned
above. It just happened that his next meeting scheduled during that week was
with the other players of the OVM game, in view of releasing OVM 2.1. In other
words, there is a real incentive over this project.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482884] Review Request: CLC-INTERCAL - Compiler for the INTERCAL language

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482884


Iain Arnell  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |CLC-INTERCAL - Compiler |CLC-INTERCAL - Compiler for
   |Language With No|the INTERCAL language
   |Pronounceable Acronym   |




--- Comment #2 from Iain Arnell   2009-01-28 19:40:14 EDT ---
Answer: No, I already maintain several other perl packages. No sponsor
required.


1. Okay, description was a little weak. New text ripped from Debian package:

Summary: Compiler for the INTERCAL language

Description:
This package provides a Perl-based compiler for the INTERCAL programming
language, usable either from the command line or as a Perl module.

CLC-INTERCAL is designed to be almost compatible with the original (Princeton
1972) compiler. It also implements several extensions to the original language,
including support for object orientation, operator overloading and quantum
computing. 


2. Indeed. But RPM can't cope with hyphens in version numbers (and even if it
could, it probably wouldn't realise that 1.-94.-2 is a higher version number
than 1.-94.-3). It seemed appropriate for INTERCAL to seek a particularly
obtuse solution, but on second thought...

Since it's not yet a 1.0 release, how about Version: 0 and Release:
0.%{X}.1._94._2 (as a non-numeric pre-release tag).


3. %{summary} comment is moot if I stick the proper version into release tag;
the offending sub-package is no longer necessary. 

Only Group: %{group} remains in UI-X sub-package. 


New Spec: http://iarnell.fedorapeople.org/rpms/CLC-INTERCAL.spec
New SRPM:
http://iarnell.fedorapeople.org/rpms/CLC-INTERCAL-0-0.0.1._94._2.fc11.src.rpm
New Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1090063

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457947] Review Request: oldstandard-sfd-fonts - Old Standard Fonts

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457947


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #36 from Kevin Fenzi   2009-01-28 19:35:19 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457955] Review Request: bonvenocf-fonts - BonvenoCF font

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457955


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #27 from Kevin Fenzi   2009-01-28 19:32:47 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457947] Review Request: oldstandard-sfd-fonts - Old Standard Fonts

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457947


Ankur Sinha  changed:

   What|Removed |Added

 CC||sanjay.an...@gmail.com
   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474864] Review Request: perl-Test-Signature - Automated SIGNATURE testing

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474864


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #12 from Kevin Fenzi   2009-01-28 19:28:41 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478749] Review Request: dinotrace - X11 waveform viewer for electronics

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478749





--- Comment #6 from manuel wolfshant   2009-01-28 
19:30:46 EDT ---
Chitlesh, you could use the following construction:

desktop-file-install \
%if 0%{?rhel}
 --vendor "" \
%endif
--dir %{buildroot}%{_datadir}/applications \
%{name}.desktop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474980] Review Request: ovm - Open Verification Methodology : IEEE 1800 SystemVerilog standard

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474980





--- Comment #16 from Kevin Fenzi   2009-01-28 19:30:41 EDT ---
Well, you are welcome to bring it up again to FESCo, but the decision made last
time was that something that could at least potentially use the content should
be added at the same time as this content package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476758] Review Request: libspiro - Library to simplify the drawing of beautiful curves

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476758


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #7 from Kevin Fenzi   2009-01-28 19:27:52 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457955] Review Request: bonvenocf-fonts - BonvenoCF font

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457955


Ankur Sinha  changed:

   What|Removed |Added

 CC||sanjay.an...@gmail.com
 AssignedTo|ankursi...@fedoraproject.or |sanjay.an...@gmail.com
   |g   |
   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467376] Review Request: mingw32-pixman - MinGW Windows Pixman library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467376


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #12 from Kevin Fenzi   2009-01-28 19:22:20 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=442233


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |




--- Comment #13 from Kevin Fenzi   2009-01-28 19:25:05 EDT ---
Please add a cvs template here so we know what branches you want, etc. 
Reset the fedora-cvs flag when thats ready.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220789] Review Request: fail2ban - Ban IPs that make too many password failures

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=220789


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #12 from Kevin Fenzi   2009-01-28 19:26:20 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564





--- Comment #16 from Itamar Reis Peixoto   2009-01-28 
19:24:59 EDT ---
> Final point: I am intending to only import this on the EL-5 branch so if 
> anyone
> wants to co-maintain in devel/F-10/F-9 then let me know.

Can I do this ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481528


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #9 from Kevin Fenzi   2009-01-28 19:21:28 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478603] Review Request: pysnmp - SNMP engine written in Python

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478603


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #6 from Kevin Fenzi   2009-01-28 19:20:19 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 464013] Review Request: findbugs-bcel - Byte Code Engineering Library with findbugs extensions

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464013


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #15 from Kevin Fenzi   2009-01-28 19:18:38 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481508] Review Request: pipviewer - Visualizer for multiple alignments of genomic sequences

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481508


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Kevin Fenzi   2009-01-28 19:19:29 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481322] Review Request: emacs-magit - Emacs interface to the most common Git operations

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481322


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #6 from Kevin Fenzi   2009-01-28 19:14:10 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481141] Review Request: pycryptsetup - Python bindings for cryptsetup tool

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481141


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #8 from Kevin Fenzi   2009-01-28 19:15:08 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 433678] Review Request: ricci - cluster and systems management agent

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=433678





--- Comment #15 from Kevin Kofler   2009-01-28 19:12:04 
EDT ---
Isn't stuff in %{_docdir} automatically marked %doc by RPM? The other
complaints do sound valid though.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #15 from Kevin Fenzi   2009-01-28 19:13:02 EDT ---
Note: the devel branch is always created. 

If you really don't want to maintain this in non EL-5 branches, you might post
to the devel list asking if anyone else would like to?

cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481389] Review Request: beesu - Beesu is a wrapper around su

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481389





--- Comment #5 from manuel wolfshant   2009-01-28 
19:14:19 EDT ---
bee: for the beginning, a real name might help. Second, you can do pre-reviews
in order to prove your packaging skills. See
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored#Sponsorship_model

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467401] Review Request: mingw32-libjpeg - MinGW Windows Libjpeg library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467401


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #10 from Kevin Fenzi   2009-01-28 19:08:44 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478447] Review Request: qtgpsc - A client for the gpsd GPS server

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478447


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Kevin Fenzi   2009-01-28 19:09:37 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222





--- Comment #4 from Fabian Affolter   2009-01-28 
18:37:31 EDT ---
License tag changed.

Updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/nullmodem.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/nullmodem-0.0.5-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 433678] Review Request: ricci - cluster and systems management agent

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=433678


Robert Scheck  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 433678] Review Request: ricci - cluster and systems management agent

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=433678


Robert Scheck  changed:

   What|Removed |Added

   Keywords||Reopened
 Status|CLOSED  |ASSIGNED
 CC||redhat-bugzi...@linuxnetz.d
   ||e
 Resolution|RAWHIDE |




--- Comment #14 from Robert Scheck   2009-01-28 18:34:49 
EDT ---
Re-opening because of fedora-review-.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 433678] Review Request: ricci - cluster and systems management agent

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=433678


Andreas Thienemann  changed:

   What|Removed |Added

   Flag|fedora-review+  |fedora-review-




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 433678] Review Request: ricci - cluster and systems management agent

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=433678


Andreas Thienemann  changed:

   What|Removed |Added

 CC||andr...@bawue.net




--- Comment #13 from Andreas Thienemann   2009-01-28 
18:28:32 EDT ---
Not to rain on the parade here, but this bug was just mentioned in a discussion
about package quality.
This package review is basically a joke.

Just posting rpmlint results is not enough: The review guidelines clearly
define several items of which only one is mentioned in the review.
A short look at the spec file makes me wonder if anything else then a cursory
rpmlint and mock run was attempted.

While it might be debateable if the .spec file is actually legible but the
missing source url is a clear blocker:

"MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the  Source URL
Guidelines for how to deal with this."

What about the duplicate Summary line?
What about duplicate Requires? What about unneeded Requires?
Why is the main %description tag talking about Conga and a second %description
tag with a name override of "ricci" (identical to the %name tag) talking about
the real program?

What happened to the %files section? Why is the directory
%{_docdir}/ricci-%{version}/ included as regular files instead of being marked
as docs? Why isn't the %doc macro used?

After taking a closer look at the .spec file I have to revise my initial
verdict: This is not only a glaring example of a major failure of our review
process, the entire .spec file is made out of fail.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482951] New: Review Request: sugar-playgo - Go for Sugar

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: sugar-playgo - Go for Sugar

https://bugzilla.redhat.com/show_bug.cgi?id=482951

   Summary: Review Request: sugar-playgo - Go for Sugar
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: fab...@bernewireless.net
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-playgo.spec
SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-playgo-5-1.fc10.src.rpm

Project URL: http://wiki.laptop.org/go/PlayGo

Description:
The PlayGo activity implements Go a strategic board game for two players. Go 
originated in ancient China, centuries before its earliest known references
in 5th century BC writing. It is mostly popular in East Asia but has nowadays
gained some popularity in the rest of the world as well. Go is noted for being
rich in strategic complexity despite its simple rules. 

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1089922

rpmlint output:
[...@laptop24 noarch]$ rpmlint sugar-playgo-5-1.fc10.noarch.rpm 
sugar-playgo.noarch: W: non-standard-group Sugar/Activities
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[...@laptop24 SRPMS]$ rpmlint sugar-playgo-5-1.fc10.src.rpm 
sugar-playgo.src: W: non-standard-group Sugar/Activities
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480249] Review Request: unalz - Decompression utility

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480249


Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235  |




--- Comment #2 from Tom "spot" Callaway   2009-01-28 
17:13:44 EDT ---
ALZ is either a hacked up bzip2 or DEFLATE, depending on the version of ALZip
used to create the file. There are no patent concerns here. Lifting FE-Legal.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482902] Review Request: gsh - aggregate several remote shells into one

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482902





--- Comment #2 from Adam Miller   2009-01-28 17:10:40 
EDT ---
Spec URL: http://maxamillion.fedorapeople.org/gsh.spec
SRPM URL: http://maxamillion.fedorapeople.org/gsh-0.3-2.src.rpm


%changelog
* Wed Jan 28 2009 Adam Miller  - 0.3-2
- Fixed rpmlint complaint, removed egg in setup, redownloaded source


I am not entirely sure what was meant by python SPECE templates as I didn't see
any mention of those on the wiki page for python packages, but I did change up
the spec in ways that I saw I was lacking in compliance with the docs. Looking
forward to further review and suggestions. Thank you for your time.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456527] Review Request: sil-gentium-fonts - Gentium Basic Font Family

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456527





--- Comment #19 from Nicolas Mailhot   2009-01-28 
16:48:57 EDT ---
oops; probably want to have the srpm named sil-gentium-basic-fonts since we
already have a gentium-fonts package that will eventually be renamed 
sil-gentium-fonts

(missed this, sorry, too much stuff to review and too little time)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482827] Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482827





--- Comment #8 from David Nielsen   2009-01-28 16:47:34 
EDT ---
Okay I think this is correct

Spec URL: http://dnielsen.fedorapeople.org/banshee-mirage.spec
SRPM URL:
http://dnielsen.fedorapeople.org/banshee-mirage-0.4.0-4.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482827] Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482827





--- Comment #7 from Jochen Schmitt   2009-01-28 
16:32:20 EDT ---
Good:
+ Panckage name fits packaging guidelines
+ Consistent usage of rpm macros
+ Package contains parallel build
+ Koji build works fine

Bad:
- Please strip files with thw strip command
- so filesname issue still occurs (No blocker for me)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083





--- Comment #49 from Matthias Clasen   2009-01-28 16:26:20 
EDT ---
If you clean up these things, I'll start a formal review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482827] Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482827





--- Comment #6 from David Nielsen   2009-01-28 16:15:49 
EDT ---
While I believe the rename is nonsensical and does not serve our users.

Spec URL: http://dnielsen.fedorapeople.org/banshee-mirage.spec
SRPM URL:
http://dnielsen.fedorapeople.org/banshee-mirage-0.4.0-3.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482827] Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482827





--- Comment #5 from David Nielsen   2009-01-28 16:09:05 
EDT ---
yes but that will not put them into the debug package. Without a way to provide
debug symbols we can't provide upstream with good backtraces which would make
them hate Fedora.. also something about making baby Darwin cry.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482827] Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482827





--- Comment #4 from Jochen Schmitt   2009-01-28 
15:52:10 EDT ---
You may remove the uncessaries symbols with the strip command

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480050] Review Request: libchamplain - Map view for Clutter

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480050





--- Comment #12 from Debarshi Ray   2009-01-28 15:39:45 
EDT ---
(In reply to comment #11)

Spec: http://rishi.fedorapeople.org/libchamplain.spec
SRPM: http://rishi.fedorapeople.org/libchamplain-0.2.8-2.fc9.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1089611

> - fold %dir entries in %files, as suggestde by Jochen
> - maybe fold 3 consecutive %doc lines into 1 ?

Merely personal preferences as I explained earlier (comment #3).

> - devel package gtk-doc Require not necessary (is pulled in by gtk2-devel
> anyways)

That is true, but I had explicitly mentioned it because libchamplain installs
files in directories owned by gtk-doc and it serves as a kind of reminder.

Hope you do not mind. :-)

> - devel package Require on clutter-devel won't be necessary for F-11

Fixed. Could not test this because my Fedora 10 machine broke down, and
libchamplain does not build on Fedora 9.

> Otherwise package looks good. Demo code "launcher.c" won't compile as-is
> because it unnecessarily include "config.h", probably should notify upstream
> about that. If you have time, can you sed out that line from it ?

Fixed. Will notify upstream also.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482827] Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482827





--- Comment #3 from Jochen Schmitt   2009-01-28 
15:39:43 EDT ---
Good:
+ License tag has the right specification GPLv2

Bad:
- Package name don't fits nameing guildlines.
The package is a addon for banshee with the own name of mirage from the
upstream author. So the pacnage name should be banshee-mirage. Please refer to
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28General.29
We are not on Debin/Ubuntu. I know, that they have any packages with other
package names then here on Fedora.
- Mixed use of $RPM_BUILD_ROOT and %{buildroot}
- Removing of the nil statement was a bad idea, because we get now a debuginfo
package which is useless, because the most part of the application is writeen
for the mono plattform.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220789] Review Request: fail2ban - Ban IPs that make too many password failures

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=220789


Adam Miller  changed:

   What|Removed |Added

 CC||maxamill...@gmail.com
   Flag||fedora-cvs?




--- Comment #11 from Adam Miller   2009-01-28 15:29:13 
EDT ---
Package Change Request
==
Package Name: fail2ban
New Branches: EL-4 EL-5
Owners: maxamillion

Fedora owner has been contacted and expressed no interest in EPEL, I would like
to maintain the EPEL package for EL-4 and EL-5

Email citing upstream packagers response to supporting EPEL:


> According to
>
> https://admin.fedoraproject.org/pkgdb/packages/name/fail2ban#Fedora%20EPEL5
> , fail2ban is available.  A yum search fail2ban doesn't show it, however,
> and http://download.fedora.redhat.com/pub/epel/5/i386/repoview/F.group.html
> doesn't show it.  Am I missing something, or is there still a step before it
> goes fully available?  I don't even see it in the testing branch.

This was a bad entry, I am not supporting EPEL. You can get a fail2ban
working on RHEL5/CentOS5 at ATrpms or DAG.
--
Axel.Thimm at ATrpms.net

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564


Tim Jackson  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #14 from Tim Jackson   2009-01-28 15:28:20 EDT ---
New Package CVS Request
===
Package Name: bind-to-tinydns
Short Description: Convert DNS zone files in BIND format to tinydns format
Owners: timj
Branches: EL-5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481034] Review Request: coccinelle - Semantic patching for Linux (spatch)

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481034





--- Comment #12 from Richard W.M. Jones   2009-01-28 
15:28:58 EDT ---
I tried putting the shared library into ${_libdir}/ocaml/stublibs
but that just means that spatch can't find the shared library and
so doesn't start up.  This doesn't appear to be an ordinary use
of the OCaml stublibs (which in ordinary OCaml programs are only
used for bytecode, and the bytecode interpreter does dlopen with
the correct library path).

The *.so.owner files are generated and used by ocamlfind, and are
not an issue here.

So I guess we have to leave the library in %{_libdir}.

In reply to comment 3:
I've corrected the license.  Docs and demos are now in subpackages.

In reply to comment 4:
I got rid of the useless Makefiles and moved the python library.
However I've little idea about the Python code, not even how to test
if it is working.

Spec URL: http://www.annexia.org/tmp/ocaml/coccinelle.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/coccinelle-0.1.4-8.fc11.src.rpm

* Wed Jan 28 2009 Richard W.M. Jones  - 0.1.4-8
- Remove useless Makefiles from python/coccilib.
- License is GPLv2 (not GPLv2+).
- Include documentation and demos in subpackages.
- Move python library to a more sensible path.
- Add a check section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482902] Review Request: gsh - aggregate several remote shells into one

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482902


Jochen Schmitt  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||joc...@herr-schmitt.de
 AssignedTo|nob...@fedoraproject.org|joc...@herr-schmitt.de
   Flag||fedora-review?




--- Comment #1 from Jochen Schmitt   2009-01-28 
15:26:10 EDT ---
Good:
+ Basename of the SPEC files matches with package name
+ BuildRoot tag is ok
+ Could download upstream tar ball with spectool
+ Package contains a License tag
+ License tag contains GPLv2+ as a valid OSS license
+ Package contains a verbatin copy of the license text
+ License in the copyright notes in the source files matches
with specification on the license tag
+ Local build works fine
+ Koji build works fine
+ Package contains no subpackages
+ %doc stanza is small, so we need no separate doc subpackage
+ Build root will be cleaned at the beginning of %clean and %install
+ Package don't contains any scriptlets
+ %changelog is ok. 

Bad:
- Package doesn't fits with the python SPECE templates
- Build complaints duplicate in the %files stanza
- Package tar ball doesn't match with upstream one
Upstream tar ball:
6b925fe21bb84606b47a9a29d1eb88fb  gsh-0.3.tar.gz 
Packaged tar ball:
9b23c16f1265925989e2c1b4f17b04f9  ../SOURCES/gsh-0.3.tar.gz
- Rpmlint compaints binary package:
$ rpmlint gsh-0.3-1.fc10.noarch.rpm
gsh.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/gsh/pity.py 0644
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
- Please remove the gsh.egg-info directory from the sources in the %setup
stanza
to make sure, theat the egg-infos will been built from source

Hints:
* It may be helpful, if you can read and unterstand the python packaging
guideline as
https://fedoraproject.org/wiki/Packaging/Python

This is not a complete review, because the package has some severe errors and
need some love from you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 464013] Review Request: findbugs-bcel - Byte Code Engineering Library with findbugs extensions

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464013


Jerry James  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #14 from Jerry James   2009-01-28 15:12:28 
EDT ---
New Package CVS Request
===
Package Name: findbugs-bcel
Short Description: Byte Code Engineering Library with findbugs extensions
Owners: jjames
Branches: F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482827] Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482827





--- Comment #2 from David Nielsen   2009-01-28 15:11:13 
EDT ---
banshee-extensions-mirage is consistent both with the application and with
other distros (e.g. Ubuntu calls the same package by this name), upholding this
as an unofficial standard helps users.

Aside that I think I got all of them, except the unstripped .so file, by all
rights now that I removed the nil statement for debug it should be stripped and
split into -debug but it isn't.. advice?:

Spec URL: http://dnielsen.fedorapeople.org/banshee-extension-mirage.spec
SRPM URL:
http://dnielsen.fedorapeople.org/banshee-extension-mirage-0.4.0-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478749] Review Request: dinotrace - X11 waveform viewer for electronics

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478749





--- Comment #5 from Chitlesh GOORAH   2009-01-28 14:56:57 
EDT ---
(In reply to comment #4)
> 1) drop vendor tag in desktop-install-file. See
> http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage
> 

Without a vendor , the build will fail for EL-5.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   3   >