Re: TGA plugin bugfix

[Austin Donnelly]

On Friday, 24 Nov 2000, Lourens Veen wrote:

> About three weeks ago now I found a bug in the TGA loader. I patched it
> and sent the patch to [EMAIL PROTECTED] I got a reply that it had been
> forwarded to the maintainer of the plugin, but I haven't heard anything
> since. So I'm trying the mailinglist.

I think Nick Lamb fixed it in CVS:

2000-11-18  Nick Lamb  <[EMAIL PROTECTED]>

* plug-ins/common/tga.c: Fix alleged problem with small images

This fix will be more widely available when Yosh makes another 1.2
release candidate available.  It's been almost a month since 1.1.29 so
we're probably due another test release soonish (Yosh?)

Austin

TGA plugin bugfix

[Lourens Veen]

Hi everyone,

About three weeks ago now I found a bug in the TGA loader. I patched it
and sent the patch to [EMAIL PROTECTED] I got a reply that it had been
forwarded to the maintainer of the plugin, but I haven't heard anything
since. So I'm trying the mailinglist.

The problem is the following: if the TGA file is smaller than 26 bytes
the loader will give an error, even though there are legal TGA files
possible that are smaller than 26 bytes. I patched it and so far it
works fine here. I have a patch but it's from tga.c in 1.1.29 to my
fixed tga.c. Should I make a context diff that works from the root of
the tree or is it ok to post the file patch (which has to be applied in
plug-ins/common? Should I make a changelog entry (read something about
that, not sure how it works).

I realise that these may be a rather hair-splitting questions but I'm
new to all this and I couldn't find anything in the FAQ about them so
I'm asking them here. 

Lourens