[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554053#comment-15554053 ] ASF GitHub Bot commented on CB-11776: - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/491 Thanks @ktop! Merged! > Can't add two plugins with different edit-config targets > > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon >Affects Versions: 1.4.0 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: edit-config, triaged > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553998#comment-15553998 ] ASF subversion and git services commented on CB-11776: -- Commit c921bc07764ede2218c55eb8399ae335ff5bb1fc in cordova-lib's branch refs/heads/master from [~ktop500] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=c921bc0 ] CB-11776 Add test case for different edit-config targets This closes #491 > Can't add two plugins with different edit-config targets > > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon >Affects Versions: 1.4.0 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: edit-config, triaged > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553999#comment-15553999 ] ASF GitHub Bot commented on CB-11776: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/491 > Can't add two plugins with different edit-config targets > > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon >Affects Versions: 1.4.0 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: edit-config, triaged > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504425#comment-15504425 ] ASF GitHub Bot commented on CB-11776: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/491 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/491?src=pr) is 80.37% (diff: 100%) > Merging [#491](https://codecov.io/gh/apache/cordova-lib/pull/491?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will not change coverage ```diff @@ master #491 diff @@ == Files67 67 Lines 5183 5183 Methods 835835 Messages 0 0 Branches 1005 1005 == Hits 4166 4166 Misses 1017 1017 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [f8b58c7...7b1354a](https://codecov.io/gh/apache/cordova-lib/compare/f8b58c782c71558516adbbd81929ee31ec3ded7f...7b1354ac0090a36133f7fb742fb2090673e200d5?src=pr) > Can't add two plugins with different edit-config targets > > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon >Affects Versions: 1.4.0 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: edit-config, triaged > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504214#comment-15504214 ] ASF GitHub Bot commented on CB-11776: - Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/491 Was part of this PR https://github.com/apache/cordova-lib/pull/486 > Can't add two plugins with different edit-config targets > > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon >Affects Versions: 1.4.0 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: edit-config, triaged > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504169#comment-15504169 ] ASF GitHub Bot commented on CB-11776: - GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/491 CB-11776 Fix can't add two plugins with different edit-config targets An error was thrown when adding two plugins with different edit-config targets. The conflict checking code was missing a case, so it errors out and the second plugin cannot be added. I fixed the conflict checking and added a test case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ktop/cordova-lib ecerror Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/491.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #491 commit 7b1354ac0090a36133f7fb742fb2090673e200d5 Author: ktop Date: 2016-09-19T17:53:51Z CB-11776 Fix can't add two plugins with different edit-config targets > Can't add two plugins with different edit-config targets > > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon >Affects Versions: 1.4.0 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: edit-config, triaged > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456863#comment-15456863 ] ASF GitHub Bot commented on CB-11776: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/486 > Can't add two plugins with different edit-config targets > > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: CordovaCommon >Affects Versions: 1.4.0 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: edit-config, triaged > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456862#comment-15456862 ] ASF subversion and git services commented on CB-11776: -- Commit 905429cf60084d2b0781bcf5643245e78cdf3474 in cordova-lib's branch refs/heads/master from [~ktop500] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=905429c ] CB-11776 check edit-config target exists This closes #486 > Can't add two plugins with different edit-config targets > > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: CordovaCommon >Affects Versions: 1.4.0 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: edit-config, triaged > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440159#comment-15440159 ] ASF GitHub Bot commented on CB-11776: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/486 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/486?src=pr) is 80.78% (diff: 100%) > Merging [#486](https://codecov.io/gh/apache/cordova-lib/pull/486?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will not change coverage ```diff @@ master #486 diff @@ == Files68 68 Lines 5407 5407 Methods 857857 Messages 0 0 Branches 1048 1048 == Hits 4368 4368 Misses 1039 1039 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [3b38b53...a7e6634](https://codecov.io/gh/apache/cordova-lib/compare/3b38b5382b9a52d1fe522514b61d3ebd6016796d...a7e6634217e187434d560ac2d32bf352662b3a25?src=pr) > Can't add two plugins with different edit-config targets > > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: CordovaCommon >Affects Versions: 1.4.0 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: edit-config > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
[ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439994#comment-15439994 ] ASF GitHub Bot commented on CB-11776: - GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/486 CB-11776 check edit-config target exists Missing a case in the conflict checking for edit-config. If the target doesn't exist in .json, and cannot resolve to an existing target, then no conflict should be found. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ktop/cordova-lib ecerror Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/486.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #486 commit a7e6634217e187434d560ac2d32bf352662b3a25 Author: ktop Date: 2016-08-26T21:59:46Z CB-11776 check edit-config target exists > Can't add two plugins with different edit-config targets > > > Key: CB-11776 > URL: https://issues.apache.org/jira/browse/CB-11776 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: CordovaCommon >Affects Versions: 1.4.0 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: edit-config > Fix For: Master > > > When adding two plugins where both plugins are using edit-config, the second > plugin will have issues being added. The conflict checking for edit-config is > missing a case where the target cannot resolve to an existing target. Should > check if the target exists before proceeding. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org