[jira] [Assigned] (HBASE-5699) Run with > 1 WAL in HRegionServer

[Li Pi (Assigned) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Li Pi reassigned HBASE-5699:


Assignee: Li Pi

> Run with > 1 WAL in HRegionServer
> -
>
> Key: HBASE-5699
> URL: https://issues.apache.org/jira/browse/HBASE-5699
> Project: HBase
>  Issue Type: Improvement
>Reporter: binlijin
>Assignee: Li Pi
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5699) Run with > 1 WAL in HRegionServer

[Li Pi (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250471#comment-13250471
 ] 

Li Pi commented on HBASE-5699:
--

This seems interesting. I'll take a look at doing this.

> Run with > 1 WAL in HRegionServer
> -
>
> Key: HBASE-5699
> URL: https://issues.apache.org/jira/browse/HBASE-5699
> Project: HBase
>  Issue Type: Improvement
>Reporter: binlijin
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5699) Run with > 1 WAL in HRegionServer

[Li Pi (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250470#comment-13250470
 ] 

Li Pi commented on HBASE-5699:
--

This seems interesting. I'll take a look at doing this.

> Run with > 1 WAL in HRegionServer
> -
>
> Key: HBASE-5699
> URL: https://issues.apache.org/jira/browse/HBASE-5699
> Project: HBase
>  Issue Type: Improvement
>Reporter: binlijin
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4336) Convert source tree into maven modules

[Jesse Yates (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250467#comment-13250467
 ] 

Jesse Yates commented on HBASE-4336:


After much divining of tarot cards and tea leaves to understand some of the 
maven 'features', I think I have a working, modularized build of hbase. The 
modules are:
* hbase (parent)
* hbase-core (most of the code)
* hbase-common (basically empty, but where things like the util classes will go)
* hbase-security
* hbase-assemble (needed because the top level module can't depend on its 
children)

Most of the code has not been moved over to common that will, but there is no 
reason why any changes should impact the build - all the jars and sources are 
being assembled correctly.

The link to the repo can be found here: 
https://github.com/jyates/hbase/tree/refactor-modules

Please give it a test drive, make sure things build well, etc. I have it 
working on OSX and deploying in standalone mode (used "mvn clean package" to 
build).

> Convert source tree into maven modules
> --
>
> Key: HBASE-4336
> URL: https://issues.apache.org/jira/browse/HBASE-4336
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Gary Helmling
>Priority: Critical
> Fix For: 0.96.0
>
>
> When we originally converted the build to maven we had a single "core" module 
> defined, but later reverted this to a module-less build for the sake of 
> simplicity.
> It now looks like it's time to re-address this, as we have an actual need for 
> modules to:
> * provide a trimmed down "client" library that applications can make use of
> * more cleanly support building against different versions of Hadoop, in 
> place of some of the reflection machinations currently required
> * incorporate the secure RPC engine that depends on some secure Hadoop classes
> I propose we start simply by refactoring into two initial modules:
> * core - common classes and utilities, and client-side code and interfaces
> * server - master and region server implementations and supporting code
> This would also lay the groundwork for incorporating the HBase security 
> features that have been developed.  Once the module structure is in place, 
> security-related features could then be incorporated into a third module -- 
> "security" -- after normal review and approval.  The security module could 
> then depend on secure Hadoop, without modifying the dependencies of the rest 
> of the HBase code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5604) M/R tools to replay WAL files

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250453#comment-13250453
 ] 

Hadoop QA commented on HBASE-5604:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522068/5604-v8.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 3 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.client.TestFromClientSide

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1460//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1460//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1460//console

This message is automatically generated.

> M/R tools to replay WAL files
> -
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, 5604-v8.txt, 
> HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5604) M/R tools to replay WAL files

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250450#comment-13250450
 ] 

Zhihong Yu commented on HBASE-5604:
---

{code}
+  if (tablesToUse == null || tableMap == null || tablesToUse.length != 
tableMap.length) {
+// this can only happen when HLogMapper is used directly by a class 
other than WALPlayer
+throw new IOException("No tables or incorrect table mapping 
specified.");
{code}
I think if we provide separate exceptions for the first two checks and the last 
check, it would be easier for user to understand.
{code}
+System.err.println("  -D" + HLogInputFormat.START_TIME_KEY + "=ms (only 
apply edit after this time)");
+System.err.println("  -D" + HLogInputFormat.END_TIME_KEY + "=ms (only 
apply edit before this time)");
{code}
User would have to resort to conversion tool in order to find out the ms 
readings for desired date / time. Can we make this more user-friendly ?
e.g. in TimeStampingFileContext.java we have:
{code}
this.sdf = new SimpleDateFormat("-MM-dd'T'HH:mm:ss");
{code}
See also 
http://docs.oracle.com/javase/6/docs/api/java/text/SimpleDateFormat.html#parse%28java.lang.String,%20java.text.ParsePosition%29
{code}
+public String[] getLocations() throws IOException, InterruptedException {
+  // TODO: Find the data node with the most blocks for this HLog?
{code}
Would the above be addressed in a separate JIRA ?
{code}
+if (i>0) LOG.info("Skipped " + i + " entries.");
{code}
Minor: add spaces around '>'



> M/R tools to replay WAL files
> -
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, 5604-v8.txt, 
> HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5677) The master never does balance because duplicate openhandled the one region

[Zhihong Yu (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu updated HBASE-5677:
--

Fix Version/s: 0.96.0
   0.94.0
   0.92.2
   0.90.7

> The master never does balance because duplicate openhandled the one region
> --
>
> Key: HBASE-5677
> URL: https://issues.apache.org/jira/browse/HBASE-5677
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.6
> Environment: 0.90
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: HBASE-5677-90-v1.patch, 
> surefire-report_no_patched_v1.html, surefire-report_patched_v1.html
>
>
> If region be assigned When the master is doing initialization(before do 
> processFailover),the region will be duplicate openhandled.
> because the unassigned node in zookeeper will be handled again in 
> AssignmentManager#processFailover()
> it cause the region in RIT,thus the master never does balance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-3443) ICV optimization to look in memstore first and then store files (HBASE-3082) does not work when deletes are in the mix

[Benoit Sigoure (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benoit Sigoure updated HBASE-3443:
--

  Component/s: regionserver
Affects Version/s: 0.90.0
   0.90.1
   0.90.2
   0.90.3
   0.90.4
   0.90.5
   0.90.6
   0.92.0
   0.92.1
   Labels: corruption  (was: )

> ICV optimization to look in memstore first and then store files (HBASE-3082) 
> does not work when deletes are in the mix
> --
>
> Key: HBASE-3443
> URL: https://issues.apache.org/jira/browse/HBASE-3443
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 
> 0.92.0, 0.92.1
>Reporter: Kannan Muthukkaruppan
>  Labels: corruption
>
> For incrementColumnValue() HBASE-3082 adds an optimization to check memstores 
> first, and only if not present in the memstore then check the store files. In 
> the presence of deletes, the above optimization is not reliable.
> If the column is marked as deleted in the memstore, one should not look 
> further into the store files. But currently, the code does so.
> Sample test code outline:
> {code}
> admin.createTable(desc)
> table = HTable.new(conf, tableName)
> table.incrementColumnValue(Bytes.toBytes("row"), cf1name, 
> Bytes.toBytes("column"), 5);
> admin.flush(tableName)
> sleep(2)
> del = Delete.new(Bytes.toBytes("row"))
> table.delete(del)
> table.incrementColumnValue(Bytes.toBytes("row"), cf1name, 
> Bytes.toBytes("column"), 5);
> get = Get.new(Bytes.toBytes("row"))
> keyValues = table.get(get).raw()
> keyValues.each do |keyValue|
>   puts "Expect 5; Got Value=#{Bytes.toLong(keyValue.getValue())}";
> end
> {code}
> The above prints:
> {code}
> Expect 5; Got Value=10
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5604) M/R tools to replay WAL files

[Lars Hofhansl (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-5604:
-

Attachment: 5604-v8.txt

Addressed Ted's comment (except for Put.heapSize()). Also actually included the 
WALPlayer end-to-end test this time.

> M/R tools to replay WAL files
> -
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, 5604-v8.txt, 
> HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3443) ICV optimization to look in memstore first and then store files (HBASE-3082) does not work when deletes are in the mix

[Benoit Sigoure (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250447#comment-13250447
 ] 

Benoit Sigoure commented on HBASE-3443:
---

This seems like a pretty bad bug that causes data corruption.  I ran into it 
this weekend.  Which release do you guys think will have a fix for this issue?

> ICV optimization to look in memstore first and then store files (HBASE-3082) 
> does not work when deletes are in the mix
> --
>
> Key: HBASE-3443
> URL: https://issues.apache.org/jira/browse/HBASE-3443
> Project: HBase
>  Issue Type: Bug
>Reporter: Kannan Muthukkaruppan
>
> For incrementColumnValue() HBASE-3082 adds an optimization to check memstores 
> first, and only if not present in the memstore then check the store files. In 
> the presence of deletes, the above optimization is not reliable.
> If the column is marked as deleted in the memstore, one should not look 
> further into the store files. But currently, the code does so.
> Sample test code outline:
> {code}
> admin.createTable(desc)
> table = HTable.new(conf, tableName)
> table.incrementColumnValue(Bytes.toBytes("row"), cf1name, 
> Bytes.toBytes("column"), 5);
> admin.flush(tableName)
> sleep(2)
> del = Delete.new(Bytes.toBytes("row"))
> table.delete(del)
> table.incrementColumnValue(Bytes.toBytes("row"), cf1name, 
> Bytes.toBytes("column"), 5);
> get = Get.new(Bytes.toBytes("row"))
> keyValues = table.get(get).raw()
> keyValues.each do |keyValue|
>   puts "Expect 5; Got Value=#{Bytes.toLong(keyValue.getValue())}";
> end
> {code}
> The above prints:
> {code}
> Expect 5; Got Value=10
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5677) The master never does balance because duplicate openhandled the one region

[Lars Hofhansl (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250445#comment-13250445
 ] 

Lars Hofhansl commented on HBASE-5677:
--

Seems this should in 0.94.0. Agreed?

> The master never does balance because duplicate openhandled the one region
> --
>
> Key: HBASE-5677
> URL: https://issues.apache.org/jira/browse/HBASE-5677
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.6
> Environment: 0.90
>Reporter: xufeng
>Assignee: xufeng
> Attachments: HBASE-5677-90-v1.patch, 
> surefire-report_no_patched_v1.html, surefire-report_patched_v1.html
>
>
> If region be assigned When the master is doing initialization(before do 
> processFailover),the region will be duplicate openhandled.
> because the unassigned node in zookeeper will be handled again in 
> AssignmentManager#processFailover()
> it cause the region in RIT,thus the master never does balance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (HBASE-5677) The master never does balance because duplicate openhandled the one region

[Zhihong Yu (Issue Comment Edited) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250443#comment-13250443
 ] 

Zhihong Yu edited comment on HBASE-5677 at 4/10/12 3:58 AM:


Some comments about coding style:
{code}
+  //the master is running and it can provide service
+  public boolean isMasterAvailable() {
+   return !isStopped() && isInitialized();
+  }
{code}
@Override is missing for the above method.
Please leave a space between // and the
Indentation for the return line should be 4 spaces. i.e. 'r' of return should 
be under 'b' of public.
{code}
+  if(isAvailable) {
{code}
Please leave a space between if and left parenthesis.
{code}
+  throw new MasterNotRunningException();
{code}
You can create a new exception in place of MasterNotRunningException above.

  was (Author: zhi...@ebaysf.com):
Some comments about coding style:
{code}
+  //the master is running and it can provide service
+  public boolean isMasterAvailable() {
+   return !isStopped() && isInitialized();
+  }
{code}
@Override is missing for the above method.
Please leave a space between // and the
Indentation for the return line should be 4 spaces. i.e. 'r' of return should 
be under 'b' of public.
{code}
+  if(isAvailable) {
{code}
Please leave a space between if and left parenthesis.
{code}
+  throw new MasterNotRunningException();
{code}
You can create a new exception or provide cause to MasterNotRunningException.
  
> The master never does balance because duplicate openhandled the one region
> --
>
> Key: HBASE-5677
> URL: https://issues.apache.org/jira/browse/HBASE-5677
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.6
> Environment: 0.90
>Reporter: xufeng
>Assignee: xufeng
> Attachments: HBASE-5677-90-v1.patch, 
> surefire-report_no_patched_v1.html, surefire-report_patched_v1.html
>
>
> If region be assigned When the master is doing initialization(before do 
> processFailover),the region will be duplicate openhandled.
> because the unassigned node in zookeeper will be handled again in 
> AssignmentManager#processFailover()
> it cause the region in RIT,thus the master never does balance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5755) Region sever looking for master forever with cached stale data.

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250444#comment-13250444
 ] 

Zhihong Yu commented on HBASE-5755:
---

Patch makes sense.

> Region sever looking for master forever with cached stale data.
> ---
>
> Key: HBASE-5755
> URL: https://issues.apache.org/jira/browse/HBASE-5755
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.96.0
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5755.patch
>
>
> When the master address tracker doesn't have the master address ZK data, or 
> the cached data is wrong, region server should not use the cached data.
> It should pull the data from ZK directly again.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5677) The master never does balance because duplicate openhandled the one region

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250443#comment-13250443
 ] 

Zhihong Yu commented on HBASE-5677:
---

Some comments about coding style:
{code}
+  //the master is running and it can provide service
+  public boolean isMasterAvailable() {
+   return !isStopped() && isInitialized();
+  }
{code}
@Override is missing for the above method.
Please leave a space between // and the
Indentation for the return line should be 4 spaces. i.e. 'r' of return should 
be under 'b' of public.
{code}
+  if(isAvailable) {
{code}
Please leave a space between if and left parenthesis.
{code}
+  throw new MasterNotRunningException();
{code}
You can create a new exception or provide cause to MasterNotRunningException.

> The master never does balance because duplicate openhandled the one region
> --
>
> Key: HBASE-5677
> URL: https://issues.apache.org/jira/browse/HBASE-5677
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.6
> Environment: 0.90
>Reporter: xufeng
>Assignee: xufeng
> Attachments: HBASE-5677-90-v1.patch, 
> surefire-report_no_patched_v1.html, surefire-report_patched_v1.html
>
>
> If region be assigned When the master is doing initialization(before do 
> processFailover),the region will be duplicate openhandled.
> because the unassigned node in zookeeper will be handled again in 
> AssignmentManager#processFailover()
> it cause the region in RIT,thus the master never does balance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5677) The master never does balance because duplicate openhandled the one region

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250442#comment-13250442
 ] 

Zhihong Yu commented on HBASE-5677:
---

The new method has traces of the existing method:
{code}
+  public boolean isMasterAvailable()
+  throws MasterNotRunningException, ZooKeeperConnectionException {
{code}
We should wait for other reviewers' comment about proper naming.

As always, please provide patch for trunk, 0.94 and 0.92.
Attaching patch for trunk would allow Hadoop QA to run.

> The master never does balance because duplicate openhandled the one region
> --
>
> Key: HBASE-5677
> URL: https://issues.apache.org/jira/browse/HBASE-5677
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.6
> Environment: 0.90
>Reporter: xufeng
>Assignee: xufeng
> Attachments: HBASE-5677-90-v1.patch, 
> surefire-report_no_patched_v1.html, surefire-report_patched_v1.html
>
>
> If region be assigned When the master is doing initialization(before do 
> processFailover),the region will be duplicate openhandled.
> because the unassigned node in zookeeper will be handled again in 
> AssignmentManager#processFailover()
> it cause the region in RIT,thus the master never does balance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5604) M/R tools to replay WAL files

[Lars Hofhansl (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250439#comment-13250439
 ] 

Lars Hofhansl commented on HBASE-5604:
--

Thanks Ted.

* I'll add Javadoc.
* index of 0 is used here, since when creating HFiles for bulk import only a 
single table is currently allowed (that is also documented in usage(), but 
perhaps not clearly enough...?). I'll add a comment to that extent.
* That the two arrays are of the same size if guaranteed in 
WALPlayer.createSubmittableJob(), but perhaps it is better to double check here.
* Checking heapSize() seems unnecessary. After all, this is single WALEdit.


> M/R tools to replay WAL files
> -
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5749) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5749:
-

   Resolution: Fixed
Fix Version/s: 0.96.0
 Assignee: stack
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Committed to trunk.

> "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
> heapsize
> --
>
> Key: HBASE-5749
> URL: https://issues.apache.org/jira/browse/HBASE-5749
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: heapsize.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5677) The master never does balance because duplicate openhandled the one region

[xufeng (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xufeng updated HBASE-5677:
--

Attachment: surefire-report_patched_v1.html
surefire-report_no_patched_v1.html
HBASE-5677-90-v1.patch

@Ted
At first,I try to change the isMasterRunning like this:
  public boolean isMasterRunning() {
return !isStopped() && isInitialized();
  }
But Some class like HMerge,this tool just care the master is running or not.

So I think it is necessary to create a new method in HMasterInterface.

I create a 90 patch,pls review this and give me some suggestions,thanks.

I tested it by reproduce steps, shell can not work until the master completed 
the initialization.
And I also do the unit test,it seems ok.

> The master never does balance because duplicate openhandled the one region
> --
>
> Key: HBASE-5677
> URL: https://issues.apache.org/jira/browse/HBASE-5677
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.6
> Environment: 0.90
>Reporter: xufeng
>Assignee: xufeng
> Attachments: HBASE-5677-90-v1.patch, 
> surefire-report_no_patched_v1.html, surefire-report_patched_v1.html
>
>
> If region be assigned When the master is doing initialization(before do 
> processFailover),the region will be duplicate openhandled.
> because the unassigned node in zookeeper will be handled again in 
> AssignmentManager#processFailover()
> it cause the region in RIT,thus the master never does balance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5684) Make ProcessBasedLocalHBaseCluster run HDFS and make it more robust

[Phabricator (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250415#comment-13250415
 ] 

Phabricator commented on HBASE-5684:


tedyu has commented on the revision "[jira] [HBASE-5684] Make 
ProcessBasedLocalHBaseCluster run HDFS and make it more robust".

  Patch looks good.

INLINE COMMENTS
  src/test/java/org/apache/hadoop/hbase/util/HBaseHomePath.java:44 Should read 
'to look up'
  
src/test/java/org/apache/hadoop/hbase/util/ProcessBasedLocalHBaseCluster.java:114
 Why is sorting needed ?
  
src/test/java/org/apache/hadoop/hbase/util/ProcessBasedLocalHBaseCluster.java:250
 I think removing 'to kill' would make the sentence clearer.
  
src/test/java/org/apache/hadoop/hbase/util/ProcessBasedLocalHBaseCluster.java:395
 Should we add mapping for 'fs.defaultFS' as well ?

REVISION DETAIL
  https://reviews.facebook.net/D2709


> Make ProcessBasedLocalHBaseCluster run HDFS and make it more robust
> ---
>
> Key: HBASE-5684
> URL: https://issues.apache.org/jira/browse/HBASE-5684
> Project: HBase
>  Issue Type: Improvement
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
> Attachments: D2709.1.patch
>
>
> Currently ProcessBasedLocalHBaseCluster runs on top of raw local filesystem. 
> We need it to start a process-based HDFS cluster as well. We also need to 
> make the whole thing more stable so we can use it in unit tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5748) Enable lib directory in jar file for coprocessor

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250403#comment-13250403
 ] 

Hudson commented on HBASE-5748:
---

Integrated in HBase-0.92 #365 (See 
[https://builds.apache.org/job/HBase-0.92/365/])
HBASE-5748 Enable lib directory in jar file for coprocessor (Revision 
1311503)

 Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java


> Enable lib directory in jar file for coprocessor
> 
>
> Key: HBASE-5748
> URL: https://issues.apache.org/jira/browse/HBASE-5748
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors
>Affects Versions: 0.92.1, 0.94.0
>Reporter: Takuya Ueshin
>Assignee: Takuya Ueshin
> Fix For: 0.92.2, 0.94.0
>
> Attachments: HBASE-5748.patch
>
>
> Hadoop MapReduce job can use external libraries in 'lib' directory in the 
> job.jar file.
> It is useful that jar files for coprocessor can use external libraries in the 
> same way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5604) M/R tools to replay WAL files

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250393#comment-13250393
 ] 

Zhihong Yu commented on HBASE-5604:
---

{code}
+public class WALPlayer extends Configured implements Tool {
{code}
Javadoc for the above new class is desirable.
{code}
+public void setup(Context context) {
+  table = 
Bytes.toBytes(context.getConfiguration().getStrings(TABLES_KEY)[0]);
+}
{code}
Why index of 0 is always used above ?
{code}
+public void setup(Context context) {
+  String[] tableMap = context.getConfiguration().getStrings(TABLE_MAP_KEY);
+  int i = 0;
+  for (String table : context.getConfiguration().getStrings(TABLES_KEY)) {
+tables.put(Bytes.toBytes(table), Bytes.toBytes(tableMap[i++]));
{code}
I think validation on the lengths of the two String[] should be performed. If 
they don't match, bail out early.
{code}
+// Aggregate as much as possible into a single Put/Delete
+// operation before writing to the context.
{code}
Shall we utilize Put.heapSize() and remember the aggregate size of the Put so 
that we can write to context when certain threshold is reached ?

> M/R tools to replay WAL files
> -
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5684) Make ProcessBasedLocalHBaseCluster run HDFS and make it more robust

[Phabricator (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HBASE-5684:
---

Attachment: D2709.1.patch

mbautin requested code review of "[jira] [HBASE-5684] Make 
ProcessBasedLocalHBaseCluster run HDFS and make it more robust".
Reviewers: Kannan, Liyin, khemani, Karthik, madhuvaidya, amirshim, JIRA

  Currently ProcessBasedLocalHBaseCluster runs on top of raw local filesystem. 
We need it to start a process-based HDFS cluster as well. We also need to make 
the whole thing more stable so we can use it in unit tests.

  Also all logs of local HBase cluster daemons are now tailed to the primary 
log of the unit test with the appropriate prefixes to make debugging easier.

TEST PLAN
  Run the new unit test multiple times (10x or 50x).
  Run all unit tests.

REVISION DETAIL
  https://reviews.facebook.net/D2709

AFFECTED FILES
  bin/hbase-config.sh
  bin/test/kill_process_based_cluster.sh
  src/main/java/org/apache/hadoop/hbase/HConstants.java
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
  src/test/java/org/apache/hadoop/hbase/HTestConst.java
  src/test/java/org/apache/hadoop/hbase/TestInfoServers.java
  src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
  src/test/java/org/apache/hadoop/hbase/master/TestZKBasedCloseRegion.java
  src/test/java/org/apache/hadoop/hbase/master/TestZKBasedReopenRegion.java
  src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
  src/test/java/org/apache/hadoop/hbase/util/HBaseHomePath.java
  src/test/java/org/apache/hadoop/hbase/util/ProcessBasedLocalHBaseCluster.java
  src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java
  src/test/java/org/apache/hadoop/hbase/util/TestHBaseHomePath.java
  src/test/java/org/apache/hadoop/hbase/util/TestProcessBasedCluster.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6195/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.


> Make ProcessBasedLocalHBaseCluster run HDFS and make it more robust
> ---
>
> Key: HBASE-5684
> URL: https://issues.apache.org/jira/browse/HBASE-5684
> Project: HBase
>  Issue Type: Improvement
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
> Attachments: D2709.1.patch
>
>
> Currently ProcessBasedLocalHBaseCluster runs on top of raw local filesystem. 
> We need it to start a process-based HDFS cluster as well. We also need to 
> make the whole thing more stable so we can use it in unit tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5699) Run with > 1 WAL in HRegionServer

[binlijin (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250374#comment-13250374
 ] 

binlijin commented on HBASE-5699:
-

I just run a test and don't test the recovery and the others.

> Run with > 1 WAL in HRegionServer
> -
>
> Key: HBASE-5699
> URL: https://issues.apache.org/jira/browse/HBASE-5699
> Project: HBase
>  Issue Type: Improvement
>Reporter: binlijin
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5755) Region sever looking for master forever with cached stale data.

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250370#comment-13250370
 ] 

Hadoop QA commented on HBASE-5755:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522043/hbase-5755.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1459//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1459//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1459//console

This message is automatically generated.

> Region sever looking for master forever with cached stale data.
> ---
>
> Key: HBASE-5755
> URL: https://issues.apache.org/jira/browse/HBASE-5755
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.96.0
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5755.patch
>
>
> When the master address tracker doesn't have the master address ZK data, or 
> the cached data is wrong, region server should not use the cached data.
> It should pull the data from ZK directly again.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5604) M/R tools to replay WAL files

[Lars Hofhansl (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-5604:
-

Summary: M/R tools to replay WAL files  (was: HLog replay tool that 
generates HFiles for use by LoadIncrementalHFiles.)

> M/R tools to replay WAL files
> -
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5604) HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.

[Lars Hofhansl (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-5604:
-

Release Note: 
Tool to replay WAL files using a M/R job.

The WAL can be replayed for a set of tables or all tables, and a timerange can 
be provided (in milliseconds).
The WAL is filtered to this set of tables, the output can optionally be mapped 
to another set of tables.

WAL replay can also generate HFiles for later bulk importing, in that case the 
WAL is replayed for a single table only.


> HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.
> 
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250348#comment-13250348
 ] 

Zhihong Yu commented on HBASE-5727:
---

Integrated addendum to trunk.

Jenkins is having trouble performing build at the moment.
Will resolve once a good build is produced.

> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch, 
> AccessController.diff
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5604) HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.

[Lars Hofhansl (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250336#comment-13250336
 ] 

Lars Hofhansl commented on HBASE-5604:
--

TestForceCacheImportantBlocks passes locally. I'm ready to commit.

> HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.
> 
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5604) HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250327#comment-13250327
 ] 

Hadoop QA commented on HBASE-5604:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522035/5604-v7.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 3 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1458//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1458//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1458//console

This message is automatically generated.

> HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.
> 
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5748) Enable lib directory in jar file for coprocessor

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250317#comment-13250317
 ] 

Hudson commented on HBASE-5748:
---

Integrated in HBase-0.94 #100 (See 
[https://builds.apache.org/job/HBase-0.94/100/])
HBASE-5748 Enable lib directory in jar file for coprocessor -- REDO AFTER 
OVERCOMMIT (Revision 1311501)
HBASE-5748 Enable lib directory in jar file for coprocessor -- UNDO OVERCOMMIT 
(Revision 1311500)
HBASE-5748 Enable lib directory in jar file for coprocessor (Revision 1311499)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java

stack : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java

stack : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java


> Enable lib directory in jar file for coprocessor
> 
>
> Key: HBASE-5748
> URL: https://issues.apache.org/jira/browse/HBASE-5748
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors
>Affects Versions: 0.92.1, 0.94.0
>Reporter: Takuya Ueshin
>Assignee: Takuya Ueshin
> Fix For: 0.92.2, 0.94.0
>
> Attachments: HBASE-5748.patch
>
>
> Hadoop MapReduce job can use external libraries in 'lib' directory in the 
> job.jar file.
> It is useful that jar files for coprocessor can use external libraries in the 
> same way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5748) Enable lib directory in jar file for coprocessor

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250314#comment-13250314
 ] 

Hudson commented on HBASE-5748:
---

Integrated in HBase-TRUNK #2733 (See 
[https://builds.apache.org/job/HBase-TRUNK/2733/])
HBASE-5748 Enable lib directory in jar file for coprocessor (Revision 
1311498)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java


> Enable lib directory in jar file for coprocessor
> 
>
> Key: HBASE-5748
> URL: https://issues.apache.org/jira/browse/HBASE-5748
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors
>Affects Versions: 0.92.1, 0.94.0
>Reporter: Takuya Ueshin
>Assignee: Takuya Ueshin
> Fix For: 0.92.2, 0.94.0
>
> Attachments: HBASE-5748.patch
>
>
> Hadoop MapReduce job can use external libraries in 'lib' directory in the 
> job.jar file.
> It is useful that jar files for coprocessor can use external libraries in the 
> same way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5754) data lost with gora continuous ingest test (goraci)

[Enis Soztutar (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250316#comment-13250316
 ] 

Enis Soztutar commented on HBASE-5754:
--

@Stack, if you need any help with Gora, I can help with that. 

> data lost with gora continuous ingest test (goraci)
> ---
>
> Key: HBASE-5754
> URL: https://issues.apache.org/jira/browse/HBASE-5754
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
> Environment: 10 node test cluster
>Reporter: Eric Newton
>Assignee: stack
>
> Keith Turner re-wrote the accumulo continuous ingest test using gora, which 
> has both hbase and accumulo back-ends.
> I put a billion entries into HBase, and ran the Verify map/reduce job.  The 
> verification failed because about 21K entries were missing.  The goraci 
> [README|https://github.com/keith-turner/goraci] explains the test, and how it 
> detects missing data.
> I re-ran the test with 100 million entries, and it verified successfully.  
> Both of the times I tested using a billion entries, the verification failed.
> If I run the verification step twice, the results are consistent, so the 
> problem is
> probably not on the verify step.
> Here's the versions of the various packages:
> ||package||version||
> |hadoop|0.20.205.0|
> |hbase|0.92.1|
> |gora|http://svn.apache.org/repos/asf/gora/trunk r1311277|
> |goraci|https://github.com/ericnewton/goraci  tagged 2012-04-08|
> The change I made to goraci was to configure it for hbase and to allow it to 
> build properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5740) Compaction interruption may be due to balacing

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250315#comment-13250315
 ] 

Hudson commented on HBASE-5740:
---

Integrated in HBase-TRUNK #2733 (See 
[https://builds.apache.org/job/HBase-TRUNK/2733/])
HBASE-5740 Compaction interruption may be due to balacing (Revision 1311514)

 Result = SUCCESS
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Compactor.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Compaction interruption may be due to balacing
> --
>
> Key: HBASE-5740
> URL: https://issues.apache.org/jira/browse/HBASE-5740
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.96.0
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
>Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: hbase-5740.patch, hbase-5740_v2.patch
>
>
> Currently, the log shows 
> Aborting compaction of store LOG in region  because user requested stop.
> But it is actually because of balancing.
> Currently, there is no way to figure out who closed the region.  So it is 
> better to change the message to say it is because of user, or balancing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5755) Region sever looking for master forever with cached stale data.

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5755:
---

Attachment: hbase-5755.patch

The other solution is to update ZookeeperNodeTracker.getData to pull data from 
ZK anyway when this.data is null or empty, which means the contract is 
different though.

> Region sever looking for master forever with cached stale data.
> ---
>
> Key: HBASE-5755
> URL: https://issues.apache.org/jira/browse/HBASE-5755
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.96.0
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5755.patch
>
>
> When the master address tracker doesn't have the master address ZK data, or 
> the cached data is wrong, region server should not use the cached data.
> It should pull the data from ZK directly again.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5755) Region sever looking for master forever with cached stale data.

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5755:
---

Status: Patch Available  (was: Open)

> Region sever looking for master forever with cached stale data.
> ---
>
> Key: HBASE-5755
> URL: https://issues.apache.org/jira/browse/HBASE-5755
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.96.0
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5755.patch
>
>
> When the master address tracker doesn't have the master address ZK data, or 
> the cached data is wrong, region server should not use the cached data.
> It should pull the data from ZK directly again.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5755) Region sever looking for master forever with cached stale data.

[Jimmy Xiang (Created) (JIRA)]

Region sever looking for master forever with cached stale data.
---

 Key: HBASE-5755
 URL: https://issues.apache.org/jira/browse/HBASE-5755
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
 Fix For: 0.96.0


When the master address tracker doesn't have the master address ZK data, or the 
cached data is wrong, region server should not use the cached data.
It should pull the data from ZK directly again.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5604) HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.

[Lars Hofhansl (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-5604:
-

Attachment: 5604-v7.txt

This should be close to what I would like to commit.
Added a simple end-to-end test for WALPlayer.

> HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.
> 
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5604) HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.

[Lars Hofhansl (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-5604:
-

Status: Patch Available  (was: Open)

> HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.
> 
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-5604) HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.

[Lars Hofhansl (Assigned) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl reassigned HBASE-5604:


Assignee: Lars Hofhansl

> HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.
> 
>
> Key: HBASE-5604
> URL: https://issues.apache.org/jira/browse/HBASE-5604
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5749) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250285#comment-13250285
 ] 

Hadoop QA commented on HBASE-5749:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12521975/heapsize.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1457//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1457//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1457//console

This message is automatically generated.

> "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
> heapsize
> --
>
> Key: HBASE-5749
> URL: https://issues.apache.org/jira/browse/HBASE-5749
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: heapsize.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5749) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[Nicolas Spiegelberg (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250282#comment-13250282
 ] 

Nicolas Spiegelberg commented on HBASE-5749:


+1 if you haven't committed/resolved already

> "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
> heapsize
> --
>
> Key: HBASE-5749
> URL: https://issues.apache.org/jira/browse/HBASE-5749
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: heapsize.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5748) Enable lib directory in jar file for coprocessor

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250276#comment-13250276
 ] 

stack commented on HBASE-5748:
--

No.  Thank you (smile).

> Enable lib directory in jar file for coprocessor
> 
>
> Key: HBASE-5748
> URL: https://issues.apache.org/jira/browse/HBASE-5748
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors
>Affects Versions: 0.92.1, 0.94.0
>Reporter: Takuya Ueshin
>Assignee: Takuya Ueshin
> Fix For: 0.92.2, 0.94.0
>
> Attachments: HBASE-5748.patch
>
>
> Hadoop MapReduce job can use external libraries in 'lib' directory in the 
> job.jar file.
> It is useful that jar files for coprocessor can use external libraries in the 
> same way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5740) Compaction interruption may be due to balacing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5740:
-

  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Committed to trunk.  Thanks for the patch Jimmy.

> Compaction interruption may be due to balacing
> --
>
> Key: HBASE-5740
> URL: https://issues.apache.org/jira/browse/HBASE-5740
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.96.0
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
>Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: hbase-5740.patch, hbase-5740_v2.patch
>
>
> Currently, the log shows 
> Aborting compaction of store LOG in region  because user requested stop.
> But it is actually because of balancing.
> Currently, there is no way to figure out who closed the region.  So it is 
> better to change the message to say it is because of user, or balancing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5740) Compaction interruption may be due to balacing

[Jimmy Xiang (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250267#comment-13250267
 ] 

Jimmy Xiang commented on HBASE-5740:


@Stack, I am fine with the generic message. Please make the change on commit.  
Thanks a lot.
We don't know for sure who interrupted it anyway for now.

> Compaction interruption may be due to balacing
> --
>
> Key: HBASE-5740
> URL: https://issues.apache.org/jira/browse/HBASE-5740
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.96.0
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
>Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: hbase-5740.patch, hbase-5740_v2.patch
>
>
> Currently, the log shows 
> Aborting compaction of store LOG in region  because user requested stop.
> But it is actually because of balancing.
> Currently, there is no way to figure out who closed the region.  So it is 
> better to change the message to say it is because of user, or balancing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5666) RegionServer doesn't retry to check if base node is available

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250269#comment-13250269
 ] 

stack commented on HBASE-5666:
--

Patch looks good.

Logs '{
+LOG.warn(zkw.prefix("Unable to set watcher on znode (" + znode + 
")"), keeperEx);
'
... but the method says its checkExists w/o setting watch.

I think this a bad idea; i.e. sleeping w/o interrupt.  How long is 
SOCKET_RETRY_WAIT_MS?  What if we try to stop the hosting server in meantime?  
We have to wait on this to come up out of this loop?

+Threads.sleepWithoutInterrupt(HConstants.SOCKET_RETRY_WAIT_MS);

Passing 0, are we supposed to try once only?  My guess is that we could try 
more than once given how the loop runs; i.e. we may loop multiple times in same 
millisecond.. you might want to exit loop if timeout is zero.

What happens if a client comes in during this time?  It will crash out 
immediately because no base node?

Thanks Matteo.

> RegionServer doesn't retry to check if base node is available
> -
>
> Key: HBASE-5666
> URL: https://issues.apache.org/jira/browse/HBASE-5666
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver, zookeeper
>Affects Versions: 0.92.1, 0.94.0, 0.96.0
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
> Attachments: HBASE-5666-v1.patch, HBASE-5666-v2.patch, 
> HBASE-5666-v3.patch, HBASE-5666-v4.patch, HBASE-5666-v5.patch, 
> HBASE-5666-v6.patch, hbase-1-regionserver.log, hbase-2-regionserver.log, 
> hbase-3-regionserver.log, hbase-master.log, hbase-regionserver.log, 
> hbase-zookeeper.log
>
>
> I've a script that starts hbase and a couple of region servers in distributed 
> mode (hbase.cluster.distributed = true)
> {code}
> $HBASE_HOME/bin/start-hbase.sh
> $HBASE_HOME/bin/local-regionservers.sh start 1 2 3
> {code}
> but the region servers are not able to start...
> It seems that during the RS start the the znode is still not available, and 
> HRegionServer.initializeZooKeeper() check just once if the base not is 
> available.
> {code}
> 2012-03-28 21:54:05,013 INFO 
> org.apache.hadoop.hbase.regionserver.HRegionServer: STOPPED: Check the value 
> configured in 'zookeeper.znode.parent'. There could be a mismatch with the 
> one configured in the master.
> 2012-03-28 21:54:08,598 FATAL 
> org.apache.hadoop.hbase.regionserver.HRegionServer: ABORTING region server 
> localhost,60202,133296824: Initialization of RS failed.  Hence aborting 
> RS.
> java.io.IOException: Received the shutdown message while waiting.
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.blockAndCheckIfStopped(HRegionServer.java:626)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.initializeZooKeeper(HRegionServer.java:596)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:558)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:672)
>   at java.lang.Thread.run(Thread.java:662)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5748) Enable lib directory in jar file for coprocessor

[Takuya Ueshin (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250268#comment-13250268
 ] 

Takuya Ueshin commented on HBASE-5748:
--

Thank you very much!

> Enable lib directory in jar file for coprocessor
> 
>
> Key: HBASE-5748
> URL: https://issues.apache.org/jira/browse/HBASE-5748
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors
>Affects Versions: 0.92.1, 0.94.0
>Reporter: Takuya Ueshin
>Assignee: Takuya Ueshin
> Fix For: 0.92.2, 0.94.0
>
> Attachments: HBASE-5748.patch
>
>
> Hadoop MapReduce job can use external libraries in 'lib' directory in the 
> job.jar file.
> It is useful that jar files for coprocessor can use external libraries in the 
> same way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5740) Compaction interruption may be due to balacing

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250262#comment-13250262
 ] 

stack commented on HBASE-5740:
--

The first change is fine -- saying it was interrupted rather than it was 
stopped by user.

The second change is not so clean; says user or system.  Maybe this should be 
generic too... just 'compaction interrupted'?

If you are good w/ the latter I can make this change on commit.

> Compaction interruption may be due to balacing
> --
>
> Key: HBASE-5740
> URL: https://issues.apache.org/jira/browse/HBASE-5740
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.96.0
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
>Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: hbase-5740.patch, hbase-5740_v2.patch
>
>
> Currently, the log shows 
> Aborting compaction of store LOG in region  because user requested stop.
> But it is actually because of balancing.
> Currently, there is no way to figure out who closed the region.  So it is 
> better to change the message to say it is because of user, or balancing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5748) Enable lib directory in jar file for coprocessor

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5748:
-

   Resolution: Fixed
Fix Version/s: (was: 0.96.0)
   0.92.2
   Status: Resolved  (was: Patch Available)

Committed to 0.92, 0.94 and trunk.  Thanks for the patch Takuya.

> Enable lib directory in jar file for coprocessor
> 
>
> Key: HBASE-5748
> URL: https://issues.apache.org/jira/browse/HBASE-5748
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors
>Affects Versions: 0.92.1, 0.94.0
>Reporter: Takuya Ueshin
>Assignee: Takuya Ueshin
> Fix For: 0.92.2, 0.94.0
>
> Attachments: HBASE-5748.patch
>
>
> Hadoop MapReduce job can use external libraries in 'lib' directory in the 
> job.jar file.
> It is useful that jar files for coprocessor can use external libraries in the 
> same way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5749) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5749:
-

Status: Patch Available  (was: Open)

> "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
> heapsize
> --
>
> Key: HBASE-5749
> URL: https://issues.apache.org/jira/browse/HBASE-5749
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: heapsize.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5752) Blank line in SPLITS_FILE causes Master to crash

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250230#comment-13250230
 ] 

stack commented on HBASE-5752:
--

Something like this Jeremy?

{code}
Index: src/main/ruby/hbase/admin.rb
===
--- src/main/ruby/hbase/admin.rb(revision 1311378)
+++ src/main/ruby/hbase/admin.rb(working copy)
@@ -194,7 +194,9 @@
   end
   arg[SPLITS] = []
   File.foreach(arg[SPLITS_FILE]) do |line|
-arg[SPLITS].push(line.strip())
+stripped = line.strip()
+next unless stripped.length > 0
+arg[SPLITS].push(stripped)
   end
 end
{code}

I've not tried it.

> Blank line in SPLITS_FILE causes Master to crash
> 
>
> Key: HBASE-5752
> URL: https://issues.apache.org/jira/browse/HBASE-5752
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 0.92.1
>Reporter: Jeremy Carroll
>Priority: Minor
> Attachments: test.txt
>
>
> When creating a new table with the hbase shell, and specifying a SPLITS_FILE 
> with a blank line in it will cause the master to crash.
> Uploading a sample splits file, here are the commands to test the split.
> create 'testTable', {NAME => 'a', BLOOMFILTER => 'NONE', REPLICATION_SCOPE => 
> '0', COMPRESSION => 'NONE', MIN_VERSIONS => '3', TTL => '2147483647', 
> BLOCKSIZE => '65536', IN_MEMORY => 'false', BLOCKCACHE => 'true'}, 
> {SPLITS_FILE => '/tmp/test.txt'}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5753) [book] adding listdata schema design case-study to Use Cases chapter

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250223#comment-13250223
 ] 

Hudson commented on HBASE-5753:
---

Integrated in HBase-TRUNK #2732 (See 
[https://builds.apache.org/job/HBase-TRUNK/2732/])
hbase-5753.xml - adding schema design case study in Case Studies chapter 
(Revision 1311411)

 Result = SUCCESS

> [book] adding listdata schema design case-study to Use Cases chapter
> 
>
> Key: HBASE-5753
> URL: https://issues.apache.org/jira/browse/HBASE-5753
> Project: HBase
>  Issue Type: Improvement
>Reporter: Doug Meil
>Assignee: Doug Meil
>Priority: Minor
> Attachments: case_studies_hbase_5753.xml.patch
>
>
> case_studies.xml
> * Ported a discussion from the dist-list about designing a schema to support 
> list data t 
> * created Schema Design and Performance/Troubleshooting sections in this 
> chapter (previously all the entries were perf/trouble related)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5754) data lost with gora continuous ingest test (goraci)

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250195#comment-13250195
 ] 

stack commented on HBASE-5754:
--

Let me take this one.  I've been playing w/ goraci.  I did 25M for my first 
test and that seemed to work.  Let me do the bigger numbers.  Thanks Eric.

> data lost with gora continuous ingest test (goraci)
> ---
>
> Key: HBASE-5754
> URL: https://issues.apache.org/jira/browse/HBASE-5754
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
> Environment: 10 node test cluster
>Reporter: Eric Newton
>Assignee: stack
>
> Keith Turner re-wrote the accumulo continuous ingest test using gora, which 
> has both hbase and accumulo back-ends.
> I put a billion entries into HBase, and ran the Verify map/reduce job.  The 
> verification failed because about 21K entries were missing.  The goraci 
> [README|https://github.com/keith-turner/goraci] explains the test, and how it 
> detects missing data.
> I re-ran the test with 100 million entries, and it verified successfully.  
> Both of the times I tested using a billion entries, the verification failed.
> If I run the verification step twice, the results are consistent, so the 
> problem is
> probably not on the verify step.
> Here's the versions of the various packages:
> ||package||version||
> |hadoop|0.20.205.0|
> |hbase|0.92.1|
> |gora|http://svn.apache.org/repos/asf/gora/trunk r1311277|
> |goraci|https://github.com/ericnewton/goraci  tagged 2012-04-08|
> The change I made to goraci was to configure it for hbase and to allow it to 
> build properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-5754) data lost with gora continuous ingest test (goraci)

[stack (Assigned) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack reassigned HBASE-5754:


Assignee: stack

> data lost with gora continuous ingest test (goraci)
> ---
>
> Key: HBASE-5754
> URL: https://issues.apache.org/jira/browse/HBASE-5754
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
> Environment: 10 node test cluster
>Reporter: Eric Newton
>Assignee: stack
>
> Keith Turner re-wrote the accumulo continuous ingest test using gora, which 
> has both hbase and accumulo back-ends.
> I put a billion entries into HBase, and ran the Verify map/reduce job.  The 
> verification failed because about 21K entries were missing.  The goraci 
> [README|https://github.com/keith-turner/goraci] explains the test, and how it 
> detects missing data.
> I re-ran the test with 100 million entries, and it verified successfully.  
> Both of the times I tested using a billion entries, the verification failed.
> If I run the verification step twice, the results are consistent, so the 
> problem is
> probably not on the verify step.
> Here's the versions of the various packages:
> ||package||version||
> |hadoop|0.20.205.0|
> |hbase|0.92.1|
> |gora|http://svn.apache.org/repos/asf/gora/trunk r1311277|
> |goraci|https://github.com/ericnewton/goraci  tagged 2012-04-08|
> The change I made to goraci was to configure it for hbase and to allow it to 
> build properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5754) data lost with gora continuous ingest test (goraci)

[Eric Newton (Created) (JIRA)]

data lost with gora continuous ingest test (goraci)
---

 Key: HBASE-5754
 URL: https://issues.apache.org/jira/browse/HBASE-5754
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.92.1
 Environment: 10 node test cluster
Reporter: Eric Newton


Keith Turner re-wrote the accumulo continuous ingest test using gora, which has 
both hbase and accumulo back-ends.

I put a billion entries into HBase, and ran the Verify map/reduce job.  The 
verification failed because about 21K entries were missing.  The goraci 
[README|https://github.com/keith-turner/goraci] explains the test, and how it 
detects missing data.

I re-ran the test with 100 million entries, and it verified successfully.  
Both of the times I tested using a billion entries, the verification failed.
If I run the verification step twice, the results are consistent, so the 
problem is
probably not on the verify step.

Here's the versions of the various packages:

||package||version||
|hadoop|0.20.205.0|
|hbase|0.92.1|
|gora|http://svn.apache.org/repos/asf/gora/trunk r1311277|
|goraci|https://github.com/ericnewton/goraci  tagged 2012-04-08|

The change I made to goraci was to configure it for hbase and to allow it to 
build properly.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5752) Blank line in SPLITS_FILE causes Master to crash

[Jeremy Carroll (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250174#comment-13250174
 ] 

Jeremy Carroll commented on HBASE-5752:
---

Here is the ZooKeeper Exception
http://www.pastie.org/3757155

Here is the Master Exception
http://www.pastie.org/3757146

Full master exception output
http://www.pastie.org/3756831

> Blank line in SPLITS_FILE causes Master to crash
> 
>
> Key: HBASE-5752
> URL: https://issues.apache.org/jira/browse/HBASE-5752
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 0.92.1
>Reporter: Jeremy Carroll
>Priority: Minor
> Attachments: test.txt
>
>
> When creating a new table with the hbase shell, and specifying a SPLITS_FILE 
> with a blank line in it will cause the master to crash.
> Uploading a sample splits file, here are the commands to test the split.
> create 'testTable', {NAME => 'a', BLOOMFILTER => 'NONE', REPLICATION_SCOPE => 
> '0', COMPRESSION => 'NONE', MIN_VERSIONS => '3', TTL => '2147483647', 
> BLOCKSIZE => '65536', IN_MEMORY => 'false', BLOCKCACHE => 'true'}, 
> {SPLITS_FILE => '/tmp/test.txt'}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5752) Blank line in SPLITS_FILE causes Master to crash

[Jeremy Carroll (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Carroll updated HBASE-5752:
--

Attachment: test.txt

> Blank line in SPLITS_FILE causes Master to crash
> 
>
> Key: HBASE-5752
> URL: https://issues.apache.org/jira/browse/HBASE-5752
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 0.92.1
>Reporter: Jeremy Carroll
>Priority: Minor
> Attachments: test.txt
>
>
> When creating a new table with the hbase shell, and specifying a SPLITS_FILE 
> with a blank line in it will cause the master to crash.
> Uploading a sample splits file, here are the commands to test the split.
> create 'testTable', {NAME => 'a', BLOOMFILTER => 'NONE', REPLICATION_SCOPE => 
> '0', COMPRESSION => 'NONE', MIN_VERSIONS => '3', TTL => '2147483647', 
> BLOCKSIZE => '65536', IN_MEMORY => 'false', BLOCKCACHE => 'true'}, 
> {SPLITS_FILE => '/tmp/test.txt'}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4336) Convert source tree into maven modules

[Jesse Yates (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250170#comment-13250170
 ] 

Jesse Yates commented on HBASE-4336:


bq. client module with the minimum set of dependencies would a big thing

Yup, that was part of the my original plan. Its just painful to do. :)

Agree that follow on tickets would/should be useful for this. My original 
intention with this patch to do it wholesale (master, region, client, etc.), 
but I think we can get away with just a couple small ones (see my above 
comment) without too much work.

bq. BC = backwards compatibility. 

Still think my argument holds above for preserving this as well.  

> Convert source tree into maven modules
> --
>
> Key: HBASE-4336
> URL: https://issues.apache.org/jira/browse/HBASE-4336
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Gary Helmling
>Priority: Critical
> Fix For: 0.96.0
>
>
> When we originally converted the build to maven we had a single "core" module 
> defined, but later reverted this to a module-less build for the sake of 
> simplicity.
> It now looks like it's time to re-address this, as we have an actual need for 
> modules to:
> * provide a trimmed down "client" library that applications can make use of
> * more cleanly support building against different versions of Hadoop, in 
> place of some of the reflection machinations currently required
> * incorporate the secure RPC engine that depends on some secure Hadoop classes
> I propose we start simply by refactoring into two initial modules:
> * core - common classes and utilities, and client-side code and interfaces
> * server - master and region server implementations and supporting code
> This would also lay the groundwork for incorporating the HBase security 
> features that have been developed.  Once the module structure is in place, 
> security-related features could then be incorporated into a third module -- 
> "security" -- after normal review and approval.  The security module could 
> then depend on secure Hadoop, without modifying the dependencies of the rest 
> of the HBase code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2223) Handle 10min+ network partitions between clusters

[Himanshu Vashishtha (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250160#comment-13250160
 ] 

Himanshu Vashishtha commented on HBASE-2223:


I was skimming through the patch; and it looks like its not there in the 
current trunk? 
Will be great if anyone can provide its current status, or follow up jiras?

> Handle 10min+ network partitions between clusters
> -
>
> Key: HBASE-2223
> URL: https://issues.apache.org/jira/browse/HBASE-2223
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jean-Daniel Cryans
>Assignee: Jean-Daniel Cryans
> Fix For: 0.90.0
>
> Attachments: HBASE-2223.patch
>
>
> We need a nice way of handling long network partitions without impacting a 
> master cluster (which pushes the data). Currently it will just retry over and 
> over again.
> I think we could:
>  - Stop replication to a slave cluster if it didn't respond for more than 10 
> minutes
>  - Keep track of the duration of the partition
>  - When the slave cluster comes back, initiate a MR job like HBASE-2221 
> Maybe we want less than 10 minutes, maybe we want this to be all automatic or 
> just the first 2 parts. Discuss.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5744) Thrift server metrics should be long instead of int

[Mikhail Bautin (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Bautin updated HBASE-5744:
--

Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committed to trunk.

> Thrift server metrics should be long instead of int
> ---
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch, 
> D2685.3.patch, 
> jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make 
> latencies long instead of int everywhere.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250140#comment-13250140
 ] 

Zhihong Yu commented on HBASE-5727:
---

If there is no objection, I will integrate the addendum in 3 hours.

> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch, 
> AccessController.diff
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5753) [book] adding listdata schema design case-study to Use Cases chapter

[Doug Meil (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5753:
-

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> [book] adding listdata schema design case-study to Use Cases chapter
> 
>
> Key: HBASE-5753
> URL: https://issues.apache.org/jira/browse/HBASE-5753
> Project: HBase
>  Issue Type: Improvement
>Reporter: Doug Meil
>Assignee: Doug Meil
>Priority: Minor
> Attachments: case_studies_hbase_5753.xml.patch
>
>
> case_studies.xml
> * Ported a discussion from the dist-list about designing a schema to support 
> list data t 
> * created Schema Design and Performance/Troubleshooting sections in this 
> chapter (previously all the entries were perf/trouble related)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5753) [book] adding listdata schema design case-study to Use Cases chapter

[Doug Meil (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5753:
-

Status: Patch Available  (was: Open)

> [book] adding listdata schema design case-study to Use Cases chapter
> 
>
> Key: HBASE-5753
> URL: https://issues.apache.org/jira/browse/HBASE-5753
> Project: HBase
>  Issue Type: Improvement
>Reporter: Doug Meil
>Assignee: Doug Meil
>Priority: Minor
> Attachments: case_studies_hbase_5753.xml.patch
>
>
> case_studies.xml
> * Ported a discussion from the dist-list about designing a schema to support 
> list data t 
> * created Schema Design and Performance/Troubleshooting sections in this 
> chapter (previously all the entries were perf/trouble related)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5753) [book] adding listdata schema design case-study to Use Cases chapter

[Doug Meil (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5753:
-

Description: 
case_studies.xml
* Ported a discussion from the dist-list about designing a schema to support 
list data t 
* created Schema Design and Performance/Troubleshooting sections in this 
chapter (previously all the entries were perf/trouble related)

  was:
Ported a discussion from the dist-list about designing a schema to support list 
data.
 


> [book] adding listdata schema design case-study to Use Cases chapter
> 
>
> Key: HBASE-5753
> URL: https://issues.apache.org/jira/browse/HBASE-5753
> Project: HBase
>  Issue Type: Improvement
>Reporter: Doug Meil
>Assignee: Doug Meil
>Priority: Minor
> Attachments: case_studies_hbase_5753.xml.patch
>
>
> case_studies.xml
> * Ported a discussion from the dist-list about designing a schema to support 
> list data t 
> * created Schema Design and Performance/Troubleshooting sections in this 
> chapter (previously all the entries were perf/trouble related)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5753) [book] adding listdata schema design case-study to Use Cases chapter

[Doug Meil (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5753:
-

Attachment: case_studies_hbase_5753.xml.patch

> [book] adding listdata schema design case-study to Use Cases chapter
> 
>
> Key: HBASE-5753
> URL: https://issues.apache.org/jira/browse/HBASE-5753
> Project: HBase
>  Issue Type: Improvement
>Reporter: Doug Meil
>Assignee: Doug Meil
>Priority: Minor
> Attachments: case_studies_hbase_5753.xml.patch
>
>
> case_studies.xml
> * Ported a discussion from the dist-list about designing a schema to support 
> list data t 
> * created Schema Design and Performance/Troubleshooting sections in this 
> chapter (previously all the entries were perf/trouble related)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5753) [book] adding listdata schema design case-study to Use Cases chapter

[Doug Meil (Created) (JIRA)]

[book] adding listdata schema design case-study to Use Cases chapter


 Key: HBASE-5753
 URL: https://issues.apache.org/jira/browse/HBASE-5753
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor


Ported a discussion from the dist-list about designing a schema to support list 
data.
 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5752) Blank line in SPLITS_FILE causes Master to crash

[Jeremy Carroll (Created) (JIRA)]

Blank line in SPLITS_FILE causes Master to crash


 Key: HBASE-5752
 URL: https://issues.apache.org/jira/browse/HBASE-5752
 Project: HBase
  Issue Type: Bug
  Components: shell
Affects Versions: 0.92.1
Reporter: Jeremy Carroll
Priority: Minor


When creating a new table with the hbase shell, and specifying a SPLITS_FILE 
with a blank line in it will cause the master to crash.

Uploading a sample splits file, here are the commands to test the split.

create 'testTable', {NAME => 'a', BLOOMFILTER => 'NONE', REPLICATION_SCOPE => 
'0', COMPRESSION => 'NONE', MIN_VERSIONS => '3', TTL => '2147483647', BLOCKSIZE 
=> '65536', IN_MEMORY => 'false', BLOCKCACHE => 'true'}, {SPLITS_FILE => 
'/tmp/test.txt'}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5719) Enhance hbck to sideline overlapped mega regions

[jirapos...@reviews.apache.org (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250092#comment-13250092
 ] 

jirapos...@reviews.apache.org commented on HBASE-5719:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4649/
---

(Updated 2012-04-09 19:27:53.361210)


Review request for hbase and jmhsieh.


Changes
---

Addressed Jon's second review comments.


Summary
---

Make it configurable to sideline some regions in big overlapped groups which 
hbck doesn't handle currently.

The regions chose to sideline are those which overlap with most other regions.


This addresses bug HBASE-5719.
https://issues.apache.org/jira/browse/HBASE-5719


Diffs (updated)
-

  src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 
  src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd 
  src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java 
ac3b225 

Diff: https://reviews.apache.org/r/4649/diff


Testing
---

mvn -PlocalTests -Dtest=TestHBaseFsck* clean test

Also tested in real system to fix inconsistencies.


Thanks,

Jimmy



> Enhance hbck to sideline overlapped mega regions
> 
>
> Key: HBASE-5719
> URL: https://issues.apache.org/jira/browse/HBASE-5719
> Project: HBase
>  Issue Type: New Feature
>  Components: hbck
>Affects Versions: 0.94.0, 0.96.0
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5719.patch
>
>
> If there are too many regions in one overlapped group (by default, more than 
> 10), hbck currently doesn't merge them since it takes time.
> In this case, we can sideline some regions in the group and break the 
> overlapping to fix the inconsistency.  Later on, sidelined regions can be 
> bulk loaded manually.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5719) Enhance hbck to sideline overlapped mega regions

[jirapos...@reviews.apache.org (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250087#comment-13250087
 ] 

jirapos...@reviews.apache.org commented on HBASE-5719:
--



bq.  On 2012-04-09 18:20:11, jmhsieh wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1869
bq.  > 

bq.  >
bq.  > Maybe this one is at info level?

Will change to info level.


bq.  On 2012-04-09 18:20:11, jmhsieh wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 2828
bq.  > 

bq.  >
bq.  > nit: typo (old was correct)

Changed it back. It must be because the mouse moved when I was typing 
something.  I didn't remember I changed it. :)


bq.  On 2012-04-09 18:20:11, jmhsieh wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 2895
bq.  > 

bq.  >
bq.  > Is this  per group or globally? please make it clear in usage

It is per group.  Will fix it.


bq.  On 2012-04-09 18:20:11, jmhsieh wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 2981
bq.  > 

bq.  >
bq.  > nit: should be like previous -maxMerge's comments.

Will fix it.


bq.  On 2012-04-09 18:20:11, jmhsieh wrote:
bq.  > 
src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java, line 
360
bq.  > 
bq.  >
bq.  > nit: it would easer to read if this was called ai, the next ae, and 
the one after that ac.  
bq.  > 
bq.  > Also would help if you put the expected overlap count in comments!

Sure.


bq.  On 2012-04-09 18:20:11, jmhsieh wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, 
line 212
bq.  > 
bq.  >
bq.  > what is the intuition here?

Added comment


bq.  On 2012-04-09 18:20:11, jmhsieh wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, 
line 189
bq.  > 
bq.  >
bq.  > add comment?
bq.  > 
bq.  > We always overlap with ourselves -- which is why > 1 is the 
condition below..

Will do.


bq.  On 2012-04-09 18:20:11, jmhsieh wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, 
line 178
bq.  > 
bq.  >
bq.  > add comment: calculates the # of overlaps for each region and 
populates rangeOverlapMap

Sure


bq.  On 2012-04-09 18:20:11, jmhsieh wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, 
line 177
bq.  > 
bq.  >
bq.  > Add comment about structure contents.  something like: Integer key 
is overlap count and List is regions that have that many overlaps.
bq.  > maybe rename to overlapRangeMap?

Sure.


bq.  On 2012-04-09 18:20:11, jmhsieh wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, 
line 171
bq.  > 
bq.  >
bq.  > To find?  Would returning a sort make sense?  if there are no 
overlaps will this return the specified number (or less?)
bq.  > 
bq.  > Could this return several regions that now leave holes?
bq.  > 
bq.  > nit: It might make testing clearer to return the overlapCount -> 
regions map and check that.

Added comment.


- Jimmy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4649/#review6764
---


On 2012-04-06 18:27:34, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4649/
bq.  ---
bq.  
bq.  (Updated 2012-04-06 18:27:34)
bq.  
bq.  
bq.  Review request for hbase and jmhsieh.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Make it configurable to sideline some regions in big overlapped groups 
which hbck doesn't handle currently.
bq.  
bq.  The regions chose to sideline are those which overlap with most other 
regions.
bq.  
bq.  
bq.  This addresses bug HBASE-5719.
bq.  https://issues.apache.org/jira/browse/HBASE-5719
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.jav

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250077#comment-13250077
 ] 

stack commented on HBASE-5727:
--

Patch looks right to me; its providing the region context configuration making 
access determination to a particular region.

> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch, 
> AccessController.diff
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5750) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250074#comment-13250074
 ] 

Hadoop QA commented on HBASE-5750:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12521976/heapsize.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1456//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1456//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1456//console

This message is automatically generated.

> "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
> heapsize
> --
>
> Key: HBASE-5750
> URL: https://issues.apache.org/jira/browse/HBASE-5750
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: heapsize.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4336) Convert source tree into maven modules

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250067#comment-13250067
 ] 

stack commented on HBASE-4336:
--

Following on from Matt, i see this issue in a new light of late as an aid to 
untangling our hairball.  I propose that all thats needed to close this issue 
is a modularization that has one module only in it and that module is 
hbase-common.  In subsequent issues we can break out other modules; 
compressors, hregion, client, security, server, leather or vinyl, etc.

> Convert source tree into maven modules
> --
>
> Key: HBASE-4336
> URL: https://issues.apache.org/jira/browse/HBASE-4336
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Gary Helmling
>Priority: Critical
> Fix For: 0.96.0
>
>
> When we originally converted the build to maven we had a single "core" module 
> defined, but later reverted this to a module-less build for the sake of 
> simplicity.
> It now looks like it's time to re-address this, as we have an actual need for 
> modules to:
> * provide a trimmed down "client" library that applications can make use of
> * more cleanly support building against different versions of Hadoop, in 
> place of some of the reflection machinations currently required
> * incorporate the secure RPC engine that depends on some secure Hadoop classes
> I propose we start simply by refactoring into two initial modules:
> * core - common classes and utilities, and client-side code and interfaces
> * server - master and region server implementations and supporting code
> This would also lay the groundwork for incorporating the HBase security 
> features that have been developed.  Once the module structure is in place, 
> security-related features could then be incorporated into a third module -- 
> "security" -- after normal review and approval.  The security module could 
> then depend on secure Hadoop, without modifying the dependencies of the rest 
> of the HBase code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5615) the master never does balance because of balancing the parent region

[Lars Hofhansl (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250069#comment-13250069
 ] 

Lars Hofhansl commented on HBASE-5615:
--

Thanks Ram... I'll hold up 0.94 for this (unless you think that unnecessary).

> the master never does balance because of balancing the parent region
> 
>
> Key: HBASE-5615
> URL: https://issues.apache.org/jira/browse/HBASE-5615
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.7
>Reporter: xufeng
>Assignee: xufeng
>Priority: Critical
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: 5615-trunk.txt, HBASE-5615-90.patch, HBASE-5615.patch, 
> NoPatched-surefire-report-5615-90.html, Patched_surefire-report-5615-90.html
>
>
> the master never do balance becauseof when master do rebuildUserRegions()，it 
> will add the parent region into  AssignmentManager#servers,
> if balancer let the parent region to move,the parent will in RIT forever.thus 
> balance will never be executed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4336) Convert source tree into maven modules

[Enis Soztutar (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250066#comment-13250066
 ] 

Enis Soztutar commented on HBASE-4336:
--

bq. BC
BC = backwards compatibility. Sorry for the confusion. I assume that for 
separating the client side, we have to make some changes to core client APIs 
(like splitting the KeyValue, Bytes, ZK classes, etc). 

> Convert source tree into maven modules
> --
>
> Key: HBASE-4336
> URL: https://issues.apache.org/jira/browse/HBASE-4336
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Gary Helmling
>Priority: Critical
> Fix For: 0.96.0
>
>
> When we originally converted the build to maven we had a single "core" module 
> defined, but later reverted this to a module-less build for the sake of 
> simplicity.
> It now looks like it's time to re-address this, as we have an actual need for 
> modules to:
> * provide a trimmed down "client" library that applications can make use of
> * more cleanly support building against different versions of Hadoop, in 
> place of some of the reflection machinations currently required
> * incorporate the secure RPC engine that depends on some secure Hadoop classes
> I propose we start simply by refactoring into two initial modules:
> * core - common classes and utilities, and client-side code and interfaces
> * server - master and region server implementations and supporting code
> This would also lay the groundwork for incorporating the HBase security 
> features that have been developed.  Once the module structure is in place, 
> security-related features could then be incorporated into a third module -- 
> "security" -- after normal review and approval.  The security module could 
> then depend on secure Hadoop, without modifying the dependencies of the rest 
> of the HBase code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5751) "hbase master stop" does not bring down backup masters

[Lars Hofhansl (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250056#comment-13250056
 ] 

Lars Hofhansl commented on HBASE-5751:
--

Tail of discussion from parent:

stack added a comment - 06/Apr/12 15:03

This seems to have broken 0.90 builds. Can we revert from 0.90 trunk till 
fixed. See here: https://builds.apache.org/view/G-L/view/HBase/job/hbase-0.90/ 
Build #458 is where it got committed and thereafter the build fails rolling the 
wal test.


David S. Wang added a comment - 06/Apr/12 15:18

Greg is out of town for the next week or so ... IMHO if it's breaking 0.90, we 
should revert for now and Greg can look at it when he gets back.


Zhihong Yu added a comment - 06/Apr/12 16:11

TestLogRolling hangs in 0.90


Jonathan Hsieh added a comment - 06/Apr/12 16:21

I'll revert the 0.90 version. Sorry about this fellas.


Lars Hofhansl added a comment - 09/Apr/12 03:31

So from the discussion the test is only a problem in 0.90? Do we know why this 
is?
Asking because we're close to another RC attempt for 0.94.0.


Jonathan Hsieh added a comment - 09/Apr/12 03:37

The issue is apparently only in 0.90. How about we close this issue for 
0.92/0.94/trunk and create a follow on issue for 0.90? This will unblock this 
for 0.94 and Greg can address this when he gets back.


> "hbase master stop" does not bring down backup masters
> --
>
> Key: HBASE-5751
> URL: https://issues.apache.org/jira/browse/HBASE-5751
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Lars Hofhansl
>Assignee: Gregory Chanan
> Fix For: 0.90.7
>
>
> Carry forward the discussion from parent for 0.90

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[Zhihong Yu (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu updated HBASE-5727:
--

Attachment: AccessController.diff

The attached patch allows TestRowProcessorEndpoint to pass.

> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch, 
> AccessController.diff
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-5213) "hbase master stop" does not bring down backup masters

[Lars Hofhansl (Resolved) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl resolved HBASE-5213.
--

Resolution: Fixed

Marking this one as fixed. Created sub-issue for 0.90 discussion.

> "hbase master stop" does not bring down backup masters
> --
>
> Key: HBASE-5213
> URL: https://issues.apache.org/jira/browse/HBASE-5213
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
>Reporter: Gregory Chanan
>Assignee: Gregory Chanan
>Priority: Minor
> Fix For: 0.92.2, 0.94.0, 0.96.0
>
> Attachments: 5213.jstack, HBASE-5213-v0-trunk.patch, 
> HBASE-5213-v1-trunk.patch, HBASE-5213-v2-90.patch, HBASE-5213-v2-92.patch, 
> HBASE-5213-v2-trunk.patch
>
>
> Typing "hbase master stop" produces the following message:
> "stop   Start cluster shutdown; Master signals RegionServer shutdown"
> It seems like backup masters should be considered part of the cluster, but 
> they are not brought down by "hbase master stop".
> "stop-hbase.sh" does correctly bring down the backup masters.
> The same behavior is observed when a client app makes use of the client API 
> HBaseAdmin.shutdown() 
> http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html#shutdown()
>  -- this isn't too surprising since I think "hbase master stop" just calls 
> this API.
> It seems like HBASE-1448 address this; perhaps there was a regression?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5213) "hbase master stop" does not bring down backup masters

[Lars Hofhansl (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-5213:
-

Fix Version/s: (was: 0.90.7)

> "hbase master stop" does not bring down backup masters
> --
>
> Key: HBASE-5213
> URL: https://issues.apache.org/jira/browse/HBASE-5213
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
>Reporter: Gregory Chanan
>Assignee: Gregory Chanan
>Priority: Minor
> Fix For: 0.92.2, 0.94.0, 0.96.0
>
> Attachments: 5213.jstack, HBASE-5213-v0-trunk.patch, 
> HBASE-5213-v1-trunk.patch, HBASE-5213-v2-90.patch, HBASE-5213-v2-92.patch, 
> HBASE-5213-v2-trunk.patch
>
>
> Typing "hbase master stop" produces the following message:
> "stop   Start cluster shutdown; Master signals RegionServer shutdown"
> It seems like backup masters should be considered part of the cluster, but 
> they are not brought down by "hbase master stop".
> "stop-hbase.sh" does correctly bring down the backup masters.
> The same behavior is observed when a client app makes use of the client API 
> HBaseAdmin.shutdown() 
> http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html#shutdown()
>  -- this isn't too surprising since I think "hbase master stop" just calls 
> this API.
> It seems like HBASE-1448 address this; perhaps there was a regression?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-5751) "hbase master stop" does not bring down backup masters

[Lars Hofhansl (Assigned) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl reassigned HBASE-5751:


Assignee: Gregory Chanan

> "hbase master stop" does not bring down backup masters
> --
>
> Key: HBASE-5751
> URL: https://issues.apache.org/jira/browse/HBASE-5751
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Lars Hofhansl
>Assignee: Gregory Chanan
> Fix For: 0.90.7
>
>
> Carry forward the discussion from parent for 0.90

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5751) "hbase master stop" does not bring down backup masters

[Lars Hofhansl (Created) (JIRA)]

"hbase master stop" does not bring down backup masters
--

 Key: HBASE-5751
 URL: https://issues.apache.org/jira/browse/HBASE-5751
 Project: HBase
  Issue Type: Sub-task
Reporter: Lars Hofhansl
 Fix For: 0.90.7


Carry forward the discussion from parent for 0.90

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4336) Convert source tree into maven modules

[Matt Corgan (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250044#comment-13250044
 ] 

Matt Corgan commented on HBASE-4336:


Sometimes helps to think of modules as things that can be pulled out of the 
main project and turned into "black boxes" that just work.  After you pull them 
out, the main project becomes simpler.

Eventually, I think the HRegion is a good candidate for becoming a module.  
It's really a database on its own which will inevitably grow more and more 
complex.  Then the purpose of the master and region servers are to coordinate 
and host bunches of HRegions without worrying what's going on inside the region.

> Convert source tree into maven modules
> --
>
> Key: HBASE-4336
> URL: https://issues.apache.org/jira/browse/HBASE-4336
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Gary Helmling
>Priority: Critical
> Fix For: 0.96.0
>
>
> When we originally converted the build to maven we had a single "core" module 
> defined, but later reverted this to a module-less build for the sake of 
> simplicity.
> It now looks like it's time to re-address this, as we have an actual need for 
> modules to:
> * provide a trimmed down "client" library that applications can make use of
> * more cleanly support building against different versions of Hadoop, in 
> place of some of the reflection machinations currently required
> * incorporate the secure RPC engine that depends on some secure Hadoop classes
> I propose we start simply by refactoring into two initial modules:
> * core - common classes and utilities, and client-side code and interfaces
> * server - master and region server implementations and supporting code
> This would also lay the groundwork for incorporating the HBase security 
> features that have been developed.  Once the module structure is in place, 
> security-related features could then be incorporated into a third module -- 
> "security" -- after normal review and approval.  The security module could 
> then depend on secure Hadoop, without modifying the dependencies of the rest 
> of the HBase code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4336) Convert source tree into maven modules

[Alejandro Abdelnur (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250038#comment-13250038
 ] 

Alejandro Abdelnur commented on HBASE-4336:
---

@Jeese, having a client module with the minimum set of dependencies would a big 
thing for apps built on top of hbase. thxs

> Convert source tree into maven modules
> --
>
> Key: HBASE-4336
> URL: https://issues.apache.org/jira/browse/HBASE-4336
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Gary Helmling
>Priority: Critical
> Fix For: 0.96.0
>
>
> When we originally converted the build to maven we had a single "core" module 
> defined, but later reverted this to a module-less build for the sake of 
> simplicity.
> It now looks like it's time to re-address this, as we have an actual need for 
> modules to:
> * provide a trimmed down "client" library that applications can make use of
> * more cleanly support building against different versions of Hadoop, in 
> place of some of the reflection machinations currently required
> * incorporate the secure RPC engine that depends on some secure Hadoop classes
> I propose we start simply by refactoring into two initial modules:
> * core - common classes and utilities, and client-side code and interfaces
> * server - master and region server implementations and supporting code
> This would also lay the groundwork for incorporating the HBase security 
> features that have been developed.  Once the module structure is in place, 
> security-related features could then be incorporated into a third module -- 
> "security" -- after normal review and approval.  The security module could 
> then depend on secure Hadoop, without modifying the dependencies of the rest 
> of the HBase code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[Andrew Purtell (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250037#comment-13250037
 ] 

Andrew Purtell commented on HBASE-5727:
---

bq. If your coprocessor uses the HRegionServer.conf, it should work the same as 
it always has. If your corprocessor uses HRegion.conf, a compilation error is 
better than a subtle runtime error that you have to spend a week hunting down.

Yes I agree. I didn't mean to imply it was an incorrect change in some way, 
just that the change had implications (obviously...)

bq. Taking a look at the security code, it looks like you want to use 
HRegionServer.conf because both calling classes seem to access global security 
data.

Yes.


> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4336) Convert source tree into maven modules

[Jesse Yates (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250031#comment-13250031
 ] 

Jesse Yates commented on HBASE-4336:


bq. BC

Build compatibility? I don't think we necessarily need to break that  - just 
because its in another module doesn't mean it changes the package. Should be 
fine :)



> Convert source tree into maven modules
> --
>
> Key: HBASE-4336
> URL: https://issues.apache.org/jira/browse/HBASE-4336
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Gary Helmling
>Priority: Critical
> Fix For: 0.96.0
>
>
> When we originally converted the build to maven we had a single "core" module 
> defined, but later reverted this to a module-less build for the sake of 
> simplicity.
> It now looks like it's time to re-address this, as we have an actual need for 
> modules to:
> * provide a trimmed down "client" library that applications can make use of
> * more cleanly support building against different versions of Hadoop, in 
> place of some of the reflection machinations currently required
> * incorporate the secure RPC engine that depends on some secure Hadoop classes
> I propose we start simply by refactoring into two initial modules:
> * core - common classes and utilities, and client-side code and interfaces
> * server - master and region server implementations and supporting code
> This would also lay the groundwork for incorporating the HBase security 
> features that have been developed.  Once the module structure is in place, 
> security-related features could then be incorporated into a third module -- 
> "security" -- after normal review and approval.  The security module could 
> then depend on secure Hadoop, without modifying the dependencies of the rest 
> of the HBase code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5750) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[Nicolas Spiegelberg (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250033#comment-13250033
 ] 

Nicolas Spiegelberg commented on HBASE-5750:


I'm interested in how this wasn't caught by Hadoop QA

> "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
> heapsize
> --
>
> Key: HBASE-5750
> URL: https://issues.apache.org/jira/browse/HBASE-5750
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: heapsize.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[Nicolas Spiegelberg (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250028#comment-13250028
 ] 

Nicolas Spiegelberg commented on HBASE-5727:


I agree with Stack, this isn't a common occurrence and is pretty trivial to fix.

getConf() was, sadly, a hack API that was public because one of the tests 
wasn't in the same namespace originally.  It shouldn't have been public because 
the config has traditionally been at a per-server granularity.  Now, with 
HBASE-5335, the per-server config object can be per-server or per-region/per-CF 
depending upon how it's used and the functionality you want.  Now: HRegion.conf 
!= HRegionServer.conf != Store.conf.  If your coprocessor uses the 
HRegionServer.conf, it should work the same as it always has.  If your 
corprocessor uses HRegion.conf, a compilation error is better than a subtle 
runtime error that you have to spend a week hunting down.  Of course, this is 
part of why we tell people they are playing with fire if they use a coprocessor 
(vs. MySQL triggers).

Taking a look at the security code, it looks like you want to use 
HRegionServer.conf because both calling classes seem to access global security 
data.  See HRegionServer.getConfiguration(), which is used in other sections of 
the AccessController class.

> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5719) Enhance hbck to sideline overlapped mega regions

[jirapos...@reviews.apache.org (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250024#comment-13250024
 ] 

jirapos...@reviews.apache.org commented on HBASE-5719:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4649/#review6764
---


Jimmy,

Looks good to me.  Mostly some questions and a little bit of of follow up to 
make it easier to read and to provide user more info.


src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java


nice catch.



src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java


Maybe this one is at info level?



src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java


nit: typo (old was correct)



src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java


Is this  per group or globally? please make it clear in usage



src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java


nit: should be like previous -maxMerge's comments. 



src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java


To find?  Would returning a sort make sense?  if there are no overlaps will 
this return the specified number (or less?)

Could this return several regions that now leave holes?

nit: It might make testing clearer to return the overlapCount -> regions 
map and check that.



src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java


Add comment about structure contents.  something like: Integer key is 
overlap count and List is regions that have that many overlaps.
maybe rename to overlapRangeMap? 



src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java


add comment: calculates the # of overlaps for each region and populates 
rangeOverlapMap



src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java


add comment?

We always overlap with ourselves -- which is why > 1 is the condition 
below.. 



src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java


what is the intuition here?



src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java


nit: it would easer to read if this was called ai, the next ae, and the one 
after that ac.  

Also would help if you put the expected overlap count in comments!


- jmhsieh


On 2012-04-06 18:27:34, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4649/
bq.  ---
bq.  
bq.  (Updated 2012-04-06 18:27:34)
bq.  
bq.  
bq.  Review request for hbase and jmhsieh.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Make it configurable to sideline some regions in big overlapped groups 
which hbck doesn't handle currently.
bq.  
bq.  The regions chose to sideline are those which overlap with most other 
regions.
bq.  
bq.  
bq.  This addresses bug HBASE-5719.
bq.  https://issues.apache.org/jira/browse/HBASE-5719
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 
bq.src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 
17678dd 
bq.
src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java 
ac3b225 
bq.  
bq.  Diff: https://reviews.apache.org/r/4649/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  mvn -PlocalTests -Dtest=TestHBaseFsck* clean test
bq.  
bq.  Also tested in real system to fix inconsistencies.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.



> Enhance hbck to sideline overlapped mega regions
> 
>
> Key: HBASE-5719
> URL: https://issues.apache.org/jira/browse/HBASE-5719
> Project: HBase
>  Issue Type: New Feature
>  Components: hbck
>Affects Versions: 0.94.0, 0.96.0
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5719.patch
>
>
> If there are too many regions in one overlapped group (by default, more than 
> 10), hbck currently doesn't merge them since it takes tim

[jira] [Commented] (HBASE-4336) Convert source tree into maven modules

[Enis Soztutar (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250023#comment-13250023
 ] 

Enis Soztutar commented on HBASE-4336:
--

bq. I think an hbase-common, hbase-security and hbase-core packages would be a 
reasonable
+1 to that. At least getting the module structure in place will help us a lot. 
After that we can gradually attack client-server separation. 

Since 0.96 is the singularity, should we make client side module a blocker? It 
seems we might have to break BC for this as well. 

> Convert source tree into maven modules
> --
>
> Key: HBASE-4336
> URL: https://issues.apache.org/jira/browse/HBASE-4336
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Gary Helmling
>Priority: Critical
> Fix For: 0.96.0
>
>
> When we originally converted the build to maven we had a single "core" module 
> defined, but later reverted this to a module-less build for the sake of 
> simplicity.
> It now looks like it's time to re-address this, as we have an actual need for 
> modules to:
> * provide a trimmed down "client" library that applications can make use of
> * more cleanly support building against different versions of Hadoop, in 
> place of some of the reflection machinations currently required
> * incorporate the secure RPC engine that depends on some secure Hadoop classes
> I propose we start simply by refactoring into two initial modules:
> * core - common classes and utilities, and client-side code and interfaces
> * server - master and region server implementations and supporting code
> This would also lay the groundwork for incorporating the HBase security 
> features that have been developed.  Once the module structure is in place, 
> security-related features could then be incorporated into a third module -- 
> "security" -- after normal review and approval.  The security module could 
> then depend on secure Hadoop, without modifying the dependencies of the rest 
> of the HBase code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4336) Convert source tree into maven modules

[Jesse Yates (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250017#comment-13250017
 ] 

Jesse Yates commented on HBASE-4336:


@stack: yeah, I think that is a bit more reasonable. Now that I'm thinking a 
little more about it, I think an hbase-common, hbase-security and hbase-core 
packages would be a reasonable (and not overly consuming) step. Sets up the 
division between things and eventually might lead to splits between client and 
server (and maybe between RS and master?). I'll try to take a look this week at 
getting something simpler up.

> Convert source tree into maven modules
> --
>
> Key: HBASE-4336
> URL: https://issues.apache.org/jira/browse/HBASE-4336
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Gary Helmling
>Priority: Critical
> Fix For: 0.96.0
>
>
> When we originally converted the build to maven we had a single "core" module 
> defined, but later reverted this to a module-less build for the sake of 
> simplicity.
> It now looks like it's time to re-address this, as we have an actual need for 
> modules to:
> * provide a trimmed down "client" library that applications can make use of
> * more cleanly support building against different versions of Hadoop, in 
> place of some of the reflection machinations currently required
> * incorporate the secure RPC engine that depends on some secure Hadoop classes
> I propose we start simply by refactoring into two initial modules:
> * core - common classes and utilities, and client-side code and interfaces
> * server - master and region server implementations and supporting code
> This would also lay the groundwork for incorporating the HBase security 
> features that have been developed.  Once the module structure is in place, 
> security-related features could then be incorporated into a third module -- 
> "security" -- after normal review and approval.  The security module could 
> then depend on secure Hadoop, without modifying the dependencies of the rest 
> of the HBase code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[Andrew Purtell (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250013#comment-13250013
 ] 

Andrew Purtell commented on HBASE-5727:
---

Removing getConf() was an action that had implications for all coprocessors; 
AccessController just exposed it by being the only thing in tree currently that 
uses it.

We can unify the build by integrating RPC security in the 0.96 RPC singularity. 
These issues with secure versus nonsecure build should be as short a 
transitional phase as possible, i.e. 0.92 and 0.94 use it to bridge Hadoop core 
differences until 0.96 specifies Hadoop 1.0 or equivalent security shims as a 
minimum requirement. 

> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5750) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5750:
-

Attachment: heapsize.txt

> "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
> heapsize
> --
>
> Key: HBASE-5750
> URL: https://issues.apache.org/jira/browse/HBASE-5750
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: heapsize.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5750) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5750:
-

Status: Patch Available  (was: Open)

> "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
> heapsize
> --
>
> Key: HBASE-5750
> URL: https://issues.apache.org/jira/browse/HBASE-5750
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: heapsize.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5749) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5749:
-

Attachment: heapsize.txt

> "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
> heapsize
> --
>
> Key: HBASE-5749
> URL: https://issues.apache.org/jira/browse/HBASE-5749
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: heapsize.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5749) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[stack (Created) (JIRA)]

"HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
heapsize
--

 Key: HBASE-5749
 URL: https://issues.apache.org/jira/browse/HBASE-5749
 Project: HBase
  Issue Type: Bug
Reporter: stack
 Attachments: heapsize.txt



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5750) "HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion heapsize

[stack (Created) (JIRA)]

"HBASE-5335 Dynamic Schema Config" broke build, missing change to HRegion 
heapsize
--

 Key: HBASE-5750
 URL: https://issues.apache.org/jira/browse/HBASE-5750
 Project: HBase
  Issue Type: Bug
Reporter: stack
 Attachments: heapsize.txt



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5744) Thrift server metrics should be long instead of int

[Phabricator (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250007#comment-13250007
 ] 

Phabricator commented on HBASE-5744:


mbautin has abandoned the revision "[jira] [HBASE-5744] Thrift server metrics 
should be long instead of int".

  Unfortunately, I committed this diff under the 89-fb differential revision 
first (D2679) and had to edit the commit message. Here is what I did:

  > svn propedit -r 1311167 --revprop svn:log

  The new commit message is as follows:

  > svn log -r1311167 https://svn.apache.org/repos/asf/hbase/trunk
  
  r1311167 | mbautin | 2012-04-09 02:00:11 -0700 (Mon, 09 Apr 2012) | 23 
lines

  [jira] [HBASE-5744] Thrift server metrics should be long instead of int

  Summary:
  As we measure our Thrift call latencies in nanoseconds, we need to make
  latencies long instead of int everywhere. There is a bug where we 
truncate a
  nanosecond latency to int, which is a problem with RPCs that take more 
than
  2.147483647 seconds to process.

  This is a trunk diff. The 89-fb version of this diff is at D2679.

  Test Plan:
  TestThriftServer is updated to test for the failure case (an RPC is 
artificially
  made to take 3 seconds). The new test case fails without the fix.

  Re-run all unit tests.

  Reviewers: stack, sc, Kannan, JIRA

  Reviewed By: sc

  Differential Revision: https://reviews.facebook.net/D2685

  If you have a git-svn checkout that got confused by this, here is how to get 
it back to a consistent state:

  git svn reset 1311166
  git svn rebase

  Sorry about the inconvenience.


REVISION DETAIL
  https://reviews.facebook.net/D2685


> Thrift server metrics should be long instead of int
> ---
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch, 
> D2685.3.patch, 
> jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make 
> latencies long instead of int everywhere.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249998#comment-13249998
 ] 

stack commented on HBASE-5727:
--

@Ted No. Thats why we run a secure build up on jenkins to find those rare cases 
where a commit on insecure breaks secure.



> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249994#comment-13249994
 ] 

Zhihong Yu commented on HBASE-5727:
---

I tend to agree with Devaraj in that HBASE-5335 should have gone through 
compilation against secure HBase.
In AccessController.java, I don't see reference to HRegionServer through which 
the config can be obtained.

> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5335) Dynamic Schema Configurations

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249991#comment-13249991
 ] 

Zhihong Yu commented on HBASE-5335:
---

@Nicolas:
Can you comment how we can resolve the compilation error seen in HBASE-5727 ?

> Dynamic Schema Configurations
> -
>
> Key: HBASE-5335
> URL: https://issues.apache.org/jira/browse/HBASE-5335
> Project: HBase
>  Issue Type: New Feature
>Reporter: Nicolas Spiegelberg
>Assignee: Nicolas Spiegelberg
>  Labels: configuration, schema
> Fix For: 0.96.0
>
> Attachments: D2247.1.patch, D2247.2.patch, D2247.3.patch, 
> D2247.4.patch, D2247.5.patch, D2247.6.patch, D2247.7.patch, D2247.8.patch, 
> HBASE-5335-trunk-2.patch, HBASE-5335-trunk-3.patch, HBASE-5335-trunk-3.patch, 
> HBASE-5335-trunk-4.patch, HBASE-5335-trunk.patch
>
>
> Currently, the ability for a core developer to add per-table & per-CF 
> configuration settings is very heavyweight.  You need to add a reserved 
> keyword all the way up the stack & you have to support this variable 
> long-term if you're going to expose it explicitly to the user.  This has 
> ended up with using Configuration.get() a lot because it is lightweight and 
> you can tweak settings while you're trying to understand system behavior 
> [since there are many config params that may never need to be tuned].  We 
> need to add the ability to put & read arbitrary KV settings in the HBase 
> schema.  Combined with online schema change, this will allow us to safely 
> iterate on configuration settings.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249981#comment-13249981
 ] 

stack commented on HBASE-5727:
--

Sorry.  Scratch the above suggestion.

> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249980#comment-13249980
 ] 

stack commented on HBASE-5727:
--

Or just add it back w/ addendum on this patch.

> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> 
>
> Key: HBASE-5727
> URL: https://issues.apache.org/jira/browse/HBASE-5727
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 5727.1.patch, 5727.2.patch, 5727.patch
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira