D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven added a comment.


  In D28590#673609 , @dfaure wrote:
  
  > @meven you're confusing me with my clone @ervin.
  
  
  lol
  I thought this was still you when I read the comment.
  Thanks @ervin

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter, dfaure
Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

Re: KEmoticons, emoticons kcm

[Volker Krause]

On Saturday, 23 May 2020 02:49:57 CEST Aleix Pol wrote:
> I was looking through some Plasma code and I saw that we have some
> fairly old emoticons KCM using KF5Emoticons.
> 
> Now while I know why this exists, it feels like it's more of a thing
> of the past from when people wrote :) instead of . While keeping it
> around for the few apps that might still use it (ktp? kopete?) could
> make sense, I'm afraid it's probably making it confusing for the users
> who expect this to actually allow them to customise their  but
> won't.
> 
> Do you think it would make sense to deprecate the framework and remove the
> KCM?

Absolutely! 

There's some discussion on this topic in https://phabricator.kde.org/T11585 
already. While direct usage of KEmoticons in applications is rare, there is a 
"backdoor dependency" via a KCoreAddons plug-in it provides.

Regards,
Volker

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 25 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/25/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 23 May 2020 09:09:29 +
 Build duration:
15 min and counting
   CONSOLE OUTPUT
  [...truncated 602 lines...][2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:178:5: note: expanded from macro 'Q_OBJECT'[2020-05-23T09:24:24.591Z] QT_TR_FUNCTIONS \[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:134:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2020-05-23T09:24:24.591Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-05-23T09:24:24.591Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:227:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-05-23T09:24:24.591Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.14/src/solid/devices/backends/hal/haldevice.cpp:526:26: warning: 'trUtf8' is deprecated [-Wdeprecated-declarations][2020-05-23T09:24:24.591Z] second = trUtf8("/DVD��RW DL", "Second item of %1%2 Drive sentence");[2020-05-23T09:24:24.591Z]  ^[2020-05-23T09:24:24.591Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.14/src/solid/devices/backends/hal/haldevice.h:31:5: note: 'trUtf8' has been explicitly marked deprecated here[2020-05-23T09:24:24.591Z] Q_OBJECT[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:178:5: note: expanded from macro 'Q_OBJECT'[2020-05-23T09:24:24.591Z] QT_TR_FUNCTIONS \[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:134:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2020-05-23T09:24:24.591Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-05-23T09:24:24.591Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:227:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-05-23T09:24:24.591Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.14/src/solid/devices/backends/hal/haldevice.cpp:528:26: warning: 'trUtf8' is deprecated [-Wdeprecated-declarations][2020-05-23T09:24:24.591Z] second = trUtf8("/DVD��RW", "Second item of %1%2 Drive sentence");[2020-05-23T09:24:24.591Z]  ^[2020-05-23T09:24:24.591Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.14/src/solid/devices/backends/hal/haldevice.h:31:5: note: 'trUtf8' has been explicitly marked deprecated here[2020-05-23T09:24:24.591Z] Q_OBJECT[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:178:5: note: expanded from macro 'Q_OBJECT'[2020-05-23T09:24:24.591Z] QT_TR_FUNCTIONS \[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:134:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2020-05-23T09:24:24.591Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-05-23T09:24:24.591Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:227:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-05-23T09:24:24.591Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T09:24:24.591Z] ^[2020-05-23T09:24:24.591Z] [ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halportablemediaplayer.cpp.o[2020-05-23T09:24:25.560Z] 4 warnings generated.[2020-05-23T09:24:25.560Z] [ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halprocessor.cpp.o[2020-05-23T09:24:25.839Z] [ 83%] Building CXX 

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.12 - Build # 132 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.12/132/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 May 2020 09:50:09 +
 Build duration:
7 min 42 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Solid-5.71.0.xmlcompat_reports/KF5Solid_compat_report.htmllogs/KF5Solid/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report85%
(11/13)51%
(73/143)51%
(73/143)29%
(1503/5271)16%
(539/3400)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)99%
(317/321)50%
(141/280)src.imports0%
(0/2)0%
(0/2)0%
(0/94)0%
(0/44)src.solid.devices67%
(2/3)67%
(2/3)81%
(98/121)57%
(21/37)src.solid.devices.backends.fakehw100%
(16/16)100%
(16/16)50%
(331/658)38%
(103/272)src.solid.devices.backends.fstab43%
(3/7)43%
(3/7)22%
(87/400)19%
(49/256)src.solid.devices.backends.shared20%
(1/5)20%
(1/5)10%
(36/343)6%
(10/160)src.solid.devices.backends.udev9%
(1/11)9%
(1/11)8%
(32/401)0%
(2/486)src.solid.devices.backends.udisks214%
(2/14)14%
(2/14)4%
(52/1377)2%
(20/1159)src.solid.devices.backends.udisks2.dbus100%
(2/2)100%
(2/2)67%
(6/9)100%
(0/0)src.solid.devices.backends.upower14%
(1/7)14%
(1/7)5%
(20/379)5%
(8/163)src.solid.devices.frontend50%
(22/44)50%
(22/44)57%
(498/876)44%
(180/410)src.solid.devices.ifaces74%
(20/27)74%
(20/27)52%
(26/50)21%
(5/24)src.tools.solid-hardware0%
(0/2)0%
(0/2)0%
(0/242)0%
(0/109)

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fstabdevice.cpp:73
> +if (m_displayName.isEmpty()) {
> +QStringList currentMountPoints = 
> FstabHandling::currentMountPoints(m_device);
> +if (currentMountPoints.isEmpty()) {

`const`

> fstabdevice.cpp:75
> +if (currentMountPoints.isEmpty()) {
> +QStringList mountPoints = FstabHandling::mountPoints(m_device);
> +m_displayName = mountPoints.isEmpty() ? m_description : 
> mountPoints.first();

`const` so that first() doesn't detach.

> device.h:93
> +/**
> +  * Retrieves the display Name to use for this device.
> +  * Same as description when not defined.

Why "Name" with an uppercase letter?

> device.h:96
> +  *
> +  * @return the display Name
> +  * @since 5.71

(same)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter, dfaure
Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> device.h:99
> +  */
> +virtual QString displayName() const = 0;
> +

Why not have a default implementation which returns descriptions()? This would 
make for a less intrusive patch (I think it's in part what @bruns suggested 
earlier).

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter, dfaure
Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29358: Implement lock-screen visibility control on Android

[Volker Krause]

vkrause closed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29358

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 24 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/24/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 23 May 2020 08:45:53 +
 Build duration:
23 min and counting
   CONSOLE OUTPUT
  [...truncated 633 lines...][2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:134:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2020-05-23T09:09:20.472Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-05-23T09:09:20.472Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:227:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-05-23T09:09:20.472Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.14/src/solid/devices/backends/hal/haldevice.cpp:521:26: warning: 'trUtf8' is deprecated [-Wdeprecated-declarations][2020-05-23T09:09:20.472Z] second = trUtf8("/DVD��R", "Second item of %1%2 Drive sentence");[2020-05-23T09:09:20.472Z]  ^[2020-05-23T09:09:20.472Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.14/src/solid/devices/backends/hal/haldevice.h:31:5: note: 'trUtf8' has been explicitly marked deprecated here[2020-05-23T09:09:20.472Z] Q_OBJECT[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:178:5: note: expanded from macro 'Q_OBJECT'[2020-05-23T09:09:20.472Z] QT_TR_FUNCTIONS \[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:134:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2020-05-23T09:09:20.472Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-05-23T09:09:20.472Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:227:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-05-23T09:09:20.472Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.14/src/solid/devices/backends/hal/haldevice.cpp:526:26: warning: 'trUtf8' is deprecated [-Wdeprecated-declarations][2020-05-23T09:09:20.472Z] second = trUtf8("/DVD��RW DL", "Second item of %1%2 Drive sentence");[2020-05-23T09:09:20.472Z]  ^[2020-05-23T09:09:20.472Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.14/src/solid/devices/backends/hal/haldevice.h:31:5: note: 'trUtf8' has been explicitly marked deprecated here[2020-05-23T09:09:20.472Z] Q_OBJECT[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:178:5: note: expanded from macro 'Q_OBJECT'[2020-05-23T09:09:20.472Z] QT_TR_FUNCTIONS \[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:134:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2020-05-23T09:09:20.472Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-05-23T09:09:20.472Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:227:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-05-23T09:09:20.472Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T09:09:20.472Z] ^[2020-05-23T09:09:20.472Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.14/src/solid/devices/backends/hal/haldevice.cpp:528:26: warning: 'trUtf8' is deprecated [-Wdeprecated-declarations][2020-05-23T09:09:20.472Z] second = trUtf8("/DVD��RW", "Second item of %1%2 Drive sentence");[2020-05-23T09:09:20.472Z]  ^[2020-05-23T09:09:20.472Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.14/src/solid/devices/backends/hal/haldevice.h:31:5: note: 'trUtf8' has been explicitly marked deprecated here[2020-05-23T09:09:20.472Z] 

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 26 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/26/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 23 May 2020 09:50:09 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.14 - Build # 17 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.14/17/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 23 May 2020 12:40:49 +
 Build duration:
2 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Runner-5.71.0.xmlcompat_reports/KF5Runner_compat_report.htmllogs/KF5Runner/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.runnercontexttest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)65%
(11/17)65%
(11/17)48%
(742/1559)33%
(264/804)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests67%
(2/3)67%
(2/3)78%
(131/167)53%
(52/98)src90%
(9/10)90%
(9/10)50%
(611/1214)35%
(212/606)src.declarative0%
(0/2)0%
(0/2)0%
(0/134)0%
(0/96)tests0%
(0/2)0%
(0/2)0%
(0/44)0%
(0/4)

KDE CI: Frameworks » krunner » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20FreeBSDQt5.14/18/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 23 May 2020 12:40:49 +
 Build duration:
1 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.runnercontexttest

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

[Ahmad Samir]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f2984ff28e72: [StatJob] Make mostLocalUrl ignore remote 
(ftp, http...etc) URLs (authored by ahmadsamir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29782?vs=82974=83130#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29782?vs=82974=83130

REVISION DETAIL
  https://phabricator.kde.org/D29782

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/ioslaves/trash/tests/testtrash.cpp
  src/ioslaves/trash/tests/testtrash.h

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Igor Poboiko]

poboiko updated this revision to Diff 83129.
poboiko added a comment.


  Don't override if fallbackThemeName is already set

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29826?vs=83109=83129

BRANCH
  icon-load (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29826

AFFECTED FILES
  src/kmainwindow.cpp

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

[Alexander Lohnau]

alex closed this revision.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29281

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.14 - Build # 41 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.14/41/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 23 May 2020 09:50:09 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.solidhwtest

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven added subscribers: broulik, dfaure.
meven added a comment.


  Maybe @dfaure or @broulik would be nice to help the review effort.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter
Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven updated this revision to Diff 83128.
meven added a comment.


  Remove unneeded change

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28590?vs=83127=83128

BRANCH
  arcpatch-D28590_1

REVISION DETAIL
  https://phabricator.kde.org/D28590

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/frontend/device.cpp
  src/solid/devices/frontend/device.h
  src/solid/devices/ifaces/device.cpp
  src/solid/devices/ifaces/device.h

To: meven, #frameworks, bruns, sitter, dfaure
Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven updated this revision to Diff 83127.
meven marked 5 inline comments as done.
meven added a comment.


  Use a default implementation for Device::displayName()

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28590?vs=83112=83127

BRANCH
  arcpatch-D28590_1

REVISION DETAIL
  https://phabricator.kde.org/D28590

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/udisks2/udisksdevicebackend.cpp
  src/solid/devices/frontend/device.cpp
  src/solid/devices/frontend/device.h
  src/solid/devices/ifaces/device.cpp
  src/solid/devices/ifaces/device.h

To: meven, #frameworks, bruns, sitter, dfaure
Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.14 - Build # 23 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.14/23/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 23 May 2020 08:45:53 +
 Build duration:
3 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 720 lines...][2020-05-23T08:48:47.592Z]  from /usr/include/qt5/QtCore/QMetaType:1,[2020-05-23T08:48:47.592Z]  from /home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.14/src/solid/devices/backends/udisks2/udisks2.h:10,[2020-05-23T08:48:47.592Z]  from /home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.14/src/solid/devices/backends/udisks2/udisksdevice.h:11,[2020-05-23T08:48:47.592Z]  from /home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.14/src/solid/devices/backends/udisks2/udisksdevice.cpp:8:[2020-05-23T08:48:47.592Z] /home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.14/src/solid/devices/backends/udisks2/udisksdevice.h:31:5: note: declared here[2020-05-23T08:48:47.592Z]31 | Q_OBJECT[2020-05-23T08:48:47.592Z]   | ^~~~[2020-05-23T08:48:47.592Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/predicateparse.cpp.o[2020-05-23T08:48:47.592Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/managerbase.cpp.o[2020-05-23T08:48:47.592Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksdevicebackend.cpp.o[2020-05-23T08:48:47.592Z] [ 77%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/solidnamespace.cpp.o[2020-05-23T08:48:47.851Z] [ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksblock.cpp.o[2020-05-23T08:48:47.851Z] [ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksstoragevolume.cpp.o[2020-05-23T08:48:48.420Z] [ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksopticaldisc.cpp.o[2020-05-23T08:48:48.420Z] [ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksdeviceinterface.cpp.o[2020-05-23T08:48:48.420Z] [ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksopticaldrive.cpp.o[2020-05-23T08:48:48.420Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksstoragedrive.cpp.o[2020-05-23T08:48:48.420Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksstorageaccess.cpp.o[2020-05-23T08:48:48.420Z] [ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksgenericinterface.cpp.o[2020-05-23T08:48:48.987Z] [ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/dbus/manager.cpp.o[2020-05-23T08:48:48.987Z] [ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/udisks_debug.cpp.o[2020-05-23T08:48:49.246Z] [ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabmanager.cpp.o[2020-05-23T08:48:49.246Z] [ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabdevice.cpp.o[2020-05-23T08:48:49.246Z] [ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabnetworkshare.cpp.o[2020-05-23T08:48:49.505Z] [ 84%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabstorageaccess.cpp.o[2020-05-23T08:48:49.505Z] [ 84%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabhandling.cpp.o[2020-05-23T08:48:49.505Z] [ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabwatcher.cpp.o[2020-05-23T08:48:49.764Z] [ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/fstab_debug.cpp.o[2020-05-23T08:48:49.764Z] [ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowermanager.cpp.o[2020-05-23T08:48:50.021Z] [ 86%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerdevice.cpp.o[2020-05-23T08:48:50.021Z] [ 86%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerbattery.cpp.o[2020-05-23T08:48:50.278Z] [ 87%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerdeviceinterface.cpp.o[2020-05-23T08:48:50.278Z] [ 87%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowergenericinterface.cpp.o[2020-05-23T08:48:50.278Z] [ 88%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/ECMQmLoader-solid5_qt.cpp.o[2020-05-23T08:48:50.536Z] /home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.14/src/solid/devices/backends/upower/upowerdevice.cpp: In member function ���virtual bool 

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Igor Poboiko]

poboiko added a comment.


  Thanks for looking into it! :)
  
  In D29826#673543 , @aacid wrote:
  
  > I don't think moving this code from KIconThemes to kmainwindow makes sense, 
what about all the apps that use KIconThemes but no KMainWindow?
  
  
  I'm just not aware of any. I've looked at some of the most used (by me :]), 
noted that all of them use KMainWindow and thought it might be a good option.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29826

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.12 - Build # 94 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.12/94/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 May 2020 12:40:49 +
 Build duration:
2 min 47 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Runner-5.71.0.xmlcompat_reports/KF5Runner_compat_report.htmllogs/KF5Runner/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.runnercontexttest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)65%
(11/17)65%
(11/17)48%
(742/1558)33%
(265/804)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests67%
(2/3)67%
(2/3)78%
(131/167)53%
(52/98)src90%
(9/10)90%
(9/10)50%
(611/1214)35%
(213/606)src.declarative0%
(0/2)0%
(0/2)0%
(0/133)0%
(0/96)tests0%
(0/2)0%
(0/2)0%
(0/44)0%
(0/4)

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.14 - Build # 25 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.14/25/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 23 May 2020 09:50:09 +
 Build duration:
3 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Solid-5.71.0.xmlcompat_reports/KF5Solid_compat_report.htmllogs/KF5Solid/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report85%
(11/13)51%
(73/143)51%
(73/143)29%
(1503/5271)16%
(538/3400)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)99%
(317/321)50%
(141/280)src.imports0%
(0/2)0%
(0/2)0%
(0/94)0%
(0/44)src.solid.devices67%
(2/3)67%
(2/3)81%
(98/121)57%
(21/37)src.solid.devices.backends.fakehw100%
(16/16)100%
(16/16)50%
(331/658)38%
(103/272)src.solid.devices.backends.fstab43%
(3/7)43%
(3/7)22%
(87/400)19%
(49/256)src.solid.devices.backends.shared20%
(1/5)20%
(1/5)10%
(36/343)6%
(10/160)src.solid.devices.backends.udev9%
(1/11)9%
(1/11)8%
(32/401)0%
(2/486)src.solid.devices.backends.udisks214%
(2/14)14%
(2/14)4%
(52/1377)2%
(20/1159)src.solid.devices.backends.udisks2.dbus100%
(2/2)100%
(2/2)67%
(6/9)100%
(0/0)src.solid.devices.backends.upower14%
(1/7)14%
(1/7)5%
(20/379)5%
(8/163)src.solid.devices.frontend50%
(22/44)50%
(22/44)57%
(498/876)44%
(179/410)src.solid.devices.ifaces74%
(20/27)74%
(20/27)52%
(26/50)21%
(5/24)src.tools.solid-hardware0%
(0/2)0%
(0/2)0%
(0/242)0%
(0/109)

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Albert Astals Cid]

aacid added a comment.


  In D29826#673572 , @poboiko wrote:
  
  > Thanks for looking into it! :)
  >
  > In D29826#673543 , @aacid wrote:
  >
  > > I don't think moving this code from KIconThemes to kmainwindow makes 
sense, what about all the apps that use KIconThemes but no KMainWindow?
  >
  >
  > I'm just not aware of any. I've looked at some of the most used (by me :]), 
noted that all of them use KMainWindow and thought it might be a good option.
  
  
  What about discover for example?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29826

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[David Faure]

dfaure added a comment.


  @meven you're confusing me with my clone @ervin.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter, dfaure
Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven added a comment.


  This makes the patch way less intrusive in the process, thanks @dfaure

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter, dfaure
Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

[Christoph Cullmann]

Hi,

I did a bit research, I think this might be

https://bugreports.qt.io/browse/QTBUG-84363

=> This makes actually Qt 5.14 completely unusable for 
KTextEditor/Kate/KWrite/.


I run into this kind of crashs during normal editing, too :(

I still have no 5.15 build with the fix here, will need to investigate 
that more.


Seems other users stumble on this for all parts of our products, e.g.

https://bugs.kde.org/show_bug.cgi?id=415872
https://bugs.kde.org/show_bug.cgi?id=414768

Greetings
Christoph

On 2020-05-21 13:09, CI System wrote:

BUILD UNSTABLE

 Build URL

https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/19/

 Project:
kf5-qt5 SUSEQt5.14

 Date of build:
Thu, 21 May 2020 10:51:54 +

 Build duration:
17 min and counting

 BUILD ARTIFACTS

* abi-compatibility-results.yaml [1]
* acc/KF5TextEditor-5.71.0.xml [2]
* compat_reports/KF5TextEditor_compat_report.html [3]
* logs/KF5TextEditor/5.71.0/log.txt [4]

 JUnit Tests

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0
test(s), Total: 1 test(s)

Name: projectroot Failed: 3 test(s), Passed: 59 test(s), 
Skipped: 0
test(s), Total: 62 test(s)

* Failed: projectroot.autotests.bug313759

* Failed: projectroot.autotests.kateindenttest_testAda

* Failed: projectroot.autotests.kateindenttest_testPascal

Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5
test(s), Skipped: 0 test(s), Total: 5 test(s)

 Cobertura Report

 Project Coverage Summary

 Name
Packages
Files
Classes
Lines
Conditionals

Cobertura Coverage Report
79% (22/28)
87% (260/298)
87% (260/298)
67% (32994/49195)
49% (14791/30094)

Coverage Breakdown by Package

 Name
Files
Classes
Lines
Conditionals

autotests.src
97% (37/38)
97% (37/38)
93% (4785/5127)
49% (1812/3680)

autotests.src.vimode
100% (9/9)
100% (9/9)
99% (5526/5568)
58% (984/1708)

src.buffer
88% (15/17)
88% (15/17)
89% (1677/1892)
74% (1082/1472)

src.completion
100% (11/11)
100% (11/11)
57% (1785/3131)
42% (1008/2423)

src.completion.expandingtree
100% (3/3)
100% (3/3)
40% (182/457)
21% (73/340)

src.dialogs
0% (0/4)
0% (0/4)
0% (0/858)
0% (0/180)

src.document
100% (4/4)
100% (4/4)
61% (1934/3176)
48% (1417/2977)

src.export
0% (0/4)
0% (0/4)
0% (0/121)
0% (0/156)

src.include.ktexteditor
93% (14/15)
93% (14/15)
84% (187/222)
55% (125/226)

src.inputmode
100% (8/8)
100% (8/8)
63% (192/304)
51% (39/77)

src.mode
88% (7/8)
88% (7/8)
36% (378/1050)
16% (146/897)

src.part
0% (0/1)
0% (0/1)
0% (0/7)
100% (0/0)

src.printing
0% (0/4)
0% (0/4)
0% (0/862)
0% (0/278)

src.render
100% (7/7)
100% (7/7)
77% (949/1226)
67% (611/916)

src.schema
29% (2/7)
29% (2/7)
1% (19/1468)
1% (6/625)

src.script
100% (16/16)
100% (16/16)
67% (698/1038)
53% (212/403)

src.search
100% (7/7)
100% (7/7)
74% (/1503)
63% (590/932)

src.spellcheck
57% (4/7)
57% (4/7)
7% (82/1205)
3% (19/696)

src.swapfile
50% (1/2)
50% (1/2)
32% (119/374)
 

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Igor Poboiko]

poboiko added a comment.


  In D29826#673585 , @aacid wrote:
  
  > What about discover for example?
  
  
  Good point...

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29826

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.14 - Build # 39 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.14/39/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 23 May 2020 08:45:53 +
 Build duration:
1 min 52 sec and counting
   CONSOLE OUTPUT
  [...truncated 495 lines...][2020-05-23T08:47:24.000Z] [107/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\frontend\opticaldrive.cpp.obj[2020-05-23T08:47:24.000Z] [108/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\frontend\storageaccess.cpp.obj[2020-05-23T08:47:24.268Z] [109/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\ifaces\opticaldrive.cpp.obj[2020-05-23T08:47:24.268Z] [110/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\ifaces\opticaldisc.cpp.obj[2020-05-23T08:47:24.569Z] [111/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\predicateparse.cpp.obj[2020-05-23T08:47:24.569Z] [112/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\frontend\device.cpp.obj[2020-05-23T08:47:26.075Z] [113/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\frontend\opticaldisc.cpp.obj[2020-05-23T08:47:27.074Z] [114/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakeprocessor.cpp.obj[2020-05-23T08:47:27.350Z] [115/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakedeviceinterface.cpp.obj[2020-05-23T08:47:27.960Z] [116/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakedevice.cpp.obj[2020-05-23T08:47:27.960Z] [117/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakeopticaldisc.cpp.obj[2020-05-23T08:47:27.960Z] [118/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakegenericinterface.cpp.obj[2020-05-23T08:47:28.563Z] [119/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakestorageaccess.cpp.obj[2020-05-23T08:47:28.890Z] [120/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\winstoragedrive.cpp.obj[2020-05-23T08:47:29.532Z] [121/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\wininterface.cpp.obj[2020-05-23T08:47:30.113Z] [122/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakecamera.cpp.obj[2020-05-23T08:47:30.113Z] [123/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakecdrom.cpp.obj[2020-05-23T08:47:30.113Z] [124/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakenetworkshare.cpp.obj[2020-05-23T08:47:30.736Z] [125/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakemanager.cpp.obj[2020-05-23T08:47:31.369Z] [126/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\windevice.cpp.obj[2020-05-23T08:47:31.651Z] [127/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\ECMQmLoader-solid5_qt.cpp.obj[2020-05-23T08:47:31.651Z] [128/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\winopticaldisc.cpp.obj[2020-05-23T08:47:31.651Z] [129/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\winstorageaccess.cpp.obj[2020-05-23T08:47:31.651Z] [130/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakevolume.cpp.obj[2020-05-23T08:47:31.927Z] [131/162] Linking CXX static library lib\KF5Solid_static.lib[2020-05-23T08:47:32.193Z] [132/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\winprocessor.cpp.obj[2020-05-23T08:47:32.475Z] [133/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakeportablemediaplayer.cpp.obj[2020-05-23T08:47:32.475Z] [134/162] Automatic MOC for target fakehardwaretest[2020-05-23T08:47:32.740Z] [135/162] Automatic MOC for target solidhwtest[2020-05-23T08:47:33.043Z] [136/162] Automatic MOC for target solidmttest[2020-05-23T08:47:33.043Z] [137/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\winblock.cpp.obj[2020-05-23T08:47:33.317Z] [138/162] Building CXX object autotests\CMakeFiles\fakehardwaretest.dir\fakehardwaretest_autogen\mocs_compilation.cpp.obj[2020-05-23T08:47:33.317Z] [139/162] Building CXX object autotests\CMakeFiles\solidhwtest.dir\solidhwtest_autogen\mocs_compilation.cpp.obj[2020-05-23T08:47:33.317Z] [140/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakestorage.cpp.obj[2020-05-23T08:47:33.317Z] [141/162] Building CXX object autotests\CMakeFiles\solidmttest.dir\solidmttest_autogen\mocs_compilation.cpp.obj[2020-05-23T08:47:34.746Z] [142/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\windevicemanager.cpp.obj[2020-05-23T08:47:34.746Z] ..\src\solid\devices\backends\win\windevicemanager.cpp(200): warning 

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.12 - Build # 130 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.12/130/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 May 2020 08:45:53 +
 Build duration:
1 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 524 lines...][2020-05-23T08:47:09.355Z] [ 67%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udev/udevblock.cpp.o[2020-05-23T08:47:09.355Z] [ 67%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksopticaldisc.cpp.o[2020-05-23T08:47:09.925Z] [ 68%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksopticaldrive.cpp.o[2020-05-23T08:47:09.925Z] [ 68%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/shared/udevqtclient.cpp.o[2020-05-23T08:47:10.183Z] [ 69%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/shared/udevqtdevice.cpp.o[2020-05-23T08:47:10.183Z] [ 69%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksmanager.cpp.o[2020-05-23T08:47:10.183Z] [ 70%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksdevice.cpp.o[2020-05-23T08:47:10.749Z] [ 70%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksdevicebackend.cpp.o[2020-05-23T08:47:11.008Z] [ 70%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstoragedrive.cpp.o[2020-05-23T08:47:11.267Z] [ 71%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksblock.cpp.o[2020-05-23T08:47:12.204Z] [ 71%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstorageaccess.cpp.o[2020-05-23T08:47:12.204Z] [ 71%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksstoragevolume.cpp.o[2020-05-23T08:47:12.770Z] [ 71%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksdeviceinterface.cpp.o[2020-05-23T08:47:12.770Z] [ 72%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksgenericinterface.cpp.o[2020-05-23T08:47:13.028Z] [ 72%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/dbus/manager.cpp.o[2020-05-23T08:47:13.028Z] [ 73%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/udisks_debug.cpp.o[2020-05-23T08:47:13.592Z] [ 73%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabmanager.cpp.o[2020-05-23T08:47:13.850Z] [ 74%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksopticaldisc.cpp.o[2020-05-23T08:47:14.108Z] [ 74%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksopticaldrive.cpp.o[2020-05-23T08:47:14.108Z] [ 75%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabdevice.cpp.o[2020-05-23T08:47:14.108Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksstoragedrive.cpp.o[2020-05-23T08:47:14.108Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabnetworkshare.cpp.o[2020-05-23T08:47:15.479Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksstorageaccess.cpp.o[2020-05-23T08:47:15.479Z] [ 77%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksgenericinterface.cpp.o[2020-05-23T08:47:15.479Z] [ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabstorageaccess.cpp.o[2020-05-23T08:47:15.737Z] [ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabhandling.cpp.o[2020-05-23T08:47:15.737Z] [ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabwatcher.cpp.o[2020-05-23T08:47:16.309Z] [ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/fstab_debug.cpp.o[2020-05-23T08:47:16.567Z] [ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/dbus/manager.cpp.o[2020-05-23T08:47:16.828Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/udisks_debug.cpp.o[2020-05-23T08:47:17.087Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabmanager.cpp.o[2020-05-23T08:47:17.087Z] [ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/upower/upowermanager.cpp.o[2020-05-23T08:47:17.087Z] [ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabdevice.cpp.o[2020-05-23T08:47:17.347Z] [ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/upower/upowerdevice.cpp.o[2020-05-23T08:47:17.915Z] [ 83%] Building CXX object 

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.14 - Build # 24 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.14/24/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 23 May 2020 09:07:43 +
 Build duration:
3 min 50 sec and counting
   CONSOLE OUTPUT
  [...truncated 717 lines...][2020-05-23T09:10:46.898Z]  from /home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.14/src/solid/devices/backends/udisks2/udisksdevice.cpp:8:[2020-05-23T09:10:46.898Z] /home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.14/src/solid/devices/backends/udisks2/udisksdevice.h:31:5: note: declared here[2020-05-23T09:10:46.898Z]31 | Q_OBJECT[2020-05-23T09:10:46.898Z]   | ^~~~[2020-05-23T09:10:47.467Z] [ 73%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksdevicebackend.cpp.o[2020-05-23T09:10:49.376Z] [ 74%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksblock.cpp.o[2020-05-23T09:10:50.313Z] [ 74%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksstoragevolume.cpp.o[2020-05-23T09:10:51.247Z] [ 74%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksdeviceinterface.cpp.o[2020-05-23T09:10:52.185Z] [ 75%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksopticaldisc.cpp.o[2020-05-23T09:10:53.123Z] [ 75%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksopticaldrive.cpp.o[2020-05-23T09:10:55.037Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksstoragedrive.cpp.o[2020-05-23T09:10:55.977Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksstorageaccess.cpp.o[2020-05-23T09:10:57.358Z] [ 77%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/udisksgenericinterface.cpp.o[2020-05-23T09:10:58.304Z] [ 77%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udisks2/dbus/manager.cpp.o[2020-05-23T09:10:59.244Z] [ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/udisks_debug.cpp.o[2020-05-23T09:10:59.811Z] [ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabmanager.cpp.o[2020-05-23T09:11:01.183Z] [ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabdevice.cpp.o[2020-05-23T09:11:02.550Z] [ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabnetworkshare.cpp.o[2020-05-23T09:11:03.134Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabstorageaccess.cpp.o[2020-05-23T09:11:04.066Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabhandling.cpp.o[2020-05-23T09:11:05.010Z] [ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabwatcher.cpp.o[2020-05-23T09:11:05.941Z] [ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/fstab_debug.cpp.o[2020-05-23T09:11:06.878Z] [ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowermanager.cpp.o[2020-05-23T09:11:07.816Z] [ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerdevice.cpp.o[2020-05-23T09:11:08.753Z] /home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.14/src/solid/devices/backends/upower/upowerdevice.cpp: In member function ���virtual bool Solid::Backends::UPower::UPowerDevice::queryDeviceInterface(const Solid::DeviceInterface::Type&) const���:[2020-05-23T09:11:08.753Z] /home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.14/src/solid/devices/backends/upower/upowerdevice.cpp:77:9: warning: this statement may fall through [-Wimplicit-fallthrough=][2020-05-23T09:11:08.753Z]77 | switch (uptype) {[2020-05-23T09:11:08.753Z]   | ^~[2020-05-23T09:11:08.753Z] /home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.14/src/solid/devices/backends/upower/upowerdevice.cpp:100:5: note: here[2020-05-23T09:11:08.753Z]   100 | default:[2020-05-23T09:11:08.753Z]   | ^~~[2020-05-23T09:11:09.012Z] [ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerbattery.cpp.o[2020-05-23T09:11:09.962Z] [ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerdeviceinterface.cpp.o[2020-05-23T09:11:10.531Z] [ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowergenericinterface.cpp.o[2020-05-23T09:11:11.478Z] [ 84%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/ECMQmLoader-solid5_qt.cpp.o[2020-05-23T09:11:12.420Z] [ 85%] Building CXX object 

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.14 - Build # 40 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.14/40/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 23 May 2020 09:07:43 +
 Build duration:
1 min 35 sec and counting
   CONSOLE OUTPUT
  [...truncated 494 lines...][2020-05-23T09:08:59.566Z] [107/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\ifaces\storageaccess.cpp.obj[2020-05-23T09:08:59.566Z] [108/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\frontend\opticaldisc.cpp.obj[2020-05-23T09:08:59.841Z] [109/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\frontend\opticaldrive.cpp.obj[2020-05-23T09:08:59.842Z] [110/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakegenericinterface.cpp.obj[2020-05-23T09:09:00.108Z] [111/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\ifaces\networkshare.cpp.obj[2020-05-23T09:09:00.724Z] [112/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\frontend\processor.cpp.obj[2020-05-23T09:09:00.724Z] [113/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakeblock.cpp.obj[2020-05-23T09:09:02.165Z] [114/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakestorageaccess.cpp.obj[2020-05-23T09:09:02.165Z] [115/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakeportablemediaplayer.cpp.obj[2020-05-23T09:09:02.433Z] [116/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakedeviceinterface.cpp.obj[2020-05-23T09:09:03.408Z] [117/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakecdrom.cpp.obj[2020-05-23T09:09:03.671Z] [118/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakevolume.cpp.obj[2020-05-23T09:09:03.940Z] [119/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\windevice.cpp.obj[2020-05-23T09:09:03.940Z] [120/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\winbattery.cpp.obj[2020-05-23T09:09:03.940Z] [121/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakestorage.cpp.obj[2020-05-23T09:09:04.919Z] [122/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\KF5Solid_autogen\mocs_compilation.cpp.obj[2020-05-23T09:09:05.490Z] [123/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakeprocessor.cpp.obj[2020-05-23T09:09:05.753Z] [124/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\wininterface.cpp.obj[2020-05-23T09:09:05.754Z] [125/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\winblock.cpp.obj[2020-05-23T09:09:05.754Z] [126/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\wingenericinterface.cpp.obj[2020-05-23T09:09:06.332Z] [127/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\winprocessor.cpp.obj[2020-05-23T09:09:06.593Z] [128/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\winstorageaccess.cpp.obj[2020-05-23T09:09:06.854Z] [129/162] Linking CXX static library lib\KF5Solid_static.lib[2020-05-23T09:09:07.430Z] [130/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakemanager.cpp.obj[2020-05-23T09:09:07.430Z] [131/162] Automatic MOC for target solidhwtest[2020-05-23T09:09:07.690Z] [132/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\fakehw\fakecamera.cpp.obj[2020-05-23T09:09:07.950Z] [133/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\ECMQmLoader-solid5_qt.cpp.obj[2020-05-23T09:09:07.950Z] [134/162] Building CXX object autotests\CMakeFiles\solidhwtest.dir\solidhwtest_autogen\mocs_compilation.cpp.obj[2020-05-23T09:09:07.950Z] [135/162] Automatic MOC for target fakehardwaretest[2020-05-23T09:09:08.523Z] [136/162] Building CXX object autotests\CMakeFiles\fakehardwaretest.dir\fakehardwaretest_autogen\mocs_compilation.cpp.obj[2020-05-23T09:09:08.523Z] [137/162] Automatic MOC for target solidmttest[2020-05-23T09:09:08.786Z] [138/162] Building CXX object autotests\CMakeFiles\solidmttest.dir\solidmttest_autogen\mocs_compilation.cpp.obj[2020-05-23T09:09:09.085Z] [139/162] Building CXX object src\solid\CMakeFiles\KF5Solid.dir\devices\backends\win\windevicemanager.cpp.obj[2020-05-23T09:09:09.085Z] ..\src\solid\devices\backends\win\windevicemanager.cpp(200): warning C4996: 'QSet::toList': Use values() instead.[2020-05-23T09:09:09.085Z] with[2020-05-23T09:09:09.085Z] [[2020-05-23T09:09:09.085Z] T=QString[2020-05-23T09:09:09.085Z] ][2020-05-23T09:09:09.085Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(251): note: see declaration of 'QSet::toList'[2020-05-23T09:09:09.085Z] 

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.12 - Build # 131 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.12/131/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 May 2020 09:07:43 +
 Build duration:
2 min 11 sec and counting
   CONSOLE OUTPUT
  [...truncated 541 lines...][2020-05-23T09:09:37.390Z] [ 74%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerbattery.cpp.o[2020-05-23T09:09:38.321Z] [ 75%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udev/udevblock.cpp.o[2020-05-23T09:09:39.254Z] [ 75%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/udev/udevmanager.cpp.o[2020-05-23T09:09:39.254Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fakehw/fakeprocessor.cpp.o[2020-05-23T09:09:39.254Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksblock.cpp.o[2020-05-23T09:09:39.254Z] [ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksdevicebackend.cpp.o[2020-05-23T09:09:40.191Z] [ 77%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerdeviceinterface.cpp.o[2020-05-23T09:09:40.191Z] [ 77%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstoragevolume.cpp.o[2020-05-23T09:09:40.768Z] [ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksdevice.cpp.o[2020-05-23T09:09:40.768Z] [ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowergenericinterface.cpp.o[2020-05-23T09:09:41.027Z] [ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/ECMQmLoader-solid5_qt.cpp.o[2020-05-23T09:09:41.027Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksdeviceinterface.cpp.o[2020-05-23T09:09:41.592Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksopticaldisc.cpp.o[2020-05-23T09:09:42.534Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstoragedrive.cpp.o[2020-05-23T09:09:42.534Z] [ 80%] Linking CXX static library ../../lib/libKF5Solid_static.a[2020-05-23T09:09:42.534Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstorageaccess.cpp.o[2020-05-23T09:09:43.475Z] [ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksgenericinterface.cpp.o[2020-05-23T09:09:43.734Z] [ 81%] Built target KF5Solid_static[2020-05-23T09:09:43.734Z] Scanning dependencies of target solidmttest_autogen[2020-05-23T09:09:43.734Z] [ 82%] Automatic MOC for target solidmttest[2020-05-23T09:09:43.734Z] [ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksopticaldrive.cpp.o[2020-05-23T09:09:44.298Z] [ 83%] Built target solidmttest_autogen[2020-05-23T09:09:44.298Z] Scanning dependencies of target solidhwtest_autogen[2020-05-23T09:09:44.298Z] Scanning dependencies of target fakehardwaretest_autogen[2020-05-23T09:09:44.298Z] [ 84%] Automatic MOC for target solidhwtest[2020-05-23T09:09:44.298Z] [ 85%] Automatic MOC for target fakehardwaretest[2020-05-23T09:09:44.298Z] [ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/dbus/manager.cpp.o[2020-05-23T09:09:44.298Z] [ 86%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/udisks_debug.cpp.o[2020-05-23T09:09:44.298Z] [ 86%] Built target solidhwtest_autogen[2020-05-23T09:09:44.556Z] [ 86%] Built target fakehardwaretest_autogen[2020-05-23T09:09:44.556Z] [ 87%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabdevice.cpp.o[2020-05-23T09:09:45.123Z] Scanning dependencies of target solidmttest[2020-05-23T09:09:45.123Z] [ 87%] Building CXX object autotests/CMakeFiles/solidmttest.dir/solidmttest_autogen/mocs_compilation.cpp.o[2020-05-23T09:09:45.380Z] [ 88%] Building CXX object autotests/CMakeFiles/solidmttest.dir/solidmttest.cpp.o[2020-05-23T09:09:45.380Z] [ 88%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabmanager.cpp.o[2020-05-23T09:09:45.380Z] Scanning dependencies of target solidhwtest[2020-05-23T09:09:45.380Z] [ 88%] Building CXX object autotests/CMakeFiles/solidhwtest.dir/solidhwtest_autogen/mocs_compilation.cpp.o[2020-05-23T09:09:45.639Z] [ 88%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabnetworkshare.cpp.o[2020-05-23T09:09:45.900Z] [ 89%] Building CXX object autotests/CMakeFiles/solidhwtest.dir/solidhwtest.cpp.o[2020-05-23T09:09:45.900Z] [ 90%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabstorageaccess.cpp.o[2020-05-23T09:09:46.834Z] [ 90%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabhandling.cpp.o[2020-05-23T09:09:46.834Z] [ 90%] Linking 

Re: KEmoticons, emoticons kcm

[Nate Graham]

On 5/22/20 6:49 PM, Aleix Pol wrote:

Hi,
I was looking through some Plasma code and I saw that we have some
fairly old emoticons KCM using KF5Emoticons.

Now while I know why this exists, it feels like it's more of a thing
of the past from when people wrote :) instead of . While keeping it
around for the few apps that might still use it (ktp? kopete?) could
make sense, I'm afraid it's probably making it confusing for the users
who expect this to actually allow them to customise their  but
won't.

Do you think it would make sense to deprecate the framework and remove the KCM?

If some application still uses it, they can integrate the kcm
temporarily until their users come to terms that  is the new :).


I think so. IIRC we already agreed to this, in fact. See 
https://phabricator.kde.org/T11585


Nate

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Albert Astals Cid]

aacid added a comment.


  Do you think we should mention something like
  
  // TODO Remove once we can depend on a Qt version that has 
https://codereview.qt-project.org/c/qt/qtbase/+/301588
  
  Or maybe i'm being too optimistic in getting that landed ^_^ 

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29826

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

[Méven Car]

meven added a comment.


  I believe this causes https://bugs.kde.org/show_bug.cgi?id=419434
  It causes similar issue with dolphin and KFileWidget
  
  This is not a correct behavior.
  It prevents file treeview to show files within folders with no subfolders.
  The bug has a proposed patch :
  https://bugsfiles.kde.org/attachment.cgi?id=128272
  
  I think this needs to be reverted or at least reworked.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27731

To: dfaure, apol, ahmadsamir, meven, rrosch
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

[Méven Car]

meven accepted this revision as: meven.
meven added a comment.
This revision is now accepted and ready to land.


  Nice

REPOSITORY
  R308 KRunner

BRANCH
  deprecations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29281

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22488: invoke QIcon::setFallbackThemeName a bit later

[Igor Poboiko]

poboiko added a comment.


  In D22488#673544 , @aacid wrote:
  
  > Wouldn't it make more sense to fix in Qt?
  
  
  It would make more sense.
  I thought as a temporary solution it would be nice to fix it in KF as well, 
since KF releases go out more often.
  
  In D22488#673547 , @aacid wrote:
  
  > What about something like
  >
  > [...]
  
  
  Well, if it serves the purpose - why not? Have you tested it?
  (I just only have Plasma QPA platform installed :( )

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D22488

To: mart, #frameworks, #plasma
Cc: poboiko, aacid, mlaurent, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D22488: invoke QIcon::setFallbackThemeName a bit later

[Albert Astals Cid]

aacid added a comment.


  In D22488#673575 , @poboiko wrote:
  
  > UPD: seems like it doesn't. I've added couple qDebug lines, to 
`QIcon::fromTheme()` method and near `QIcon::setFallbackThemeName()` with your 
patch, and then ran okular and dolphin. 
  >  By the time `setFallbackThemeName()` is called, almost all icons are 
already loaded :(
  
  
  Yes, that's exactly what i said with my comment about it being bad :D
  
  Ok, maybe we can go extra crazy and [assuming my patch makes it to Qt 5.15.1] 
have this block and your block from KMainWindow (maybe adding a if 
QIcon::fallbackThemeName().isEmpty() first, we don't want to overwrite if 
people manually chose something else)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D22488

To: mart, #frameworks, #plasma
Cc: poboiko, aacid, mlaurent, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

[Ahmad Samir]

ahmadsamir added a comment.


  This wasn't landed on master, but rather phabricator is confused by me 
pushing to work/ branch on gitlab :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29782

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> previewjob.cpp:587
> +if 
> (thumb.textKeys().contains(QStringLiteral("Thumb::DevicePixelRatio"))) {
> +qreal dpr = 
> thumb.text(QStringLiteral("Thumb::DevicePixelRatio")).toDouble();
> +thumb.setDevicePixelRatio(dpr);

Missing `const`

> previewjob.h:192
> +/**
> + * Request preview to use the device pixel ratio @p.
> + * The returned thumbnail may not respect the device pixel ratio 
> returned.

Did you mean `@p dpr`?

(unless doxygen is smart enough to figure out the name of the parameter?)

> previewjob.h:268
> + */
> +static void setDefaultDevicePixelRatio(qreal devicePixerRatio);
>  };

Typo: `devicePixelRatio`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Kevin Ottens]

ervin added a comment.


  LGTM now, I'll let the other reviewers weight in though.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter, dfaure
Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29810: Don't use the setenv function after fork

[Jiří Paleček]

jpalecek updated this revision to Diff 83137.
jpalecek retitled this revision from "Don't use setenv after fork" to "Don't 
use the setenv function after fork".
jpalecek edited the summary of this revision.
jpalecek added a comment.


  Change the code a bit for readability

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29810?vs=83023=83137

BRANCH
  for-upstream

REVISION DETAIL
  https://phabricator.kde.org/D29810

AFFECTED FILES
  src/kcrash.cpp

To: jpalecek, #frameworks
Cc: apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29813: t/minimize-allocations-in-crash-handler

[Jiří Paleček]

jpalecek abandoned this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29813

To: jpalecek
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29812: t/handle-errors-from-socket

[Jiří Paleček]

jpalecek abandoned this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29812

To: jpalecek
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

[Jiří Paleček]

jpalecek abandoned this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29811

To: jpalecek, #frameworks
Cc: anthonyfieroni, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

[Jiří Paleček]

jpalecek updated this revision to Diff 83138.
jpalecek edited the summary of this revision.
jpalecek added a dependency: D29810: Don't use the setenv function after fork.
jpalecek added a comment.


  Edited the commit msg, also prune the dependencies I want to abandon

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29814?vs=83027=83138

BRANCH
  for-upstream

REVISION DETAIL
  https://phabricator.kde.org/D29814

AFFECTED FILES
  src/kcrash.cpp

To: jpalecek, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use the setenv function after fork

[Jiří Paleček]

jpalecek added a dependent revision: D29814: Fix segfault on no restart args.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29810

To: jpalecek, #frameworks
Cc: apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven updated this revision to Diff 83139.
meven marked 3 inline comments as done.
meven added a comment.


  Typo, const, doxygen fix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29397?vs=82709=83139

BRANCH
  arcpatch-D29397

REVISION DETAIL
  https://phabricator.kde.org/D29397

AFFECTED FILES
  src/widgets/previewjob.cpp
  src/widgets/previewjob.h
  src/widgets/thumbcreator.cpp
  src/widgets/thumbcreator.h

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D29809: Don't invoke qstring localized stuff in critical section

[Jiří Paleček]

jpalecek updated this revision to Diff 83136.
jpalecek retitled this revision from "Don't invoke QString localized stuff in 
critical section" to "Don't invoke qstring localized stuff in critical section".
jpalecek edited the summary of this revision.
jpalecek added a comment.


  (edited the commit msg)

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29809?vs=83022=83136

BRANCH
  for-upstream

REVISION DETAIL
  https://phabricator.kde.org/D29809

AFFECTED FILES
  src/kcrash.cpp

To: jpalecek, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use the setenv function after fork

[Jiří Paleček]

jpalecek marked an inline comment as done.
jpalecek added inline comments.

INLINE COMMENTS

> apol wrote in kcrash.cpp:823
> Use {} instead of ; for readability.

Done that.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29810

To: jpalecek, #frameworks
Cc: apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29810: Don't use the setenv function after fork

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kcrash.cpp:689
>  {
> +static char autorestarted_envvar[] = "KCRASH_AUTO_RESTARTED";
> +char** environ_end;

move this to the lambda scope, you can also make the var name shorter then.

> kcrash.cpp:698
> +}
> +auto end = std::copy(environ, environ_end, environ_data.begin());
> +

`std::copy_if`, instead of a separate `remove_if` pass.

> kcrash.cpp:703
> + return strncmp(autorestarted_envvar, s, 
> sizeof(autorestarted_envvar)-1) == 0 &&
> + s[sizeof(autorestarted_envvar)-1] == '=';
> + });

the part after the `&&` can be removed when you include the '=' in the static 
string

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29810

To: jpalecek, #frameworks
Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham