[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
I am not sure if it's the right fix, but everything still seems to work
alright.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999

--- Comment #6 from Katrin Fischer  ---
QA might ask for a regression test here.

Note: All Acquisition related tests still pass for me (Acquisitions.t,
Acquisition/*, Budgets.t)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65446|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19053] Auto renewal flag is not kept if a confirmation is needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19053

Jonathan Druart  changed:

   What|Removed |Added

Summary|Auto renewal flag is not|Auto renewal flag is not
   |kept if a confirmation if   |kept if a confirmation is
   |needed  |needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19062] New: Don't queue check-in/ checkout messages if patron has no e-mail

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062

Bug ID: 19062
   Summary: Don't queue check-in/checkout messages if patron has
no e-mail
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

If the patron has no e-mail address we should not queue a check-in or checkout
message.

If later on an e-mail address is added to the patron account all the old
messages could be sent out by accident. Check out and check in messages are
only interesting close to the checkout/checkin process, later on, they are just
confusing to patrons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #64803|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 65625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65625=edit
[SIGNED OFF] Bug 18725 - Process_message_queue sends duplicate emails if
message_queue is not writable.

Last week, we had a database server whose disk filled, causing database writes
to fail.

This meant that messages in message_queue marked 'pending' were not marked as
'sent' when they were added to the postfix mail queue; messages were sent every
15 minutes (as specified in the cron job) until the disk space issues were
cleared.

I would suggest adding a token write to the start of process_message_queue.pl
as a 'canary in the coal mine'. If the database write fails,
process_message_queue should stop, because it's not safe to proceed sending
emails that may not be marked 'sent'.

I have no good idea on how to test this patch so this is what I've got:
Test Plan:
1) Apply this patch
2) prove t/db_dependent/Letters.t

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #4 from Katrin Fischer  ---
There is a slight change in behaviour from these patches, but after giving it
some thought, I think it makes more sense this way:

Before:
- Receive the order, but invoice is not closed
- Acq home: 
  - shipping cost is added to 'ordered', but not shown in list (not ok)
- Fund table:
  - shipping cost is added to 'total ordered'
- Close invoice
- Acq home:
  - shipping cost is NOT added to 'spent' and shows in list (not ok)
- Fund table:
  - shipping cost is added to 'total spent'

After:
- Receive the order, but invoice is not closed
- Acq home:
  - shipping cost is added to 'spent' and shows in list (ok)
- Fund table:
  - shipping cost is added to 'total spent'
- Close invoice
- Acq home:
  - shipping cost is added to 'spent' and shows in list (ok)
- Fund table:
  - shipping cost is added to 'total spent'

So with the new patch the funds table and acq table always match, which is
good. Also the sum on the acq home page for 'spent' and the sum on the linked
list of ordered items match.

There is no longer a different behaviour for open/closed invoiced. But as this
was only applying to the shipping cost and not the cost for the items itself,
it seems more consistent this way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999

--- Comment #5 from Katrin Fischer  ---
Created attachment 65626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65626=edit
[SIGNED OFF] Bug 18999- Modified SQL query in GetBudgetSpent() in C4/Budgets.pm

Removed the SQL select condition 'AND closedate IS NOT NULL' because
this was not returning shippingcost values and it does not exist in the
SQL query to return the shipping cost in spent.pl

Also removed the retrieval of shipping cost and the associated addition
of item(s) cost and shipping cost in GetBudgetOrdered() in C4/Budgets.pm
to prevent the shipping costs being subtracted off the fund total twice

Test plan:
1. Go to Acquisition and create a currency, budget (make this value of
100), fund ( make this the value of 50), vendor (if
neccessary)

2. Create a basket and click 'Add to basket'

3. Add 2 items with the vendor price of 10

4. Click 'Receive shipment' and write in the shipment cost of 6

5. Click 'Finish receiving' and go back to Acquisitions

6. Notice the spent column value is 0.00 but if you click on the value then
the spent.pl page is displayed and shows that the shipment cost was 6.00

7. On the acquisition page also notice that the ordered column value is 26.00

8. Click on the name of the fund and notice the spent column value is
0.00 in the fund page table

9. Apply patch

10. Refresh acquisition page and notice that 6.00 is the value in the
Spent column and 20.00 is the value in the ordered column. Both of which
match the subtotal of the full-list tables displayed when you click on these
values

11. Also notice the spent value in the fund page table is 6.00

12 Observe the changes to GetBudgetSpent() and GetBudgetOrdered() C4/Budgets.pm
and check they make sense

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

--- Comment #59 from Tomás Cohen Arazi  ---
I think bug 12412 should've added new options to the 'format' dropdown so we
don't rely on it magically falling back to some plugin  processing the file,
and explicitly choosing it instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #15 from Katrin Fischer  ---
I tried to fix the conflicts in kohastructure.sql, but ended with:

Apply? [(y)es, (n)o, (i)nteractive] i
Applying: Bug 8628: [FOLLOW-UP] More fixes
fatal: sha1 information is lacking or useless
(installer/data/mysql/kohastructure.sql).
error: could not build fake ancestor
Patch failed at 0001 Bug 8628: [FOLLOW-UP] More fixes
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-8628-FOLLOW-UP-More-fixes-banEXL.patch

Can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #12 from Tomás Cohen Arazi  ---
(In reply to Nick Clemens from comment #10)
> Created attachment 64999 [details] [review]
> Bug 16976 - Unit tests

Nick, please comment on which bug this one depends (for the tests)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059

--- Comment #13 from Owen Leonard  ---
Created attachment 65638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65638=edit
[SIGNED-OFF] Bug 19059: Remove CancelReserve - add new tests

This is bonus, let's add new tests

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059

--- Comment #12 from Owen Leonard  ---
Created attachment 65637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65637=edit
[SIGNED-OFF] Bug 19059: Remove CancelReserve - move tests

Move the existing tests

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059

--- Comment #14 from Owen Leonard  ---
Created attachment 65639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65639=edit
[SIGNED-OFF] Bug 19059: Remove CancelReserve - do not log DELETE

There is something wrong with the DELETE log, it should be replaced with
a FILLED log.
Anyway, here we do not want it to be logged.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059

Owen Leonard  changed:

   What|Removed |Added

  Attachment #65630|0   |1
is obsolete||
  Attachment #65631|0   |1
is obsolete||
  Attachment #65632|0   |1
is obsolete||
  Attachment #65633|0   |1
is obsolete||
  Attachment #65634|0   |1
is obsolete||

--- Comment #11 from Owen Leonard  ---
Created attachment 65636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65636=edit
[SIGNED-OFF] Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel

This patch adds a new Koha::Hold->cancel method and replaces the calls
to C4::Reserves::CancelReserve with it.

Test plan:
- Add and cancel holds
- Change priority of holds

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19064] New: OAI-PMH Records appearing in OAI that can' t be found in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19064

Bug ID: 19064
   Summary: OAI-PMH Records appearing in OAI that can't be found
in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marrone.patri...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Hello,

While harvesting Koha records from the OAI-PMH interface, I found a series of
records that can't be accessed using the OPAC interface. That is, the harvester
finds a record with an identifier, say 
http://example.com/cgi-bin/koha/oai.pl?verb=GetRecord=oai_dc=KOHA-OAI-EXAMPLE:572

that shows the complete record.
Trying to link to the OPAC using the biblionumber in the last part of the
identifier, say

http://example.com/cgi-bin/koha/opac-detail.pl?biblionumber=572

I get a 404 error.

I have yet to confirm this, but this might be related to the records being
hidden in the OPAC view being leaked into OAI. In that case, I would expect the
record to have a deleted status in OAI so that in can be removed from the
harvesting results.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989

Patricio Marrone  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19064

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059

--- Comment #15 from Owen Leonard  ---
Created attachment 65640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65640=edit
[SIGNED-OFF] Bug 19059: Remove CancelReserve

It's done!

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

--- Comment #60 from Katrin Fischer  ---
It's probably true, but was missed at the time. Reenabling the feature, it
could be done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

Jonathan Druart  changed:

   What|Removed |Added

URL||https://github.com/joubu/ko
   ||ha-howto

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #55 from Kyle M Hall  ---
Created attachment 65664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65664=edit
Bug 16735 - Filter groups without immediate child libraries from group pulldown

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #56 from Kyle M Hall  ---
Created attachment 65665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65665=edit
Bug 16735 - Use libraries in all subgroups, not just immediate children

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #187 from Kyle M Hall  ---
Created attachment 65680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65680=edit
Bug 15707 - Updates for Bootstrap 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #184 from Kyle M Hall  ---
Created attachment 65677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65677=edit
Bug 15707: Followup - use cat-search instead of cities-search in header

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #186 from Kyle M Hall  ---
Created attachment 65679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65679=edit
Bug 15707 - Add UNIQUE constraint to library groups table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #185 from Kyle M Hall  ---
Created attachment 65678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65678=edit
Bug 15707 - Switch datetimes to timestamps

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #182 from Kyle M Hall  ---
Created attachment 65675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65675=edit
Bug 15707 [QA Followup] - Allow object names to be styled without impeding
translation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #181 from Kyle M Hall  ---
Created attachment 65674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65674=edit
Bug 15707 [QA Followup] - Remove class for treegrid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #183 from Kyle M Hall  ---
Created attachment 65676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65676=edit
Bug 15707 - Update Schema Files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #54 from Kyle M Hall  ---
Created attachment 65663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65663=edit
Bug 16735 - Filter individual libraries from search group pulldown

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #51 from Kyle M Hall  ---
Created attachment 65660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65660=edit
Bug 16735 - Replace existing library search groups functionality with the new
hierarchical groups system

Test Plan:
1) Apply this patch set
2) Note your existing search groups have been ported over to the new
   __SEARCH_GROUPS__ group if you had any
3) Create the group __SEARCH_GROUPS__ if one does not already exist
4) Add some first level subgroups to this group, add libraries to those groups
5) Search the library group searching in the intranet and opac
6) Note you get the same results as pre-patch

Signed-off-by: Josef Moravec 

Conflicts:
catalogue/search.pl
installer/data/mysql/updatedatabase.pl
opac/opac-search.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #53 from Kyle M Hall  ---
Created attachment 65662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65662=edit
Bug 16735 - Remove use of get_categories

Feature using it is completely undocumented as far as my research has
shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #52 from Kyle M Hall  ---
Created attachment 65661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65661=edit
Bug 16735 - Don't use objects for database update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Kyle M Hall  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60772|0   |1
is obsolete||
  Attachment #60773|0   |1
is obsolete||
  Attachment #60774|0   |1
is obsolete||
  Attachment #60775|0   |1
is obsolete||
  Attachment #60776|0   |1
is obsolete||
  Attachment #60777|0   |1
is obsolete||
  Attachment #60778|0   |1
is obsolete||
  Attachment #60779|0   |1
is obsolete||

--- Comment #49 from Kyle M Hall  ---
Created attachment 65658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65658=edit
Bug 16735 - Remove modules no longer needed

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #50 from Kyle M Hall  ---
Created attachment 65659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65659=edit
Bug 16735 - Clean up sample data

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #63975|0   |1
is obsolete||
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Created attachment 65683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65683=edit
Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #63977|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 65686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65686=edit
Bug 17967: TT syntax for notices - Prove that ODUE is compatible

Nothing new here, unless we are introducing a regression.
The items.fine is a trick of our historical syntax.
We need to provide a way to access this value from the a notice template
using the TT syntax.
A bug 17976 has been opened for discussion.

Test plan:
Define ODUE and OVERDUES_SLIP notice templates and use it to generate
overdue notices from the cronjob script (misc/cronjobs/overdue_notices.pl)
or the interface (members/print_overdues.pl).

You should be able to generate the same notices with and without using
the TT syntax

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #188 from Kyle M Hall  ---
Created attachment 65681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65681=edit
Bug 15707 - Display error if group title is already used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17969] Refactor the way <> is generated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #65567|0   |1
is obsolete||
  Attachment #65568|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 65684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65684=edit
Bug 17969: Refactor the way <> is generated

<> is generated 4x in advance_notices.pl and once in
overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it
testable and reusable.

Test plan:
Use the <> tag for advance and overdue notices.
The generated notices must be the same as before this patch.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17969] Refactor the way <> is generated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969

--- Comment #9 from Kyle M Hall  ---
Created attachment 65685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65685=edit
Bug 17969: (QA followup) Add POD

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15705] Notify the user on auto renewing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19014


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014
[Bug 19014] Patrons should not get a on_reserve notification if the checkout is
due in the future
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15705


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705
[Bug 15705] Notify the user on auto renewing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #41 from Katrin Fischer  ---
Argh, sorry, I think I forgot to switch the status last time I worked on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13374] AllowHoldsOnPatronsPossessions not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13374

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #8 from Jonathan Druart  
---
Kyle, I think a new bug report must be opened, the original issue seems fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17277] Current Location column in Holdings table showing empty under OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #80 from Katrin Fischer  ---
I am testing with a kohadevbox, but have problems to access the file, even
though it is listed on the page. This is what I did:

- Added the entry to koha-conf.xml, copied from the plugins/uploads default
  /var/lib/koha/kohadev/files
- Created a file with runreport.pl and moved it to the files directory
- The file is listed on the tool page
- When I try to access the file, I get "internal server error"
- The Plack error log shows:
  /home/vagrant/kohaclone/tools/access_files.pl line 119.
  I thought it might be permission related, but even with 
  777 the problem remains:
  -rwxrwxrwx 1 kohadev-koha kohadev-koha 592 Aug  8  2017 report1.csv

While testing I've made a few little changes:
- Fixed conflicts on reports-home.tt from adding/removing the link before
moving it to tools
- Slightly reworded second line on the tools page to be a bit more verbose.
- Added entry to the tools-menu.inc.

Attaching this as a follow-up for sign-off if you agree.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #81 from Katrin Fischer  ---
Created attachment 65691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65691=edit
Bug 11317 - Follow-up - Fixing merge error and cosmetic changes

- Fixed conflicts on reports-home.tt from adding/removing
  the link before moving it to tools
- Slightly reworded second line on the tools page to be
  a bit more verbose.
- Added entry to the tools-menu.inc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

--- Comment #61 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #59)
> I think bug 12412 should've added new options to the 'format' dropdown so we
> don't rely on it magically falling back to some plugin  processing the file,
> and explicitly choosing it instead.

(In reply to Katrin Fischer from comment #60)
> It's probably true, but was missed at the time. Reenabling the feature, it
> could be done.

Will submit on bug 19049. Putting the plugins into the format combo.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19049] Recover the Arbitrary file type on stage-marc-import with plugin to_marc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65595|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 65655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65655=edit
Bug 19049: Restore import with to_marc plugin

Still needs some polishing and testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19049] Recover the Arbitrary file type on stage-marc-import with plugin to_marc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049

--- Comment #4 from Marcel de Rooy  ---
Created attachment 65656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65656=edit
Bug 19049: Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
   Severity|enhancement |trivial
   Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #71 from Kyle M Hall  ---
Created attachment 65644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65644=edit
Bug 14826 - Resurrect account offsets table

The account offsets table should be used to track increments and
decrements of fines via payments and credits, as well as fine accruals.
It should be able to match fees to payments and visa versa, so we can
know which fee was paid by a given payment, and which payments applied
to a given fee.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Note the table accountoffsets has been renamed to account_offsets
4) Ensure fine generation creates offsets
5) Ensure creating a manual invoice creates an offset
6) Ensure a lost item charge creates an offset
7) Ensure Reverse Payment creates an offset
8) Ensure a payment creates an offset
9) Ensure a payment for multiple fees creates an offset for each
10) Ensure writeoffs create offsets

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #75 from Kyle M Hall  ---
Created attachment 65648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65648=edit
Bug 14826 - Add offset for rental fees

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #70 from Kyle M Hall  ---
Created attachment 65643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65643=edit
Bug 14826 - Add Koha modules for offsets

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #73 from Kyle M Hall  ---
Created attachment 65646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65646=edit
Bug 14826 - Remove old offset table schema file

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #74 from Kyle M Hall  ---
Created attachment 65647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65647=edit
Bug 14826 - Add new offset table schema file

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #72 from Kyle M Hall  ---
Created attachment 65645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65645=edit
Bug 14826 - Unit Tests

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149

Josef Moravec  changed:

   What|Removed |Added

  Attachment #64720|0   |1
is obsolete||

--- Comment #2 from Josef Moravec  ---
Created attachment 65653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65653=edit
[SIGNED-OFF] Bug 18149: Move CountUsage calls to Koha namespace

After the introduction of Koha::Authorities->get_usage_count with bug
9988, we can now replace the remaining occurrences of CountUsage.

At the same time we remove CountUsageChildren. This was an empty sub.
The typo get_count_usage in a subtest title is adjusted.

Test plan:
[1] Run t/db_dependent/Koha/Authorities.t
[2] Perform a search on authorities-home.pl and verify that you see
plausible numbers for 'used in xx records'.
[3] Click on Details for one authority. See the same number?
[4] Do the same as in 2/3 for Authority search on OPAC.
[5] Remember the authid and enter this in the record numbers box on
tools/batch_delete_records.pl. Select Authorities and click
Continue. The next form shows a column "Used in". Do you see
the same count again?
[6] Git grep CountUsage.
You should see just one hit in a comment that can be kept in
Koha/Authorities.pm.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #36 from Katrin Fischer  ---
Hm, there are changes in kohastructure.sql to the table serialitems causing a
conflict when applying the patch:

Bug 8643 - Add important constraint to marc subfields

60554 - Bug 8643 - Add important constraint to marc subfields
60555 - Bug 8643: (follow-up) atomic update
65149 - Bug 8643 - Added hint for important fields and implemented it for item
fields

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 8643 - Add important constraint to marc subfields
.git/rebase-apply/patch:22: trailing whitespace.
FROM marc_tag_structure 
.git/rebase-apply/patch:23: trailing whitespace.
WHERE frameworkcode=? 
.git/rebase-apply/patch:42: trailing whitespace.
 FROM   marc_subfield_structure 
.git/rebase-apply/patch:43: trailing whitespace.
 WHERE  frameworkcode=? 
.git/rebase-apply/patch:194: trailing whitespace.
FROM marc_tag_structure 
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
Using index info to reconstruct a base tree...
M   C4/Biblio.pm
M   admin/marc_subfields_structure.pl
M   cataloguing/addbiblio.pl
M   installer/data/mysql/kohastructure.sql
.git/rebase-apply/patch:22: trailing whitespace.
FROM marc_tag_structure 
.git/rebase-apply/patch:23: trailing whitespace.
WHERE frameworkcode=? 
.git/rebase-apply/patch:42: trailing whitespace.
 FROM   marc_subfield_structure 
.git/rebase-apply/patch:43: trailing whitespace.
 WHERE  frameworkcode=? 
.git/rebase-apply/patch:194: trailing whitespace.
FROM marc_tag_structure 
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/kohastructure.sql
CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql
Auto-merging cataloguing/addbiblio.pl
Auto-merging admin/marc_subfields_structure.pl
Auto-merging C4/Biblio.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 8643 - Add important constraint to marc subfields
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-8643---Add-important-constraint-to-marc-subfie-FP83NQ.patch

Are those changes related to the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #64313|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 65654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65654=edit
[SIGNED OFF] Bug 10112 - add test for ./debian/control* files

to test, apply patch...

1/ install libparse-debcontrol-perl package
apt-get install libparse-debcontrol-perl

2/ run successful tests
$ perl ./t/00-valid-debian-control-file.t  
1..2
ok 1 - parsed ./debian/control file cleanly
ok 2 - parsed ./debian/control.in file cleanly

3/ add some bad syntax to a file
$ sed -i -e '20i ---\' ./debian/control.in

4/ run failed tests
$ perl ./t/00-valid-debian-control-file.t
1..2
ok 1 - parsed ./debian/control file cleanly
not ok 2 - parsed ./debian/control.in file cleanly

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043

--- Comment #1 from Josef Moravec  ---
Created attachment 65641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65641=edit
Bug 19043: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly
available

Test plan:
0) Apply the patch
1) Install all affected languages: de-DE, es-ES, fr-CA and pl-PL
2) Remove and recreate Koha database
3) Go through web installer in English and don't forgot to load sample Z39.50
servers
4) Go to Administration -> Z39.50/SRU Servers and confirm the sample
servers are here, but columbia.edu is not here
5) Repeat 2-4 for other languages: de-DE, es-ES, fr-CA and pl-PL

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043

Josef Moravec  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #65459|0   |1
is obsolete||
  Attachment #65460|0   |1
is obsolete||
  Attachment #65461|0   |1
is obsolete||
  Attachment #65462|0   |1
is obsolete||
  Attachment #65463|0   |1
is obsolete||
  Attachment #65464|0   |1
is obsolete||
  Attachment #65465|0   |1
is obsolete||
  Attachment #65466|0   |1
is obsolete||
  Attachment #65467|0   |1
is obsolete||

--- Comment #69 from Kyle M Hall  ---
Created attachment 65642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65642=edit
Bug 14826 - Update database

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #76 from Kyle M Hall  ---
Created attachment 65649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65649=edit
Bug 14826 - Add unit tests for _FixAccountForLostAndReturned and
_FixOverduesOnReturn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #77 from Kyle M Hall  ---
Created attachment 65650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65650=edit
Bug 14826 - Update existing schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #79 from Kyle M Hall  ---
Created attachment 65652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65652=edit
Bug 14826 [QA Followup] - Only use plural modules in other modules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #78 from Kyle M Hall  ---
Created attachment 65651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65651=edit
Bug 14826 [QA Followup] - Fix minor issues with unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #27 from Katrin Fischer  ---
There is a conflict in the OPAC minified CSS:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 8630 - Adlibris covers (OPAC minified CSS)
Using index info to reconstruct a base tree...
M   koha-tmpl/opac-tmpl/bootstrap/css/opac.css
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
error: Failed to merge in the changes.
Patch failed at 0001 Bug 8630 - Adlibris covers (OPAC minified CSS)

Leaving this Needs Signoff, someone familiar with the process could recompile
before testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #64313|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

--- Comment #9 from Katrin Fischer  ---
The patch proposes a new dependency libparse-debcontrol-perl and there has been
some discussion about it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

--- Comment #19 from Katrin Fischer  ---
It's impossible to enter them, but scanning from an ID or c from another
system you might not know that it has been automatically cut off. This was just
thought to provide some help for this case. 

I am signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #62934|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer  ---
Created attachment 65657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65657=edit
[SIGNED OFF] Bug 10267: Show error message if user tries to enter too many
characters for cardnumber

This patch displays a message if the user tries to enter more than the
max number of characters for a cardnumber.

To test:
1) Apply patch and go to Patrons -> New patron
2) Scroll down to Card number
3) Put in any characters. Notice that when you have entered the max
number of characters, you are unable to type any more.
4) Click out of the text field (so it loses focus), the error message will show
up.
5) if you backspace some characters and click out of the text field
again, the message should disappear

Sponsored-by: Catalyst IT

Followed test plan, works as expected
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18877] Outdated explanation of use when two patches applied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18877

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
(In reply to Lee Jamison from comment #2)
> testing 2 commit(s) (applied to 3d24c19 'Bug 14533: remove CREATE USER when
> ko')
> 
> Processing files before patches
> 
> Processing files after patches
> 
> 
> kohadev-koha@kohadevbox:/home/vagrant/kohaclone$
> 
> 
> It appears that applying this patch breaks QA Tools for some reason.
> 
> Failing QA

This is not relevant, nothing is displayed because no file are processed.
You can consider that as a bug in the QA script.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/