[OpenWrt-Devel] Requesting patch review for #7667 -- preserving SUID/SGID permissions when building images
Hi there, I've spent some time troubleshooting my backfire branch build because sudo in particular was not installed with its SUID bit set in the final squashfs image, effectively making it unusable (thanks to nbd and xMff for putting up with all my questions in #openwrt). I have created patches for the changes that work for me, but they should probably receive wider testing before being included in OpenWrt proper. Ticket w/patches here: https://dev.openwrt.org/ticket/7667 Kind regards, -ermo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] Builds since yesterday afternoon not succeeding
When trying to build from the latest sources, I get the following output (with V=99) on 'make world': --- snip --- make[3]: Entering directory `/home/jhenderson/Downloads/openwrt/feeds/ packages/net/miniupnpd' ln -sf /home/jhenderson/Downloads/openwrt/build_dir/linux-ar71xx_generic/ miniupnpd-1.4/config.h.openwrt /home/jhenderson/Downloads/openwrt/ build_dir/linux-ar71xx_generic/miniupnpd-1.4/config.h make -C /home/jhenderson/Downloads/openwrt/build_dir/linux-ar71xx_generic/ miniupnpd-1.4 -f Makefile.openwrt AR=mips-openwrt-linux-uclibc-ar AS=mips-openwrt-linux-uclibc-gcc -c -Os -pipe -mips32r2 -mtune=mips32r2 - funit-at-a-time -fhonour-copts -msoft-float LD=mips-openwrt-linux-uclibc- ld NM=mips-openwrt-linux-uclibc-nm CC=mips-openwrt-linux-uclibc-gcc GCC=mips-openwrt-linux-uclibc-gcc CXX=mips-openwrt-linux-uclibc-g++ RANLIB=mips-openwrt-linux-uclibc-ranlib STRIP=mips-openwrt-linux-uclibc- strip OBJCOPY=mips-openwrt-linux-uclibc-objcopy OBJDUMP=mips-openwrt- linux-uclibc-objdump SIZE=mips-openwrt-linux-uclibc-size STAGING_DIR=/ home/jhenderson/Downloads/openwrt/staging_dir/target- mips_r2_uClibc-0.9.30.1 CFLAGS=-Os -pipe -mips32r2 -mtune=mips32r2 - funit-at-a-time -fhonour-copts -msoft-float -I/home/jhenderson/Downloads/ openwrt/staging_dir/target-mips_r2_uClibc-0.9.30.1/usr/include -I - DIPTABLES_143 LIBS=/home/jhenderson/Downloads/openwrt/staging_dir/ target-mips_r2_uClibc-0.9.30.1/usr/lib/libiptc.so /home/jhenderson/ Downloads/openwrt/staging_dir/target-mips_r2_uClibc-0.9.30.1/usr/lib/ libip4tc.so /home/jhenderson/Downloads/openwrt/staging_dir/target- mips_r2_uClibc-0.9.30.1/usr/lib/libip6tc.so make[4]: Entering directory `/home/jhenderson/Downloads/openwrt/build_dir/ linux-ar71xx_generic/miniupnpd-1.4' mips-openwrt-linux-uclibc-gcc -Os -pipe -mips32r2 -mtune=mips32r2 -funit- at-a-time -fhonour-copts -msoft-float -I/home/jhenderson/Downloads/ openwrt/staging_dir/target-mips_r2_uClibc-0.9.30.1/usr/include -I - DIPTABLES_143 -I/home/jhenderson/Downloads/openwrt/staging_dir/target- mips_r2_uClibc-0.9.30.1/usr/include -c -o netfilter/iptcrdr.o netfilter/ iptcrdr.c netfilter/iptcrdr.c:32:36: error: linux/netfilter/nf_nat.h: No such file or directory netfilter/iptcrdr.c: In function 'get_redirect_rule': netfilter/iptcrdr.c:161: error: 'iptc_handle_t' undeclared (first use in this function) netfilter/iptcrdr.c:161: error: (Each undeclared identifier is reported only once netfilter/iptcrdr.c:161: error: for each function it appears in.) netfilter/iptcrdr.c:161: error: expected ';' before 'h' netfilter/iptcrdr.c:167: error: 'h' undeclared (first use in this function) netfilter/iptcrdr.c:211: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c:212: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c: In function 'get_redirect_rule_by_index': netfilter/iptcrdr.c:245: error: 'iptc_handle_t' undeclared (first use in this function) netfilter/iptcrdr.c:245: error: expected ';' before 'h' netfilter/iptcrdr.c:251: error: 'h' undeclared (first use in this function) netfilter/iptcrdr.c:293: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c:294: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c: At top level: netfilter/iptcrdr.c:320: error: expected declaration specifiers or '...' before 'iptc_handle_t' netfilter/iptcrdr.c: In function 'delete_rule_and_commit': netfilter/iptcrdr.c:328: error: 'h' undeclared (first use in this function) netfilter/iptcrdr.c: In function 'delete_redirect_and_filter_rules': netfilter/iptcrdr.c:362: error: 'iptc_handle_t' undeclared (first use in this function) netfilter/iptcrdr.c:362: error: expected ';' before 'h' netfilter/iptcrdr.c:366: error: 'h' undeclared (first use in this function) netfilter/iptcrdr.c:426: error: too many arguments to function 'delete_rule_and_commit' netfilter/iptcrdr.c:430: error: too many arguments to function 'delete_rule_and_commit' netfilter/iptcrdr.c: In function 'get_dnat_target': netfilter/iptcrdr.c:487: error: invalid application of 'sizeof' to incomplete type 'struct ip_nat_multi_range' netfilter/iptcrdr.c:493: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c:494: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c:495: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c:495: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c:496: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c:496: error: 'IP_NAT_RANGE_MAP_IPS' undeclared (first use in this function) netfilter/iptcrdr.c:497: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c:497: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c:498: error: dereferencing pointer to incomplete type netfilter/iptcrdr.c:498: error: 'IP_NAT_RANGE_PROTO_SPECIFIED' undeclared (first use in this function) netfilter/iptcrdr.c: In function 'iptc_init_verify_and_append': netfilter/iptcrdr.c:508: error: 'iptc_handle_t'
Re: [OpenWrt-Devel] Builds since yesterday afternoon not succeeding
On Sun, 25 Jul 2010 18:18:53 +, Jim Henderson wrote: When trying to build from the latest sources, I get the following output (with V=99) on 'make world': Seems to be working now. Jim -- Jim Henderson Please keep on-topic replies on the list so everyone benefits ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Builds since yesterday afternoon not succeeding
I am experiencing the same errors. It happens to me even with `make -j1'. The miniupnpd package is being built before the iptables package, which miniupnpd depends on. It uses header files from the iptables package. The miniupnpd Makefile tries to set CFLAGS to CFLAGS=... -I$(firstword $(wildcard $(KERNEL_BUILD_DIR)/iptables-*/include)) -DIPTABLES_143 but the directory referenced, `$(KERNEL_BUILD_DIR)/iptables-*/include' doesn't exist until iptables is at least unpacked. There is a DEPENDS:=iptables in the miniupnpd Makefile. I've also tried putting a PKG_BUILD_DEPENDS:=iptables but no change. I honestly don't know what the difference between DEPENDS and PKG_BUILD_DEPENDS is, but neither seem to trigger iptables build before miniupnpd. Joe On Jul 25, 2010, at 8:49 PM, Jim Henderson wrote: On Sun, 25 Jul 2010 18:18:53 +, Jim Henderson wrote: When trying to build from the latest sources, I get the following output (with V=99) on 'make world': Seems to be working now. Jim -- Jim Henderson Please keep on-topic replies on the list so everyone benefits ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Builds since yesterday afternoon not succeeding
Also interesting, if invoked to build miniupnpd manually, the iptables dependency seems to be honored. $ make package/feeds/packages/miniupnpd-compile Collecting package info: done make[1] package/feeds/packages/miniupnpd-compile make[2] -C package/libtool host-compile make[2] -C package/libtool compile make[2] -C package/iptables compile make[2] -C feeds/packages/net/miniupnpd compile The problem, repeatable every build, only seems to occur after `make clean make' of the entire trunk Joe On Jul 25, 2010, at 9:18 PM, Joseph Roback wrote: I am experiencing the same errors. It happens to me even with `make -j1'. The miniupnpd package is being built before the iptables package, which miniupnpd depends on. It uses header files from the iptables package. The miniupnpd Makefile tries to set CFLAGS to CFLAGS=... -I$(firstword $(wildcard $(KERNEL_BUILD_DIR)/iptables-*/include)) -DIPTABLES_143 but the directory referenced, `$(KERNEL_BUILD_DIR)/iptables-*/include' doesn't exist until iptables is at least unpacked. There is a DEPENDS:=iptables in the miniupnpd Makefile. I've also tried putting a PKG_BUILD_DEPENDS:=iptables but no change. I honestly don't know what the difference between DEPENDS and PKG_BUILD_DEPENDS is, but neither seem to trigger iptables build before miniupnpd. Joe On Jul 25, 2010, at 8:49 PM, Jim Henderson wrote: On Sun, 25 Jul 2010 18:18:53 +, Jim Henderson wrote: When trying to build from the latest sources, I get the following output (with V=99) on 'make world': Seems to be working now. Jim -- Jim Henderson Please keep on-topic replies on the list so everyone benefits ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Builds since yesterday afternoon not succeeding
On Sun, 25 Jul 2010 21:44:52 -0600, Joseph Roback wrote: Also interesting, if invoked to build miniupnpd manually, the iptables dependency seems to be honored. $ make package/feeds/packages/miniupnpd-compile Collecting package info: done make[1] package/feeds/packages/miniupnpd-compile make[2] -C package/libtool host-compile make[2] -C package/libtool compile make[2] -C package/iptables compile make[2] -C feeds/packages/net/miniupnpd compile The problem, repeatable every build, only seems to occur after `make clean make' of the entire trunk I've noticed this in my testing - r22344 seems to build OK, r22348 doesn't. I'll see if I can narrow it down a bit more (I'm building r22344 now). Jim -- Jim Henderson Please keep on-topic replies on the list so everyone benefits ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Builds since yesterday afternoon not succeeding
I using r22388. After building miniupnpd manually and continuing the build, uhttpd failed because its dependency openssl was there. I manually build uhttpd make package/uhttpd-compile and then it was ok. I think the build system dependencies are screwed up somehow... Joe On Jul 25, 2010, at 10:01 PM, Jim Henderson wrote: On Sun, 25 Jul 2010 21:44:52 -0600, Joseph Roback wrote: Also interesting, if invoked to build miniupnpd manually, the iptables dependency seems to be honored. $ make package/feeds/packages/miniupnpd-compile Collecting package info: done make[1] package/feeds/packages/miniupnpd-compile make[2] -C package/libtool host-compile make[2] -C package/libtool compile make[2] -C package/iptables compile make[2] -C feeds/packages/net/miniupnpd compile The problem, repeatable every build, only seems to occur after `make clean make' of the entire trunk I've noticed this in my testing - r22344 seems to build OK, r22348 doesn't. I'll see if I can narrow it down a bit more (I'm building r22344 now). Jim -- Jim Henderson Please keep on-topic replies on the list so everyone benefits ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Builds since yesterday afternoon not succeeding
On Sun, 25 Jul 2010 22:05:12 -0600, Joseph Roback wrote: I using r22388. After building miniupnpd manually and continuing the build, uhttpd failed because its dependency openssl was there. I manually build uhttpd make package/uhttpd-compile and then it was ok. I think the build system dependencies are screwed up somehow... It looks like that's the case. I'm trying building the releases between r22380 and r22388 to see if I can pinpoint where it stopped building. I don't know now why I went all the way back to r22344, I think I must've mistyped (meaning to go to 84), but I noticed the build date when going in to update the feeds. Something I do wish the feeds script would do (maybe it does?) is update to the same date/time as the main build. I end up manually going in and using svn update to update feeds/packages, feeds/xwrt, and feeds/luci (by date) to make sure I'm on the sources that would've been downloaded at the same time as the main openwrt code repository. It's not difficult to do, but if the feeds script could figure that out, that would be awesome for tracking things like this down. :-) I'll probably identify which is the last release to build tomorrow morning, it looks like r22380 is going to be successful, so I'll jump ahead to r22384 and try that next - that'll probably run while I'm sleeping. Jim -- Jim Henderson Please keep on-topic replies on the list so everyone benefits ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
