Re: [ptxdist] [PATCH 28/48] [procps] Added installation of alternative /etc/sysctl.conf

2010-01-08 Thread Ladislav Michl
On Fri, Jan 08, 2010 at 12:14:45PM +0100, Carsten Schlote wrote:
> > -Urspr?ngliche Nachricht-
> > Then it could be easy to read/write files in /proc/sys directly, unless you
> > found some sysctl entry which does not have its equivalent in /proc/sys. Is
> > it the case? Otherwise, it should be only matter of script(s) modification.
> 
> Sure, and i'm going to replace the stuff. 
> 
> But patch 28 just introduced the installation of sysctl.conf after installing
> sysctl. This should be no problem at all and either uses an empty generic
> file or a user version from project root.
> 
> In case you install sysctl for your project, the startup system will check
> for this config file and call sysctl.

I'm perfectly fine with that. I'd just like to see no PROCPS_SYSCTL
in PTXdist config files at all, which is rather hard because
1) we are importing Busybox' version anyway
2) people won't understand it was removed for their own good ;-)

So lets individuals decide and document it.

ladis (thinking enlighted autocracy is the only right form of 
governement)

--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 28/48] [procps] Added installation of alternative /etc/sysctl.conf

2010-01-08 Thread Ladislav Michl
On Fri, Jan 08, 2010 at 12:14:06AM +0100, Carsten Schlote wrote:
> Am Freitag, den 08.01.2010, 00:03 +0100 schrieb Ladislav Michl:
> > As newer kernels emulates binary interface we probably do not want to 
> > support
> > obsolete interfaces, right?
> > 
> > http://lwn.net/Articles/361001/
> 
> Hi
> 
> Thanks for the point. As sysctl was in our firmware for a long time and
> is still used for older kernels, I added this patch.
> 
> I will add the comments to the patch, so everyone knows as well. And of
> course I will remove sysctl from our current dev-firmware asap. 
> 
> Nevertheless I need it for the old projects - all of them are maintained
> to work with the latest ptxdist version.

Then it could be easy to read/write files in /proc/sys directly, unless
you found some sysctl entry which does not have its equivalent in
/proc/sys. Is it the case? Otherwise, it should be only matter of
script(s) modification.

ladis

--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 28/48] [procps] Added installation of alternative /etc/sysctl.conf

2010-01-07 Thread Ladislav Michl
On Thu, Jan 07, 2010 at 11:27:55PM +0100, Marc Kleine-Budde wrote:
> luckily, I haven't pushed that commit not yet. :) However it's probably
> interesting for olther kernels than the latest -rc :)

It is not the case. My man page dated 21 Sep 1999 says:
  sysctl  is  used to modify kernel parameters at runtime.  The parameters
  available are those listed under /proc/sys/.  Procfs is required for sysctl
  support in Linux.  You can use sysctl to both read and write sysctl data.

Honestly, I've never got the point of this program.

> Carsten can you please add a notice to PTXCONF_PROCPS_SYSCTL's helptext
> stating that this is a deprecated interface.

I'd commit this patch only after someone would find anything available only
via sysctl and meanwhile add notice advicing people to use /proc/sys.

ladis

--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 28/48] [procps] Added installation of alternative /etc/sysctl.conf

2010-01-07 Thread Carsten Schlote
Am Freitag, den 08.01.2010, 00:03 +0100 schrieb Ladislav Michl:
> As newer kernels emulates binary interface we probably do not want to support
> obsolete interfaces, right?
> 
> http://lwn.net/Articles/361001/

Hi

Thanks for the point. As sysctl was in our firmware for a long time and
is still used for older kernels, I added this patch.

I will add the comments to the patch, so everyone knows as well. And of
course I will remove sysctl from our current dev-firmware asap. 

Nevertheless I need it for the old projects - all of them are maintained
to work with the latest ptxdist version.


-- 
Carsten Schlote 


signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 28/48] [procps] Added installation of alternative /etc/sysctl.conf

2010-01-07 Thread Marc Kleine-Budde
Ladislav Michl wrote:
> On Thu, Jan 07, 2010 at 09:28:07PM +0100, Marc Kleine-Budde wrote:
>> carsten.schl...@gmx.net wrote:
>>> From: Carsten Schlote 
>>>
>>> Signed-off-by: Carsten Schlote 
>> applied, tnx
> 
> As newer kernels emulates binary interface we probably do not want to support
> obsolete interfaces, right?
> 
> http://lwn.net/Articles/361001/
> 
> Kernel help says:
>   | CONFIG_SYSCTL_SYSCALL:
>   
>|
>   |   
>   
>|
>   | sys_sysctl uses binary paths that have been found challenging 
>   
>|
>   | to properly maintain and use.  The interface in /proc/sys 
>   
>|
>   | using paths with ascii names is now the primary path to this  
>   
>|
>   | information.  
>   
>|
>   |   
>   
>|
>   | Almost nothing using the binary sysctl interface so if you are
>   
>|
>   | trying to save some space it is probably safe to disable this,
>   
>|
>   | making your kernel marginally smaller.
> 
> ... and your system will get even smaller without sysctl binary.
> 
> Btw, 'sysctl' branch was merged 24 Dec 2009. Some people can really enjoy
> Christmas ;-)

luckily, I haven't pushed that commit not yet. :) However it's probably
interesting for olther kernels than the latest -rc :)

Carsten can you please add a notice to PTXCONF_PROCPS_SYSCTL's helptext
stating that this is a deprecated interface.

cheers, Marc

-- 
Pengutronix e.K.  | Marc Kleine-Budde   |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund  | Fax:   +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



signature.asc
Description: OpenPGP digital signature
--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 28/48] [procps] Added installation of alternative /etc/sysctl.conf

2010-01-07 Thread Ladislav Michl
On Thu, Jan 07, 2010 at 09:28:07PM +0100, Marc Kleine-Budde wrote:
> carsten.schl...@gmx.net wrote:
> > From: Carsten Schlote 
> > 
> > Signed-off-by: Carsten Schlote 
> 
> applied, tnx

As newer kernels emulates binary interface we probably do not want to support
obsolete interfaces, right?

http://lwn.net/Articles/361001/

Kernel help says:
  | CONFIG_SYSCTL_SYSCALL:  

   |
  | 

   |
  | sys_sysctl uses binary paths that have been found challenging   

   |
  | to properly maintain and use.  The interface in /proc/sys   

   |
  | using paths with ascii names is now the primary path to this

   |
  | information.

   |
  | 

   |
  | Almost nothing using the binary sysctl interface so if you are  

   |
  | trying to save some space it is probably safe to disable this,  

   |
  | making your kernel marginally smaller.

... and your system will get even smaller without sysctl binary.

Btw, 'sysctl' branch was merged 24 Dec 2009. Some people can really enjoy
Christmas ;-)

ladis

> > ---
> >  generic/etc/sysctl.conf |4 
> >  rules/procps.make   |2 ++
> >  2 files changed, 6 insertions(+), 0 deletions(-)
> >  create mode 100644 generic/etc/sysctl.conf
> > 
> > diff --git a/generic/etc/sysctl.conf b/generic/etc/sysctl.conf
> > new file mode 100644
> > index 000..b10c21d
> > --- /dev/null
> > +++ b/generic/etc/sysctl.conf
> > @@ -0,0 +1,4 @@
> > +#
> > +# /etc/sysctl.conf - Configuration file for setting system variables
> > +# See sysctl.conf (5) for information.
> > +#
> > diff --git a/rules/procps.make b/rules/procps.make
> > index 57f8fdb..403714b 100644
> > --- a/rules/procps.make
> > +++ b/rules/procps.make
> > @@ -90,6 +90,8 @@ endif
> >  ifdef PTXCONF_PROCPS_SYSCTL
> > @$(call install_copy, procps, 0, 0, 0755, -, \
> > /sbin/sysctl)
> > +
> > +   @$(call install_alternative, procps, 0, 0, 0644, /etc/sysctl.conf, n)
> >  endif
> >  ifdef PTXCONF_PROCPS_PS
> > @$(call install_copy, procps, 0, 0, 0755, -, \

--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 28/48] [procps] Added installation of alternative /etc/sysctl.conf

2010-01-07 Thread Marc Kleine-Budde
carsten.schl...@gmx.net wrote:
> From: Carsten Schlote 
> 
> Signed-off-by: Carsten Schlote 

applied, tnx

marc
> ---
>  generic/etc/sysctl.conf |4 
>  rules/procps.make   |2 ++
>  2 files changed, 6 insertions(+), 0 deletions(-)
>  create mode 100644 generic/etc/sysctl.conf
> 
> diff --git a/generic/etc/sysctl.conf b/generic/etc/sysctl.conf
> new file mode 100644
> index 000..b10c21d
> --- /dev/null
> +++ b/generic/etc/sysctl.conf
> @@ -0,0 +1,4 @@
> +#
> +# /etc/sysctl.conf - Configuration file for setting system variables
> +# See sysctl.conf (5) for information.
> +#
> diff --git a/rules/procps.make b/rules/procps.make
> index 57f8fdb..403714b 100644
> --- a/rules/procps.make
> +++ b/rules/procps.make
> @@ -90,6 +90,8 @@ endif
>  ifdef PTXCONF_PROCPS_SYSCTL
>   @$(call install_copy, procps, 0, 0, 0755, -, \
>   /sbin/sysctl)
> +
> + @$(call install_alternative, procps, 0, 0, 0644, /etc/sysctl.conf, n)
>  endif
>  ifdef PTXCONF_PROCPS_PS
>   @$(call install_copy, procps, 0, 0, 0755, -, \


-- 
Pengutronix e.K.  | Marc Kleine-Budde   |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund  | Fax:   +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



signature.asc
Description: OpenPGP digital signature
--
ptxdist mailing list
ptxdist@pengutronix.de


[ptxdist] [PATCH 28/48] [procps] Added installation of alternative /etc/sysctl.conf

2010-01-07 Thread carsten . schlote
From: Carsten Schlote 

Signed-off-by: Carsten Schlote 
---
 generic/etc/sysctl.conf |4 
 rules/procps.make   |2 ++
 2 files changed, 6 insertions(+), 0 deletions(-)
 create mode 100644 generic/etc/sysctl.conf

diff --git a/generic/etc/sysctl.conf b/generic/etc/sysctl.conf
new file mode 100644
index 000..b10c21d
--- /dev/null
+++ b/generic/etc/sysctl.conf
@@ -0,0 +1,4 @@
+#
+# /etc/sysctl.conf - Configuration file for setting system variables
+# See sysctl.conf (5) for information.
+#
diff --git a/rules/procps.make b/rules/procps.make
index 57f8fdb..403714b 100644
--- a/rules/procps.make
+++ b/rules/procps.make
@@ -90,6 +90,8 @@ endif
 ifdef PTXCONF_PROCPS_SYSCTL
@$(call install_copy, procps, 0, 0, 0755, -, \
/sbin/sysctl)
+
+   @$(call install_alternative, procps, 0, 0, 0644, /etc/sysctl.conf, n)
 endif
 ifdef PTXCONF_PROCPS_PS
@$(call install_copy, procps, 0, 0, 0755, -, \
-- 
1.6.5.6.gb3118


--
ptxdist mailing list
ptxdist@pengutronix.de