[Impala-ASF-CR] Add Apache license header to files in doc directory

[John Russell (Code Review)]

John Russell has posted comments on this change.

Change subject: Add Apache license header to files in doc directory
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5232/2//COMMIT_MSG
Commit Message:

PS2, Line 7: Add Apache license header to files in doc directory
> No, I used "replace".
To sanity-check the logic, what was the exact 'replace' command? I.e. was it to 
replace line 1:



with line 1 + version notice? Is/was there an option to say "only replace the 
first instance"?

If there's an unusual file with a different  header line, or a second 
instance inside a comment, I would doublecheck that with grep -l or grep -c for 
an extra level of confidence. That's why it helps me to know the precise 
search/replace procedure.


-- 
To view, visit http://gerrit.cloudera.org:8080/5232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add Apache license header to files in doc directory

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Add Apache license header to files in doc directory
..


Patch Set 2:

(1 comment)

> (1 comment)
 > 
 > Looks good. (Does the +2 initiate any further transfer of files or
 > do you as the code review creator still have to do all the followup
 > git commands to get the changes over to master?)

+2 does nothing but +2.

"Submit" puts it in gerrit's master branch. bin/push_to_asf.py copies patches 
from gerrit's master branch to apache's master branch.

http://gerrit.cloudera.org:8080/#/c/5232/2//COMMIT_MSG
Commit Message:

PS2, Line 7: Add Apache license header to files in doc directory
> Is that another sed script?  If so, let's save that somewhere so we can run
No, I used "replace".

As I mentioned on another patch, discussion of Cloudera-specific docs files is 
off-topic for this forum. Patches here are to Apache Impala (incubating).


-- 
To view, visit http://gerrit.cloudera.org:8080/5232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add Apache license header to files in doc directory

[John Russell (Code Review)]

John Russell has posted comments on this change.

Change subject: Add Apache license header to files in doc directory
..


Patch Set 2: Code-Review+2

(1 comment)

Looks good. (Does the +2 initiate any further transfer of files or do you as 
the code review creator still have to do all the followup git commands to get 
the changes over to master?)

http://gerrit.cloudera.org:8080/#/c/5232/2//COMMIT_MSG
Commit Message:

PS2, Line 7: Add Apache license header to files in doc directory
Is that another sed script?  If so, let's save that somewhere so we can run it 
independently on the files in the Cloudera repo. Simpler than doing diff/patch 
on all the files.


-- 
To view, visit http://gerrit.cloudera.org:8080/5232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add Apache license header to files in doc directory

[John Russell (Code Review)]

John Russell has submitted this change and it was merged.

Change subject: Add Apache license header to files in doc directory
..


Add Apache license header to files in doc directory

This now gives a clean RAT check with bin/check-rat-report.py, which
is one way for the Impala community to check compliance with ASF rules
on intellectual property.

Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036
Reviewed-on: http://gerrit.cloudera.org:8080/5232
Reviewed-by: Jim Apple 
Tested-by: Impala Public Jenkins
Reviewed-by: John Russell 
---
M bin/rat_exclude_files.txt
M docs/Cloudera-Impala-Release-Notes.ditamap
M docs/impala.ditamap
M docs/impala_html.ditaval
M docs/impala_pdf.ditaval
M docs/impala_sqlref.ditamap
M docs/shared/ImpalaVariables.xml
M docs/shared/impala_common.xml
M docs/topics/impala.xml
M docs/topics/impala_abort_on_default_limit_exceeded.xml
M docs/topics/impala_abort_on_error.xml
M docs/topics/impala_admin.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_aggregate_functions.xml
M docs/topics/impala_aliases.xml
M docs/topics/impala_allow_unsupported_formats.xml
M docs/topics/impala_alter_function.xml
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
M docs/topics/impala_analytic_functions.xml
M docs/topics/impala_appx_count_distinct.xml
M docs/topics/impala_appx_median.xml
M docs/topics/impala_array.xml
M docs/topics/impala_auditing.xml
M docs/topics/impala_authentication.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_avg.xml
M docs/topics/impala_avro.xml
M docs/topics/impala_batch_size.xml
M docs/topics/impala_bigint.xml
M docs/topics/impala_bit_functions.xml
M docs/topics/impala_boolean.xml
M docs/topics/impala_breakpad.xml
M docs/topics/impala_cdh.xml
M docs/topics/impala_char.xml
M docs/topics/impala_cluster_sizing.xml
M docs/topics/impala_cm_installation.xml
M docs/topics/impala_comments.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_components.xml
M docs/topics/impala_compression_codec.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_concepts.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_config.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_connecting.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_count.xml
M docs/topics/impala_create_data_source.xml
M docs/topics/impala_create_database.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_create_role.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_create_view.xml
M docs/topics/impala_data_sources.xml
M docs/topics/impala_databases.xml
M docs/topics/impala_datatypes.xml
M docs/topics/impala_date.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_ddl.xml
M docs/topics/impala_debug_action.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_default_order_by_limit.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_delete.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_development.xml
M docs/topics/impala_disable_cached_reads.xml
M docs/topics/impala_disable_codegen.xml
M docs/topics/impala_disable_outermost_topn.xml
M docs/topics/impala_disable_row_runtime_filtering.xml
M docs/topics/impala_disable_streaming_preaggregations.xml
M docs/topics/impala_disable_unsafe_spills.xml
M docs/topics/impala_disk_space.xml
M docs/topics/impala_distinct.xml
M docs/topics/impala_dml.xml
M docs/topics/impala_double.xml
M docs/topics/impala_drop_data_source.xml
M docs/topics/impala_drop_database.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_drop_role.xml
M docs/topics/impala_drop_stats.xml
M docs/topics/impala_drop_table.xml
M docs/topics/impala_drop_view.xml
M docs/topics/impala_errata.xml
M docs/topics/impala_exec_single_node_rows_threshold.xml
M docs/topics/impala_explain.xml
M docs/topics/impala_explain_level.xml
M docs/topics/impala_explain_plan.xml
M docs/topics/impala_faq.xml
M docs/topics/impala_faq_base.xml
M docs/topics/impala_features.xml
M docs/topics/impala_file_formats.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_float.xml
M docs/topics/impala_functions.xml
M docs/topics/impala_functions_overview.xml
M docs/topics/impala_glossary.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_group_by.xml
M docs/topics/impala_group_concat.xml
M docs/topics/impala_hadoop.xml
M docs/topics/impala_having.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_hbase_cache_blocks.xml
M docs/topics/impala_hbase_caching.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_howto_rm.xml
M docs/topics/impala_identifiers.xml
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_insert.xml
M docs/topics/impala_install.xml
M docs/topics/impala_int.xml
M docs/topics/impala_intro.xml
M 

[Impala-ASF-CR] Add Apache license header to files in doc directory

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Add Apache license header to files in doc directory
..


Patch Set 2:

> Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/4/

This job is just checking that "make" works and that the RAT check passes; it 
won't submit until there's a +2 on this patch.

-- 
To view, visit http://gerrit.cloudera.org:8080/5232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: No

[Impala-ASF-CR] Add Apache license header to files in doc directory

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: Add Apache license header to files in doc directory
..


Patch Set 2:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/4/

-- 
To view, visit http://gerrit.cloudera.org:8080/5232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: No

[Impala-ASF-CR] Add Apache license header to files in doc directory

[Greg Rahn (Code Review)]

Greg Rahn has posted comments on this change.

Change subject: Add Apache license header to files in doc directory
..


Patch Set 1: Code-Review+1

LGTM

-- 
To view, visit http://gerrit.cloudera.org:8080/5232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-HasComments: No

[Impala-ASF-CR] Add Apache license header to files in doc directory

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Add Apache license header to files in doc directory
..


Patch Set 1:

Once this is merged, we can add RAT checks to our pre-merge testing.

-- 
To view, visit http://gerrit.cloudera.org:8080/5232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-HasComments: No

[Impala-ASF-CR] Add Apache license header to files in doc directory

[Jim Apple (Code Review)]

Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5232

Change subject: Add Apache license header to files in doc directory
..

Add Apache license header to files in doc directory

This now gives a clean RAT check with bin/check-rat-report.py, which
is one way for the Impala community to check compliance with ASF rules
on intellectual property.

Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036
---
M bin/rat_exclude_files.txt
M docs/Cloudera-Impala-Release-Notes.ditamap
M docs/impala.ditamap
M docs/impala_html.ditaval
M docs/impala_pdf.ditaval
M docs/impala_sqlref.ditamap
M docs/shared/ImpalaVariables.xml
M docs/shared/impala_common.xml
M docs/topics/impala.xml
M docs/topics/impala_abort_on_default_limit_exceeded.xml
M docs/topics/impala_abort_on_error.xml
M docs/topics/impala_admin.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_aggregate_functions.xml
M docs/topics/impala_aliases.xml
M docs/topics/impala_allow_unsupported_formats.xml
M docs/topics/impala_alter_function.xml
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
M docs/topics/impala_analytic_functions.xml
M docs/topics/impala_appx_count_distinct.xml
M docs/topics/impala_appx_median.xml
M docs/topics/impala_array.xml
M docs/topics/impala_auditing.xml
M docs/topics/impala_authentication.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_avg.xml
M docs/topics/impala_avro.xml
M docs/topics/impala_batch_size.xml
M docs/topics/impala_bigint.xml
M docs/topics/impala_bit_functions.xml
M docs/topics/impala_boolean.xml
M docs/topics/impala_breakpad.xml
M docs/topics/impala_cdh.xml
M docs/topics/impala_char.xml
M docs/topics/impala_cluster_sizing.xml
M docs/topics/impala_cm_installation.xml
M docs/topics/impala_comments.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_components.xml
M docs/topics/impala_compression_codec.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_concepts.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_config.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_connecting.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_count.xml
M docs/topics/impala_create_data_source.xml
M docs/topics/impala_create_database.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_create_role.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_create_view.xml
M docs/topics/impala_data_sources.xml
M docs/topics/impala_databases.xml
M docs/topics/impala_datatypes.xml
M docs/topics/impala_date.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_ddl.xml
M docs/topics/impala_debug_action.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_default_order_by_limit.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_delete.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_development.xml
M docs/topics/impala_disable_cached_reads.xml
M docs/topics/impala_disable_codegen.xml
M docs/topics/impala_disable_outermost_topn.xml
M docs/topics/impala_disable_row_runtime_filtering.xml
M docs/topics/impala_disable_streaming_preaggregations.xml
M docs/topics/impala_disable_unsafe_spills.xml
M docs/topics/impala_disk_space.xml
M docs/topics/impala_distinct.xml
M docs/topics/impala_dml.xml
M docs/topics/impala_double.xml
M docs/topics/impala_drop_data_source.xml
M docs/topics/impala_drop_database.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_drop_role.xml
M docs/topics/impala_drop_stats.xml
M docs/topics/impala_drop_table.xml
M docs/topics/impala_drop_view.xml
M docs/topics/impala_errata.xml
M docs/topics/impala_exec_single_node_rows_threshold.xml
M docs/topics/impala_explain.xml
M docs/topics/impala_explain_level.xml
M docs/topics/impala_explain_plan.xml
M docs/topics/impala_faq.xml
M docs/topics/impala_faq_base.xml
M docs/topics/impala_features.xml
M docs/topics/impala_file_formats.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_float.xml
M docs/topics/impala_functions.xml
M docs/topics/impala_functions_overview.xml
M docs/topics/impala_glossary.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_group_by.xml
M docs/topics/impala_group_concat.xml
M docs/topics/impala_hadoop.xml
M docs/topics/impala_having.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_hbase_cache_blocks.xml
M docs/topics/impala_hbase_caching.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_howto_rm.xml
M docs/topics/impala_identifiers.xml
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_insert.xml
M docs/topics/impala_install.xml
M docs/topics/impala_int.xml
M docs/topics/impala_intro.xml
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_joins.xml
M docs/topics/impala_kerberos.xml