[GitHub] [spark] zhengruifeng commented on issue #26135: [SPARK-29489][ML][PySpark] ml.evaluation support log-loss

2019-10-18 Thread GitBox
zhengruifeng commented on issue #26135: [SPARK-29489][ML][PySpark] 
ml.evaluation support log-loss
URL: https://github.com/apache/spark/pull/26135#issuecomment-543645162
 
 
   merged to master, thanks @srowen for reviewing!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] skonto commented on issue #25229: [SPARK-27900][K8s] Add jvm oom flag

2019-10-18 Thread GitBox
skonto commented on issue #25229: [SPARK-27900][K8s] Add jvm oom flag
URL: https://github.com/apache/spark/pull/25229#issuecomment-543645501
 
 
   closing this in favor of https://github.com/apache/spark/pull/26161


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] skonto closed pull request #25229: [SPARK-27900][K8s] Add jvm oom flag

2019-10-18 Thread GitBox
skonto closed pull request #25229: [SPARK-27900][K8s] Add jvm oom flag
URL: https://github.com/apache/spark/pull/25229
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on a change in pull request #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-10-18 Thread GitBox
cloud-fan commented on a change in pull request #26080: [SPARK-29425][SQL] The 
ownership of a database should be respected
URL: https://github.com/apache/spark/pull/26080#discussion_r336419494
 
 

 ##
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
 ##
 @@ -576,6 +576,8 @@ case class CatalogDatabase(
 name: String,
 description: String,
 locationUri: URI,
+ownerName: String,
+ownerType: String,
 
 Review comment:
   can't we put them in the properties?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-18 Thread GitBox
SparkQA removed a comment on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS  
show '!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#issuecomment-543573443
 
 
   **[Test build #112263 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112263/testReport)**
 for PR 26053 at commit 
[`7ac4d16`](https://github.com/apache/spark/commit/7ac4d1612a99c3b2aaec93accab92a5c7dfea8aa).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS  show 
'!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#issuecomment-543684482
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26053: [SPARK-29379][SQL]SHOW 
FUNCTIONS  show '!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#issuecomment-543684482
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26053: [SPARK-29379][SQL]SHOW 
FUNCTIONS  show '!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#issuecomment-543684489
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112263/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25981: [SPARK-28420][SQL] Support the `INTERVAL` type in `date_part()`

2019-10-18 Thread GitBox
SparkQA commented on issue #25981: [SPARK-28420][SQL] Support the `INTERVAL` 
type in `date_part()`
URL: https://github.com/apache/spark/pull/25981#issuecomment-543684332
 
 
   **[Test build #112262 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112262/testReport)**
 for PR 25981 at commit 
[`5620472`](https://github.com/apache/spark/commit/5620472a26f57590f2d5a67b24b5295980641f1c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS  show 
'!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#issuecomment-543684489
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112263/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HeartSaVioR commented on a change in pull request #26153: [SPARK-29500][SQL][SS] Support partition column when writing to Kafka

2019-10-18 Thread GitBox
HeartSaVioR commented on a change in pull request #26153: 
[SPARK-29500][SQL][SS] Support partition column when writing to Kafka
URL: https://github.com/apache/spark/pull/26153#discussion_r336445511
 
 

 ##
 File path: 
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
 ##
 @@ -293,6 +293,21 @@ class KafkaSinkStreamingSuite extends KafkaSinkSuiteBase 
with StreamTest {
 }
 assert(ex.getMessage.toLowerCase(Locale.ROOT).contains(
   "key attribute type must be a string or binary"))
+
+try {
 
 Review comment:
   Actually I just submitted a patch #26158 to handle refactor to old ones: 
depending on which one to merge first, we can apply it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26155: [SPARK-27879][SQL] Add support for bit_and and bit_or aggregates

2019-10-18 Thread GitBox
SparkQA removed a comment on issue #26155: [SPARK-27879][SQL] Add support for 
bit_and and bit_or aggregates
URL: https://github.com/apache/spark/pull/26155#issuecomment-543600948
 
 
   **[Test build #112266 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112266/testReport)**
 for PR 26155 at commit 
[`58b99e9`](https://github.com/apache/spark/commit/58b99e92e13a7bf99450bf3233945388cbc496d4).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] redsk commented on a change in pull request #26153: [SPARK-29500][SQL][SS] Support partition column when writing to Kafka

2019-10-18 Thread GitBox
redsk commented on a change in pull request #26153: [SPARK-29500][SQL][SS] 
Support partition column when writing to Kafka
URL: https://github.com/apache/spark/pull/26153#discussion_r336474422
 
 

 ##
 File path: 
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
 ##
 @@ -404,20 +420,85 @@ abstract class KafkaSinkBatchSuiteBase extends 
KafkaSinkSuiteBase {
   .save()
 checkAnswer(
   createKafkaReader(topic, includeHeaders = true).selectExpr(
-"CAST(value as STRING) value", "headers"
+"CAST(value as STRING) value", "headers", "partition"
   ),
-  Row("1", Seq(Row("a", "b".getBytes(UTF_8 ::
-Row("2", Seq(Row("c", "d".getBytes(UTF_8)), Row("e", 
"f".getBytes(UTF_8 ::
-Row("3", Seq(Row("g", "h".getBytes(UTF_8)), Row("g", 
"i".getBytes(UTF_8 ::
-Row("4", null) ::
+  Row("1", Seq(Row("a", "b".getBytes(UTF_8))), 0) ::
+Row("2", Seq(Row("c", "d".getBytes(UTF_8)), Row("e", 
"f".getBytes(UTF_8))), 1) ::
+Row("3", Seq(Row("g", "h".getBytes(UTF_8)), Row("g", 
"i".getBytes(UTF_8))), 2) ::
+Row("4", null, 3) ::
 Row("5", Seq(
   Row("j", "k".getBytes(UTF_8)),
   Row("j", "l".getBytes(UTF_8)),
-  Row("m", "n".getBytes(UTF_8 ::
+  Row("m", "n".getBytes(UTF_8))), 0) ::
 Nil
 )
   }
 
+  test("batch - partition column vs default Kafka partitioner") {
 
 Review comment:
   > Yes, the code can be enhanced several places but that doesn't mean we have 
to do the same copy-paste.
   
   There are different opinions on copy-paste in UTs and I just copied the 
pattern in use in the file. But I also lean towards *not* copy-pasting. I can 
write a small function for that. Shall I apply it to other tests in the same 
function or just my contribution?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] srowen commented on a change in pull request #26146: [SPARK-24576][DOCS][FOLLOW-UP] Fix incorrect ORC version in the doc

2019-10-18 Thread GitBox
srowen commented on a change in pull request #26146: 
[SPARK-24576][DOCS][FOLLOW-UP] Fix incorrect ORC version in the doc
URL: https://github.com/apache/spark/pull/26146#discussion_r336479878
 
 

 ##
 File path: docs/sql-data-sources-orc.md
 ##
 @@ -31,7 +31,7 @@ the vectorized reader is used when 
`spark.sql.hive.convertMetastoreOrc` is also
   
 spark.sql.orc.impl
 native
-The name of ORC implementation. It can be one of native 
and hive. native means the native ORC support that is 
built on Apache ORC 1.4. `hive` means the ORC library in Hive 1.2.1.
+The name of ORC implementation. It can be one of native 
and hive. native means the native ORC support. 
hive means the ORC library in Hive 1.2.1.
 
 Review comment:
   Can you also remove 1.2.1?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The 
ownership of a database should be respected
URL: https://github.com/apache/spark/pull/26080#issuecomment-543739396
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17260/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The 
ownership of a database should be respected
URL: https://github.com/apache/spark/pull/26080#issuecomment-543739386
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26153: [SPARK-29500][SQL][SS] Support partition column when writing to Kafka

2019-10-18 Thread GitBox
gaborgsomogyi commented on a change in pull request #26153: 
[SPARK-29500][SQL][SS] Support partition column when writing to Kafka
URL: https://github.com/apache/spark/pull/26153#discussion_r33659
 
 

 ##
 File path: 
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
 ##
 @@ -404,20 +420,85 @@ abstract class KafkaSinkBatchSuiteBase extends 
KafkaSinkSuiteBase {
   .save()
 checkAnswer(
   createKafkaReader(topic, includeHeaders = true).selectExpr(
-"CAST(value as STRING) value", "headers"
+"CAST(value as STRING) value", "headers", "partition"
   ),
-  Row("1", Seq(Row("a", "b".getBytes(UTF_8 ::
-Row("2", Seq(Row("c", "d".getBytes(UTF_8)), Row("e", 
"f".getBytes(UTF_8 ::
-Row("3", Seq(Row("g", "h".getBytes(UTF_8)), Row("g", 
"i".getBytes(UTF_8 ::
-Row("4", null) ::
+  Row("1", Seq(Row("a", "b".getBytes(UTF_8))), 0) ::
+Row("2", Seq(Row("c", "d".getBytes(UTF_8)), Row("e", 
"f".getBytes(UTF_8))), 1) ::
+Row("3", Seq(Row("g", "h".getBytes(UTF_8)), Row("g", 
"i".getBytes(UTF_8))), 2) ::
+Row("4", null, 3) ::
 Row("5", Seq(
   Row("j", "k".getBytes(UTF_8)),
   Row("j", "l".getBytes(UTF_8)),
-  Row("m", "n".getBytes(UTF_8 ::
+  Row("m", "n".getBytes(UTF_8))), 0) ::
 Nil
 )
   }
 
+  test("batch - partition column vs default Kafka partitioner") {
 
 Review comment:
   In order not to have feature creep I would suggest to keep this for you 
change set. Later we can file another PR for the rest...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26134: [SPARK-29486][SQL] CalendarInterval should have 3 fields: months, days and microseconds

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26134: [SPARK-29486][SQL] 
CalendarInterval should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#issuecomment-543771826
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26134: [SPARK-29486][SQL] CalendarInterval should have 3 fields: months, days and microseconds

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26134: [SPARK-29486][SQL] 
CalendarInterval should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#issuecomment-543771840
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17264/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26162: [SPARK-29438][SS] Use partition ID of StateStoreAwareZipPartitionsRDD for determining partition ID of state store in stream-stream join

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26162: [SPARK-29438][SS] Use partition ID of 
StateStoreAwareZipPartitionsRDD for determining partition ID of state store in 
stream-stream join
URL: https://github.com/apache/spark/pull/26162#issuecomment-543772241
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112273/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26162: [SPARK-29438][SS] Use partition ID of StateStoreAwareZipPartitionsRDD for determining partition ID of state store in stream-stream joi

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26162: [SPARK-29438][SS] Use 
partition ID of StateStoreAwareZipPartitionsRDD for determining partition ID of 
state store in stream-stream join
URL: https://github.com/apache/spark/pull/26162#issuecomment-543772229
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26162: [SPARK-29438][SS] Use partition ID of StateStoreAwareZipPartitionsRDD for determining partition ID of state store in stream-stream joi

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26162: [SPARK-29438][SS] Use 
partition ID of StateStoreAwareZipPartitionsRDD for determining partition ID of 
state store in stream-stream join
URL: https://github.com/apache/spark/pull/26162#issuecomment-543772241
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112273/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26134: [SPARK-29486][SQL] CalendarInterval should have 3 fields: months, days and microseconds

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26134: [SPARK-29486][SQL] CalendarInterval 
should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#issuecomment-543771840
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17264/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26134: [SPARK-29486][SQL] CalendarInterval should have 3 fields: months, days and microseconds

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26134: [SPARK-29486][SQL] CalendarInterval 
should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#issuecomment-543771826
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26162: [SPARK-29438][SS] Use partition ID of StateStoreAwareZipPartitionsRDD for determining partition ID of state store in stream-stream join

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26162: [SPARK-29438][SS] Use partition ID of 
StateStoreAwareZipPartitionsRDD for determining partition ID of state store in 
stream-stream join
URL: https://github.com/apache/spark/pull/26162#issuecomment-543772229
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-10-18 Thread GitBox
SparkQA commented on issue #25971: [SPARK-29298][CORE] Separate block manager 
heartbeat endpoint from driver endpoint
URL: https://github.com/apache/spark/pull/25971#issuecomment-543541720
 
 
   **[Test build #112249 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112249/testReport)**
 for PR 25971 at commit 
[`cb6c4f6`](https://github.com/apache/spark/commit/cb6c4f6842ae977c4f664703c1f3df5b23a0a004).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26151: [SPARK-29502][SQL] typed interval expression should fail for invalid format

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26151: [SPARK-29502][SQL] typed interval 
expression should fail for invalid format
URL: https://github.com/apache/spark/pull/26151#issuecomment-543556541
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112254/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26156: [SPARK-29438][SS] Failed to get state store when task number is not determinate

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26156: [SPARK-29438][SS] Failed to get state 
store when task number is not determinate
URL: https://github.com/apache/spark/pull/26156#issuecomment-543556619
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112251/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26155: [SPARK-27879][SQL] Add support for bit_and and bit_or aggregates

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26155: [SPARK-27879][SQL] Add support 
for bit_and and bit_or aggregates
URL: https://github.com/apache/spark/pull/26155#issuecomment-543556108
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE should look up catalog/table like v2 commands

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE 
should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26129#issuecomment-543556499
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112255/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26157: [SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26157: [SPARK-28560][SQL][followup] resolve 
the remaining comments for PR#25295
URL: https://github.com/apache/spark/pull/26157#issuecomment-543556413
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112256/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26151: [SPARK-29502][SQL] typed interval expression should fail for invalid format

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26151: [SPARK-29502][SQL] typed interval 
expression should fail for invalid format
URL: https://github.com/apache/spark/pull/26151#issuecomment-543556529
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26157: [SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295

2019-10-18 Thread GitBox
SparkQA commented on issue #26157: [SPARK-28560][SQL][followup] resolve the 
remaining comments for PR#25295
URL: https://github.com/apache/spark/pull/26157#issuecomment-543556339
 
 
   **[Test build #112256 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112256/testReport)**
 for PR 26157 at commit 
[`f17db39`](https://github.com/apache/spark/commit/f17db393b778f8f79d9659627e94d960307cd2da).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE should look up catalog/table like v2 commands

2019-10-18 Thread GitBox
SparkQA removed a comment on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE 
should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26129#issuecomment-543531473
 
 
   **[Test build #112255 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112255/testReport)**
 for PR 26129 at commit 
[`78e1495`](https://github.com/apache/spark/commit/78e1495fa3a5e85af4795fafc9c3a72ae40a8038).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26156: [SPARK-29438][SS] Failed to get state store when task number is not determinate

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26156: [SPARK-29438][SS] Failed to 
get state store when task number is not determinate
URL: https://github.com/apache/spark/pull/26156#issuecomment-543556607
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26157: [SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26157: [SPARK-28560][SQL][followup] 
resolve the remaining comments for PR#25295
URL: https://github.com/apache/spark/pull/26157#issuecomment-543556403
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26156: [SPARK-29438][SS] Failed to get state store when task number is not determinate

2019-10-18 Thread GitBox
SparkQA removed a comment on issue #26156: [SPARK-29438][SS] Failed to get 
state store when task number is not determinate
URL: https://github.com/apache/spark/pull/26156#issuecomment-543493154
 
 
   **[Test build #112251 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112251/testReport)**
 for PR 26156 at commit 
[`f25e4ac`](https://github.com/apache/spark/commit/f25e4acf91c517c33afce444c1e45bae71cf6d2a).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26151: [SPARK-29502][SQL] typed interval expression should fail for invalid format

2019-10-18 Thread GitBox
SparkQA removed a comment on issue #26151: [SPARK-29502][SQL] typed interval 
expression should fail for invalid format
URL: https://github.com/apache/spark/pull/26151#issuecomment-543518902
 
 
   **[Test build #112254 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112254/testReport)**
 for PR 26151 at commit 
[`5a375eb`](https://github.com/apache/spark/commit/5a375eb520602e68f3b4c0faceb6c56a33461b13).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26157: [SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295

2019-10-18 Thread GitBox
SparkQA removed a comment on issue #26157: [SPARK-28560][SQL][followup] resolve 
the remaining comments for PR#25295
URL: https://github.com/apache/spark/pull/26157#issuecomment-543548538
 
 
   **[Test build #112256 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112256/testReport)**
 for PR 26157 at commit 
[`f17db39`](https://github.com/apache/spark/commit/f17db393b778f8f79d9659627e94d960307cd2da).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE should look up catalog/table like v2 commands

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26129: [SPARK-29482][SQL] ANALYZE 
TABLE should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26129#issuecomment-543556490
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26151: [SPARK-29502][SQL] typed interval expression should fail for invalid format

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26151: [SPARK-29502][SQL] typed 
interval expression should fail for invalid format
URL: https://github.com/apache/spark/pull/26151#issuecomment-543556529
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE should look up catalog/table like v2 commands

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE 
should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26129#issuecomment-543556490
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26157: [SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26157: [SPARK-28560][SQL][followup] resolve 
the remaining comments for PR#25295
URL: https://github.com/apache/spark/pull/26157#issuecomment-543556403
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26151: [SPARK-29502][SQL] typed interval expression should fail for invalid format

2019-10-18 Thread GitBox
SparkQA commented on issue #26151: [SPARK-29502][SQL] typed interval expression 
should fail for invalid format
URL: https://github.com/apache/spark/pull/26151#issuecomment-543556346
 
 
   **[Test build #112254 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112254/testReport)**
 for PR 26151 at commit 
[`5a375eb`](https://github.com/apache/spark/commit/5a375eb520602e68f3b4c0faceb6c56a33461b13).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26156: [SPARK-29438][SS] Failed to get state store when task number is not determinate

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26156: [SPARK-29438][SS] Failed to get state 
store when task number is not determinate
URL: https://github.com/apache/spark/pull/26156#issuecomment-543556607
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE should look up catalog/table like v2 commands

2019-10-18 Thread GitBox
SparkQA commented on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE should look 
up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26129#issuecomment-543556347
 
 
   **[Test build #112255 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112255/testReport)**
 for PR 26129 at commit 
[`78e1495`](https://github.com/apache/spark/commit/78e1495fa3a5e85af4795fafc9c3a72ae40a8038).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26155: [SPARK-27879][SQL] Add support for bit_and and bit_or aggregates

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26155: [SPARK-27879][SQL] Add support for 
bit_and and bit_or aggregates
URL: https://github.com/apache/spark/pull/26155#issuecomment-543556118
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112250/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26156: [SPARK-29438][SS] Failed to get state store when task number is not determinate

2019-10-18 Thread GitBox
SparkQA commented on issue #26156: [SPARK-29438][SS] Failed to get state store 
when task number is not determinate
URL: https://github.com/apache/spark/pull/26156#issuecomment-543556344
 
 
   **[Test build #112251 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112251/testReport)**
 for PR 26156 at commit 
[`f25e4ac`](https://github.com/apache/spark/commit/f25e4acf91c517c33afce444c1e45bae71cf6d2a).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26159: [SPARK-29506][SQL] Use dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26159: [SPARK-29506][SQL] Use 
dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table
URL: https://github.com/apache/spark/pull/26159#issuecomment-543556291
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17242/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26155: [SPARK-27879][SQL] Add support for bit_and and bit_or aggregates

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26155: [SPARK-27879][SQL] Add support for 
bit_and and bit_or aggregates
URL: https://github.com/apache/spark/pull/26155#issuecomment-543556108
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26159: [SPARK-29506][SQL] Use dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26159: [SPARK-29506][SQL] Use 
dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table
URL: https://github.com/apache/spark/pull/26159#issuecomment-543556280
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26155: [SPARK-27879][SQL] Add support for bit_and and bit_or aggregates

2019-10-18 Thread GitBox
SparkQA removed a comment on issue #26155: [SPARK-27879][SQL] Add support for 
bit_and and bit_or aggregates
URL: https://github.com/apache/spark/pull/26155#issuecomment-543490967
 
 
   **[Test build #112250 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112250/testReport)**
 for PR 26155 at commit 
[`b6c246e`](https://github.com/apache/spark/commit/b6c246e3ce43e2da5da60dee8787a141ec42a501).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] francis0407 commented on issue #23783: [SPARK-26854][SQL] Support ANY/SOME subquery

2019-10-18 Thread GitBox
francis0407 commented on issue #23783: [SPARK-26854][SQL] Support ANY/SOME 
subquery
URL: https://github.com/apache/spark/pull/23783#issuecomment-543563886
 
 
   Friendly ping @cloud-fan, @viirya, @dongjoon-hyun . Could you please take a 
look here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25981: [SPARK-28420][SQL] Support the `INTERVAL` type in `date_part()`

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #25981: [SPARK-28420][SQL] Support the 
`INTERVAL` type in `date_part()`
URL: https://github.com/apache/spark/pull/25981#issuecomment-543570568
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17247/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25981: [SPARK-28420][SQL] Support the `INTERVAL` type in `date_part()`

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #25981: [SPARK-28420][SQL] Support the 
`INTERVAL` type in `date_part()`
URL: https://github.com/apache/spark/pull/25981#issuecomment-543570560
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-18 Thread GitBox
cloud-fan commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS  show 
'!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#issuecomment-543570816
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25981: [SPARK-28420][SQL] Support the `INTERVAL` type in `date_part()`

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #25981: [SPARK-28420][SQL] Support the 
`INTERVAL` type in `date_part()`
URL: https://github.com/apache/spark/pull/25981#issuecomment-543570568
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17247/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25981: [SPARK-28420][SQL] Support the `INTERVAL` type in `date_part()`

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #25981: [SPARK-28420][SQL] Support the 
`INTERVAL` type in `date_part()`
URL: https://github.com/apache/spark/pull/25981#issuecomment-543570560
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS  show 
'!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#issuecomment-543574258
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS  show 
'!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#issuecomment-543574270
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17248/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26053: [SPARK-29379][SQL]SHOW 
FUNCTIONS  show '!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#issuecomment-543574258
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26053: [SPARK-29379][SQL]SHOW 
FUNCTIONS  show '!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#issuecomment-543574270
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17248/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26157: [SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26157: [SPARK-28560][SQL][followup] 
resolve the remaining comments for PR#25295
URL: https://github.com/apache/spark/pull/26157#issuecomment-543582022
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26157: [SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26157: [SPARK-28560][SQL][followup] resolve 
the remaining comments for PR#25295
URL: https://github.com/apache/spark/pull/26157#issuecomment-543582022
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26157: [SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26157: [SPARK-28560][SQL][followup] 
resolve the remaining comments for PR#25295
URL: https://github.com/apache/spark/pull/26157#issuecomment-543582035
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17249/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #26098: [SPARK-29444] Add configuration to support JacksonGenrator to keep fields with null values

2019-10-18 Thread GitBox
cloud-fan commented on issue #26098: [SPARK-29444] Add configuration to support 
JacksonGenrator to keep fields with null values
URL: https://github.com/apache/spark/pull/26098#issuecomment-543585947
 
 
   thanks, merging to master!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan closed pull request #26098: [SPARK-29444] Add configuration to support JacksonGenrator to keep fields with null values

2019-10-18 Thread GitBox
cloud-fan closed pull request #26098: [SPARK-29444] Add configuration to 
support JacksonGenrator to keep fields with null values
URL: https://github.com/apache/spark/pull/26098
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The 
ownership of a database should be respected
URL: https://github.com/apache/spark/pull/26080#issuecomment-543606125
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17252/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26080: [SPARK-29425][SQL] The ownership of a 
database should be respected
URL: https://github.com/apache/spark/pull/26080#issuecomment-543606113
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26080: [SPARK-29425][SQL] The ownership of a 
database should be respected
URL: https://github.com/apache/spark/pull/26080#issuecomment-543606125
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17252/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The 
ownership of a database should be respected
URL: https://github.com/apache/spark/pull/26080#issuecomment-543606113
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26159: [SPARK-29506][SQL] Use dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table

2019-10-18 Thread GitBox
SparkQA commented on issue #26159: [SPARK-29506][SQL] Use 
dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table
URL: https://github.com/apache/spark/pull/26159#issuecomment-543619787
 
 
   **[Test build #112257 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112257/testReport)**
 for PR 26159 at commit 
[`669c7fa`](https://github.com/apache/spark/commit/669c7fa773b34c3420cea9a9ef45bf1a9cde5c47).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] itsvikramagr commented on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-10-18 Thread GitBox
itsvikramagr commented on issue #24922: [SPARK-28120][SS]  Rocksdb state 
storage implementation
URL: https://github.com/apache/spark/pull/24922#issuecomment-543619888
 
 
   @marmbrus / @gatorsmile  - Got your point on making it an external package. 
I will close the PR and corresponding JIRA. Will update this thread once I have 
submitted it to https://spark-packages.org/?
   
   Thanks, @gaborgsomogyi @HeartSaVioR @dongjoon-hyun @PingHao  for looking 
into the PR and helped me to make significant improvements.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] itsvikramagr closed pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-10-18 Thread GitBox
itsvikramagr closed pull request #24922: [SPARK-28120][SS]  Rocksdb state 
storage implementation
URL: https://github.com/apache/spark/pull/24922
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26120: [SPARK-29014][SQL] DataSourceV2: Fix current/default catalog usage

2019-10-18 Thread GitBox
SparkQA commented on issue #26120: [SPARK-29014][SQL] DataSourceV2: Fix 
current/default catalog usage
URL: https://github.com/apache/spark/pull/26120#issuecomment-543626018
 
 
   **[Test build #112269 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112269/testReport)**
 for PR 26120 at commit 
[`b93c5e3`](https://github.com/apache/spark/commit/b93c5e362e6492f86723f334cc891485b370ec4f).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] skonto edited a comment on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-10-18 Thread GitBox
skonto edited a comment on issue #24922: [SPARK-28120][SS]  Rocksdb state 
storage implementation
URL: https://github.com/apache/spark/pull/24922#issuecomment-543634413
 
 
   @marmbrus @itsvikramagr  Flink has supported this at the right level for 
them (https://github.com/apache/flink/tree/master/flink-state-backends). These 
backends dont change much and the benefits of using RockDB with checkpointing 
for large states are important, at least for Flink which emphasizes on stateful 
apps a lot. There is always a trade-off anyway. Having apis is the way to go 
for many parts but also some default, reference implementation is helpful 
especially if it makes a difference. Packages outside of the core project could 
become outdated fast I am afraid.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] skonto commented on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-10-18 Thread GitBox
skonto commented on issue #24922: [SPARK-28120][SS]  Rocksdb state storage 
implementation
URL: https://github.com/apache/spark/pull/24922#issuecomment-543634413
 
 
   @marmbrus @itsvikramagr  Flink has supported this at the right level for 
them (https://github.com/apache/flink/tree/master/flink-state-backends). These 
backends dont change much and the benefits of using RockDB with checkpointing 
for large states are important, at least for Flink which emphasizes on stateful 
apps a lot. There is always a trade-off anyway.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on a change in pull request #26157: [SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295

2019-10-18 Thread GitBox
cloud-fan commented on a change in pull request #26157: 
[SPARK-28560][SQL][followup] resolve the remaining comments for PR#25295
URL: https://github.com/apache/spark/pull/26157#discussion_r336342585
 
 

 ##
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
 ##
 @@ -229,6 +229,8 @@ class AdaptiveQueryExecSuite
   assert(smj.size == 3)
   val bhj = findTopLevelBroadcastHashJoin(adaptivePlan)
   assert(bhj.size == 2)
+  checkNumLocalShuffleReaders(adaptivePlan, 1)
 
 Review comment:
   there are 2 broadcast joins, but we only have 1 local shuffle reader. Why is 
it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] uncleGen commented on issue #26156: [SPARK-29438][SS] Failed to get state store when task number is not determinate

2019-10-18 Thread GitBox
uncleGen commented on issue #26156: [SPARK-29438][SS] Failed to get state store 
when task number is not determinate
URL: https://github.com/apache/spark/pull/26156#issuecomment-543558998
 
 
   retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26159: [SPARK-29506][SQL] Use dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table

2019-10-18 Thread GitBox
SparkQA commented on issue #26159: [SPARK-29506][SQL] Use 
dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table
URL: https://github.com/apache/spark/pull/26159#issuecomment-543559171
 
 
   **[Test build #112257 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112257/testReport)**
 for PR 26159 at commit 
[`669c7fa`](https://github.com/apache/spark/commit/669c7fa773b34c3420cea9a9ef45bf1a9cde5c47).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE should look up catalog/table like v2 commands

2019-10-18 Thread GitBox
SparkQA commented on issue #26129: [SPARK-29482][SQL] ANALYZE TABLE should look 
up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26129#issuecomment-543559210
 
 
   **[Test build #112259 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112259/testReport)**
 for PR 26129 at commit 
[`78e1495`](https://github.com/apache/spark/commit/78e1495fa3a5e85af4795fafc9c3a72ae40a8038).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25981: [SPARK-28420][SQL] Support the `INTERVAL` type in `date_part()`

2019-10-18 Thread GitBox
SparkQA commented on issue #25981: [SPARK-28420][SQL] Support the `INTERVAL` 
type in `date_part()`
URL: https://github.com/apache/spark/pull/25981#issuecomment-543559212
 
 
   **[Test build #112260 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112260/testReport)**
 for PR 25981 at commit 
[`d4375b5`](https://github.com/apache/spark/commit/d4375b5a938c6a93708059fcf66402d8782e8731).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26151: [SPARK-29502][SQL] typed interval expression should fail for invalid format

2019-10-18 Thread GitBox
SparkQA commented on issue #26151: [SPARK-29502][SQL] typed interval expression 
should fail for invalid format
URL: https://github.com/apache/spark/pull/26151#issuecomment-543559175
 
 
   **[Test build #112258 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112258/testReport)**
 for PR 26151 at commit 
[`5a375eb`](https://github.com/apache/spark/commit/5a375eb520602e68f3b4c0faceb6c56a33461b13).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26159: [SPARK-29506][SQL] Use dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26159: [SPARK-29506][SQL] Use 
dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table
URL: https://github.com/apache/spark/pull/26159#issuecomment-543556280
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26159: [SPARK-29506][SQL] Use dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26159: [SPARK-29506][SQL] Use 
dynamicPartitionOverwrite in FileCommitProtocol when insert into hive table
URL: https://github.com/apache/spark/pull/26159#issuecomment-543556291
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17242/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #20690: [SPARK-23532][Standalone]Improve data locality when launching new executors for dynamic allocation

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #20690: [SPARK-23532][Standalone]Improve data 
locality when launching new executors for dynamic allocation
URL: https://github.com/apache/spark/pull/20690#issuecomment-543613857
 
 
   Build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #20690: [SPARK-23532][Standalone]Improve data locality when launching new executors for dynamic allocation

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #20690: [SPARK-23532][Standalone]Improve data 
locality when launching new executors for dynamic allocation
URL: https://github.com/apache/spark/pull/20690#issuecomment-543613880
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112268/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #20690: [SPARK-23532][Standalone]Improve data locality when launching new executors for dynamic allocation

2019-10-18 Thread GitBox
SparkQA commented on issue #20690: [SPARK-23532][Standalone]Improve data 
locality when launching new executors for dynamic allocation
URL: https://github.com/apache/spark/pull/20690#issuecomment-543613839
 
 
   **[Test build #112268 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112268/testReport)**
 for PR 20690 at commit 
[`1d01b2b`](https://github.com/apache/spark/commit/1d01b2b5c34c4bc0934f1fbcb3789ad2d80ae99b).
* This patch **fails R style tests**.
* This patch **does not merge cleanly**.
* This patch adds the following public classes _(experimental)_:
 * `  case class RequestExecutors(appId: String, requestedTotal: Int,`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #20690: [SPARK-23532][Standalone]Improve data locality when launching new executors for dynamic allocation

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #20690: 
[SPARK-23532][Standalone]Improve data locality when launching new executors for 
dynamic allocation
URL: https://github.com/apache/spark/pull/20690#issuecomment-543613857
 
 
   Build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #20690: [SPARK-23532][Standalone]Improve data locality when launching new executors for dynamic allocation

2019-10-18 Thread GitBox
SparkQA removed a comment on issue #20690: [SPARK-23532][Standalone]Improve 
data locality when launching new executors for dynamic allocation
URL: https://github.com/apache/spark/pull/20690#issuecomment-543605294
 
 
   **[Test build #112268 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112268/testReport)**
 for PR 20690 at commit 
[`1d01b2b`](https://github.com/apache/spark/commit/1d01b2b5c34c4bc0934f1fbcb3789ad2d80ae99b).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26120: [SPARK-29014][SQL] DataSourceV2: Fix current/default catalog usage

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26120: [SPARK-29014][SQL] DataSourceV2: Fix 
current/default catalog usage
URL: https://github.com/apache/spark/pull/26120#issuecomment-543626738
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17253/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26120: [SPARK-29014][SQL] DataSourceV2: Fix current/default catalog usage

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26120: [SPARK-29014][SQL] DataSourceV2: Fix 
current/default catalog usage
URL: https://github.com/apache/spark/pull/26120#issuecomment-543626724
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26120: [SPARK-29014][SQL] DataSourceV2: Fix current/default catalog usage

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26120: [SPARK-29014][SQL] 
DataSourceV2: Fix current/default catalog usage
URL: https://github.com/apache/spark/pull/26120#issuecomment-543626724
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26120: [SPARK-29014][SQL] DataSourceV2: Fix current/default catalog usage

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26120: [SPARK-29014][SQL] 
DataSourceV2: Fix current/default catalog usage
URL: https://github.com/apache/spark/pull/26120#issuecomment-543626738
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17253/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26146: [SPARK-24576][DOCS][FOLLOW-UP] Fix incorrect ORC version in the doc

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26146: [SPARK-24576][DOCS][FOLLOW-UP] Fix 
incorrect ORC version in the doc
URL: https://github.com/apache/spark/pull/26146#issuecomment-543589586
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17250/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26146: [SPARK-24576][DOCS][FOLLOW-UP] Fix incorrect ORC version in the doc

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26146: [SPARK-24576][DOCS][FOLLOW-UP] Fix 
incorrect ORC version in the doc
URL: https://github.com/apache/spark/pull/26146#issuecomment-543589579
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26155: [SPARK-27879][SQL] Add support for bit_and and bit_or aggregates

2019-10-18 Thread GitBox
AmplabJenkins removed a comment on issue #26155: [SPARK-27879][SQL] Add support 
for bit_and and bit_or aggregates
URL: https://github.com/apache/spark/pull/26155#issuecomment-543601774
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17251/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-10-18 Thread GitBox
yaooqinn commented on issue #26080: [SPARK-29425][SQL] The ownership of a 
database should be respected
URL: https://github.com/apache/spark/pull/26080#issuecomment-543601998
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26155: [SPARK-27879][SQL] Add support for bit_and and bit_or aggregates

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26155: [SPARK-27879][SQL] Add support for 
bit_and and bit_or aggregates
URL: https://github.com/apache/spark/pull/26155#issuecomment-543601765
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26155: [SPARK-27879][SQL] Add support for bit_and and bit_or aggregates

2019-10-18 Thread GitBox
AmplabJenkins commented on issue #26155: [SPARK-27879][SQL] Add support for 
bit_and and bit_or aggregates
URL: https://github.com/apache/spark/pull/26155#issuecomment-543601774
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17251/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



  1   2   3   4   5   6   7   8   9   10   >