cvs commit: jakarta-tomcat-4.0/webapps/admin index.jsp

[manveen]

manveen 02/04/30 23:02:57

  Modified:webapps/admin index.jsp
  Log:
  * Made the borders of the various frames visible so that the user knows they can be 
resized.
  
  Revision  ChangesPath
  1.9   +2 -2  jakarta-tomcat-4.0/webapps/admin/index.jsp
  
  Index: index.jsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/index.jsp,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- index.jsp 11 Dec 2001 22:54:12 -  1.8
  +++ index.jsp 1 May 2002 06:02:56 -   1.9
  @@ -13,9 +13,9 @@
   
   
   
  -
  +
 
  -  
  +  
   
   
 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6468] - content-type not set for errors

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6468

content-type not set for errors





--- Additional Comments From [EMAIL PROTECTED]  2002-05-01 05:03 
---
Where has this been fixed? I'm running tomcat 4.03 and mod_webapp compiled from
the sources in the 4.03 release dir, and it still happens. Do I need a CVS version?

Apache 1.3.19
Content type is getting set to text/plain

Thanks

Tom

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Modification of Jasper2's Generator.java

[Bill Barker]

- Original Message -
From: "Denis Benoit" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Tuesday, April 30, 2002 8:52 PM
Subject: Modification of Jasper2's Generator.java


> I was reading Remy's comments on the Generator.java patch and I noted two
> things:
>
> 1. It could be possible to not always create a Vector and a BitSet if we
>declare them as instance variables instead of local variables.  This
>way we could defer their initialisation in the addTagToVector method;
>

No, if they are instance variables, then you quickly fall into thread-safety
hell.  If you have 20 different people accessing the same JSP page at the
same time, then you have no clue as to which tag is in the Vector.

> 2. It was not necessary to call the addTagToVector method in the
>generateCustomEnd.  In this method we are merely accessing the tag
whose
>index was popped from the stack.  Since we call addTagToVector when
>we begin the pseudo "try" block, it follows that the tag is already
>in the vector when we reach the pseudo "finally" block;
>
> Thanks!
>
> --
> Denis Benoit
> [EMAIL PROTECTED]
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_workerEnv.c

[costin]

costin  02/04/30 21:18:34

  Modified:jk/native2/common jk_workerEnv.c
  Log:
  Small fix - ajp13/worker.ajp13 ( Nacho - you were right, that was broken )
  
  Revision  ChangesPath
  1.31  +3 -2  jakarta-tomcat-connectors/jk/native2/common/jk_workerEnv.c
  
  Index: jk_workerEnv.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_workerEnv.c,v
  retrieving revision 1.30
  retrieving revision 1.31
  diff -u -r1.30 -r1.31
  --- jk_workerEnv.c25 Apr 2002 19:20:46 -  1.30
  +++ jk_workerEnv.c1 May 2002 04:18:34 -   1.31
  @@ -59,7 +59,7 @@
* Description: Workers controller *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Author:  Henri Gomez <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.30 $   *
  + * Version: $Revision: 1.31 $   *
***/
   
   #include "jk_env.h"
  @@ -188,7 +188,8 @@
 name); 
   } else {
   /* Add the worker automatically in the 'default' lb and in any 
group */
  -if( strncmp( "worker.ajp13", w->mbean->name, 12 ) == 0 ) {
  +if( strncmp( "worker.ajp13", w->mbean->name, 12 ) == 0 ||
  +strncmp( "ajp13", w->mbean->name, 5 ) == 0 ) {
   /* It's a forwarding worker */
   lb->mbean->setAttribute(env, lb->mbean, "balanced_workers",
   w->mbean->name);
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Modification of Jasper2's Generator.java

[Denis Benoit]

I was reading Remy's comments on the Generator.java patch and I noted two
things:

1. It could be possible to not always create a Vector and a BitSet if we
   declare them as instance variables instead of local variables.  This
   way we could defer their initialisation in the addTagToVector method;

2. It was not necessary to call the addTagToVector method in the
   generateCustomEnd.  In this method we are merely accessing the tag whose
   index was popped from the stack.  Since we call addTagToVector when
   we begin the pseudo "try" block, it follows that the tag is already
   in the vector when we reach the pseudo "finally" block;

Thanks!

-- 
Denis Benoit
[EMAIL PROTECTED]


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServlet.java JspServletWrapper.java

[glenn]

glenn   02/04/30 19:40:37

  Modified:jasper2/src/share/org/apache/jasper JspEngineContext.java
   jasper2/src/share/org/apache/jasper/servlet JspServlet.java
JspServletWrapper.java
  Log:
  Reformat code to more closely match coding conventions
  
  Revision  ChangesPath
  1.5   +22 -29
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspEngineContext.java
  
  Index: JspEngineContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspEngineContext.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- JspEngineContext.java 1 May 2002 01:33:42 -   1.4
  +++ JspEngineContext.java 1 May 2002 02:40:37 -   1.5
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspEngineContext.java,v
 1.4 2002/05/01 01:33:42 glenn Exp $
  - * $Revision: 1.4 $
  - * $Date: 2002/05/01 01:33:42 $
  + * $Header: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspEngineContext.java,v
 1.5 2002/05/01 02:40:37 glenn Exp $
  + * $Revision: 1.5 $
  + * $Date: 2002/05/01 02:40:37 $
*
* 
* 
  @@ -92,6 +92,7 @@
* @author Anil K. Vijendran
* @author Harish Prabandham
* @author Pierre Delisle
  + * @author Glenn Nielsen
*/
   public class JspEngineContext implements JspCompilationContext {
   private JspReader reader;
  @@ -112,13 +113,12 @@
   
   public JspEngineContext(URLClassLoader loader, String classpath, 
   ServletContext context, String jspUri,
  -boolean isErrPage, Options options)
  -{
  +boolean isErrPage, Options options) {
   this.loader = loader;
   this.classpath = classpath;
   this.context = context;
   this.jspUri = jspUri;
  -baseURI = jspUri.substring(0, jspUri.lastIndexOf('/'));
  +baseURI = jspUri.substring(0, jspUri.lastIndexOf('/') + 1);
   this.isErrPage = isErrPage;
   this.options = options;
   createOutdir();
  @@ -129,12 +129,13 @@
   try {
   URL outURL = options.getScratchDir().toURL();
   String outURI = outURL.toString();   
  -if( outURI.endsWith("/") )   
  +if( outURI.endsWith("/") ) {
   outURI = outURI + 
jspUri.substring(1,jspUri.lastIndexOf("/")+1);
  -else   
  +} else {
   outURI = outURI +  
jspUri.substring(0,jspUri.lastIndexOf("/")+1);;
  +}
   outURL = new URL(outURI);   
   outDir = new File(outURL.getFile());
   if( !outDir.exists() ) {
  @@ -312,8 +313,9 @@
*/
   public Compiler createCompiler() throws JasperException {
   
  -if (jspCompiler != null)
  +if (jspCompiler != null) {
   return jspCompiler;
  +}
   
String compilerPath = options.getJspCompilerPath();
Class jspCompilerPlugin = options.getJspCompilerPlugin();
  @@ -332,8 +334,9 @@
   javac = new SunJavaCompiler();
}
   
  -if (compilerPath != null)
  +if (compilerPath != null) {
   javac.setCompilerPath(compilerPath);
  +}
   
   jspCompiler = new JspCompiler(this);
jspCompiler.setJavaCompiler(javac);
  @@ -345,14 +348,12 @@
   /** 
* Get the full value of a URI relative to this compilations context
*/
  -public String resolveRelativeUri(String uri)
  -{
  -if (uri.charAt(0) == '/')
  -{
  +public String resolveRelativeUri(String uri) {
  +if (uri.charAt(0) == '/') {
   return uri;
   }
  -return baseURI + '/' + uri;
  -}
  +return baseURI + uri;
  +}
   
   /**
* Gets a resource as a stream, relative to the meanings of this
  @@ -360,14 +361,11 @@
* @return a null if the resource cannot be found or represented 
* as an InputStream.
*/
  -public java.io.InputStream getResourceAsStream(String res)
  -{
  +public java.io.InputStream getResourceAsStream(String res) {
   return context.getResourceAsStream(res);
   }
   
  -public URL getResource(String res)
  - throws MalformedURLException
  -{
  +public URL getResource(String res) throws MalformedURLException {
   return context.getResource(res);
   }
   
  @@ -375,16 +373,11 @@
* Gets the actua

cvs commit: jakarta-tomcat-4.0/webapps/admin/connector connectors.jsp

[manveen]

manveen 02/04/30 19:37:22

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector
ConnectorForm.java
   webapps/admin/connector connectors.jsp
  Log:
  Display the list of connectors to be deletd with their port numbers instead of calss 
name attributes.
  
  Revision  ChangesPath
  1.11  +8 -8  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/ConnectorForm.java
  
  Index: ConnectorForm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/ConnectorForm.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- ConnectorForm.java30 Apr 2002 21:38:20 -  1.10
  +++ ConnectorForm.java1 May 2002 02:37:22 -   1.11
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/ConnectorForm.java,v
 1.10 2002/04/30 21:38:20 manveen Exp $
  - * $Revision: 1.10 $
  - * $Date: 2002/04/30 21:38:20 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/ConnectorForm.java,v
 1.11 2002/05/01 02:37:22 manveen Exp $
  + * $Revision: 1.11 $
  + * $Date: 2002/05/01 02:37:22 $
*
* 
*
  @@ -74,7 +74,7 @@
* Form bean for the connector page.
*
* @author Manveen Kaur
  - * @version $Revision: 1.10 $ $Date: 2002/04/30 21:38:20 $
  + * @version $Revision: 1.11 $ $Date: 2002/05/01 02:37:22 $
*/
   
   public final class ConnectorForm extends ActionForm {
  @@ -742,7 +742,7 @@
 
   /* The IP address can also be null -- which means open the
server socket on *all* IP addresses for this host */
  -if (address.length() > 0) {
  +if ((address.length() > 0) && !address.equalsIgnoreCase(" ")) {
   try {
   InetAddress.getByName(address);
   } catch (Exception e) {
  @@ -767,7 +767,7 @@
   numberCheck("maxProcessorsText",  maxProcessorsText, true, 1, 512);
   }
   
  -/* proxy*/  
  +// proxy  
   if ((proxyName!= null) && (proxyName.length() > 0)) {
   try {
   InetAddress.getByName(proxyName);
  @@ -776,7 +776,7 @@
   }
   }   
   
  -/* supported only by Coyote HTTP/1.1 connectors */
  +// supported only by Coyote HTTP and HTTPS connectors
   if (!("AJP".equalsIgnoreCase(connectorType)))
   numberCheck("proxyPortText",  proxyPortText, true, 0, 65535);   
 
   }
  @@ -785,7 +785,7 @@
   }
   
   /*
  - * Helper method to check that it is a reuired number and
  + * Helper method to check that it is a required number and
* is a valid integer within the given range. (min, max).
*
* @param  field  The field name in the form for which this error occured.
  
  
  
  1.4   +1 -1  jakarta-tomcat-4.0/webapps/admin/connector/connectors.jsp
  
  Index: connectors.jsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/connector/connectors.jsp,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- connectors.jsp26 Apr 2002 19:15:52 -  1.3
  +++ connectors.jsp1 May 2002 02:37:22 -   1.4
  @@ -77,7 +77,7 @@
    
 
  -
  +Connector ()
 
   
 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspEngineContext.java

[glenn]

glenn   02/04/30 18:33:42

  Modified:jasper2/src/share/org/apache/jasper/servlet JspServlet.java
   jasper2  build.xml
   jasper2/src/share/org/apache/jasper JspEngineContext.java
  Added:   jasper2/src/share/org/apache/jasper/servlet
JspServletWrapper.java
  Log:
  Refactor JspServlet, JspServletWrapper, and JspEngineContext
  prior to implementing new features.  There was alot of intimacy
  and some code duplication between these three.
  
  JspServletWrapper had been an inner class of JspServlet,
  refactored out of JspServlet into its own class.
  
  Removed unneeded imports.
  
  Removed some unused code.
  
  Removed use of an HttpServletRequest and HttpServletResponse
  from JspEngineContext in preparation for doing background
  compiles.
  
  Switched JspServlet over to using the Jakarta-Commons
  collections FastHashMap instead of a Hashtable, this
  should improve performance while remaining thread safe.
  
  Passes all jsp watchdog tests except for the broken test case.
  
  Revision  ChangesPath
  1.9   +31 -322   
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java
  
  Index: JspServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- JspServlet.java   30 Apr 2002 13:28:24 -  1.8
  +++ JspServlet.java   1 May 2002 01:33:42 -   1.9
  @@ -59,18 +59,12 @@
   import javax.servlet.ServletContext;
   import javax.servlet.ServletConfig;
   import javax.servlet.ServletException;
  -import javax.servlet.SingleThreadModel;
  -import javax.servlet.UnavailableException;
   import javax.servlet.http.HttpServlet;
   import javax.servlet.http.HttpServletRequest;
   import javax.servlet.http.HttpServletResponse;
  -import javax.servlet.jsp.HttpJspPage;
   import javax.servlet.jsp.JspFactory;
   
  -import java.util.Hashtable;
  -import java.util.Enumeration;
   import java.io.File;
  -import java.io.PrintWriter;
   import java.io.IOException;
   import java.io.FileNotFoundException;
   import java.io.FilePermission;
  @@ -78,24 +72,21 @@
   import java.net.URL;
   import java.net.URLClassLoader;
   import java.net.MalformedURLException;
  -import java.security.AccessController;
   import java.security.CodeSource;
   import java.security.PermissionCollection;
   import java.security.Policy;
  -import java.security.PrivilegedAction;
  +import java.util.Enumeration;
  +import java.util.Iterator;
  +import java.util.Map;
  +
  +import org.apache.commons.collections.FastHashMap;
   
   import org.apache.jasper.JasperException;
   import org.apache.jasper.Constants;
   import org.apache.jasper.Options;
   import org.apache.jasper.EmbededServletOptions;
  -import org.apache.jasper.JspCompilationContext;
  -import org.apache.jasper.JspEngineContext;
  -import org.apache.jasper.compiler.Mangler;
   import org.apache.jasper.runtime.*;
   
  -import org.apache.jasper.compiler.Compiler;
  -import org.apache.jasper.compiler.TldLocationsCache;
  -
   import org.apache.jasper.logging.Logger;
   import org.apache.jasper.logging.DefaultLogger;
   import org.apache.jasper.logging.JasperLogger;
  @@ -114,155 +105,23 @@
* @author Harish Prabandham
* @author Remy Maucherat
* @author Kin-man Chung
  + * @author Glenn Nielsen
*/
   public class JspServlet extends HttpServlet {
   
  -Logger.Helper loghelper;
  -
  -class JspServletWrapper {
  -Servlet theServlet;
  - String jspUri;
  - boolean isErrorPage;
  - // ServletWrapper will set this 
  - Class servletClass;
  - URLClassLoader loader = null;
  -JspCompilationContext ctxt = null;
  -String outDir = null;
  -long available = 0L;
  - 
  - JspServletWrapper(String jspUri, boolean isErrorPage) {
  - this.jspUri = jspUri;
  - this.isErrorPage = isErrorPage;
  - this.theServlet = null;
  -createOutdir();
  - }
  - 
  -private void createOutdir() {
  -File outDir = null;
  -try {
  -URL outURL = options.getScratchDir().toURL();
  -String outURI = outURL.toString();
  -if( outURI.endsWith("/") )
  -outURI = outURI + jspUri.substring(1,jspUri.lastIndexOf("/")+1);
  -else
  -outURI = outURI + 
jspUri.substring(0,jspUri.lastIndexOf("/")+1);;
  -outURL = new URL(outURI);
  -outDir = new File(outURL.getFile());
  -if( !outDir.exists() ) {
  -outDir.mkdirs();
  -}
  -this.outDir = outDir.toString() + File.separator;
  -} catch(Exception e) {
  -throw new IllegalStateException("No 

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF web.xml

[manveen]

manveen 02/04/30 17:53:55

  Modified:webapps/admin/WEB-INF web.xml
  Log:
  do not render "tomcat root" node by default.
  
  Revision  ChangesPath
  1.11  +2 -0  jakarta-tomcat-4.0/webapps/admin/WEB-INF/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/web.xml,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- web.xml   4 Apr 2002 20:30:34 -   1.10
  +++ web.xml   1 May 2002 00:53:55 -   1.11
  @@ -43,10 +43,12 @@
 true
   
   
  +
   
 treebuilders
 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: cvs commit: jakarta-tomcat-connectors/webapp/lib Makefile.in

[Pier Fumagalli]

"[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:

> pier02/04/30 17:37:16
> 
> Modified:webapp   Makedefs.in Makefile.in configure.in
>  webapp/apache-1.3 Makefile.in
>  webapp/lib Makefile.in
> Log:
> Reorganization and clean-up of all the autoconf code, with the objective
> to build Apache 2.0 binaries from APXS/2.0 tomorrow...

This works on OS/X great, actually better than before because it's MUCH
simpler to debug. Tomorrow I'll try it out @work on some solaris 7 and 8
machines. Can someone try it on Linux (you can also wait when the whole kit
will be finished up - but might be great to know of issues right now).

Pier

--
I think that it's extremely foolish to name a server after the current U.S.
President. B.W. Fitzpatrick



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/webapp/lib Makefile.in

[pier]

pier02/04/30 17:41:58

  Modified:webapp/lib Makefile.in
  Log:
  Forgot -I. for the generated pr_warp_defs.h
  
  Revision  ChangesPath
  1.25  +2 -2  jakarta-tomcat-connectors/webapp/lib/Makefile.in
  
  Index: Makefile.in
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/webapp/lib/Makefile.in,v
  retrieving revision 1.24
  retrieving revision 1.25
  diff -u -r1.24 -r1.25
  --- Makefile.in   1 May 2002 00:37:16 -   1.24
  +++ Makefile.in   1 May 2002 00:41:58 -   1.25
  @@ -56,9 +56,9 @@
   # = #
   
   # @author  Pier Fumagalli 
  -# @version $Id: Makefile.in,v 1.24 2002/05/01 00:37:16 pier Exp $
  +# @version $Id: Makefile.in,v 1.25 2002/05/01 00:41:58 pier Exp $
   
  -LOCAL_INCLUDES = -I$(SRC_DIR)/include -I$(SRC_DIR)/lib
  +LOCAL_INCLUDES = -I$(SRC_DIR)/include -I$(SRC_DIR)/lib -I.
   LOCAL_TGT_DIR = $(TGT_DIR)/lib
   LOCAL_SRC_DIR = $(SRC_DIR)/lib
   include @TGT_DIR@/Makedefs
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans ConnectorMBean.java MBeanFactory.java

[amyroh]

amyroh  02/04/30 17:38:10

  Modified:catalina/src/share/org/apache/catalina/mbeans
ConnectorMBean.java MBeanFactory.java
  Log:
  Minor fixes to edit serversocketfactory properties.
  
  Revision  ChangesPath
  1.3   +48 -47
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java
  
  Index: ConnectorMBean.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ConnectorMBean.java   30 Apr 2002 18:24:08 -  1.2
  +++ ConnectorMBean.java   1 May 2002 00:38:09 -   1.3
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java,v
 1.2 2002/04/30 18:24:08 amyroh Exp $
  - * $Revision: 1.2 $
  - * $Date: 2002/04/30 18:24:08 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java,v
 1.3 2002/05/01 00:38:09 amyroh Exp $
  + * $Revision: 1.3 $
  + * $Date: 2002/05/01 00:38:09 $
*
* 
*
  @@ -76,7 +76,7 @@
* org.apache.coyote.tomcat4.CoyoteConnector component.
*
* @author Amy Roh
  - * @version $Revision: 1.2 $ $Date: 2002/04/30 18:24:08 $
  + * @version $Revision: 1.3 $ $Date: 2002/05/01 00:38:09 $
*/
   
   public class ConnectorMBean extends BaseModelMBean {
  @@ -108,6 +108,7 @@
   
   // - Operations
   
  +
   /**
* Return Client authentication info
*
  @@ -120,17 +121,13 @@
   Class coyoteConnectorCls = 
Class.forName("org.apache.coyote.tomcat4.CoyoteConnector");
   if (coyoteConnectorCls.isInstance(this.resource)) {
   // get factory
  -Class partypes1 [] = new Class[1];
  -Method meth1 = coyoteConnectorCls.getMethod("getFactory", partypes1);
  -Object arglist1[] = new Object[1];
  -Object factory = meth1.invoke(this.resource, arglist1);
  +Method meth1 = coyoteConnectorCls.getMethod("getFactory", null);
  +Object factory = meth1.invoke(this.resource, null);
   Class coyoteServerSocketFactoryCls = 
Class.forName("org.apache.coyote.tomcat4.CoyoteServerSocketFactory");
   if (coyoteServerSocketFactoryCls.isInstance(factory)) {
   // get clientAuth
  -Class partypes2 [] = new Class[1];
  -Method meth2 = 
coyoteServerSocketFactoryCls.getMethod("getClientAuth", partypes2);
  -Object arglist2[] = new Object[1];
  -clientAuthObj = meth2.invoke(this.resource, arglist2);
  +Method meth2 = 
coyoteServerSocketFactoryCls.getMethod("getClientAuth", null);
  +clientAuthObj = meth2.invoke(this.resource, null);
   }
  
   }
  @@ -139,6 +136,7 @@
   else return false;
   }
   
  +
   /**
* Set Client authentication info
*
  @@ -150,10 +148,8 @@
   Class coyoteConnectorCls = 
Class.forName("org.apache.coyote.tomcat4.CoyoteConnector");
   if (coyoteConnectorCls.isInstance(this.resource)) {
   // get factory
  -Class partypes1 [] = new Class[1];
  -Method meth1 = coyoteConnectorCls.getMethod("getFactory", partypes1);
  -Object arglist1[] = new Object[1];
  -Object factory = meth1.invoke(this.resource, arglist1);
  +Method meth1 = coyoteConnectorCls.getMethod("getFactory", null);
  +Object factory = meth1.invoke(this.resource, null);
   Class coyoteServerSocketFactoryCls = 
Class.forName("org.apache.coyote.tomcat4.CoyoteServerSocketFactory");
   if (coyoteServerSocketFactoryCls.isInstance(factory)) {
   // set clientAuth
  @@ -163,9 +159,9 @@
   Object arglist2[] = new Object[1];
   arglist2[0] = new Boolean(clientAuth);
   meth2.invoke(this.resource, arglist2);
  -}
  -   
  -}
  +} 
  +} 
  +
   }
   
   
  @@ -181,21 +177,22 @@
   Class coyoteConnectorCls = 
Class.forName("org.apache.coyote.tomcat4.CoyoteConnector");
   if (coyoteConnectorCls.isInstance(this.resource)) {
   // get keystoreFile
  -Class partypes1 [] = new Class[1];
  -Method meth1 = coyoteConnectorCls.getMethod("getKeystoreFile", 
partypes1);
  -Object arglist1[] = new Object[1];
  -Object factory = meth1.invoke(this.resource, arglist1);
  +Method meth1 = coyoteConnectorCls.getMethod("getFactory", null);
 

cvs commit: jakarta-tomcat-connectors/webapp/lib Makefile.in

[pier]

pier02/04/30 17:37:16

  Modified:webapp   Makedefs.in Makefile.in configure.in
   webapp/apache-1.3 Makefile.in
   webapp/lib Makefile.in
  Log:
  Reorganization and clean-up of all the autoconf code, with the objective
  to build Apache 2.0 binaries from APXS/2.0 tomorrow...
  
  Revision  ChangesPath
  1.14  +29 -119   jakarta-tomcat-connectors/webapp/Makedefs.in
  
  Index: Makedefs.in
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/webapp/Makedefs.in,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- Makedefs.in   1 Nov 2001 22:20:51 -   1.13
  +++ Makedefs.in   1 May 2002 00:37:16 -   1.14
  @@ -56,126 +56,36 @@
   # = #
   
   # @author  Pier Fumagalli 
  -# @version $Id: Makedefs.in,v 1.13 2001/11/01 22:20:51 pier Exp $
  +# @version $Id: Makedefs.in,v 1.14 2002/05/01 00:37:16 pier Exp $
   
   .SUFFIXES: .c .o .lo
   
  -# -
  -# Programs discovered by "configure" during initialization
  -# -
  -
  -TEST = @TEST@
  -TRUE = @TRUE@
  -ECHO = @ECHO@
  -GREP = @GREP@
  -CAT = @CAT@
  -SED = @SED@
  -LN = @LN@
  -RM = @RM@
  -
  -# -
  -# Compilation settings and Makefile macros
  -# -
  -
  -# The target module to build
  -MODULE = @MODULE@
  -# The system which built this binary
  -SYSTEM = @SYSTEM@
  -# Wether to build debug information or not
  -DEBUG = @DEBUG@
  -# The WebApp sources directory
  -SRCDIR = @SRCDIR@
  -# The compilation (this) directory
  -TGTDIR = @TGTDIR@
  -# The directory of a Tomcat 4.0 binary distribution
  -TC4DIR = @TC4DIR@
  -# The list of configure-generated files
  -CFGFILES = @CFGFILES@ ./config.cache ./config.log ./config.status
  -# The file holding the list of makefile-generated files
  -LSTFILE = $(TGTDIR)/config.list
  -# GNU-Make style echo
  -MECHO = $(ECHO) "$(MAKE)[$(MAKELEVEL)]:"
  -
  -# -
  -# APR library values
  -# -
  -
  -# The APR source directory (if needed)
  -APR_SRCDIR = @APR_SRCDIR@
  -# Where libapr.a resides
  -APR_LIBDIR = @APR_LIBDIR@
  -# Where APR include files are located
  -APR_INCDIR = @APR_INCDIR@
  -# Location of APRVARS
  -APR_VARFIL = @APR_VARFIL@
  -# Extra APR C compilation flags
  -APR_CFLAGS = @APR_CFLAGS@
  -# Extra APR C macro pre-processor flags
  -APR_CPPFLAGS = @APR_CPPFLAGS@
  -# Extra APR inclusion flags
  -APR_INCLUDES = @APR_INCLUDES@
  -# Extra APR linker flags
  -APR_LDFLAGS = @APR_LDFLAGS@
  -# Extra APR libraries required for linking
  -APR_LIBS = @APR_LIBS@
  -# Libtool location
  -LIBTOOL = @LIBTOOL@
  -
  -# -
  -# C Compiler settings
  -# -
  -
  -# Library archiver
  -AR = @AR@
  -# C compiler
  -CC = @CC@
  -# C macro pre-processor
  -CPP = @CPP@
  -# Library updater
  -RANLIB = @RANLIB@
  -# C compilation flags
  -CFLAGS = @CFLAGS@
  -# C macro pre-processor flags
  -CPPFLAGS = @CPPFLAGS@
  -
  -# -
  -# Java Compiler settings
  -# -
  -
  -# The JVM home directory
  -JAVA_HOME = @JAVA_HOME@
  -# Jar archiver
  -JAR = @JAR@
  -# Java compiler
  -JAVAC = @JAVAC@
  -# JavaDoc documentation tool
  -JAVADOC = @JAVADOC@
  -# Java compilation flags
  -JAVACFLAGS = @JAVACFLAGS@
  -# Java Class Path
  -CLASSPATH = @CLASSPATH@
  -
  -# -
  -# ScanDoc Documentation tool settings
  -# -
  -
  -# PERL interpreter
  -PERL = @PERL@
  -# ScanDoc documentation tool
  -SCANDOC = @SCANDOC@
  -# Scandoc flags
  -SCANDOCFLAGS = @SCANDOCFLAGS@
  -
  -# -
  -# C-Compilation default setting
  -# -
  -
  -ALL_CFLAGS = $(CFLAGS) $(CPPFLAGS) \
  - $(APR_CFLAGS) $(APR_CPPFLAGS) $(APR_INCLUDES) \
  - -I$(APR_INCDIR) -I$(SRCDIR)/include
  +# Building tools
  +CC   = @CC@
  +CPP  = @CPP@
  +SHELL= @SHELL@
  +LIBTOOL  = @LIBTOOL@
  +APXS = @APXS@
   
  -.c.o:
  - $(CC) $(ALL_CFLAGS) -c "$<" -o "$@"
  -
  -.c.lo:
  - $(LIBTOOL) $(CC) -static $(ALL_CFLAGS) -c

cvs commit: jakarta-tomcat-connectors/webapp/support wa_util.m4

[pier]

pier02/04/30 17:31:07

  Added:   webapp/support wa_util.m4
  Log:
  Various M4 utilities we'll need in configure.
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-connectors/webapp/support/wa_util.m4
  
  Index: wa_util.m4
  ===
  dnl  =
  dnl
  dnl  The Apache Software License,  Version 1.1
  dnl
  dnl   Copyright (c) 1999-2001 The Apache Software Foundation.
  dnlAll rights reserved.
  dnl
  dnl  =
  dnl
  dnl  Redistribution and use in source and binary forms,  with or without modi-
  dnl  fication, are permitted provided that the following conditions are met:
  dnl
  dnl  1. Redistributions of source code  must retain the above copyright notice
  dnl notice, this list of conditions and the following disclaimer.
  dnl
  dnl  2. Redistributions  in binary  form  must  reproduce the  above copyright
  dnl notice,  this list of conditions  and the following  disclaimer in the
  dnl documentation and/or other materials provided with the distribution.
  dnl
  dnl  3. The end-user documentation  included with the redistribution,  if any,
  dnl must include the following acknowlegement:
  dnl
  dnl"This product includes  software developed  by the Apache  Software
  dnl Foundation ."
  dnl
  dnl Alternately, this acknowlegement may appear in the software itself, if
  dnl and wherever such third-party acknowlegements normally appear.
  dnl
  dnl  4. The names "The Jakarta Project",  "Apache WebApp Module",  and "Apache
  dnl Software Foundation"  must not be used to endorse or promote  products
  dnl derived  from this  software  without  prior  written  permission. For
  dnl written permission, please contact <[EMAIL PROTECTED]>.
  dnl
  dnl  5. Products derived from this software may not be called "Apache" nor may
  dnl "Apache" appear in their names without prior written permission of the
  dnl Apache Software Foundation.
  dnl
  dnl  THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESSED OR IMPLIED WARRANTIES
  dnl  INCLUDING, BUT NOT LIMITED TO,  THE IMPLIED WARRANTIES OF MERCHANTABILITY
  dnl  AND FITNESS FOR  A PARTICULAR PURPOSE  ARE DISCLAIMED.  IN NO EVENT SHALL
  dnl  THE APACHE  SOFTWARE  FOUNDATION OR  ITS CONTRIBUTORS  BE LIABLE  FOR ANY
  dnl  DIRECT,  INDIRECT,   INCIDENTAL,  SPECIAL,  EXEMPLARY,  OR  CONSEQUENTIAL
  dnl  DAMAGES (INCLUDING,  BUT NOT LIMITED TO,  PROCUREMENT OF SUBSTITUTE GOODS
  dnl  OR SERVICES;  LOSS OF USE,  DATA,  OR PROFITS;  OR BUSINESS INTERRUPTION)
  dnl  HOWEVER CAUSED AND  ON ANY  THEORY  OF  LIABILITY,  WHETHER IN  CONTRACT,
  dnl  STRICT LIABILITY, OR TORT  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
  dnl  ANY  WAY  OUT OF  THE  USE OF  THIS  SOFTWARE,  EVEN  IF  ADVISED  OF THE
  dnl  POSSIBILITY OF SUCH DAMAGE.
  dnl
  dnl  =
  dnl
  dnl  This software  consists of voluntary  contributions made  by many indivi-
  dnl  duals on behalf of the  Apache Software Foundation.  For more information
  dnl  on the Apache Software Foundation, please see .
  dnl
  dnl  =
  
  dnl --
  dnl Author Pier Fumagalli <[EMAIL PROTECTED]>
  dnl Version $Id: wa_util.m4,v 1.1 2002/05/01 00:31:07 pier Exp $
  dnl --
  
  dnl --
  dnl WA_ERROR
  dnl   Dump an error message and make sure we actually exit.
  dnl   $1 => Message to dump for error.
  dnl --
  AC_DEFUN(
[WA_ERROR],
[
  AC_MSG_RESULT([error])
  AC_MSG_ERROR([$1])
  exit 1
])
  
  dnl --
  dnl WA_VARIABLE
  dnl   Initialize a substituted (global) variable with a zero-length string.
  dnl   $1 => The environment variable name.
  dnl --
  AC_DEFUN(
[WA_VARIABLE],
[
  $1=""
  AC_SUBST([$1])
])
  
  dnl --
  dnl WA_PATH_DIR
  dnl   Resolve the FULL path name of a directory.
  dnl   $1 => The variable where the full path name will be stored.
  dnl   $2 => The path to resolve.
  dnl   $3 => The description of what we're trying to locate.
  dnl --
  AC_DEFUN(
[WA_PATH_DIR],
[
  A

cvs commit: jakarta-tomcat-connectors/webapp/support wa_apxs.m4

[pier]

pier02/04/30 17:25:50

  Added:   webapp/support wa_apxs.m4
  Log:
  Handle configuration of APXS (both 1.3 and 2.0)
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-connectors/webapp/support/wa_apxs.m4
  
  Index: wa_apxs.m4
  ===
  dnl  =
  dnl
  dnl  The Apache Software License,  Version 1.1
  dnl
  dnl   Copyright (c) 1999-2001 The Apache Software Foundation.
  dnlAll rights reserved.
  dnl
  dnl  =
  dnl
  dnl  Redistribution and use in source and binary forms,  with or without modi-
  dnl  fication, are permitted provided that the following conditions are met:
  dnl
  dnl  1. Redistributions of source code  must retain the above copyright notice
  dnl notice, this list of conditions and the following disclaimer.
  dnl
  dnl  2. Redistributions  in binary  form  must  reproduce the  above copyright
  dnl notice,  this list of conditions  and the following  disclaimer in the
  dnl documentation and/or other materials provided with the distribution.
  dnl
  dnl  3. The end-user documentation  included with the redistribution,  if any,
  dnl must include the following acknowlegement:
  dnl
  dnl"This product includes  software developed  by the Apache  Software
  dnl Foundation ."
  dnl
  dnl Alternately, this acknowlegement may appear in the software itself, if
  dnl and wherever such third-party acknowlegements normally appear.
  dnl
  dnl  4. The names "The Jakarta Project",  "Apache WebApp Module",  and "Apache
  dnl Software Foundation"  must not be used to endorse or promote  products
  dnl derived  from this  software  without  prior  written  permission. For
  dnl written permission, please contact <[EMAIL PROTECTED]>.
  dnl
  dnl  5. Products derived from this software may not be called "Apache" nor may
  dnl "Apache" appear in their names without prior written permission of the
  dnl Apache Software Foundation.
  dnl
  dnl  THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESSED OR IMPLIED WARRANTIES
  dnl  INCLUDING, BUT NOT LIMITED TO,  THE IMPLIED WARRANTIES OF MERCHANTABILITY
  dnl  AND FITNESS FOR  A PARTICULAR PURPOSE  ARE DISCLAIMED.  IN NO EVENT SHALL
  dnl  THE APACHE  SOFTWARE  FOUNDATION OR  ITS CONTRIBUTORS  BE LIABLE  FOR ANY
  dnl  DIRECT,  INDIRECT,   INCIDENTAL,  SPECIAL,  EXEMPLARY,  OR  CONSEQUENTIAL
  dnl  DAMAGES (INCLUDING,  BUT NOT LIMITED TO,  PROCUREMENT OF SUBSTITUTE GOODS
  dnl  OR SERVICES;  LOSS OF USE,  DATA,  OR PROFITS;  OR BUSINESS INTERRUPTION)
  dnl  HOWEVER CAUSED AND  ON ANY  THEORY  OF  LIABILITY,  WHETHER IN  CONTRACT,
  dnl  STRICT LIABILITY, OR TORT  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
  dnl  ANY  WAY  OUT OF  THE  USE OF  THIS  SOFTWARE,  EVEN  IF  ADVISED  OF THE
  dnl  POSSIBILITY OF SUCH DAMAGE.
  dnl
  dnl  =
  dnl
  dnl  This software  consists of voluntary  contributions made  by many indivi-
  dnl  duals on behalf of the  Apache Software Foundation.  For more information
  dnl  on the Apache Software Foundation, please see .
  dnl
  dnl  =
  
  dnl --
  dnl Author Pier Fumagalli <[EMAIL PROTECTED]>
  dnl Version $Id: wa_apxs.m4,v 1.1 2002/05/01 00:25:49 pier Exp $
  dnl --
  
  dnl --
  dnl WA_APXS
  dnl   Locate the APXS script
  dnl   $1 => Environment variable where the APXS script name will be stored
  dnl --
  AC_DEFUN(
[WA_APXS],
[
  tempval="apxs"
  AC_MSG_CHECKING([for apxs name])
  AC_ARG_WITH(
[apxs],
[  --with-apxs[[=apxs]]  the Apache "apxs" utility to use.],
[
  case "${withval}" in
  ""|"yes"|"YES"|"true"|"TRUE")
;;
  "no"|"NO"|"false"|"FALSE")
WA_ERROR([apxs required for compilation])
;;
  *)
tempval="${withval}"
;;
  esac
])
  AC_MSG_RESULT([${tempval}])
  AC_PATH_PROG($1,[${tempval}])
  
  if test -z "${$1}" ; then
AC_MSG_ERROR([cannot find apxs utility "${tempval}"])
exit 1
  fi
  unset tempval
  AC_SUBST($1)
])
  
  dnl --
  dnl WA_APXS_CHECK
  dnl   Check that APXS is actually workable, and return its version number
  dnl   $1 => Env

cvs commit: jakarta-tomcat-connectors/webapp/support wa_exec.m4

[pier]

pier02/04/30 17:22:29

  Added:   webapp/support wa_exec.m4
  Log:
  Pretty printing of a command execution.
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-connectors/webapp/support/wa_exec.m4
  
  Index: wa_exec.m4
  ===
  dnl  =
  dnl
  dnl  The Apache Software License,  Version 1.1
  dnl
  dnl   Copyright (c) 1999-2001 The Apache Software Foundation.
  dnlAll rights reserved.
  dnl
  dnl  =
  dnl
  dnl  Redistribution and use in source and binary forms,  with or without modi-
  dnl  fication, are permitted provided that the following conditions are met:
  dnl
  dnl  1. Redistributions of source code  must retain the above copyright notice
  dnl notice, this list of conditions and the following disclaimer.
  dnl
  dnl  2. Redistributions  in binary  form  must  reproduce the  above copyright
  dnl notice,  this list of conditions  and the following  disclaimer in the
  dnl documentation and/or other materials provided with the distribution.
  dnl
  dnl  3. The end-user documentation  included with the redistribution,  if any,
  dnl must include the following acknowlegement:
  dnl
  dnl"This product includes  software developed  by the Apache  Software
  dnl Foundation ."
  dnl
  dnl Alternately, this acknowlegement may appear in the software itself, if
  dnl and wherever such third-party acknowlegements normally appear.
  dnl
  dnl  4. The names "The Jakarta Project",  "Apache WebApp Module",  and "Apache
  dnl Software Foundation"  must not be used to endorse or promote  products
  dnl derived  from this  software  without  prior  written  permission. For
  dnl written permission, please contact <[EMAIL PROTECTED]>.
  dnl
  dnl  5. Products derived from this software may not be called "Apache" nor may
  dnl "Apache" appear in their names without prior written permission of the
  dnl Apache Software Foundation.
  dnl
  dnl  THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESSED OR IMPLIED WARRANTIES
  dnl  INCLUDING, BUT NOT LIMITED TO,  THE IMPLIED WARRANTIES OF MERCHANTABILITY
  dnl  AND FITNESS FOR  A PARTICULAR PURPOSE  ARE DISCLAIMED.  IN NO EVENT SHALL
  dnl  THE APACHE  SOFTWARE  FOUNDATION OR  ITS CONTRIBUTORS  BE LIABLE  FOR ANY
  dnl  DIRECT,  INDIRECT,   INCIDENTAL,  SPECIAL,  EXEMPLARY,  OR  CONSEQUENTIAL
  dnl  DAMAGES (INCLUDING,  BUT NOT LIMITED TO,  PROCUREMENT OF SUBSTITUTE GOODS
  dnl  OR SERVICES;  LOSS OF USE,  DATA,  OR PROFITS;  OR BUSINESS INTERRUPTION)
  dnl  HOWEVER CAUSED AND  ON ANY  THEORY  OF  LIABILITY,  WHETHER IN  CONTRACT,
  dnl  STRICT LIABILITY, OR TORT  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
  dnl  ANY  WAY  OUT OF  THE  USE OF  THIS  SOFTWARE,  EVEN  IF  ADVISED  OF THE
  dnl  POSSIBILITY OF SUCH DAMAGE.
  dnl
  dnl  =
  dnl
  dnl  This software  consists of voluntary  contributions made  by many indivi-
  dnl  duals on behalf of the  Apache Software Foundation.  For more information
  dnl  on the Apache Software Foundation, please see .
  dnl
  dnl  =
  
  dnl --
  dnl Author Pier Fumagalli <[EMAIL PROTECTED]>
  dnl Version $Id: wa_exec.m4,v 1.1 2002/05/01 00:22:28 pier Exp $
  dnl --
  
  dnl --
  dnl WA_EXEC
  dnl   Execute a program filtering its output (pretty printing).
  dnl
  dnl   Parameters:
  dnl $1 => name of the variable containing the return value (error code).
  dnl $2 => name of the binary/script to invoke
  dnl $3 => message used for pretty printing output
  dnl $4 => the directory where the command must be executed
  dnl --
  AC_DEFUN(
[WA_EXEC],
[
  local_curdir="`pwd`"
  if test -d "$4" ; then
cd "$4"
  else
AC_MSG_ERROR([can't switch to directory $4]) 
  fi
  
  echo "  invoking \"$2\""
  echo "  in directory \"$4\""
  echo "-1" > retvalue.tmp
  
  set $2
  local_file=[$]1
  if test ! -x "${local_file}" ; then
AC_MSG_ERROR([cannot find or execute \"${local_file}\" in \"$4\"])
exit 1
  fi
  unset local_file
  
  {
$2
echo _retvalue_ $?
  } | {
ret=0
while true ; do
  read first line
  if test ! "$?" -eq "0" ; then
break
  else
if test "

cvs commit: jakarta-tomcat-connectors/webapp/support wa_apr.m4

[pier]

pier02/04/30 17:19:18

  Added:   webapp/support wa_apr.m4
  Log:
  Added M4 definitions to handle building APR from sources.
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-connectors/webapp/support/wa_apr.m4
  
  Index: wa_apr.m4
  ===
  dnl  =
  dnl
  dnl  The Apache Software License,  Version 1.1
  dnl
  dnl   Copyright (c) 1999-2001 The Apache Software Foundation.
  dnlAll rights reserved.
  dnl
  dnl  =
  dnl
  dnl  Redistribution and use in source and binary forms,  with or without modi-
  dnl  fication, are permitted provided that the following conditions are met:
  dnl
  dnl  1. Redistributions of source code  must retain the above copyright notice
  dnl notice, this list of conditions and the following disclaimer.
  dnl
  dnl  2. Redistributions  in binary  form  must  reproduce the  above copyright
  dnl notice,  this list of conditions  and the following  disclaimer in the
  dnl documentation and/or other materials provided with the distribution.
  dnl
  dnl  3. The end-user documentation  included with the redistribution,  if any,
  dnl must include the following acknowlegement:
  dnl
  dnl"This product includes  software developed  by the Apache  Software
  dnl Foundation ."
  dnl
  dnl Alternately, this acknowlegement may appear in the software itself, if
  dnl and wherever such third-party acknowlegements normally appear.
  dnl
  dnl  4. The names "The Jakarta Project",  "Apache WebApp Module",  and "Apache
  dnl Software Foundation"  must not be used to endorse or promote  products
  dnl derived  from this  software  without  prior  written  permission. For
  dnl written permission, please contact <[EMAIL PROTECTED]>.
  dnl
  dnl  5. Products derived from this software may not be called "Apache" nor may
  dnl "Apache" appear in their names without prior written permission of the
  dnl Apache Software Foundation.
  dnl
  dnl  THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESSED OR IMPLIED WARRANTIES
  dnl  INCLUDING, BUT NOT LIMITED TO,  THE IMPLIED WARRANTIES OF MERCHANTABILITY
  dnl  AND FITNESS FOR  A PARTICULAR PURPOSE  ARE DISCLAIMED.  IN NO EVENT SHALL
  dnl  THE APACHE  SOFTWARE  FOUNDATION OR  ITS CONTRIBUTORS  BE LIABLE  FOR ANY
  dnl  DIRECT,  INDIRECT,   INCIDENTAL,  SPECIAL,  EXEMPLARY,  OR  CONSEQUENTIAL
  dnl  DAMAGES (INCLUDING,  BUT NOT LIMITED TO,  PROCUREMENT OF SUBSTITUTE GOODS
  dnl  OR SERVICES;  LOSS OF USE,  DATA,  OR PROFITS;  OR BUSINESS INTERRUPTION)
  dnl  HOWEVER CAUSED AND  ON ANY  THEORY  OF  LIABILITY,  WHETHER IN  CONTRACT,
  dnl  STRICT LIABILITY, OR TORT  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
  dnl  ANY  WAY  OUT OF  THE  USE OF  THIS  SOFTWARE,  EVEN  IF  ADVISED  OF THE
  dnl  POSSIBILITY OF SUCH DAMAGE.
  dnl
  dnl  =
  dnl
  dnl  This software  consists of voluntary  contributions made  by many indivi-
  dnl  duals on behalf of the  Apache Software Foundation.  For more information
  dnl  on the Apache Software Foundation, please see .
  dnl
  dnl  =
  
  dnl --
  dnl Author Pier Fumagalli <[EMAIL PROTECTED]>
  dnl Version $Id: wa_apr.m4,v 1.1 2002/05/01 00:19:18 pier Exp $
  dnl --
  
  dnl --
  dnl WA_APR
  dnl   Locate the Apache APR source directory.
  dnl   $1 => Environment variable name where the APR directory will be stored
  dnl --
  AC_DEFUN(
[WA_APR],
[
  tempval="apr"
  AC_MSG_CHECKING([for apr sources])
  AC_ARG_WITH(
[apr],
[  --with-apr[[=apr]]the Apache Portable Runtime library to use.],
[
  case "${withval}" in
  ""|"yes"|"YES"|"true"|"TRUE")
;;
  "no"|"NO"|"false"|"FALSE")
WA_ERROR([apr library sources required for compilation])
;;
  *)
tempval="${withval}"
;;
  esac
])
  AC_MSG_RESULT([${tempval}])
  WA_PATH_DIR($1,[${tempval}],[apr sources])
  
  if test -z "$1" ; then
AC_MSG_ERROR([cannot find apr directory "${tempval}"])
exit 1
  fi
  unset tempval
  AC_SUBST($1)
])
  
  dnl --
  dnl WA_APR_GET
  dnl   Retrieve a value from the con

cvs commit: jakarta-tomcat-connectors/webapp/support buildconf.sh

[pier]

pier02/04/30 17:09:46

  Modified:webapp/support buildconf.sh
  Log:
  Start enforcing AutoConf 2.52 since it'll be used in the next revision
  of configure. Nagoya's nightly build have been already upgraded to the
  correct revision, if you don't have this version, just get the snapshot.
  
  Revision  ChangesPath
  1.10  +4 -4  jakarta-tomcat-connectors/webapp/support/buildconf.sh
  
  Index: buildconf.sh
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/webapp/support/buildconf.sh,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- buildconf.sh  29 Apr 2002 19:22:04 -  1.9
  +++ buildconf.sh  1 May 2002 00:09:46 -   1.10
  @@ -58,7 +58,7 @@
   
   # - #
   # Author Pier Fumagalli 
  -# Version $Id: buildconf.sh,v 1.9 2002/04/29 19:22:04 pier Exp $
  +# Version $Id: buildconf.sh,v 1.10 2002/05/01 00:09:46 pier Exp $
   # - #
   
   # - #
  @@ -80,16 +80,16 @@
   
   if test -z "${VERSION}"; then
   echo "autoconf not found."
  -echo "autoconf version 2.13 or newer required to build from CVS."
  +echo "autoconf version 2.52 or newer required to build from CVS."
   exit 1
   fi
   
   IFS=.
   set $VERSION
   IFS=' '
  -if test "$1" = "2" -a "$2" -lt "13" || test "$1" -lt "2"; then
  +if test "$1" = "2" -a "$2" -lt "52" || test "$1" -lt "2"; then
   echo "autoconf version $VERSION found."
  -echo "autoconf version 2.13 or newer required to build from CVS."
  +echo "autoconf version 2.52 or newer required to build from CVS."
   exit 1
   fi
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [4.1.0] Anyone testing it ?

[costinm]

On Wed, 1 May 2002, GOMEZ Henri wrote:

> And coyote/http11/jk need tomcat 4 to be built !
> 
> I'll have to try some kind of bootstrap action
> in my rpm, start compiling TC 4.x with binaries,
> then goes to JTC and rebuild it against newly
> built TC 4.x, then install these in place of
> bundled binaries ?(8

I think you can compile coyote without 4.x/3.x 
( it has autodetection and will not compile the parts
that depend on tomcat ). Then you can compile the rest
of jtc, as it depends only on coyote.

Then 3.3/4.x, and recompile coyote to get the 
tomcat specific part.

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: mod_webapp build problem

[Pier Fumagalli]

"GOMEZ Henri" <[EMAIL PROTECTED]> wrote:

> Hi,
> 
> I'm trying to build a rpm for mod_webapp against
> apache 1.3.23-mod_ssl and apache 2.0.35 on a redhat 7.2 box
> 
> apache-2.0 failed :

Working on it Henri... I have a whole new kit that I'm going to commit
pretty soon, once it's done... Here's a short-hand patch from my machine,
I'm breaking few bits and pieces (so right now the 2.0 doesn't even try to
compile), but I'm getting a hold on the beast...

Pier

--
I think that it's extremely foolish to name a server after the current U.S.
President. B.W. Fitzpatrick





webapp-buildpatch.txt
Description: Binary data

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [4.1.0] Anyone testing it ?

[GOMEZ Henri]

I'm trying to make a rpm for it but I'm stuck
with chicken-eggs problems between TC 4.1.0
and JTC (ditto for latest TC 4.0.4 and JTC).

To follow rpm policies I should avoid using
pre-built binaries (like commons-logging,
coyote, http11).

And coyote/http11/jk need tomcat 4 to be built !

I'll have to try some kind of bootstrap action
in my rpm, start compiling TC 4.x with binaries,
then goes to JTC and rebuild it against newly
built TC 4.x, then install these in place of
bundled binaries ?(8

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 



>-Original Message-
>From: Remy Maucherat [mailto:[EMAIL PROTECTED]]
>Sent: Tuesday, April 30, 2002 11:50 AM
>To: Tomcat Developers List
>Subject: [4.1.0] Anyone testing it ?
>
>
>Is anyone testing 4.1.0 ?
>The URL as a reminder:
>http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.0/
>
>Obviously, I expect people voting to rate the build to have 
>tried it ;-)
>
>Of particular interest is testing:
>- AJP 1.3 support
>- To see if bug 5735 is fixed with the current Coyote connector
>- Jasper 2
>
>Thanks,
>Remy
>
>
>--
>To unsubscribe, e-mail:   
>
>For additional commands, e-mail: 
>
>
>

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

mod_webapp build problem

[GOMEZ Henri]

Hi,

I'm trying to build a rpm for mod_webapp against
apache 1.3.23-mod_ssl and apache 2.0.35 on a redhat 7.2 box

apache-2.0 failed :

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
/etc/httpd2/build/libtool --silent --mode=finish \
/usr/src/redhat/BUILD/mod_webapp-1.0/jakarta-tomcat-connectors-4.0.4-b2-src/webapp/lib
make[2]: Leaving directory 
`/usr/src/redhat/BUILD/mod_webapp-1.0/jakarta-tomcat-connectors-4.0.4-b2-src/webapp/lib'
make[1]: Exiting directory "lib"
make[1]: Leaving directory 
`/usr/src/redhat/BUILD/mod_webapp-1.0/jakarta-tomcat-connectors-4.0.4-b2-src/webapp'
make[1]: Entering directory 
`/usr/src/redhat/BUILD/mod_webapp-1.0/jakarta-tomcat-connectors-4.0.4-b2-src/webapp'

make[1]: Entering directory "apache-2.0"
make[1]: Invoking "make  build"
make[2]: Entering directory 
`/usr/src/redhat/BUILD/mod_webapp-1.0/jakarta-tomcat-connectors-4.0.4-b2-src/webapp/apache-2.0'
Compiling and Linking Apache 2.0 WebApp Module
/usr/sbin/apxs2 -I../include -c -L ../lib -lwebapp mod_webapp.c
/etc/httpd2/build/libtool --silent --mode=compile gcc  -O2 -march=i386 -mcpu=i686 
-DAP_HAVE_DESIGNATED_INITIALIZER -DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 
-D_BSD_SOURCE -D_SVID_SOURCE -pthread -DNO_DBM_REWRITEMAP -I/usr/include/apache2 
-I../include  -c -o mod_webapp.lo mod_webapp.c && touch mod_webapp.slo
mod_webapp.c: In function `wam_invoke':
mod_webapp.c:482: warning: initialization discards qualifiers from pointer target type
/etc/httpd2/build/libtool --silent --mode=link gcc -o mod_webapp.la -rpath 
/usr/lib/apache2 -module -avoid-version -I../include  -L../lib -lwebapp  mod_webapp.lo

*** Warning: This library needs some functionality provided by -lwebapp.
*** I have the capability to make that library automatically link in when
*** you link to this library.  But I can only do this if you have a
*** shared version of the library, which you do not appear to have.

*** Warning: libtool could not satisfy all declared inter-library
*** dependencies of module mod_webapp.  Therefore, libtool will create
*** a static module, that should work as long as the dlopening
*** application is linked with the -dlopen flag.
make[2]: Leaving directory 
`/usr/src/redhat/BUILD/mod_webapp-1.0/jakarta-tomcat-connectors-4.0.4-b2-src/webapp/apache-2.0'
make[1]: Exiting directory "apache-2.0"
make[1]: Leaving directory 
`/usr/src/redhat/BUILD/mod_webapp-1.0/jakarta-tomcat-connectors-4.0.4-b2-src/webapp'

my libtool is not too old.

libtool --version
ltmain.sh (GNU libtool) 1.4 (1.920 2001/04/24 23:26:18)

apache 1.3 works :

with APR source from Apache 2.0.35 copy

What's that libtool problem ?

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans mbeans-descriptors.xml

[amyroh]

amyroh  02/04/30 15:46:08

  Modified:catalina/src/share/org/apache/catalina/mbeans
mbeans-descriptors.xml
  Log:
  Fix proxyPort type to int.
  
  Revision  ChangesPath
  1.54  +1 -1  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml
  
  Index: mbeans-descriptors.xml
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml,v
  retrieving revision 1.53
  retrieving revision 1.54
  diff -u -r1.53 -r1.54
  --- mbeans-descriptors.xml30 Apr 2002 22:14:08 -  1.53
  +++ mbeans-descriptors.xml30 Apr 2002 22:46:07 -  1.54
  @@ -6,7 +6,7 @@
   
   
   
  @@ -204,7 +204,7 @@
 
 
  + type="int"/>  
   
   mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: 

DO NOT REPLY [Bug 8645] - Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8645

Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 22:23 ---
I guess we are off scope, but I don't think it matters - we're trying to resolve
you problem, right?

First, the real reason why I don't like the patch. A quick search through Tomcat
sources reveals that the method lastModified() gets called in a number of
different places, from different code and always relies on the fact that the
timestamp of the file has changed (correctly). So, you would potentially be
fixing a lot more instances. And then there is of course Ant, Velocity and other
Jakarta software that would have to do the same to satisfy a buggy piece of
software. Sometimes that's the only option (for instance a buggy ZIP
implementation in JDK, screwing class reloads from .jar files) since it is core
part of the system and cannot be avoided. But this scenario isn't one of those
things (although I appreciate that it is important to you).

In solution to your problem, why not have the home directories on a Linux box -
then you can have a decent SMB and NFS on the same machine. I have searched the
web for smbfs + autofs and even found a HOWTO. I agree when you say that it is
an unproven concept, but so is Microsoft NFS.

Bojan

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/webapps/ROOT index.jsp

[remm]

remm02/04/30 15:17:49

  Modified:webapps/ROOT index.jsp
  Log:
  - Add a link to the Tomcat admin webapp.
  
  Revision  ChangesPath
  1.3   +14 -0 jakarta-tomcat-4.0/webapps/ROOT/index.jsp
  
  Index: index.jsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/ROOT/index.jsp,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- index.jsp 25 Apr 2002 14:14:29 -  1.2
  +++ index.jsp 30 Apr 2002 22:17:49 -  1.3
  @@ -76,6 +76,20 @@
   
   
   
  +Administration  
  +
  +
  +
  +
  +Tomcat Administration
  + 
  +
  +
  +
  +
  +
  +
  +
   Documentation  
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans mbeans-descriptors.xml

[amyroh]

amyroh  02/04/30 15:14:08

  Modified:catalina/src/share/org/apache/catalina/mbeans
mbeans-descriptors.xml
  Log:
  Add NonLoginAuthenticator MBean to mbeans-descriptors.
  
  Revision  ChangesPath
  1.53  +36 -1 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml
  
  Index: mbeans-descriptors.xml
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml,v
  retrieving revision 1.52
  retrieving revision 1.53
  diff -u -r1.52 -r1.53
  --- mbeans-descriptors.xml30 Apr 2002 18:24:08 -  1.52
  +++ mbeans-descriptors.xml30 Apr 2002 22:14:08 -  1.53
  @@ -6,7 +6,7 @@
   
   
   
  @@ -1375,6 +1375,41 @@
 description="The comma-delimited set of deny expressions"
type="java.lang.String"/>
   
  +  
  +
  +
  +  
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
 
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: cvs commit:jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/coreStandardContext.java

[Jon Scott Stevens]

on 4/30/02 2:13 PM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:

> +if (!started)
> +throw new IllegalStateException
> +(sm.getString("containerBase.notStarted", logName()));

It drives me nuts that you guys don't even follow the Sun coding spec's.

http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#449

-jon


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector ConnectorForm.java EditConnectorAction.java SaveConnectorAction.java

[manveen]

manveen 02/04/30 14:38:20

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector
ConnectorForm.java EditConnectorAction.java
SaveConnectorAction.java
  Log:
  Integrating with new mBean create operations.
  
  Revision  ChangesPath
  1.10  +6 -6  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/ConnectorForm.java
  
  Index: ConnectorForm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/ConnectorForm.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- ConnectorForm.java26 Apr 2002 07:11:01 -  1.9
  +++ ConnectorForm.java30 Apr 2002 21:38:20 -  1.10
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/ConnectorForm.java,v
 1.9 2002/04/26 07:11:01 manveen Exp $
  - * $Revision: 1.9 $
  - * $Date: 2002/04/26 07:11:01 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/ConnectorForm.java,v
 1.10 2002/04/30 21:38:20 manveen Exp $
  + * $Revision: 1.10 $
  + * $Date: 2002/04/30 21:38:20 $
*
* 
*
  @@ -74,7 +74,7 @@
* Form bean for the connector page.
*
* @author Manveen Kaur
  - * @version $Revision: 1.9 $ $Date: 2002/04/26 07:11:01 $
  + * @version $Revision: 1.10 $ $Date: 2002/04/30 21:38:20 $
*/
   
   public final class ConnectorForm extends ActionForm {
  @@ -459,7 +459,7 @@
   
   }
   
  -  /**
  +/**
* Return the object name of the service this connector belongs to.
*/
   public String getKeyStoreFileName() {
  @@ -777,7 +777,7 @@
   }   
   
   /* supported only by Coyote HTTP/1.1 connectors */
  -if (!("HTTP(AJP)".equalsIgnoreCase(connectorType)))
  +if (!("AJP".equalsIgnoreCase(connectorType)))
   numberCheck("proxyPortText",  proxyPortText, true, 0, 65535);   
 
   }
   
  
  
  
  1.5   +22 -16
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/EditConnectorAction.java
  
  Index: EditConnectorAction.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/EditConnectorAction.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- EditConnectorAction.java  26 Apr 2002 07:04:14 -  1.4
  +++ EditConnectorAction.java  30 Apr 2002 21:38:20 -  1.5
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/EditConnectorAction.java,v
 1.4 2002/04/26 07:04:14 manveen Exp $
  - * $Revision: 1.4 $
  - * $Date: 2002/04/26 07:04:14 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/EditConnectorAction.java,v
 1.5 2002/04/30 21:38:20 manveen Exp $
  + * $Revision: 1.5 $
  + * $Date: 2002/04/30 21:38:20 $
*
* 
*
  @@ -91,7 +91,7 @@
* The Action that sets up Edit Connector transactions.
*
* @author Manveen Kaur
  - * @version $Revision: 1.4 $ $Date: 2002/04/26 07:04:14 $
  + * @version $Revision: 1.5 $ $Date: 2002/04/30 21:38:20 $
*/
   
   public class EditConnectorAction extends Action {
  @@ -173,22 +173,29 @@
   connectorFm.setDebugLvlVals(Lists.getDebugLevels());   
   connectorFm.setBooleanVals(Lists.getBooleanValues());
   
  -String scheme = null;
   String attribute = null;
   try {
   
   // Copy scalar properties
   // General properties
  -attribute = "className";
  -String className = 
  +attribute = "scheme";
  +String scheme = (String) mBServer.getAttribute(cname, attribute);
  +connectorFm.setScheme(scheme);
  +
  +attribute = "protocolHandlerClassName";
  +String handlerClassName = 
   (String) mBServer.getAttribute(cname, attribute);
  -int period = className.lastIndexOf('.');
  -String connectorType = className.substring(period + 1);
  +int period = handlerClassName.lastIndexOf('.');
  +String connType = handlerClassName.substring(period + 1);
  +String connectorType = "HTTPS";
  +if ("JkCoyoteHandler".equalsIgnoreCase(connType)) {
  +connectorType = "AJP";
  +} else if ("Http11Protocol".equal

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardContext.java

[remm]

remm02/04/30 14:13:37

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  - Prevent reloading when context is not started.
  
  Revision  ChangesPath
  1.105 +9 -4  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.104
  retrieving revision 1.105
  diff -u -r1.104 -r1.105
  --- StandardContext.java  13 Apr 2002 12:36:34 -  1.104
  +++ StandardContext.java  30 Apr 2002 21:13:37 -  1.105
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
 1.104 2002/04/13 12:36:34 remm Exp $
  - * $Revision: 1.104 $
  - * $Date: 2002/04/13 12:36:34 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
 1.105 2002/04/30 21:13:37 remm Exp $
  + * $Revision: 1.105 $
  + * $Date: 2002/04/30 21:13:37 $
*
* 
*
  @@ -147,7 +147,7 @@
*
* @author Craig R. McClanahan
* @author Remy Maucherat
  - * @version $Revision: 1.104 $ $Date: 2002/04/13 12:36:34 $
  + * @version $Revision: 1.105 $ $Date: 2002/04/30 21:13:37 $
*/
   
   public class StandardContext
  @@ -2364,6 +2364,11 @@
*  property is set to false.
*/
   public synchronized void reload() {
  +
  +// Validate our current component state
  +if (!started)
  +throw new IllegalStateException
  +(sm.getString("containerBase.notStarted", logName()));
   
   // Make sure reloading is enabled
   //  if (!reloadable)
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8024] - Can't include entities in web.xml

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024

Can't include entities in web.xml





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 21:00 ---
(Is there an easy way to tell exactly what changes went into a fix for a bug? I
don't see any way to do that, unless the fix comment informally states what was
changed.)

As I've built tomcat-4.0 from the latest CVS, I would expect I'm getting the
required fix for this.  Unfortunately, it appears to have had no effect.

When I precompile my JSP pages, it still complains about the file reference.

If I use this:



I get:

XML parsing error on file /WEB-INF/web.xml: java.io.FileNotFoundException:
.\webinc.xml (The system cannot find the file specified)

I I use this:

XML parsing error on file /WEB-INF/web.xml: (line 6, col -1): Relative URI
"webinc.xml"; can not be resolved without a base URI.

I've also tried "./webinc.xml" and "file:webinc.xml", but both give the previous
error.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.1.0] Anyone testing it ?

[Amy Roh]

I'll add a MBean for NonLoginAuthenticator.  It sholdn't throw exception then.  Pls 
let me know if any other component is
missing MBean and throwing exception.  I missed that one since it wasn't part of 
default Catalina start.

Amy

Kevin Seguin wrote:

> i've done some minimal testing.  i see the following exception a lot, but that's 
>about it:
>
> ServerLifecycleListener: processContainerAddChild: MBeanException
> java.lang.Exception: ManagedBean is not found with NonLoginAuthenticator
> at org.apache.catalina.mbeans.MBeanUtils.createMBean(MBeanUtils.java:654)
> at 
>org.apache.catalina.mbeans.ServerLifecycleListener.createMBeans(ServerLifecycleListener.java:361)
> at 
>org.apache.catalina.mbeans.ServerLifecycleListener.processContainerAddChild(ServerLifecycleListener.java:820)
> at 
>org.apache.catalina.mbeans.ServerLifecycleListener.containerEvent(ServerLifecycleListener.java:148)
> at 
>org.apache.catalina.core.ContainerBase.fireContainerEvent(ContainerBase.java:1394)
> at 
>org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:829)
> at org.apache.catalina.core.ContainerBase.access$0(ContainerBase.java:811)
> at 
>org.apache.catalina.core.ContainerBase$PrivilegedAddChild.run(ContainerBase.java:182)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:805)
> at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:571)
> at 
>org.apache.catalina.core.StandardHostDeployer.install(StandardHostDeployer.java:257)
> at org.apache.catalina.core.StandardHost.install(StandardHost.java:765)
> at org.apache.catalina.startup.HostConfig.deployWARs(HostConfig.java:492)
> at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:410)
> at org.apache.catalina.startup.HostConfig.start(HostConfig.java:872)
> at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:368)
> at 
>org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:166)
> at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1194)
> at org.apache.catalina.core.StandardHost.start(StandardHost.java:731)
> at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1186)
> at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:339)
> at org.apache.catalina.core.StandardService.start(StandardService.java:496)
> at org.apache.catalina.core.StandardServer.start(StandardServer.java:699)
> at 
>org.apache.catalina.startup.CatalinaService.start(CatalinaService.java:256)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
>sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at 
>sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:324)
> at 
>org.apache.catalina.startup.BootstrapService.start(BootstrapService.java:219)
> at 
>org.apache.catalina.startup.BootstrapService.main(BootstrapService.java:279)
>
> > -Original Message-
> > From: Remy Maucherat [mailto:[EMAIL PROTECTED]]
> > Sent: Tuesday, April 30, 2002 4:50 AM
> > To: Tomcat Developers List
> > Subject: [4.1.0] Anyone testing it ?
> >
> >
> > Is anyone testing 4.1.0 ?
> > The URL as a reminder:
> > http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.0/
> >
> > Obviously, I expect people voting to rate the build to have
> > tried it ;-)
> >
> > Of particular interest is testing:
> > - AJP 1.3 support
> > - To see if bug 5735 is fixed with the current Coyote connector
> > - Jasper 2
> >
> > Thanks,
> > Remy
> >
> >
> > --
> > To unsubscribe, e-mail:
> > 
> > For additional commands, e-mail:
> > 
> >
> >
>
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteConnector.java

[remm]

remm02/04/30 13:27:37

  Modified:coyote/src/java/org/apache/coyote/tomcat4
CoyoteConnector.java
  Log:
  - Only start the endpoint in start, to avoid processing requests using a non
fully initialized pipeline.
  
  Revision  ChangesPath
  1.12  +12 -12
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteConnector.java
  
  Index: CoyoteConnector.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteConnector.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- CoyoteConnector.java  26 Apr 2002 20:13:36 -  1.11
  +++ CoyoteConnector.java  30 Apr 2002 20:27:37 -  1.12
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteConnector.java,v
 1.11 2002/04/26 20:13:36 remm Exp $
  - * $Revision: 1.11 $
  - * $Date: 2002/04/26 20:13:36 $
  + * $Header: 
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteConnector.java,v
 1.12 2002/04/30 20:27:37 remm Exp $
  + * $Revision: 1.12 $
  + * $Date: 2002/04/30 20:27:37 $
*
* 
*
  @@ -112,7 +112,7 @@
*
* @author Craig R. McClanahan
* @author Remy Maucherat
  - * @version $Revision: 1.11 $ $Date: 2002/04/26 20:13:36 $
  + * @version $Revision: 1.12 $ $Date: 2002/04/30 20:27:37 $
*/
   
   
  @@ -991,14 +991,6 @@
  "" + false);
   }
   
  -try {
  -protocolHandler.init();
  -} catch (Exception e) {
  -throw new LifecycleException
  -(sm.getString
  - ("coyoteConnector.protocolHandlerInitializationFailed", e));
  -}
  -
   }
   
   
  @@ -1015,6 +1007,14 @@
   (sm.getString("coyoteConnector.alreadyStarted"));
   lifecycle.fireLifecycleEvent(START_EVENT, null);
   started = true;
  +
  +try {
  +protocolHandler.init();
  +} catch (Exception e) {
  +throw new LifecycleException
  +(sm.getString
  + ("coyoteConnector.protocolHandlerInitializationFailed", e));
  +}
   
   }
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.1.0] Anyone testing it ?

[Remy Maucherat]

> what constitutes a "custom component"?  i didn't add anything
> to server.xml, just uncommented some things and commented out
> some other things...

After checking, that valve should be skipped, so this is a bug.
You should disable the JMX listener I mentioned in the meantime if you want
to do some additional testing.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [4.1.0] Anyone testing it ?

[Kevin Seguin]

> 
> > i've done some minimal testing.  i see the following exception
> > a lot, but that's about it:
> 
> The JMX stuff doesn't like you having a custom component 
> defined in your
> server.xml (you do have one, right ?). So the exception you 
> see indicates
> the JMX features, including the admin webapp, won't work. If 
> you don't want
> to see it, you can disable the JMX features by removing the following
> listener from the server.xml:
> 
>className="org.apache.catalina.mbeans.ServerLifecycleListener"
> debug="0"/>
> 
> Remy
> 

what constitutes a "custom component"?  i didn't add anything to server.xml, just 
uncommented some things and commented out some other things...

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.1.0] Anyone testing it ?

[Remy Maucherat]

> i've done some minimal testing.  i see the following exception
> a lot, but that's about it:

The JMX stuff doesn't like you having a custom component defined in your
server.xml (you do have one, right ?). So the exception you see indicates
the JMX features, including the admin webapp, won't work. If you don't want
to see it, you can disable the JMX features by removing the following
listener from the server.xml:

  

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [4.1.0] Anyone testing it ?

[Kevin Seguin]

i've done some minimal testing.  i see the following exception a lot, but that's about 
it:

ServerLifecycleListener: processContainerAddChild: MBeanException
java.lang.Exception: ManagedBean is not found with NonLoginAuthenticator
at org.apache.catalina.mbeans.MBeanUtils.createMBean(MBeanUtils.java:654)
at 
org.apache.catalina.mbeans.ServerLifecycleListener.createMBeans(ServerLifecycleListener.java:361)
at 
org.apache.catalina.mbeans.ServerLifecycleListener.processContainerAddChild(ServerLifecycleListener.java:820)
at 
org.apache.catalina.mbeans.ServerLifecycleListener.containerEvent(ServerLifecycleListener.java:148)
at 
org.apache.catalina.core.ContainerBase.fireContainerEvent(ContainerBase.java:1394)
at 
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:829)
at org.apache.catalina.core.ContainerBase.access$0(ContainerBase.java:811)
at 
org.apache.catalina.core.ContainerBase$PrivilegedAddChild.run(ContainerBase.java:182)
at java.security.AccessController.doPrivileged(Native Method)
at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:805)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:571)
at 
org.apache.catalina.core.StandardHostDeployer.install(StandardHostDeployer.java:257)
at org.apache.catalina.core.StandardHost.install(StandardHost.java:765)
at org.apache.catalina.startup.HostConfig.deployWARs(HostConfig.java:492)
at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:410)
at org.apache.catalina.startup.HostConfig.start(HostConfig.java:872)
at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:368)
at 
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:166)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1194)
at org.apache.catalina.core.StandardHost.start(StandardHost.java:731)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1186)
at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:339)
at org.apache.catalina.core.StandardService.start(StandardService.java:496)
at org.apache.catalina.core.StandardServer.start(StandardServer.java:699)
at org.apache.catalina.startup.CatalinaService.start(CatalinaService.java:256)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at 
org.apache.catalina.startup.BootstrapService.start(BootstrapService.java:219)
at org.apache.catalina.startup.BootstrapService.main(BootstrapService.java:279)

> -Original Message-
> From: Remy Maucherat [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, April 30, 2002 4:50 AM
> To: Tomcat Developers List
> Subject: [4.1.0] Anyone testing it ?
> 
> 
> Is anyone testing 4.1.0 ?
> The URL as a reminder:
> http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.0/
> 
> Obviously, I expect people voting to rate the build to have 
> tried it ;-)
> 
> Of particular interest is testing:
> - AJP 1.3 support
> - To see if bug 5735 is fixed with the current Coyote connector
> - Jasper 2
> 
> Thanks,
> Remy
> 
> 
> --
> To unsubscribe, e-mail:   
> 
> For additional commands, e-mail: 
> 
> 
> 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: embedded tomcat and JspServlet

[Arvind Srinivasan]

Richard Unger wrote:

> jsp: init
> Internal Error: File /WEB-INF/web.xml not found.
>

I believe this particular error message is generated (by 
o.a.j.compiler.TldLocationsCache.processWebDotXml) when initializing the default 
context (which doesn't have a WEB-INF/web.xml). I don't think this causes any problems 
(nor is it the source of your error) and the message should probably be
suppressed.

 Arvind


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5853] - Unable to get request parameters in the Error page for form based login

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5853

Unable to get request parameters in the Error page for form based login





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 19:00 ---
Thanks for clarifying - I was confusing this specific issue, with our more 
generic querystring problem - re-entered as bug # 8675 
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8675

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8675] - Unable to get Request Querystring parameters using getParameter( )

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8675

Unable to get Request Querystring parameters using getParameter( )





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 18:58 ---
I have no idea what could cause this, but Coyote is likely to fix it. Try beta 
8.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8675] - Unable to get Request Querystring parameters using getParameter( )

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8675

Unable to get Request Querystring parameters using getParameter( )





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 18:58 ---
Versions 
Linux : 2.2.16-22 #1, 
JVM : Classic VM (J2RE 1.2.2 IBM build cx122-20001026 (JIT enabled: jitc))

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8674] - examples fail due to missing "util.HTMLFilter" class

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8674

examples fail due to missing "util.HTMLFilter" class





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 18:54 ---
Bugzilla is not the right place to ask for help with using CVS.
Use "cvs update -d".

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8675] New: - Unable to get Request Querystring parameters using getParameter( )

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8675

Unable to get Request Querystring parameters using getParameter( )

   Summary: Unable to get Request Querystring parameters using
getParameter( )
   Product: Tomcat 4
   Version: 4.0.3 Final
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: Major
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Using Tomcat 4.0.3: while executing a JSP page requesting parameters
from the URL:

   request.getParameter() returns null
but
   request.getQueryString() returns the correct query string.

When started, our server performs the above instructions correctly for a while,
but then ends up in a situation where these instructions fail. 
Once the server get's into this state, it affects all jsp pages simultaneously.
The only way to take the server out of this state is by restarting (clearing 
the work directory does not help). Restarting once may not always be enough.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8674] - examples fail due to missing "util.HTMLFilter" class

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8674

examples fail due to missing "util.HTMLFilter" class





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 18:52 ---
I've done "cvs update" on "jakarta-tomcat-4.0" three times after I noticed this.
Either it's in some other repository that isn't obvious to me, or it really
isn't there, or I'm doing something wrong.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8674] - examples fail due to missing "util.HTMLFilter" class

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8674

examples fail due to missing "util.HTMLFilter" class

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 18:47 ---
It's there. Check out again the repository.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8674] New: - examples fail due to missing "util.HTMLFilter" class

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8674

examples fail due to missing "util.HTMLFilter" class

   Summary: examples fail due to missing "util.HTMLFilter" class
   Product: Tomcat 4
   Version: Nightly Build
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Webapps:Examples
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The jakarta-tomcat-4.0 build from CVS is failing because the webapps/examples
are failing to build.  There is a reference to an HTMLFilter class in several
classes, but this class doesn't appear to be defined anywhere.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5853] - Unable to get request parameters in the Error page for form based login

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5853

Unable to get request parameters in the Error page for form based login

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 18:31 ---
It was marked WONTFIX because any change along these lines would be nonportable
to any other container.

Form based login was designed (and specified in the Servlet Spec) in a manner
that emulates the user experience of using BASIC authentication:
* You request a protected resource
* A dialog box pops up asking you for the username and password
* (If you type them wrong, the box is redisplayed with an error message)
* When you are successfully authenticated, your *original*
  request is executed unchanged.

The only difference with form-based login is that you get to define the UI of
the login and error pages.  In neither of those pages do you have *any* access
to any aspect of the original request that triggered authentication.  The server
 has cached that away so that it can be replayed once you are successfully
authenticated (in BASIC it's actually the browser that does this, but the user
experience is identical).

If that is not sufficient for your requirements, you should use some technique
other than form based login for your app.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

embedded tomcat and JspServlet

[Richard Unger]

I've written an Embedded tomcat (4.0.3) that reads in the standard 
${catalina.home}/conf/web.xml.  Servlets and .war files work fine.  However, when I 
try to fetch a jsp page, the result comes back with several stack traces to the effect 
of not being able to find the javax.servlet package and classes.

The catalina log contains:

jsp: init
Internal Error: File /WEB-INF/web.xml not found.

Any notions?

Thanks,
Rich

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans ConnectorMBean.java mbeans-descriptors.xml

[amyroh]

amyroh  02/04/30 11:24:08

  Modified:catalina/src/share/org/apache/catalina/mbeans
ConnectorMBean.java mbeans-descriptors.xml
  Log:
  Add protocolHandlerClassName so the admin can tell AJP connector.
  Minor package error fix.
  
  Revision  ChangesPath
  1.2   +4 -4  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java
  
  Index: ConnectorMBean.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- ConnectorMBean.java   30 Apr 2002 17:47:26 -  1.1
  +++ ConnectorMBean.java   30 Apr 2002 18:24:08 -  1.2
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java,v
 1.1 2002/04/30 17:47:26 amyroh Exp $
  - * $Revision: 1.1 $
  - * $Date: 2002/04/30 17:47:26 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java,v
 1.2 2002/04/30 18:24:08 amyroh Exp $
  + * $Revision: 1.2 $
  + * $Date: 2002/04/30 18:24:08 $
*
* 
*
  @@ -61,7 +61,7 @@
*
*/
   
  -package catalina.src.share.org.apache.catalina.mbeans;
  +package org.apache.catalina.mbeans;
   
   import java.lang.reflect.Method;
   import javax.management.MBeanException;
  @@ -76,7 +76,7 @@
* org.apache.coyote.tomcat4.CoyoteConnector component.
*
* @author Amy Roh
  - * @version $Revision: 1.1 $ $Date: 2002/04/30 17:47:26 $
  + * @version $Revision: 1.2 $ $Date: 2002/04/30 18:24:08 $
*/
   
   public class ConnectorMBean extends BaseModelMBean {
  
  
  
  1.52  +5 -0  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml
  
  Index: mbeans-descriptors.xml
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml,v
  retrieving revision 1.51
  retrieving revision 1.52
  diff -u -r1.51 -r1.52
  --- mbeans-descriptors.xml30 Apr 2002 17:47:26 -  1.51
  +++ mbeans-descriptors.xml30 Apr 2002 18:24:08 -  1.52
  @@ -6,7 +6,7 @@
   
   
   
  @@ -192,6 +192,11 @@
   
  +
  +
   
   mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/webapps/admin/connector connector.jsp

[manveen]

manveen 02/04/30 11:10:48

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin
ApplicationResources_en.properties
ApplicationResources_es.properties
   webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector
AddConnectorAction.java SaveConnectorAction.java
   webapps/admin/connector connector.jsp
  Log:
  Trying to use the new createConnector methods -- testing
  
  Revision  ChangesPath
  1.48  +2 -0  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties
  
  Index: ApplicationResources_en.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties,v
  retrieving revision 1.47
  retrieving revision 1.48
  diff -u -r1.47 -r1.48
  --- ApplicationResources_en.properties29 Apr 2002 01:07:53 -  1.47
  +++ ApplicationResources_en.properties30 Apr 2002 18:10:47 -  1.48
  @@ -129,6 +129,8 @@
   host.wars=Unpack WARs
   host.aliases=Aliases
   host.alias.name=Alias Name
  +error.aliasName.exists=Alias already exists
  +error.aliasName.required=Alias name is required
   context.properties=Context Properties
   context.cookies=Cookies
   context.cross.context=Cross Context
  
  
  
  1.42  +2 -0  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties
  
  Index: ApplicationResources_es.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties,v
  retrieving revision 1.41
  retrieving revision 1.42
  diff -u -r1.41 -r1.42
  --- ApplicationResources_es.properties29 Apr 2002 01:07:53 -  1.41
  +++ ApplicationResources_es.properties30 Apr 2002 18:10:47 -  1.42
  @@ -130,6 +130,8 @@
   host.wars=Desempaquetar WARs
   host.aliases=Aliases
   host.alias.name=Alias Nombre
  +error.aliasName.exists=Alias ya existe
  +error.aliasName.required=Alias nombre requiredo
   context.properties=Propiedades del contexto
   context.cookies=Cookies
   context.cross.context=Cross Context
  
  
  
  1.6   +5 -5  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/AddConnectorAction.java
  
  Index: AddConnectorAction.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/AddConnectorAction.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- AddConnectorAction.java   26 Apr 2002 19:05:12 -  1.5
  +++ AddConnectorAction.java   30 Apr 2002 18:10:47 -  1.6
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/AddConnectorAction.java,v
 1.5 2002/04/26 19:05:12 manveen Exp $
  - * $Revision: 1.5 $
  - * $Date: 2002/04/26 19:05:12 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/AddConnectorAction.java,v
 1.6 2002/04/30 18:10:47 manveen Exp $
  + * $Revision: 1.6 $
  + * $Date: 2002/04/30 18:10:47 $
*
* 
*
  @@ -82,7 +82,7 @@
* The Action that sets up Add Connector transactions.
*
* @author Manveen Kaur
  - * @version $Revision: 1.5 $ $Date: 2002/04/26 19:05:12 $
  + * @version $Revision: 1.6 $ $Date: 2002/04/30 18:10:47 $
*/
   
   public class AddConnectorAction extends Action {
  @@ -169,7 +169,7 @@
   String schemeTypes[]= new String[3];
   schemeTypes[0] = "HTTP";
   schemeTypes[1] = "HTTPS";
  -schemeTypes[2] = "HTTP(AJP)";
  +schemeTypes[2] = "AJP";
   
   ArrayList types = new ArrayList();
   // the first element in the select list should be the type selected
  
  
  
  1.6   +13 -11
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/SaveConnectorAction.java
  
  Index: SaveConnectorAction.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/SaveConnectorAction.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- SaveConnectorAction.java  26 Apr 2002 07:11:02 -  1.5
  +++ SaveConnectorAction.java  30 Apr 2002 18:10:47 -  1.6
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/SaveConnectorAction.java,v
 

DO NOT REPLY [Bug 5853] - Unable to get request parameters in the Error page for form based login

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5853

Unable to get request parameters in the Error page for form based login

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |



--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 18:04 ---
Re-opening bug - no explanation found for why it was set to RESOLVED WONTFIX

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/config WebXml2Jk.java

[costin]

costin  02/04/30 10:55:27

  Modified:jk/java/org/apache/jk/config WebXml2Jk.java
  Log:
  Few more lines of code.
  
  Revision  ChangesPath
  1.2   +74 -4 
jakarta-tomcat-connectors/jk/java/org/apache/jk/config/WebXml2Jk.java
  
  Index: WebXml2Jk.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/config/WebXml2Jk.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- WebXml2Jk.java30 Apr 2002 17:40:57 -  1.1
  +++ WebXml2Jk.java30 Apr 2002 17:55:26 -  1.2
  @@ -131,7 +131,7 @@
   
   /** Set the canonycal name of the virtual host.
*/
  -public void setVhost( String vhost ) {
  +public void setHost( String vhost ) {
   this.vhost=vhost; 
   }
   
  @@ -169,7 +169,7 @@
*
* This is equivalent to the worker in jk1.
*/
  -public void setJkGroup(String route ) {
  +public void setGroup(String route ) {
   worker=route;
   }
   
  @@ -190,6 +190,7 @@
   out.println( "#servlet=" +  getContent( servN ));
   out.println( "#cpath=" +  cpath );
   out.println( "#vhost=" +  vhost );
  +out.println();
   }
   
   Node lcN=getChild( webN, "login-config" );
  @@ -204,8 +205,72 @@
   String loginPage=getContent( getChild( n1, "form-login-page"));
   String errPage=getContent( getChild( n1, "form-error-page"));
   
  -System.out.println("LOGIN: " + loginPage );
  -System.out.println("ERR: " + errPage );
  +out.println("[url:" + vhost + cpath + loginPage  + "]" );
  +out.println( "group=" + worker );
  +out.println();
  +out.println("[url:" + vhost + cpath + errPage  + "]" );
  +out.println( "group=" + worker );
  +out.println();
  +}
  +
  +System.out.println("Generating mappings for security constraints " );
  +for( Node mapN=getChild( webN, "security-constraint" );
  + mapN != null; mapN = getNext( mapN )) {
  +Node wrcN=getChild( mapN, "web-resource-collection");
  +
  +Vector methods=new Vector();
  +for( Node uN=getChild(wrcN, "http-method");
  + uN!=null; uN=getNext( uN )) {
  +methods.addElement( getContent( uN ));
  +}
  +
  +Vector urls=new Vector();
  +for( Node uN=getChild(wrcN, "url-pattern");
  + uN!=null; uN=getNext( uN )) {
  +urls.addElement( getContent( uN ));
  +}
  +
  +// Not used at the moment
  +Node acN=getChild( mapN, "auth-constraint");
  +Vector roles=new Vector();
  +for( Node rN=getChild(acN, "role-name");
  + rN!=null; rN=getNext( rN )) {
  +roles.addElement(getContent( rN ));
  +}
  +generateConstraints( urls, methods, roles );
  +}
  +}
  +
  +// To be included in a  section
  +void generateJk1Mount(Node webN, PrintWriter out) {
  +
  +System.out.println("Generating JkMount for servlets " );
  +for( Node mapN=getChild( webN, "servlet-mapping" );
  + mapN != null; mapN = getNext( mapN ) ) {
  +
  +Node servN=getChild( mapN, "servlet-name");
  +if( servN==null )
  +servN=getChild( mapN, "jsp-file");
  +Node url=getChild( mapN, "url-pattern");
  +
  +out.println( "JkMount " + cpath + getContent(url) + " " + worker);
  +}
  +
  +Node lcN=getChild( webN, "login-config" );
  +if( lcN!=null ) {
  +System.out.println("Generating mapping for login-config " );
  +
  +Node authMethN=getChild( lcN, "auth-method");
  +String authMeth=getContent( authMethN );
  +if( authMeth == null ) authMeth="FORM";
  +
  +Node n1=getChild( lcN, "form-login-config");
  +String loginPage=getContent( getChild( n1, "form-login-page"));
  +String errPage=getContent( getChild( n1, "form-error-page"));
  +
  +out.println("JkMount " + cpath + loginPage  + " " + worker );
  +out.println("JkMount " + cpath + errPage  + " " + worker );
  +out.println();
   }
   
   System.out.println("Generating mappings for security constraints " );
  @@ -362,6 +427,11 @@
   System.out.println("Usage: ");
   System.out.println("  WebXml2Jk [OPTIONS]");
   System.out.println();
  +System.out.println("  -docBase DIRThe location of the 
webapp. Required");
  +System.out.println("  -group GROUPGroup, if you have 
multiple tomcats with dif

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans ConnectorMBean.java StandardServerMBean.java mbeans-descriptors.xml

[amyroh]

amyroh  02/04/30 10:47:26

  Modified:catalina/src/share/org/apache/catalina/mbeans
StandardServerMBean.java mbeans-descriptors.xml
  Added:   catalina/src/share/org/apache/catalina/mbeans
ConnectorMBean.java
  Log:
  Add ServerSocketFactory properties to HttpsConnector.
  
  Revision  ChangesPath
  1.12  +5 -4  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/StandardServerMBean.java
  
  Index: StandardServerMBean.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/StandardServerMBean.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- StandardServerMBean.java  30 Apr 2002 03:25:22 -  1.11
  +++ StandardServerMBean.java  30 Apr 2002 17:47:26 -  1.12
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/StandardServerMBean.java,v
 1.11 2002/04/30 03:25:22 amyroh Exp $
  - * $Revision: 1.11 $
  - * $Date: 2002/04/30 03:25:22 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/StandardServerMBean.java,v
 1.12 2002/04/30 17:47:26 amyroh Exp $
  + * $Revision: 1.12 $
  + * $Date: 2002/04/30 17:47:26 $
*
* 
*
  @@ -109,7 +109,7 @@
* org.apache.catalina.core.StandardServer component.
*
* @author Amy Roh
  - * @version $Revision: 1.11 $ $Date: 2002/04/30 03:25:22 $
  + * @version $Revision: 1.12 $ $Date: 2002/04/30 17:47:26 $
*/
   
   public class StandardServerMBean extends BaseModelMBean {
  @@ -765,6 +765,7 @@
   }  
   writer.println("");
   
  +// Store the ending of this element
   for (int i = 0; i < indent; i++) {
   writer.print(' ');
   }  
  
  
  
  1.51  +29 -9 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml
  
  Index: mbeans-descriptors.xml
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml,v
  retrieving revision 1.50
  retrieving revision 1.51
  diff -u -r1.50 -r1.51
  --- mbeans-descriptors.xml30 Apr 2002 03:25:22 -  1.50
  +++ mbeans-descriptors.xml30 Apr 2002 17:47:26 -  1.51
  @@ -6,7 +6,7 @@
   
   
   
  @@ -128,7 +128,7 @@
   
   
   
   
  +
  +
   
  @@ -164,17 +168,17 @@
 description="The debugging detail level for this component"
type="int"/>
   
  -
  -
   
   
  -
  +  
  +
  +  
   
   
  +
  + 
  +  
  +  
  +
  +
   
   
  +
  +
   
   http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Tomcat", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   * [Additional notices, if required by prior licensing conditions]
   *
   */
  
  package catalina.src.share.org.apache.catalina.mbeans;
  
  import java.lang.reflect.Method;
  import javax.management.MBeanException;
  import javax.management.RuntimeOperationsException;
  import org.apache.catalina.Connect

Re: [PATCH] Re: [PROPOSAL] Modification of the code generated by Jasper2

[peter lin]

Here is a bit more information on the test pages I have.

total tags used: 172
main page: 105
header page: 65
footer page: 2

Actually there the main page includes a few other pages using  in JSTL. The total count on the tags used is over 200, but the other files are 
>smaller, using a dozen or so tags.

I will do more tests using coyote a later in the week. Once I have that
data, I will post it.

peter lin


Remy Maucherat wrote:
> 
> > I just ran a quick test using the test pages I used earlier for
> > benchmarking, and the results are very positive. Thanks to Denis for
> > patch.  The following data might bring a smile.  Here is a link to the
> > previous benchmarks I posted.
> >
> > http://www.mail-archive.com/tomcat-user@jakarta.apache.org/msg49733.html
> >
> > The benchmark was performed on System II mentioned in the previous post
> > in tomcat-user list. Another system was used to send requests.
> 
> I don't remember what your test page was (and I can't find which series of
> tests I should compare to also ;-)), but you have to remember that the bug
> is that the time needed by the JVM is non linear to the number of tags. So
> if you use 10 tags in the page, it should help a bit. If you use 100 tags,
> it will help a LOT. If you use more tags, the page will likely not work at
> all without the patch.
> 
> Remy
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Idea for dtomcat4 script/conf in webapp.rpm

[Mark Diggory]

Think I did this right, didn't I? (I diff'ed my changes against 
tomcat_404_b2 jakarta-tomcat-4.0/catalina/src/bin/catalina.sh)

The patchfile is attached:
-Mark

Mark Diggory wrote:

> Which Tag is for 4.0.4 ? (tomcat_404_b2_01 or tomcat_404_b2)
> 
> or do I want to do it against 4.1 (HEAD)
> 
> -Mark
> 
> GOMEZ Henri wrote:
> 
 BTW, as rpm packager I'm trying to works closely with projects to
 have such add-ons included directly in original tarball which
 help developpers fixes problems of rpm users.


>>> I'm all for that. Do you know who is currently managing the 
>>> /usr/bin/dtomcat file in the current tarball? Maybe they can get in 
>>> on the conversation.
>>>
>>
>> dtomcat is just the rpm renaming of original catalina.sh...



Index: catalina.sh
===
RCS file: /home/cvspublic/jakarta-tomcat-4.0/catalina/src/bin/catalina.sh,v
retrieving revision 1.20.2.3
diff -u -r1.20.2.3 catalina.sh
--- catalina.sh 19 Mar 2002 18:24:36 -  1.20.2.3
+++ catalina.sh 30 Apr 2002 17:39:06 -
@@ -17,6 +17,9 @@
 #   the JVM should use (java.io.tmpdir).  Defaults to
 #   $CATALINA_BASE/temp.
 #
+#   CATALINA_LOG(Optional) Provides alternate output locations for StandardOut
+#   and StandardErr
+#
 #   JAVA_HOME   Must point at your Java Development Kit installation.
 #
 #   JAVA_OPTS   (Optional) Java runtime options used when the "start",
@@ -94,6 +97,11 @@
   CATALINA_TMPDIR="$CATALINA_BASE"/temp
 fi
 
+if [ -z "$CATALINA_LOG" ] ; then
+  # Define the default location for StandardErr and StandardOut to use for Catalina
+CATALINA_LOG="$CATALINA_BASE"/logs/catalina.out
+fi
+
 # For Cygwin, switch paths to Windows format before running java
 if $cygwin; then
   JAVA_HOME=`cygpath --path --windows "$JAVA_HOME"`
@@ -107,6 +115,7 @@
 echo "Using CATALINA_BASE:   $CATALINA_BASE"
 echo "Using CATALINA_HOME:   $CATALINA_HOME"
 echo "Using CATALINA_TMPDIR: $CATALINA_TMPDIR"
+echo "Using CATALINA_LOG:$CATALINA_LOG"
 echo "Using JAVA_HOME:   $JAVA_HOME"
 
 if [ "$1" = "jpda" ] ; then
@@ -197,7 +206,7 @@
   -Dcatalina.home="$CATALINA_HOME" \
   -Djava.io.tmpdir="$CATALINA_TMPDIR" \
   org.apache.catalina.startup.Bootstrap "$@" start \
-  >> "$CATALINA_BASE"/logs/catalina.out 2>&1 &
+  >> "$CATALINA_LOG" 2>&1 &
   else
 "$_RUNJAVA" $JAVA_OPTS $CATALINA_OPTS \
   -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \
@@ -205,7 +214,7 @@
   -Dcatalina.home="$CATALINA_HOME" \
   -Djava.io.tmpdir="$CATALINA_TMPDIR" \
   org.apache.catalina.startup.Bootstrap "$@" start \
-  >> "$CATALINA_BASE"/logs/catalina.out 2>&1 &
+  >> "$CATALINA_LOG" 2>&1 &
   fi
 
 elif [ "$1" = "stop" ] ; then



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/common Shm.java

[costin]

costin  02/04/30 10:44:50

  Modified:jk/java/org/apache/jk/common Shm.java
  Log:
  Use the WRITE_SLOT command.
  
  Again, the idea is that the scoreboard is divided in 'slots', each slot
  has a name ( identifying the 'owner' ).
  
  We'll use the scoreboard for configuration ( at first ), with a
  java bean ( used either individually or at tomcat startup ) writing
  information in the scoreboard about a tomcat instance.
  
  The lb worker will read the 'serial' number in the scoreboard header
  and update it's instance table based on the content.
  
  The synchronization is not implemented yet - if 2 tomcats
  are registered at the exact same time we may get unexpected results
  ( a bit unlikely, will be fixed after we 'bridge' the APR locks ).
  
  Revision  ChangesPath
  1.7   +8 -5  jakarta-tomcat-connectors/jk/java/org/apache/jk/common/Shm.java
  
  Index: Shm.java
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/common/Shm.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- Shm.java  25 Apr 2002 22:44:23 -  1.6
  +++ Shm.java  30 Apr 2002 17:44:50 -  1.7
  @@ -85,7 +85,7 @@
   
   // Will be dynamic ( getMethodId() ) after things are stable 
   static final int SHM_SET_ATTRIBUTE=0;
  -static final int SHM_REGISTER_TOMCAT=2;
  +static final int SHM_WRITE_SLOT=2;
   static final int SHM_ATTACH=3;
   static final int SHM_DETACH=4;
   
  @@ -142,8 +142,13 @@
   
   this.invoke( msg, mCtx );
   }
  +
  +public void registerTomcat(String host, int port) throws IOException {
  +String slotName="TOMCAT:" + host + ":" + port;
  +writeSlot( slotName );
  +}
   
  -public void registerTomcat(String host, int port)
  +public void writeSlot(String slotName)
   throws IOException
   {
   if( apr==null ) return;
  @@ -151,10 +156,8 @@
   Msg msg=(Msg)mCtx.getMsg(0);
   msg.reset();
   C2BConverter c2b=(C2BConverter)mCtx.getNote(C2B_NOTE);
  -
  -String slotName="TOMCAT:" + host + ":" + port;
   
  -msg.appendByte( SHM_REGISTER_TOMCAT );
  +msg.appendByte( SHM_WRITE_SLOT );
   appendString( msg, slotName, c2b );
   
   this.invoke( msg, mCtx );
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/config WebXml2Jk.java

[costin]

costin  02/04/30 10:40:57

  Added:   jk/java/org/apache/jk/config WebXml2Jk.java
  Log:
  Initial code for the web.xml to jk2 converter.
  
  The file will work as an ant task, as CLI ( with each ant attribute
  used as -ATTRIBUTE VALUE ) or as a bean.
  
  It will read web.xml files and generate jk2 configs - no tomcat
  is required.
  
  Revision  ChangesPath
  1.1  
jakarta-tomcat-connectors/jk/java/org/apache/jk/config/WebXml2Jk.java
  
  Index: WebXml2Jk.java
  ===
  /*
   * 
   *
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Tomcat", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   * [Additional notices, if required by prior licensing conditions]
   *
   */
  package org.apache.jk.config;
  
  import java.io.*;
  import java.net.*;
  import java.util.*;
  import java.security.*;
  
  import org.apache.tomcat.util.IntrospectionUtils;
  
  import javax.xml.parsers.*;
  
  /* Yes, it's using DOM */
  import org.w3c.dom.*;
  import org.xml.sax.*;
  
  
  /* Naming conventions:
  
  JK_CONF_DIR == serverRoot/work  ( XXX /jkConfig ? )
  
  - Each vhost has a sub-dir named after the canonycal name
  
  - For each webapp in a vhost, there is a separate WEBAPP_NAME.jkmap
  
  - In httpd.conf ( or equivalent servers ), in each virtual host you
  should "Include JK_CONF_DIR/VHOST/jk_apache.conf". The config
  file will contain the Alias declarations and other rules required
  for apache operation. Same for other servers. 
  
  - WebXml2Jk will be invoked by a config tool or automatically for each
  webapp - it'll generate the WEBAPP.jkmap files and config fragments.
  
  WebXml2Jk will _not_ generate anything else but mappings.
  It should _not_ try to guess locations or anything else - that's
  another components' job.
  
  */
  
  /**
   * Read a web.xml file and generate the mappings for jk2.
   * It can be used from the command line or ant.
   * 
   * In order for the web server to serve static pages, all webapps
   * must be deployed on the computer that runs Apache, IIS, etc.
   *
   * Dynamic pages can be executed on that computer or other servers
   * in a pool, but even if the main server doesn't run tomcat,
   * it must have all the static files and WEB-INF/web.xml.
   * ( you could have a script remove everything else, i

Re: [PATCH] Re: [PROPOSAL] Modification of the code generated by Jasper2

[Remy Maucherat]

> I just ran a quick test using the test pages I used earlier for
> benchmarking, and the results are very positive. Thanks to Denis for
> patch.  The following data might bring a smile.  Here is a link to the
> previous benchmarks I posted.
>
> http://www.mail-archive.com/tomcat-user@jakarta.apache.org/msg49733.html
>
> The benchmark was performed on System II mentioned in the previous post
> in tomcat-user list. Another system was used to send requests.

I don't remember what your test page was (and I can't find which series of
tests I should compare to also ;-)), but you have to remember that the bug
is that the time needed by the JVM is non linear to the number of tags. So
if you use 10 tags in the page, it should help a bit. If you use 100 tags,
it will help a LOT. If you use more tags, the page will likely not work at
all without the patch.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PATCH] Re: [PROPOSAL] Modification of the code generated by Jasper2

[peter lin]

I just ran a quick test using the test pages I used earlier for
benchmarking, and the results are very positive. Thanks to Denis for
patch.  The following data might bring a smile.  Here is a link to the
previous benchmarks I posted.

http://www.mail-archive.com/tomcat-user@jakarta.apache.org/msg49733.html

The benchmark was performed on System II mentioned in the previous post
in tomcat-user list. Another system was used to send requests.
 

New Results with Denis Patch
-

1 thread 1000
---
ave - 46
cpu usage - 35-50%

2 threads 500
---
ave - 73
cpu usage - 40-80%

4 threads 250
---
ave - 133
cpu usage - 50-80%

8 threads 125
---
ave - 235
cpu usage - 60-85%

16 threads 65
---
ave - 479
cpu usage - 60-95%

32 threads 63
---
ave - 1157
cpu usage - 80-95%


Remy Maucherat wrote:
> 
> I've applied the patch. Watchdog is fine, so I committed it.
> 
> The admin webapp appeared slow before the patch (esp when using a context
> page), and that was with an Athlon 1700 as the server with one user (me).
> I'm not happy in general when a request uses 100% of the CPU for 1 full
> second ;-) I couldn't figure out why it was so slow, and the other runtime
> optimizations didn't help at all. It turns out it was caused by this JVM bug
> ... With the patch, it's become quite fast. Very impressive, and since IMO
> it is quite representative of a Struts based application which would have
> complex pages, it's really awesome.
> 
> I suppose the fast JSP compilers (Resin, Orion) use similar tricks in the
> code generation.
> 
> Remy
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 



peter lin

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: AW: AW: PROPOSAL: mod_jk2 autoconfig

[costinm]

On Tue, 30 Apr 2002, Hans Schmid wrote:

> For the few bits of static content in our webapps (few logos) we do not
> really care (yet). They are served by Tomcat.
> 
> So we do not even have a Tomcat installed on our webservers - so no webapps
> directories.

You don't have to have tomcat installed - you can have a webapps 
directory without tomcat :-)

My proposal works regardless of tomcat's presence - all you need 
is a hierarchy of directories and some config files in some pre-set
locations - it will resemble ( or be the same with ) tomcat's webapps/.

If you have the 'real' webapp installed in the hierarchy ( or the 
static subset - you can remove all dynamic pages ), then we'll just 
use the directory name and WEB-INF/jk2/ for configuration. If you 
don't want any file on the apache server - you just have one file
for each webapp with the basic config information.

The only issue is making this consistent and easy ( and eventually
allow us in future to implement reloading ).

> We make heavy use of the apps-myall.xml files in TC 3.3.1 - but as I said,
> no Tomcat on our webservers.
> We have 2 hardware loadbalanced small pizzaboxes running Apache and three
> bigger Solaris machines
> running our Tomcats and the database.

I understand. This is just one more simple overhead - instead of 
editing httpd.conf and use JkMount you'll use one file for each
application.

Or just ignore this proposal and use manual configuration - what
I'm trying to solve is getting 'simple things simple'.

> Have not yet figured out how to combine our static DocumentRoot plus serving
> static contents from our webapps.

One easy way would be to configure the /webapps location to be the same 
dir with the DocumentRoot.

( of course, some Deny for WEB-INF will be required - but that's 
allways the case and we can do it automatically ).

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/webapp/support aplocal.m4

[pier]

pier02/04/30 09:42:44

  Modified:webapp/support aplocal.m4
  Log:
  Stripped little thing  that prevented to build ./configure with AutoConf
  2.52 and greater.
  
  Revision  ChangesPath
  1.10  +6 -6  jakarta-tomcat-connectors/webapp/support/aplocal.m4
  
  Index: aplocal.m4
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/webapp/support/aplocal.m4,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- aplocal.m41 Nov 2001 22:20:52 -   1.9
  +++ aplocal.m430 Apr 2002 16:42:44 -  1.10
  @@ -57,7 +57,7 @@
   
   dnl --
   dnl Author Pier Fumagalli <[EMAIL PROTECTED]>
  -dnl Version $Id: aplocal.m4,v 1.9 2001/11/01 22:20:52 pier Exp $
  +dnl Version $Id: aplocal.m4,v 1.10 2002/04/30 16:42:44 pier Exp $
   dnl --
   
   dnl --
  @@ -127,11 +127,11 @@
   ])
   
   AC_DEFUN(LOCAL_HELP,[
  -  AC_DIVERT_PUSH(AC_DIVERSION_NOTICE)
  -  ac_help="${ac_help}
  -
  -[$1]"
  -  AC_DIVERT_POP()
  +dnl   AC_DIVERT_PUSH(AC_DIVERSION_NOTICE)
  +dnl   ac_help="${ac_help}
  +dnl 
  +dnl [$1]"
  +dnl   AC_DIVERT_POP()
   ])
   
   dnl --
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4930] - java.io.StreamCorruptedException: Type code out of range, is 0 with Apache WebApp module

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4930

java.io.StreamCorruptedException: Type code out of range, is 0 with Apache WebApp 
module

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Resend: SSL portability and Coyote

[Eric Rescorla]

"Bill Barker" <[EMAIL PROTECTED]> writes:
> From: "Eric Rescorla" <[EMAIL PROTECTED]>
> > "Bill Barker" <[EMAIL PROTECTED]> writes:
> > > Also, somebody in o.a.c.tomcat4 needs to fire the
> ACTION_REQ_SSL_ATTRIBUTE
> > > action.  That's the Coyote replacement for CertificateValve.
> > Ah. Can you give me the 10,000 overview on how ATTRIBUTES work (or
> > point me to the right location)?
> 
> I assume you mean actions.  They are defined in o.a.c.ActionCode, and
> processed by somebody implementing o.a.c.ActionHook (both under the "coyote"
> directory).  For the HTTP/1.1 connector, this is
> o.a.c.http11.Http11Processor (under the "http11" directory).  The usual way
> to fire them is to call o.a.c.Response.action (which is conventionally named
> "coyoteResponse").  For the SSL action, the second parameter is the
> o.a.c.Request.
Hmm I arranged to call this hook in
o.a.c.tomcat4.CoyoteAdapter.postParseRequest, but none of the values
seem to be getting propagated to the servlets. I've verified that
setAttribute call is made, the variables just don't show up.

I'm not really excited about debugging this since it seems to require
first figuring out how Coyote and Cataline move attributes around,
which I assume someone already knows how to do. If that someone has a
working example of setting any such attribute using an action that
would be a greatly appreciated. At that point, I should be able to
adapt it to set the SSL attributes. Even a fixed string would be fine.

Anyone?

-Ekr

-- 
[Eric Rescorla   [EMAIL PROTECTED]]
http://www.rtfm.com/

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

AW: AW: PROPOSAL: mod_jk2 autoconfig

[Hans Schmid]

> -Ursprungliche Nachricht-
> Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> Gesendet: Dienstag, 30. April 2002 16:39
> An: Tomcat Developers List
> Betreff: Re: AW: PROPOSAL: mod_jk2 autoconfig
>
>
> On Tue, 30 Apr 2002, Hans Schmid wrote:
>
> > I can not see how this works if you have Apache and Tomcat on different
> > machines.
> > This way we do not have a webapp/ directory on that Apache server.
>
> It works fine.
>
> There are 2 cases:
> 1. You want Apache to serve static pages. That's the 'normal' case, and
> it automatically require that you _have_ the webapp (at lest the static
> pages, you can remove the clasesses, lib, etc ) on the apache server.
>
> 2. You don't want apache to serve static pages for the app. In this case
> you'll just put a small file in the webapp/ ( myApp.jk2 or something
> similar - see how 3.3 apps-myApp.xml or 4.1 webapps/myApp.xml works ),
> with the single mapping that is required to forward all requests.
>

We have lots of not webapp related static stuff so we have set the
DocumenRoot of apache
at our static 'source' tree (not tomcat related source tree).

For the few bits of static content in our webapps (few logos) we do not
really care (yet).
They are served by Tomcat.

This has all historic reasons. This is an old system migrating slowly :)

So we do not even have a Tomcat installed on our webservers - so no webapps
directories.

> Even in the second case, I think it is easier to 'deploy' one conf file
> per webapp in a clear format than editing workers.properties.
>
> > Did I misunderstand the intent of this configuration? Is it a
> 'best guess'
> > for simple setups?
> > Probably in our scenario we have to configure it manually anyways.
>
> Manual configuration will work, of course. In tomcat you can still edit
> server.xml. It's just that I would strongly discourage that for 'normal'
> use.
>

We make heavy use of the apps-myall.xml files in TC 3.3.1 - but as I said,
no Tomcat on our webservers.
We have 2 hardware loadbalanced small pizzaboxes running Apache and three
bigger Solaris machines
running our Tomcats and the database.

> > > Some 'special' files ( like in 4.1 and the 3.3 apps- files ) will
> > > also be read and used to load webapps that sit in different
> directories.
> >
> > same here we are on different machines.
>
> Again, all you need is to install 1 file on the server machine for each
> webapp ( without static files ).
>
> I personally believe that is a very bad choice to not let apache serve
> the static files, but it'll work.

Have not yet figured out how to combine our static DocumentRoot plus serving
static
contents from our webapps.

>
> > Just make sure, everything in the config can be overwritten and
> configures
> > manually
> > if possible in a single file (as workers.properties right now)
>
> Either workers2.properties, or one file in the webapps ( named
> after the application, with .jk2 extension ).
>
> The file can be used if you have the docRoot in a different place in
> the apache server.
>
>

exactly this is our setup. So we will use a workers2.properties.

Thanks for clarifying.

Cheers,
Hans


> Costin
>
>
> --
> To unsubscribe, e-mail:
> 
> For additional commands, e-mail:
> 
>
>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[TEST] Please ignore...

[Pier Fumagalli]

I need to test the antivirus thinghie on a _BIG_ list, and that's a good
one...

Sorry...

Pier


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Problem with url session encoding - Tomcat 4.0.4 b2

[Craig R. McClanahan]

On Tue, 30 Apr 2002, Arshad Mahmood wrote:

> Date: Tue, 30 Apr 2002 11:12:48 +0100
> From: Arshad Mahmood <[EMAIL PROTECTED]>
> Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>
> To: Tomcat Developers List <[EMAIL PROTECTED]>
> Subject: Problem with url session encoding - Tomcat 4.0.4 b2
>
> Hi,
>
> I am writing an e-commerce application using tomcat and have come across a
> minor issue with url session encoding. The problem is that if a valid
> session id is available on the url then tomcat does not use cookies.
>
> Here is my scenario :-
>
> 1. I have tomcat configured to use cookies for session id's if possible.
> 2. An access to the index.html of my site redirects via url encoding to
> home/index.html. This causes the session to be sent both via the url and a
> cookie, from here on tomcat knows it can use cookies and doesn't bother
> adding the session id to the url when I use encodeURL.
>

This is not quite right.  Tomcat doesn't know it can use cookies until the
browser makes the second request *with* a cookie.

> 3. If I close the browser and open a new browser and use the url history box
> then the url that appears is home/index.html with the added url encoding
> (because I redirected from the original index.html).

As you've probably gathered, closing the browser kills your session
cookies, which effectively logs you off of your sessions.  This is a "Good
Thing" (tm) -- otherwise, what happens if someone else happens to come
along and uses your PC, instead of you?  Presto, they would be
authenticated with your ID and could do all sorts of mischief.

> 4. Because this url has a valid session id, tomcat now defaults to using the
> url endoing method and doesn't even try to use a cookie for this browser
> session.
>

If the cookie had come back in again, it would have turned off URL
rewriting again.

> My problem is that I want tomcat to always try and use a cookie even when
> using url encoding (unless it is already using a cookie). I realise it is a
> pain for those users that have setup prompts before accepting cookies, but
> in my case I would prefer an inconvenience to a small number of users and
> not the vast variety of users seeing the session id on all their url's.
>
> My own prefernce would be to overload the cookies parameter so that a value
> of "force" would cause this behaviour and leave the existing semantics for
> the already defined values.
>

Sounds like a good opportunity to make your own custom version of the
Tomcat code that does this ... and, oh by the way, lock yourself now and
forever more into using your patched version of Tomcat, because no other
container implements the approach you suggest.  Also, you're likely to
cause anyone doing a security audit of your application some serious
heartburn.



> Regards,
> Arshad
>

Craig

>
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
>
>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8662] - The jsp_precompile in tomcat 4 is not working

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8662

The jsp_precompile in tomcat 4 is not working

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 15:24 ---
It does work with the current builds, as it is used for jspInit with load-on-
startup.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8662] New: - The jsp_precompile in tomcat 4 is not working

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8662

The jsp_precompile in tomcat 4 is not working

   Summary: The jsp_precompile in tomcat 4 is not working
   Product: Tomcat 4
   Version: 4.0.3 Final
  Platform: PC
OS/Version: Other
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Can somebody what needs to be done to perform precompilation using 
the "jsp_precompile=true" in tomcat 4.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: PROPOSAL: mod_jk2 autoconfig

[costinm]

On Tue, 30 Apr 2002, Glenn Nielsen wrote:

> Both generating an apache config file on startup and my mod_jk change
> which auto mounts context's make the assumption that the Tomcat
> webapps directory is available to the web server.  This may not be
> the case for instances of Tomcat on a remote system.

See my previous mails. The only assumption is that you'll have at least 
one config file on the apache server ( but in a webapps/ directory instead
of a line in workers.properties ).


> It would be best if information about what contexts are configured,
> which of the configured contexts are available, and the request URI's
> to map to Tomcat was pushed from Tomcat to Apache via the network (channel ?).

I agree - and I was proposing to use a plain HTTP request to communicate
between Tomcat and apache, and shared memory to communicate between
apache processors. 


> There would still be a need for JkAutoAlias for those who want apache
> to server static content for a web app which is available via the fs.

Yes, and this whole proposal would still need your help :-)


Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: PROPOSAL: mod_jk2 autoconfig

[costinm]

On Tue, 30 Apr 2002, GOMEZ Henri wrote:

> >I think the current solution of generating configs on tomcat startup,
> >or having tomcat send it's config to apache is wrong. 
> 
> when tomcats and httpd servers run on differents machines you need
> to have a form of link between them, and that's why I proposed
> autoconf to be added to ajp13 (I don't tell ajp14 to avoid confusion).

I know. However ( see my previous answer on this topic ) we should
get apache to serve the static files - for performance, etc - and
that would require the webapp to be on the apache machine anyway.

And in the case you want one extra round-trip for each static 
page, it is still possible to install one small file for each
app. 

The 'ctl' or 'status' workers are supposed to do exactly what you 
say - get status updates 'over the wire' ( but using HTTP - it's not
performance critical and easier ) and eventually change and save 
the new conf ( save is implemented already in jk_config, but not 
used yet ).



> I agree we have a sort of chicken and eggs problems here since httpd
> servers need to know which tomcat are available to try to connect to
> them to get the configuration.

No chicken and egg here if the config is persistent.

Similar with how JMX works - you change/add configs at any time
during runtime, it saves the config, and next time you have what you
configured, without requiring the JMX manager to be up and re-do the
config.


> httpd server should have a thread (or fork in AP 1.3) to listen
> to incoming broadcast notification and determine if there is a
> new tomcat in (or out) and contact newcomer to get its config
> informations. In case of tomcat caming out, it should remove
> references to the old tomcat.

That would be the ctl handler, and the shm will allow each apache
instances to get the message. 

I know there are other, more sophisticated solutions - but I 
prefer ( at least for the short term ) a plain HTTP and plain
config file. Later we can implement 'broadcast' or other
advanced solutions ( like using an LDAP server ?) 

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: PROPOSAL: mod_jk2: Group/Instance

[costinm]

On Tue, 30 Apr 2002, Bernd Koecke wrote:

> some weeks ago I send a patch for mod_jk for an only routing lb_worker. A few 
> days later I sent the docu. Henry Gomez said, that it should be commited. But it 
> I think it isn't in the repository. But its the same  with me here, to mutch 
> work for to less time :).

I think it is in mod_jk, I remember seeing the commit. 

And I think I commited it in jk2 as well ( after some modifications ).

> I need sticky sessions but no loadbalancing in the module. If a request without 
> a session comes in, it should be routed to the _local_ tomcat.

Well, there is another use-case with the exact same behavior - Apache2 
with tomcat in JNI mode. All requests without session should be routed to 
the _jni_ channel ( i.e. in-process, minimal overhead ).

It's exacly the same - so be sure I do my best to handle this case :-)

Apache2 acts like a 'natural' load-balancer/fail-over, with the parent
process monitoring for crashes and it starts/stop childs based on 
load.


> I think this could be possible with the associated instance of a channel (item 
> 7). Then I have to configure all four nodes for the same group. Because all 
> nodes will serve the same webapps and associate the channel with this group. But 
> for this I need a non balancing group. I don't see if the default behavior of a 
> group is balancing and if this can be switched off. Is this right or do I miss 
> something?

The default is balancing, but you can tune this using weithgs ( and I 
think we use your code for making one instance 'top priority').

Please check the code, take a look and send additional comments/patches.

It's not yet completely done, of course.


Thanks,
Costin 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: AW: PROPOSAL: mod_jk2 autoconfig

[costinm]

On Tue, 30 Apr 2002, Hans Schmid wrote:

> I can not see how this works if you have Apache and Tomcat on different
> machines.
> This way we do not have a webapp/ directory on that Apache server.

It works fine. 

There are 2 cases:
1. You want Apache to serve static pages. That's the 'normal' case, and 
it automatically require that you _have_ the webapp (at lest the static 
pages, you can remove the clasesses, lib, etc ) on the apache server.

2. You don't want apache to serve static pages for the app. In this case 
you'll just put a small file in the webapp/ ( myApp.jk2 or something 
similar - see how 3.3 apps-myApp.xml or 4.1 webapps/myApp.xml works ),
with the single mapping that is required to forward all requests.

Even in the second case, I think it is easier to 'deploy' one conf file 
per webapp in a clear format than editing workers.properties. 

> Did I misunderstand the intent of this configuration? Is it a 'best guess'
> for simple setups?
> Probably in our scenario we have to configure it manually anyways.

Manual configuration will work, of course. In tomcat you can still edit 
server.xml. It's just that I would strongly discourage that for 'normal'
use.

> > Some 'special' files ( like in 4.1 and the 3.3 apps- files ) will
> > also be read and used to load webapps that sit in different directories.
> 
> same here we are on different machines.

Again, all you need is to install 1 file on the server machine for each 
webapp ( without static files ). 

I personally believe that is a very bad choice to not let apache serve
the static files, but it'll work.

> Just make sure, everything in the config can be overwritten and configures
> manually
> if possible in a single file (as workers.properties right now)

Either workers2.properties, or one file in the webapps ( named 
after the application, with .jk2 extension ). 

The file can be used if you have the docRoot in a different place in
the apache server.


Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

re: Howto autorun an application when tomcat server startup?

[Michael E. Locasto]

Hi,

I am not sure how you would go about doing this in Tomcat 4, but in
3.2.x,
in the $TOMCAT_HOME/webapps/yourwebapp/WEB-INF/web.xml file, you could
write a special XML tag and give the fully qualified classname of your
Java class (e.g. com.yourcompany.MyApplication) in those tags. When
Tomcat
starts, it will read all the web.xml files, and finding this tag
wrapping
your class, it will load that class. I've used this to make a static
JDBC
Connection Pool available to all web applications running in Tomcat.

you should probably make your class (MyApplication.java) extend Servlet.
Since Servlet has an init() method that will be called once, your
application
will be started by Tomcat, so you don't have to start it manually. Do
your work in init() rather than doGet() or doPost(), so people just
don't call
your servlet and make it do work all over again.

see $TOMCAT_HOME/webapps/text/WEB-INF/web.xml for more details
see $TOMCAT_HOME/conf/web.xml for more details

make sure your class (MyApplication.class) is in Tomcat's classpath

use this tag: 



myapplication


com.mycompany.MyApplication


-2147483646



I'm not sure what the numbers mean :), but it has seemed to work for me.

I'm not sure this procedure is still valid in Tomcat 4 or if I've gotten
things mixed up in the explanation above, but it should be a start for
you.

regards,
Michael Locasto





--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: mod_webapp.so socketpool changes..

[jean-frederic clere]

[EMAIL PROTECTED] wrote:
 > Hi,
 >
 > I'm a bit confused about the problem with the use of the APR atomic types.
 > Is the problem that it is not supported on all platforms?

No it is not yet supported on all platforms.

 >  If this is the
 > case then isn't this a problem with the apr code?  Even if a given OS
 > doesn't specifically offer atomic types then (as menioned earlier) a simple
 > mutex and int in a struct offers the same functionality.]

Yep, there is an apr_atomic.c file that could be used as generic atomic code.

 >
 > As far as I can see, all this wrapping should be part of the apr, shouldn't
 > it?  I think puting in #ifdef APR_USE_ATOMICS is a bit of band-aid solution;
 > Whether or not atomics are OS supported the variables in question should
 > really be only operated on atomically (in a multi-threaded environment) or
 > else the code is not thread-safe.

The status of atomic is not 100% clear in APR.
Someone from RedHat tells it will not work in user space (at least on Linux)(see 
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=63643).
For mod_webapp probably the best might be to use mutex instead of atomic.

 >
 > Also, I don't know if this has got anything to do with the  compilation
 > problems found but when I first put in the atomics I found that the
 > implementation in the (fairly recent) version of the apr I had was broken
 > (on NT) and caused compilation to fail.  Getting the latest version fixed
 > this problem.
 >
 > BTW Pier, sorry for not responding earlier - I managed to get the mod_webapp
 > module compiling for Apache 2 after tweaking the 1.3 makefile to get a 2.0
 > makefile for NT.  I used the apr directly from the Apache 2.0 distribution.
 > At the moment I am using Apache 2.0 on an NT intranet server with the
 > mod_webapp at it seems to behave identically to the 1.3 version.
 >
 > PS. If you want me to make any changes modifications (either changing the
 > #ifdef or anything else) to the warp connector just let me know

I committed your changes. For the moment I think we should wait to see what 
happends in APR...

 >
 > PPS. I noticed a comment about mod_webapp being deprecated.  Is this the
 > case?
 >

No. It is just commented out in the server.xml that is delivered with the TC 
binaries.

 >
 > Simon.
 >
 > [EMAIL PROTECTED] wrote:
 >
 >
 >> Pier Fumagalli wrote:
 >>
 >>> "Cavan Morris" <[EMAIL PROTECTED]> wrote:
 >>>
 >>>
 >>>
  Attached is an ASCII file with my build process.  It may be important
  to not that I'm using the APR libraries from the
  webapp-module-1.0.2-tc402 and apxs
 >>>
  from apache 2.0.32 not 2.0.35.
 >>>
 >>>
 >>> You _need_ to use the APR libraries shipped with your Apache 2.0
 >>> version, and the same APXS, anyway it's bloated on my system as well. I
 >>> have some spare time on my hands tonight, and tomorrow... I'll try to
 >>> revamp the autoconf stuff and make it build again...
 >>>
 >>>  I might break something in Win32 builds. Can someone with MSVC
 >>> give it a go once they see my commits, please? 
 >>>
  Question: when you say "Yes, that's right... " do you mean yes that's
  right, the socketpool work may solve bug 8433 or yes that's right, it
  doesn't compile?
 >>>
 >> The #if APR_HAS_THREADS is wrong that should have been #if APR_HAS_ATOMIC.
 >> But APR_HAS_ATOMIC is not existing and it is not possible to force APR to
 >> use a generic C code for atomics (apr_force_atomic_generic cannot be set
 >> to one via some configure options).
 >>
 >> Therefore when apr_atomic_t is not defined mod_webapp compilation failed
 >> miserably.
 >>
 >> I will try to change the #if APR_HAS_THREADS into #ifdef USE_ATOMICS like
 >> in the mod_mem_cache.c of httpd-2.0. (As a temporary fix).
 >>
 >>
 >>>
 >>> Both... Yeah, the socketpool solves that problem as well (at least it should,
 >>> what's your worker configuration in Apache 2.0? - output of httpd -l please
 >>> :) and yes, it doesn't compile...
 >>>
 >>> On APR they're talking about removing atomics, since those bits actually
 >>> depend (especially on sun hardware) on some opcodes present only on V9
 >>> architectures (JF might explain it better than me, the only 2 RISCs I've
 >>> coded for are PPCs and MIPSes), thus making binaries unportable from one
 >>> architecture to another...
 >>
 >> The atomic for SPARC is using cas that is an 8+ opcode. This causes
 >> "problems" on SPARC machines with "old" processors.
 >>
 >> There is a C code for machines that does not have a as atomic support.
 >>
 >>
 >>> Therefore my thought is to rely on inter-process mutex locking, instead
 >>> of atomics)...
 >>>
 >>>
 >>>
  Thanks for your time.
 >>>
 >>>
 >>> I feel lucky to have some spare time on my hands :) :) :)
 >>>
 >>> Pier
 >>>
 >>>
 >>>
  -Cavan Morris
 
  - Original Message - From: "Pier Fumagalli"
  <[EMAIL PROTECTED]> To: "Tomcat Developers List"
  <[EMAIL PROTECTED]> Sent: Saturday, April 27, 2002 8:58 AM
  Subject:

RE: Idea for dtomcat4 script/conf in webapp.rpm

[GOMEZ Henri]

>>BTW, as rpm packager I'm trying to works closely with projects to
>>have such add-ons included directly in original tarball which
>>help developpers fixes problems of rpm users.
>>
>I'm all for that. Do you know who is currently managing the 
>/usr/bin/dtomcat file in the current tarball? Maybe they can get in on 
>the conversation.

dtomcat is just the rpm renaming of original catalina.sh...

I think that patch could be usefull, you should get the latest
tomcat 4.0.4 from cvs, and apply the same patch to catalina.sh.

#   CATALINA_LOG(Optional) Provides alternate output locations for StandardOut 
#   and StandardErr

...
...

if [ -z "$CATALINA_BASE" ] ; then
  CATALINA_BASE="$CATALINA_HOME"
fi

if [ -z "$CATALINA_TMPDIR" ] ; then
  # Define the java.io.tmpdir to use for Catalina
  CATALINA_TMPDIR="$CATALINA_BASE"/temp
fi

if [ -z "$CATALINA_LOG" ] ; then
  # Set it to a default
  CATALINA_LOG="$CATALINA_BASE"/logs/catalina.out
fi

# - Execute The Requested Command -

echo "Using CATALINA_BASE:   $CATALINA_BASE"
echo "Using CATALINA_HOME:   $CATALINA_HOME"
echo "Using CATALINA_TMPDIR: $CATALINA_TMPDIR"
echo "Using CATALINA_LOG:$CATALINA_LOG"
echo "Using JAVA_HOME:   $JAVA_HOME"

...
...

elif [ "$1" = "start" ] ; then

  shift
  touch "$CATALINA_LOG"
  if [ "$1" = "-security" ] ; then
echo "Using Security Manager"
shift
"$_RUNJAVA" $JAVA_OPTS $CATALINA_OPTS \
  -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \
  -Djava.security.manager \
  -Djava.security.policy="$CATALINA_BASE"/conf/catalina.policy \
  -Dcatalina.base="$CATALINA_BASE" \
  -Dcatalina.home="$CATALINA_HOME" \
  -Djava.io.tmpdir="$CATALINA_TMPDIR" \
  org.apache.catalina.startup.Bootstrap "$@" start \
  >> "$CATALINA_LOG" 2>&1 &
  else
"$_RUNJAVA" $JAVA_OPTS $CATALINA_OPTS \
  -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \
  -Dcatalina.base="$CATALINA_BASE" \
  -Dcatalina.home="$CATALINA_HOME" \
  -Djava.io.tmpdir="$CATALINA_TMPDIR" \
  org.apache.catalina.startup.Bootstrap "$@" start \
  >> "$CATALINA_LOG" 2>&1 &
  fi

a big +1

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PATCH] Re: [PROPOSAL] Modification of the code generated by Jasper2

[Remy Maucherat]

> On Mon, 29 Apr 2002, Remy Maucherat wrote:
>
> > This looks like a good idea to me (Kin-Man is not there this week, so
it's
> > not an expert opinion). I would see that kind of change going into
Jasper 2,
> > though. Do you think you can prepare a patch against that version ?
> >
> > Remy
>
> Thanks!
>
> We've done some benchmarks with JMeter, even though the case we tested is
pathologic,
> the JSP contained 100 tags!  The results were impressive.  The Jasper
version included
> with the "pre-beta" 4.1 tomcat averaged 20 seconds/hit, with the patch,
the CVS
> version of jasper2 average 0.8 second/hit.  If there is less try/finally
nesting
> in the java code of the page, the difference is less impressive of course.
>
> The test setup, the test page and the detail of the results can be found:
>
> http://www3.sympatico.ca/benoitde/
>
> NOTE my "sunday patch" contained one bug, this one has been more tested.

I've applied the patch. Watchdog is fine, so I committed it.

The admin webapp appeared slow before the patch (esp when using a context
page), and that was with an Athlon 1700 as the server with one user (me).
I'm not happy in general when a request uses 100% of the CPU for 1 full
second ;-) I couldn't figure out why it was so slow, and the other runtime
optimizations didn't help at all. It turns out it was caused by this JVM bug
... With the patch, it's become quite fast. Very impressive, and since IMO
it is quite representative of a Struts based application which would have
complex pages, it's really awesome.

I suppose the fast JSP compilers (Resin, Orion) use similar tricks in the
code generation.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PATCH] possible speed enhancement to JspServlet.java

[Remy Maucherat]

> The numbers I got were for a fairly specific application. The page request
I was
> making did includes of 10 jsp's in total (which would account for the
difference
> in my results and yours I think).
> I really like the idea of having a server vs development setting. I'll
take a
> look at that this morning. Might it be a good idea to have a manual way to
force
> a JSP reload in a production environment? I see reading your comment that
you
> can reload the JSP by reloading the web application, but I'm not sure the
> container I'm using has that option available in a straight forward
manner.
> Something simple like a parameter in the URL like "jasper_jsp_reload=true"
would
> make it relatively easy to modify a production system without taking it
off-line
>   even briefly.

That kind of setting could be used for a DOS attack (making the server
recompile pages all the time). It should rather be something like
check_modified=true. Actually, I'll have to check what the precompile
attribte does. It may already be doing that; otherwise, I'll probably add
the other.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.1.0] Anyone testing it ?

[Remy Maucherat]

> I have 4.1 built from CVS Sunday morning in production
> for a system who's applications are low volume.
>
> But it doesn't use either Coyote or Jasper 2.

Ok, how about trying these also ? At least the HTTP/1.1 connector should be
solid.
BTW, those are the three points I mentioned that I think should recieve the
most testing ;-)

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PATCH] possible speed enhancement to JspServlet.java

[Duncan McLean]

The numbers I got were for a fairly specific application. The page request I was 
making did includes of 10 jsp's in total (which would account for the difference 
in my results and yours I think).
I really like the idea of having a server vs development setting. I'll take a 
look at that this morning. Might it be a good idea to have a manual way to force 
a JSP reload in a production environment? I see reading your comment that you 
can reload the JSP by reloading the web application, but I'm not sure the 
container I'm using has that option available in a straight forward manner. 
Something simple like a parameter in the URL like "jasper_jsp_reload=true" would 
make it relatively easy to modify a production system without taking it off-line 
  even briefly.

Remy Maucherat wrote:

>>Thanks for the comments Kin-Man. Given those comments and a look at the
>>
> jasper2
> 
>>code I have come up with the patch below. After profiling jasper2 I saw
>>
> that
> 
>>there was indeed a speed improvement over Jasper. However the excessive
>>
> creation
> 
>>of File objects and getting files from URL's was still a problem.
>>I did as you suggested and used the JspServletWrapper object to hold all
>>
> of the
> 
>>required data. As well I set up this version to fall back to reading JSP's
>>
> from
> 
>>a URL if reading the File object doesn't work.
>>I found in my testing that the jasper engine used ~15% of the request time
>>
> in
> 
>>loadJSP, jasper2 used ~12%, and my change uses ~1%. The only thing my code
>>
> does
> 
>>not do is force a reload of the .class file if it is deleted. My code only
>>causes a recompile if the jsp changes. I can look into modifying it to
>>
> handle
> 
>>this situation as well if required. I look forward to your feedback.
>>
> 
> A much simpler solution would be to allow disabling reloading altogether for
> production systems. I've committed a patch which does that.
> 
> That way, loadJSP can use 0% and everything stays very simple.
> 
> What do you think ?
> 
> Remy
> 
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
> 
> 


-- 
Duncan McLean
Hummingbird Ltd.
613-548-4355 x1539
http://www.hummingbird.com


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Idea for dtomcat4 script/conf in webapp.rpm

[Mark R. Diggory]

GOMEZ Henri wrote:

>>Yes, I mean in the Tomcat4 RPM, not the mod_webapp rpm. I did 
>>this with 
>>my tomcat4.conf file and dtomcat4 and it works for the "start" option. 
>>I'm not sure what one would have to do with the "run" or 
>>"embed" options 
>>of dtomcat4.
>>
>
>It's something which should be even added to tomcat4 original script.
>
>I'm +1 with it.
>
>BTW, as rpm packager I'm trying to works closely with projects to
>have such add-ons included directly in original tarball which
>help developpers fixes problems of rpm users.
>
I'm all for that. Do you know who is currently managing the 
/usr/bin/dtomcat file in the current tarball? Maybe they can get in on 
the conversation.

>
>That's why we works today so closely with ant developpers to
>merge the ant original script and the one we're using in rpms
>(jakarta rpms or jpackage project rpms)
>




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServlet.java

[glenn]

glenn   02/04/30 06:28:24

  Modified:jasper2/src/share/org/apache/jasper/servlet JspServlet.java
  Log:
  Minor refactoring.  Remove commented out and unused code.
  Move obtaining the classpath from loadIfNecessary to init(),
  minor performance improvement.
  Factor out the loadIfNecessary method, it only had a few lines
  of code left in it.
  
  Revision  ChangesPath
  1.8   +16 -58
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java
  
  Index: JspServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- JspServlet.java   29 Apr 2002 23:03:06 -  1.7
  +++ JspServlet.java   30 Apr 2002 13:28:24 -  1.8
  @@ -167,38 +167,8 @@
throw new JasperException(ex);
}
theServlet.init(JspServlet.this.config);
  -/*   Shouldn't be needed after switching to URLClassLoader
  - if (theServlet instanceof HttpJspBase)  {
  -HttpJspBase h = (HttpJspBase) theServlet;
  -h.setClassLoader(JspServlet.this.parentClassLoader);
  - }
  -*/
}
  - 
  - private void loadIfNecessary(HttpServletRequest req, HttpServletResponse res) 
  -throws JasperException, ServletException, FileNotFoundException 
  -{
  -// First try context attribute; if that fails then use the 
  -// classpath init parameter. 
  -
  -// Should I try to concatenate them if both are non-null?
  -
  -String cp = (String) context.getAttribute(Constants.SERVLET_CLASSPATH);
  -
  -String accordingto;
  -
  -if (cp == null || cp.equals("")) {
  -accordingto = "according to the init parameter";
  -cp = options.getClassPath();
  -} else 
  -accordingto = "according to the Servlet Engine";
  -
  -if (loadJSP(this, jspUri, cp, isErrorPage, req, res) 
  -|| theServlet == null) {
  -load();
  -}
  - }
  - 
  +
public void service(HttpServletRequest request, 
HttpServletResponse response,
boolean precompile)
  @@ -213,7 +183,11 @@
Constants.getString("jsp.error.unavailable"));
   }
   
  -loadIfNecessary(request, response);
  +if (loadJSP(this, jspUri, classpath,
  +isErrorPage, request, response)
  +|| theServlet == null) {
  +load();
  +}
   
// If a page is to only to be precompiled return.
if (precompile)
  @@ -286,9 +260,9 @@
   protected URLClassLoader parentClassLoader;
   protected ServletEngine engine;
   protected String serverInfo;
  -private PermissionCollection permissionCollection = null;
  -private CodeSource codeSource = null;
  -
  +private PermissionCollection permissionCollection;
  +private CodeSource codeSource;
  +private String classpath;
   static boolean firstTime = true;
   
   public void init(ServletConfig config)
  @@ -310,6 +284,13 @@
   
options = new EmbededServletOptions(config, context);
   
  +// Get the classpath to use for compiling
  +classpath = (String) context.getAttribute(Constants.SERVLET_CLASSPATH);
  +
  +if (classpath == null || classpath.equals("")) {
  +classpath = options.getClassPath();
  +}
  +
// Get the parent class loader
parentClassLoader =
(URLClassLoader) Thread.currentThread().getContextClassLoader();
  @@ -642,29 +623,6 @@
   }
   
return outDated;
  -}
  -
  -
  -/**
  - * Determines whether the current JSP class is older than the JSP file
  - * from whence it came
  - * KMC: This is currently no used
  - */
  -public boolean isOutDated(File jsp, JspCompilationContext ctxt,
  -   Mangler mangler ) {
  -File jspReal = null;
  - boolean outDated;
  - 
  -jspReal = new File(ctxt.getRealPath(jsp.getPath()));
  -
  -File classFile = new File(mangler.getClassFileName());
  -if (classFile.exists()) {
  -outDated = classFile.lastModified() < jspReal.lastModified();
  -} else {
  -outDated = true;
  -}
  -
  -return outDated;
   }
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: Idea for dtomcat4 script/conf in webapp.rpm

[GOMEZ Henri]

>Yes, I mean in the Tomcat4 RPM, not the mod_webapp rpm. I did 
>this with 
>my tomcat4.conf file and dtomcat4 and it works for the "start" option. 
>I'm not sure what one would have to do with the "run" or 
>"embed" options 
>of dtomcat4.

It's something which should be even added to tomcat4 original script.

I'm +1 with it.

BTW, as rpm packager I'm trying to works closely with projects to
have such add-ons included directly in original tarball which
help developpers fixes problems of rpm users.

That's why we works today so closely with ant developpers to
merge the ant original script and the one we're using in rpms
(jakarta rpms or jpackage project rpms)

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Idea for dtomcat4 script/conf in webapp.rpm

[Mark R. Diggory]

Opse, sorry.

Yes, I mean in the Tomcat4 RPM, not the mod_webapp rpm. I did this with 
my tomcat4.conf file and dtomcat4 and it works for the "start" option. 
I'm not sure what one would have to do with the "run" or "embed" options 
of dtomcat4.

-Mark

GOMEZ Henri wrote:

>>What do you think of adding a conf variable that allow one to set the 
>>location of catalina.out thats independent of $CATALINA_BASE? 
>>Something 
>>like $CATALINA_LOGDIR?
>>
>
>Do you means specific to rpm ?
>
>--
>To unsubscribe, e-mail:   
>For additional commands, e-mail: 
>



# tomcat /etc/rc.d script example configuration file
# Use with version 1.07 of the scripts or later

# Where your java installation lives
JAVA_HOME=/usr/java/jdk
# JAVA_HOME="/opt/IBMJava2-13"

# You can pass some parameters to java
# here if you wish to
# JAVACMD="$JAVA_HOME/bin/java -Xms128m -Xmx128m"

# Where your tomcat installation lives
# That change from previous RPM where TOMCAT_HOME 
# used to be /var/tomcat.
# Now /var/tomcat will be the base for webapps only
CATALINA_HOME="/var/tomcat4"
JASPER_HOME="/var/tomcat4"
CATALINA_TMPDIR="/tmp"

# What user should run tomcat
TOMCAT_USER="tomcat4"

# You can change your tomcat locale here
#LANG=en_US

# If you wish to further customize your tomcat environment,
# put your own definitions here
# (i.e. LD_LIBRARY_PATH for some jdbc drivers)
# Just do not forget to export them :)
export CATALINA_OPTS="-Xms128m -Xmx128m"
ulimit -s unlimited

export CATALINA_LOG=/var/log/tomcat/catalina.out


#!/bin/sh
# -
# Start/Stop Script for the CATALINA Server
#
# Environment Variable Prequisites
#
#   CATALINA_HOME   May point at your Catalina "build" directory.
#
#   CATALINA_BASE   (Optional) Base directory for resolving dynamic portions
#   of a Catalina installation.  If not present, resolves to
#   the same directory that CATALINA_HOME points to.
#
#   CATALINA_OPTS   (Optional) Java runtime options used when the "start",
#   "stop", or "run" command is executed.
#
#   CATALINA_TMPDIR (Optional) Directory path location of temporary directory
#   the JVM should use (java.io.tmpdir).  Defaults to
#   $CATALINA_BASE/temp.
#
#   CATALINA_LOG(Optional) Provides alternate output locations for StandardOut 
#   and StandardErr
#
#   JAVA_HOME   Must point at your Java Development Kit installation.
#
#   JAVA_OPTS   (Optional) Java runtime options used when the "start",
#   "stop", or "run" command is executed.
#
#   JPDA_ADDRESS(Optional) Java runtime options used when the "jpda start"
#   command is executed. The default is 8000.
#
#   JSSE_HOME   (Optional) May point at your Java Secure Sockets Extension
#   (JSSE) installation, whose JAR files will be added to the
#   system class path used to start Tomcat.
#
# $Id: catalina.sh,v 1.20.2.1 2002/01/30 18:10:39 patrickl Exp $
# -

TOMCAT_CFG="/etc/tomcat4/conf/tomcat4.conf"

[ -r "$TOMCAT_CFG" ] && . "${TOMCAT_CFG}"

# Set standard commands for invoking Java.
_RUNJAVA="$JAVA_HOME"/bin/java
_RUNJDB="$JAVA_HOME"/bin/jdb

### Set up defaults if they were omitted in TOMCAT_CFG

###  JVM lookup

if [ -z "$JAVA_HOME" ]; then
# Search for java in PATH
JAVA=`which java`
if [ -z "$JAVA" ] ; then
JAVA_BINDIR=`dirname ${JAVA}`
JAVA_HOME="${JAVA_BINDIR}/.."
fi 
# Default clean JAVA_HOME
[ -z "$JAVA_HOME"  -a -d "/usr/lib/java" ] &&  JAVA_HOME="/usr/lib/java"
# Default IBM JAVA_HOME
[ -z "$JAVA_HOME"  -a -d "/opt/IBMJava2-13" ] &&  JAVA_HOME="/opt/IBMJava2-13"
# Another solution 
[ -z "$JAVA_HOME"  -a -d "/usr/java/jdk" ] &&  JAVA_HOME="/usr/java/jdk"
# madeinlinux JAVA_HOME
[ -z "$JAVA_HOME" -a -d "/usr/local/jdk1.2.2" ] && JAVA_HOME="/usr/local/jdk1.2.2"
# Kondara JAVA_HOME
[ -z "$JAVA_HOME"  -a -d "/usr/lib/java/jdk1.2.2" ] && 
JAVA_HOME="/usr/lib/java/jdk1.2.2"
# Other commonly found JAVA_HOMEs
[ -z "$JAVA_HOME"  -a -d "/usr/jdk1.2" ] && JAVA_HOME="/usr/jdk1.2"
# Default Caldera JAVA_HOME
[ -z "$JAVA_HOME"  -a -d "/opt/java-1.3" ] && JAVA_HOME="/opt/java-1.3"
# Add other locations here
if [ -z "$JAVA_HOME" ]; then
echo "No JAVA_HOME specified in ${TOMCAT_CFG} and no java found, exiting..."
exit 1
else 
echo "Found JAVA_HOME: ${JAVA_HOME}"
echo "Please complete your ${TOMCAT_CFG} so we won't have to look for it next time"
fi
fi  

# Set standard CLASSPATH
CLASSPATH="$JAVA_HOME"/lib/tools.jar

# Add on extra jar files to CLASSPATH
if [ -n "$JSSE_HOME" ]; then
  
CLASSPATH="$CLASSPATH":"$JSSE_HOME"/lib/jcert.jar:"$JSSE_HOME"/lib/jnet.jar:"$JSSE_HOME"/lib/jsse.jar
fi
CLASSPATH="$CLASSPATH":"$CATALI

RE: [4.1.0] Anyone testing it ?

[Dobridge, Thomas A]

Where does bug #5647 stand?  I'd be happy to test on my IIS setup if someone
would point me to the right isapi dll to use.

regards,

tomd

> -Original Message-
> From: Remy Maucherat [SMTP:[EMAIL PROTECTED]]
> Sent: Tuesday, April 30, 2002 5:50 AM
> To:   Tomcat Developers List
> Subject:  [4.1.0] Anyone testing it ?
> 
> Is anyone testing 4.1.0 ?
> The URL as a reminder:
> http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.0/
> 
> Obviously, I expect people voting to rate the build to have tried it ;-)
> 
> Of particular interest is testing:
> - AJP 1.3 support
> - To see if bug 5735 is fixed with the current Coyote connector
> - Jasper 2
> 
> Thanks,
> Remy
> 
> 
> --
> To unsubscribe, e-mail:
> 
> For additional commands, e-mail:
> 
> 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8645] - Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8645

Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 13:01 ---
To have a unified home directory no matter if I'm using the Linux development 
server or a Windows desktop. This helps us having centralised backups etc etc. 
autofs helps with this and centralised home directories is a Good Thing (TM). 
Hmmm are we off scope now?

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: mod_webapp.so socketpool changes..

[simonkeary]

Hi,

I'm a bit confused about the problem with the use of the APR atomic types.  Is the 
problem that it is not supported on all platforms?  If this is the case then isn't 
this a problem with the apr code?  Even if a given OS doesn't specifically offer 
atomic types then (as menioned earlier) a simple mutex and int in a struct offers the 
same functionality.

As far as I can see, all this wrapping should be part of the apr, shouldn't it?  I 
think puting in #ifdef APR_USE_ATOMICS is a bit of band-aid solution; Whether or not 
atomics are OS supported the variables in question should really be only operated on 
atomically (in a multi-threaded environment) or else the code is not thread-safe.

Also, I don't know if this has got anything to do with the  compilation problems found 
but when I first put in the atomics I found that the implementation in the (fairly 
recent) version of the apr I had was broken (on NT) and caused compilation to fail.  
Getting the latest version fixed this problem.

BTW Pier, sorry for not responding earlier - I managed to get the mod_webapp module 
compiling for Apache 2 after tweaking the 1.3 makefile to get a 2.0 makefile for NT.  
I used the apr directly from the Apache 2.0 distribution.  At the moment I am using 
Apache 2.0 on an NT intranet server with the mod_webapp at it seems to behave 
identically to the 1.3 version.

PS. If you want me to make any changes modifications (either changing the #ifdef or 
anything else) to the warp connector just let me know

PPS. I noticed a comment about mod_webapp being deprecated.  Is this the case?


Simon.

[EMAIL PROTECTED] wrote:

> 
> Pier Fumagalli wrote:
> > "Cavan Morris" <[EMAIL PROTECTED]> wrote:
> > 
> > 
> >>Attached is an ASCII file with my build process.  It may be important to not
> >>that I'm using the APR libraries from the webapp-module-1.0.2-tc402 and apxs
> >>from apache 2.0.32 not 2.0.35.
> > 
> > 
> > You _need_ to use the APR libraries shipped with your Apache 2.0 version,
> > and the same APXS, anyway it's bloated on my system as well. I have some
> > spare time on my hands tonight, and tomorrow... I'll try to revamp the
> > autoconf stuff and make it build again...
> > 
> > 
> >   I might break something in Win32 builds. Can someone with MSVC give it a
> >   go once they see my commits, please?
> > 
> > 
> >>Question:
> >>when you say "Yes, that's right... " do you mean yes that's right, the
> >>socketpool work may solve bug 8433 or yes that's right, it doesn't compile?
> 
> The #if APR_HAS_THREADS is wrong that should have been #if APR_HAS_ATOMIC.
> But APR_HAS_ATOMIC is not existing and it is not possible to force APR to use a 
> generic C code for atomics (apr_force_atomic_generic cannot be set to one via 
> some configure options).
> 
> Therefore when apr_atomic_t is not defined mod_webapp compilation failed miserably.
> 
> I will try to change the #if APR_HAS_THREADS into #ifdef USE_ATOMICS like in the 
> mod_mem_cache.c of httpd-2.0. (As a temporary fix).
> 
> > 
> > 
> > Both... Yeah, the socketpool solves that problem as well (at least it
> > should, what's your worker configuration in Apache 2.0? - output of httpd -l
> > please :) and yes, it doesn't compile...
> > 
> > On APR they're talking about removing atomics, since those bits actually
> > depend (especially on sun hardware) on some opcodes present only on V9
> > architectures (JF might explain it better than me, the only 2 RISCs I've
> > coded for are PPCs and MIPSes), thus making binaries unportable from one
> > architecture to another...
> 
> The atomic for SPARC is using cas that is an 8+ opcode. This causes "problems" 
> on SPARC machines with "old" processors.
> 
> There is a C code for machines that does not have a as atomic support.
> 
> > Therefore my thought is to rely on inter-process
> > mutex locking, instead of atomics)...
> > 
> > 
> >>Thanks for your time.
> > 
> > 
> > I feel lucky to have some spare time on my hands :) :) :)
> > 
> > Pier
> > 
> > 
> >>-Cavan Morris
> >>
> >>- Original Message -
> >>From: "Pier Fumagalli" <[EMAIL PROTECTED]>
> >>To: "Tomcat Developers List" <[EMAIL PROTECTED]>
> >>Sent: Saturday, April 27, 2002 8:58 AM
> >>Subject: Re: mod_webapp.so socketpool changes..
> >>
> >>
> >>
> >>>"Cavan Morris" <[EMAIL PROTECTED]> wrote:
> >>>
> >>>
> Hey Guys,
> I reported bug 8433 and am looking for a way to solve it.  I thought that
> the
> socketpool work you're doing might solve the problem but wasn't able to
> compile the latest from cvs.
> My question is do you think that what you're working on could fix the bug?
> This is a very severe problem on my system.  I have to restart both apache
> and
> tomcat if I get 2 concurrent requests.  If you've got any ideas on the java
> side I can look into it, but have no idea what to do with the C.
> >>>
> >>>Yes, that's right... Can you send out why it doesn't compile? That code uses
> >>>ATOMIC, but given that atomi

DO NOT REPLY [Bug 8645] - Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8645

Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 12:18 ---
Obviously not with Microsoft NFS ;-)

What do you need autofs in this scenario for?

Bojan

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8644] - Mysql-Connection (Servlet) Problem (Timeout ?)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8644

Mysql-Connection (Servlet) Problem (Timeout ?)

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8644] - Mysql-Connection (Servlet) Problem (Timeout ?)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8644

Mysql-Connection (Servlet) Problem (Timeout ?)

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 12:12 ---
I looked at your code. This is not a bug in Tomcat, it is a problem in
your servlet.  MySQL has a limit for how long it will keep an idle db
connection open, the default is 8 hours.  Your code never tries to reopen
the db connection if it gets closed from the db side.  You might consider
using a db connection pool instead of your own code for managing db connections.
For further assistance please use the tomcat-user list.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8645] - Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8645

Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 11:48 ---
I haven't seen any strong evidence that autofs and samba would play well 
together. NIS, autofs and NFS is a very well proven concept in comparison.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8645] - Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8645

Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 11:21 ---
Although I'd personally vote for solution 1 :-), have you tried running Samba
mount instead? Something like:

mount -t smbfs //winserv/martin /home/martin -o username= (blah, blah...)

You might have to fiddle with permissions a bit, but I think it can be done.

Bojan

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/qlog Logger.java

[GOMEZ Henri]

Ok, is there still a need to use commons-log ?

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 



>-Original Message-
>From: Ignacio J. Ortega [mailto:[EMAIL PROTECTED]]
>Sent: Tuesday, April 30, 2002 12:23 PM
>To: 'Tomcat Developers List'
>Subject: RE: cvs commit:
>jakarta-tomcat/src/share/org/apache/tomcat/util/qlog Logger.java
>
>
>Thanks!! :), Now we have the flexible logrotate of tc3.3, working..
>
>Saludos ,
>Ignacio J. Ortega
>
>--
>To unsubscribe, e-mail:   
>
>For additional commands, e-mail: 
>
>
>

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: PROPOSAL: mod_jk2 autoconfig

[GOMEZ Henri]

>I think the current solution of generating configs on tomcat startup,
>or having tomcat send it's config to apache is wrong. 

when tomcats and httpd servers run on differents machines you need
to have a form of link between them, and that's why I proposed
autoconf to be added to ajp13 (I don't tell ajp14 to avoid confusion).

I agree we have a sort of chicken and eggs problems here since httpd
servers need to know which tomcat are available to try to connect to
them to get the configuration.

Ideally we need a broadcast solution for such purpose.

httpd server should have a thread (or fork in AP 1.3) to listen
to incoming broadcast notification and determine if there is a
new tomcat in (or out) and contact newcomer to get its config
informations. In case of tomcat caming out, it should remove
references to the old tomcat.

- In java land there is a solution, javagroups 
 (http://sourceforge.net/projects/javagroups/)
  which sadly still use a LGPL license which prevent to have it include in ASF project.

  If ever javagroups decide to switch to a BSD license or better
  join jakarta, it will be really great and in that case we could
  use httpd + jni + javagroups to talk and configure the groups 
  of distants tomcats

- In native/java land, there is still spread (http://www.spread.org)
  which have a license compatible with ASF.


>Finally, the shmem system that is ( will be ) used for 
>autoconfiguration 
>of workers ( i.e. when a tomcat starts up it can add itself 
>automatically,
>without admin intervention ) can be used by the deploy/admin tool to 
>reconfigure uri mappings ( with the common mapper, the native mapper
>still requires a soft restart - but that can be automated as well ). 
>
>Implementation-wise - this is not difficult, and can be done pretty
>fast if Glenn and few other people step in. 
>
>I believe that's going to be very close to 'minimal' pain for the 
>regular user while preserving the ability to fine tune everything.
>
>NOTE: jk2 will use a different model for the lb, see next mail.

You're speaking of channel, I'd like the idea, since it's very
similar to the channel/group concept of javagroup/spread.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/qlog Logger.java

[Ignacio J. Ortega]

Thanks!! :), Now we have the flexible logrotate of tc3.3, working..

Saludos ,
Ignacio J. Ortega

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Problem with url session encoding - Tomcat 4.0.4 b2

[Arshad Mahmood]

Hi,

I am writing an e-commerce application using tomcat and have come across a
minor issue with url session encoding. The problem is that if a valid
session id is available on the url then tomcat does not use cookies.

Here is my scenario :-

1. I have tomcat configured to use cookies for session id's if possible.
2. An access to the index.html of my site redirects via url encoding to
home/index.html. This causes the session to be sent both via the url and a
cookie, from here on tomcat knows it can use cookies and doesn't bother
adding the session id to the url when I use encodeURL.

3. If I close the browser and open a new browser and use the url history box
then the url that appears is home/index.html with the added url encoding
(because I redirected from the original index.html).
4. Because this url has a valid session id, tomcat now defaults to using the
url endoing method and doesn't even try to use a cookie for this browser
session.

My problem is that I want tomcat to always try and use a cookie even when
using url encoding (unless it is already using a cookie). I realise it is a
pain for those users that have setup prompts before accepting cookies, but
in my case I would prefer an inconvenience to a small number of users and
not the vast variety of users seeing the session id on all their url's.

My own prefernce would be to overload the cookies parameter so that a value
of "force" would cause this behaviour and leave the existing semantics for
the already defined values.

Regards,
Arshad


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [4.1.0] Anyone testing it ?

[GOMEZ Henri]

Downloaded yesterday,

will try it on linux and rpm packaging ASAP

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 



>-Original Message-
>From: Remy Maucherat [mailto:[EMAIL PROTECTED]]
>Sent: Tuesday, April 30, 2002 11:50 AM
>To: Tomcat Developers List
>Subject: [4.1.0] Anyone testing it ?
>
>
>Is anyone testing 4.1.0 ?
>The URL as a reminder:
>http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.0/
>
>Obviously, I expect people voting to rate the build to have 
>tried it ;-)
>
>Of particular interest is testing:
>- AJP 1.3 support
>- To see if bug 5735 is fixed with the current Coyote connector
>- Jasper 2
>
>Thanks,
>Remy
>
>
>--
>To unsubscribe, e-mail:   
>
>For additional commands, e-mail: 
>
>
>

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[4.1.0] Anyone testing it ?

[Remy Maucherat]

Is anyone testing 4.1.0 ?
The URL as a reminder:
http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.0/

Obviously, I expect people voting to rate the build to have tried it ;-)

Of particular interest is testing:
- AJP 1.3 support
- To see if bug 5735 is fixed with the current Coyote connector
- Jasper 2

Thanks,
Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8645] New: - Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8645

Microsoft "Services for UNIX v2.0" nfs server has a corrupt last modification date

   Summary: Microsoft "Services for UNIX v2.0" nfs server has a
corrupt last modification date
   Product: Tomcat 3
   Version: 3.3.1 Final
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Webapps
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


This might or might not be Tomcat's problem, however I've found no 
documentation of this problem anywhere on the web, and Tomcat is severly 
affected. If Tomcat is behaving according to plan, then this bug report can be 
seen more as "for information purposes".

Microsoft's "Services for UNIX v2.0" http://www.microsoft.com/windows2000/sfu/ 
includes an NFS server amongst other things. This server has a big problem 
with last modification times of files. 

My setup is a Windows 2000 Server with Services for UNIX, sharing some folders 
using NFS to a Redhat Linux 7.2 box where I'm running tomcat on the NFS file 
system. 

It seems the NFS server sets the modification time twice for every update to 
the file. First when the NFS write is done to memory, and second when the 
change is flushed out to disk. I have verified that the second modification 
date change happens when I see a change in the NTFS file system. 

Consider the following shell excercise where we can see the modification date 
changing twice just using some normal shell tools:

$ pwd 
/home/martin

$ mount | grep /home/martin
winserv:/user_folders/martin on /home/martin type nfs (rw,hard,addr=10.8.0.2)

$ date ; echo "foo" >> bar ; ls --full-time bar
Tue Apr 30 09:42:21 BST 2002
-rw-rw-r--1 martin   dev 4 Tue Apr 30 09:42:21 2002 bar

$ date ; ls --full-time bar
Tue Apr 30 09:42:31 BST 2002
-rw-rw-r--1 martin   dev 4 Tue Apr 30 09:42:23 2002 bar


In words what we see is that the file gets a new modification time when I do 
the echo to the file. And roughly ten seconds later when I look at it again. 
The modification time has changed again (after that it stays as is). The 
second change is always around 2 seconds later.

Needless to say this has quite significant impacts on applications like 
Tomcat, where the modificaion time is used to determine reloads. The behaviour 
I'm seeing in Tomcat is along the lines of:

A) .jsp gets compiled to .java that gets compiled to .class
2002-04-30 09:03:12 - Ctx() : Compiling: /index.jsp to index_0

B) A dependency graph is built inside Tomcat using 
org.apache.tomcat.util.Dependecy and org.apache.tomcat.util.DependManager. The 
dependencies seems to be:
ROOT context -> .jsp
ROOT context -> .java 
ROOT context -> .class

C) At a later request the DependManager will validate the dependencies and 
finds the the .class file to have changed. (DependManager contains logging, 
but it is not possible to turn on without editing the class):
DependManager: Found expired file index_1.class
DependManager: ShouldReload5 E=true C=false

D) This triggers an invalidation of the whole dependency graph (my guess) that 
ultimatelly triggers the reload of the context:
2002-04-30 09:05:58 - ContextManager: Removing context 
martin.www.ioboxgroup.com.developer.taglab.com:/ROOT
2002-04-30 09:05:58 - Ctx() : Remove mapping
2002-04-30 09:05:58 - Ctx() : Remove mapping /index.jsp
2002-04-30 09:05:58 - ContextManager: Adding context 127.0.0.1:/ROOT

My webapps doesn't handle this reload very well, so this was a problem for me. 

Possible fixes:

1) Stop using crap Microsoft solutions.

2) Convince Microsoft to fix this problem (why does the phrase "move a 
mountain" spring to mind?)

3) Make the Dependency class tolerant for "minor changes" in the modification 
date. By testing I have concluded that the second update to the modification 
date seems to always be around 2 seconds after the first. The solution I've 
implemented locally allows for a 4 second change without doing a reload. This 
has of course the unwanted side effect that if I update say a JSP two times 
within 4 seconds, the server might not notice the second change. Arguably this 
is a fix for the symptoms and not the cause, and hence is probably nothing we 
would like to see in the Tomcat code base.

4) Should a change in the .class file really trigger a reload of the whole 
context? In the DependManager there is a concept of files being "local" or 
not "local". A change in a local is seemed to not be a reason to invalidate 
the whole Dependency manager. I am not sure I have all the facts about 
the "local" concept, but perhaps the .clas

DO NOT REPLY [Bug 8644] New: - Mysql-Connection (Servlet) Problem (Timeout ?)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8644

Mysql-Connection (Servlet) Problem (Timeout ?)

   Summary: Mysql-Connection (Servlet) Problem (Timeout ?)
   Product: Tomcat 3
   Version: 3.2.3 Final
  Platform: PC
   URL: http://www.ascom.ch
OS/Version: Linux
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Servlet
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have a Servlet that makes a Connection to a mysql-DB.

When I compile it (javac *.java) and restart Tomcat (rctomcat restart) it

works fine... The users are displayed from the DB and I could login.

But the next day (13 Hours later) it doesn't work.

It can't see the users displayed from the DB... See dont_work.jpg.



The following Links are the Screenshots !

http://tigarr.ch/ska/cesi/tomcat_bug/work_fine.jpg

http://tigarr.ch/ska/cesi/tomcat_bug/dont_work.jpg



My Java, Servlet - Code is here :

I've tried all the Combinations (//...)

http://tigarr.ch/ska/cesi/tomcat_bug/AFIdentification.java

http://tigarr.ch/ska/cesi/tomcat_bug/DBCon.java



But after I restarted Tomcat (rctomcat restart) the Servlet works fine,

and I could login... See work_fine.jpg



Need help, what is wrong here ???

Can anyone help me please ?



Thanks

Cesi

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [NITPICK] didn't see this one coming...

[jean-frederic clere]

Pier Fumagalli wrote:
> "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
> 
> 
>>On Mon, 29 Apr 2002, Remy Maucherat wrote:
>>
>>
However I do think we should somehow document better what's
happening - many people have the strange impression that
webapp is going to replace jk.
>>>
>>>I'd like to find a way to indicate that the two preferred connectors are:
>>>- Coyote HTTP/1.1
>>>- Coyote JK 2 (AJP with mod_jk, JNI)
>>
>>And to clearly indicate that for whatever OS Pier is using and Apache2,
>>users can also use mod_webapp.
> 
> 
> I can cover for OS/X and Solaris 8 (both X86 and SPARC). That's all I have
> access to ATM (my flatmate's Linux box is a happily hand-tuned llama slow
> Debian box, basically impossible to compile whatever on it)
> 
> J-F uses a couple of whacko ;) systems, and something else (???)

I have some Linux (Suse), access to FreeBSD, Solaris8, ReliantUnix (mips) and 
BS2000 (EBCDIC mainframe) ;-))

> 
> Henri is building RPMs for WebApp already, and since it's another dialect of
> a pseudo POSIX-compliant OS, things should work there as well, and it's
> pretty easy to provide fixes when he tries to build the thing.
> 
> I used to have an HP-UX box as well, but the power supply died last week,
> and the cost to replace that was much more than the value of the box itself,
> so it just ended up in the bin with my kitty litter last week... I know that
> Covalent has some HP-UX boxes, if they want to put them on-line, it might be
> good (since I was hosting HP-UX for the entire Apache community)
> 
> Apart from that, if someone wants to do some Windows porting, he's more than
> welcome to volunteer (as you are well-aware of, it's kinda impossible to run
> MSVC from remote, you _have_ to have a console. The only alternative would
> be someone providing a Wintel PC with a valid license of MSVC and an SSH
> server to do builds on, although it might get nasty when you think about
> doing all those NMAKE files)...

I have (at home) a win98 (For hacking USB devices).
I have made some tries there, with cygwin is it possible to run sshd and use a 
machine remotly. It is even possible to compile programs for native win32.
The problem starts when the native program stops and displays a message box (may 
be vnc can help (http://www.uk.research.att.com/vnc/) but I have not tried it 
yet) normaly a ps -W + kill -9 or custom shutdown.exe helps...

> 
> Pier
> 
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
> 
> 
> 




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: logrotate and tomcat 3.3/4.0/4.1

[Bojan Smojver]

Quoting GOMEZ Henri <[EMAIL PROTECTED]>:

> Whaou.
> 
> Didn't now about copytruncate option of logrotate.

It has some downsides too. But it's documented in the manual page, so everyone
should know what to expect.

> Under Linux there is truncate and ftruncate calls 
> but I wonder how it works regarding OS ?

Not sure what you mean here exactly, but here is the text from the manual page
that explains what happens:


copytruncate
  Truncate the original log file in place after  cre­-
  ating  a  copy,  instead of moving the old log file
  and optionally creating a new one, It can  be  used
  when some program can not be told to close its log­
  file and thus might continue writing (appending) to
  the  previous log file forever.  Note that there is
  a very small time slice between  copying  the  file
  and  truncating  it,  so some logging data might be
  lost.  When this option is used, the create  option
  will  have  no effect, as the old log file stays in
  place.


> I'll add this to all my tomcat rpm ASAP

Cool.

Bojan

--
To unsubscribe, e-mail:   
For additional commands, e-mail: