Change in vdsm[master]: ovs: acquire external ifaces

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: ovs: acquire external ifaces
..


Patch Set 25:

(2 comments)

https://gerrit.ovirt.org/#/c/60404/25/tests/network/ovs_switch_test.py
File tests/network/ovs_switch_test.py:

Line 28: @attr(type='unit')
Line 29: class ListAcquiredIfacesTests(VdsmTestCase):
Line 30: 
Line 31: @mock.patch('vdsm.network.ovs.info.OvsInfo')
Line 32: def test_add_network_with_nic(self, mock_ovs_info):
> Great, can we add a test for this?
Both is handled by ifacquire module.

I will add a test for a). b) is already tested in latest ifacquire_test.py
Line 33: mock_ovs_info.bridges = {}
Line 34: mock_ovs_info.bridges_by_sb = {}
Line 35: mock_ovs_info.northbounds_by_sb = {}
Line 36: 


PS25, Line 53: set()
> Ok, that makes sense for the slaves, but what about the bond itself?
For now we handle only acquiration (wow is it a word?) for nics, bonds are 
supposed to be created and handled only by us.


-- 
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: ovs_net2bridge fails when ovs service is down

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: ovs: ovs_net2bridge fails when ovs service is down
..


Patch Set 2:

So then we should drop it from netinfo too?

-- 
To view, visit https://gerrit.ovirt.org/61241
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f28234cf8913d964ee60b3f396f6b62cec03383
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Limit the number of workers in executor

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Limit the number of workers in executor
..


Patch Set 20: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/57754/20/tests/executorTests.py
File tests/executorTests.py:

Line 88
Line 89
Line 90
Line 91
Line 92
Old tests are very fragile, it would be nice to replace the sleeps with waiting 
for events. This is not related to this patch, but it adds nice infrastructure 
that these tests can use.


Line 269: self.wait = wait
Line 270: self.error = error
Line 271: self.event = event
Line 272: self.start_barrier = start_barrier
Line 273: self.started = threading.Event()
We are not using this event.

Lets remove it, and rename start_barrier to started?
Line 274: self.executed = threading.Event()
Line 275: 
Line 276: def __call__(self):
Line 277: self.started.set()


Line 280: if self.wait:
Line 281: time.sleep(self.wait)
Line 282: if self.event is not None:
Line 283: if not self.event.wait(10):
Line 284: return
Both wait and event have similar usage, making the task block for some time. 
Can we unify them and always pass an event instead of sleep time?
Line 285: self.executed.set()
Line 286: if self.error:
Line 287: raise self.error
Line 288: 


-- 
To view, visit https://gerrit.ovirt.org/57754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba56d91474c6b14a1cfe2db827b6fd61843a1db2
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: log: Use INFO log level as default

[automation]

gerrit-hooks has posted comments on this change.

Change subject: log: Use INFO log level as default
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/32504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I767dcd9bad7b9fbeebb438e9ef13cb0ec3f042ee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: log: Use INFO log level as default

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: log: Use INFO log level as default
..


Patch Set 2:

Rebase, update new logger added since the original patch.

-- 
To view, visit https://gerrit.ovirt.org/32504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I767dcd9bad7b9fbeebb438e9ef13cb0ec3f042ee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt net: Change graphics type from network to address

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt net: Change graphics type from network to address
..


Patch Set 1: Verified-1

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::#1195208::OK, correct target milestone ovirt-4.0.2
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/61262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id809e90f2340caffaf30a5749dd75ec39516c96c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt net: Change graphics type from network to address

[edwardh]

Hello Petr Horáček, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/61262

to review the following change.

Change subject: virt net: Change graphics type from network to address
..

virt net: Change graphics type from network to address

This patch changes the graphics listen type of VM/s from a libvirt
network name to an address for OVS based display networks.

OVS integration has avoided the use of libvirt network entities, for
simplicitly and as part of a general effort to eliminate VDSM networking
libvirt dependency.
With this patch, a VM graphics may be assign to an OVS based host network.

NOTE: This patch must be merged with the libvirt hook patch.
(id: Ie7d32f9605f9ca99d1e070621)

This reverts commit 9e3ff6d62bd42fad387e69c1a6bdab153cd3.

Change-Id: Id809e90f2340caffaf30a5749dd75ec39516c96c
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/59336
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Tested-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/61120
---
M vdsm/virt/vmdevices/graphics.py
1 file changed, 19 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/61262/1

diff --git a/vdsm/virt/vmdevices/graphics.py b/vdsm/virt/vmdevices/graphics.py
index 0bfa186..8066325 100644
--- a/vdsm/virt/vmdevices/graphics.py
+++ b/vdsm/virt/vmdevices/graphics.py
@@ -18,10 +18,9 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
-import logging
-
 import libvirt
 
+from vdsm import supervdsm
 from vdsm.network import api as net_api
 from vdsm import utils
 from vdsm.config import config
@@ -141,7 +140,17 @@
 graphics.appendChildWithArgs('channel', name=chan,
  mode='secure')
 
-if self.specParams.get('displayNetwork'):
+# For the listen type IP to be used, the display network must be OVS.
+# We assume that the cluster in which the host operates is OVS enabled
+# and all other hosts in the cluster have the migration hook installed.
+# The migration hook is responsible to convert ip to net and vice versa
+display_network = self.specParams.get('displayNetwork')
+display_ip = self.specParams.get('displayIp', '0')
+if (display_network and display_ip != '0' and
+supervdsm.getProxy().ovs_bridge(display_network)):
+graphics.appendChildWithArgs(
+'listen', type='address', address=display_ip)
+elif display_network:
 graphics.appendChildWithArgs(
 'listen', type='network',
 network=net_api.netname_o2l(
@@ -243,11 +252,16 @@
 def _getNetworkIp(network):
 try:
 nets = net_api.libvirt_networks()
-device = nets[network].get('iface', network)
+# On a legacy based network, the device is the iface specified in the
+# network report (supporting real bridgeless networks).
+# In case the report or the iface key is missing,
+# the device is defaulted to the network name (i.e. northbound port).
+device = (nets[network].get('iface', network)
+  if network in nets else network)
 ip, _, _, _ = net_api.ip_addrs_info(device)
 except (libvirt.libvirtError, KeyError, IndexError):
 ip = config.get('addresses', 'guests_gateway_ip')
+finally:
 if ip == '':
 ip = '0'
-logging.info('network %s: using %s', network, ip)
 return ip


-- 
To view, visit https://gerrit.ovirt.org/61262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id809e90f2340caffaf30a5749dd75ec39516c96c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/60533/4/README.logging
File README.logging:

Line 25: The basic syntax is:
Line 26: 
Line 27: # vdsClient [options] setLogLevel LEVEL [logger]
Line 28: 
Line 29: `LEVEL` is one of DEBUG, INFO, WARNING, ERROR, CRITICAL
Please do not document ERROR and CRITICAL, we don't want people to use these 
log levels, we cannot support system running with CRITICAL (there will be no 
logs) and seeing only errors is also quite unsupportable.

Or add a warning about using these levels.
Line 30: `logger` is any logger Vdsm uses. Please check the configuration file
Line 31: to learn about some predefined loggers.
Line 32: 
Line 33: If no logger is given, the root logger is used implicitely.


Line 46: vdsClient -s 0 setLogLevel WARNING virt
Line 47: 
Line 48: 3. same as #2, for storage (case is significant here)
Line 49: vdsClient -s 0 setLogLevel WARNING Storage
Line 50: vdsClient -s 0 setLogLevel WARNING storage
Unified in https://gerrit.ovirt.org/61261, please update when that patch is 
merged.
Line 51: 
Line 52: 4. silence JSONRPC logs:
Line 53: vdsClient -s 0 setLogLevel ERROR jsonrpc
Line 54: 


Line 49: vdsClient -s 0 setLogLevel WARNING Storage
Line 50: vdsClient -s 0 setLogLevel WARNING storage
Line 51: 
Line 52: 4. silence JSONRPC logs:
Line 53: vdsClient -s 0 setLogLevel ERROR jsonrpc
This is bad idea, please use WARNING.
Line 54: 
Line 55: 
Line 56: Notes
Line 57: -


-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Revert "virt net: Change graphics type from network to address"

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Revert "virt net: Change graphics type from network to address"
..


Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/61259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea42b9c0de25b2d1d08e06ef0deaae59b9e53717
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Unify stoage logger name

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Unify stoage logger name
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I653c41301393b5450de4ac6dee92b606a5f64838
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Unify stoage logger name

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: storage: Unify stoage logger name
..

storage: Unify stoage logger name

We had both "Storage" and "storage" loggers, but configuration was only
for "Storage". Unify all logger names and the configuration to
"storage", matching other loggers names.

We need more work to unify the sub loggers - I'm not touching them now
since I want to move to module level loggers or even subsystem level
loggers instead of class based loggers we have now.

Change-Id: I653c41301393b5450de4ac6dee92b606a5f64838
Signed-off-by: Nir Soffer 
---
M lib/vdsm/storage/clusterlock.py
M lib/vdsm/storage/fileUtils.py
M lib/vdsm/storage/hba.py
M lib/vdsm/storage/misc.py
M lib/vdsm/storage/persistent.py
M lib/vdsm/storage/volumemetadata.py
M vdsm/logger.conf.in
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/dispatcher.py
M vdsm/storage/fileSD.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/imageRepository/formatConverter.py
M vdsm/storage/imageSharing.py
M vdsm/storage/iscsi.py
M vdsm/storage/lvm.py
M vdsm/storage/monitor.py
M vdsm/storage/multipath.py
M vdsm/storage/outOfProcess.py
M vdsm/storage/resourceFactories.py
M vdsm/storage/resourceManager.py
M vdsm/storage/sd.py
M vdsm/storage/sdc.py
M vdsm/storage/sdm/volume_artifacts.py
M vdsm/storage/sp.py
M vdsm/storage/spbackends.py
M vdsm/storage/storageServer.py
M vdsm/storage/storage_mailbox.py
M vdsm/storage/task.py
M vdsm/storage/taskManager.py
M vdsm/storage/threadPool.py
M vdsm/storage/volume.py
33 files changed, 67 insertions(+), 67 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/61261/1

diff --git a/lib/vdsm/storage/clusterlock.py b/lib/vdsm/storage/clusterlock.py
index 5243a7c..9a2ecee 100644
--- a/lib/vdsm/storage/clusterlock.py
+++ b/lib/vdsm/storage/clusterlock.py
@@ -75,7 +75,7 @@
 
 
 class SafeLease(object):
-log = logging.getLogger("Storage.SafeLease")
+log = logging.getLogger("storage.Safelease")
 
 lockUtilPath = config.get('irs', 'lock_util_path')
 lockCmd = config.get('irs', 'lock_cmd')
@@ -176,7 +176,7 @@
self._sdUUID)
 
 
-initSANLockLog = logging.getLogger("Storage.initSANLock")
+initSANLockLog = logging.getLogger("storage.initSANLock")
 
 
 def initSANLock(sdUUID, idsPath, leasesPath):
@@ -202,7 +202,7 @@
 sanlock.HOST_DEAD: HOST_STATUS_DEAD,
 }
 
-log = logging.getLogger("Storage.SANLock")
+log = logging.getLogger("storage.SANLock")
 
 _sanlock_fd = None
 _sanlock_lock = threading.Lock()
@@ -353,7 +353,7 @@
 
 
 class LocalLock(object):
-log = logging.getLogger("Storage.LocalLock")
+log = logging.getLogger("storage.LocalLock")
 
 LVER = 0
 
diff --git a/lib/vdsm/storage/fileUtils.py b/lib/vdsm/storage/fileUtils.py
index fcd8829..938c641 100644
--- a/lib/vdsm/storage/fileUtils.py
+++ b/lib/vdsm/storage/fileUtils.py
@@ -43,7 +43,7 @@
 from vdsm import constants
 from vdsm.common.network import address
 
-log = logging.getLogger('Storage.fileUtils')
+log = logging.getLogger('storage.fileUtils')
 
 MIN_PORT = 1
 MAX_PORT = 65535
diff --git a/lib/vdsm/storage/hba.py b/lib/vdsm/storage/hba.py
index 5175a80..4a0a6cf 100644
--- a/lib/vdsm/storage/hba.py
+++ b/lib/vdsm/storage/hba.py
@@ -35,7 +35,7 @@
 from vdsm.common import zombiereaper
 from vdsm.storage import misc
 
-log = logging.getLogger("Storage.HBA")
+log = logging.getLogger("storage.HBA")
 
 ISCSI_INITIATOR_NAME = "/etc/iscsi/initiatorname.iscsi"
 INITIATOR_NAME = "InitiatorName"
diff --git a/lib/vdsm/storage/misc.py b/lib/vdsm/storage/misc.py
index 5c466a8..6682430 100644
--- a/lib/vdsm/storage/misc.py
+++ b/lib/vdsm/storage/misc.py
@@ -64,7 +64,7 @@
 MEGA = 1 << 20
 UNLIMITED_THREADS = -1
 
-log = logging.getLogger('Storage.Misc')
+log = logging.getLogger('storage.Misc')
 
 
 def namedtuple2dict(nt):
@@ -154,12 +154,12 @@
 return result
 
 
-execCmdLogger = enableLogSkip(logging.getLogger('Storage.Misc.excCmd'),
+execCmdLogger = enableLogSkip(logging.getLogger('storage.Misc.excCmd'),
   ignoreSourceFiles=[__file__],
-  logSkipName="Storage.Misc.excCmd")
+  logSkipName="storage.Misc.excCmd")
 
 
-execCmd = partial(logskip("Storage.Misc.excCmd")(commands.execCmd),
+execCmd = partial(logskip("storage.Misc.excCmd")(commands.execCmd),
   execCmdLogger=execCmdLogger)
 
 
@@ -528,7 +528,7 @@
 Supporting parameters or exception passing to all functions would
 make the code much more complex for no reason.
 """
-_log = logging.getLogger("Storage.SamplingMethod")
+_log = logging.getLogger("storage.SamplingMethod")
 
 def __init__(self, func):
 self.__func = func
@@ -580,7 +580,7 @@
 
 class Event(object):
 def __init__(self, name, sync=False):
-self._log = 

Change in vdsm[ovirt-4.0]: Revert "virt net: Change graphics type from network to address"

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Revert "virt net: Change graphics type from network to address"
..


Patch Set 1: Verified-1

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::#1195208::OK, correct target milestone ovirt-4.0.2
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/61259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea42b9c0de25b2d1d08e06ef0deaae59b9e53717
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Revert "virt net: Change graphics type from network to address"

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: Revert "virt net: Change graphics type from network to address"
..

Revert "virt net: Change graphics type from network to address"

This reverts commit 13603192ab2daa0eb39172f0682a864cd64edf88.

The original commit should have been merged together with all
ovs_backport topic patches.

Change-Id: Iea42b9c0de25b2d1d08e06ef0deaae59b9e53717
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Edward Haas 
---
M vdsm/virt/vmdevices/graphics.py
1 file changed, 5 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/61259/1

diff --git a/vdsm/virt/vmdevices/graphics.py b/vdsm/virt/vmdevices/graphics.py
index 8066325..0bfa186 100644
--- a/vdsm/virt/vmdevices/graphics.py
+++ b/vdsm/virt/vmdevices/graphics.py
@@ -18,9 +18,10 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
+import logging
+
 import libvirt
 
-from vdsm import supervdsm
 from vdsm.network import api as net_api
 from vdsm import utils
 from vdsm.config import config
@@ -140,17 +141,7 @@
 graphics.appendChildWithArgs('channel', name=chan,
  mode='secure')
 
-# For the listen type IP to be used, the display network must be OVS.
-# We assume that the cluster in which the host operates is OVS enabled
-# and all other hosts in the cluster have the migration hook installed.
-# The migration hook is responsible to convert ip to net and vice versa
-display_network = self.specParams.get('displayNetwork')
-display_ip = self.specParams.get('displayIp', '0')
-if (display_network and display_ip != '0' and
-supervdsm.getProxy().ovs_bridge(display_network)):
-graphics.appendChildWithArgs(
-'listen', type='address', address=display_ip)
-elif display_network:
+if self.specParams.get('displayNetwork'):
 graphics.appendChildWithArgs(
 'listen', type='network',
 network=net_api.netname_o2l(
@@ -252,16 +243,11 @@
 def _getNetworkIp(network):
 try:
 nets = net_api.libvirt_networks()
-# On a legacy based network, the device is the iface specified in the
-# network report (supporting real bridgeless networks).
-# In case the report or the iface key is missing,
-# the device is defaulted to the network name (i.e. northbound port).
-device = (nets[network].get('iface', network)
-  if network in nets else network)
+device = nets[network].get('iface', network)
 ip, _, _, _ = net_api.ip_addrs_info(device)
 except (libvirt.libvirtError, KeyError, IndexError):
 ip = config.get('addresses', 'guests_gateway_ip')
-finally:
 if ip == '':
 ip = '0'
+logging.info('network %s: using %s', network, ip)
 return ip


-- 
To view, visit https://gerrit.ovirt.org/61259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea42b9c0de25b2d1d08e06ef0deaae59b9e53717
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding report_stats to virt.stats

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Adding report_stats to virt.stats
..


Patch Set 8:

Yaniv, can you reply to the questions in 
https://gerrit.ovirt.org/#/c/59066/8/lib/vdsm/virt/vmstats.py?

-- 
To view, visit https://gerrit.ovirt.org/59066
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf494c6a3087d04c12731c587b619f253dd51165
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Wire up when_finished callback

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Wire up when_finished callback
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/61255/1/vdsm/storage/sdm/api/base.py
File vdsm/storage/sdm/api/base.py:

Line 50: self._status = jobs.STATUS.FAILED
Line 51: else:
Line 52: self._status = jobs.STATUS.DONE
Line 53: finally:
Line 54: self._finished_cb()
Just schedule jobs delete here - pass the scheduler to jobs, it may be useful 
for other stuff.

Since abort() also need to schedule a delete, we can add a _autoclear() method 
called from both run and abort.


-- 
To view, visit https://gerrit.ovirt.org/61255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8db3abc6e57a4a06b90ea1c7bb4186b0b936a152
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: rollback acquired ifaces after failure

[edwardh]

Edward Haas has posted comments on this change.

Change subject: ovs: rollback acquired ifaces after failure
..


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/61088/7/lib/vdsm/network/ifacquire.py
File lib/vdsm/network/ifacquire.py:

PS7, Line 55: netinfo_nets
leftover


-- 
To view, visit https://gerrit.ovirt.org/61088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b7a96c0a83e8dd5dbed1e83a16dd8de6428a601
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Add when_finished callback and wire up Job.abort

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Add when_finished callback and wire up Job.abort
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/61254/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 70: self._id = job_id
Line 71: self._status = STATUS.PENDING
Line 72: self._description = description
Line 73: self._error = None
Line 74: self._finished_cb = lambda: None
I don't see a need for generic finished callback. Since we are adding autoclear 
only to sdm jobs now, we should just schedule a jobs.delete(job_id) in 
sdm.base.Job.run.

We should create the most simple and direct code that does what we need now.
Line 75: 
Line 76: @property
Line 77: def id(self):
Line 78: return self._id


-- 
To view, visit https://gerrit.ovirt.org/61254
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73d4c167a4cf1f1da4c1e2629b7afa9c01d338fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Pass the Scheduler instance to HSM

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Pass the Scheduler instance to HSM
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/61253/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 395: def ready(self):
Line 396: return self._ready
Line 397: 
Line 398: def set_scheduler(self, scheduler):
Line 399: self._scheduler = scheduler
Why not pass the scheduler as argument to __init__?

I don't see a need to replace the scheduler during runtime, and this setter 
cannot be used since we wrap this object in a dispatcher.
Line 400: 
Line 401: @public
Line 402: def registerDomainStateChangeCallback(self, callbackFunc):
Line 403: """


-- 
To view, visit https://gerrit.ovirt.org/61253
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0db5a0dd3f519737a554550efb785d8099d02a6f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: acquire external ifaces

[edwardh]

Edward Haas has posted comments on this change.

Change subject: ovs: acquire external ifaces
..


Patch Set 26: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/60404/25/tests/network/ovs_switch_test.py
File tests/network/ovs_switch_test.py:

Line 28: @attr(type='unit')
Line 29: class ListAcquiredIfacesTests(VdsmTestCase):
Line 30: 
Line 31: @mock.patch('vdsm.network.ovs.info.OvsInfo')
Line 32: def test_add_network_with_nic(self, mock_ovs_info):
> a) remove+add in one transaction:
Great, can we add a test for this?
Line 33: mock_ovs_info.bridges = {}
Line 34: mock_ovs_info.bridges_by_sb = {}
Line 35: mock_ovs_info.northbounds_by_sb = {}
Line 36: 


PS25, Line 53: set()
> They were already acquired by bond itself. I see no problem here.
Ok, that makes sense for the slaves, but what about the bond itself?


-- 
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/60974/5/tests/network/acquire_ifaces_test.py
File tests/network/acquire_ifaces_test.py:

Line 90
Line 91
Line 92
Line 93
Line 94
> I'm not sure, i tried that but got this:
Have you specified what readlines() returns?
m_open.readlines.return_value = NIC_IFCFG.format(NIC_NAME).split()


-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Add when_finished callback and wire up Job.abort

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jobs: Add when_finished callback and wire up Job.abort
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61254
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73d4c167a4cf1f1da4c1e2629b7afa9c01d338fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Autoclear sdm jobs when finished

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Autoclear sdm jobs when finished
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61257
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I666b65d3a73380d786ac1695e4de5c3c7923effd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Wire up when_finished callback

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Wire up when_finished callback
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8db3abc6e57a4a06b90ea1c7bb4186b0b936a152
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Pass the Scheduler instance to HSM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Pass the Scheduler instance to HSM
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61253
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0db5a0dd3f519737a554550efb785d8099d02a6f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Move TestingJob to sdmtestlib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Move TestingJob to sdmtestlib
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf4b1707f3e6a56918a52511f23e21ead1bd5adc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Add when_finished callback and wire up Job.abort

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: jobs: Add when_finished callback and wire up Job.abort
..

jobs: Add when_finished callback and wire up Job.abort

Add a callback mechanism that will be triggered when a job is done, failed, or
aborted.  This will be used to auto-clear finished SDM jobs from the HostJobs
manager.  Since jobs.Job only implements the abort job lifecycle elements, this
patch adds support to jobs.Job for calling the callback after aborting.

Future patches will enable the callback for the SDM Job run lifecycle.

Change-Id: I73d4c167a4cf1f1da4c1e2629b7afa9c01d338fd
Signed-off-by: Adam Litke 
---
M lib/vdsm/jobs.py
M tests/jobsTests.py
2 files changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/61254/1

diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index 232981c..a4d3948 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -19,6 +19,7 @@
 
 from __future__ import absolute_import
 
+import functools
 import logging
 import threading
 
@@ -70,6 +71,7 @@
 self._status = STATUS.PENDING
 self._description = description
 self._error = None
+self._finished_cb = lambda: None
 
 @property
 def id(self):
@@ -117,6 +119,10 @@
 self._status = STATUS.ABORTED
 logging.info('Job %r aborting...', self._id)
 self._abort()
+self._finished_cb()
+
+def when_finished(self, fn, *args, **kwargs):
+self._finished_cb = functools.partial(fn, *args, **kwargs)
 
 def _abort(self):
 """
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index cb1cb89..0b2b7a1 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -158,6 +158,16 @@
 self.assertEqual(response.error(jobs.AbortNotSupported.name),
  jobs.abort(job.id))
 
+def test_abort_finished_callback(self):
+def cb():
+called[0] = True
+
+called = [False]
+job = TestingJob()
+job.when_finished(cb)
+job.abort()
+self.assertTrue(called[0])
+
 @permutations([
 [jobs.STATUS.PENDING, True],
 [jobs.STATUS.RUNNING, True],


-- 
To view, visit https://gerrit.ovirt.org/61254
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I73d4c167a4cf1f1da4c1e2629b7afa9c01d338fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Pass the Scheduler instance to HSM

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: Pass the Scheduler instance to HSM
..

Pass the Scheduler instance to HSM

In preparation for auto-cleared Jobs, pass the Scheduler instance created at
vdsm startup into the HSM.

Change-Id: I0db5a0dd3f519737a554550efb785d8099d02a6f
Signed-off-by: Adam Litke 
---
M vdsm/storage/hsm.py
M vdsm/vdsm
2 files changed, 12 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/61253/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 47d7e76..a4d4bf3 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -338,6 +338,7 @@
 :type defExcFun: function
 """
 self._ready = False
+self._scheduler = None
 rm.ResourceManager.getInstance().registerNamespace(
 STORAGE, rm.SimpleResourceFactory())
 self.storage_repository = config.get('irs', 'repository')
@@ -394,6 +395,9 @@
 def ready(self):
 return self._ready
 
+def set_scheduler(self, scheduler):
+self._scheduler = scheduler
+
 @public
 def registerDomainStateChangeCallback(self, callbackFunc):
 """
diff --git a/vdsm/vdsm b/vdsm/vdsm
index 497ecb6..3afc777 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -90,16 +90,18 @@
 libvirtconnection.start_event_loop()
 
 try:
-if config.getboolean('irs', 'irs_enable'):
-try:
-irs = Dispatcher(HSM())
-except:
-panic("Error initializing IRS")
-
 scheduler = schedule.Scheduler(name="vdsm.Scheduler",
clock=utils.monotonic_time)
 scheduler.start()
 
+if config.getboolean('irs', 'irs_enable'):
+try:
+hsm = HSM()
+hsm.set_scheduler(scheduler)
+irs = Dispatcher(hsm)
+except:
+panic("Error initializing IRS")
+
 from clientIF import clientIF  # must import after config is read
 cif = clientIF.getInstance(irs, log, scheduler)
 


-- 
To view, visit https://gerrit.ovirt.org/61253
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0db5a0dd3f519737a554550efb785d8099d02a6f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Autoclear sdm jobs when finished

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: sdm: Autoclear sdm jobs when finished
..

sdm: Autoclear sdm jobs when finished

The engine uses the Host.getJobs API to query the status of SDM jobs it has
run.  In the common case engine polls for status and running, done, and failed
statuses as appropriate.  Part of the contract between vdsm and engine states
that Host Jobs are nor persisted and can disappear at any time.  Currently this
happens only at vdsm restart.  When a job is missing, engine must resort to
entity polling (eg. Volume.getInfo) to determine the result of the missing job.

Our goal is to keep jobs around long enough so that engine can resolve the
status of flows efficiently but without crowding the Host.getJobs result set
with too many irrelevant jobs.  This patch introduces a new configuration
setting that will delete a completed job (done, failed, aborted) after a
certain number of seconds have elapsed.

We prefer vdsm to clear jobs as opposed to engine clearing them (as is done
with the older tasks) because jobs can disappear at any time and engine must
always be prepared to handle that case.

Change-Id: I666b65d3a73380d786ac1695e4de5c3c7923effd
Signed-off-by: Adam Litke 
---
M lib/vdsm/config.py.in
M tests/sdmtestlib.py
M tests/storage_hsm_test.py
M vdsm/storage/hsm.py
4 files changed, 55 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/61257/1

diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 1ccb3f0..188b51e 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -392,6 +392,11 @@
 'This feature requires a discard support from the storage server. '
 'Physical discard operations are supported if the value of '
 '/sys/block//queue/discard_max_bytes is not zero.'),
+
+ ('jobs_autoclear_delay', '60',
+'Time to wait (in seconds) before finished jobs are automatically '
+'cleared.  Once cleared the job can no longer be checked with the '
+'Host.getJobs API.  To disable autoclear set this to '-1'),
 ]),
 
 # Section: [addresses]
diff --git a/tests/sdmtestlib.py b/tests/sdmtestlib.py
index 2844a6c..efc5899 100644
--- a/tests/sdmtestlib.py
+++ b/tests/sdmtestlib.py
@@ -43,3 +43,6 @@
 assert(vars.job_id == self.id)
 if self.exception:
 raise self.exception
+
+def _abort(self):
+pass
diff --git a/tests/storage_hsm_test.py b/tests/storage_hsm_test.py
index e9e0448..30bc3b3 100644
--- a/tests/storage_hsm_test.py
+++ b/tests/storage_hsm_test.py
@@ -18,6 +18,7 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
+import time
 import uuid
 from contextlib import contextmanager
 
@@ -25,19 +26,28 @@
 from testlib import make_config
 from testlib import VdsmTestCase
 from testlib import permutations, expandPermutations
+from sdmtestlib import TestingJob, wait_for_job
 from storagetestlib import fake_file_env
 from storagetestlib import make_file_volume
 
+from vdsm import jobs
 from vdsm import qemuimg
+from vdsm import schedule
 from vdsm.storage import constants as sc
 from vdsm.storage import exception as se
 
 from storage import hsm
 
 
+class FakeTaskManager(object):
+
+def scheduleJob(self, type, store, task, jobName, func, *args):
+func(*args)
+
+
 class FakeHSM(hsm.HSM):
 def __init__(self):
-pass
+self.taskMng = FakeTaskManager()
 
 
 @expandPermutations
@@ -117,3 +127,35 @@
 make_file_volume(env.sd_manifest, self.SIZE, img_id, vol_id,
  vol_format=vol_fmt)
 yield env.sd_manifest.produceVolume(img_id, vol_id)
+
+
+@expandPermutations
+class SDMAutoclearTest(VdsmTestCase):
+
+def run_job(self, delay, error=None, abort=False):
+conf = make_config([('irs', 'jobs_autoclear_delay', str(delay))])
+with MonkeyPatchScope([(hsm, 'config', conf)]):
+scheduler = schedule.Scheduler()
+scheduler.start()
+h = FakeHSM()
+h.set_scheduler(scheduler)
+job = TestingJob(exception=error)
+if abort:
+job.abort()
+h.sdm_schedule(job)
+wait_for_job(job)
+time.sleep(0.1)  # Give the scheduler a chance to run
+return job
+
+@permutations(((None,), (Exception(),)))
+def test_autoclear(self, error):
+job = self.run_job(delay=0, error=error)
+self.assertRaises(jobs.NoSuchJob, jobs.get, job.id)
+
+def test_autoclear_aborted(self):
+job = self.run_job(delay=0, abort=True)
+self.assertRaises(jobs.NoSuchJob, jobs.get, job.id)
+
+def test_autoclear_disabled(self):
+job = self.run_job(delay=-1)
+self.assertEqual(job.id, jobs.get(job.id).id)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 

Change in vdsm[master]: sdm: Wire up when_finished callback

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: sdm: Wire up when_finished callback
..

sdm: Wire up when_finished callback

Change-Id: I8db3abc6e57a4a06b90ea1c7bb4186b0b936a152
Signed-off-by: Adam Litke 
---
M tests/storage_sdm_api_test.py
M vdsm/storage/sdm/api/base.py
2 files changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/61255/1

diff --git a/tests/storage_sdm_api_test.py b/tests/storage_sdm_api_test.py
index c8d93d2..a5f00bc 100644
--- a/tests/storage_sdm_api_test.py
+++ b/tests/storage_sdm_api_test.py
@@ -33,10 +33,16 @@
 class ApiBaseTests(VdsmTestCase):
 
 def run_job(self, job):
+def finished_cb():
+called[0] = True
+
+called = [False]
+job.when_finished(finished_cb)
 self.assertEqual(jobs.STATUS.PENDING, job.status)
 self.assertIsNone(getattr(vars, 'job_id', None))
 job.run()
 wait_for_job(job)
+self.assertTrue(called[0])
 self.assertIsNone(getattr(vars, 'job_id', None))
 
 def test_states(self):
diff --git a/vdsm/storage/sdm/api/base.py b/vdsm/storage/sdm/api/base.py
index a342300..23603df 100644
--- a/vdsm/storage/sdm/api/base.py
+++ b/vdsm/storage/sdm/api/base.py
@@ -51,4 +51,5 @@
 else:
 self._status = jobs.STATUS.DONE
 finally:
+self._finished_cb()
 vars.job_id = None


-- 
To view, visit https://gerrit.ovirt.org/61255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8db3abc6e57a4a06b90ea1c7bb4186b0b936a152
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Move TestingJob to sdmtestlib

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: Move TestingJob to sdmtestlib
..

tests: Move TestingJob to sdmtestlib

The TestingJob currently used in storage_sdm_api_test.py is needed for testing
Job handling in the hsm tests.  Move it to a common place where it can be
reused.

Change-Id: Ibf4b1707f3e6a56918a52511f23e21ead1bd5adc
Signed-off-by: Adam Litke 
---
M tests/sdmtestlib.py
M tests/storage_sdm_api_test.py
2 files changed, 21 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/61256/1

diff --git a/tests/sdmtestlib.py b/tests/sdmtestlib.py
index 8f95218..2844a6c 100644
--- a/tests/sdmtestlib.py
+++ b/tests/sdmtestlib.py
@@ -18,8 +18,28 @@
 #
 
 import time
+import uuid
+
+from vdsm import jobs
+from vdsm.storage.threadlocal import vars
+
+from storage.sdm.api import base
 
 
 def wait_for_job(job):
 while job.active:
 time.sleep(1)
+
+
+class TestingJob(base.Job):
+
+def __init__(self, exception=None):
+job_id = str(uuid.uuid4())
+super(TestingJob, self).__init__(job_id, 'testing_job', 'host_id')
+self.exception = exception
+
+def _run(self):
+assert(self.status == jobs.STATUS.RUNNING)
+assert(vars.job_id == self.id)
+if self.exception:
+raise self.exception
diff --git a/tests/storage_sdm_api_test.py b/tests/storage_sdm_api_test.py
index a5f00bc..3c4367e 100644
--- a/tests/storage_sdm_api_test.py
+++ b/tests/storage_sdm_api_test.py
@@ -18,16 +18,12 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
-import uuid
-
 from testlib import VdsmTestCase
-from sdmtestlib import wait_for_job
+from sdmtestlib import TestingJob, wait_for_job
 
 from vdsm import jobs
 from vdsm import exception
 from vdsm.storage.threadlocal import vars
-
-from storage.sdm.api import base
 
 
 class ApiBaseTests(VdsmTestCase):
@@ -63,17 +59,3 @@
 self.run_job(job)
 self.assertEqual(jobs.STATUS.FAILED, job.status)
 self.assertIsInstance(job.error, exception.VdsmException)
-
-
-class TestingJob(base.Job):
-
-def __init__(self, exception=None):
-job_id = str(uuid.uuid4())
-super(TestingJob, self).__init__(job_id, 'testing_job', 'host_id')
-self.exception = exception
-
-def _run(self):
-assert(self.status == jobs.STATUS.RUNNING)
-assert(vars.job_id == self.id)
-if self.exception:
-raise self.exception


-- 
To view, visit https://gerrit.ovirt.org/61256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf4b1707f3e6a56918a52511f23e21ead1bd5adc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: ovs_net2bridge fails when ovs service is down

[edwardh]

Edward Haas has posted comments on this change.

Change subject: ovs: ovs_net2bridge fails when ovs service is down
..


Patch Set 2: Code-Review-1

There was an agreement that OVS service must be running on this VDSM version.
If we cannot make this requirement, then there are multiple places where we 
need to check and skip ovs related actions.

Marking -1 for visibility until this is cleared up.

-- 
To view, visit https://gerrit.ovirt.org/61241
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f28234cf8913d964ee60b3f396f6b62cec03383
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net systemd: Require openvswitch.service

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net systemd: Require openvswitch.service
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ed856e8c7fd2cac86d70a1a2dac497dd72cc247
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: move namespace declaration

[fromani]

Francesco Romani has abandoned this change.

Change subject: vmxml: move namespace declaration
..


Abandoned

made obsolete by updated https://gerrit.ovirt.org/#/c/60481/15

-- 
To view, visit https://gerrit.ovirt.org/57381
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie33d816707cc76d4cce61a7d61d42a4304737ee6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: move namespace declaration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: move namespace declaration
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/57381
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33d816707cc76d4cce61a7d61d42a4304737ee6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: reorder operations in _domDependentInit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: reorder operations in _domDependentInit
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59817
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7eb9897a35a554550a463ba562b28f5fe939352
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: cmdutils: enhance systemd_run

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cmdutils: enhance systemd_run
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: supervdsm: configure container networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: supervdsm: configure container networks
..


Patch Set 36:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/54998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107
Gerrit-PatchSet: 36
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: **WIP** tool: reconfigure containers networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: **WIP** tool: reconfigure containers networks
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: filter out 'veth' devices.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: filter out 'veth' devices.
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: containers: add the container support module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: core: containers: add the container support module
..


Patch Set 25:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: utils: add is_kvm helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: utils: add is_kvm helper
..


Patch Set 28:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: supervdsm: expose systemd utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: expose systemd utilities
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: containers: add testsuite

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: containers: add testsuite
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: virt: add optional container support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: virt: add optional container support
..


Patch Set 43:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/53820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f
Gerrit-PatchSet: 43
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: export container metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: export container metadata
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ade3c0c7d300c5ce33cb23723c3d0e59e4af664
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: reorder operations in _domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: reorder operations in _domDependentInit
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/59817/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS5, Line 1844: self._guestEventTime = self._startTime
> Please make the newlines consistent when refactoring.
fixed (after too long :\)


-- 
To view, visit https://gerrit.ovirt.org/59817
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7eb9897a35a554550a463ba562b28f5fe939352
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: **WIP** tool: reconfigure containers networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: **WIP** tool: reconfigure containers networks
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split guest agent init from domDependentInit

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: split guest agent init from domDependentInit
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I13e456d101659848c494f2c27912303c294ccf9f
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split device init from domDependentInit

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: split device init from domDependentInit
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: virt: add optional container support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: virt: add optional container support
..


Patch Set 42:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/53820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f
Gerrit-PatchSet: 42
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split guest agent init from domDependentInit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: split guest agent init from domDependentInit
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13e456d101659848c494f2c27912303c294ccf9f
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split device init from domDependentInit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: split device init from domDependentInit
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: supervdsm: expose systemd utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: expose systemd utilities
..


Patch Set 23:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: supervdsm: configure container networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: supervdsm: configure container networks
..


Patch Set 35:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/54998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: utils: add is_kvm helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: utils: add is_kvm helper
..


Patch Set 27:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: cmdutils: enhance systemd_run

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cmdutils: enhance systemd_run
..


Patch Set 23:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: containers: add the container support module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: core: containers: add the container support module
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: filter out 'veth' devices.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: filter out 'veth' devices.
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: export container metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: export container metadata
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ade3c0c7d300c5ce33cb23723c3d0e59e4af664
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: containers: add testsuite

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: containers: add testsuite
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: reorder operations in _domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: reorder operations in _domDependentInit
..


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/59817/18/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1643: if not self._dom.connected:
Line 1644: raise 
MissingLibvirtDomainError(vmexitreason.LIBVIRT_START_FAILED)
Line 1645: 
Line 1646: sampling.stats_cache.add(self.id)
Line 1647: self._guestEventTime = self._startTime
this is harmless, but requires more work to be done correctly and really 
improving the code. Firs draft (little more than a braindump atm here: 
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:guestevent-fix)
Line 1648: 
Line 1649: self._updateDomainDescriptor()
Line 1650: 
Line 1651: self._dom_init_devices()


-- 
To view, visit https://gerrit.ovirt.org/59817
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7eb9897a35a554550a463ba562b28f5fe939352
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split guest agent init from domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: split guest agent init from domDependentInit
..


Patch Set 18: Code-Review-2

Let's do like this:
1. improve Vm.domDependentInit() separately: 
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:dom-dep-fixes
2. reorganize this series to not need this patch

-- 
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13e456d101659848c494f2c27912303c294ccf9f
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split device init from domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: split device init from domDependentInit
..


Patch Set 18: Code-Review-2

the plan changed as follows:
1. improve Vm.domDependentInit in a separate series
2. abandon this patch, is not strictly needed for container support.

-- 
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split device init from domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: split device init from domDependentInit
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/59814/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS5, Line 1883: def _dom_init_devices(self):
> This function is too packed. I believe it would be slightly better to keep 
I'll drop this patch for the time being, let's continue discussing the 
improvements to the parent function here:

https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:dom-dep-fixes


-- 
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: jsonrpc: add example script to run a VM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: jsonrpc: add example script to run a VM
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61047
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc8ec3a6ea795659834392f94e7649218ac3fda8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: add methods to get/set transient status

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: add methods to get/set transient status
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice7c1cde7244ff2e041efcecf91c2ae030c70544
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: use monotonic_time() for transient status

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: use monotonic_time() for transient status
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27b63df7956de4ae311f168ca21057a22cc0759e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: always set transient_status with its timestamp

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: always set transient_status with its timestamp
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd84c955072f5f46626aed05a6de8c1c4d381cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: rename Vm._guestEvent

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: rename Vm._guestEvent
..

vm: rename Vm._guestEvent

The _guestEvent field of Vm class is misleading.
It does not track a "guest event", but rather sets a transient
VM status which overrides the real VM status for a fixed amount of time.

After the amount of time expires, the transient VM status is ignored,
and the proper VM status is used.

Research why this logic was introduced is still in progress;
the most likely cause is to provide the correct information to Engine
while lenghty operation (VM startup or powerdown) is in progress;
should this lengthy operation fail, the transient nature provides
automatic readjustement avoiding the need of proper recovering.

However, the price to pay is increased complexity and more VM fields
to track.

This patch just renames the field to make their real purpose clearer.

Change-Id: I9fd081830146840890cf22749b41eab4b06f31db
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 15 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/61245/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7c21eca..1135896 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -267,8 +267,8 @@
 self._volPrepareLock = threading.Lock()
 self._initTimePauseCode = None
 self._initTimeRTC = int(self.conf.get('timeOffset', 0))
-self._guestEvent = vmstatus.POWERING_UP
-self._guestEventTime = 0
+self._transient_status = vmstatus.POWERING_UP
+self._transient_status_time = 0
 self._guestCpuRunning = False
 self._guestCpuLock = threading.Lock()
 self._startTime = time.time() - \
@@ -658,8 +658,8 @@
 try:
 self.log.info('reboot event')
 self._startTime = time.time()
-self._guestEventTime = self._startTime
-self._guestEvent = vmstatus.REBOOT_IN_PROGRESS
+self._transient_status_time = self._startTime
+self._transient_status = vmstatus.REBOOT_IN_PROGRESS
 self._powerDownEvent.set()
 self.saveState()
 # this always triggers onStatusChange event, which
@@ -1070,13 +1070,13 @@
 
 delay = int(delay)
 
-self._guestEventTime = time.time()
+self._transient_status_time = time.time()
 if reboot:
-self._guestEvent = vmstatus.REBOOT_IN_PROGRESS
+self._transient_status = vmstatus.REBOOT_IN_PROGRESS
 powerDown = VmReboot(self, delay, message, timeout, force,
  self._powerDownEvent)
 else:
-self._guestEvent = vmstatus.POWERING_DOWN
+self._transient_status = vmstatus.POWERING_DOWN
 powerDown = VmShutdown(self, delay, message, timeout, force,
self._powerDownEvent)
 return powerDown.start()
@@ -1312,16 +1312,17 @@
 
 def _getVmStatus(self):
 def _getVmStatusFromGuest():
-GUEST_WAIT_TIMEOUT = 60
+TRANSIENT_STATUS_VALIDITY = 60
 now = time.time()
-if now - self._guestEventTime < 5 * GUEST_WAIT_TIMEOUT and \
-self._guestEvent == vmstatus.POWERING_DOWN:
-return self._guestEvent
+if (((now - self._transient_status_time) < 
+(5 * TRANSIENT_STATUS_VALIDITY) and 
+self._transient_status == vmstatus.POWERING_DOWN):
+return self._transient_status
 if self.guestAgent and self.guestAgent.isResponsive() and \
 self.guestAgent.getStatus():
 return self.guestAgent.getStatus()
-if now - self._guestEventTime < GUEST_WAIT_TIMEOUT:
-return self._guestEvent
+if now - self._transient_status_time < TRANSIENT_STATUS_VALIDITY:
+return self._transient_status
 return vmstatus.UP
 
 statuses = (vmstatus.SAVING_STATE, vmstatus.RESTORING_STATE,
@@ -1665,7 +1666,7 @@
 supervdsm.getProxy().setPortMirroring(network,
   nic.name)
 
-self._guestEventTime = self._startTime
+self._transient_status_time = self._startTime
 try:
 self.guestAgent.start()
 except Exception:


-- 
To view, visit https://gerrit.ovirt.org/61245
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fd081830146840890cf22749b41eab4b06f31db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: rename Vm._guestEvent

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: rename Vm._guestEvent
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61245
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fd081830146840890cf22749b41eab4b06f31db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: legacy rng devices fix not needed anymore

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: legacy rng devices fix not needed anymore
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61243
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34eef559ef3d789fd502490acc9691df15c684b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: move device initialization together

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: move device initialization together
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife7c85069e3a6703fdde74c87c68615308b2674e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: legacy rng devices fix not needed anymore

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: legacy rng devices fix not needed anymore
..

vm: legacy rng devices fix not needed anymore

We introduced this fix to deal with upgrades from Vdsm
4.16.z, and we don't need this anymore.

Change-Id: I34eef559ef3d789fd502490acc9691df15c684b9
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/61243/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 61a59ca..df32da0 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1647,13 +1647,6 @@
 
 self._updateDomainDescriptor()
 
-# REQUIRED_FOR migrate from vdsm-4.16
-#
-# We need to clean out unknown devices that are created for
-# RNG devices by VDSM 3.5 and are left in the configuration
-# after upgrade to 3.6.
-self._fixLegacyRngConf()
-
 self._getUnderlyingVmDevicesInfo()
 self._updateAgentChannels()
 
@@ -4604,25 +4597,6 @@
 newChain = [x for x in device['volumeChain']
 if x['volumeID'] in volumes]
 device['volumeChain'] = drive.volumeChain = newChain
-
-def _fixLegacyRngConf(self):
-def _is_legacy_rng_device_conf(dev):
-"""
-Returns True if dev is a legacy (3.5) RNG device conf,
-False otherwise.
-"""
-return dev['type'] == hwclass.RNG and (
-'specParams' not in dev or
-'source' not in dev['specParams']
-)
-
-with self._confLock:
-self._devices[hwclass.RNG] = [dev for dev
-  in self._devices[hwclass.RNG]
-  if 'source' in dev.specParams]
-self.conf['devices'] = [dev for dev
-in self.conf['devices']
-if not _is_legacy_rng_device_conf(dev)]
 
 def getDiskDevices(self):
 return self._devices[hwclass.DISK]


-- 
To view, visit https://gerrit.ovirt.org/61243
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34eef559ef3d789fd502490acc9691df15c684b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: move device initialization together

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: move device initialization together
..

vm: move device initialization together

It was scatthered around in Vm._domDependentInit for no good reason
No intended changes in behaviour

Change-Id: Ife7c85069e3a6703fdde74c87c68615308b2674e
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/61242/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7c21eca..61a59ca 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1665,6 +1665,9 @@
 supervdsm.getProxy().setPortMirroring(network,
   nic.name)
 
+for con in self._devices[hwclass.CONSOLE]:
+con.prepare()
+
 self._guestEventTime = self._startTime
 try:
 self.guestAgent.start()
@@ -1682,9 +1685,6 @@
 
 # Drop enableGuestEvents from conf - Not required from here anymore
 self.conf.pop('enableGuestEvents', None)
-
-for con in self._devices[hwclass.CONSOLE]:
-con.prepare()
 
 self._guestCpuRunning = self._isDomainRunning()
 self._logGuestCpuStatus('domain initialization')


-- 
To view, visit https://gerrit.ovirt.org/61242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife7c85069e3a6703fdde74c87c68615308b2674e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: osutils: Start the osutils module

[alitke]

Adam Litke has posted comments on this change.

Change subject: osutils: Start the osutils module
..


Patch Set 4: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/61142/4/tests/osutils_test.py
File tests/osutils_test.py:

Line 27: from testlib import forked
Line 28: from vdsm.common import osutils
Line 29: 
Line 30: 
Line 31: class TestCloseFd(VdsmTestCase):
> Can you also test the -EINTR case?
I see this is handled by a later patch.
Line 32: 
Line 33: # Run in a child process to ensure single thread. Otherwise 
another thread
Line 34: # opening a file descriptor may cause false failure.
Line 35: @forked


-- 
To view, visit https://gerrit.ovirt.org/61142
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia995c083f31c3489ced16265d459f30355f854b0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: testlib: Use osutils.close_fd to avoid fd leaks

[alitke]

Adam Litke has posted comments on this change.

Change subject: testlib: Use osutils.close_fd to avoid fd leaks
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61216
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c8d2b7e29cc7df751d4fc1954ad3f3cae6917ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

[alitke]

Adam Litke has posted comments on this change.

Change subject: osutils: Move NoIntrCall to osutils.uninterruptible
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61153
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51f852103dcd90e1350b406d8bd053976e5820a1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Support for multiple leases

[alitke]

Adam Litke has posted comments on this change.

Change subject: clusterlock: Support for multiple leases
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60422
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7903b13bd017e3da6762e8979f7f4dfc6520de9e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: ovs_net2bridge fails when ovs service is down

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: ovs_net2bridge fails when ovs service is down
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::#1195208::OK, correct target milestone ovirt-4.0.2
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/61241
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f28234cf8913d964ee60b3f396f6b62cec03383
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Raise if lock is used improperly

[alitke]

Adam Litke has posted comments on this change.

Change subject: clusterlock: Raise if lock is used improperly
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia616070615a02fc86f85329e334d0af773e678b0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net systemd: Require openvswitch.service

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: net systemd: Require openvswitch.service
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/61239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ed856e8c7fd2cac86d70a1a2dac497dd72cc247
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net systemd: Require openvswitch.service

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net systemd: Require openvswitch.service
..


Patch Set 2: -Verified

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::#1195208::OK, correct target milestone ovirt-4.0.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/61239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ed856e8c7fd2cac86d70a1a2dac497dd72cc247
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net func tests: drop ovs/legacy permutation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net func tests: drop ovs/legacy permutation
..


Patch Set 1: Verified-1

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::#1195208::OK, correct target milestone ovirt-4.0.2
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/61238
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ca7bf36474d50a76e9cdfc1b671a632672f45d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: ovs_net2bridge fails when ovs service is down

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: ovs_net2bridge fails when ovs service is down
..


Patch Set 1: Verified-1

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::#1195208::OK, correct target milestone ovirt-4.0.2
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/61241
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f28234cf8913d964ee60b3f396f6b62cec03383
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: ovs_net2bridge fails when ovs service is down

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: ovs: ovs_net2bridge fails when ovs service is down
..

ovs: ovs_net2bridge fails when ovs service is down

Calling ovs_net2bridge() when openvswitch service is not running
leads to:
(21, 'Executing commands failed: ovs-vsctl:
unix:/var/run/openvswitch/db.sock: database connection failed (No such
file or directory)')

With this patch, we just return None if OVS service is not running.

Change-Id: I8f28234cf8913d964ee60b3f396f6b62cec03383
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/netswitch.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/61241/1

diff --git a/lib/vdsm/network/netswitch.py b/lib/vdsm/network/netswitch.py
index 0e05e37..d68f6bf 100644
--- a/lib/vdsm/network/netswitch.py
+++ b/lib/vdsm/network/netswitch.py
@@ -308,7 +308,10 @@
 
 
 def ovs_net2bridge(network_name):
-return ovs_info.northbound2bridge(network_name)
+if _is_ovs_service_running():
+return ovs_info.northbound2bridge(network_name)
+else:
+return None
 
 
 def net2vlan(network_name):


-- 
To view, visit https://gerrit.ovirt.org/61241
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f28234cf8913d964ee60b3f396f6b62cec03383
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: ovs_net2bridge fails when ovs service is down

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: ovs: ovs_net2bridge fails when ovs service is down
..

ovs: ovs_net2bridge fails when ovs service is down

Calling ovs_net2bridge() when openvswitch service is not running
leads to:
(21, 'Executing commands failed: ovs-vsctl:
unix:/var/run/openvswitch/db.sock: database connection failed (No such
file or directory)')

With this patch, we just return None if OVS service is not running.

Change-Id: I8f28234cf8913d964ee60b3f396f6b62cec03383
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/netswitch.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/61240/1

diff --git a/lib/vdsm/network/netswitch.py b/lib/vdsm/network/netswitch.py
index 0e05e37..d68f6bf 100644
--- a/lib/vdsm/network/netswitch.py
+++ b/lib/vdsm/network/netswitch.py
@@ -308,7 +308,10 @@
 
 
 def ovs_net2bridge(network_name):
-return ovs_info.northbound2bridge(network_name)
+if _is_ovs_service_running():
+return ovs_info.northbound2bridge(network_name)
+else:
+return None
 
 
 def net2vlan(network_name):


-- 
To view, visit https://gerrit.ovirt.org/61240
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f28234cf8913d964ee60b3f396f6b62cec03383
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: ovs_net2bridge fails when ovs service is down

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: ovs_net2bridge fails when ovs service is down
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61240
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f28234cf8913d964ee60b3f396f6b62cec03383
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/60533/2/README.logging
File README.logging:

PS2, Line 19: configuring
> configure
Done


-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Fix double close on EINTR

[alitke]

Adam Litke has posted comments on this change.

Change subject: clusterlock: Fix double close on EINTR
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cae714af9646e268f40ff1ff3cdb3f6b048e6e9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net systemd: Require openvswitch.service

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net systemd: Require openvswitch.service
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/61239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ed856e8c7fd2cac86d70a1a2dac497dd72cc247
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: supervdsm: expose systemd utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: expose systemd utilities
..


Patch Set 22:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: osutils: Start the osutils module

[alitke]

Adam Litke has posted comments on this change.

Change subject: osutils: Start the osutils module
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/61142/4/tests/osutils_test.py
File tests/osutils_test.py:

Line 27: from testlib import forked
Line 28: from vdsm.common import osutils
Line 29: 
Line 30: 
Line 31: class TestCloseFd(VdsmTestCase):
Can you also test the -EINTR case?
Line 32: 
Line 33: # Run in a child process to ensure single thread. Otherwise 
another thread
Line 34: # opening a file descriptor may cause false failure.
Line 35: @forked


-- 
To view, visit https://gerrit.ovirt.org/61142
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia995c083f31c3489ced16265d459f30355f854b0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net func tests: drop ovs/legacy permutation

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net func tests: drop ovs/legacy permutation
..

net func tests: drop ovs/legacy permutation

OVS tests are now covered in new functional tests
tests/network/func_*_test.py.

Change-Id: Ic2ca7bf36474d50a76e9cdfc1b671a632672f45d
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M tests/functional/networkTests.py
1 file changed, 10 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/61238/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 2438c01..e7668b8 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -488,17 +488,16 @@
 self.retryAssert(assertStatsInRange, timeout=3)
 
 @cleanupNet
-@permutations([[True, 'legacy'], [False, 'legacy'],
-   [True, 'ovs'], [False, 'ovs']])
-def testSetupNetworksAddBondWithManyVlans(self, bridged, switch):
+@permutations([[True], [False]])
+def testSetupNetworksAddBondWithManyVlans(self, bridged):
 VLAN_COUNT = 5
 network_names = [NETWORK_NAME + str(tag) for tag in range(VLAN_COUNT)]
 with dummyIf(2) as nics:
 networks = dict((vlan_net,
  {'vlan': str(tag), 'bonding': BONDING_NAME,
-  'bridged': bridged, 'switch': switch})
+  'bridged': bridged})
 for tag, vlan_net in enumerate(network_names))
-bondings = {BONDING_NAME: {'nics': nics, 'switch': switch}}
+bondings = {BONDING_NAME: {'nics': nics}}
 
 status, msg = self.setupNetworks(networks, bondings, NOCHK)
 self.assertEqual(status, SUCCESS, msg)
@@ -725,13 +724,11 @@
 self.assertEqual(status, SUCCESS, msg)
 
 @cleanupNet
-@permutations([[True, 'legacy'], [False, 'legacy'],
-   [True, 'ovs'], [False, 'ovs']])
-def testTwiceAdd(self, bridged, switch):
+@permutations([[True], [False]])
+def testTwiceAdd(self, bridged):
 with dummyIf(1) as nics:
 nic, = nics
-net = {NETWORK_NAME: {'nic': nic, 'bridged': bridged,
-  'switch': switch}}
+net = {NETWORK_NAME: {'nic': nic, 'bridged': bridged}}
 status, msg = self.vdsm_net.setupNetworks(net, {}, NOCHK)
 self.assertEqual(status, SUCCESS, msg)
 
@@ -810,9 +807,8 @@
 
 self.assertEqual(status, SUCCESS, msg)
 
-@permutations([[True, 'legacy'], [False, 'legacy'],
-   [True, 'ovs'], [False, 'ovs']])
-def testSetupNetworksAddManyVlans(self, bridged, switch):
+@permutations([[True], [False]])
+def testSetupNetworksAddManyVlans(self, bridged):
 VLAN_COUNT = 5
 NET_VLANS = [(NETWORK_NAME + str(index), str(index))
  for index in range(VLAN_COUNT)]
@@ -821,7 +817,7 @@
 nic, = nics
 networks = dict((vlan_net,
  {'vlan': str(tag), 'nic': nic,
-  'bridged': bridged, 'switch': switch})
+  'bridged': bridged})
 for vlan_net, tag in NET_VLANS)
 
 status, msg = self.setupNetworks(networks, {}, NOCHK)


-- 
To view, visit https://gerrit.ovirt.org/61238
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2ca7bf36474d50a76e9cdfc1b671a632672f45d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net systemd: Require openvswitch.service

[phoracek]

Hello Dan Kenigsberg, Edward Haas,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/61239

to review the following change.

Change subject: net systemd: Require openvswitch.service
..

net systemd: Require openvswitch.service

vdsm-network service requires openvswitch service to be running.

openvswitch service is also dependent on the --enable-openvswitch build
flag.

Change-Id: I7ed856e8c7fd2cac86d70a1a2dac497dd72cc247
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/58689
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M configure.ac
M init/systemd/vdsm-network.service.in
2 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/61239/1

diff --git a/configure.ac b/configure.ac
index a05eba0..17004be 100644
--- a/configure.ac
+++ b/configure.ac
@@ -165,6 +165,10 @@
   AC_SUBST([OPENVSWITCH], ['1']),
   AC_SUBST([OPENVSWITCH], ['0']))
 
+AS_IF([test "${enable_openvswitch}" = "yes"],
+  AC_SUBST([OPENVSWITCHSERVICE], ['openvswitch.service']),
+  AC_SUBST([OPENVSWITCHSERVICE], []))
+
 AC_ARG_WITH(
 [qemu-user],
 [AS_HELP_STRING(
diff --git a/init/systemd/vdsm-network.service.in 
b/init/systemd/vdsm-network.service.in
index 3c992f3..3a4b10d 100644
--- a/init/systemd/vdsm-network.service.in
+++ b/init/systemd/vdsm-network.service.in
@@ -1,8 +1,8 @@
 [Unit]
 Description=Virtual Desktop Server Manager network restoration
 Wants=network.target
-Requires=libvirtd.service
-After=libvirtd.service
+Requires=libvirtd.service @OPENVSWITCHSERVICE@
+After=libvirtd.service @OPENVSWITCHSERVICE@
 
 [Service]
 Type=oneshot


-- 
To view, visit https://gerrit.ovirt.org/61239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ed856e8c7fd2cac86d70a1a2dac497dd72cc247
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: api: move vm status check into migrate()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: api: move vm status check into migrate()
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60608
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d5bfcc98b1169e2deed947c945e55c19d5ab04
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 3: Verified+1

copied score.

-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split guest agent init from domDependentInit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: split guest agent init from domDependentInit
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13e456d101659848c494f2c27912303c294ccf9f
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: reorder operations in _domDependentInit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: reorder operations in _domDependentInit
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59817
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7eb9897a35a554550a463ba562b28f5fe939352
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org