Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-11-10 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Ah, sorry, I missed that part of the patch. Alex From: Wentland, Harry Sent: Tuesday, November 10, 2020 11:42 AM To: Deucher, Alexander ; Wang, Chao-kai (Stylon) ; amd-gfx@lists.freedesktop.org Cc

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-11-10 Thread Deucher, Alexander
, Chao-kai (Stylon) ; amd-gfx@lists.freedesktop.org Cc: Kazlauskas, Nicholas ; Deucher, Alexander Subject: Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume On 2020-11-10 2:49 a.m., Stylon Wang wrote: > EDID parsing in S3 resume pushes new display modes > to probed_modes list but d

Re: [PATCH] drm/amdgpu: enable DCN for navi10 headless SKU

2020-11-06 Thread Deucher, Alexander
) ; Tuikov, Luben ; Deucher, Alexander ; Cui, Flora ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: enable DCN for navi10 headless SKU From: "Tianci.Yin" There is a NULL pointer crash when DCN disabled on headless SKU. On normal SKU, the variable adev->ddev.mode_config.funcs i

Re: [PATCH] drm/amdgpu: Fix Arcturus fan speed reporting

2020-11-05 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Thursday, November 5, 2020 10:20 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] drm/amdgpu: Fix Arcturus fan

Re: [PATCH] drm/amdgpu: clip the ref divider max value at 100

2020-11-04 Thread Deucher, Alexander
yeah, ideally. Just need to get support for analog encoders. Alex From: Koenig, Christian Sent: Wednesday, November 4, 2020 9:31 AM To: Deucher, Alexander ; Sharma, Shashank ; amd-gfx@lists.freedesktop.org Cc: Qin, Eddy Subject: Re: [PATCH] drm/amdgpu: clip

Re: [PATCH] drm/amdgpu: clip the ref divider max value at 100

2020-11-04 Thread Deucher, Alexander
, Shashank Sent: Wednesday, November 4, 2020 9:11 AM To: Deucher, Alexander ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Cc: Qin, Eddy Subject: Re: [PATCH] drm/amdgpu: clip the ref divider max value at 100 Thanks Alex, Same question here, Should we go through some extensive test routine due

Re: [PATCH] drm/amdgpu: clip the ref divider max value at 100

2020-11-04 Thread Deucher, Alexander
Acked-by: Alex Deucher From: Koenig, Christian Sent: Wednesday, November 4, 2020 6:54 AM To: Sharma, Shashank ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Qin, Eddy Subject: Re: [PATCH] drm/amdgpu: clip the ref divider max value at 100 Am 04.11.20

Re: [PATCH] drm/amd/display: fix psr panel lightup

2020-11-03 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: roman...@amd.com Sent: Tuesday, November 3, 2020 6:12 PM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Quan, Evan ; Siqueira, Rodrigo ; Pillai, Aurabindo Cc: Li, Roman Subject: [PATCH] drm/amd/display: fix psr panel

RE: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-03 Thread Deucher, Alexander
gt;; Melissa Wen ; > amd-gfx list ; Daniel Vetter > ; Daniel Vetter ; Deucher, > Alexander > Subject: Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or > NULL > > On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian König wrote: > > Am 02.11.20 um 20:43 s

Re: [PATCH] drm/amdgpu: update module paramter doc of amdgpu_dpm

2020-11-03 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kevin Wang Sent: Tuesday, November 3, 2020 12:54 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) ; Feng, Kenneth Subject: [PATCH] drm/amdgpu: update module paramter doc of amdgpu_dpm the vega20

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-03 Thread Deucher, Alexander
That should be harmless and we can fix that up. Does everything work as expected other than the error message? Alex From: Yin, Tianci (Rico) Sent: Monday, November 2, 2020 9:51 PM To: Alex Deucher ; Deucher, Alexander Cc: Zhang, Hawking ; amd-gfx

Re: [PATCH] amdkfd: Check kvmalloc return before memcpy

2020-11-02 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Monday, November 2, 2020 11:27 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] amdkfd: Check kvmalloc return

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-02 Thread Deucher, Alexander
[AMD Public Use] That's the IP discovery table. The Object header is part of atombios. Do you have an vbios image from that system? Alex From: Yin, Tianci (Rico) Sent: Sunday, November 1, 2020 10:46 PM To: Deucher, Alexander ; Zhang, Hawking ; amd-gfx

Re: [PATCH] drm/amdgpu: replace ih ip block for vega20 and arcturus

2020-11-02 Thread Deucher, Alexander
[AMD Public Use] It might be cleaner to just split out vega20 into a separate switch case in that function. Alex From: amd-gfx on behalf of Alex Sierra Sent: Friday, October 30, 2020 11:06 PM To: amd-gfx@lists.freedesktop.org Cc: Sierra Guiza, Alejandro

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-10-30 Thread Deucher, Alexander
: Tuikov, Luben ; Deucher, Alexander ; Chen, Guchun ; Cui, Flora ; Xu, Feifei ; Long, Gang Subject: RE: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU [AMD Public Use] [AMD Public Use] I see, thanks for the clarifying. The patch is Reviewed-by: Hawking Zhang I

Re: [PATCH] drm/amdgpu: cleanup gmc_v9_0_process_interrupt

2020-10-28 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Wednesday, October 28, 2020 9:49 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: cleanup

Re: [PATCH 5/5] drm/amd/pm: do not use ixFEATURE_STATUS for checking smc running

2020-10-28 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Wednesday, October 28, 2020 4:30 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; sandy.8...@gmail.com ; Quan, Evan Subject: [PATCH 5/5] drm/amd/pm: do not use

Re: [PATCH 2/2] drm/amd/pm: fix compile warnings about variable used uninitialized

2020-10-27 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Tuesday, October 27, 2020 10:45 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan ; kernel test robot Subject: [PATCH 2/2

Re: [PATCH] drm/amdgpu: add vangogh apu flag

2020-10-26 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Huang Rui Sent: Monday, October 26, 2020 8:51 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: [PATCH] drm/amdgpu: add vangogh apu flag This patch is to add vangogh apu flag to

RE: amdgpu crashes on OOM

2020-10-26 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Michel Dänzer > Sent: Monday, October 26, 2020 7:04 AM > To: Alex Xu (Hello71) ; Kazlauskas, Nicholas > ; Deucher, Alexander > ; Wentland, Harry > ; Li, Sun peng (Leo) ; > amd-gfx@lists.freedesktop.org > Cc: l

Re: [PATCH] drm/amdgpu: drop mem_global_referenced

2020-10-26 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Monday, October 26, 2020 5:29 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: drop mem_global_referenced Not used any more. Signed-off-by:

Re: [PATCH] drm/amdgpu: enable VCN PG and CG for vangogh

2020-10-19 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Zhang, Boyuan Sent: Friday, October 16, 2020 7:28 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: enable VCN PG and CG for vangogh [AMD Official Use Only - Internal

Re: [PATCH] drm/amd/psp: Fix sysfs: cannot create duplicate filename

2020-10-16 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher Want to add a Fixes: tag? From: amd-gfx on behalf of Andrey Grodzovsky Sent: Friday, October 16, 2020 10:52 AM To: amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Zhang, Jack (Jian) Subject: [PATCH]

Re: [PATCH 2/2] drm/amd/display: Fix DCN302 makefile

2020-10-15 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Bhawanpreet Lakha Sent: Thursday, October 15, 2020 2:20 PM To: Kazlauskas, Nicholas ; Deucher, Alexander Cc: rodrigo.siqofue...@amd.com ; amd-gfx@lists.freedesktop.org ; Lakha, Bhawanpreet Subject

Re: [PATCH 2/2] drm/amdgpu/display: enable display ip block for vangogh

2020-10-15 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Series is: Reviewed-by: Alex Deucher From: Huang, Ray Sent: Thursday, October 15, 2020 4:28 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Roman ; Deucher, Alexander ; Huang, Ray Subject

Re: [PATCH] drm/amdgpu: update golden setting for sienna_cichlid

2020-10-15 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Likun Gao Sent: Wednesday, October 14, 2020 10:57 PM To: amd-gfx@lists.freedesktop.org Cc: Gao, Likun ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: update golden setting for sienna_cichlid

Re: [PATCH] Revert "drm/amdgpu: disable gfxoff temporarily for navy_flounder"

2020-10-14 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Jiansong Chen Sent: Wednesday, October 14, 2020 10:46 PM To: amd-gfx@lists.freedesktop.org Cc: Chen, Jiansong (Simon) ; Zhou1, Tao ; Zhang, Hawking Subject: [PATCH] Revert "drm/amdgpu:

Re: [PATCH] drm/amdkfd: Use kvfree in destroy_crat_image

2020-10-14 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Wednesday, October 14, 2020 7:51 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] drm/amdkfd: Use kvfree in

Re: [PATCH] drm/amd/pm: increase mclk switch threshold to 200 us

2020-10-13 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: Quan, Evan Sent: Tuesday, October 13, 2020 2:45 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/pm: increase mclk switch

RE: [PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power managed by ACPI

2020-10-02 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Rafael J. Wysocki > Sent: Friday, October 2, 2020 10:25 AM > To: Deucher, Alexander > Cc: Rafael J. Wysocki ; Lukas Wunner > ; Aaron Zakhrov ; Michal > Rostecki ; Linux PCI ; > Rafael J. Wysocki ; amd-gfx list g.

RE: [PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power managed by ACPI

2020-10-02 Thread Deucher, Alexander
.org>; ACPI Devel Maling List a...@vger.kernel.org>; Shai Coleman ; Bjorn > Helgaas ; Arthur Borsboom > ; matoro ; Deucher, > Alexander ; Mika Westerberg > ; Len Brown > Subject: Re: [PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power > managed by ACPI > &

RE: [PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power managed by ACPI

2020-10-02 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Lukas Wunner > Sent: Friday, October 2, 2020 1:10 AM > To: Bjorn Helgaas ; Rafael J. Wysocki > ; Len Brown > Cc: Deucher, Alexander ; Mika Westerberg > ; linux-...@vger.kernel.org; linux- > a...@vger.kernel.org; amd-g

Re: [PATCH] drm/amd/pm: fix screen flicker seen on Navi14 with 2*4K monitors

2020-09-24 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Thanks. Acked-by: Alex Deucher From: Quan, Evan Sent: Thursday, September 24, 2020 11:38 PM To: Alex Deucher Cc: amd-gfx list ; Deucher, Alexander Subject: RE: [PATCH] drm/amd/pm: fix screen flicker seen

Re: [PATCH] drm/amd/pm: correct the pmfw version check for Navi14

2020-09-21 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Quan, Evan Sent: Sunday, September 20, 2020 10:47 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/pm: correct the pmfw version check for Navi14 Otherwise

Re: [PATCH 2/2] drm/amd/pm: drop redundant watermarks bitmap setting

2020-09-21 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Sunday, September 20, 2020 10:49 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 2/2] drm/amd/pm: drop redundant watermarks bitmap setting

Re: [PATCH] drm/amdkfd: Use kvmalloc instead of kmalloc for VCRAT

2020-09-21 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Monday, September 21, 2020 10:27 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] drm/amdkfd: Use kvmalloc instead of kmalloc for VCRAT Since

Re: [PATCH] drm/amd/pm: apply dummy reads workaround for CDR enabled only

2020-09-17 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: Quan, Evan Sent: Thursday, September 17, 2020 10:36 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/pm: apply dummy reads

Re: [PATCH] drm/amd/display: Don't log hdcp module warnings in dmesg

2020-09-15 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: Bhawanpreet Lakha Sent: Tuesday, September 15, 2020 5:38 PM To: Deucher, Alexander Cc: Siqueira, Rodrigo ; Kazlauskas, Nicholas ; amd-gfx@lists.freedesktop.org ; Lakha

Re: [PATCH] drm/amdgpu: Update RAS init handling

2020-09-14 Thread Deucher, Alexander
[AMD Public Use] Also, general nit, per kernel coding style, braces should be on the same line as the if or else, E.g., } else { Alex From: amd-gfx on behalf of Zhang, Hawking Sent: Friday, September 11, 2020 2:02 AM To: Clements, John ; amd-gfx list ;

Re: [PATCH 1/1] drm/amdgpu: fix a typo

2020-09-14 Thread Deucher, Alexander
[AMD Public Use] This is not upstream, but Acked-by: Alex Deucher From: amd-gfx on behalf of Nirmoy Das Sent: Tuesday, September 8, 2020 11:57 AM To: amd-gfx@lists.freedesktop.org Cc: Das, Nirmoy ; Kazlauskas, Nicholas Subject: [PATCH 1/1] drm/amdgpu: fix a

Re: [PATCH] drm/amdgpu: Include sienna_cichlid in USBC PD FW support.

2020-09-14 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Grodzovsky, Andrey Sent: Monday, September 14, 2020 10:32 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: Include sienna_cichlid in USBC PD FW support. Ping Andrey

RE: [PATCH v3 6/7] drm: Validate encoder->possible_crtcs

2020-09-10 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: amd-gfx On Behalf Of > Daniel Vetter > Sent: Monday, September 7, 2020 3:15 AM > To: Jan Kiszka ; amd-gfx list g...@lists.freedesktop.org>; Wentland, Harry ; > Kazlauskas, Nicholas > Cc: dri-devel ; intel-gfx g...@lists.freedesktop.org>;

Re: [PATCH] drm/amdgpu: add ta firmware load in psp_v12_0 for renoir

2020-09-03 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: Zhu, Changfeng Sent: Thursday, September 3, 2020 11:19 AM To: Lakha, Bhawanpreet ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org ; Huang, Ray Subject: RE: [PATCH] drm/amdgpu: add ta firmware load in psp_v12_0 for renoir

Re: [PATCH v4 0/8] Implement PCI Error Recovery on Navi12

2020-09-03 Thread Deucher, Alexander
; linux-...@vger.kernel.org ; Deucher, Alexander ; Das, Nirmoy ; Li, Dennis ; Koenig, Christian ; Tuikov, Luben ; bhelg...@google.com Subject: Re: [PATCH v4 0/8] Implement PCI Error Recovery on Navi12 This one is very close - https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm

Re: [PATCH 2/2] drm/amdgpu/gmc10: print client id string for gfxhub

2020-09-02 Thread Deucher, Alexander
@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 2/2] drm/amdgpu/gmc10: print client id string for gfxhub Am 02.09.20 um 04:32 schrieb Felix Kuehling: > Should there a corresponding change in mmhub_v2_0.c? It would be at least nice to have. Maybe we should put a pointer to the array and

Re: [PATCH] drm/amdgpu: fix max_entries calculation v2

2020-09-02 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Wednesday, September 2, 2020 10:05 AM To: Pan, Xinhui ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: fix max_entries

Re: [PATCH] drm/amdgpu: add ta firmware load in psp_v12_0 for renoir

2020-09-02 Thread Deucher, Alexander
[AMD Public Use] We also need to release the firmware when the driver unloads or is that already handled in some common path? Alex From: amd-gfx on behalf of Changfeng.Zhu Sent: Tuesday, September 1, 2020 10:25 PM To: amd-gfx@lists.freedesktop.org ; Huang,

Re: [PATCH 1/4] drm/amd/pm: drop unnecessary feature->mutex lock protections(V2)

2020-08-28 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] This code gets called during suspend and resume and GPU reset as well. Are those cases properly covered? Alex From: amd-gfx on behalf of Christian König Sent: Friday, August 28, 2020 4:16 AM To: Das,

Re: [PATCH 1/1] drm/amdgpu: fix compiler warnings

2020-08-27 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: Das, Nirmoy Sent: Thursday, August 27, 2020 11:58 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Das, Nirmoy Subject: [PATCH 1/1] drm/amdgpu: fix compiler

Re: [PATCH] drm/amd/pm: avoid false alarm due to confusing softwareshutdowntemp setting

2020-08-26 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: Quan, Evan Sent: Wednesday, August 26, 2020 3:45 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/pm: avoid false alarm due

Re: [PATCH] drm/amd/pm: suppress static checker warning

2020-08-26 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: Quan, Evan Sent: Tuesday, August 25, 2020 11:32 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; dan.carpen...@oracle.com ; Quan, Evan Subject: [PATCH] drm/amd

Re: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled

2020-08-25 Thread Deucher, Alexander
[AMD Public Use] I can do that. Alex From: Chen, Guchun Sent: Tuesday, August 25, 2020 10:13 AM To: Alex Deucher ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled

Re: [PATCH] drm/amd/display: Add DPCS regs for dcn3 link encoder

2020-08-24 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: Bhawanpreet Lakha Sent: Monday, August 24, 2020 11:11 AM To: Deucher, Alexander Cc: Siqueira, Rodrigo ; Kazlauskas, Nicholas ; amd-gfx@lists.freedesktop.org ; Lakha, Bhawanpreet

Re: [PATCH 1/2] drm/amdkfd: call amdgpu_amdkfd_get_unique_id directly

2020-08-24 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Felix Kuehling Sent: Monday, August 24, 2020 10:21 AM To: amd-gfx@lists.freedesktop.org Cc: Lin, Amber ; Shikre, Divya Subject: [PATCH 1/2]

Re: [PATCH 1/3] drm/amd/pm: correct Vega10 swctf limit setting

2020-08-21 Thread Deucher, Alexander
@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 1/3] drm/amd/pm: correct Vega10 swctf limit setting Correct the Vega10 thermal swctf limit. Change-Id: I220c18bcb0772bfb8cb674337bac6dccafbd7698 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_thermal.c

Re: TTM/nouveau conflict in drm-misc-next

2020-08-18 Thread Deucher, Alexander
[AMD Public Use] Double check for mis-merges on patches that went upstream via -fixes and -next. Alex From: Christian König Sent: Tuesday, August 18, 2020 11:06 AM To: Thomas Zimmermann ; Koenig, Christian ; Alex Deucher Cc: Deucher, Alexander ; amd-gfx

Re: [PATCH] Revert "drm/amdgpu: disable gfxoff for navy_flounder"

2020-08-17 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Jiansong Chen Sent: Monday, August 17, 2020 10:45 AM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Feng, Kenneth ; Chen, Jiansong (Simon) Subject: [PATCH] Revert "drm/amdgpu: disable

Re: [PATCH 1/5] drm/amd/pm: disable/enable deep sleep features on UMD pstate enter/exit

2020-08-17 Thread Deucher, Alexander
[AMD Public Use] You can probably just squash patches 2-5 into one patch. Either way, series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Monday, August 17, 2020 4:29 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject

Re: [PATCH 1/5] drm/amd/pm: disable/enable gfx ulv on UMD pstate enter/exit

2020-08-17 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] You can probably just squash patches 2-5 into one patch. Either way, series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Monday, August 17, 2020 3:49 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher

Re: [PATCH] drm/amdgpu: Fix incorrect return value in sysfs for pp_od_clk_voltage

2020-08-14 Thread Deucher, Alexander
[AMD Public Use] No need to apologize, it was a good catch. Something to double check in the future if something similar ends up getting applied again. Thanks! Alex From: amd-gfx on behalf of Matt Coffin Sent: Friday, August 14, 2020 3:13 PM To:

Re: [PATCH] drm/amdgpu/jpeg: remove redundant check when it returns

2020-08-13 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Leo Liu Sent: Thursday, August 13, 2020 3:40 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Leo Subject: [PATCH] drm/amdgpu/jpeg: remove redundant check when it returns Fix warning from

Re: [PATCH] drm/amdgpu: load ta firmware for navy_flounder

2020-08-12 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Bhawanpreet Lakha Sent: Wednesday, August 12, 2020 4:17 PM To: Kazlauskas, Nicholas ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Clements, John ; Lakha, Bhawanpreet Subject: [PATCH] drm/amdgpu

Re: [PATCH] drm/amdkfd: fix the wrong sdma instance query for renoir

2020-08-11 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Huang Rui Sent: Tuesday, August 11, 2020 2:27 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Huang, Ray Subject: [PATCH] drm/amdkfd: fix the wrong sdma instance query for

Re: [PATCH] drm/amd/powerplay: bump NAVI12 driver if version

2020-08-11 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Quan, Evan Sent: Monday, August 10, 2020 11:37 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/powerplay: bump NAVI12 driver if version To fit the latest SMU

Re: [PATCH 1/2] drm/amd/powerplay: update the metrics table cache interval as 1ms

2020-08-11 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Monday, August 10, 2020 11:35 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 1/2] drm/amd/powerplay: update the metrics table cache interval

Re: [PATCH] drm/amd/powerplay: correct Vega20 cached smu feature state

2020-08-07 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: Quan, Evan Sent: Friday, August 7, 2020 5:30 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kuehling, Felix ; Quan, Evan Subject: [PATCH] drm/amd/powerplay

Re: [PATCH] drm/amd/powerplay: correct UVD/VCE PG state on custom pptable uploading

2020-08-07 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: Quan, Evan Sent: Friday, August 7, 2020 5:31 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/powerplay: correct UVD/VCE PG

Re: [PATCH 1/1] drm/ttm: fix offset in VMAs with a pg_offs in ttm_bo_vm_access

2020-07-29 Thread Deucher, Alexander
[AMD Public Use] Christian, Can you cc stable when you apply it to drm-misc? Alex From: Kuehling, Felix Sent: Wednesday, July 29, 2020 10:15 AM To: Koenig, Christian ; dri-de...@lists.freedesktop.org ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander Cc

Re: [PATCH] drm/amdgpu: reconfigure spm golden settings on Navi1x after GFXOFF exit(v2)

2020-07-29 Thread Deucher, Alexander
Are any of those situations really time sensitive? Otherwise, I think we'll end up having to patch this in everywhere we want SPM to be consistent. Alex From: Yin, Tianci (Rico) Sent: Tuesday, July 28, 2020 10:26 PM To: Deucher, Alexander ; amd-gfx

Re: [PATCH] drm/amdgpu: reconfigure spm golden settings on Navi1x after GFXOFF exit(v2)

2020-07-28 Thread Deucher, Alexander
; Deucher, Alexander ; Zhang, Hawking ; Xu, Feifei ; Hesik, Christopher ; Swamy, Manjunatha ; Quan, Evan ; Chen, Guchun ; Feng, Kenneth ; Yin, Tianci (Rico) Subject: [PATCH] drm/amdgpu: reconfigure spm golden settings on Navi1x after GFXOFF exit(v2) From: "Tianci.Yin" On Navi1x, the

Re: [PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

2020-07-27 Thread Deucher, Alexander
n ; Koenig, Christian ; Deucher, Alexander ; Xiao, Jack ; Zhang, Hawking ; Xu, Feifei ; Wang, Kevin(Yang) ; Yuan, Xiaojie ; Liu, Cheng Zhe Subject: [PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV From: root 1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; 2. Check pointer befo

Re: [PATCH] drm/amd/amdgpu: Fix compiler warning in df driver

2020-07-22 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Tom St Denis Sent: Wednesday, July 22, 2020 7:40 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH] drm/amd/amdgpu: Fix compiler

Re: [PATCH 6/6] drm/amdgpu/sienna_cichlid: add SMU i2c support

2020-07-21 Thread Deucher, Alexander
: Deucher, Alexander Subject: Re: [PATCH 6/6] drm/amdgpu/sienna_cichlid: add SMU i2c support Looks like same code as arcturus - should we make it common helper code and reuse in both ? Andrey On 7/21/20 12:52 PM, Alex Deucher wrote: > Enable SMU i2c bus access for sienna_cichlid asics. > &g

Re: [PATCH 5/6] drm/amdgpu/navi1x: add SMU i2c support

2020-07-21 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Ignore this. Sent out the wrong version. Alex From: Alex Deucher Sent: Tuesday, July 21, 2020 12:52 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 5/6] drm/amdgpu/navi1x: add

Re: [PATCH] drm/amd/powerplay: suppress compile error around BUG_ON

2020-07-15 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Quan, Evan Sent: Wednesday, July 15, 2020 2:52 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/powerplay: suppress compile error around BUG_ON To suppress

Re: Failed to find memory space for buffer eviction

2020-07-15 Thread Deucher, Alexander
[AMD Public Use] Maybe we should re-test the problematic piglit test and if it's no longer an issue, revert: commit 24562523688bebc7ec17a88271b4e8c3fc337b74 Author: Andrey Grodzovsky Date: Fri Dec 15 12:09:16 2017 -0500 Revert "drm/amd/amdgpu: set gtt size according to system memory

Re: [PATCH 13/16] drm/amd/powerplay: apply gfxoff disablement/enablement for all SMU11 ASICs

2020-07-14 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Quan, Evan Sent: Tuesday, July 14, 2020 2:55 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH 13/16] drm/amd/powerplay: apply gfxoff disablement/enablement for all SMU11 ASICs

Re: [PATCH 2/5] drm/amdgpu: optimize rlcg write for gfx_v10

2020-07-14 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Jack Zhang Sent: Monday, July 13, 2020 10:46 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) ; Liu, Leo ; Zhang, Hawking Subject: [PATCH 2/5]

Re: [PATCH 1/5] drm/amd/sriov skip jped ip block and close pgcg flags

2020-07-14 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Jack Zhang Sent: Monday, July 13, 2020 10:45 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) ; Liu, Leo ; Zhang, Hawking Subject: [PATCH 1/5] drm/amd/sriov skip jped ip block and

Re: [PATCH] drm/amd/display: Fix compilation error on dcn3

2020-07-14 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Siqueira, Rodrigo Sent: Tuesday, July 14, 2020 8:06 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Deucher, Alexander ; Teng, Rui ; Laktyushkin, Dmytro ; Kazlauskas, Nicholas

Re: [PATCH] drm/amd/display: add dmcub check on RENOIR

2020-07-08 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Aaron Ma Sent: Wednesday, July 8, 2020 4:16 AM To: Wentland, Harry ; Li, Sun peng (Leo) ; Deucher, Alexander ; Koenig, Christian ; airl...@linux.ie ; dan...@ffwll.ch ; amd-gfx@lists.freedesktop.org ; dri-de

Re: [PATCH] drm/amdgpu/swSMU: drop pm_enabled check in set mp1 state

2020-07-07 Thread Deucher, Alexander
[AMD Public Use] Ah, yes, indeed. Thanks, Alex From: Quan, Evan Sent: Monday, July 6, 2020 9:31 PM To: Alex Deucher ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu/swSMU: drop pm_enabled check in set mp1 state [AMD

Re: [PATCH 2/2] drm/amdgpu: add TMR destory function for psp

2020-06-30 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Huang Rui Sent: Tuesday, June 30, 2020 6:30 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: [PATCH 2/2] drm/amdgpu: add TMR destory function for psp TMR is

Re: [PATCH] drm/amdgpu: correct discovery_tmr_size init val

2020-06-29 Thread Deucher, Alexander
[AMD Public Use] You might want to add a comment to the code here. It looks wrong to use the OFFSET. Alex From: amd-gfx on behalf of Wenhui.Sheng Sent: Monday, June 29, 2020 2:07 AM To: amd-gfx@lists.freedesktop.org Cc: Sheng, Wenhui ; Zhang, Hawking

Re: [PATCH 3/3] drm/amdgpu: SI support for UVD and VCE power managment

2020-06-24 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Jivin, Alex Sent: Wednesday, June 24, 2020 4:31 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 3/3] drm/amdgpu: SI support for UVD and VCE power managment Port

Re: [PATCH 1/2] drm/amd/powerplay: change method to set board parameters

2020-06-24 Thread Deucher, Alexander
[AMD Public Use] Series is: Acked-by: Alex Deucher From: amd-gfx on behalf of Likun Gao Sent: Wednesday, June 24, 2020 2:35 AM To: amd-gfx@lists.freedesktop.org Cc: Gao, Likun ; Feng, Kenneth ; Zhang, Hawking Subject: [PATCH 1/2] drm/amd/powerplay: change

Re: [PATCH 1/1] drm/amd/powerplay: Fix DCEFCLK related compilation error for arcturus

2020-06-23 Thread Deucher, Alexander
[AMD Public Use] No problem. Reviewed-by: Alex Deucher From: Das, Nirmoy Sent: Tuesday, June 23, 2020 12:04 PM To: Nirmoy Das ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Das, Nirmoy Subject: Re: [PATCH 1/1] drm/amd/powerplay: Fix DCEFCLK

Re: [PATCH 1/1] drm/amd/powerplay: return current DCEFCLK on sysfs read

2020-06-23 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Nirmoy Das Sent: Tuesday, June 23, 2020 5:43 AM To: amd-gfx@lists.freedesktop.org Cc: Das, Nirmoy Subject: [PATCH 1/1] drm/amd/powerplay: return current

Re: [PATCH 1/1] drm/amdgpu: remove unused functions

2020-06-18 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Nirmoy Das Sent: Thursday, June 18, 2020 10:52 AM To: amd-gfx@lists.freedesktop.org Cc: Das, Nirmoy Subject: [PATCH 1/1] drm/amdgpu: remove unused functions Remove unused

Re: [PATCH 1/4] drm/amdgpu: label internally used symbols as static

2020-06-18 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Nirmoy Das Sent: Thursday, June 18, 2020 9:17 AM To: amd-gfx@lists.freedesktop.org Cc: Das, Nirmoy Subject: [PATCH 1/4] drm/amdgpu: label internally used symbols as static Used

Re: [PATCH] drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can be static

2020-06-17 Thread Deucher, Alexander
[AMD Public Use] James, please feel free to commit this. Alex From: amd-gfx on behalf of James Zhu Sent: Wednesday, June 17, 2020 4:41 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James ; kernel test robot Subject: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amd/amdgpu: Add SQ debug registers to GFX10 headers

2020-06-09 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Might as well add it for gfx9 as well. With that fixed: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Tom St Denis Sent: Tuesday, June 9, 2020 1:59 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis,

Re: [PATCH] drm/amd/powerplay: move maximum sustainable clock retrieving to .hw_init

2020-06-08 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Quan, Evan Sent: Monday, June 8, 2020 6:46 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan ; Cui, Flora Subject: [PATCH] drm/amd/powerplay: move maximum sustainable clock retrieving

Re: [PATCH] drm/amdgpu/soc15: fix nullptr issue in soc15_read_register() for reg base accessing

2020-06-08 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: Liang, Prike Sent: Monday, June 8, 2020 3:34 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Liang, Prike Subject: [PATCH] drm/amdgpu/soc15: fix nullptr issue in soc15_read_register

Re: [PATCH 4/4] drm/amd/powerplay: use the same interval as PMFW on retrieving metrics table

2020-06-05 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Friday, June 5, 2020 2:07 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 4/4] drm/amd/powerplay: use the same interval as PMFW

Re: [PATCH 1/3] drm/amd/powerplay: stop thermal IRQs on suspend

2020-05-28 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Thursday, May 28, 2020 5:02 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 1/3] drm/amd/powerplay: stop thermal IRQs on suspend Added

Re: [PATCH] drm/amdgpu: Improve the MTYPE comments

2020-05-27 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yong Zhao Sent: Tuesday, May 26, 2020 8:57 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH] drm/amdgpu: Improve the MTYPE comments Use words insteads of acronym for

Re: [PATCH 1/2] drm/amd/powerplay: remove the support of xgmi pstate on vega20 from swsmu

2020-05-20 Thread Deucher, Alexander
[AMD Public Use] Series is: Reviewed-by: Alex Deucher From: Wang, Kevin(Yang) Sent: Tuesday, May 19, 2020 11:50 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Wang, Kevin(Yang) Subject: [PATCH 1/2] drm/amd/powerplay: remove

Re: [PATCH AUTOSEL 5.6 33/50] drm/amdgpu: bump version for invalidate L2 before SDMA IBs

2020-05-19 Thread Deucher, Alexander
; dri-devel ; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH AUTOSEL 5.6 33/50] drm/amdgpu: bump version for invalidate L2 before SDMA IBs Hi Sasha, I disagree with this. Bumping the driver version will have implications on other new features, because it's like an ABI barrier exposing

Re: [PATCH] drm/amdgpu: turn back rlcg write for gfx_v10

2020-05-12 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Yintian Tao Sent: Tuesday, May 12, 2020 6:17 AM To: Deucher, Alexander ; Liu, Monk ; Liu, Shaoyun Cc: amd-gfx@lists.freedesktop.org ; Tao, Yintian Subject: [PATCH] drm/amdgpu: turn back rlcg write for gfx_v10

<    1   2   3   4   5   6   7   8   9   10   >