X86-1
(2020-10-22 11:06:49 +0300)
Kalle Valo (11):
ath10k: QCA6174 hw3.0: update firmware-6.bin to
WLAN.RM.4.4.1-00157-QCARMSWPZ-1
ath10k: QCA6174 hw3.0: update board-2.bin
ath10k: QCA9888 hw2.0: update firmware-5.bin to
Kalle Valo writes:
> Hi linux-firmware maintainers,
>
> here's a pull request for ath10k and ath11k drivers. For ath10k there
> is a firmware for new hardware QCA6174 hw3.0 SDIO. For ath11k there
> are firmwares for new hardware IPQ8074 hw2.0, IPQ6018 hw1.0 and
> QCA6
.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
(2020-10-23 18:42:08 +0300)
----
Kalle Valo (11):
ath10k: QCA6174 hw3.0: update firmware-6.bin to
WLAN.RM.4.4.1-00157-QCARMSWPZ-1
ath10k: QCA6174 hw3.0: update board-2.bin
ath10k: QCA98
Latest checkpatch complains about use of fall-through comment. But as this is a
switch statement just reword the comment to workaround the problem.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net
Found by latest checkpatch.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.c| 2 +-
drivers/net/wireless/ath/ath10k/debug.c | 2 +-
drivers/net/wireless/ath/ath10k/mac.c | 2 +-
drivers/net/wireless/ath/ath10k/rx_desc.h | 2 +-
drivers/net/wireless/ath/ath10k
Kalle Valo wrote:
> Found by latest checkpatch.
>
> Signed-off-by: Kalle Valo
2 patches applied to ath-next branch of ath.git, thanks.
762fd1aec588 ath10k: remove repeated words in comments
d2f3f68864a4 ath10k: ath10k_pci_init_irq(): workaround for checkpatch
fallthrough warning
> Cc: Joerg Roedel
> Cc: Thomas Gleixner
> Cc: Jason Cooper
> Cc: Marc Zyngier
> Cc: Linus Walleij
> Cc: Vinod Koul
> Cc: Kalle Valo
> Cc: Maulik Shah
> Cc: Lina Iyer
> Cc: Saravana Kannan
> Cc: Todd Kjos
> Cc: Greg Kroah-Hartman
> Cc: linux-arm-...
+ ath10k list
Dan Carpenter writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 3cea11cd5e3b00d91caf0b4730194039b45c5891
> commit: 7b2531d93bac6bea67e9c7f49901e9e8796d6d57 ath10k: Add new api to
> support TID specific configuration
> config:
Christian Lamparter writes:
> Hello,
>
> On 2020-09-15 17:02, Hans Geiblinger wrote:
>> The support for this device is currently being added into OpenWrt. This AP
>> requires
>> two special BDFs to get the Wi-Fi PHYs working (correctly).
>>
>> * description for what hardware this is:
>>
>>-
Brian Norris writes:
> + ath10k
>
> [ I realize I replied to the "wrong" RFC v1; I fell trap to Kalle's note:
>
> "When you submit a new version mark it as "v2". Otherwise people don't
> know what's the latest version." ]
>
> On Tue, Nov 3, 2020 at 11:32 PM Carl Huang wrote:
>> On 2020-11-04 10:
ine for clarity
>
> Addresses-Coverity: 1496984 ("Null pointer dereferences)
> Suggested-by: Saeed Mahameed
> Signed-off-by: Alex Dewar
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
dbeb101d28eb ath10k: sdio: remove redundant check in for loop
--
h
Abhishek Kumar wrote:
> In some devices difference in chip-id should be enough to pick
> the right BDF. Add another support for chip-id based BDF selection.
> With this new option, ath10k supports 2 fallback options.
>
> The board name with chip-id as option looks as follows
> board name 'bus=sn
"Rakesh Pillai" writes:
>> > diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> > index 932266d..3b49e29 100644
>> > --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> > +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> > @@ -1404,9 +1404,12
Rakesh Pillai writes:
> The wmi service available event has been
> extended to contain extra 128 bit for new services
> to be indicated by firmware.
>
> Currently the presence of any optional TLVs in
> the wmi service available event leads to a parsing
> error with the below error message:
> ath1
Doug Anderson writes:
>> static int ath10k_wmi_tlv_op_pull_svc_avail(struct ath10k *ar,
>> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c
>> b/drivers/net/wireless/ath/ath10k/wmi.c
>> index 1fa7107..2e4b561 100644
>> --- a/drivers/net/wireless/ath/ath10k/wmi.c
>> +++ b/drivers/net/wireless/
Wen Gong writes:
> The rx worker of SDIO should be cancelled after disable interrupt, and
> release rx sk_buff in queue, otherwise the rx worker maybe still run
> after hif_stop. And it should be cancelled before napi_synchronize in
> hif_stop, because the rx worker of SDIO will call napi_schedul
--
>
> Similar logic was tested for years in ath10k-ct driver and various firmware.
>
> Also tested with stock kernel plus this patch, with firmware
> 10.2.4-1.0-00037
>
> This test case was to bring up 5 vap on a radio and fake a firmware
> crash. Make sure ap interfaces co
> Reported-by: kernel test robot
> Reported-by: Dan Carpenter
> Signed-off-by: Tamizh Chelvam
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
b91626451178 ath10k: fix compilation warning
--
https://patchwork.kernel.org/project/linux-wireles
IO will call napi_schedule, it
> should have no napi_schedule before napi_synchronize, otherwise it
> lead napi_synchronize wait untill napi_complete.
>
> Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to a
t...@redhat.com wrote:
> From: Tom Rix
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix
Patch applied to wireless-drivers-next.git, thanks.
3287953b0399 wireless: remove unneeded break
--
https://patchwork.kernel.org/project/linux-wireless/patch/2020102012
Abhishek Kumar writes:
> Apologies for the delay, was busy so could not work on V2 . I have
> started working on V2 patch. Will upload by today/tomorrow.
Thanks, I'll then drop this v1.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers
+ ath10k list
kernel test robot writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1
> commit: 3c45f21af84eb05a355919abc80cf70a3a681cee ath10k: sdio: add
> firmware coredump support
> compiler: nios2-lin
Jani Nikula writes:
> Now that relay_open() accepts const callbacks, make relay callbacks
> const.
>
> Cc: Kalle Valo
> Cc: ath10k@lists.infradead.org
> Signed-off-by: Jani Nikula
I assume this goes via some other tree:
Acked-by: Kalle Valo
--
https://patchwork.kernel
.nik...@intel.com
>
>
> Cc: linux-bl...@vger.kernel.org
> Cc: Jens Axboe
> Cc: ath...@lists.infradead.org
> Cc: ath10k@lists.infradead.org
> Cc: Kalle Valo
> Cc: linux-wirel...@vger.kernel.org
> Cc: QCA ath9k Development
> Cc: intel-...@lists.freedesktop.org
ing hif_memcpy.
>
> This IRAM recovery feature prevent target assert in case of
> unexpected target IRAM corruptions.
>
> This patch also introduce a new feature flag 'iram-recovery' for
> backward compatibility.
>
> Tested-on: QCA9888 10.4-3.9.0.2-00094
>
>
Jakub Kicinski writes:
> On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote:
>> These are only used as input arguments to qmi_handle_init() which
>> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
>> const to allow the compiler to put them in read-only memory.
>>
>>
AN.HL.3.2.2-00720-QCAHLSWMTPL-1
>
> Fixes: cea19a6ce8bf ("ath10k: add WMI_SERVICE_AVAILABLE_EVENT support")
> Signed-off-by: Rakesh Pillai
> Reviewed-by: Douglas Anderson
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
c7cee9c0f499
Doug Anderson writes:
> Hi,
>
> On Sun, Nov 15, 2020 at 8:35 PM Rakesh Pillai wrote:
>>
>> The wmi service available event has been
>> extended to contain extra 128 bit for new services
>> to be indicated by firmware.
>>
>> Currently the presence of any optional TLVs in
>> the wmi service availa
Christophe JAILLET wrote:
> If 'ath10k_usb_create()' fails, we should release some resources and report
> an error instead of silently continuing.
>
> Fixes: 4db66499df91 ("ath10k: add initial USB support")
> Signed-off-by: Christophe JAILLET
> Signed-off
: Rikard Falkeborn
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
ad37a46e8cb5 ath10k: Constify static qmi structs
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201122234031.33432-3-rikard.falkeb...@gmail.com/
https://wireless.wiki.ker
zhoulian...@126.com wrote:
> From: lzhou
The subject and commit log is badly formatted, see patchwork link below.
But how is schedule_timeout_interruptible() better than msleep()?
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201203033729.38208
on]
> return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW;
>
> Reported-by: kernel test robot
>
> Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
7f881a721716 ath10k: fix a check pa
Brian Norris writes:
> On Thu, Nov 26, 2020 at 9:16 AM Youghandhar Chintala
> wrote:
>> --- a/drivers/net/wireless/ath/ath10k/snoc.c
>> +++ b/drivers/net/wireless/ath/ath10k/snoc.c
>> @@ -1790,9 +1790,6 @@ static int ath10k_snoc_remove(struct platform_device
>> *pdev)
>>
>> reinit_compl
Bjorn Andersson writes:
> On Tue 03 Nov 01:48 CST 2020, Amit Pundir wrote:
>
>> Hi Rob, Bjorn, Kalle,
>>
>> On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson
>> wrote:
>> >
>> > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote:
>> >
>> > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote:
t; board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320'
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1
> Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1
> Signed-off-by: Abhishek Kumar
> Reviewed-by: Douglas Anderson
> Reviewed-by: Rakesh
Krishna Chaitanya writes:
> On Fri, Aug 28, 2020 at 5:53 PM Wen Gong wrote:
>>
>> It happened "Kernel panic - not syncing: hung_task: blocked tasks" when
>> test simulate crash and ifconfig down/rmmod meanwhile.
(editing out hundreds of lines of unnecessary text, please edit your quotes)
> LGT
Wen Gong writes:
> On 2020-09-08 00:22, Kalle Valo wrote:
>
>> Just like with the recent firmware restart patch, isn't
>> ar->napi_enabled
>> racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer?
>>
>> Or are we holdin
Zheng Yongjun writes:
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun
> ---
> drivers/net/wireless/ath/ath10k/ahb.c | 8 +---
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/ahb.c
> b/drivers/net/wireless/ath/ath10k/ahb.c
t; board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320'
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1
> Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1
> Signed-off-by: Abhishek Kumar
> Reviewed-by: Douglas Anderson
> Reviewed-by: Rake
O WLAN.RMH.4.4.1-00049
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
5dadbe4e3718 ath10k: add atomic protection for device recovery
--
https://patchwork.kernel.org/project/linux-wireless/patch/010101746bead6a0-d5e97c66-dedd-4
Ben Greear writes:
> On 12/9/20 1:24 AM, Kalle Valo wrote:
>> Wen Gong writes:
>>
>>> On 2020-09-08 00:22, Kalle Valo wrote:
>>>
>>>> Just like with the recent firmware restart patch, isn't
>>>> ar->napi_enabled
>>
Wen Gong writes:
> On 2020-12-09 23:00, Ben Greear wrote:
>> On 12/9/20 1:24 AM, Kalle Valo wrote:
>>> Wen Gong writes:
>>>
>>>> On 2020-09-08 00:22, Kalle Valo wrote:
>>>>
>>>>> Just like with the recent firmware restart patch,
Hi,
ath10k and ath11k list archives are now available from lore.kernel.org:
https://lore.kernel.org/ath10k/
https://lore.kernel.org/ath11k/
They have full archives starting when lists were created (ath10k 2013
and ath11k 2019). So I recommend using lore archives over
lists.infradead.org as infr
wer on/off in SNOC targets, so that these voltage
> regulator votes are there only when wlan is enabled.
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
>
> Signed-off-by: Rakesh Pillai
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git,
45af5b264f ("ath10k: enable SRRI/DRRI support on ddr for WCN3990")
> Signed-off-by: Rakesh Pillai
> Reviewed-by: Brian Norris
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
31561e8557cd ath10k: Fix error handling in case of CE pipe init failure
ED, and then napi_synchronize will enter dead loop
> becuase bit NAPI_STATE_SCHED is set by napi_disable.
>
> function of napi_synchronize
> static inline void napi_synchronize(const struct napi_struct *n)
> {
> if (IS_ENABLED(CONFIG_SMP))
> while (test_bit(NAP
Pradeep Kumar Chitrapu wrote:
> Issues wmi command to firmware when multicast rate change is received
> with the new BSS_CHANGED_MCAST_RATE flag.
>
> Signed-off-by: Pradeep Kumar Chitrapu
(Cleaning up my backlog, this is from 2018.) I don't understand the
issue from commit log, please clarify
Zekun Shen writes:
> Function ep_rx_complete is being called without NULL checking
> in ath10k_htc_rx_completion_handler. Without such check, mal-
> formed packet is able to cause jump to NULL.
>
> ep->service_id seems a good candidate for sanity check as it is
> used in usb.c.
>
> Signed-off-by:
It's unused so let's get rid of it. Compile tested only, no functional changes.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.h
b/drivers/net/wireless/ath/ath10k/co
Isaac Hermida writes:
> This is needed to have the AP mode working for SDIO.
> Tested with lastest master/pending code on a QCA6564 chip with firmware
> firmware-sdio-6.bin_WLAN.RMH.4.4.1-00011-QCARMSWP-2
>
> Signed-off-by: Isaac Hermida
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>
gree...@candelatech.com wrote:
> From: Ben Greear
>
> This makes per-chain RSSI be more consistent between HT20, HT40, HT80.
> Instead of doing precise log math for adding dbm, I did a rough estimate,
> it seems to work good enough.
>
> Tested on ath10k-ct 9984 firmware.
>
> Signed-off-by: Ben
Rakesh Pillai writes:
> This patch series includes some fixes when the device
> is in recovery mode, i.e. when the firmware goes down.
>
> - Pausing TX queues when FW goes down
> - Removed unwanted/extra error logging in pkt TX path
> - Skipping wait for FW response for delete cmds
> - Handling t
Brian Norris writes:
> Hi,
>
> On Sun, Dec 20, 2020 at 5:53 PM Miaoqing Pan wrote:
>>
>> Failed to transmit wmi management frames:
>>
>> [84977.840894] ath10k_snoc a00.wifi: wmi mgmt tx queue is full
>> [84977.840913] ath10k_snoc a00.wifi: failed to transmit packet,
>> dropping: -28
>>
Brian Norris writes:
> On Mon, Dec 21, 2020 at 7:43 PM Wen Gong wrote:
>>
>> On 2020-12-21 05:06, Sustek Goran wrote:
>> > Hi, on my ath10k Chipset,
>> > QCA9984(https://compex.com.sg/shop/wifi-module/802-11ac-wave-2/wle1216v5-20-2/)
>> > afetr this patch i can not longer to initialize my card.
Abhishek Kumar writes:
> On Tue, Dec 15, 2020 at 9:24 AM Youghandhar Chintala
> wrote:
>>
>> From: Rakesh Pillai
>>
>> Currently after the hardware restart triggered from the driver,
>> the station interface connection remains intact, since a disconnect
>> trigger is not sent to userspace. This
sb.c.
>
> Signed-off-by: Zekun Shen
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
d18ba9f1351c ath10k: sanitity check for ep connectivity
--
https://patchwork.kernel.org/project/linux-wireless/patch/20200622022055.16028-1-bruceshe...@gmail.com/
https
Ben Greear.
>
> Link: https://github.com/greearb/ath10k-ct/issues/89
> Link:
> https://github.com/greearb/ath10k-ct/commit/9e5ab25027e0971fa24ccf93373324c08c4e992d
> Cc: Ben Greear
> Signed-off-by: Linus Lüssing
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of
gt; So remove ar->data_lock, and use 'skb_queue_tail' instead of
> '__skb_queue_tail' to prevent the potential race condition.
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1.c2-00033-QCAHLSWMTPLZ-1
>
> Signed-off-by: Miaoqing Pan
> Signed-off-by: K
Kalle Valo wrote:
> It's unused so let's get rid of it. Compile tested only, no functional
> changes.
>
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
4c239f012f7b ath10k: remove unused struct ath10k::dev_type
--
https://patchwork.ke
eature is controlled by hw parameter: dynamic_sar_support.
>
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
>
> Signed-off-by: Carl Huang
> Reviewed-by: Brian Norris
> Reviewed-by: Abhishek Kumar
> Reported-by: kernel test robot
> Signed-off-by: Kalle Valo
eature is controlled by hw parameter: dynamic_sar_support.
>
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
>
> Signed-off-by: Carl Huang
> Reviewed-by: Brian Norris
> Reviewed-by: Abhishek Kumar
> Reported-by: kernel test robot
> Signed-off-by: Kalle
Dan Carpenter writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
> head: 13112a10a90ece17774a25bc363a7561c26aa19f
> commit: c995c0bdf2d68ce279507a2017e1e65e823339df [10/12] ath10k: allow
> dynamic SAR power limits via common API
> config: x86_64-randconfig-m
eature is controlled by hw parameter: dynamic_sar_support.
>
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
>
> Signed-off-by: Carl Huang
> Reviewed-by: Brian Norris
> Reviewed-by: Abhishek Kumar
> Reported-by: kernel test robot
> Signed-off-by: Kalle Valo
In
eature is controlled by hw parameter: dynamic_sar_support.
>
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
>
> Signed-off-by: Carl Huang
> Reviewed-by: Brian Norris
> Reviewed-by: Abhishek Kumar
> Reported-by: kernel test robot
> Signed-off-by: Kalle Valo
Patch
de with QCA6174 hw3.2 PCI, it is success start/connect/ping for
> WPA/OPEN mode.
>
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
22df5e1bec25 ath10k: p
> So remove ar->data_lock, and use 'skb_queue_tail' instead of
> '__skb_queue_tail' to prevent the potential race condition. Also switch
> to use skb_queue_len_lockless, in case we queue a few SKBs simultaneously.
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1.c2-00
hx is useless
> so do not encourage the use of %hh[xudi] or %h[xudi].
>
> Signed-off-by: Tom Rix
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
779750bb153d ath10k: remove h from printk format specifier
--
https://patchwork.kernel.org/project/linux-wire
Amit Pundir writes:
> Hi Kalle,
>
> On Mon, 7 Dec 2020 at 22:25, Kalle Valo wrote:
>>
>> This is firmware version specific, right? There's also enum
>> ath10k_fw_features which is embedded within firmware-N.bin, we could add
>> a new flag there. But that
t; __do_softirq+0x2d3/0x539
> run_ksoftirqd+0x4b/0x86
> smpboot_thread_fn+0x1d0/0x2ab
> ? cpu_report_death+0x7f/0x7f
> kthread+0x189/0x191
> ? cpu_report_death+0x7f/0x7f
> ? kthread_blkcg+0x31/0x31
> ret_from_fork+0x22/0x30
>
> Fixes: 0f7cb26830a6e ("ath
o_syscall_64+0x43/0x55
> entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> Fixes: 4913e675630e ("ath10k: enable rx duration report default for wmi tlv")
> Signed-off-by: Anand K Mistry
> Signed-off-by: Kalle Valo
Patch applied to ath-n
Chelvam
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
97614c59cb72 ath10k: Add new debug level for sta related logs
--
https://patchwork.kernel.org/project/linux-wireless/patch/1612463738-16542-1-git-send-email-tami...@codeaurora.org/
https://wireless.wi
Wen Gong wrote:
> Kernel panic every time in kernel when running below case:
> steps:
> 1. connect to an AP with good signal strength
> 2. echo 0x7f > /sys/kernel/debug/ieee80211/phy0/ath10k/pktlog_filter
> 3. echo 0x 0 > /sys/kernel/debug/ieee80211/phy0/ath10k/fw_dbglog
> 4. echo 0 > /sys/mo
Bjorn Andersson writes:
> On Mon 08 Feb 11:21 CST 2021, Kalle Valo wrote:
>
>> Amit Pundir writes:
>>
>> > Hi Kalle,
>> >
>> > On Mon, 7 Dec 2020 at 22:25, Kalle Valo wrote:
>> >>
>> >> This is firmware version specific
+ ath10k list
Peter Zijlstra writes:
> On Mon, Feb 08, 2021 at 08:04:27PM +0100, Rafael J. Wysocki wrote:
>> Hi Peter & Paul,
>>
>> The traces below are present in the boot dmesg log on my Dell XPS13 9360.
>>
>> I haven't had the time to look into this in detail yet, but here it goes in
>> cas
"Rafael J. Wysocki" writes:
>> > AFAICT that's a simple 'use RCU without holding rcu_read_lock' warning.
>> > I've not dug through ath10k to see who should be doing rcu_read_lock,
>> > but the few places I did look at don't seem to have changed recently.
>>
>> Just this morning I applied a patch
Shuah Khan wrote:
> ath10k_debug_fw_stats_request() is called ath10k_sta_statistics()
> without holding conf_mutex. ath10k_debug_fw_stats_request() simply
> returns when CONFIG_ATH10K_DEBUGFS is disabled.
>
> When CONFIG_ATH10K_DEBUGFS is enabled, ath10k_debug_fw_stats_request()
> code path isn'
Shuah Khan wrote:
> ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and
> the resulting pointer is only valid under RCU lock as well.
>
> Fix ath10k_wmi_tlv_parse_peer_stats_info() to hold RCU lock before it
> calls ieee80211_find_sta_by_ifaddr() and release it when the resultin
Shuah Khan writes:
> ath10k_drain_tx() must not be called with conf_mutex held as workers can
> use that also. Add check to detect conf_mutex held calls.
>
> Signed-off-by: Shuah Khan
The commit log does not answer to "Why?". How did you find this? What
actual problem are you trying to solve?
Wen Gong writes:
> On 2021-02-10 08:42, Shuah Khan wrote:
>> ath10k_mac_get_rate_flags_ht() floods dmesg with the following
>> messages,
>> when it fails to find a match for mcs=7 and rate=1440.
>>
>> supported_ht_mcs_rate_nss2:
>> {7, {1300, 2700, 1444, 3000} }
>>
>> ath10k_pci :02:00.0: in
n0: send auth to 5e:6f:2b:0d:fb:d7 (try 2/3)
> [ 216.745874] wlan0: send auth to 5e:6f:2b:0d:fb:d7 (try 3/3)
>
> Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
83bae26532ca ath10k: change ath10k_offchan_tx_work() peer present msg to a warn
--
https://patchwork.kernel.org/project/linux-wireless/patch/3b1f71272d56ee1d7f567fbce13bdb56cc06d342.1612915444.git.sk...@linuxfoun
Shuah Khan writes:
> On 2/10/21 1:25 AM, Kalle Valo wrote:
>> Shuah Khan writes:
>>
>>> ath10k_drain_tx() must not be called with conf_mutex held as workers can
>>> use that also. Add check to detect conf_mutex held calls.
>>>
>>> Signed-off-b
Shuah Khan writes:
> On 2/10/21 1:28 AM, Kalle Valo wrote:
>> Wen Gong writes:
>>
>>> On 2021-02-10 08:42, Shuah Khan wrote:
>>>> ath10k_mac_get_rate_flags_ht() floods dmesg with the following
>>>> messages,
>>&g
gt; Signed-off-by: Shuah Khan
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
09078368d516 ath10k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210210212107.40373-1-sk...@linuxfoundat
worker routines try
> to call this routine.
>
> Link: https://lore.kernel.org/linux-wireless/871rdmu9z9@codeaurora.org/
> Signed-off-by: Shuah Khan
This can go via the same tree as patch 1:
Acked-by: Kalle Valo
But I can also take this to my ath tree, once patch 1 has reac
Peter Zijlstra writes:
> On Fri, Feb 26, 2021 at 05:06:57PM -0700, Shuah Khan wrote:
>> Shuah Khan (3):
>> lockdep: add lockdep_assert_not_held()
>> lockdep: add lockdep lock state defines
>> ath10k: detect conf_mutex held ath10k_drain_tx() calls
>
> Thanks!
Via which tree should these go?
Peter Zijlstra writes:
> On Mon, Mar 01, 2021 at 10:45:32AM +0200, Kalle Valo wrote:
>> Peter Zijlstra writes:
>>
>> > On Fri, Feb 26, 2021 at 05:06:57PM -0700, Shuah Khan wrote:
>> >> Shuah Khan (3):
>> >> lockdep: add lockdep_assert_no
oughandhar Chintala
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
018e3fa8e7ff ath10k: skip the wait for completion to recovery in shutdown path
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210223142908.23374-1-yough...@codeaurora.or
e_skb was freed.
>
> Fixes: c8334512f3dd1 ("ath10k: add htt TX bundle for sdio")
> Signed-off-by: Lv Yunlong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
8392df5d7e0b ath10k: Fix a use after free in ath10k_htc_send_bundle
--
https://
quot;ath10k: hold RCU lock when calling
> ieee80211_find_sta_by_ifaddr()")
> Reported-by: Pavel Machek
> Signed-off-by: Shuah Khan
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
eaaf52e4b866 ath10k: Fix ath10k_wmi_tlv_op_pull_p
Bryan O'Donoghue writes:
> On 23/05/2021 14:05, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
>> head: a9cccebc0c3b91c2e5d2033d11def1e6f7fc74d4
>> commit: d1f965c7b4068af9420408f308bcc6206158b658 [16/26] wcn36xx:
>> Run suspend for the
Colin King wrote:
> There are multiple occurrances of the misspelling of requeued in
> the drivers with symbol names and debug text. Fix these.
>
> Signed-off-by: Colin Ian King
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
17818dfa8f2e ath
Caleb Connolly wrote:
> Some devices/firmwares cause this to be printed every 5-15 seconds,
> though it has no impact on functionality. Demote this to a debug
> message.
>
> Signed-off-by: Caleb Connolly
> Signed-off-by: Kalle Valo
On what hardware and firmware versi
166b2653db ("ath10k: add CCMP PN replay protection for fragmented
> frames for PCIe")
> Reported-by: Hulk Robot
> Signed-off-by: Yang Yingliang
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
e0a6120f6816 ath10k: remove unused more_frags vari
Caleb Connolly writes:
> Hi Kalle,
>
> On 12/06/2021 11:36 am, Kalle Valo wrote:
>> Caleb Connolly wrote:
>>
>>> Some devices/firmwares cause this to be printed every 5-15 seconds,
>>> though it has no impact on functionality. Demote this to a debug
&g
warn:
> missing error code 'ret'
>
> Reported-by: Abaci Robot
> Fixes: 'commit ccec9038c721 ("ath10k: enable raw encap mode and software
> crypto engine")'
> Signed-off-by: Yang Li
> Signed-off-by: Kalle Valo
Fixes tag is wrong, it should be:
Shaokun Zhang wrote:
> Functions 'ath10k_pci_free_pipes' and 'ath10k_wmi_alloc_skb'
> are declared twice in their header file, so remove the repeated
> declaration.
>
> Cc: Kalle Valo
> Signed-off-by: Shaokun Zhang
> Signed-off-by: Kalle Valo
Pa
warn:
> missing error code 'ret'
>
> Reported-by: Abaci Robot
> Fixes: ccec9038c721 ("ath10k: enable raw encap mode and software crypto
> engine")
> Signed-off-by: Yang Li
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
ea1c2023efbc ath10k: Use devm_platform_get_and_ioremap_resour
Z-1
> Tested-on: WCN3990 hw1.0 SNOC
> WLAN.HL.1.0.c6-00126-QCAHLSWMTPLZ-1.211883.1.278648
>
> Signed-off-by: Caleb Connolly
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
8a952a955de7 ath10k: demote chan info without scan request warning
--
https://patchw
1 - 100 of 3044 matches
Mail list logo