Hi, Sundar.
>>> http://cr.openjdk.java.net/~sundar/8251276/webrev.00/index.html
These changes look good.
Iris
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Nice clean-up.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/814
On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote:
> This PR proposes to remove
> 1. JavaDoc `@author` tags with unclear semantics: `@author
> unascribed|unattributed|unknown`
> 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters
Marked as reviewed by iris (Reviewer).
Hi, Leo.
Thanks for adding legal notices (copyright and license) to these resource
.property files.
For the files in src/demo/share/jfc/*.properties, is there any reason why the
legal notices should not be in a separate comment block? Right now, it appears
that you've prepended the legal noti
Hi, Leo.,
This updated webrev looks fine.
Thanks for fixing!
iris
-Original Message-
From: Leo Jiang
Sent: Tuesday, July 23, 2019 12:08 AM
To: Mandy Chung
Cc: jdk-dev ; core-libs-dev
Subject: Re: RFR: 8228397: Missing license copyright header in some resource
properties files
Than
HI, Lance.
Looks good.
I'm curious. How did you find this?
iris
-Original Message-
From: Lance Andersen
Sent: Wednesday, August 14, 2019 7:34 AM
To: core-libs-dev
Subject: RFR 8184432: Remove references to j...@sun.com from
javax.sql.rowset.spi.SyncProvider
Hi,
Please review this
Hi, Roger.
http://cr.openjdk.java.net/~rriggs/webrev-header-cleanup-8231663/
+1
Thanks,
Iris
Hi, Naoto.
> https://cr.openjdk.java.net/~naoto/8241311/webrev.06/
Looks good!
Thanks,
Iris
On Thu, 19 Nov 2020 03:44:10 GMT, Stuart Marks wrote:
> 8231547: Serializable class doc should link to serialization specification
>
> Rewrite a couple confusing sentences in the Serializable class doc. This does
> affect normative text, but the edits are primarily to focus and clarify the
> t
On Fri, 20 Nov 2020 15:08:27 GMT, Alan Bateman wrote:
>> This change terminally deprecates the following methods defined by
>> java.lang.ThreadGroup
>>
>> - stop
>> - destroy
>> - isDestroyed
>> - setDaemon
>> - isDaemon
>>
>> The stop method has been deprecated since=1.2 because it is i
On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote:
> Start of JDK 17 updates.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1531
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote:
> Please review this simple doc fix.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2028
On Mon, 11 Jan 2021 23:15:07 GMT, Stuart Marks wrote:
> Just fixing a broken link.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk16/pull/106
On Wed, 27 Jan 2021 03:18:09 GMT, Stuart Marks wrote:
> Fix a typo, and change an example to use Stream.toList().
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2249
On Wed, 3 Feb 2021 04:01:51 GMT, Sergey Bylokhov wrote:
> Trivial cleanup, the "default" license header is removed in a few components.
Trivial removal of template instructions.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2368
On Tue, 9 Feb 2021 00:11:52 GMT, Brian Burkhalter wrote:
> Please review this really small correction to the class level documentation
> of `java.util.ServiceLoader`.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2468
On Wed, 17 Feb 2021 20:21:57 GMT, Naoto Sato wrote:
>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Made the additional text an @apiNote
Marked as review
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy wrote:
> Noticed by some of Jon Gibbons's doc linting & checking tooling, this
> changeset fixes two javadoc issues for BigDecimal's serialization-related
> methods, improving the serial form page.
Marked as reviewed by iris (Reviewer).
---
On Thu, 25 Feb 2021 22:41:46 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to remove some superfluous `` tags and an
> erroneous `` tag, all reported by doclint..
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2733
On Fri, 26 Feb 2021 08:04:02 GMT, Joe Wang wrote:
>> Add the documentation for XML processing limits to module summary. The
>> limits were previously documented in Java tutorial and guide.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revisi
On Mon, 1 Mar 2021 23:59:11 GMT, Joe Wang wrote:
>> Add the documentation for XML processing limits to module summary. The
>> limits were previously documented in Java tutorial and guide.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revisio
On Fri, 5 Mar 2021 14:24:34 GMT, Claes Redestad wrote:
> This patch removes the CharacterData.isOtherUppercase and isOtherLowercase
> methods. It also exploits the fact that isOtherUppercase is always false for
> all codepoints in the CharacterDataLatin1 range for a small speed-up.
>
> I have
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the `instanceof` pattern
> variable?
>
> Kind regards,
> Patrick
Marked as reviewed by iris
On Sat, 6 Mar 2021 07:31:09 GMT, Bradford Wetmore wrote:
> Fix various things pointed out by the most recent doclint run in the
> security-libs area.
>
> This is docs only: I will be checking doccheck/doclint, and will be running
> tier1/tier2 tests. Minor spot checks on generated files.
I'
On Tue, 9 Mar 2021 22:19:28 GMT, Bradford Wetmore wrote:
>> Fix various things pointed out by the most recent doclint run in the
>> security-libs area.
>>
>> This is docs only: I will be checking doccheck/doclint, and will be running
>> tier1/tier2 tests. Minor spot checks on generated files
On Thu, 11 Mar 2021 16:42:24 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request i
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote:
> implementation of
> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2920
On Sat, 13 Mar 2021 20:26:42 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this trivial cleanup?
> from JBS:
>
>> jtreg `@modules X` directive does two things:
>> - exclude a test from execution if JDK under test doesn't have module X
>> - if JDK under test has module X, m
On Mon, 15 Mar 2021 09:21:22 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request i
On Tue, 16 Mar 2021 21:39:26 GMT, Joe Wang wrote:
>> Consolidate and move javadoc for the lookup mechanism to the module summary.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typos: s/XMLEventFactory/XMLInputFactory
> s
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote:
> Fixed several broken links to Unicode.org.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3093
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
Marked as reviewed by iris (Reviewer).
--
On Tue, 23 Mar 2021 21:41:32 GMT, Alex Blewitt
wrote:
> 8264091: Use the blessed modifier order in java.logging
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3163
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote:
>> implementation of
>> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
On Thu, 1 Apr 2021 03:24:04 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. Thanks to the contribution by
> Chris Johnson.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3300
On Thu, 1 Apr 2021 22:15:01 GMT, Joe Darcy wrote:
> Simple change to make the exception/error messages more informative for
> various malformed annotation situations.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3317
On Mon, 26 Apr 2021 17:14:29 GMT, Pavel Rappo wrote:
>> I had been looking for an example of a "properties" file when spotted a typo
>> in `logging.properties`. I decided to proofread the file. That resulted in
>> finding a few other issues.
>
> Pavel Rappo has updated the pull request incremen
On Tue, 27 Apr 2021 00:20:49 GMT, Ian Graves wrote:
> 8260560: convert jdeps and jdeprscan tools to use Stream.toList()
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3705
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote:
> 8266155: Convert java.base to use Stream.toList()
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3734
On Wed, 28 Apr 2021 16:57:25 GMT, Ian Graves wrote:
>> 8266155: Convert java.base to use Stream.toList()
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing redundant imports
Marked as reviewed by iris (Reviewer).
On Wed, 28 Apr 2021 16:58:50 GMT, Naoto Sato wrote:
> This new regression test was introduced with the Console::charset(), but it
> fails on ubuntu platforms assuming its locales/encoding incorrectly. To not
> make false-alarm/noise on test runs, this fix minimizes the tests not
> depending on
On Thu, 29 Apr 2021 00:37:37 GMT, Joe Wang wrote:
>> After some internal discussion, we thought it was good to expose the native
>> environment's default character encoding, which Charset.defaultCharset() is
>> currently based on. This way applications will have a better migration path
>> afte
On Wed, 28 Apr 2021 22:24:31 GMT, Naoto Sato wrote:
> After some internal discussion, we thought it was good to expose the native
> environment's default character encoding, which Charset.defaultCharset() is
> currently based on. This way applications will have a better migration path
> after
On Fri, 30 Apr 2021 22:10:21 GMT, Naoto Sato wrote:
>> After some internal discussion, we thought it was good to expose the native
>> environment's default character encoding, which Charset.defaultCharset() is
>> currently based on. This way applications will have a better migration path
>> af
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs wrote:
>> Hi, please find here a trivial test change that adds some diagnostic (time
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
On Tue, 11 May 2021 16:48:28 GMT, Mandy Chung wrote:
> Data provider with varargs does not work on TestNG 7.4.0. Fix the test to
> create an object array instead of varargs to workaround this issue.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pu
On Tue, 25 May 2021 21:43:36 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
On Wed, 26 May 2021 02:22:42 GMT, Tagir F. Valeev wrote:
>> Inspired by PR#4088. Most of the changes are done automatically using
>> IntelliJ IDEA refactoring. Some manual adjustments are also performed,
>> including indentations, moving comments, extracting common cast out of
>> switch expres
On Wed, 26 May 2021 17:52:31 GMT, Roger Riggs wrote:
>> The class `test/lib/jtreg/SkippedException.java` is missing a
>> serialVersionUID causing additional noise in compiler output of tests.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last
On Mon, 31 May 2021 14:10:50 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote:
> 8267630: Start of release updates for JDK 18
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4175
On Thu, 3 Jun 2021 11:01:02 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request incrementall
On Mon, 7 Jun 2021 19:38:58 GMT, Joe Darcy wrote:
>> 8267630: Start of release updates for JDK 18
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull requ
On Wed, 9 Jun 2021 10:25:35 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request incrementall
On Thu, 10 Jun 2021 14:42:24 GMT, Joe Darcy wrote:
>> 8267630: Start of release updates for JDK 18
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master' into 8267630
> - Update copy
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote:
>> The issue was that the attribute was processed before the variable was set
>> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revi
On Mon, 21 Jun 2021 18:22:26 GMT, Naoto Sato wrote:
> Please review this doc clarification fix to `toDaysPart()` method. CSR will
> also be filed accordingly.
Associated CSR also reviewed.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4542
On Tue, 22 Jun 2021 04:22:34 GMT, Ian Graves wrote:
> 8268664: The documentation of the Scanner.hasNextLine is incorrect
Associated CSR also Reviewed.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4547
On Tue, 22 Jun 2021 16:07:12 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind rega
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new
On Tue, 22 Jun 2021 17:50:05 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind rega
On Wed, 23 Jun 2021 07:34:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8268457 bug fixes?
>>
>> The problem is that ToHTMLStream applies processing for non-surrogate pairs
>> to the surrogate pair.
>> This fix changes the processing for non-surrogate pairs to the e
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind rega
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed one.
Marke
On Tue, 29 Jun 2021 04:39:28 GMT, Jonathan Gibbons wrote:
> Please review a trivial `noreg-doc` fix for some javadoc tags for
> `java.lang.Runtime` for JDK17
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/167
On Wed, 30 Jun 2021 21:38:43 GMT, Naoto Sato wrote:
> A trivial typo fix.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/187
On Wed, 7 Jul 2021 19:05:14 GMT, Roger Riggs wrote:
> The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently
> with unexpected output from the VM.
> It appears that destroying the process causes a vm thread to fail to be
> started.
> Extend the delay between starting the
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote:
> 8199594: Add doc describing how (?x) ignores spaces in character classes
Changes match corresponding, approved CSR.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4618
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk wrote:
> Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app'
> dir to env variable in jpackage app launcher.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/271
On Fri, 23 Jul 2021 03:37:44 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked
> fine and the generated javadoc looks fine.
Marked as reviewed by iris (Reviewer).
On Thu, 22 Jul 2021 01:46:09 GMT, Ian Graves wrote:
>> 8199594: Add doc describing how (?x) ignores spaces in character classes
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Rewording repetitive phrase
Marked as reviewed b
On Fri, 23 Jul 2021 17:27:27 GMT, Naoto Sato wrote:
> Please review this PR to introduce `java.time.Duration.isPositive()` method.
> A CSR is also drafted.
Looks good! I've also Reviewed the associated CSR.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.ne
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Marked as reviewed by iris
On Wed, 28 Jul 2021 17:12:04 GMT, Emmanuel Bourg
wrote:
>> This PR fixes the following spelling errors:
>>
>> choosen -> chosen
>> commad -> command
>> hiearchy -> hierarchy
>> leagacy -> legacy
>> minium -> minimum
>> subsytem -> subsystem
>> unamed -> unnamed
>
> Emmanuel Bourg
On Thu, 29 Jul 2021 19:05:58 GMT, Roger Riggs wrote:
> Improve the clarity of comments in the ObjectInputFilter FilterInThread
> example.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/293
On Thu, 5 Aug 2021 14:28:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial fix which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8271208?
>
> Ran `make docs-image` locally and generated the new javadocs and the change
> looks fine.
Marked as review
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/303
On Fri, 6 Aug 2021 16:39:34 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. The root cause of this problem is
> that the currency for the country code `XK` is undefined because the country
> code is user-defined in the ISO 3166 standard. However, it is commonly used
> to r
On Thu, 12 Aug 2021 19:27:42 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the fix for JDK-8263940 to address an issues when the default
>> file system provider is packaged as JAR file on class path.
>>
>> The patch also addresses the `@bug` line for JDK-8271194
>>
>> Mach5 Tier1
On Wed, 18 Aug 2021 20:59:20 GMT, Andrey Turbanov
wrote:
> remove redundant if
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5171
On Mon, 23 Aug 2021 16:42:03 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. When instant seconds and zone
> co-exist in parsed data, instant seconds was not resolved correctly from them.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.ne
On Wed, 1 Sep 2021 19:26:17 GMT, Lance Andersen wrote:
> Hi,
>
> Please review this trivial fix to the javadoc which addresses an issue shown
> via Intellij where the error: "Symbol 'getAdler' is inaccessible from here"
> is generated for the "@See Inflater#getAlder" references.
>
> Best
> La
On Wed, 1 Sep 2021 07:37:53 GMT, Andrey Turbanov
wrote:
> There are few places in code where manual while loop is used with Iterator to
> iterate over Collection.
> Instead of manual while cycles it's preferred to use enhanced-for cycle
> instead: it's less verbose, makes code easier to read a
On Thu, 2 Sep 2021 19:26:12 GMT, Naoto Sato wrote:
> Simple spec clarification. A CSR has also been drafted
> (https://bugs.openjdk.java.net/browse/JDK-8273296).
Associated CSR also "Reviewed".
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/535
On Fri, 3 Sep 2021 13:22:54 GMT, Сергей Цыпанов
wrote:
> Current implementation looks like this:
>
> public byte[] getBytes(String charsetName)
> throws UnsupportedEncodingException {
> if (charsetName == null) throw new NullPointerException();
> return encode(lookupCharset(char
On Wed, 8 Sep 2021 00:37:41 GMT, Naoto Sato wrote:
>> Simple spec clarification. A CSR has also been drafted
>> (https://bugs.openjdk.java.net/browse/JDK-8273296).
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined word
On Fri, 10 Sep 2021 12:21:41 GMT, Naoto Sato wrote:
>> Simple spec clarification. A CSR has also been drafted
>> (https://bugs.openjdk.java.net/browse/JDK-8273296).
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes t
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert two fixes
Marked as reviewed by iris (Reviewer).
---
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by iris (Rev
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote:
> Fixing failing regression tests caused by the JEP 400: UTF-8 by Default.
>
> `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale.
> The output from the agent library is in `UTF-8` so it succeeded before the
> JEP has
On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo wrote:
> This PR fixes an inline comment typo and reduces "overlinking" in a doc
> comment in `java.lang.ref.Reference`. Overlinking happens because the
> `reachabilityFence` method:
> * Links `package-summary.html#reachability` twice.
> * Refers
On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweak wording for Throwable constructor parameters
Marked as reviewed by
On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato wrote:
> Fixing an AIOOBE on normalizing the month value.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5611
On Tue, 21 Sep 2021 18:14:17 GMT, Roger Riggs wrote:
> Correct the check if any field has been appended to the StringBuilder in
> ProcessHandleImpl.Info.toString().
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5618
On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote:
> Simple doc fix.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5620
On Tue, 21 Sep 2021 22:18:07 GMT, Naoto Sato wrote:
>> Fixing an AIOOBE on normalizing the month value.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed the unnecessary space
Marked as reviewed by iris (Reviewer).
--
On Wed, 22 Sep 2021 15:38:33 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing "the"
>
> (Spotted by Brian Burkhalter.)
Marked as revie
On Fri, 24 Sep 2021 23:07:33 GMT, Mandy Chung wrote:
> GenGraphs tool generates the module graph. It currently supports the
> configuration via javadoc-graphs.properties. However,
> `make/jdk/src/classes/build/tools/jigsaw/javadoc-graphs.properties` only
> documents two properties. It should b
1 - 100 of 330 matches
Mail list logo
