[GitHub] ahgittin commented on issue #963: disable jclouds authorizePublicKey for extra ssh public key data

ahgittin commented on issue #963: disable jclouds authorizePublicKey for extra ssh public key data URL: https://github.com/apache/brooklyn-server/pull/963#issuecomment-447275653 Just had a report of a user who is disabling the ssh init options and using `extraSsh...` to configure the user'

[GitHub] ahgittin opened a new pull request #117: require login to webconsole for webapps

ahgittin opened a new pull request #117: require login to webconsole for webapps URL: https://github.com/apache/brooklyn-ui/pull/117 the REST API has always been secured but we now secure these static assets also; this gives a better experience on login, and it will be even more importan

[GitHub] ahgittin commented on issue #117: require login to webconsole for webapps

ahgittin commented on issue #117: require login to webconsole for webapps URL: https://github.com/apache/brooklyn-ui/pull/117#issuecomment-447363483 fixed a bug reported by @frogfather where one snippet had been added twice but have noticed that while this works for the first launch,

[GitHub] tbouron commented on issue #117: require login to webconsole for webapps

tbouron commented on issue #117: require login to webconsole for webapps URL: https://github.com/apache/brooklyn-ui/pull/117#issuecomment-447371396 @ahgittin This should be ok for basic auth but I think will fail for any other kind of auth (if implemented in the future) All resources are no

[GitHub] ahgittin commented on issue #117: require login to webconsole for webapps

ahgittin commented on issue #117: require login to webconsole for webapps URL: https://github.com/apache/brooklyn-ui/pull/117#issuecomment-447379194 good spot @tbouron -- i was trying to do things the "right way" with a JaaS login module but that seems geared around the `` indeed is limite

[GitHub] geomacy opened a new pull request #275: Change git-wip-us.apache.org to gitbox.apache.org

geomacy opened a new pull request #275: Change git-wip-us.apache.org to gitbox.apache.org URL: https://github.com/apache/brooklyn-docs/pull/275 This follows move to gitbox, see https://lists.apache.org/thread.html/3d87de62fa3330222a972ed98e63907107ca5951f0bdf099972ae426

[GitHub] geomacy commented on issue #275: Change git-wip-us.apache.org to gitbox.apache.org

geomacy commented on issue #275: Change git-wip-us.apache.org to gitbox.apache.org URL: https://github.com/apache/brooklyn-docs/pull/275#issuecomment-447492195 We probably need a bit more of a rewrite, but this is a minimal start. ---

[GitHub] tbouron closed pull request #275: Change git-wip-us.apache.org to gitbox.apache.org

tbouron closed pull request #275: Change git-wip-us.apache.org to gitbox.apache.org URL: https://github.com/apache/brooklyn-docs/pull/275 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] geomacy opened a new pull request #136: Avoid build depending on Docker by default

geomacy opened a new pull request #136: Avoid build depending on Docker by default URL: https://github.com/apache/brooklyn-dist/pull/136 To avoid the build failing if Docker is not installed and running, put the docker image build into a profile, so build with mvn clean install -P

[GitHub] duncangrant commented on issue #136: Avoid build depending on Docker by default

duncangrant commented on issue #136: Avoid build depending on Docker by default URL: https://github.com/apache/brooklyn-dist/pull/136#issuecomment-447782289 So we opt out of building the go client, rpm build, and deb build. So this is a bit inconsistent but I think I'd be happy to merge if

[GitHub] geomacy commented on issue #136: Avoid build depending on Docker by default

geomacy commented on issue #136: Avoid build depending on Docker by default URL: https://github.com/apache/brooklyn-dist/pull/136#issuecomment-447783349 I agree that it's inconsistent - actually I was just thinking over the weekend that the same reasoning applies to the rpm/deb and go build

[GitHub] tbouron commented on issue #136: Avoid build depending on Docker by default

tbouron commented on issue #136: Avoid build depending on Docker by default URL: https://github.com/apache/brooklyn-dist/pull/136#issuecomment-447784220 I agree with @duncangrant, we should do opt-in or opt-out for all, i.e. RPM/DEB/Go/Docker. However, this looks good @geomacy! But I

[GitHub] kemitix commented on issue #136: Avoid build depending on Docker by default

kemitix commented on issue #136: Avoid build depending on Docker by default URL: https://github.com/apache/brooklyn-dist/pull/136#issuecomment-447787567 I much prefer the Opt-In approach. How many dev boxes are configured to build *both* rpm and deb packages? As a default configurati

[GitHub] rdowner commented on issue #136: Avoid build depending on Docker by default

rdowner commented on issue #136: Avoid build depending on Docker by default URL: https://github.com/apache/brooklyn-dist/pull/136#issuecomment-448259624 Can I suggest that the Docker artifact is produced in its own project, instead of pigging-backing off the karaf build project? --

[GitHub] geomacy commented on issue #136: Avoid build depending on Docker by default

geomacy commented on issue #136: Avoid build depending on Docker by default URL: https://github.com/apache/brooklyn-dist/pull/136#issuecomment-448367088 I'll have a look at that This is an automated message from the Apache Git

[GitHub] geomacy commented on issue #136: Avoid build depending on Docker by default

geomacy commented on issue #136: Avoid build depending on Docker by default URL: https://github.com/apache/brooklyn-dist/pull/136#issuecomment-451867575 @rdowner @duncangrant @kemitix @tbouron how do you think that looks now?

[GitHub] tbouron commented on a change in pull request #136: Avoid build depending on Docker by default

tbouron commented on a change in pull request #136: Avoid build depending on Docker by default URL: https://github.com/apache/brooklyn-dist/pull/136#discussion_r245587504 ## File path: docker-image/pom.xml ## @@ -0,0 +1,104 @@ + + +http://maven.apache.org/POM/4.0.0"; xmln

[GitHub] duncangrant opened a new pull request #1023: Add version for docker build plugin

duncangrant opened a new pull request #1023: Add version for docker build plugin URL: https://github.com/apache/brooklyn-server/pull/1023 Allows https://github.com/apache/brooklyn-dist/pull/136 review comments to be addressed - i.e. moving docker plugin version to shared pom in brooklyn-se

[GitHub] duncangrant opened a new pull request #137: Docker build plugin version

duncangrant opened a new pull request #137: Docker build plugin version URL: https://github.com/apache/brooklyn-dist/pull/137 Incorporates and addresses review comment in #136 Moves version to brooklyn-server/pom.xml Requires https://github.com/apache/brooklyn-server/pull/1023 ---

[GitHub] geomacy closed pull request #1023: Add version for docker build plugin

geomacy closed pull request #1023: Add version for docker build plugin URL: https://github.com/apache/brooklyn-server/pull/1023 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] geomacy closed pull request #136: Avoid build depending on Docker by default

geomacy closed pull request #136: Avoid build depending on Docker by default URL: https://github.com/apache/brooklyn-dist/pull/136 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] geomacy closed pull request #137: Docker build plugin version

geomacy closed pull request #137: Docker build plugin version URL: https://github.com/apache/brooklyn-dist/pull/137 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] ahgittin opened a new pull request #1024: Implement REST and UI security as filter not JAAS LoginModule, start OAuth

ahgittin opened a new pull request #1024: Implement REST and UI security as filter not JAAS LoginModule, start OAuth URL: https://github.com/apache/brooklyn-server/pull/1024 The JAAS LoginModule seems only to work with BASIC and related auth schemes; it is insufficient for things like OAut

[GitHub] ahgittin commented on issue #117: require login to webconsole for webapps

ahgittin commented on issue #117: require login to webconsole for webapps URL: https://github.com/apache/brooklyn-ui/pull/117#issuecomment-452650378 Changed to use the `BrooklynSecurityProviderFilter` introduced in https://github.com/apache/brooklyn-server/pull/1024 ---

[GitHub] ahgittin commented on issue #1024: Implement REST and UI security as filter not JAAS LoginModule, start OAuth

ahgittin commented on issue #1024: Implement REST and UI security as filter not JAAS LoginModule, start OAuth URL: https://github.com/apache/brooklyn-server/pull/1024#issuecomment-454429862 Note: Bumps some of the versions (see https://github.com/apache/brooklyn-server/pull/1024/files#dif

[GitHub] ahgittin opened a new pull request #138: new version of cxf seems to require this setting

ahgittin opened a new pull request #138: new version of cxf seems to require this setting URL: https://github.com/apache/brooklyn-dist/pull/138 feels like it _shouldn't_ be needed, but we get a glassfish class not found error otherwise, and this fixes it by pointing at cxf instead

[GitHub] ahgittin commented on issue #1024: Implement REST and UI security as filter not JAAS LoginModule, start OAuth

ahgittin commented on issue #1024: Implement REST and UI security as filter not JAAS LoginModule, start OAuth URL: https://github.com/apache/brooklyn-server/pull/1024#issuecomment-454503413 Note the following pull requests are needed simultaneously with this one: * https://github.com

[GitHub] ahgittin commented on issue #138: new version of cxf seems to require this setting

ahgittin commented on issue #138: new version of cxf seems to require this setting URL: https://github.com/apache/brooklyn-dist/pull/138#issuecomment-454504635 thanks to @jcabrerizo for finding this solution to the boot failure! -

[GitHub] ahgittin opened a new pull request #76: bump resteasy to be compatible with new jersey

ahgittin opened a new pull request #76: bump resteasy to be compatible with new jersey URL: https://github.com/apache/brooklyn-client/pull/76 fix need for csrf header now that that is respected in tests needed following https://github.com/apache/brooklyn-server/pull/1024 ---

[GitHub] ahgittin commented on issue #1024: Implement REST and UI security as filter not JAAS LoginModule, start OAuth

ahgittin commented on issue #1024: Implement REST and UI security as filter not JAAS LoginModule, start OAuth URL: https://github.com/apache/brooklyn-server/pull/1024#issuecomment-454624501 @jcabrerizo and I have reviewed each other's work on this. Lots of minor version bumps and tweaks t

[GitHub] asfgit merged pull request #1024: Implement REST and UI security as filter not JAAS LoginModule, start OAuth

asfgit merged pull request #1024: Implement REST and UI security as filter not JAAS LoginModule, start OAuth URL: https://github.com/apache/brooklyn-server/pull/1024 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@brooklyn.apach

[GitHub] asfgit merged pull request #117: require login to webconsole for webapps

asfgit merged pull request #117: require login to webconsole for webapps URL: https://github.com/apache/brooklyn-ui/pull/117 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@brooklyn.apache.org ---

[GitHub] asfgit merged pull request #76: bump resteasy to be compatible with new jersey

asfgit merged pull request #76: bump resteasy to be compatible with new jersey URL: https://github.com/apache/brooklyn-client/pull/76 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@brooklyn.apache.org --

[GitHub] asfgit merged pull request #138: new version of cxf seems to require this setting

asfgit merged pull request #138: new version of cxf seems to require this setting URL: https://github.com/apache/brooklyn-dist/pull/138 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@brooklyn.apache.org ---

[GitHub] asfgit merged pull request #126: update order in pom so we get the preferred versions

asfgit merged pull request #126: update order in pom so we get the preferred versions URL: https://github.com/apache/brooklyn-dist/pull/126 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@brooklyn.apache.org ---

[GitHub] tbouron commented on a change in pull request #117: require login to webconsole for webapps

tbouron commented on a change in pull request #117: require login to webconsole for webapps URL: https://github.com/apache/brooklyn-ui/pull/117#discussion_r248205106 ## File path: ui-modules/features/pom.xml ## @@ -71,46 +71,11 @@ org.apache.

[GitHub] tbouron commented on a change in pull request #117: require login to webconsole for webapps

tbouron commented on a change in pull request #117: require login to webconsole for webapps URL: https://github.com/apache/brooklyn-ui/pull/117#discussion_r248204904 ## File path: modularity-server/features/pom.xml ## @@ -63,46 +63,11 @@ org.

[GitHub] ahgittin opened a new pull request #1025: remove WIP oauth provider

ahgittin opened a new pull request #1025: remove WIP oauth provider URL: https://github.com/apache/brooklyn-server/pull/1025 will be added back when working it's not needed for #1024 (except for testing) and probably confusing to have in, in its current state. those who need it for

[GitHub] aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r248238589 ## File path: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUpgradeScanner.java #

[GitHub] aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r248246789 ## File path: utils/common/src/test/java/org/apache/brooklyn/util/javalang/ReflectionsTest.java ###

[GitHub] aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r248244616 ## File path: core/src/test/java/org/apache/brooklyn/core/typereg/CatalogUpgradesGetBundleUpgradedIfNece

[GitHub] aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r248246191 ## File path: utils/common/src/test/java/org/apache/brooklyn/util/javalang/ReflectionsFindMappedNameTest

[GitHub] aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r248245151 ## File path: parent/pom.xml ## @@ -581,6 +581,11 @@ org.ops4j.pax.web

[GitHub] aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r248245634 ## File path: pom.xml ## @@ -183,11 +183,13 @@ 6121 +6.10 Revie

[GitHub] aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r248243963 ## File path: core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindWithDeserializingClassRename

[GitHub] aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r228574716 ## File path: core/src/test/java/org/apache/brooklyn/core/catalog/internal/CatalogUpgradeScannerTest.jav

[GitHub] aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r228573401 ## File path: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUpgradeScanner.java #

[GitHub] kemitix commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

kemitix commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r248307907 ## File path: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUpgradeScanner.java ##

[GitHub] kemitix commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state

kemitix commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r248307907 ## File path: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUpgradeScanner.java ##

[GitHub] kemitix commented on issue #1010: BROOKLYN-605 rebind fails for historic state

kemitix commented on issue #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#issuecomment-454819030 @aledsage Updated as requested. This is an automated message from t

[GitHub] aledsage commented on issue #1010: BROOKLYN-605 rebind fails for historic state

aledsage commented on issue #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#issuecomment-454845886 Thanks @kemitix - looks great. Merging now. This is an automated m

[GitHub] asfgit merged pull request #1010: BROOKLYN-605 rebind fails for historic state

asfgit merged pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] nakomis opened a new pull request #169: Fixes JBoss 6 & 7 logos in catalog

nakomis opened a new pull request #169: Fixes JBoss 6 & 7 logos in catalog URL: https://github.com/apache/brooklyn-library/pull/169 Fixes JBoss 6 & 7 logos in catalog This is an automated message from the Apache Git Service. T

[GitHub] asfgit commented on issue #169: Fixes JBoss 6 & 7 logos in catalog

asfgit commented on issue #169: Fixes JBoss 6 & 7 logos in catalog URL: https://github.com/apache/brooklyn-library/pull/169#issuecomment-455498928 Can one of the admins verify this patch? This is an automated message from the

[GitHub] tbouron commented on a change in pull request #169: Fixes JBoss 6 & 7 logos in catalog

tbouron commented on a change in pull request #169: Fixes JBoss 6 & 7 logos in catalog URL: https://github.com/apache/brooklyn-library/pull/169#discussion_r248994554 ## File path: software/webapp/src/main/resources/catalog.bom ## @@ -62,7 +62,7 @@ brooklyn.catalog:

[GitHub] tbouron merged pull request #1025: remove WIP oauth provider

tbouron merged pull request #1025: remove WIP oauth provider URL: https://github.com/apache/brooklyn-server/pull/1025 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub a

[GitHub] jcabrerizo commented on issue #1025: remove WIP oauth provider

jcabrerizo commented on issue #1025: remove WIP oauth provider URL: https://github.com/apache/brooklyn-server/pull/1025#issuecomment-456002612 LGTM. Next step, finish the implementation of the `SecurityProvider` to use Oauth authentication --

[GitHub] tbouron merged pull request #169: Fixes JBoss 6 & 7 logos in catalog

tbouron merged pull request #169: Fixes JBoss 6 & 7 logos in catalog URL: https://github.com/apache/brooklyn-library/pull/169 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] duncangrant opened a new pull request #1026: Add cxf-karaf-commands dependency

duncangrant opened a new pull request #1026: Add cxf-karaf-commands dependency URL: https://github.com/apache/brooklyn-server/pull/1026 This is a dependency of cxf that was introduced by the version change to 4.2.7. This adds cxf commands to the karaf shell such as listing endpoints. --

[GitHub] kemitix commented on a change in pull request #1026: Add cxf-karaf-commands dependency

kemitix commented on a change in pull request #1026: Add cxf-karaf-commands dependency URL: https://github.com/apache/brooklyn-server/pull/1026#discussion_r250136326 ## File path: karaf/features/src/main/feature/feature.xml ## @@ -208,6 +208,7 @@ cxf-jaxrs

[GitHub] kemitix commented on a change in pull request #1026: Add cxf-karaf-commands dependency

kemitix commented on a change in pull request #1026: Add cxf-karaf-commands dependency URL: https://github.com/apache/brooklyn-server/pull/1026#discussion_r250136326 ## File path: karaf/features/src/main/feature/feature.xml ## @@ -208,6 +208,7 @@ cxf-jaxrs

[GitHub] tbouron commented on a change in pull request #1026: Add cxf-karaf-commands dependency

tbouron commented on a change in pull request #1026: Add cxf-karaf-commands dependency URL: https://github.com/apache/brooklyn-server/pull/1026#discussion_r250137380 ## File path: karaf/features/src/main/feature/feature.xml ## @@ -208,6 +208,7 @@ cxf-jaxrs

[GitHub] kemitix commented on a change in pull request #1026: Add cxf-karaf-commands dependency

kemitix commented on a change in pull request #1026: Add cxf-karaf-commands dependency URL: https://github.com/apache/brooklyn-server/pull/1026#discussion_r250138782 ## File path: karaf/features/src/main/feature/feature.xml ## @@ -208,6 +208,7 @@ cxf-jaxrs

[GitHub] duncangrant commented on a change in pull request #1026: Add cxf-karaf-commands dependency

duncangrant commented on a change in pull request #1026: Add cxf-karaf-commands dependency URL: https://github.com/apache/brooklyn-server/pull/1026#discussion_r250141286 ## File path: karaf/features/src/main/feature/feature.xml ## @@ -208,6 +208,7 @@ cxf-jaxrs

[GitHub] jcabrerizo opened a new pull request #1027: Added config keys for Oauth

jcabrerizo opened a new pull request #1027: Added config keys for Oauth URL: https://github.com/apache/brooklyn-server/pull/1027 Some new ConfigKeys added to mange the authentication using Oauth This is an automated message fr

[GitHub] tbouron commented on issue #1027: Added config keys for Oauth

tbouron commented on issue #1027: Added config keys for Oauth URL: https://github.com/apache/brooklyn-server/pull/1027#issuecomment-456760002 Thanks for the PR @jcabrerizo ! However, the `OAuthProvider` introduced by #1024 was WIP and removed in #1025. So I think these config keys sh

[GitHub] tbouron edited a comment on issue #1027: Added config keys for Oauth

tbouron edited a comment on issue #1027: Added config keys for Oauth URL: https://github.com/apache/brooklyn-server/pull/1027#issuecomment-456760002 Thanks for the PR @jcabrerizo ! However, the `OAuthProvider` introduced by #1024 was WIP and removed in #1025. So I think these config

[GitHub] tbouron merged pull request #1026: Add cxf-karaf-commands dependency

tbouron merged pull request #1026: Add cxf-karaf-commands dependency URL: https://github.com/apache/brooklyn-server/pull/1026 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] duncangrant opened a new pull request #1028: Add missing $

duncangrant opened a new pull request #1028: Add missing $ URL: https://github.com/apache/brooklyn-server/pull/1028 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] tbouron merged pull request #1028: Add missing $

tbouron merged pull request #1028: Add missing $ URL: https://github.com/apache/brooklyn-server/pull/1028 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the U

[GitHub] grkvlt opened a new pull request #118: [WIP] Parameter UI additions

grkvlt opened a new pull request #118: [WIP] Parameter UI additions URL: https://github.com/apache/brooklyn-ui/pull/118 Adding code to handle the `brooklyn.parameters` section in a blueprint. Currently needs more work on editing and handling raw JSON data. -

[GitHub] nakomis opened a new pull request #1029: winrm4j 0.5.0 -> 0.6.1

nakomis opened a new pull request #1029: winrm4j 0.5.0 -> 0.6.1 URL: https://github.com/apache/brooklyn-server/pull/1029 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] aledsage opened a new pull request #1030: BROOKLYN-607: prefer vanilla CentOS image on azure

aledsage opened a new pull request #1030: BROOKLYN-607: prefer vanilla CentOS image on azure URL: https://github.com/apache/brooklyn-server/pull/1030 This is an automated message from the Apache Git Service. To respond to th

[GitHub] ahgittin commented on issue #1030: BROOKLYN-607: prefer vanilla CentOS image on azure

ahgittin commented on issue #1030: BROOKLYN-607: prefer vanilla CentOS image on azure URL: https://github.com/apache/brooklyn-server/pull/1030#issuecomment-457184010 Looks good. Will add some comments: ``` // suggest to use NaturalOrderComparator (so 10>9) then order by: // 1)

[GitHub] asfgit merged pull request #1030: BROOKLYN-607: prefer vanilla CentOS image on azure

asfgit merged pull request #1030: BROOKLYN-607: prefer vanilla CentOS image on azure URL: https://github.com/apache/brooklyn-server/pull/1030 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] aledsage commented on issue #1029: winrm4j 0.5.0 -> 0.6.1

aledsage commented on issue #1029: winrm4j 0.5.0 -> 0.6.1 URL: https://github.com/apache/brooklyn-server/pull/1029#issuecomment-457210362 LGTM; merging now. This is an automated message from the Apache Git Service. To respond

[GitHub] asfgit merged pull request #1029: winrm4j 0.5.0 -> 0.6.1

asfgit merged pull request #1029: winrm4j 0.5.0 -> 0.6.1 URL: https://github.com/apache/brooklyn-server/pull/1029 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and u

[GitHub] ahgittin opened a new pull request #119: tables should run with their own scope

ahgittin opened a new pull request #119: tables should run with their own scope URL: https://github.com/apache/brooklyn-ui/pull/119 without this if you put _two_ tables in the same parent controller view they collide on their data and have their own data ---

[GitHub] aledsage opened a new pull request #1031: BROOKLYN-608: fix karaf start (javax.annotation-api version)

aledsage opened a new pull request #1031: BROOKLYN-608: fix karaf start (javax.annotation-api version) URL: https://github.com/apache/brooklyn-server/pull/1031 This is an automated message from the Apache Git Service. To res

[GitHub] duncangrant merged pull request #1031: BROOKLYN-608: fix karaf start (javax.annotation-api version)

duncangrant merged pull request #1031: BROOKLYN-608: fix karaf start (javax.annotation-api version) URL: https://github.com/apache/brooklyn-server/pull/1031 This is an automated message from the Apache Git Service. To respon

[GitHub] ahgittin opened a new pull request #1033: Share sessions among all bundles so we can share auth

ahgittin opened a new pull request #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033 this takes the first encountered session handler and caches it, also setting the sessonPath on the cookies so cookies are valid for all

[GitHub] ahgittin opened a new pull request #1032: make /logout just log out

ahgittin opened a new pull request #1032: make /logout just log out URL: https://github.com/apache/brooklyn-server/pull/1032 previously it redirected to the user-specific logout; but some clients didn't respect that, and assumed the logout had happened. not convinced there is a good reas

[GitHub] aledsage commented on issue #1033: Share sessions among all bundles so we can share auth

aledsage commented on issue #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#issuecomment-457965480 Jenkins test failures look related, e.g. `BrooklynRestApiLauncherTest.testServletStart`: ``` java.lang.NoSuchMethod

[GitHub] ahgittin commented on issue #1032: make /logout just log out

ahgittin commented on issue #1032: make /logout just log out URL: https://github.com/apache/brooklyn-server/pull/1032#issuecomment-457977863 experimenting to see what makes sense the browser seems to keep the local cached creds, _even_ on a 401 unauthorized, so not sure if there's mu

[GitHub] ahgittin opened a new pull request #120: Fix logout [DO NOT MERGE]

ahgittin opened a new pull request #120: Fix logout [DO NOT MERGE] URL: https://github.com/apache/brooklyn-ui/pull/120 update logout to use angular `$http` and actually to call the server to log out previously it wasn't calling to the server (not sure where it was going wrong but it

[GitHub] ahgittin commented on issue #120: Fix logout [DO NOT MERGE]

ahgittin commented on issue #120: Fix logout [DO NOT MERGE] URL: https://github.com/apache/brooklyn-ui/pull/120#issuecomment-457978118 this PR includes a lot of exploration, and i'm _still_ exploring. it's proving quite hard to get the browser to forget or re-question its cached user:pass

[GitHub] ahgittin commented on issue #1033: Share sessions among all bundles so we can share auth

ahgittin commented on issue #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#issuecomment-457978368 Thanks @aledsage ; fixed the obvious problem but there are still some tests that need TLC. Top priority for the mornin

[GitHub] ahgittin commented on issue #1033: Share sessions among all bundles so we can share auth

ahgittin commented on issue #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#issuecomment-458063610 Have fixed above tests now; let's see how this build does ---

[GitHub] ahgittin commented on issue #1033: Share sessions among all bundles so we can share auth

ahgittin commented on issue #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#issuecomment-458081709 retest this please unrelated error in polilcies T

[GitHub] jcabrerizo commented on issue #1033: Share sessions among all bundles so we can share auth

jcabrerizo commented on issue #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#issuecomment-458089933 Great job. I'm testing manually the WIP around the Google Oauth provider and seems to be working. ---

[GitHub] aledsage commented on a change in pull request #1033: Share sessions among all bundles so we can share auth

aledsage commented on a change in pull request #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#discussion_r251413877 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/filter/BrooklynSecurit

[GitHub] aledsage commented on a change in pull request #1033: Share sessions among all bundles so we can share auth

aledsage commented on a change in pull request #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#discussion_r251416007 ## File path: rest/rest-resources/pom.xml ## @@ -220,10 +215,9 @@

[GitHub] jcabrerizo commented on issue #1033: Share sessions among all bundles so we can share auth

jcabrerizo commented on issue #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#issuecomment-458178665 I've been testing with @richardcloudsoft the Web UI and the BR command line and it works perfectly using `AnyoneSecurit

[GitHub] ahgittin commented on a change in pull request #1033: Share sessions among all bundles so we can share auth

ahgittin commented on a change in pull request #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#discussion_r251657088 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/filter/BrooklynSecurit

[GitHub] ahgittin commented on a change in pull request #1033: Share sessions among all bundles so we can share auth

ahgittin commented on a change in pull request #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#discussion_r251657301 ## File path: rest/rest-resources/pom.xml ## @@ -220,10 +215,9 @@

[GitHub] ahgittin commented on issue #1033: Share sessions among all bundles so we can share auth

ahgittin commented on issue #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#issuecomment-458366764 This seems to be working well, except for one thing. The original session handler is still in the handler stack, and whe

[GitHub] ahgittin edited a comment on issue #1033: Share sessions among all bundles so we can share auth

ahgittin edited a comment on issue #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033#issuecomment-458366764 This seems to be working well, except for one thing. The original session handler is still in the handler stack,

[GitHub] ahgittin commented on issue #1032: make /logout just log out

ahgittin commented on issue #1032: make /logout just log out URL: https://github.com/apache/brooklyn-server/pull/1032#issuecomment-458368531 mostly fixes problem at #1033 and makes it nicer to work with from the uI, including invalidating locally-stored creds still to do: * push t

[GitHub] ahgittin edited a comment on issue #1032: make /logout just log out

ahgittin edited a comment on issue #1032: make /logout just log out URL: https://github.com/apache/brooklyn-server/pull/1032#issuecomment-458368531 mostly fixes problem at #1033 and makes it nicer to work with from the uI, including invalidating locally-stored creds still to do: *

[GitHub] ahgittin closed pull request #1033: Share sessions among all bundles so we can share auth

ahgittin closed pull request #1033: Share sessions among all bundles so we can share auth URL: https://github.com/apache/brooklyn-server/pull/1033 This is an automated message from the Apache Git Service. To respond to the m

  1   2   3   4   5   6   7   8   9   10   >