Re: [PR] Draft: Adding tests for Patch Generation [directory-scimple]

2023-12-07 Thread via GitHub
bdemers commented on code in PR #435: URL: https://github.com/apache/directory-scimple/pull/435#discussion_r1419171006 ## scim-core/src/main/java/org/apache/directory/scim/core/repository/PatchGenerator.java: ## @@ -305,7 +306,7 @@ private List handleAttributes(JsonNode valueNo

Re: [I] Add ScimGroup tests for PatchGenerator, (previously)UpdateRequest [directory-scimple]

2023-12-07 Thread via GitHub
bdemers commented on issue #427: URL: https://github.com/apache/directory-scimple/issues/427#issuecomment-1846315481 Digging into the `REPLACE` vs `REMOVE`/`ADD` a bit more. I hacked up some (really ugly) code to try to understand how the logic in the `PatchGenerator` (previously `Update

Re: [PR] Bump commons-dbutils:commons-dbutils from 1.8.0 to 1.8.1 [directory-kerby]

2023-12-07 Thread via GitHub
coheigea merged PR #298: URL: https://github.com/apache/directory-kerby/pull/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directo

Re: [PR] Bump org.apache.maven.plugins:maven-jxr-plugin from 3.3.0 to 3.3.1 [directory-kerby]

2023-12-07 Thread via GitHub
coheigea commented on PR #295: URL: https://github.com/apache/directory-kerby/pull/295#issuecomment-1846623329 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.5.0 to 3.6.3 [directory-kerby]

2023-12-07 Thread via GitHub
coheigea merged PR #297: URL: https://github.com/apache/directory-kerby/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directo

Re: [PR] Bump commons-io:commons-io from 2.12.0 to 2.15.1 [directory-kerby]

2023-12-07 Thread via GitHub
coheigea merged PR #296: URL: https://github.com/apache/directory-kerby/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directo

Re: [PR] Bump org.apache.maven.plugins:maven-jxr-plugin from 3.3.0 to 3.3.1 [directory-kerby]

2023-12-07 Thread via GitHub
dependabot[bot] commented on PR #295: URL: https://github.com/apache/directory-kerby/pull/295#issuecomment-1846623405 Looks like this PR is already up-to-date with trunk! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- Th

Re: [PR] Bump org.apache.maven.plugins:maven-jxr-plugin from 3.3.0 to 3.3.1 [directory-kerby]

2023-12-07 Thread via GitHub
coheigea merged PR #295: URL: https://github.com/apache/directory-kerby/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directo

[PR] Bump com.nimbusds:nimbus-jose-jwt from 9.37.2 to 9.37.3 [directory-kerby]

2023-12-08 Thread via GitHub
dependabot[bot] opened a new pull request, #300: URL: https://github.com/apache/directory-kerby/pull/300 Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 9.37.2 to 9.37.3. Changelog Sourced from https://bitbucket.org/connect2id/nimbus-jos

[PR] Bump org.apache.maven.plugins:maven-surefire-plugin from 3.1.2 to 3.2.2 [directory-kerby]

2023-12-08 Thread via GitHub
dependabot[bot] opened a new pull request, #299: URL: https://github.com/apache/directory-kerby/pull/299 Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.1.2 to 3.2.2. Release notes Sourced from https://github.com/apache/maven

[I] DefaultPatchHandler does not handle Group member remove operations correctly [directory-scimple]

2023-12-10 Thread via GitHub
kjthorpe18 opened a new issue, #436: URL: https://github.com/apache/directory-scimple/issues/436 The DefaultPatchHandler does not treat ScimGroup `members` as a collection, and removes the `members` attribute instead of the specified value. Example request: `PATCH /api/scim/v2/Grou

Re: [I] DefaultPatchHandler does not handle Group member remove operations correctly [directory-scimple]

2023-12-10 Thread via GitHub
kjthorpe18 commented on issue #436: URL: https://github.com/apache/directory-scimple/issues/436#issuecomment-1849105074 Also, this needs to handle removing members by _only_ their specified `value`, without specifying other information such as `display`. For example, in the `source` items

Re: [I] DefaultPatchHandler does not handle Group member remove operations correctly [directory-scimple]

2023-12-10 Thread via GitHub
kjthorpe18 commented on issue #436: URL: https://github.com/apache/directory-scimple/issues/436#issuecomment-1849107103 The SCIM RFC specifies the following as the way to remove a member from a group (and this is also how Okta formats their requests): ``` The following example show

[PR] Bump github/codeql-action from 2.22.8 to 2.22.9 [directory-kerby]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #301: URL: https://github.com/apache/directory-kerby/pull/301 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.8 to 2.22.9. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.m

Re: [I] Add ScimGroup tests for PatchGenerator, (previously)UpdateRequest [directory-scimple]

2023-12-11 Thread via GitHub
kjthorpe18 commented on issue #427: URL: https://github.com/apache/directory-scimple/issues/427#issuecomment-1850082458 I looked at the RFC again and I believe I was misunderstanding `replace` ops with Group members. I don't think it's possible to replace one `member` value with another, b

Re: [I] DefaultPatchHandler does not handle Group member remove operations correctly [directory-scimple]

2023-12-11 Thread via GitHub
bdemers commented on issue #436: URL: https://github.com/apache/directory-scimple/issues/436#issuecomment-1850361386 Good find @kjthorpe18! I agree that does look out of spec: > If the target location is a multi-valued attribute and no filter is specified, the attribute and al

Re: [I] DefaultPatchHandler does not handle Group member remove operations correctly [directory-scimple]

2023-12-11 Thread via GitHub
kjthorpe18 commented on issue #436: URL: https://github.com/apache/directory-scimple/issues/436#issuecomment-1850433454 There are a few ways in which Azure doesn't conform to the spec, and I really don't expect them to fix these any time soon. So, I think if we can catch this specif

Re: [I] DefaultPatchHandler does not handle Group member remove operations correctly [directory-scimple]

2023-12-11 Thread via GitHub
bdemers commented on issue #436: URL: https://github.com/apache/directory-scimple/issues/436#issuecomment-1850464887 Maybe we should create a test naming or tag for these. My guess is that Azure wont be the only one that will have quirks. Do you want to take a pass creating tests fo

[PR] Bump org.owasp:dependency-check-maven from 8.4.3 to 9.0.4 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #438: URL: https://github.com/apache/directory-scimple/pull/438 Bumps [org.owasp:dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 8.4.3 to 9.0.4. Release notes Sourced from https://github.com/jeremylong/Dependen

[PR] Bump version.quarkus from 3.6.0 to 3.6.1 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #439: URL: https://github.com/apache/directory-scimple/pull/439 Bumps `version.quarkus` from 3.6.0 to 3.6.1. Updates `io.quarkus.platform:quarkus-bom` from 3.6.0 to 3.6.1 Commits https://github.com/quarkusio/quarkus-platform/commit/6

[PR] Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #437: URL: https://github.com/apache/directory-scimple/pull/437 Bumps org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency

Re: [PR] Bump org.owasp:dependency-check-maven from 8.4.3 to 9.0.2 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] commented on PR #431: URL: https://github.com/apache/directory-scimple/pull/431#issuecomment-1850575337 Superseded by #438. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Bump org.owasp:dependency-check-maven from 8.4.3 to 9.0.2 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] closed pull request #431: Bump org.owasp:dependency-check-maven from 8.4.3 to 9.0.2 URL: https://github.com/apache/directory-scimple/pull/431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.1.0 to 3.2.2 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #440: URL: https://github.com/apache/directory-scimple/pull/440 Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.1.0 to 3.2.2. Release notes Sourced from https://github.com/apache/mav

[PR] Bump com.gradle:common-custom-user-data-maven-extension from 1.12.4 to 1.12.5 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #441: URL: https://github.com/apache/directory-scimple/pull/441 Bumps [com.gradle:common-custom-user-data-maven-extension](https://github.com/gradle/common-custom-user-data-maven-extension) from 1.12.4 to 1.12.5. Release notes Sourced fro

[PR] Bump com.gradle:gradle-enterprise-maven-extension from 1.19.3 to 1.20 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #444: URL: https://github.com/apache/directory-scimple/pull/444 Bumps com.gradle:gradle-enterprise-maven-extension from 1.19.3 to 1.20. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?

[PR] Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.3.0 to 3.4.1 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #445: URL: https://github.com/apache/directory-scimple/pull/445 Bumps [org.apache.maven.plugins:maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.3.0 to 3.4.1. Release notes Sourced from https://github.com/apache/mav

[PR] Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.5.0 to 3.6.3 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #446: URL: https://github.com/apache/directory-scimple/pull/446 Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.5.0 to 3.6.3. Release notes Sourced from https://github.com/apach

[PR] Bump org.apache.maven.plugins:maven-surefire-plugin from 3.1.0 to 3.2.2 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #442: URL: https://github.com/apache/directory-scimple/pull/442 Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.1.0 to 3.2.2. Release notes Sourced from https://github.com/apache/mav

[PR] Bump commons-codec:commons-codec from 1.15 to 1.16.0 [directory-scimple]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #443: URL: https://github.com/apache/directory-scimple/pull/443 Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec) from 1.15 to 1.16.0. Changelog Sourced from https://github.com/apache/commons-codec/blob/master/RE

Re: [PR] Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.3.0 to 3.4.1 [directory-scimple]

2023-12-11 Thread via GitHub
bdemers merged PR #445: URL: https://github.com/apache/directory-scimple/pull/445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [PR] Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.5.0 to 3.6.3 [directory-scimple]

2023-12-11 Thread via GitHub
bdemers merged PR #446: URL: https://github.com/apache/directory-scimple/pull/446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [PR] Bump commons-codec:commons-codec from 1.15 to 1.16.0 [directory-scimple]

2023-12-11 Thread via GitHub
bdemers merged PR #443: URL: https://github.com/apache/directory-scimple/pull/443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [PR] Bump org.apache.maven.plugins:maven-surefire-plugin from 3.1.0 to 3.2.2 [directory-scimple]

2023-12-11 Thread via GitHub
bdemers merged PR #442: URL: https://github.com/apache/directory-scimple/pull/442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [PR] Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.1.0 to 3.2.2 [directory-scimple]

2023-12-11 Thread via GitHub
bdemers merged PR #440: URL: https://github.com/apache/directory-scimple/pull/440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [PR] Bump version.quarkus from 3.6.0 to 3.6.1 [directory-scimple]

2023-12-11 Thread via GitHub
bdemers merged PR #439: URL: https://github.com/apache/directory-scimple/pull/439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [PR] Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0 [directory-scimple]

2023-12-11 Thread via GitHub
bdemers merged PR #437: URL: https://github.com/apache/directory-scimple/pull/437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [I] DefaultPatchHandler does not handle Group member remove operations correctly [directory-scimple]

2023-12-11 Thread via GitHub
kjthorpe18 commented on issue #436: URL: https://github.com/apache/directory-scimple/issues/436#issuecomment-1850718076 @bdemers yep I can give it a shot. Specifically in the PatchHandler? Anywhere else? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [I] DefaultPatchHandler does not handle Group member remove operations correctly [directory-scimple]

2023-12-11 Thread via GitHub
bdemers commented on issue #436: URL: https://github.com/apache/directory-scimple/issues/436#issuecomment-1850874468 Yup! PatchHandler is probably the best bet That said, if we need to test this at a higher level, we can do that too! -- This is an automated message from the Apache Git

[PR] Handle azure style remove member operations [directory-scimple]

2023-12-12 Thread via GitHub
kjthorpe18 opened a new pull request, #447: URL: https://github.com/apache/directory-scimple/pull/447 Azure sends PATCH requests to remove individual members from a Group of the style ``` { "schemas":[ "urn:ietf:params:scim:api:messages:2.0:PatchOp" ], "Opera

Re: [PR] Handle azure style remove member operations [directory-scimple]

2023-12-12 Thread via GitHub
kjthorpe18 closed pull request #447: Handle azure style remove member operations URL: https://github.com/apache/directory-scimple/pull/447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] DefaultPatchHandler does not handle Group member remove operations correctly [directory-scimple]

2023-12-12 Thread via GitHub
kjthorpe18 commented on issue #436: URL: https://github.com/apache/directory-scimple/issues/436#issuecomment-1852165423 @bdemers Started https://github.com/apache/directory-scimple/pull/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] Handle Azure style Group member remove operations [directory-scimple]

2023-12-12 Thread via GitHub
kjthorpe18 opened a new pull request, #448: URL: https://github.com/apache/directory-scimple/pull/448 Azure sends PATCH operations to remove members from a group of the following form: ``` { "schemas":[ "urn:ietf:params:scim:api:messages:2.0:PatchOp" ], "Oper

Re: [PR] Handle Azure style Group member remove operations [directory-scimple]

2023-12-12 Thread via GitHub
bdemers commented on code in PR #448: URL: https://github.com/apache/directory-scimple/pull/448#discussion_r1424361352 ## scim-core/src/test/java/org/apache/directory/scim/core/repository/PatchHandlerTest.java: ## @@ -465,6 +467,39 @@ public void deleteItemWithComplexFilter() th

Re: [PR] Handle Azure style Group member remove operations [directory-scimple]

2023-12-12 Thread via GitHub
bdemers commented on code in PR #448: URL: https://github.com/apache/directory-scimple/pull/448#discussion_r1424365505 ## scim-core/src/test/java/org/apache/directory/scim/core/repository/PatchHandlerTest.java: ## @@ -465,6 +467,39 @@ public void deleteItemWithComplexFilter() th

[PR] Bump netty.version from 4.1.101.Final to 4.1.103.Final [directory-kerby]

2023-12-13 Thread via GitHub
dependabot[bot] opened a new pull request, #302: URL: https://github.com/apache/directory-kerby/pull/302 Bumps `netty.version` from 4.1.101.Final to 4.1.103.Final. Updates `io.netty:netty-transport` from 4.1.101.Final to 4.1.103.Final Commits https://github.com/netty/netty/co

[PR] Bump org.apache.maven.plugins:maven-surefire-plugin from 3.1.2 to 3.2.3 [directory-kerby]

2023-12-13 Thread via GitHub
dependabot[bot] opened a new pull request, #303: URL: https://github.com/apache/directory-kerby/pull/303 Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.1.2 to 3.2.3. Release notes Sourced from https://github.com/apache/maven

Re: [PR] Bump org.apache.maven.plugins:maven-surefire-plugin from 3.1.2 to 3.2.2 [directory-kerby]

2023-12-13 Thread via GitHub
dependabot[bot] commented on PR #299: URL: https://github.com/apache/directory-kerby/pull/299#issuecomment-1853759021 Superseded by #303. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Bump org.apache.maven.plugins:maven-surefire-plugin from 3.1.2 to 3.2.2 [directory-kerby]

2023-12-13 Thread via GitHub
dependabot[bot] closed pull request #299: Bump org.apache.maven.plugins:maven-surefire-plugin from 3.1.2 to 3.2.2 URL: https://github.com/apache/directory-kerby/pull/299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Improve Patch Generation logic and add tests [directory-scimple]

2023-12-13 Thread via GitHub
bdemers commented on code in PR #435: URL: https://github.com/apache/directory-scimple/pull/435#discussion_r1426198499 ## scim-spec/scim-spec-schema/src/main/java/org/apache/directory/scim/spec/schema/Schemas.java: ## @@ -201,6 +202,7 @@ private static List createAttributes(Str

[I] Enriching calls to scim repository [directory-scimple]

2023-12-14 Thread via GitHub
erant10 opened a new issue, #449: URL: https://github.com/apache/directory-scimple/issues/449 Trying to figure out a way to “enrich” calls coming into the scim repositories with additional context which is not part of the ScimResource (e.g. customerId, directory provider - azure/okta/other,

Re: [I] Enriching calls to scim repository [directory-scimple]

2023-12-14 Thread via GitHub
bdemers commented on issue #449: URL: https://github.com/apache/directory-scimple/issues/449#issuecomment-1856484338 🤔 You could probably inject the SecurityContext and HTTP request objects into your `Repository` implementation NOTE: How it gets injected may depend on your container,

Re: [I] Enriching calls to scim repository [directory-scimple]

2023-12-14 Thread via GitHub
bdemers commented on issue #449: URL: https://github.com/apache/directory-scimple/issues/449#issuecomment-1856839560 I think you could add a layer of abstraction, e.g. create a component with an interface `ScimResourceContext` (🤢 naming is hard) with a bunch of getters for the attrib

[PR] Maven Site now generates [directory-scimple]

2023-12-14 Thread via GitHub
bdemers opened a new pull request, #450: URL: https://github.com/apache/directory-scimple/pull/450 We really only need the javadoc, but it works now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Bump netty.version from 4.1.101.Final to 4.1.103.Final [directory-kerby]

2023-12-15 Thread via GitHub
dependabot[bot] closed pull request #302: Bump netty.version from 4.1.101.Final to 4.1.103.Final URL: https://github.com/apache/directory-kerby/pull/302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Bump netty.version from 4.1.101.Final to 4.1.104.Final [directory-kerby]

2023-12-15 Thread via GitHub
dependabot[bot] opened a new pull request, #304: URL: https://github.com/apache/directory-kerby/pull/304 Bumps `netty.version` from 4.1.101.Final to 4.1.104.Final. Updates `io.netty:netty-transport` from 4.1.101.Final to 4.1.104.Final Commits https://github.com/netty/netty/co

Re: [PR] Bump netty.version from 4.1.101.Final to 4.1.103.Final [directory-kerby]

2023-12-15 Thread via GitHub
dependabot[bot] commented on PR #302: URL: https://github.com/apache/directory-kerby/pull/302#issuecomment-1857732585 Superseded by #304. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Maven Site now generates [directory-scimple]

2023-12-15 Thread via GitHub
bdemers merged PR #450: URL: https://github.com/apache/directory-scimple/pull/450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [PR] Improve Patch Generation logic and add tests [directory-scimple]

2023-12-15 Thread via GitHub
bdemers commented on PR #435: URL: https://github.com/apache/directory-scimple/pull/435#issuecomment-1858148133 Before merging, i'll break this up into more isolated changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] Add scim-test module for common test code [directory-scimple]

2023-12-15 Thread via GitHub
bdemers opened a new pull request, #451: URL: https://github.com/apache/directory-scimple/pull/451 - AssertJ Assertions - Common test objects -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Improve Patch Generation logic and add tests [directory-scimple]

2023-12-15 Thread via GitHub
bdemers commented on PR #435: URL: https://github.com/apache/directory-scimple/pull/435#issuecomment-1858521965 splitting this PR up, see: ##451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Add scim-test module for common test code [directory-scimple]

2023-12-15 Thread via GitHub
bdemers merged PR #451: URL: https://github.com/apache/directory-scimple/pull/451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [PR] Improve Patch Generation logic and add tests [directory-scimple]

2023-12-15 Thread via GitHub
bdemers commented on code in PR #435: URL: https://github.com/apache/directory-scimple/pull/435#discussion_r1428524926 ## scim-spec/scim-spec-schema/src/main/java/org/apache/directory/scim/spec/schema/Schemas.java: ## @@ -201,6 +202,7 @@ private static List createAttributes(Str

Re: [PR] Improve Patch Generation logic and add tests [directory-scimple]

2023-12-15 Thread via GitHub
bdemers merged PR #435: URL: https://github.com/apache/directory-scimple/pull/435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [PR] Add `name="$ref"` to ScimAttribute, where it's set in XmlElement [directory-scimple]

2023-12-15 Thread via GitHub
bdemers merged PR #426: URL: https://github.com/apache/directory-scimple/pull/426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

Re: [PR] Add `name="$ref"` to ScimAttribute, where it's set in XmlElement [directory-scimple]

2023-12-15 Thread via GitHub
bdemers commented on PR #426: URL: https://github.com/apache/directory-scimple/pull/426#issuecomment-1858603020 Thanks @tm-drtina! I've got a test for this pending in #452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [SCIMPLE-93] Set type=reference, when referenceTypes are set [directory-scimple]

2023-12-15 Thread via GitHub
bdemers closed pull request #425: [SCIMPLE-93] Set type=reference, when referenceTypes are set URL: https://github.com/apache/directory-scimple/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SCIMPLE-93] Set type=reference, when referenceTypes are set [directory-scimple]

2023-12-15 Thread via GitHub
bdemers commented on PR #425: URL: https://github.com/apache/directory-scimple/pull/425#issuecomment-1858610801 Fixed in: #452 Thanks again @tm-drtina! this was really helpful and me track down a related issue! -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Add test for Schema generation from Annotations [directory-scimple]

2023-12-15 Thread via GitHub
bdemers merged PR #452: URL: https://github.com/apache/directory-scimple/pull/452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

[PR] Adds common project git hooks directory [directory-scimple]

2023-12-15 Thread via GitHub
bdemers opened a new pull request, #453: URL: https://github.com/apache/directory-scimple/pull/453 Use is optional, I've had too many CI failures because I forgot license headers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Adds common project git hooks directory [directory-scimple]

2023-12-15 Thread via GitHub
bdemers merged PR #453: URL: https://github.com/apache/directory-scimple/pull/453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

[PR] Handle Azure style Group member remove operations (rebased) [directory-scimple]

2023-12-15 Thread via GitHub
bdemers opened a new pull request, #454: URL: https://github.com/apache/directory-scimple/pull/454 - Handle Azure style Group member remove operations - Fix merge conflicts - Adds support for Azure non-standard patch REMOVE requests -- This is an automated message from the Apache

Re: [PR] Handle Azure style Group member remove operations (rebased) [directory-scimple]

2023-12-15 Thread via GitHub
bdemers commented on PR #454: URL: https://github.com/apache/directory-scimple/pull/454#issuecomment-1858738189 @kjthorpe18 I rebased your branch on `develop`, but I didn't want to force push to your PR. If you want you can merge these changes in and we can continue working on your bran

Re: [PR] Handle Azure style Group member remove operations (rebased) [directory-scimple]

2023-12-15 Thread via GitHub
bdemers commented on code in PR #454: URL: https://github.com/apache/directory-scimple/pull/454#discussion_r1428712393 ## scim-core/src/test/java/org/apache/directory/scim/core/repository/PatchHandlerTest.java: ## @@ -49,6 +52,7 @@ public class PatchHandlerTest { public Patch

Re: [PR] Handle Azure style Group member remove operations (rebased) [directory-scimple]

2023-12-15 Thread via GitHub
bdemers commented on code in PR #454: URL: https://github.com/apache/directory-scimple/pull/454#discussion_r1428712628 ## scim-core/src/test/java/org/apache/directory/scim/core/repository/PatchHandlerTest.java: ## @@ -465,6 +469,46 @@ public void deleteItemWithComplexFilter() th

Re: [PR] Handle Azure style Group member remove operations (rebased) [directory-scimple]

2023-12-15 Thread via GitHub
bdemers commented on code in PR #454: URL: https://github.com/apache/directory-scimple/pull/454#discussion_r1428713069 ## scim-core/src/main/java/org/apache/directory/scim/core/repository/DefaultPatchHandler.java: ## @@ -426,5 +447,48 @@ public void applyMultiValue(T source, M

Re: [PR] Handle Azure style Group member remove operations (rebased) [directory-scimple]

2023-12-15 Thread via GitHub
bdemers commented on code in PR #454: URL: https://github.com/apache/directory-scimple/pull/454#discussion_r1428713069 ## scim-core/src/main/java/org/apache/directory/scim/core/repository/DefaultPatchHandler.java: ## @@ -426,5 +447,48 @@ public void applyMultiValue(T source, M

Re: [PR] Handle Azure style Group member remove operations [directory-scimple]

2023-12-16 Thread via GitHub
kjthorpe18 commented on code in PR #448: URL: https://github.com/apache/directory-scimple/pull/448#discussion_r1428820471 ## scim-core/src/test/java/org/apache/directory/scim/core/repository/PatchHandlerTest.java: ## @@ -465,6 +467,39 @@ public void deleteItemWithComplexFilter()

Re: [PR] Handle Azure style Group member remove operations (rebased) [directory-scimple]

2023-12-16 Thread via GitHub
kjthorpe18 commented on code in PR #454: URL: https://github.com/apache/directory-scimple/pull/454#discussion_r1428820778 ## scim-core/src/main/java/org/apache/directory/scim/core/repository/DefaultPatchHandler.java: ## @@ -426,5 +447,48 @@ public void applyMultiValue(T source

[PR] Bump actions/upload-artifact from 3.1.3 to 4.0.0 [directory-ldap-api]

2023-12-17 Thread via GitHub
dependabot[bot] opened a new pull request, #66: URL: https://github.com/apache/directory-ldap-api/pull/66 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.0.0. Release notes Sourced from https://github.com/actions/upload-artifact/releases"

Re: [PR] Bump github/codeql-action from 2.22.8 to 2.22.9 [directory-kerby]

2023-12-18 Thread via GitHub
dependabot[bot] closed pull request #301: Bump github/codeql-action from 2.22.8 to 2.22.9 URL: https://github.com/apache/directory-kerby/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump github/codeql-action from 2.22.8 to 3.22.11 [directory-kerby]

2023-12-18 Thread via GitHub
dependabot[bot] opened a new pull request, #305: URL: https://github.com/apache/directory-kerby/pull/305 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.8 to 3.22.11. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.

Re: [PR] Bump github/codeql-action from 2.22.8 to 2.22.9 [directory-kerby]

2023-12-18 Thread via GitHub
dependabot[bot] commented on PR #301: URL: https://github.com/apache/directory-kerby/pull/301#issuecomment-1860273402 Superseded by #305. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] Bump actions/upload-artifact from 3.1.3 to 4.0.0 [directory-kerby]

2023-12-18 Thread via GitHub
dependabot[bot] opened a new pull request, #306: URL: https://github.com/apache/directory-kerby/pull/306 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.0.0. Release notes Sourced from https://github.com/actions/upload-artifact/releases";

Re: [PR] Handle Azure style Group member remove operations (rebased) [directory-scimple]

2023-12-18 Thread via GitHub
bdemers commented on PR #454: URL: https://github.com/apache/directory-scimple/pull/454#issuecomment-1860838115 > This looks good to me - I'm fine with using my PR (which I rebased and force pushed) or this one to continue. Nice work! Let's continue working with yours! I'll clean up

[PR] Allow disabling optional features bulk, etags and sorting in ServerCo… [directory-scimple]

2023-12-18 Thread via GitHub
markusmueller opened a new pull request, #455: URL: https://github.com/apache/directory-scimple/pull/455 Bulk, Sorting and Etags are defined optional in the spec. This changes allows subclasses of ServerConfig to disable these features by overwriting the setters. -- This is an automated

Re: [PR] Allow disabling optional features bulk, etags and sorting in ServerCo… [directory-scimple]

2023-12-18 Thread via GitHub
bdemers commented on code in PR #455: URL: https://github.com/apache/directory-scimple/pull/455#discussion_r1430398787 ## scim-server/src/main/java/org/apache/directory/scim/server/configuration/ServerConfiguration.java: ## @@ -86,15 +86,15 @@ public SupportedConfiguration getC

[PR] Bump version.quarkus from 3.6.1 to 3.6.3 [directory-scimple]

2023-12-18 Thread via GitHub
dependabot[bot] opened a new pull request, #456: URL: https://github.com/apache/directory-scimple/pull/456 Bumps `version.quarkus` from 3.6.1 to 3.6.3. Updates `io.quarkus.platform:quarkus-bom` from 3.6.1 to 3.6.3 Commits https://github.com/quarkusio/quarkus-platform/commit/1

[PR] Bump org.apache.directory.project:project from 47 to 48 [directory-scimple]

2023-12-18 Thread via GitHub
dependabot[bot] opened a new pull request, #457: URL: https://github.com/apache/directory-scimple/pull/457 Bumps [org.apache.directory.project:project](https://github.com/apache/directory-project) from 47 to 48. Commits See full diff in https://github.com/apache/directory-proj

[PR] Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.2.2 to 3.2.3 [directory-scimple]

2023-12-18 Thread via GitHub
dependabot[bot] opened a new pull request, #458: URL: https://github.com/apache/directory-scimple/pull/458 Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.2.2 to 3.2.3. Commits https://github.com/apache/maven-surefire/com

[PR] Bump io.rest-assured:rest-assured-bom from 5.3.2 to 5.4.0 [directory-scimple]

2023-12-18 Thread via GitHub
dependabot[bot] opened a new pull request, #460: URL: https://github.com/apache/directory-scimple/pull/460 Bumps [io.rest-assured:rest-assured-bom](https://github.com/rest-assured/rest-assured) from 5.3.2 to 5.4.0. Changelog Sourced from https://github.com/rest-assured/rest-assure

Re: [PR] Bump org.owasp:dependency-check-maven from 8.4.3 to 9.0.4 [directory-scimple]

2023-12-18 Thread via GitHub
dependabot[bot] commented on PR #438: URL: https://github.com/apache/directory-scimple/pull/438#issuecomment-1861138771 Superseded by #459. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] Bump org.owasp:dependency-check-maven from 8.4.3 to 9.0.7 [directory-scimple]

2023-12-18 Thread via GitHub
dependabot[bot] opened a new pull request, #459: URL: https://github.com/apache/directory-scimple/pull/459 Bumps [org.owasp:dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 8.4.3 to 9.0.7. Release notes Sourced from https://github.com/jeremylong/Dependen

Re: [PR] Bump org.owasp:dependency-check-maven from 8.4.3 to 9.0.4 [directory-scimple]

2023-12-18 Thread via GitHub
dependabot[bot] closed pull request #438: Bump org.owasp:dependency-check-maven from 8.4.3 to 9.0.4 URL: https://github.com/apache/directory-scimple/pull/438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] Bump org.glassfish.jersey:jersey-bom from 3.1.4 to 3.1.5 [directory-scimple]

2023-12-18 Thread via GitHub
dependabot[bot] opened a new pull request, #461: URL: https://github.com/apache/directory-scimple/pull/461 Bumps org.glassfish.jersey:jersey-bom from 3.1.4 to 3.1.5. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-na

[PR] Bump org.apache.maven.plugins:maven-surefire-plugin from 3.2.2 to 3.2.3 [directory-scimple]

2023-12-18 Thread via GitHub
dependabot[bot] opened a new pull request, #462: URL: https://github.com/apache/directory-scimple/pull/462 Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.2.2 to 3.2.3. Commits https://github.com/apache/maven-surefire/com

[PR] Bump org.apache.maven.plugins:maven-site-plugin from 4.0.0-M12 to 4.0.0-M13 [directory-scimple]

2023-12-18 Thread via GitHub
dependabot[bot] opened a new pull request, #463: URL: https://github.com/apache/directory-scimple/pull/463 Bumps [org.apache.maven.plugins:maven-site-plugin](https://github.com/apache/maven-site-plugin) from 4.0.0-M12 to 4.0.0-M13. Commits https://github.com/apache/maven-site-

Re: [PR] Allow disabling optional features bulk, etags and sorting in ServerCo… [directory-scimple]

2023-12-18 Thread via GitHub
markusmueller commented on code in PR #455: URL: https://github.com/apache/directory-scimple/pull/455#discussion_r1430471149 ## scim-server/src/main/java/org/apache/directory/scim/server/configuration/ServerConfiguration.java: ## @@ -86,15 +86,15 @@ public SupportedConfiguration

Re: [PR] Allow disabling optional features bulk, etags and sorting in ServerCo… [directory-scimple]

2023-12-18 Thread via GitHub
markusmueller commented on code in PR #455: URL: https://github.com/apache/directory-scimple/pull/455#discussion_r1430471149 ## scim-server/src/main/java/org/apache/directory/scim/server/configuration/ServerConfiguration.java: ## @@ -86,15 +86,15 @@ public SupportedConfiguration

Re: [PR] Bump version.quarkus from 3.6.1 to 3.6.3 [directory-scimple]

2023-12-18 Thread via GitHub
bdemers merged PR #456: URL: https://github.com/apache/directory-scimple/pull/456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@direct

<    8   9   10   11   12   13   14   15   16   17   >