Re: [jira] [Commented] (KAFKA-2132) Move Log4J appender to a separate module

2015-07-06 Thread Stevo Slavić
Hello Jun, I can easily reproduce the issue with previous commit (RAT). While on latest trunk branch: $ git checkout HEAD^ $ gradle clean $ gradle copyDependantLibs $ ls -lart core/build/dependant-libs-2.10.5/ lists slf4j-api-1.7.6.jar and slf4j-api-1.6.1.jar Not sure exactly which modification

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-06 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-972: - Status: Patch Available (was: In Progress) > MetadataRequest returns stale list of brokers > -

Re: Review Request 36030: Patch for KAFKA-972

2015-07-06 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/ --- (Updated July 7, 2015, 6:07 a.m.) Review request for kafka. Bugs: KAFKA-972

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-06 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-972: - Attachment: KAFKA-972_2015-07-06_23:07:34.patch > MetadataRequest returns stale list of brokers > -

[jira] [Commented] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-06 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616238#comment-14616238 ] Ashish K Singh commented on KAFKA-972: -- Updated reviewboard https://reviews.apache.org

Re: Review Request 36030: Patch for KAFKA-972

2015-07-06 Thread Ashish Singh
> On July 6, 2015, 9:47 p.m., Jun Rao wrote: > > Thanks for the patch. A few more minor comments blow. Thanks for the review again Jun! > On July 6, 2015, 9:47 p.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala, line 147 > >

Re: Review Request 36244: Patch for KAFKA-2312

2015-07-06 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36244/#review90651 --- Ship it! Performance-wise, it's a micro-optimization that probably

Re: [ANNOUNCE] New Committer

2015-07-06 Thread gharatmayuresh15
Congratulations! Gwen Mayuresh Sent from my iPhone > On Jul 6, 2015, at 9:46 PM, Jun Rao wrote: > > Gwen, > > Congratulations! > > Jun > >> On Mon, Jul 6, 2015 at 6:08 PM, Joe Stein wrote: >> >> I am pleased to announce that the Apache Kafka PMC has voted to invite Gwen >> Shapira as a co

Re: Review Request 36242: Patch for KAFKA-2311

2015-07-06 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36242/#review90644 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

Re: [jira] [Commented] (KAFKA-2132) Move Log4J appender to a separate module

2015-07-06 Thread Jun Rao
Stevo, I don't see duplicated slf4j-log4j12 jars under core/build/dependant-libs after a clean build in trunk. If this is still an issue, could you file a jira and describe how to reproduce this? Thanks, Jun On Fri, Jun 26, 2015 at 2:19 PM, Stevo Slavić wrote: > Are changes for KAFKA-2132 tic

[jira] [Updated] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-07-06 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-1367: -- Attachment: KAFKA-1367_2015-07-06_22:04:06.patch > Broker topic metadata not kept in sync with Z

[jira] [Updated] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-07-06 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-1367: -- Status: Patch Available (was: In Progress) > Broker topic metadata not kept in sync with ZooKee

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-07-06 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616184#comment-14616184 ] Ashish K Singh commented on KAFKA-1367: --- Updated reviewboard https://reviews.apache.

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-06 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/#review90630 --- core/src/main/scala/kafka/controller/KafkaController.scala (line 42

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-06 Thread Ashish Singh
> On July 7, 2015, 12:36 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala, line 50 > > > > > > This seems to be specific to testIsrAfterBrokerShutDownAndJoinsBack. > > Could w

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-06 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/ --- (Updated July 7, 2015, 5:04 a.m.) Review request for kafka. Bugs: KAFKA-1367

Review Request 36244: Patch for KAFKA-2312

2015-07-06 Thread Tim Brooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36244/ --- Review request for kafka. Bugs: KAFKA-2312 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2312) Use AtomicLong opposed to AtomicReference to store currentThread in consumer

2015-07-06 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616179#comment-14616179 ] Tim Brooks commented on KAFKA-2312: --- Created reviewboard https://reviews.apache.org/r/36

[jira] [Updated] (KAFKA-2312) Use AtomicLong opposed to AtomicReference to store currentThread in consumer

2015-07-06 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2312: -- Attachment: KAFKA-2312.patch > Use AtomicLong opposed to AtomicReference to store currentThread in consu

[jira] [Updated] (KAFKA-2312) Use AtomicLong opposed to AtomicReference to store currentThread in consumer

2015-07-06 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2312: -- Assignee: Tim Brooks Status: Patch Available (was: Open) > Use AtomicLong opposed to AtomicRefere

[jira] [Created] (KAFKA-2312) Use AtomicLong opposed to AtomicReference to store currentThread in consumer

2015-07-06 Thread Tim Brooks (JIRA)
Tim Brooks created KAFKA-2312: - Summary: Use AtomicLong opposed to AtomicReference to store currentThread in consumer Key: KAFKA-2312 URL: https://issues.apache.org/jira/browse/KAFKA-2312 Project: Kafka

Re: [ANNOUNCE] New Committer

2015-07-06 Thread Jun Rao
Gwen, Congratulations! Jun On Mon, Jul 6, 2015 at 6:08 PM, Joe Stein wrote: > I am pleased to announce that the Apache Kafka PMC has voted to invite Gwen > Shapira as a committer and Gwen has accepted. > > Please join me on welcoming and congratulating Gwen. > > Thanks for the contribution bot

Re: [ANNOUNCE] New Committer

2015-07-06 Thread Jay Kreps
Congrats, welcome to the team! -Jay On Mon, Jul 6, 2015 at 6:08 PM, Joe Stein wrote: > I am pleased to announce that the Apache Kafka PMC has voted to invite Gwen > Shapira as a committer and Gwen has accepted. > > Please join me on welcoming and congratulating Gwen. > > Thanks for the contribu

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-07-06 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616158#comment-14616158 ] Tim Brooks commented on KAFKA-2102: --- I can probably take another look at this later this

[jira] [Updated] (KAFKA-2129) Consumer could make multiple concurrent metadata requests

2015-07-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2129: - Resolution: Fixed Status: Resolved (was: Patch Available) > Consumer could make multiple

[jira] [Updated] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

2015-07-06 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2311: -- Assignee: Tim Brooks Status: Patch Available (was: Open) > Consumer's ensureNotClosed method not

[jira] [Commented] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

2015-07-06 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616155#comment-14616155 ] Tim Brooks commented on KAFKA-2311: --- Created reviewboard https://reviews.apache.org/r/36

[jira] [Updated] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

2015-07-06 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2311: -- Attachment: KAFKA-2311.patch > Consumer's ensureNotClosed method not thread safe > -

Review Request 36242: Patch for KAFKA-2311

2015-07-06 Thread Tim Brooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36242/ --- Review request for kafka. Bugs: KAFKA-2311 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

2015-07-06 Thread Tim Brooks (JIRA)
Tim Brooks created KAFKA-2311: - Summary: Consumer's ensureNotClosed method not thread safe Key: KAFKA-2311 URL: https://issues.apache.org/jira/browse/KAFKA-2311 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-2129) Consumer could make multiple concurrent metadata requests

2015-07-06 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616136#comment-14616136 ] Tim Brooks commented on KAFKA-2129: --- Since post-2168 it seems to be explicitly documente

Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-07-06 Thread Ashish Singh
Thanks for your comments and vote guys. KIP-23 passed retroactively with 2 binding +1s and 2 non-binding +1s. On Mon, Jun 29, 2015 at 3:25 PM, Jun Rao wrote: > +1 > > Thanks, > > Jun > > On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh > wrote: > >> Hey Guys, >> >> We had some discussion over mai

Re: [ANNOUNCE] New Committer

2015-07-06 Thread Jiangjie Qin
Congrats, Gwen! On 7/6/15, 7:17 PM, "Jaikiran Pai" wrote: >Congratulations Gwen. > >Gwen has been very helpful in various places (blogs, user mailing lists) >which has helped me (and I'm sure many others) in using Kafka and even >contributing patches. Very well deserved promotion. > >-Jaikiran >

Re: Deprecation of ConsumerOffsetChecker

2015-07-06 Thread Jaikiran Pai
Thanks for explaining, Ewen. -Jaikiran On Thursday 02 July 2015 02:03 PM, Ewen Cheslack-Postava wrote: Jaikiran, After the last KIP discussion, I've been tasked with proposing a policy to address general rules across all public interfaces including APIs, configs, metrics, and command line inter

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/#review90622 --- Thanks for the patch. A few more comments below. 1. The patch doesn

Re: [ANNOUNCE] New Committer

2015-07-06 Thread Jaikiran Pai
Congratulations Gwen. Gwen has been very helpful in various places (blogs, user mailing lists) which has helped me (and I'm sure many others) in using Kafka and even contributing patches. Very well deserved promotion. -Jaikiran On Tuesday 07 July 2015 07:36 AM, Guozhang Wang wrote: Congrats

Re: [ANNOUNCE] New Committer

2015-07-06 Thread Guozhang Wang
Congrats and welcome Gwen! Very-well deserved. Guozhang On Mon, Jul 6, 2015 at 6:16 PM, Ashish Singh wrote: > Congrats Gwen! > > On Monday, July 6, 2015, Joe Stein wrote: > > > I am pleased to announce that the Apache Kafka PMC has voted to invite > Gwen > > Shapira as a committer and Gwen has

Re: [DISCUSS] KIP-26 - Add Copycat, a connector framework for data import/export

2015-07-06 Thread Ewen Cheslack-Postava
On Mon, Jul 6, 2015 at 6:24 PM, Guozhang Wang wrote: > On Mon, Jul 6, 2015 at 4:33 PM, Ewen Cheslack-Postava > wrote: > > > On Mon, Jul 6, 2015 at 11:40 AM, Guozhang Wang > wrote: > > > > > Hi Ewen, > > > > > > I read through the KIP page and here are some comments on the design > > > section:

Re: [ANNOUNCE] New Committer

2015-07-06 Thread Joel Koshy
Congrats Gwen! On Mon, Jul 06, 2015 at 06:08:11PM -0700, Joe Stein wrote: > I am pleased to announce that the Apache Kafka PMC has voted to invite Gwen > Shapira as a committer and Gwen has accepted. > > Please join me on welcoming and congratulating Gwen. > > Thanks for the contribution both in

Re: [ANNOUNCE] New Committer

2015-07-06 Thread Neha Narkhede
Very well deserved. Go Gwen! On Mon, Jul 6, 2015 at 6:20 PM, Todd Palino wrote: > Congrats, Gwen! It's definitely deserved. > > -Todd > > > > On Jul 6, 2015, at 6:08 PM, Joe Stein wrote: > > > > I am pleased to announce that the Apache Kafka PMC has voted to invite > Gwen > > Shapira as a commi

Re: [DISCUSS] KIP-26 - Add Copycat, a connector framework for data import/export

2015-07-06 Thread Guozhang Wang
On Mon, Jul 6, 2015 at 4:33 PM, Ewen Cheslack-Postava wrote: > On Mon, Jul 6, 2015 at 11:40 AM, Guozhang Wang wrote: > > > Hi Ewen, > > > > I read through the KIP page and here are some comments on the design > > section: > > > > 1. "... and Copycat does not require that all partitions be enumer

[jira] [Commented] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616028#comment-14616028 ] Dong Lin commented on KAFKA-2306: - Updated reviewboard https://reviews.apache.org/r/36034/

[jira] [Updated] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2306: Attachment: KAFKA-2306_2015-07-06_18:21:43.patch > New producer should emit metrics for buffer exhaustion >

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/ --- (Updated July 7, 2015, 1:22 a.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Dong Lin
> On July 7, 2015, 12:25 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 254 > > > > > > I think we do not need to create a varialbe here since it

Re: [ANNOUNCE] New Committer

2015-07-06 Thread Todd Palino
Congrats, Gwen! It's definitely deserved. -Todd > On Jul 6, 2015, at 6:08 PM, Joe Stein wrote: > > I am pleased to announce that the Apache Kafka PMC has voted to invite Gwen > Shapira as a committer and Gwen has accepted. > > Please join me on welcoming and congratulating Gwen. > > Thanks f

RE: [ANNOUNCE] New Committer

2015-07-06 Thread Aditya Auradkar
Congratulations Gwen! Aditya From: Ashish Singh [asi...@cloudera.com] Sent: Monday, July 06, 2015 6:16 PM To: dev@kafka.apache.org Subject: Re: [ANNOUNCE] New Committer Congrats Gwen! On Monday, July 6, 2015, Joe Stein wrote: > I am pleased to announce

Re: [ANNOUNCE] New Committer

2015-07-06 Thread Ashish Singh
Congrats Gwen! On Monday, July 6, 2015, Joe Stein wrote: > I am pleased to announce that the Apache Kafka PMC has voted to invite Gwen > Shapira as a committer and Gwen has accepted. > > Please join me on welcoming and congratulating Gwen. > > Thanks for the contribution both in the project (cod

[ANNOUNCE] New Committer

2015-07-06 Thread Joe Stein
I am pleased to announce that the Apache Kafka PMC has voted to invite Gwen Shapira as a committer and Gwen has accepted. Please join me on welcoming and congratulating Gwen. Thanks for the contribution both in the project (code, email, etc, etc, etc) and in throughout the community too(other pro

[jira] [Updated] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-07-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1367: --- Status: In Progress (was: Patch Available) > Broker topic metadata not kept in sync with ZooKeeper >

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/#review90605 --- Thanks for the patch. A few more comments below. core/src/main/sca

Jenkins build is back to normal : Kafka-trunk #526

2015-07-06 Thread Apache Jenkins Server
See

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/#review90614 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

[jira] [Commented] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615922#comment-14615922 ] Joel Koshy commented on KAFKA-2310: --- Is this a dup of KAFKA-1778? https://issues.apach

[jira] [Updated] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-07-06 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2298: -- Reviewer: Joel Koshy > Client Selector can drop connections on InvalidReceiveException without > notify

Re: Build failed in Jenkins: KafkaPreCommit #136

2015-07-06 Thread Jay Kreps
Ha ha, hoisted on our own petard. -Jay On Mon, Jul 6, 2015 at 4:39 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > Changes: > > [junrao] kafka-2248; Use Apache Rat to enforce copyright headers; patched > by Ewen C

Build failed in Jenkins: KafkaPreCommit #136

2015-07-06 Thread Apache Jenkins Server
See Changes: [junrao] kafka-2248; Use Apache Rat to enforce copyright headers; patched by Ewen Cheslack-Postava; reviewed by Gwen Shapira, Joel Joshy and Jun Rao [junrao] kafka-2132; Move Log4J appender to a separate module; patched by

[jira] [Updated] (KAFKA-2132) Move Log4J appender to a separate module

2015-07-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2132: --- Resolution: Fixed Reviewer: Jun Rao (was: Jay Kreps) Fix Version/s: 0.8.3 Status: R

Re: [DISCUSS] KIP-26 - Add Copycat, a connector framework for data import/export

2015-07-06 Thread Ewen Cheslack-Postava
On Mon, Jul 6, 2015 at 11:40 AM, Guozhang Wang wrote: > Hi Ewen, > > I read through the KIP page and here are some comments on the design > section: > > 1. "... and Copycat does not require that all partitions be enumerated". > Not very clear about this, do you mean Copycat allows non-enumerable

Build failed in Jenkins: Kafka-trunk #525

2015-07-06 Thread Apache Jenkins Server
See Changes: [junrao] kafka-2248; Use Apache Rat to enforce copyright headers; patched by Ewen Cheslack-Postava; reviewed by Gwen Shapira, Joel Joshy and Jun Rao -- Started by an SCM change Building

[jira] [Updated] (KAFKA-2248) Use Apache Rat to enforce copyright headers

2015-07-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2248: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks the latest patch. +1 and committed t

[jira] [Commented] (KAFKA-2174) Wrong TopicMetadata deserialization

2015-07-06 Thread Osama Abu-Obeid (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615788#comment-14615788 ] Osama Abu-Obeid commented on KAFKA-2174: Confirmed getting the same issue during c

Re: [DISCUSS] KIP-26 - Add Copycat, a connector framework for data import/export

2015-07-06 Thread Guozhang Wang
Hi Ewen, I read through the KIP page and here are some comments on the design section: 1. "... and Copycat does not require that all partitions be enumerated". Not very clear about this, do you mean Copycat allows non-enumerable stream partitions? 2. "... translates the data to Copycat's format,

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Dong Lin
> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-

[jira] [Commented] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615736#comment-14615736 ] Dong Lin commented on KAFKA-2306: - Updated reviewboard https://reviews.apache.org/r/36034/

[jira] [Updated] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2306: Attachment: KAFKA-2306_2015-07-06_14:54:01.patch > New producer should emit metrics for buffer exhaustion >

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/ --- (Updated July 6, 2015, 9:54 p.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Dong Lin
> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-972: -- Status: In Progress (was: Patch Available) > MetadataRequest returns stale list of brokers > ---

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Guozhang Wang
> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-

Re: Review Request 36030: Patch for KAFKA-972

2015-07-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90579 --- Thanks for the patch. A few more minor comments blow. core/src/tes

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Dong Lin
> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-

[jira] [Comment Edited] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615627#comment-14615627 ] Dong Lin edited comment on KAFKA-2241 at 7/6/15 8:48 PM: - Hi [~jun

[jira] [Commented] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615627#comment-14615627 ] Dong Lin commented on KAFKA-2241: - Hi [~junrao]], could you please review this patch when

[jira] [Commented] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615622#comment-14615622 ] Dong Lin commented on KAFKA-2298: - Joel, could you please review this patch when you have

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Attachment: KAFKA-2310_0.8.2.patch > Add config to prevent broker becoming controller >

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Attachment: (was: KAFKA-2310_0.8.2.patch) > Add config to prevent broker becoming contro

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Attachment: KAFKA-2310_0.8.1.patch > Add config to prevent broker becoming controller >

[jira] [Reopened] (KAFKA-2199) Make signing artifacts optional, setting maven repository possible from command line

2015-07-06 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava reopened KAFKA-2199: -- Needs followup patch applied. > Make signing artifacts optional, setting maven repo

Re: Guozhang Wang elected to Kafka PMC

2015-07-06 Thread Jarek Jarcec Cecho
Congratulations Guozhang! Jarcec > On Jun 15, 2015, at 9:59 PM, Jun Rao wrote: > > Hi, Everyone, > > Guozhang Wang has been active in the Kafka community since he became a > Kafka committer about 7 months ago. I am glad to announce that Guozhang is > now a member of Kafka PMC. > > Congratulat

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/#review90488 --- clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Attachment: KAFKA-2310_0.8.2.patch > Add config to prevent broker becoming controller >

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Status: Patch Available (was: Open) > Add config to prevent broker becoming controller > --

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Attachment: KAFKA-2310.patch > Add config to prevent broker becoming controller > --

[jira] [Commented] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615111#comment-14615111 ] Andrii Biletskyi commented on KAFKA-2310: - Created reviewboard https://reviews.apa

Review Request 36203: Patch for KAFKA-2310

2015-07-06 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36203/ --- Review request for kafka. Bugs: KAFKA-2310 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2310: --- Summary: Add config to prevent broker becoming controller Key: KAFKA-2310 URL: https://issues.apache.org/jira/browse/KAFKA-2310 Project: Kafka Issue Ty