[jira] [Commented] (KAFKA-2347) Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api.

[ https://issues.apache.org/jira/browse/KAFKA-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632276#comment-14632276 ] Ashish K Singh commented on KAFKA-2347: --- Thanks for the info [~becket_qin]. That tur

[jira] [Commented] (KAFKA-2347) Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api.

[ https://issues.apache.org/jira/browse/KAFKA-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632275#comment-14632275 ] Ashish K Singh commented on KAFKA-2347: --- Created reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2347) Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api.

[ https://issues.apache.org/jira/browse/KAFKA-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2347: -- Status: Patch Available (was: Open) > Add setConsumerRebalanceListener method to ZookeeperConsu

[jira] [Updated] (KAFKA-2347) Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api.

[ https://issues.apache.org/jira/browse/KAFKA-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2347: -- Attachment: KAFKA-2347.patch > Add setConsumerRebalanceListener method to ZookeeperConsuemrConne

Review Request 36593: Patch for KAFKA-2347

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/ --- Review request for kafka. Bugs: KAFKA-2347 https://issues.apache.org/jira/b

[jira] [Assigned] (KAFKA-2347) Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api.

[ https://issues.apache.org/jira/browse/KAFKA-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh reassigned KAFKA-2347: - Assignee: Ashish K Singh > Add setConsumerRebalanceListener method to ZookeeperConsuemrCo

[jira] [Commented] (KAFKA-2301) Deprecate ConsumerOffsetChecker

[ https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632270#comment-14632270 ] Ashish K Singh commented on KAFKA-2301: --- [~ewencp], [~junrao] this depends on KAFKA-

[jira] [Commented] (KAFKA-2347) Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api.

[ https://issues.apache.org/jira/browse/KAFKA-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632269#comment-14632269 ] Jiangjie Qin commented on KAFKA-2347: - [~ashishujjain] Sure, actually it was my bad wh

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632268#comment-14632268 ] Ashish K Singh commented on KAFKA-2275: --- [~guozhang] if you agree with the approach

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632267#comment-14632267 ] Ashish K Singh commented on KAFKA-2275: --- [~onurkaraman] let me know if it looks fine

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632265#comment-14632265 ] Ashish K Singh commented on KAFKA-2275: --- Updated reviewboard https://reviews.apache.

[jira] [Commented] (KAFKA-2301) Deprecate ConsumerOffsetChecker

[ https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632264#comment-14632264 ] Ewen Cheslack-Postava commented on KAFKA-2301: -- [~junrao] This looks like a t

[jira] [Updated] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2275: -- Attachment: KAFKA-2275_2015-07-17_21:39:27.patch > Add a ListTopics() API to the new consumer >

Re: Review Request 36548: Patch for KAFKA-2336

> On July 17, 2015, 4:26 a.m., Jiangjie Qin wrote: > > Looks good to me. > > Jiangjie Qin wrote: > Actually do we need to talk to Zookeeper every time? Can we read the data > from topic metadata cache directly? > > Gwen Shapira wrote: > Good point, Jiangjie - looks like partitionFor is

Re: Review Request 36590: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/ --- (Updated July 18, 2015, 4:39 a.m.) Review request for kafka. Bugs: KAFKA-2275

[jira] [Updated] (KAFKA-2301) Deprecate ConsumerOffsetChecker

[ https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2301: - Reviewer: Jun Rao > Deprecate ConsumerOffsetChecker >

Re: [VOTE] KIP-26 Add Copycat connector framework for data import/export

If I'm counting correctly, this passes with 7 binding and 1 non-binding +1s. I'll update the wiki and post an initial patch in the coming days! Thanks everyone for the feedback and for voting! -Ewen On Fri, Jul 17, 2015 at 3:22 PM, Joel Koshy wrote: > +1 > > Thanks, > > Joel > > On Tue, Jul 14

[jira] [Comment Edited] (KAFKA-2260) Allow specifying expected offset on produce

[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632259#comment-14632259 ] Yasuhiro Matsuda edited comment on KAFKA-2260 at 7/18/15 4:16 AM: --

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632259#comment-14632259 ] Yasuhiro Matsuda commented on KAFKA-2260: - Here is the outline of the variant Jay

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338_2015-07-18_00:37:31.patch > Warn users if they change max.message.bytes t

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632244#comment-14632244 ] Edward Ribeiro commented on KAFKA-2338: --- Updated reviewboard https://reviews.apache.

Re: Review Request 36578: Patch for KAFKA-2338

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/ --- (Updated July 18, 2015, 3:37 a.m.) Review request for kafka. Bugs: KAFKA-2338

Re: Review Request 32841: Patch for KAFKA-2041

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32841/ --- (Updated July 18, 2015, 2:46 a.m.) Review request for kafka. Bugs: KAFKA-2041

[jira] [Updated] (KAFKA-2041) Add ability to specify a KeyClass for KafkaLog4jAppender

[ https://issues.apache.org/jira/browse/KAFKA-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benoy Antony updated KAFKA-2041: Attachment: kafka-2041-004.patch Attaching the patch ported to Java. Also added a test case to test

[jira] [Commented] (KAFKA-2347) Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api.

[ https://issues.apache.org/jira/browse/KAFKA-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632227#comment-14632227 ] Ashish K Singh commented on KAFKA-2347: --- [~becket_qin] I might have some cycles to w

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632225#comment-14632225 ] Ewen Cheslack-Postava commented on KAFKA-2260: -- [~bkirwi] That's how I interp

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632224#comment-14632224 ] Ashish K Singh commented on KAFKA-2275: --- [~onurkaraman] my bad, will update the patc

Re: Review Request 36578: Patch for KAFKA-2338

> On July 18, 2015, 12:10 a.m., Ashish Singh wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, lines 56-62 > > > > > > Nit: What changed here? Its always a good idea to keep non-functional > > changes ve

Re: Review Request 36578: Patch for KAFKA-2338

> On July 18, 2015, 12:10 a.m., Ashish Singh wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, line 87 > > > > > > I guess it is unnecessary to parse "0" as int. You can have > > maxMessageSize init to 0

[jira] [Created] (KAFKA-2347) Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api.

Jiangjie Qin created KAFKA-2347: --- Summary: Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api. Key: KAFKA-2347 URL: https://issues.apache.org/jira/browse/KAFKA-2347 Project:

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632213#comment-14632213 ] Onur Karaman commented on KAFKA-2275: - Just to make sure we're on the same page: http

Re: [VOTE] Drop support for Scala 2.9 for the next release

+1 On Fri, Jul 17, 2015 at 10:06 AM, Gwen Shapira wrote: > +1 (binding) > > On Fri, Jul 17, 2015 at 3:26 AM, Ismael Juma wrote: > > Hi all, > > > > I would like to start a vote on dropping support for Scala 2.9 for the > next > > release. People seemed to be in favour of the idea in previous >

[jira] [Commented] (KAFKA-2301) Deprecate ConsumerOffsetChecker

[ https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632151#comment-14632151 ] Ashish K Singh commented on KAFKA-2301: --- [~nehanarkhede] pinging for review. > Depr

[jira] [Commented] (KAFKA-2299) kafka-patch-review tool does not correctly capture testing done

[ https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632154#comment-14632154 ] Ashish K Singh commented on KAFKA-2299: --- [~nehanarkhede] pinging for review. > kafk

[jira] [Commented] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632153#comment-14632153 ] Ashish K Singh commented on KAFKA-313: -- [~nehanarkhede] pinging for review. > Add JSO

Re: Review Request 36578: Patch for KAFKA-2338

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review92145 --- core/src/main/scala/kafka/admin/TopicCommand.scala (lines 56 - 62)

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632137#comment-14632137 ] Ashish K Singh commented on KAFKA-2275: --- Created reviewboard https://reviews.apache.

Review Request 36590: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/ --- Review request for kafka. Bugs: KAFKA-2275 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2275: -- Status: Patch Available (was: Open) > Add a ListTopics() API to the new consumer >

[jira] [Updated] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2275: -- Attachment: KAFKA-2275.patch > Add a ListTopics() API to the new consumer >

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632120#comment-14632120 ] Ben Kirwin commented on KAFKA-2260: --- Interesting -- the idea is that we track the max of

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632113#comment-14632113 ] Ben Kirwin commented on KAFKA-2260: --- Ah, sorry! Let me try again. Suppose you try and s

Re: [VOTE] Drop support for Scala 2.9 for the next release

+1 On Fri, Jul 17, 2015 at 3:26 AM, Ismael Juma wrote: > Hi all, > > I would like to start a vote on dropping support for Scala 2.9 for the next > release. People seemed to be in favour of the idea in previous discussions: > > * http://search-hadoop.com/m/uyzND1uIW3k2fZVfU1 > * http://search-hado

Re: [DISCUSS] KIP-27 - Conditional Publish

Hi all, So, perhaps it's worth adding a couple specific examples of where this feature is useful, to make this a bit more concrete: - Suppose I'm using Kafka as a commit log for a partitioned KV store, like Samza or Pistachio (?) do. We bootstrap the process state by reading from that partition,

Re: [VOTE] KIP-26 Add Copycat connector framework for data import/export

+1 Thanks, Joel On Tue, Jul 14, 2015 at 2:09 PM, Ewen Cheslack-Postava wrote: > Hi all, > > Let's start a vote on KIP-26: Add Copycat connector framework for data > import/export > > For reference, here's the wiki: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=58851767 > An

Re: [DISCUSS] KIP-27 - Conditional Publish

Good concept. I have a question though. Say there are two producers A and B. Both producers are producing to same partition. - A sends a message with expected offset, x1 - Broker accepts is and sends an Ack - B sends a message with expected offset, x1 - Broker rejects it, sends nack - B sends mess

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631868#comment-14631868 ] Ismael Juma commented on KAFKA-1595: That's fine Gwen, it's not blocking anything. I a

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631822#comment-14631822 ] Nick Zalabak commented on KAFKA-824: Can someone confirm that upgrading to zkclient-0.5

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631785#comment-14631785 ] Edward Ribeiro commented on KAFKA-2338: --- Hi [~ewencp], as this my first official Kaf

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338.patch > Warn users if they change max.message.bytes that they also need t

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631784#comment-14631784 ] Edward Ribeiro commented on KAFKA-2338: --- Created reviewboard https://reviews.apache.

Review Request 36578: Patch for KAFKA-2338

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/ --- Review request for kafka. Bugs: KAFKA-2338 https://issues.apache.org/jira/b

Re: [VOTE] Drop support for Scala 2.9 for the next release

+1 (binding) On 17 July 2015 at 10:06, Gwen Shapira wrote: > +1 (binding) > > On Fri, Jul 17, 2015 at 3:26 AM, Ismael Juma wrote: >> Hi all, >> >> I would like to start a vote on dropping support for Scala 2.9 for the next >> release. People seemed to be in favour of the idea in previous discuss

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631772#comment-14631772 ] Aditya Auradkar commented on KAFKA-2205: [~junrao] Another patch ready! > General

Re: Official Kafka Gitter Room?

+1, will be helpful. On Fri, Jul 17, 2015 at 11:28 AM, Grant Henke wrote: > With more of Kafka's development moving to Github is there any interest in > creating a Gitter chat room? > > I think it could be useful to have a place to chat that is associated with > the Kafka repo. Note that we do c

Merge improvements back into Kafka Metrics?

Hi, We've been using the new Kafka Metrics within Voldemort for a little while now, and we have made some improvements to the library that you might like to copy back into Kafka proper. You can view the changes that went in after we forked here: https://github.com/tehuti-io/tehuti/commits/master

Official Kafka Gitter Room?

With more of Kafka's development moving to Github is there any interest in creating a Gitter chat room? I think it could be useful to have a place to chat that is associated with the Kafka repo. Note that we do currently have an IRC channel, but from my experience its a ghost town. I am also open

Re: [DISCUSS] KIP-27 - Conditional Publish

If we have 2 producers producing to a partition, they can be out of order, then how does one producer know what offset to expect as it does not interact with other producer? Can you give an example flow that explains how it works with single producer and with multiple producers? Thanks, Mayures

Build failed in Jenkins: Kafka-trunk #549

See Changes: [cshapi] KAFKA-2345; Attempt to delete a topic already marked for deletion throws ZkNodeExistsException; patched by Ashish Singh; reviewed by Sriharsha Chintalapani and Ismael Juma [cshapi] Adding a file missed while committ

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:20 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631699#comment-14631699 ] Aditya A Auradkar commented on KAFKA-2205: -- Updated reviewboard https://reviews.a

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631700#comment-14631700 ] Gwen Shapira commented on KAFKA-1595: - [~ijuma] - I'll be happy to review, but can't c

[jira] [Updated] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2205: - Attachment: KAFKA-2205_2015-07-17_11:18:31.patch > Generalize TopicConfigManager to handle

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:18 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631694#comment-14631694 ] Aditya A Auradkar commented on KAFKA-2205: -- Updated reviewboard https://reviews.a

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:14 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Updated] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2205: - Attachment: KAFKA-2205_2015-07-17_11:14:26.patch > Generalize TopicConfigManager to handle

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:14 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 34554: Patch for KAFKA-2205

> On July 17, 2015, 4:43 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/ConfigHandler.scala, lines 64-65 > > > > > > Could we just use Pool? Nice.. didn't know about that util. - Aditya ---

Re: Build failed in Jenkins: KafkaPreCommit #156

It's a bit easy for this to happen with the patch workflow. The GitHub one via the merge script fixes it nicely. There are a couple of improvements that need to be done and then I will start a vote on switching to it. Hopefully early next week. Ismael On 17 Jul 2015 18:55, "Gwen Shapira" wrote:

Build failed in Jenkins: KafkaPreCommit #157

See Changes: [cshapi] Adding a file missed while committing KAFKA-2345 -- [...truncated 797 lines...] kafka.log.OffsetMapTest > testBasicValidation PASSED kafka.log.LogManagerTest > testCheckpoint

Re: Build failed in Jenkins: KafkaPreCommit #156

my bad, I missed a file while committing. I did a "trivial" commit with the missing file and I think the build looks ok now. On Fri, Jul 17, 2015 at 10:42 AM, Gwen Shapira wrote: > Ick. It seemed to work locally. I'm checking what went wrong. > > Let me know if you want a revert. > > On Fri, Ju

Re: Build failed in Jenkins: KafkaPreCommit #156

Ick. It seemed to work locally. I'm checking what went wrong. Let me know if you want a revert. On Fri, Jul 17, 2015 at 10:39 AM, Apache Jenkins Server wrote: > See > > Changes: > > [cshapi] KAFKA-2345; Attempt to delete a topic already

Re: Review Request 36548: Patch for KAFKA-2336

> On July 17, 2015, 4:26 a.m., Jiangjie Qin wrote: > > Looks good to me. > > Jiangjie Qin wrote: > Actually do we need to talk to Zookeeper every time? Can we read the data > from topic metadata cache directly? > > Gwen Shapira wrote: > Good point, Jiangjie - looks like partitionFor is

Build failed in Jenkins: KafkaPreCommit #156

See Changes: [cshapi] KAFKA-2345; Attempt to delete a topic already marked for deletion throws ZkNodeExistsException; patched by Ashish Singh; reviewed by Sriharsha Chintalapani and Ismael Juma

[jira] [Updated] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2345: Resolution: Fixed Reviewer: Gwen Shapira Fix Version/s: 0.8.3 Status: Reso

[jira] [Commented] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631645#comment-14631645 ] Gwen Shapira commented on KAFKA-2345: - Thanks for the patch [~singhashish] and for the

Re: Review Request 36548: Patch for KAFKA-2336

> On July 17, 2015, 4:26 a.m., Jiangjie Qin wrote: > > Looks good to me. > > Jiangjie Qin wrote: > Actually do we need to talk to Zookeeper every time? Can we read the data > from topic metadata cache directly? > > Gwen Shapira wrote: > Good point, Jiangjie - looks like partitionFor is

Re: Review Request 36565: Patch for KAFKA-2345

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/#review92106 --- Ship it! - Gwen Shapira On July 17, 2015, 5:21 p.m., Ashish Singh

Re: [DISCUSS] KIP-27 - Conditional Publish

I like this feature, it reminds me of conditional updates in zookeeper. I'm not sure if it'd be best to have some mechanism for fencing rather than a conditional write like you're proposing. The reason I'm saying this is that the conditional write applies to requests individually, while it sound

[jira] [Updated] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2345: -- Attachment: KAFKA-2345_2015-07-17_10:20:55.patch > Attempt to delete a topic already marked for

[jira] [Commented] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631618#comment-14631618 ] Ashish K Singh commented on KAFKA-2345: --- Updated reviewboard https://reviews.apache.

[jira] [Commented] (KAFKA-2344) kafka-merge-pr should support reviewers in commit message

[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631614#comment-14631614 ] Gwen Shapira commented on KAFKA-2344: - Good with me [~ijuma]. The JIRA issue was my o

Re: Review Request 36565: Patch for KAFKA-2345

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/#review92105 --- core/src/main/scala/kafka/common/TopicAlreadyMarkedForDeletionExcep

Re: Review Request 36565: Patch for KAFKA-2345

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/ --- (Updated July 17, 2015, 5:21 p.m.) Review request for kafka. Bugs: KAFKA-2345

Re: [VOTE] Drop support for Scala 2.9 for the next release

+1 (binding) On Fri, Jul 17, 2015 at 3:26 AM, Ismael Juma wrote: > Hi all, > > I would like to start a vote on dropping support for Scala 2.9 for the next > release. People seemed to be in favour of the idea in previous discussions: > > * http://search-hadoop.com/m/uyzND1uIW3k2fZVfU1 > * http://s

[jira] [Commented] (KAFKA-2344) kafka-merge-pr should support reviewers in commit message

[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631564#comment-14631564 ] Ismael Juma commented on KAFKA-2344: I renamed the JIRA title, I hope you don't mind.

[jira] [Updated] (KAFKA-2344) kafka-merge-pr should support reviewers in commit message

[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2344: --- Summary: kafka-merge-pr should support reviewers in commit message (was: Improvements for the pr-merg

[jira] [Assigned] (KAFKA-2344) Improvements for the pr-merge tool

[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-2344: -- Assignee: Ismael Juma > Improvements for the pr-merge tool > --

[jira] [Updated] (KAFKA-2328) merge-kafka-pr.py script should not leave user in a detached branch

[ https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2328: --- Status: Patch Available (was: Open) Looks like definite bug, PR fixes it. [~gwenshap] or [~guozhang],

[jira] [Commented] (KAFKA-2328) merge-kafka-pr.py script should not leave user in a detached branch

[ https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631543#comment-14631543 ] ASF GitHub Bot commented on KAFKA-2328: --- GitHub user ijuma opened a pull request:

[GitHub] kafka pull request: KAFKA-2328; merge-kafka-pr.py script should no...

GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/84 KAFKA-2328; merge-kafka-pr.py script should not leave user in a detached branch The right command to get the branch name is `git rev-parse --abbrev-ref HEAD` instead of `git rev-parse HEAD`. The latter

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1901: -- Status: In Progress (was: Patch Available) > Move Kafka version to be generated in code by build (inste

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review92078 --- clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.j

Re: [VOTE] Drop support for Scala 2.9 for the next release

+1 (binding) On Fri, Jul 17, 2015 at 8:33 AM, Brock Noland wrote: > +1 (non-binding) > > On Friday, July 17, 2015, Grant Henke wrote: > > > +1 (non-binding) > > > > On Fri, Jul 17, 2015 at 9:44 AM, Ashish Singh > > wrote: > > > > > +1 (non-binding) > > > > > > On Friday, July 17, 2015, Stevo S

[jira] [Updated] (KAFKA-2337) Verify that metric names will not collide when creating new topics

[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2337: --- Attachment: KAFKA-2337_2015-07-17_11:17:30.patch > Verify that metric names will not collide when crea

[jira] [Commented] (KAFKA-2337) Verify that metric names will not collide when creating new topics

[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631525#comment-14631525 ] Grant Henke commented on KAFKA-2337: Updated reviewboard https://reviews.apache.org/r/

Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/ --- (Updated July 17, 2015, 4:17 p.m.) Review request for kafka. Bugs: KAFKA-2337

Re: Review Request 36570: Patch for KAFKA-2337

> On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/common/Topic.scala, line 64 > > > > > > *Maybe* this method name could be renamed to 'collide' to make it more > > like a verb instea

Re: Review Request 36570: Patch for KAFKA-2337

> On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/common/Topic.scala, line 64 > > > > > > *Maybe* this method name could be renamed to 'collide' to make it more > > like a verb instea

  1   2   >