[GitHub] [lucene-solr] mocobeta commented on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module

2019-04-07 Thread GitBox
mocobeta commented on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module URL: https://github.com/apache/lucene-solr/pull/618#issuecomment-480571380 Hi, I got done with comprehensive interface testing on my Windows/Linux PCs, fixed bugs, made some minor improvements. Seems all f

[GitHub] [lucene-solr] mocobeta edited a comment on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module

2019-04-07 Thread GitBox
mocobeta edited a comment on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module URL: https://github.com/apache/lucene-solr/pull/618#issuecomment-480571380 Hi, I got done with comprehensive interface testing on my Windows/Linux PCs, fixed bugs, made some minor improvements. See

[GitHub] [lucene-solr] mocobeta edited a comment on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module

2019-04-07 Thread GitBox
mocobeta edited a comment on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module URL: https://github.com/apache/lucene-solr/pull/618#issuecomment-480571380 Hi, I got done with comprehensive interface testing on my Windows/Linux PCs, fixed bugs, made some minor improvements. See

[GitHub] [lucene-solr] uschindler commented on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module

2019-04-07 Thread GitBox
uschindler commented on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module URL: https://github.com/apache/lucene-solr/pull/618#issuecomment-480579706 Hi @mocobeta, +1 to merge it soon. Please check your private mail, we have some good news for you. I will soon push this bra

[GitHub] [lucene-solr] uschindler edited a comment on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module

2019-04-07 Thread GitBox
uschindler edited a comment on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module URL: https://github.com/apache/lucene-solr/pull/618#issuecomment-480579706 Hi @mocobeta, +1 to merge it soon. Please check your private mail, we have some good news for you. I will soon push

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #455: SOLR-12638

2019-04-07 Thread GitBox
dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r272887687 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -1959,6 +1959,21 @@ public boolean isUsableForChildDocs()

[GitHub] [lucene-solr] jpountz commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-07 Thread GitBox
jpountz commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r272899650 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-07 Thread GitBox
jpountz commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r272899879 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-07 Thread GitBox
jpountz commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r272899201 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java ##

[GitHub] [lucene-solr] moshebla commented on issue #455: SOLR-12638

2019-04-08 Thread GitBox
moshebla commented on issue #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#issuecomment-480731792 > Thanks for taking a stab at this. Sometimes I think the "atomic"-ness gets more visibility in features/naming than the "partial-update"-ness that goes along with it, wh

[GitHub] [lucene-solr] moshebla commented on issue #455: SOLR-12638

2019-04-08 Thread GitBox
moshebla commented on issue #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#issuecomment-480732116 > OH; we're missing updates to the Ref Guide! See `updating-parts-of-documents.adoc`. You could also add a link & mention in the indexing side of the page on nested docs

[GitHub] [lucene-solr] moshebla edited a comment on issue #455: SOLR-12638

2019-04-08 Thread GitBox
moshebla edited a comment on issue #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#issuecomment-480731792 > Thanks for taking a stab at this. Sometimes I think the "atomic"-ness gets more visibility in features/naming than the "partial-update"-ness that goes along with

[GitHub] [lucene-solr] s1monw commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
s1monw commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r272982607 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java ## @

[GitHub] [lucene-solr] s1monw commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
s1monw commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r272983432 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java ## @

[GitHub] [lucene-solr] s1monw commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
s1monw commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r272983458 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java ## @

[GitHub] [lucene-solr] s1monw commented on issue #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
s1monw commented on issue #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#issuecomment-480779441 @jpountz I pushed new commits This is an automated

[GitHub] [lucene-solr] dsmiley commented on issue #455: SOLR-12638

2019-04-08 Thread GitBox
dsmiley commented on issue #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#issuecomment-480806665 Another PR is fine. I attached the patch version of this to JIRA and enabled patch review. I'm looking forward to seeing this one done! -

[GitHub] [lucene-solr] ollik1 opened a new pull request #638: LUCENE-8756: Fix MLT like text with custom frequencies

2019-04-08 Thread GitBox
ollik1 opened a new pull request #638: LUCENE-8756: Fix MLT like text with custom frequencies URL: https://github.com/apache/lucene-solr/pull/638 When an analyzer with custom term frequencies is used with MLT like texts, the custom term frequencies are incorrectly omitted and a fixed

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
mikemccand commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r273118641 ## File path: lucene/CHANGES.txt ## @@ -62,6 +62,9 @@ Bug fixes Scorer in

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
mikemccand commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r273119818 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50Postings

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
mikemccand commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r273124637 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java #

[GitHub] [lucene-solr] s1monw commented on issue #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
s1monw commented on issue #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#issuecomment-480902394 @mikemccand pushed changes This is an automated me

[GitHub] [lucene-solr] jpountz commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
jpountz commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r273339633 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java ##

[GitHub] [lucene-solr] uschindler commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
uschindler commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r273345219 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java #

[GitHub] [lucene-solr] uschindler commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-08 Thread GitBox
uschindler commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r273345219 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java #

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-04-09 Thread GitBox
diegoceccarelli commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r273444073 ## File path: solr/core/src/java/org/apache/solr/search/grouping/dis

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-04-09 Thread GitBox
diegoceccarelli commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r273634722 ## File path: solr/core/src/java/org/apache/solr/search/grouping/dis

[GitHub] [lucene-solr] dsmiley closed pull request #455: SOLR-12638

2019-04-10 Thread GitBox
dsmiley closed pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene-solr] s1monw commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-10 Thread GitBox
s1monw commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r273822504 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java ## @

[GitHub] [lucene-solr] s1monw merged pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo

2019-04-10 Thread GitBox
s1monw merged pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637 This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] chatman commented on a change in pull request #597: [SOLR-13272] feat(facet/interval): support json facet requests for interval facet

2019-04-10 Thread GitBox
chatman commented on a change in pull request #597: [SOLR-13272] feat(facet/interval): support json facet requests for interval facet URL: https://github.com/apache/lucene-solr/pull/597#discussion_r273843687 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetInterva

[GitHub] [lucene-solr] chatman commented on a change in pull request #597: [SOLR-13272] feat(facet/interval): support json facet requests for interval facet

2019-04-10 Thread GitBox
chatman commented on a change in pull request #597: [SOLR-13272] feat(facet/interval): support json facet requests for interval facet URL: https://github.com/apache/lucene-solr/pull/597#discussion_r273843687 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetInterva

[GitHub] [lucene-solr] mocobeta commented on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module

2019-04-10 Thread GitBox
mocobeta commented on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module URL: https://github.com/apache/lucene-solr/pull/618#issuecomment-481637304 This was merged to Apache Lucene master and branch_8x. This is an automa

[GitHub] [lucene-solr] mocobeta closed pull request #618: #Lucene-2562: Make Luke a Lucene/Solr Module

2019-04-10 Thread GitBox
mocobeta closed pull request #618: #Lucene-2562: Make Luke a Lucene/Solr Module URL: https://github.com/apache/lucene-solr/pull/618 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene-solr] mengbin16 opened a new pull request #639: Solve the problem of highlighting Chinese inaccurately.

2019-04-10 Thread GitBox
mengbin16 opened a new pull request #639: Solve the problem of highlighting Chinese inaccurately. URL: https://github.com/apache/lucene-solr/pull/639 I found a bug. When I am highlighting Chinese, extra phrases are highlighted. I solved it according to my understanding. I added a t

[GitHub] [lucene-solr] s1monw opened a new pull request #640: LUCENE-8671: Introduce Reader attributes

2019-04-10 Thread GitBox
s1monw opened a new pull request #640: LUCENE-8671: Introduce Reader attributes URL: https://github.com/apache/lucene-solr/pull/640 Reader attributes allows a per IndexReader configuration of codec internals. For instance this allows a per reader configuration if FSTs are loaded into mem

[GitHub] [lucene-solr] s1monw commented on issue #640: LUCENE-8671: Introduce Reader attributes

2019-04-10 Thread GitBox
s1monw commented on issue #640: LUCENE-8671: Introduce Reader attributes URL: https://github.com/apache/lucene-solr/pull/640#issuecomment-481706543 it's still a bit rough and misses javadocs etc. but I wanted to get the idea out.

[GitHub] [lucene-solr] jefferyyuan opened a new pull request #641: Move versionBucketLockTimeoutMs into VersionInfo

2019-04-10 Thread GitBox
jefferyyuan opened a new pull request #641: Move versionBucketLockTimeoutMs into VersionInfo URL: https://github.com/apache/lucene-solr/pull/641 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #162: SOLR-8776: Support RankQuery in grouping

2019-04-11 Thread GitBox
romseygeek commented on a change in pull request #162: SOLR-8776: Support RankQuery in grouping URL: https://github.com/apache/lucene-solr/pull/162#discussion_r274321223 ## File path: lucene/grouping/src/java/org/apache/lucene/search/grouping/SecondPassGroupingCollector.java #

[GitHub] [lucene-solr] janhoy opened a new pull request #642: SOLR-12860: MetricsHistoryHandler now always uses PKI Auth

2019-04-11 Thread GitBox
janhoy opened a new pull request #642: SOLR-12860: MetricsHistoryHandler now always uses PKI Auth URL: https://github.com/apache/lucene-solr/pull/642 This gets rid of the 401 errors currently seen when using e.g. basic auth.

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests)

2019-04-11 Thread GitBox
diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests) URL: https://github.com/apache/lucene-solr/pull/636#discussion_r274348734 ## File path: solr/core/src/java/org/apache/solr/

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests)

2019-04-11 Thread GitBox
diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests) URL: https://github.com/apache/lucene-solr/pull/636#discussion_r274350016 ## File path: solr/core/src/java/org/apache/solr/

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests)

2019-04-11 Thread GitBox
diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests) URL: https://github.com/apache/lucene-solr/pull/636#discussion_r274355703 ## File path: solr/core/src/java/org/apache/solr/

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests)

2019-04-11 Thread GitBox
diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests) URL: https://github.com/apache/lucene-solr/pull/636#discussion_r274357188 ## File path: solr/core/src/test/org/apache/solr

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests)

2019-04-11 Thread GitBox
diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added support for rows=x in /export to limit number of docs exported (With unit tests) URL: https://github.com/apache/lucene-solr/pull/636#discussion_r274350444 ## File path: solr/core/src/java/org/apache/solr/

[GitHub] [lucene-solr] NazerkeBS opened a new pull request #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-11 Thread GitBox
NazerkeBS opened a new pull request #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643 @joel-bernstein, please have a look to the code. This is an auto

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #640: LUCENE-8671: Introduce Reader attributes

2019-04-11 Thread GitBox
mikemccand commented on a change in pull request #640: LUCENE-8671: Introduce Reader attributes URL: https://github.com/apache/lucene-solr/pull/640#discussion_r274496177 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsReader.java ## @@

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #640: LUCENE-8671: Introduce Reader attributes

2019-04-11 Thread GitBox
mikemccand commented on a change in pull request #640: LUCENE-8671: Introduce Reader attributes URL: https://github.com/apache/lucene-solr/pull/640#discussion_r274495805 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsReader.java ## @@

[GitHub] [lucene-solr] kesharee opened a new pull request #644: SOLR-13394: Change default GC from CMS to G1

2019-04-11 Thread GitBox
kesharee opened a new pull request #644: SOLR-13394: Change default GC from CMS to G1 URL: https://github.com/apache/lucene-solr/pull/644 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [lucene-solr] janhoy opened a new pull request #645: SOLR-12121 Refresh JWK from IdP on invalid sig

2019-04-12 Thread GitBox
janhoy opened a new pull request #645: SOLR-12121 Refresh JWK from IdP on invalid sig URL: https://github.com/apache/lucene-solr/pull/645 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [lucene-solr] s1monw commented on a change in pull request #640: LUCENE-8671: Introduce Reader attributes

2019-04-12 Thread GitBox
s1monw commented on a change in pull request #640: LUCENE-8671: Introduce Reader attributes URL: https://github.com/apache/lucene-solr/pull/640#discussion_r274786488 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsReader.java ## @@ -75,

[GitHub] [lucene-solr] s1monw commented on a change in pull request #640: LUCENE-8671: Introduce Reader attributes

2019-04-12 Thread GitBox
s1monw commented on a change in pull request #640: LUCENE-8671: Introduce Reader attributes URL: https://github.com/apache/lucene-solr/pull/640#discussion_r274790221 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsReader.java ## @@ -156

[GitHub] [lucene-solr] s1monw commented on issue #640: LUCENE-8671: Introduce Reader attributes

2019-04-12 Thread GitBox
s1monw commented on issue #640: LUCENE-8671: Introduce Reader attributes URL: https://github.com/apache/lucene-solr/pull/640#issuecomment-482471238 @jpountz thanks for the review @mikemccand I pushed updates for your comments

[GitHub] [lucene-solr] janhoy closed pull request #645: SOLR-12121 Refresh JWK from IdP on invalid sig

2019-04-12 Thread GitBox
janhoy closed pull request #645: SOLR-12121 Refresh JWK from IdP on invalid sig URL: https://github.com/apache/lucene-solr/pull/645 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene-solr] janhoy commented on issue #645: SOLR-12121 Refresh JWK from IdP on invalid sig

2019-04-12 Thread GitBox
janhoy commented on issue #645: SOLR-12121 Refresh JWK from IdP on invalid sig URL: https://github.com/apache/lucene-solr/pull/645#issuecomment-482483037 (Squash) merged This is an automated message from the Apache Git Service

[GitHub] [lucene-solr] janhoy merged pull request #642: SOLR-12860: MetricsHistoryHandler now always uses PKI Auth

2019-04-12 Thread GitBox
janhoy merged pull request #642: SOLR-12860: MetricsHistoryHandler now always uses PKI Auth URL: https://github.com/apache/lucene-solr/pull/642 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [lucene-solr] NazerkeBS commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
NazerkeBS commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482549905 I added a separate test for the variance and the standard deviation. It works now. -

[GitHub] [lucene-solr] NazerkeBS edited a comment on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
NazerkeBS edited a comment on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482549905 I added a separate test for the variance and the standard deviation. The test passes. ---

[GitHub] [lucene-solr] joel-bernstein commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
joel-bernstein commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482569350 Here is how it looks from Zeppelin-Solr interpreter https://user-images.githubusercontent.com/5747955/56039

[GitHub] [lucene-solr] joel-bernstein edited a comment on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
joel-bernstein edited a comment on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482569350 Here is how it looks from Zeppelin-Solr interpreter --

[GitHub] [lucene-solr] joel-bernstein edited a comment on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
joel-bernstein edited a comment on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482569350 Here is how it looks from Zeppelin-Solr interpreter https://user-images.githubusercontent.com/574795

[GitHub] [lucene-solr] joel-bernstein edited a comment on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
joel-bernstein edited a comment on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482569350 Here is how it looks from the Zeppelin-Solr interpreter https://user-images.githubusercontent.com/57

[GitHub] [lucene-solr] joel-bernstein removed a comment on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
joel-bernstein removed a comment on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482570071 https://user-images.githubusercontent.com/5747955/56039861-40812000-5d03-11e9-80a7-f06590c72771.pn

[GitHub] [lucene-solr] joel-bernstein commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
joel-bernstein commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482570071 https://user-images.githubusercontent.com/5747955/56039861-40812000-5d03-11e9-80a7-f06590c72771.png";>

[GitHub] [lucene-solr] joel-bernstein commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
joel-bernstein commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482572344 This is pretty much ready to go. Thanks again for the contribution. I should be able to get this in for

[GitHub] [lucene-solr] NazerkeBS commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
NazerkeBS commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482579769 I think, that is fine. In the future I would like to contribute more for streaming expressions as I am working on

[GitHub] [lucene-solr] joel-bernstein commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
joel-bernstein commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482589219 > I think, that is fine. In the future I would like to contribute more for streaming expressions as I am work

[GitHub] [lucene-solr] NazerkeBS commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
NazerkeBS commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482605657 I would be so grateful if you could give me a few suggestions to work on.

[GitHub] [lucene-solr] joel-bernstein commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators

2019-04-12 Thread GitBox
joel-bernstein commented on issue #643: SOLR-13391: Add variance and standard deviation stream evaluators URL: https://github.com/apache/lucene-solr/pull/643#issuecomment-482613805 Ok, this is a great ticket to work on: https://issues.apache.org/jira/browse/SOLR-13047 I'll update it w

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #579: LUCENE-8681: prorated early termination

2019-04-12 Thread GitBox
mikemccand commented on a change in pull request #579: LUCENE-8681: prorated early termination URL: https://github.com/apache/lucene-solr/pull/579#discussion_r274964396 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ## @@ -165,11 +169,35

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-04-12 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r275043339 ## File path: solr/core/src/java/org/apache/solr/search/grouping/distribu

[GitHub] [lucene-solr] mocobeta closed pull request #632: LUCENE-8752: Add a Kuromoji dictionary entry for Japanese new era 令和(Reiwa)

2019-04-13 Thread GitBox
mocobeta closed pull request #632: LUCENE-8752: Add a Kuromoji dictionary entry for Japanese new era 令和(Reiwa) URL: https://github.com/apache/lucene-solr/pull/632 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] mocobeta commented on issue #632: LUCENE-8752: Add a Kuromoji dictionary entry for Japanese new era 令和(Reiwa)

2019-04-13 Thread GitBox
mocobeta commented on issue #632: LUCENE-8752: Add a Kuromoji dictionary entry for Japanese new era 令和(Reiwa) URL: https://github.com/apache/lucene-solr/pull/632#issuecomment-482805606 This was merged to master & branch_8x. T

[GitHub] [lucene-solr] janhoy opened a new pull request #646: SOLR-12371: Fix unintended security edit API caching in standalone mode

2019-04-14 Thread GitBox
janhoy opened a new pull request #646: SOLR-12371: Fix unintended security edit API caching in standalone mode URL: https://github.com/apache/lucene-solr/pull/646 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] moshebla opened a new pull request #647: SOLR-12638: Added docs in the ref-guide for nested atomic updates

2019-04-15 Thread GitBox
moshebla opened a new pull request #647: SOLR-12638: Added docs in the ref-guide for nested atomic updates URL: https://github.com/apache/lucene-solr/pull/647 This is an automated message from the Apache Git Service. To resp

[GitHub] [lucene-solr] moshebla commented on issue #647: SOLR-12638: Added docs in the ref-guide for nested atomic updates

2019-04-15 Thread GitBox
moshebla commented on issue #647: SOLR-12638: Added docs in the ref-guide for nested atomic updates URL: https://github.com/apache/lucene-solr/pull/647#issuecomment-483225382 This PR adds docs for nested/partial updates #455 . ---

[GitHub] [lucene-solr] msokolov commented on a change in pull request #579: LUCENE-8681: prorated early termination

2019-04-15 Thread GitBox
msokolov commented on a change in pull request #579: LUCENE-8681: prorated early termination URL: https://github.com/apache/lucene-solr/pull/579#discussion_r275490738 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ## @@ -165,11 +169,35 @

[GitHub] [lucene-solr] s1monw merged pull request #640: LUCENE-8671: Introduce Reader attributes

2019-04-15 Thread GitBox
s1monw merged pull request #640: LUCENE-8671: Introduce Reader attributes URL: https://github.com/apache/lucene-solr/pull/640 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene-solr] mocobeta edited a comment on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module

2019-04-16 Thread GitBox
mocobeta edited a comment on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module URL: https://github.com/apache/lucene-solr/pull/618#issuecomment-481637304 This was merged to Apache Lucene master and branch_8x. https://github.com/apache/lucene-solr/commit/3a78c1999a8716669c574448b2

[GitHub] [lucene-solr] romseygeek opened a new pull request #648: LUCENE-8766: Add Luwak as a lucene module

2019-04-16 Thread GitBox
romseygeek opened a new pull request #648: LUCENE-8766: Add Luwak as a lucene module URL: https://github.com/apache/lucene-solr/pull/648 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [lucene-solr] s1monw opened a new pull request #649: Use Map.copyOf in lucene core

2019-04-16 Thread GitBox
s1monw opened a new pull request #649: Use Map.copyOf in lucene core URL: https://github.com/apache/lucene-solr/pull/649 This cuts over several places that use the pattern of creating a copy of the supplied map with Map.copyOf.

[GitHub] [lucene-solr] s1monw merged pull request #649: Use Map.copyOf in lucene core

2019-04-17 Thread GitBox
s1monw merged pull request #649: Use Map.copyOf in lucene core URL: https://github.com/apache/lucene-solr/pull/649 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [lucene-solr] uschindler commented on a change in pull request #644: SOLR-13394: Change default GC from CMS to G1

2019-04-17 Thread GitBox
uschindler commented on a change in pull request #644: SOLR-13394: Change default GC from CMS to G1 URL: https://github.com/apache/lucene-solr/pull/644#discussion_r276282835 ## File path: solr/bin/solr.cmd ## @@ -1167,20 +1167,14 @@ set SOLR_OPTS=%SOLR_JAVA_STACK_SIZE% %SO

[GitHub] [lucene-solr] danmuzi opened a new pull request #650: LUCENE-8768: Javadoc search support

2019-04-17 Thread GitBox
danmuzi opened a new pull request #650: LUCENE-8768: Javadoc search support URL: https://github.com/apache/lucene-solr/pull/650 This is a PR to support **"Javadoc search"** released in Java 9. **[Before - Lucene Nightly Core Module Javadoc]** ![javadoc-nightly](https://user-images

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-04-18 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r276714459 ## File path: solr/core/src/java/org/apache/solr/search/grouping/distribu

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-04-18 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r276777359 ## File path: solr/core/src/java/org/apache/solr/search/grouping/distribu

[GitHub] [lucene-solr] kesharee commented on a change in pull request #644: SOLR-13394: Change default GC from CMS to G1

2019-04-18 Thread GitBox
kesharee commented on a change in pull request #644: SOLR-13394: Change default GC from CMS to G1 URL: https://github.com/apache/lucene-solr/pull/644#discussion_r276788540 ## File path: solr/bin/solr.cmd ## @@ -1167,20 +1167,14 @@ set SOLR_OPTS=%SOLR_JAVA_STACK_SIZE% %SOLR

[GitHub] [lucene-solr] johann-beessip opened a new pull request #651: Performance improvement for update?optimize=true

2019-04-18 Thread GitBox
johann-beessip opened a new pull request #651: Performance improvement for update?optimize=true URL: https://github.com/apache/lucene-solr/pull/651 For our use case we have a small number of documents with a large number of docValues. During optimize we noticed a lot of time being spent i

[GitHub] [lucene] zacharymorn commented on a diff in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-03 Thread GitBox
zacharymorn commented on code in PR #767: URL: https://github.com/apache/lucene/pull/767#discussion_r841309603 ## lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java: ## @@ -31,42 +28,21 @@ /** * A {@link Query} that matches documents that have a valu

[GitHub] [lucene] zacharymorn commented on a diff in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-03 Thread GitBox
zacharymorn commented on code in PR #767: URL: https://github.com/apache/lucene/pull/767#discussion_r841312352 ## lucene/core/src/java/org/apache/lucene/search/FieldExistsQuery.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #1: Fix markup conversion error

2022-06-29 Thread GitBox
mocobeta opened a new issue, #1: URL: https://github.com/apache/lucene-jira-archive/issues/1 There are various errors in converting Jira markup to Markdown. For example: - tables are broken - bullet lists converted to bold blocks (?) - bullet lists include unnecessary spaces b

[GitHub] [lucene-jira-archive] dweiss commented on issue #1: Fix markup conversion error

2022-06-29 Thread GitBox
dweiss commented on issue #1: URL: https://github.com/apache/lucene-jira-archive/issues/1#issuecomment-1169793482 ![image](https://user-images.githubusercontent.com/199470/176411524-9d1a8998-09cb-4544-9890-282ba1ff8b31.png) This is what the bold block-issue looks like. -- This is

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #2: Archive all Jira attachments

2022-06-29 Thread GitBox
mocobeta opened a new issue, #2: URL: https://github.com/apache/lucene-jira-archive/issues/2 All attachments should be archived in `attachments/`. They will be referred from the migrated issues in https://github.com/apache/lucene. For files with the same names, we keep the latest versions

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #3: Create mapping on Jira user id -> GitHub account

2022-06-29 Thread GitBox
mocobeta opened a new issue, #3: URL: https://github.com/apache/lucene-jira-archive/issues/3 To correctly map Jira user ids in issues (reporter/assignee/author) to GitHub account, we need an account mapping file. This could be inferred from https://github.com/orgs/apache/people? -- Thi

[GitHub] [lucene-jira-archive] mocobeta commented on issue #1: Fix markup conversion error

2022-06-29 Thread GitBox
mocobeta commented on issue #1: URL: https://github.com/apache/lucene-jira-archive/issues/1#issuecomment-1169860211 Thanks for reporting. I found Jira's number list (`#`) is not correctly converted and it is interpreted as headers in Markdown. Jira dump ``` "body": "I'm

[GitHub] [lucene-solr] mikemccand commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search

2019-09-02 Thread GitBox
mikemccand commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-527262380 > > > I'm trying to understand the behavior change Lucene users will see with this, when using concurrent

[GitHub] [lucene-solr] atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search

2019-09-02 Thread GitBox
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-527284505 > https://issues.apache.org/jira/browse/LUCENE-8681 I am not sure I see how that solves the problem?

[GitHub] [lucene-solr] atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search

2019-09-02 Thread GitBox
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-527285002 > > https://issues.apache.org/jira/browse/LUCENE-8681 > > I am not sure I see how that solves the problem

[GitHub] [lucene-solr] jpountz commented on a change in pull request #851: LUCENE-8960: Add LatLonDocValuesPointInPolygonQuery

2019-09-03 Thread GitBox
jpountz commented on a change in pull request #851: LUCENE-8960: Add LatLonDocValuesPointInPolygonQuery URL: https://github.com/apache/lucene-solr/pull/851#discussion_r320121607 ## File path: lucene/core/src/java/org/apache/lucene/document/LatLonDocValuesPointInPolygonQuery.java #

[GitHub] [lucene-solr] iverase merged pull request #851: LUCENE-8960: Add LatLonDocValuesPointInPolygonQuery

2019-09-03 Thread GitBox
iverase merged pull request #851: LUCENE-8960: Add LatLonDocValuesPointInPolygonQuery URL: https://github.com/apache/lucene-solr/pull/851 This is an automated message from the Apache Git Service. To respond to the message, p

  1   2   3   4   5   6   7   8   9   10   >