Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/774#discussion_r150620372
--- Diff: bundles-maven-plugin/README.md ---
@@ -0,0 +1,230 @@
+
+# Apache Metron Bundle Maven Plugin
+
+Apache Metron Bundles Maven
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/840
6.0 was released, should we consider going to that while we are at it?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/774
@nickwallen I have added a usage document in the last commit. Is this what
you are looking for?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/774#discussion_r151198323
--- Diff: bundles-maven-plugin/README.md ---
@@ -0,0 +1,230 @@
+
+# Apache Metron Bundle Maven Plugin
+
+Apache Metron Bundles Maven
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/844
Are there any consequences for users with external, existing and older bro
installations? Will they have to upgrade bro if they take this build?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/844
Ran tests as described, everything worked according to steps.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/844
Is there some way to document these PCAPS?
Could we have a script that does what you do here just checked in?
I think this would be useful.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/844
The documentation in the template is nice. After 777, when each parser has
a readme, this documentation of the index fields should be in the bro readme.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/844#discussion_r152052808
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/bro/BasicBroParserTest.java
---
@@ -1133,6 +1133,233 @@ public void
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/844
I am +1 pending travis.
Reviewed code
Ran build and tests ( after fix*)
Followed test instructions.
Great work @JonZeolla
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/845#discussion_r152069979
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -614,8 +625,15
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/844
That is fine. We should surface them regardless at some point. Burying
them in the deployment is not ideal. How they index is an important part of
any parser's base functionality.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/844
Documentation that cannot be found doesn't exist, people who aren't devs
aren't going to look in the deployment code
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/845#discussion_r152081656
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -614,8 +625,15
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/845
+1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/844
+1 - wtg
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/841
+1, ship it
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
Bump?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
Great catch! Moved it out.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/774
I have refactored to have a top level metron-bundles directory, with the
bundles lib and bundles testing under there.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/846
Thanks for the contribution! This is a great idea. If I may, I think this
may be more clear:
```bash
if docker info 2>&1 | grep -q 'Cannot connect to the Docker daem
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/846
I would prefer it always say docker is running or not, but this will work.
+1
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/848
METRON-1333 Ensure that ansible-docker can be used to build metron (
including rpms )
The ansible-docker container could be used to build metron ( even the rpms
) and run the ansible scripts
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/849#discussion_r153322627
--- Diff: metron-deployment/scripts/platform-info.sh ---
@@ -73,6 +73,30 @@ echo "--"
echo "npm"
npm --version
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/849#discussion_r153322856
--- Diff: metron-deployment/scripts/platform-info.sh ---
@@ -73,6 +73,30 @@ echo "--"
echo "npm"
npm --version
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/849#discussion_r153328847
--- Diff: metron-deployment/scripts/platform-info.sh ---
@@ -73,6 +73,30 @@ echo "--"
echo "npm"
npm --version
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/848#discussion_r153332780
--- Diff: metron-deployment/packaging/docker/ansible-docker/Dockerfile ---
@@ -14,13 +14,18 @@
# See the License for the specific language
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/848#discussion_r15358
--- Diff: metron-deployment/packaging/docker/ansible-docker/README.md ---
@@ -1,17 +1,34 @@
# Overview
-The Metron ansible-docker container is
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/849#discussion_r153334325
--- Diff: metron-deployment/scripts/platform-info.sh ---
@@ -73,6 +73,30 @@ echo "--"
echo "npm"
npm --version
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/849
+1, Tested on OSX and on centos 6 with and without compliant g++ installed
Thanks Nick!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/848
Added above, adding as a comment to make sure it is seen
-
Also, after building with the rpms, exit docker
and do full_dev with
`vagrant --ansible-skip-tags
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/849
I think that is valid
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/847
+1, nice work
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/4
+1
- review looks good
- ran through test steps, everything works as described
Great job!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/823
I'm ok with the functions as they are, but if we are not going to verify
the parameters, then remove the documented restriction.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/848
@JonZeolla I would like to change the readme example to include the
quick_dev skip.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/852
I think you missed the inventory/quick-dev-platform stuff
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/852
+1 by inspection
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/852
The issue is that we should use this type of operation, but do it as part
of maven no?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/852
no, i mean auto documentation of the rest stuff ( and stellar stuff ) from
maven builds is a good ideaâ¢
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/852
i'm not saying keep *this* utility
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/852
The api should be documented without requiring the installation of the
product.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
Great! I am not sure on that. @cestella what do you think?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
Maybe we need a tool that tests stellar scripts or configurations that the
user can run and report?
And we can maintain that per release?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/852
agreed, didn't meet to hijack.
my +1 stands
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
Ok, I'll update the upgrading doc.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/823#discussion_r153927131
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java
---
@@ -18,76 +18,91
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/823#discussion_r153926767
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java
---
@@ -18,76 +18,91
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
Ok, please have a look at the doc. I'll not that we have not added any
notes previously for this type of thing.
Also: [METRON-1339: Stellar shellShould have a way to validate dep
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/823#discussion_r153968584
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java
---
@@ -18,76 +18,91
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
@cestella any last words before I pull the trigger on this? Any comment?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/854
Nick, this is awesome. I like it a lot. I don't see any downside it this.
Do you plan on people using this locally as well?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/823
That looks great! Can you close and reopen the PR so we can get a green
build? Looks like there was a failure due to network issues.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/823
@jasper-k thanks for the contribution. Really great job.
+1
@cestella @justinleet are you guys all set?
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/856
METRON-1339 Stellar Shell functionality to verify stored stellar statements
This will allow users to check their deployed statements, say after
upgrade, when they are at rest ( and would
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
PR: https://github.com/apache/metron/pull/856 adds capability to use the
stellar shell to validate stellar statements at rest out of ZK
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
So, the scenario here is checking things that *were* valid when uploaded,
but have been invalidated by external changes ( language changes ). I would
like to keep the magic specific
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
@simonellistonball, yes, the namespace should be part of the jira and
interface design
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
Ok, what was is_alert in this test?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
Ok, I'll check it out after i do my full dev test on validate
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154109552
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154110765
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r15404
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154114714
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154123254
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154124236
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154135697
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
@cestella new test and fix is in
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154155446
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154155977
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154185591
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154200025
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
I am glad for the interest in this PR, and that it seems to have sparked
some great ideas for continuing on.
What I would like to do is line it up as follows
1. This PR with
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154241894
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154245631
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
Per the conversation above, i'm going to take a stab at the attributed
approach.
I think the Stellar Functions should be a separate Jira.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154375781
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154375558
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
https://github.com/apache/metron/pull/856/commits/65278a67a07f1c4c23ab2d95ebb6de92e1cac731
introduces conceptually what @nickwallen and I have been discussing.
I need to think about
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
@cestella @simonellistonball
With the new implementation, doing the blob or file check should be a piece
of cake would you prefer it as part of this or as a new issue?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154763112
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -572,15 +590,22
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154761355
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,42
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/840
So, this has me thinking It is a shame to have these test materials (
and others like @JonZeolla creates ) embedded in these pr's.
Maybe we should have someplace to put th
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/840
Yeah, I'm trying to think of the right way to do it, without having to have
it be "officially maintained".
more like an informal /testing_stuff , with some descriptions, whe
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154802693
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,42
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154803527
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -572,15 +590,22
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154804149
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -572,15 +590,22
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154824031
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,42
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154824002
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,42
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154824244
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,42
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
@nickwallen @mattf-horton I think we can use the annotation approach to
resolve [METRON-989](https://issues.apache.org/jira/browse/METRON-989) as well.
Thoughts?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/850
I'm running it up now
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/850
Thanks for the contribution, installed as described in full dev.
+1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/850
Do you need me to land it?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/850
please take care to close the jira. Thanks again
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/785
So, when 777 hits, this is going to be removed?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
Wow, this is awesome. I'm looking forward to getting into it. First thing
that pops to mind is how this relates to or is effected by @nickwallen's
https://github.com/apache/metron/pull/854
---
1 - 100 of 1314 matches
Mail list logo
