Re: What is future of editor mode-lines after the switch to clang-format?

2018-12-10 Thread Gregory Szorc
On Wed, Dec 5, 2018 at 5:51 AM Ehsan Akhgari wrote: > On Fri, Nov 30, 2018 at 8:23 PM Ehsan Akhgari > wrote: > >> On Fri, Nov 30, 2018 at 4:08 PM Gregory Szorc wrote: >> >>> On Fri, Nov 30, 2018 at 10:00 AM wrote: >>> >>> > Now that all of mozilla-central is been migrated to use clang-format

Re: What is future of editor mode-lines after the switch to clang-format?

2018-12-05 Thread Ehsan Akhgari
On Fri, Nov 30, 2018 at 8:23 PM Ehsan Akhgari wrote: > On Fri, Nov 30, 2018 at 4:08 PM Gregory Szorc wrote: > >> On Fri, Nov 30, 2018 at 10:00 AM wrote: >> >> > Now that all of mozilla-central is been migrated to use clang-format >> > automated code formatting, the question of what should

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Ehsan Akhgari
On Fri, Nov 30, 2018 at 4:08 PM Gregory Szorc wrote: > On Fri, Nov 30, 2018 at 10:00 AM wrote: > > > Now that all of mozilla-central is been migrated to use clang-format > > automated code formatting, the question of what should happen with editor > > modelines at the top of files should be

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Ehsan Akhgari
On Fri, Nov 30, 2018 at 2:06 PM Nathan Froyd wrote: > On Fri, Nov 30, 2018 at 1:51 PM Ehsan Akhgari > wrote: > > I think these are all great points. It seems like for Emacs, it is not > > actually necessary to sprinkle modelines across all of the files in your > > repository (per

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Mike Hommey
On Fri, Nov 30, 2018 at 09:57:00AM -0800, tcampb...@mozilla.com wrote: > Now that all of mozilla-central is been migrated to use clang-format > automated code formatting, the question of what should happen with editor > modelines at the top of files should be considered. > >

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Gregory Szorc
On Fri, Nov 30, 2018 at 10:00 AM wrote: > Now that all of mozilla-central is been migrated to use clang-format > automated code formatting, the question of what should happen with editor > modelines at the top of files should be considered. > >

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Tom Tromey
Nathan> Unfortunately, it doesn't look like .dir-locals.el provides any way to Nathan> set file modes, e.g. setting python-mode for moz.build file That's correct, it's a hole in dir-locals (there's already a bug filed against Emacs for this). It's also easy to document how to update

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Nathan Froyd
On Fri, Nov 30, 2018 at 1:51 PM Ehsan Akhgari wrote: > I think these are all great points. It seems like for Emacs, it is not > actually necessary to sprinkle modelines across all of the files in your > repository (per https://bugzilla.mozilla.org/show_bug.cgi?id=1023839#c7). > For Vim, Benjamin

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Andrew McCreight
On Fri, Nov 30, 2018 at 10:00 AM wrote: > Now that all of mozilla-central is been migrated to use clang-format > automated code formatting, the question of what should happen with editor > modelines at the top of files should be considered. > >

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Ehsan Akhgari
On Fri, Nov 30, 2018 at 1:00 PM wrote: > Now that all of mozilla-central is been migrated to use clang-format > automated code formatting, the question of what should happen with editor > modelines at the top of files should be considered. > >

What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread tcampbell
Now that all of mozilla-central is been migrated to use clang-format automated code formatting, the question of what should happen with editor modelines at the top of files should be considered. https://bugzilla.mozilla.org/show_bug.cgi?id=clang-format Here are some options and some arguments