Re: FYI: We've forked the Breakpad client code

On Thu, Feb 09, 2017 at 12:41:07PM -0800, Jim Blandy wrote: > Under the circumstances, I'll volunteer to review, if that's feasible. I can too. > On Thu, Feb 9, 2017 at 12:37 PM, Ted Mielczarek wrote: > > > On Thu, Feb 9, 2017, at 02:47 PM, Aaron Klotz wrote: > > > This is great news, Ted! > >

Re: Tool for converting C++ standard library naming style to Gecko naming style?

On Thu, Feb 16, 2017 at 02:41:11PM +0200, Henri Sivonen wrote: > Is there some kind of tool, similar to ./mach clang-format for > whitespace, that changes identifies from C++ standard library style to > Gecko style? > > I.e. foo becomes Foo, foo_bar becomes FooBar and arguments and members > get p

Re: Should &&/|| really be at the end of lines?

On Fri, Feb 17, 2017 at 12:10:32AM +0100, Jean-Yves Avenard wrote: > reading this: (turn on courier) > > return ((aCodecMask & VPXDecoder::VP8) > && aMimeType.EqualsLiteral("video/webm; codecs=vp8")) > || ((aCodecMask & VPXDecoder::VP9) > && aMimeType.EqualsLitera

Re: Embeddable Browser

On Tue, Feb 21, 2017 at 04:29:43PM -0800, Myk Melez wrote: > > Rodolpho Porto > > 2017 February 20 at 02:38 > > Hello guys, > > > > I do not know if this serious or the right group to do this ask, but I > > will try here rss > > > > Xulrunner no longer has update

Re: ANN: Default bug view for BMO changed today!

On Wed, Mar 01, 2017 at 03:47:32PM -0500, David Lawrence wrote: >Today, the BMO Team changed the default bug view to the new modal > view that has been in development for a while. For those who would like > to use the old form, instructions on how to switch back are below in the > background in

Re: Heads up: archive.m.o is no longer updating tinderbox builds, AWSY is effectively dead

On Mon, Mar 06, 2017 at 01:17:02PM -0800, Eric Rahm wrote: > I'm unaware of a bug for this decision, but https://archive.mozilla.org > stopped adding tinderbox builds back on January 18th. Wild guess: that's when buildbot builds were turned off. You can get the builds through the taskcluster index

Re: Is there a way to improve partial compilation times?

On Tue, Mar 07, 2017 at 11:29:00AM -0800, zbranie...@mozilla.com wrote: > So, > > I'm on Dell XPS 13 (9350), and I don't think that toying with MOZ_MAKE_FLAGS > will help me here. "-j4" seems to be a bit high and a bit slowing down my > work while the compilation is going on, but bearable. > >

Re: Heads Up: /storage upgraded from version 1.0 to 2.0

On Wed, Mar 08, 2017 at 10:09:52AM +1100, Xidorn Quan wrote: > On Wed, Mar 8, 2017, at 09:59 AM, Jan Varga wrote: > > On 07/03/17 23:43, Robert Strong wrote: > > > Are there any problems experienced by clients that downgrade to an > > > older version after their profile has been upgraded? > > > >

Re: Is there a way to improve partial compilation times?

On Tue, Mar 07, 2017 at 03:50:56PM -0800, zbranie...@mozilla.com wrote: > On Tuesday, March 7, 2017 at 3:24:33 PM UTC-8, Mike Hommey wrote: > > On what OS? I have a XPS 12 from 2013 and a XPS 13 9360, and both do > > clobber builds in 40 minutes (which is the sad surprise t

Re: Is there a way to improve partial compilation times?

On Thu, Mar 09, 2017 at 07:45:13AM -0500, Ted Mielczarek wrote: > On Wed, Mar 8, 2017, at 05:43 PM, Ehsan Akhgari wrote: > > On 2017-03-08 11:31 AM, Simon Sapin wrote: > > > On 08/03/17 15:24, Ehsan Akhgari wrote: > > >> What we did in the Toronto office was walked to people who ran Linux on > > >>

Re: Please write good commit messages before asking for code review

On Thu, Mar 09, 2017 at 02:46:53PM -0500, Ehsan Akhgari wrote: > I review a large number of patches on a typical day, and usually I have to > spend a fair amount of time to just understand what the patch is doing. As > the patch author, you can do a lot to help make this easier by *writing > bette

Re: Please write good commit messages before asking for code review

On Thu, Mar 09, 2017 at 02:07:51PM -0800, Andrew McCreight wrote: > On Thu, Mar 9, 2017 at 1:55 PM, Nicholas Alexander > wrote: > > > On Thu, Mar 9, 2017 at 1:48 PM, Boris Zbarsky wrote: > > > > > On 3/9/17 4:35 PM, Eric Rescorla wrote: > > > > > >> I'm in favor of good commit messages, but I wo

Re: Please write good commit messages before asking for code review

On Thu, Mar 09, 2017 at 05:50:36PM -0500, Ehsan Akhgari wrote: > > On the subject of long commit messages, here's a commit message I wrote > > that had 3 paragraphs to explain a patch that just changed a 0 to a 1: > > https://hg.mozilla.org/integration/autoland/rev/bf059ec2bdc9 > > I think the len

Re: The future of commit access policy for core Firefox

On Thu, Mar 09, 2017 at 03:51:07PM -0800, Justin Dolske wrote: > I suppose this policy also implies no more "Typo fix, no bug" landings. But > I never really liked those anyway, so I'm fine with that. Bugs are cheap! :) Considering the overhead of creating a bug, attaching a patch, requesting a re

Re: The future of commit access policy for core Firefox

On Thu, Mar 09, 2017 at 08:25:17PM -0800, zbranie...@mozilla.com wrote: > As others stated, the idea that patch cannot be altered after r+ has a > massive effect on productivity. I can't overstate how much it would impact > day-to-day work for engineers, and I don't really see an easy way out. >

Re: windows build anti-virus exclusion list?

On Fri, Mar 17, 2017 at 03:53:14PM -0400, Boris Zbarsky wrote: > On 3/17/17 3:40 PM, Ted Mielczarek wrote: > > We do try to build js/src pretty early in the build > > We do? It's always the last thing I see building before we link libxul. > Seeing the js/src stuff appearing is how I know my build

Re: windows build anti-virus exclusion list?

On Fri, Mar 17, 2017 at 07:13:03PM -0400, Nathan Froyd wrote: > On Fri, Mar 17, 2017 at 6:31 PM, Mike Hommey wrote: > > On Fri, Mar 17, 2017 at 03:53:14PM -0400, Boris Zbarsky wrote: > >> On 3/17/17 3:40 PM, Ted Mielczarek wrote: > >> > We do try to build js

Re: intent to remove: standalone about:addons UI and tests

On Wed, Mar 22, 2017 at 02:36:31PM -0700, Robert Helmer wrote: > Currently we support running the about:addons UI in both a standalone > window, and also in a browser tab. > > Firefox has only used the latter for many years, but we've continued > to maintain tests for both, which increases both ou

Re: A reminder about commit messages: they should be useful

On Tue, Apr 18, 2017 at 02:10:21AM +0300, smaug wrote: > On 04/17/2017 06:16 PM, Boris Zbarsky wrote: > > A quick reminder to patch authors and reviewers. > > > > Changesets should have commit messages. The commit message should describe > > not just the "what" of the change but also the "why".

Re: A reminder about commit messages: they should be useful

On Tue, Apr 18, 2017 at 02:58:05AM +0300, smaug wrote: > On 04/18/2017 02:36 AM, Gregory Szorc wrote: > > On Mon, Apr 17, 2017 at 4:10 PM, smaug wrote: > > > > > On 04/17/2017 06:16 PM, Boris Zbarsky wrote: > > > > > > > A quick reminder to patch authors and reviewers. > > > > > > > > Changeset

Re: A reminder about commit messages: they should be useful

On Mon, Apr 17, 2017 at 09:34:39PM -0400, Ben Kelly wrote: > On Mon, Apr 17, 2017 at 9:21 PM, Nicholas Nethercote > wrote: > > > > That is why we have links to the bug. Bug should always be the unite of > > > truth telling > > > why some change was done. Bugs tend to have so much more context abo

Re: A reminder about commit messages: they should be useful

On Tue, Apr 18, 2017 at 03:42:40AM +0300, smaug wrote: > On 04/18/2017 03:12 AM, gsquel...@mozilla.com wrote: > > On Tuesday, April 18, 2017 at 11:58:11 AM UTC+12, smaug wrote: > > > On 04/18/2017 02:36 AM, Gregory Szorc wrote: > > > > On Mon, Apr 17, 2017 at 4:10 PM, smaug wrote: > > > > > > > >

Re: Using references vs. pointers in C++ code

On Tue, May 09, 2017 at 01:31:33PM +0300, Henri Sivonen wrote: > On Tue, May 9, 2017 at 12:58 PM, Emilio Cobos Álvarez > wrote: > > I think references help to encode that a bit more in the type system, > > and help reasoning about the code without having to look at the > > implementation of the f

Re: Is Big5 form submission fast enough?

On Fri, May 12, 2017 at 09:28:50AM +0800, Kan-Ru Chen wrote: > On Thu, May 11, 2017, at 01:43 PM, Henri Sivonen wrote: > > In Firefox 43, I rewrote our Big5 support and, among other things, I > > optimized the *encoder* for footprint rather than speed on the theory > > that users won't notice anywa

Removing Jemalloc 4

Hi, We've tried to get off mozjemalloc for, apparently, close to 5 years (date of the filing of bug 762449). We've had memory usage regressions (like bug 1219914), and we've had perf regressions as per talos numbers (things like bug 1138999), and those have never gone away (with variations with ea

Re: Removing Jemalloc 4

; > Is there a path forward with this in mozjemalloc? Plans, or would-take > changes, or just thoughts on what to do here? See last paragraph of the email you quoted ;) > On Mon, May 15, 2017 at 7:14 PM, Mike Hommey wrote: > > Hi, > > > > We've tried to get off moz

Re: Removing Jemalloc 4

On Tue, May 16, 2017 at 11:28:02AM -0700, Steve Fink wrote: > But I'm curious if you know anything about the intended future directions of > jemalloc, if there are any, and whether they align with anything we need. As Nick mentions, Jason Evans, the main developer on jemalloc (guess where "je" com

Linux builds now default to -O2 instead of -Os

Hi, For some reason, the default when building on Linux had stayed -Os. I just landed a change[1] to this default to now use -O2 instead (on autoland at the moment). This is going to give better performance to local builds (although that might make the build itself take a little longer). (Note th

Re: Linux builds now default to -O2 instead of -Os

On Fri, Jun 02, 2017 at 01:01:14AM +, Benjamin Smedberg wrote: > On Thu, Jun 1, 2017 at 8:52 PM Mike Hommey wrote: > > > Hi, > > > > For some reason, the default when building on Linux had stayed -Os. I > > just landed a change[1] to this default to now use -

Re: Linux builds now default to -O2 instead of -Os

On Thu, Jun 01, 2017 at 09:09:44PM -0400, Nathan Froyd wrote: > On Thu, Jun 1, 2017 at 8:51 PM, Mike Hommey wrote: > > I'll take on the > > occasion to remind or inform people that recent versions of GCC (all > > versions we support, actually), and clang >= 4.0 suppo

Re: Linux builds now default to -O2 instead of -Os

On Fri, Jun 02, 2017 at 12:44:35AM -0400, Ehsan Akhgari wrote: > On 06/01/2017 08:51 PM, Mike Hommey wrote: > > Hi, > > > > For some reason, the default when building on Linux had stayed -Os. I > > just landed a change[1] to this default to now use -O2 instead (on

Re: Fwd: [tools-tc] TaskCluster Windows Loaners

On Mon, Jun 05, 2017 at 12:17:45PM -0700, Gregory Szorc wrote: > (Forwarding for Rob since he's not on these lists and can't post.) > > Many of you have said that you want an easier way to reproduce what > automation is doing. Rob's work should make things a bit easier for Windows. > > --

Re: JSBC: JavaScript Start-up Bytecode Cache

On Tue, Jun 13, 2017 at 12:10:58PM -0400, Boris Zbarsky wrote: > On 6/13/17 11:00 AM, Dirkjan Ochtman wrote: > > Has anyone thought about doing similar things for chrome JS? > > We've been doing fastload for chrome JS (and indeed for entire chrome XUL > documents, including their scripts) for 15+

Re: Shipping Headless Firefox on Linux

On Thu, Jun 15, 2017 at 04:51:48PM -0400, Ben Kelly wrote: > On Thu, Jun 15, 2017 at 4:37 PM, Nathan Froyd wrote: > > > On Thu, Jun 15, 2017 at 2:02 PM, Brendan Dahl wrote: > > > Headless will run less of the platform specific widget code and I don't > > > recommend using it for platform specifi

Re: Profiling nightlies on Mac - what tools are used?

On Mon, Jun 19, 2017 at 10:21:14PM -0400, Boris Zbarsky wrote: > On 6/19/17 6:03 PM, Chris Cooper wrote: > > If you profile on Mac, now is your chance to speak up. What other profiling > > tools do you use that we should be aware of? > > Instruments for targeted profiling, though I mostly do that

Re: Switching to per-channel profiles

On Fri, Jun 23, 2017 at 03:43:54PM -0700, Dave Townsend wrote: > TL;DR: We should make each Firefox channel use its own profile data > allowing you to run multiple channels at the same time. > > Running multiple channels of Firefox is currently harder than it needs to > be. You can't start more th

Re: Switching to per-channel profiles

On Fri, Jun 23, 2017 at 04:42:05PM -0700, Dave Townsend wrote: > On Fri, Jun 23, 2017 at 4:37 PM, Aki Sasaki wrote: > > > I'm a Nightly only user who periodically uses Release, and I'm not > > thrilled with the idea of my profile going away. Nightly users are probably > > better suited to dealing

Re: More Rust code

On Wed, Jul 12, 2017 at 08:05:05AM +0900, Brian Birtles wrote: > On Tue, Jul 11, 2017 at 11:34 PM, Jim Mathies wrote: > > > What's the debugging situation look like for Windows developers? I've heard > > it's pretty painful. Can we step through rust code using common tools > > (WinDBG/Visual Stud

Re: Phabricator Update, July 2017

On Tue, Jul 11, 2017 at 09:59:57PM -0400, Mark Côté wrote: > On 2017-07-11 9:51 PM, Martin Thomson wrote: > > On Wed, Jul 12, 2017 at 6:41 AM, Mark Côté wrote: > > > * MozReview and Splinter turned off in early December. > > > > Is this bugzilla-wide? I know that other project use splinter still

Re: More Rust code

On Wed, Jul 12, 2017 at 04:06:39PM -0700, Eric Rahm wrote: > Interesting points. > >- *using breakpad* - was the problem that creating wrappers to access >the c/c++ code was too tedious? Could bindgen help with that, if not it >would be interesting gather some details about why it woul

Re: Phabricator Update, July 2017

On Fri, Jul 14, 2017 at 01:00:51PM -0400, Ben Kelly wrote: > Also a random reply. > > I think this kind of effort is more likely to be successful if it gets > input and buy-in from the key stakeholders. In this case that would be the > most frequent reviewers. > > It would be nice to run a bugzi

Re: 64-bit Firefox progress report: 2017-07-18

On Tue, Jul 18, 2017 at 11:38:56PM -0700, Chris Peterson wrote: > We are on track to make 64-bit Firefox the default build for Win64 OS, > bringing improved ASLR and fewer OOM crashes to the 70% of Windows Firefox > users running Win64. > > PLANS: > > * In Firefox 55 (August 8), the Windows stub

Re: 64-bit Firefox progress report: 2017-07-18

On Thu, Jul 20, 2017 at 12:01:04AM +0200, Jean-Yves Avenard wrote: > Hi > > On Wed, Jul 19, 2017 at 9:01 AM, Mike Hommey wrote: > > What's the plan for eligible people that still want to keep 32-bit > > Firefox? Are they going to have to stop auto upgrades, which would

Re: 64-bit Firefox progress report: 2017-07-18

On Wed, Jul 19, 2017 at 08:48:45PM -0400, Ben Kelly wrote: > On Jul 19, 2017 6:20 PM, "Mike Hommey" wrote: > > > What would be the rationale behind this choice? > > Smaller memory footprint, which, you'll admit, when you're on a machine > with (less tha

Re: 64-bit Firefox progress report: 2017-07-18

On Wed, Jul 19, 2017 at 09:40:12PM -0400, Ben Kelly wrote: > On Jul 19, 2017 8:57 PM, "Mike Hommey" wrote: > > On Wed, Jul 19, 2017 at 08:48:45PM -0400, Ben Kelly wrote: > > On Jul 19, 2017 6:20 PM, "Mike Hommey" wrote: > > > > > What would be

Re: Announcing MozillaBuild 3.0 Release

On Mon, Jul 24, 2017 at 03:57:24PM -0700, Ralph Giles wrote: > On Mon, Jul 24, 2017 at 3:51 PM, Botond Ballo wrote: > > > > With MozReview [1], you can submit patches from the command line via a > > simple "hg push review". > > > > There's a `git mozreview push` command in the same repo but I b

Re: Announcing MozillaBuild 3.0 Release

On Mon, Jul 24, 2017 at 08:25:18PM +, Enrico Weigelt, metux IT consult wrote: > I'm currently trying to package tbird (52esr) for Debian/Devuan. It looks like you're doing a lot of work that is completely out of scope for creating packages for Debian/Devuan, and that is work that sounds like

Re: Announcing MozillaBuild 3.0 Release

On Tue, Jul 25, 2017 at 12:20:48AM +, Enrico Weigelt, metux IT consult wrote: > On 24.07.2017 23:04, Mike Hommey wrote: > > > It looks like you're doing a lot of work that is completely out of scope > > for creating packages for Debian/Devuan, > > Not quite. Of

Re: Announcing MozillaBuild 3.0 Release

On Tue, Jul 25, 2017 at 01:07:19AM +, Enrico Weigelt, metux IT consult wrote: > On 25.07.2017 00:34, Mike Hommey wrote: > > > Debian has 52esr. > > Maybe in experimental. But that doesn't help me much for jessie. No, it's in testing, and should reach stable at

Re: Correct format specifier for size_t

On Tue, Jul 25, 2017 at 08:13:17PM +0200, Honza Bambas wrote: > Thanks! OTOH, I think we no longer need it. Since VS2015 (our minimal > toolchain version on Win) supports %z modifier. Only VS2013 and down only > defines %I. Are you sure? Because that's not listed on MSDN: https://msdn.microsoft

Re: Heads up! Building Stylo in local developer builds

On Fri, Jul 28, 2017 at 01:04:21AM -0700, Chris Peterson wrote: > Stylo support (pref'd off) has been built in automation builds for a couple > weeks. Ralph Giles just landed bug 1384258 to also build Stylo support > (pref'd off) in local developer builds, too. You should rerun `mach > bootstrap` t

Re: sccache as ccache

On Fri, Aug 04, 2017 at 11:25:52AM +0200, Simon Sapin wrote: > On 26/07/2017 19:22, Ted Mielczarek wrote: > > > I’ve ended up keeping "classic" ccache for C and C++ code and adding > > > 'export RUSTC_WRAPPER=sccache' to my mach wrapper script in order to use > > > sccache for Rust code. (Having th

Re: More Rust code

On Fri, Aug 04, 2017 at 08:45:14AM +0300, Henri Sivonen wrote: > I guess I buried my questions in too long a post, so extracting them: > > On Mon, Jul 31, 2017 at 1:02 PM, Henri Sivonen wrote: > > Naïvely, one would think that it should be possible to do that with > > clang producing "object file

Re: More Rust code

On Tue, Aug 08, 2017 at 07:12:13AM +0900, Mike Hommey wrote: > On Fri, Aug 04, 2017 at 08:45:14AM +0300, Henri Sivonen wrote: > > I guess I buried my questions in too long a post, so extracting them: > > > > On Mon, Jul 31, 2017 at 1:02 PM, Henri Sivonen wrote: > >

Re: Firefox and clang-cl

On Sat, Aug 12, 2017 at 11:22:30PM -0400, Jeff Muizelaar wrote: > On Sat, Aug 12, 2017 at 9:40 PM, Ehsan Akhgari > wrote: > > Last but not least, you may ask yourself why would we want to spend this > > much effort to switch to clang-cl on Windows? I believe this is an > > important long term sh

Re: Intent to ship version 4 of the Safe Browsing protocol

On Wed, Aug 16, 2017 at 12:43:19PM -0700, Daniel Veditz wrote: > 100 options is 4950 configurations to test. I think you mean 2^100. That's 1.26 x 10^30. Mike ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinf

Re: sccache as ccache

On Wed, Jul 26, 2017 at 09:54:14AM -0400, Alex Gaynor wrote: > If you're on macOS, you can also get sccache with `brew install sccache`. If you're on macOS and were hitting errors building openvr, this is fixed in sccache master. Mike ___ dev-platform m

Re: New string types: nsAutoStringN<> and nsAutoCStringN<>

On Tue, Aug 22, 2017 at 04:38:04PM +1000, Nicholas Nethercote wrote: > I really wish our top-level namespace was "moz", rather than "mozilla". It's never too late to change it. I, for one, vote +1. Mike ___ dev-platform mailing list dev-platform@lists.m

Re: More Rust code

On Tue, Aug 08, 2017 at 09:09:09AM +0900, Mike Hommey wrote: > On Tue, Aug 08, 2017 at 07:12:13AM +0900, Mike Hommey wrote: > > On Fri, Aug 04, 2017 at 08:45:14AM +0300, Henri Sivonen wrote: > > > I guess I buried my questions in too long a post, so extracting them: > >

Re: Coding style: `else for` or `else { for... }`?

On Wed, Aug 30, 2017 at 06:26:18PM -0600, Eric Rescorla wrote: > On Wed, Aug 30, 2017 at 4:41 PM, Jeff Gilbert wrote: > > > IMO: Never else-for. (or else-while) > > > > Else-if is a reasonable continuation of concept: "Well it wasn't that, > > what if it's this instead?" > > Else-for is just shor

Re: New minimum Rust version policy for Firefox

On Thu, Aug 31, 2017 at 10:27:55AM -0500, Jack Moffitt wrote: > Specifically for webrender (and anything else under the servo org on > GitHub), you can just file a bug and assign to edunham and we'll fix > that up. > > jack. Note that for webrender specifically, it used to build against stable, b

Re: Coding style: Placement of binary operators when breaking a long line

On Wed, Sep 06, 2017 at 12:30:58PM -0700, Eric Rahm wrote: > Hi folks- > > *Note: Previously we've discussed the placement of logical operators && and > ||; a decision was made and I do not wish to re-litigate that here*. > > Currently we have a somewhat convoluted set of rules about where to pla

Re: Coding style: Placement of binary operators when breaking a long line

On Thu, Sep 07, 2017 at 12:47:51AM -0700, Chris Peterson wrote: > On 2017-09-06 8:06 PM, Ehsan Akhgari wrote: > > The interesting points to consider is the data that Nick alluded to in > > the previous discussion about the existing prevalent style. > > > > Also, the point you up about the pragmati

Re: Re-visiting the DOM tree depth limit in layout

On Wed, Sep 13, 2017 at 10:03:55AM -0700, Eric Rahm wrote: > Jan is right, increasing the stack size for all threads would cause a very > large memory regression. Lets not do that ;) Selectively increasing might > make sense but we'd need to keep an eye on how large of an increase we're > expecting

Re: Reminder on Try usage and infrastructure resources

On Thu, Sep 14, 2017 at 11:35:53AM -0400, Stuart Philp wrote: > Hello all, > > As we near 57 the Firefox CI group felt it was important to send out a bit > of a reminder regarding infrastructure usage when you push. > > *tl;dr* There is a real cost (both time and $) to using the 'all' flags in >

Re: Follow up on clang-format

On Tue, Sep 26, 2017 at 02:49:56PM +0200, Sylvestre Ledru wrote: > Le 26/09/2017 à 14:33, smaug a écrit : > > On 05/23/2014 04:29 AM, Anthony Jones wrote: > >> Some of you may remember the discussion on clang-format and the `mach > >> clang-format` command. What we have in place right now is very t

Re: Changes to tab min-width

On Fri, Oct 06, 2017 at 05:40:13PM +0100, Jonathan Kew wrote: > On 06/10/2017 17:05, Boris Zbarsky wrote: > > On 10/3/17 5:18 PM, Boris Zbarsky wrote: > > > So just to make sure I understand the change (and this is a > > > theoretical point, because I haven't had a chance to try the change > > > ye

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

On Tue, Oct 17, 2017 at 10:38:09AM +0200, Jean-Yves Avenard wrote: > Hi > > Do you have ways to prevent running this code on some external > frameworks? > > Whenever we modify a gtest this causes hundreds of errors about not > using a default constructor … (which shouldn’t be an error anyway) ht

Re: More ThinkStation P710 Nvidia tips (was Re: Faster gecko builds with IceCC on Mac and Linux)

On Thu, Oct 26, 2017 at 04:02:20PM -0700, Gregory Szorc wrote: > Also, the machines come with Windows by default. That's by design: that's > where the bulk of Firefox users are. We will develop better products if the > machines we use every day resemble what actual users use. I would encourage > de

Re: Pulsebot in #developers

Hi, As the owner of the mentioned bot, I feel I need to jump in, not because I want to defend any position (I pretty much don't care whether pulsebot sends its messages to #developers or somewhere else), but just to mention some facts. Pulsebot did its first post to #developers on May 30, 2014, b

Re: More ThinkStation P710 Nvidia tips (was Re: Faster gecko builds with IceCC on Mac and Linux)

On Wed, Nov 08, 2017 at 09:43:29AM +0200, Henri Sivonen wrote: > I agree that workstation GPUs should be avoided. Even if they were as > well supported by Linux distro-provided Open Source drivers as > consumer GPUs, it's at the very least more difficult to find > information about what's true abou

Re: Intent to require Python 3 to build Firefox 59 and later

On Fri, Nov 10, 2017 at 05:42:01PM -0800, Gregory Szorc wrote: > On Fri, Nov 10, 2017 at 4:22 PM, Xidorn Quan wrote: > > > I'm happy hearing this. I would be interested on whether we are going to > > drop Python 2 at some point, or are we stuck with that forever? > > > > Let's put it this way: w

Re: Dropping remains of support for non-UTF-8 file paths on Gtk platforms (was: Re: Please do not use GetNativePath and GetNativeTarget in XP code and Windows-specific code)

On Tue, Dec 05, 2017 at 05:16:52PM +0200, Henri Sivonen wrote: > On Tue, Dec 5, 2017 at 4:37 PM, ISHIKAWA,chiaki wrote: > > There are other non-ASCII character issues such as > > https://bugzilla.mozilla.org/show_bug.cgi?id=1258613 > > Very weird bug! (Summary for others: decomposed voiced sound

Re: `general.useragent.locale` is no more. All hail `intl.locale.requested`

On Tue, Dec 05, 2017 at 03:15:06PM -0800, Zibi Braniecki (Gandalf) wrote: > Hi all, > > We just landed a major patch which replaces `general.useragent.locale` pref > with a new pref `intl.locale.requested`. > > Historically, `general.useragent.locale` has been widely used to set a > locale for Fi

Re: PSA: searchfox now indexes rust

On Mon, Jan 08, 2018 at 11:15:13AM -0500, Kartikaya Gupta wrote: > Just a heads-up, thanks to a bunch of work by Emilio, searchfox.org > now indexes rust code as well, so you can do things like jump to > function definitions and call sites and whatnot. Please use it and > file bugs under Webtools :

Re: Faster gecko builds with IceCC on Mac and Linux

On Tue, Jan 16, 2018 at 10:02:12AM -0800, Ralph Giles wrote: > On Tue, Jan 16, 2018 at 7:51 AM, Jean-Yves Avenard > wrote: > > But I would be interested in knowing how long that same Lenovo P710 takes > > to compile *today*…. > > > > On my Lenovo P710 (2x2x6 core Xeon E5-2643 v4), Fedora 27 Linu

Re: PSA: Chrome-only WebIDL interfaces no longer require DOM peer review

On Thu, Mar 08, 2018 at 11:16:44PM +, Stuart Philp wrote: > Generally I think we’d take performance and memory wins over installer > size, but we monitor all three and if installer size grows (gradually) by > an uncomfortable amount we ought to make a call on the trade off. We can > bring it to

Re: PSA: Chrome-only WebIDL interfaces no longer require DOM peer review

On Thu, Mar 08, 2018 at 02:40:52PM -0800, Bobby Holley wrote: > I've seen a lot of momentum around migrating chrome-only XPIDL interfaces > to WebIDL. I'm concerned that insufficient attention is being paid to the > impact on our binary size. > > Fundamentally, the WebIDL bindings improve performa

Re: PSA: Visual Studio 2017 15.6 now required to build 61+

On Tue, Mar 13, 2018 at 09:05:50AM +0200, Henri Sivonen wrote: > On Tue, Mar 13, 2018 at 2:29 AM, Ryan VanderMeulen > wrote: > > While I know I'm tempting fate by sending this out while the patches are > > still on autoland, I wanted to start giving people a heads-up now that bug > > 1424281 has b

Re: PSA: Building Firefox 61+ with GCC will soon require version GCC 6.1+

On Thu, Apr 05, 2018 at 06:53:52PM +1000, Nicholas Nethercote wrote: > Thank you for working on this, jgilbert. > > I tried to take advantage of C++14's relaxed constexpr for bug 1451278, but > I'm getting one test job failure on automation, visible here: > > https://treeherder.mozilla.org/#/jobs

Re: Intent To Require Manifests For Vendored Code In mozilla-central

On Tue, Apr 10, 2018 at 12:33:27PM +0800, Byron Jones wrote: > glob wrote: > > The plan is to create a YAML file for each library containing metadata > > such as the homepage url, vendored version, bugzilla component, etc. See > > https://goo.gl/QZyz4xfor the full specification. > > this should be

Re: Intent To Require Manifests For Vendored Code In mozilla-central

On Tue, Apr 10, 2018 at 02:46:40PM +1000, Martin Thomson wrote: > This seems like a good idea. > > Please consider adding hg.mozilla.org to your list of things you will > clone from. That will allow us to remove some ugly hacks from the > tree for vendoring NSS and NSPR. (libffi uses the same sc

Re: License of test data?

On Thu, May 17, 2018 at 01:31:43PM -0400, mhoye wrote: > On 2018-04-24 10:36 AM, mhoye wrote: > > On 2018-04-24 10:24 AM, David Teller wrote: > > > What's our policy for this? Are there any restrictions? All the > > > frameworks I currently have at hand are have either an MIT- or an > > > MIT-like

Re: Update on rustc/clang goodness

On Wed, May 30, 2018 at 09:19:29AM +1000, Nicholas Nethercote wrote: > On Wed, May 30, 2018 at 7:58 AM, Gregory Szorc wrote: > > > > > MSVC is a separate beast. It is a great compiler. > > > > FWIW: numerous times I have been stymied by MSVC's bugs or lack of > features. Bug 1449787 is a recent

Re: Update on rustc/clang goodness

On Wed, May 30, 2018 at 02:40:01PM +0300, Henri Sivonen wrote: > On Wed, May 30, 2018 at 8:06 AM, Dave Townsend wrote: > > On Tue, May 29, 2018 at 10:03 PM Jeff Gilbert wrote: > >> I get that, but it reminds me of the reasons people give for "our > >> website works best in $browser". > > > > I wa

PSA: clang prefered for local builds on *nix

Hi, As of bug 1253064 landed earlier today (and now merged on central), local builds on *nix (Linux, BSDs, etc.) will prefer to use clang over gcc by default. If you still prefer to build with gcc instead of clang, you can do so by setting CC=gcc in your environment or adding ac_add_options CC=gcc

Re: mozilla-inbound backout policy subject to change (become similar to autoland)

On Sun, Jun 24, 2018 at 03:28:45PM -0400, Boris Zbarsky wrote: > On 6/19/18 9:04 AM, Sebastian Hengst wrote: > > TL;DR: We would like to change the mozilla-inbound backout policy to be > > like autoland’s. > > This seems like a pretty reasonable change in general. > > Is there a well-documented t

Re: XPIDL trajectory

On Wed, Jun 27, 2018 at 01:24:27PM +1000, Nicholas Nethercote wrote: > Thanks for the tip. I've updated the last part of the script accordingly: > > # Count number of bytes in the xptdata.o file. > cd o64 > echo -n "xptdata.o bytes: " > wc --bytes xpcom/reflect/xptinfo/xptdata.o > cd .. > > The c

Re: mozilla-inbound backout policy subject to change (become similar to autoland)

On Wed, Jun 27, 2018 at 12:36:22AM -0400, Boris Zbarsky wrote: > On 6/26/18 6:53 PM, Gregory Szorc wrote: > > I agree that the default behavior of `-p all -u all -t all` is running too > > much and confusing people. I filed bug 1471404 to change the behavior. > > > > Will that be sufficient to fix

Re: Coding style: Making the `e` prefix for enum variants not mandatory?

On Thu, Jun 28, 2018 at 05:27:23PM +0200, Emilio Cobos Álvarez wrote: > I asked kats@ (which added the list item regarding enums) and he was fine > removing it from the coding style, so given that and the rest of the thread > I've edited the page accordingly. Not that I'd oppose, but I'll note tha

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

On Wed, Jul 11, 2018 at 11:42:01PM +0200, Jean-Yves Avenard wrote: > Hi > > > On 11 Jul 2018, at 10:10 pm, Kris Maglione wrote: > > Thanks. Boris added this as a blocker. > > > > It looks like it will be helpful, but unfortunately won't give us the 2MB > > simple arithmetic would suggest. On Wi

Re: Using clang-cl to ship Windows builds

On Wed, Jul 11, 2018 at 09:48:23AM -0700, Thomas Daede wrote: > On 07/10/2018 01:29 PM, David Major wrote: > > Bug 1443590 is switching our official Windows builds to use clang-cl > > as the compiler. > > Another great effect of this change is that it finally fixes the issue > of constantly runnin

Re: Using clang-cl to ship Windows builds

On Wed, Jul 11, 2018 at 11:34:52PM -0700, Anthony Jones wrote: > On Thursday, 12 July 2018 15:50:40 UTC+12, halivi...@gmail.com wrote: > > I hope that both Firefox and Chrome continue to keep the build and > > tests running on MSVC. It would suck if for example we can't build > > Firefox with MSVC

Re: Tagged pointers

On Thu, Jul 12, 2018 at 04:40:39PM -0700, Steve Fink wrote: > On 07/12/2018 04:27 PM, Cameron McCormack wrote: > > On Fri, Jul 13, 2018, at 6:51 AM, Kris Maglione wrote: > > > I actually have a patch sitting around with helpers to make it super easy > > > to > > > use smart pointers as tagged poin

Re: Tagged pointers

On Fri, Jul 13, 2018 at 03:03:47PM +1200, Robert O'Callahan wrote: > On Fri, Jul 13, 2018 at 11:40 AM, Steve Fink wrote: > > > On 07/12/2018 04:27 PM, Cameron McCormack wrote: > > > >> On Fri, Jul 13, 2018, at 6:51 AM, Kris Maglione wrote: > >> > >>> I actually have a patch sitting around with he

Re: PSA: Automated code analysis now also in Phabricator

On Tue, Jul 17, 2018 at 05:06:07PM +0200, Jan Keromnes wrote: > Thanks all for the enthusiasm, we're also excited about what this can do > for us. > > > When did this become active? > > Last year on MozReview, yesterday on Phabricator. > > > Can existing diff be forced to be scanned if they were

Re: C++ standards proposal for a embedding library

On Wed, Jul 18, 2018 at 12:45:30PM -0400, Botond Ballo wrote: > Hi everyone, > > With the proposal for a standard 2D graphics library now on ice [1], > members of the C++ standards committee have been investigating > alternative ways of giving C++ programmers a standard way to write > graphical an

Re: Plan for Sunsetting MozReview

On Thu, Jul 26, 2018 at 06:31:34PM -0400, Mark Côté wrote: > The problem there is that the review repo will be bundled and stored. We > don't want to run another Mercurial server indefinitely. Although, if the > parent is a public changeset (as I believe most are), we could put a link > to that com

Re: Use of 'auto'

On Mon, Aug 03, 2015 at 05:55:01PM -0700, Jonas Sicking wrote: > On Mon, Aug 3, 2015 at 5:06 PM, Karl Tomlinson wrote: > > but I don't see much advantage of public constructors over > > something like > > > > static already_AddRefed Foo::Create() > > > > or > > > > static nsRefPtr Foo::Make()

Re: Can we make a plan to retire Universal Mac builds?

On Wed, Aug 05, 2015 at 08:22:10AM -0700, Gregory Szorc wrote: > > > > On Aug 5, 2015, at 08:12, Ted Mielczarek wrote: > > > > Our Universal Mac builds are a frequent headache for build system > > work, being a special snowflake in many ways. They also use twice as > > much machine time as othe

  1   2   3   4   5   6   7   >