Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-15 Thread Petr Vobornik
On 05/14/2012 07:08 PM, Endi Sukma Dewata wrote: On 5/10/2012 7:19 AM, Petr Vobornik wrote: Updated patch attached. See comments below. On 05/08/2012 04:23 AM, Endi Sukma Dewata wrote: Try adding a very long DNS zone, then open the zone. Compare the breadcrumbs in the DNS Resource Records page

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-14 Thread Endi Sukma Dewata
On 5/10/2012 7:19 AM, Petr Vobornik wrote: Updated patch attached. See comments below. On 05/08/2012 04:23 AM, Endi Sukma Dewata wrote: Try adding a very long DNS zone, then open the zone. Compare the breadcrumbs in the DNS Resource Records page and in the Settings page, in my case the second o

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-11 Thread Petr Vobornik
On 05/08/2012 01:47 AM, Endi Sukma Dewata wrote: The code works, it's ACKed. Patches 124-132 pushed to master. I have some comments below: I'll address some points in separate patches. On 5/2/2012 8:33 AM, Petr Vobornik wrote: This bunch of patches are implementing ticket #2247. They in

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-10 Thread Petr Vobornik
Updated patch attached. See comments below. On 05/08/2012 04:23 AM, Endi Sukma Dewata wrote: On 5/3/2012 8:26 AM, Petr Vobornik wrote: On 05/03/2012 03:19 PM, Petr Vobornik wrote: I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which act

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-07 Thread Endi Sukma Dewata
On 5/3/2012 8:26 AM, Petr Vobornik wrote: On 05/03/2012 03:19 PM, Petr Vobornik wrote: I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which actually calculates it. I found useless line in the patch. Corrected version attached. Try add

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-07 Thread Endi Sukma Dewata
The code works, it's ACKed. I have some comments below: On 5/2/2012 8:33 AM, Petr Vobornik wrote: This bunch of patches are implementing ticket #2247. They introduce some new logic and types of internal objects. There might be design issues (mainly in state evaluation). I would appreciate some o

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-03 Thread Petr Vobornik
On 05/03/2012 03:19 PM, Petr Vobornik wrote: I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which actually calculates it. I found useless line in the patch. Corrected version attached. On 05/02/2012 03:33 PM, Petr Vobornik wrote: Thi

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-03 Thread Petr Vobornik
I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which actually calculates it. On 05/02/2012 03:33 PM, Petr Vobornik wrote: This bunch of patches are implementing ticket #2247. They introduce some new logic and types of internal objects. T