Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-08-01 Thread Petr Spacek
On 1.8.2016 18:31, Martin Basti wrote: > > > On 28.07.2016 18:29, Ariel Barria wrote: >> 2016-07-28 7:10 GMT-05:00 Petr Spacek : >>> On 27.7.2016 18:26, Ariel Barria wrote: 2016-07-26 9:39 GMT-05:00 Petr Spacek : > On 26.7.2016 16:28, Jan Cholasta

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-08-01 Thread Martin Basti
On 28.07.2016 18:29, Ariel Barria wrote: 2016-07-28 7:10 GMT-05:00 Petr Spacek : On 27.7.2016 18:26, Ariel Barria wrote: 2016-07-26 9:39 GMT-05:00 Petr Spacek : On 26.7.2016 16:28, Jan Cholasta wrote: Hi, On 26.7.2016 16:09, Martin Basti wrote: On

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-07-28 Thread Ariel Barria
2016-07-28 7:10 GMT-05:00 Petr Spacek : > On 27.7.2016 18:26, Ariel Barria wrote: >> 2016-07-26 9:39 GMT-05:00 Petr Spacek : >>> On 26.7.2016 16:28, Jan Cholasta wrote: Hi, On 26.7.2016 16:09, Martin Basti wrote: > > > On

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-07-28 Thread Petr Spacek
On 27.7.2016 18:26, Ariel Barria wrote: > 2016-07-26 9:39 GMT-05:00 Petr Spacek : >> On 26.7.2016 16:28, Jan Cholasta wrote: >>> Hi, >>> >>> On 26.7.2016 16:09, Martin Basti wrote: On 22.07.2016 00:14, Ariel Barria wrote: > Hello everyone. > > I send

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-07-26 Thread Petr Spacek
On 26.7.2016 16:28, Jan Cholasta wrote: > Hi, > > On 26.7.2016 16:09, Martin Basti wrote: >> >> >> On 22.07.2016 00:14, Ariel Barria wrote: >>> Hello everyone. >>> >>> I send patch for review. > > NACK, six.u() is supposed to be used on string literals *only* [1]. > > A proper fix would be

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-07-26 Thread Jan Cholasta
Hi, On 26.7.2016 16:09, Martin Basti wrote: On 22.07.2016 00:14, Ariel Barria wrote: Hello everyone. I send patch for review. NACK, six.u() is supposed to be used on string literals *only* [1]. A proper fix would be something like: value = self.to_text() if not isinstance(value,

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-07-26 Thread Martin Basti
On 22.07.2016 00:14, Ariel Barria wrote: Hello everyone. I send patch for review. Regards, Thank you, I will look on this, for some reason we received your e-mail just today (2016-07-26) Martin -- Manage your subscription for the Freeipa-devel mailing list: