On Wed, Apr 20, 2016 at 08:38:03AM +0200, Johannes Schindelin wrote:
> We simply need to read the config, is all.
>
> This fixes https://github.com/git-for-windows/git/issues/733
>
> Signed-off-by: Johannes Schindelin
Looks good to me. Thanks.
-Peff
--
To unsubscribe from this list: send the
We simply need to read the config, is all.
This fixes https://github.com/git-for-windows/git/issues/733
Signed-off-by: Johannes Schindelin
---
builtin/replace.c | 1 +
1 file changed, 1 insertion(+)
Interdiff vs v1:
diff --git a/builtin/replace.c b/builtin/replace.c
index 02b13f6..b58c714 10
Hi Christian & Peff,
On Wed, 20 Apr 2016, Christian Couder wrote:
> On Wed, Apr 20, 2016 at 5:53 AM, Jeff King wrote:
> > On Tue, Apr 19, 2016 at 09:22:37AM -0700, Junio C Hamano wrote:
> >
> >> I can understand "we only know edit mode needs config, and we know it
> >> will never affect other mo
Hi Junio,
On Tue, 19 Apr 2016, Junio C Hamano wrote:
> "git blame -L475,6 builtin/replace.c" points at b892bb45 (replace: add
> --edit option, 2014-04-26) and the commit log message names two people
> who can review this change, so that is what I am doing here.
D'oh. Sorry.
Dscho
--
To unsubscri
Jeff King writes:
> I mean that if you save any old patch-ids from "git patch-id", they
> won't match up when compared with new versions of git. We can probably
> ignore it, though. This isn't the first time that patch-ids might have
> changed, and I think the advice is already that one should no
On Wed, Apr 20, 2016 at 5:53 AM, Jeff King wrote:
> On Tue, Apr 19, 2016 at 09:22:37AM -0700, Junio C Hamano wrote:
>
>> I can understand "we only know edit mode needs config, and we know
>> it will never affect other modes to have the new call here", and it
>> would be good for an emergency patch
On Tue, Apr 19, 2016 at 9:18 PM, Jeff King wrote:
> [your original probably didn't make it to the list because of its 5MB
> attachment; the list has a 100K limit; I'll try to quote liberally]
>
> On Tue, Apr 19, 2016 at 04:17:50PM -0700, Jacob Keller wrote:
>
>> I ran this version of the patch ag
On Wed, Apr 20, 2016 at 12:18:27AM -0400, Jeff King wrote:
> My earlier tests with the perl script were all done with "git log -p",
> which will not show anything at all for merges (and my script wouldn't
> know how to deal with combined diffs anyway). But I think this new patch
> _will_ kick in f
[your original probably didn't make it to the list because of its 5MB
attachment; the list has a 100K limit; I'll try to quote liberally]
On Tue, Apr 19, 2016 at 04:17:50PM -0700, Jacob Keller wrote:
> I ran this version of the patch against the entire Linux kernel
> history, as I figured this h
On Tue, Apr 19, 2016 at 09:22:37AM -0700, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > We simply need to read the config, is all.
> >
> > This fixes https://github.com/git-for-windows/git/issues/733
> >
> > Signed-off-by: Johannes Schindelin
> > ---
> > builtin/replace.c | 1 +
> >
On Tue, Apr 19, 2016 at 07:43:11PM -0400, David Turner wrote:
> On Tue, 2016-04-19 at 19:22 -0400, Jeff King wrote:
> > You can find previous discussion on the list, but I think the options
> > basically are:
> >
> > 1. Something like v2, where the client gets a chance to speak
> > before
> >
On Wed, 2016-04-20 at 06:50 +0700, Duy Nguyen wrote:
> On Wed, Apr 20, 2016 at 6:28 AM, David Turner <
> dtur...@twopensource.com> wrote:
> > @@ -317,6 +320,8 @@ int main(int argc, char **argv)
> > if (fd < 0)
> > die_errno(_("could not set up index-helper
> > socket"));
> >
On Wed, 2016-04-20 at 07:15 +0700, Duy Nguyen wrote:
> Continuing my comment from the --use-watchman patch about watchman
> not
> being supported...
>
> On Wed, Apr 20, 2016 at 6:28 AM, David Turner <
> dtur...@twopensource.com> wrote:
> > +static int poke_and_wait_for_reply(int fd)
> > +{
> > +
On Wed, 2016-04-20 at 07:31 +0700, Duy Nguyen wrote:
> On Wed, Apr 20, 2016 at 6:27 AM, David Turner <
> dtur...@twopensource.com> wrote:
> > Shared memory is done by storing files in a per-repository
> > temporary
> > directory. This is more portable than shm (which requires
> > posix-realtime an
On Wed, Apr 20, 2016 at 6:27 AM, David Turner wrote:
> Shared memory is done by storing files in a per-repository temporary
> directory. This is more portable than shm (which requires
> posix-realtime and has various quirks on OS X). It might even work on
> Windows, although this has not been te
"brian m. carlson" writes:
> On Tue, Apr 19, 2016 at 04:02:22PM -0700, Junio C Hamano wrote:
>> "brian m. carlson" writes:
>>
>> > @@ -314,7 +314,7 @@ static int threeway_callback(int n, unsigned long
>> > mask, unsigned long dirmask, s
>> >}
>> >
>> >if (same_entry(entry+0, entry+1)
Continuing my comment from the --use-watchman patch about watchman not
being supported...
On Wed, Apr 20, 2016 at 6:28 AM, David Turner wrote:
> +static int poke_and_wait_for_reply(int fd)
> +{
> + struct strbuf buf = STRBUF_INIT;
> + struct strbuf reply = STRBUF_INIT;
> + int r
On Wed, Apr 20, 2016 at 6:28 AM, David Turner wrote:
> @@ -317,6 +320,8 @@ int main(int argc, char **argv)
> if (fd < 0)
> die_errno(_("could not set up index-helper socket"));
>
> + if (detach && daemonize(&daemonized))
> + die_errno(_("unable to detach
On Wed, Apr 20, 2016 at 6:28 AM, David Turner wrote:
> + if (use_watchman > 0) {
> + the_index.last_update= xstrdup("");
> + the_index.cache_changed |= WATCHMAN_CHANGED;
> + } else if (!use_watchman) {
> + the_index.last_update= NULL;
>
On Tue, 2016-04-19 at 19:22 -0400, Jeff King wrote:
> You can find previous discussion on the list, but I think the options
> basically are:
>
> 1. Something like v2, where the client gets a chance to speak
> before
> the advertisement.
>
> 2. Some out-of-band way of getting values from
Soon, we'll want to automatically start index-helper, so we need
a mode that silently exits if it can't start up (either because
it's not in a git dir, or because another one is already running).
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 4
index-helper.c
From: Nguyễn Thái Ngọc Duy
We detach after creating and opening the socket, because otherwise
we might return control to the shell before index-helper is ready to
accept commands. This might lead to flaky tests.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentatio
From: Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 3 +++
Documentation/git-update-index.txt | 6 ++
builtin/update-index.c | 11 +++
3 files changed, 20 insertions(+)
diff --git a/Docum
From: Nguyễn Thái Ngọc Duy
Instead of reading the index from disk and worrying about disk
corruption, the index is cached in memory (memory bit-flips happen
too, but hopefully less often). The result is faster read. Read time
is reduced by 70%.
The biggest gain is not having to verify the traili
From: Nguyễn Thái Ngọc Duy
The extension contains a bitmap, one bit for each entry in the
index. If the n-th bit is zero, the n-th entry is considered
unchanged, we can ce_mark_uptodate() it without refreshing. If the bit
is non-zero and we found out the corresponding file is clean after
refresh,
From: Nguyễn Thái Ngọc Duy
Later, we will introduce git index-helper to share this memory with
other git processes.
Since the memory will be shared, it will never be unmapped (although
the kernel may of course choose to page it out).
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Tur
From: Nguyễn Thái Ngọc Duy
The previous patch has the logic to clear bits in 'WAMA' bitmap. This
patch has logic to set bits as told by watchman. The missing bit,
_using_ these bits, are not here yet.
A lot of this code is written by David Turner originally, mostly from
[1]. I'm just copying and
Signed-off-by: David Turner
---
index-helper.c | 7 +++
t/t7900-index-helper.sh | 9 +
2 files changed, 16 insertions(+)
diff --git a/index-helper.c b/index-helper.c
index 6af01c9..8fcb76e 100644
--- a/index-helper.c
+++ b/index-helper.c
@@ -412,6 +412,13 @@ int main(int arg
Introduce a new config option, indexhelper.autorun, to automatically
run git index-helper before starting up a builtin git command. This
enables users to keep index-helper running without manual
intervention.
Signed-off-by: David Turner
---
Documentation/config.txt | 4
read-cache.c
Make git checkout (and other unpack_tree operations) preserve the
untracked cache and watchman status. This is valuable for two reasons:
1. Often, an unpack_tree operation will not touch large parts of the
working tree, and thus most of the untracked cache will continue to be
valid.
2. Even if th
Add a new command (and command-line arg) to allow index-helpers to
exit cleanly.
This is mainly useful for tests.
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 3 +++
index-helper.c | 31 ++-
t/t7900-index-helper.sh
From: Nguyễn Thái Ngọc Duy
Watchman is hidden behind index-helper. Before git tries to read the
index from shm, it notifies index-helper through the socket and waits
for index-helper to prepare a file for sharing memory (with
MAP_SHARED). index-helper then contacts watchman, updates 'WAMA'
extens
From: Nguyễn Thái Ngọc Duy
There are "holes" in the index-helper approach because the shared
memory is not verified again by git. If $USER is compromised, shared
memory could be modified. But anyone who could do this could already
modify $GIT_DIR/index. A more realistic risk is some bugs in
index
From: Nguyễn Thái Ngọc Duy
This allows signal handlers and atexit functions to realize this
situation and not clean up.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
builtin/gc.c | 2 +-
cache.h | 2 +-
daemon.c | 2 +-
setup.c | 4 +++-
4 files changed, 6
This version includes the following changes since v4:
1. The last patch has been removed; it's pretty much always a good
idea to wait for the index-helper
2. Documentation for index-helper --kill and --autorun. Documentation
for update-index --watchman. Documentation for index-format for WAMA.
D
From: Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
read-cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/read-cache.c b/read-cache.c
index d9fb78b..16cc487 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1345,7 +1345,7 @@
On Tue, Apr 19, 2016 at 05:40:01PM -0400, David Turner wrote:
> > I dunno, I am a bit negative on bringing new features to Git-over
> > -HTTP
> > (which is already less efficient than the other protocols!) without
> > any
> > plan for supporting them in the other protocols.
>
> Interesting -- can
On Tue, Apr 19, 2016 at 04:02:22PM -0700, Junio C Hamano wrote:
> "brian m. carlson" writes:
>
> > @@ -314,7 +314,7 @@ static int threeway_callback(int n, unsigned long mask,
> > unsigned long dirmask, s
> > }
> >
> > if (same_entry(entry+0, entry+1)) {
> > - if (entry[2].sha
Jacob Keller writes:
> On Tue, Apr 19, 2016 at 10:06 AM, Jeff King wrote:
>> On Tue, Apr 19, 2016 at 08:17:38AM -0700, Stefan Beller wrote:
>>
>>> On Mon, Apr 18, 2016 at 10:03 PM, Jeff King wrote:
>>>
>>> > I guess this will invalidate old patch-ids, but there's not much to be
>>> > done about
On Tue, Apr 19, 2016 at 10:06 AM, Jeff King wrote:
> On Tue, Apr 19, 2016 at 08:17:38AM -0700, Stefan Beller wrote:
>
>> On Mon, Apr 18, 2016 at 10:03 PM, Jeff King wrote:
>>
>> > I guess this will invalidate old patch-ids, but there's not much to be
>> > done about that.
>>
>> What do you mean b
"brian m. carlson" writes:
> @@ -314,7 +314,7 @@ static int threeway_callback(int n, unsigned long mask,
> unsigned long dirmask, s
> }
>
> if (same_entry(entry+0, entry+1)) {
> - if (entry[2].sha1 && !S_ISDIR(entry[2].mode)) {
> + if (entry[2].oid->hash &&
These were added by 8bf4bec (add "ok=sigpipe" to
test_must_fail and use it to fix flaky tests, 2015-11-27)
because we would racily die via SIGPIPE when the pack was
rejected by the other side.
But since we have recently de-flaked send-pack, we should be
able to tighten up these tests (including re
If we get an error from pack-objects, we may exit
send_pack() early, before reading the server's status
response. In such a case, we may racily see SIGPIPE from our
async demuxer (which is trying to write that status back to
us), and we'd prefer to continue pushing the error up the
call stack, rath
In commit 9ff18fa (fetch-pack: ignore SIGPIPE in sideband
demuxer, 2016-02-24), we started using sigchain_push() to
ignore SIGPIPE in the async demuxer thread. However, this is
rather clumsy, as it ignores SIGPIPE for the entire process,
including the main thread. At the time we didn't have any
per
Async processes can be implemented as separate forked
processes, or as threads (depending on the NO_PTHREADS
setting). In the latter case, if an async thread gets
SIGPIPE, it takes down the whole process. This is obviously
bad if the main process was not otherwise going to die, but
even if we were
This fixes a deadlock on the client side when pushing a
large number of refs from a corrupted repo. There's a
reproduction script below, but let's start with a
human-readable explanation.
The client side of a push goes something like this:
1. Start an async process to demux sideband coming fro
I ran across a deadlock today while pushing from a corrupted repository
where pack-objects fails. Obviously I don't expect this to succeed, but
it should not hang indefinitely.
The first patch below fixes the deadlock. Unfortunately, it turns it
into a likely SIGPIPE death. Which is an improvement
On Sun, 2016-04-17 at 12:19 +0700, Duy Nguyen wrote:
> On Wed, Apr 13, 2016 at 7:33 AM, David Turner <
> dtur...@twopensource.com> wrote:
> > @@ -536,8 +567,10 @@ static void handle_builtin(int argc, const
> > char **argv)
> > }
> >
> > builtin = get_builtin(cmd);
> > - if (b
On 19/04/16 22:48, Ramsay Jones wrote:
>
[snip]
> I think the minimal fixup (including Junio's comment on patch #2, which also
> triggered for me) is given in the patch below.
BTW, if you want to have a single static instance of the 'struct trace_key',
then the following patch on top should wo
On Sat, 2016-04-16 at 18:08 +0200, Ævar Arnfjörð Bjarmason wrote:
> On Wed, Apr 13, 2016 at 2:33 AM, David Turner <
> dtur...@twopensource.com> wrote:
> > Add a new command (and command-line arg) to allow index-helpers to
> > exit cleanly.
> >
> > This is mainly useful for tests.
>
> Both --kill
On 19/04/16 16:10, Elia Pinto wrote:
> Add the debug callback and helper routine prototype used by
> curl_easy_setopt CURLOPT_DEBUGFUNCTION in http.c
> for implementing the GIT_TRACE_CURL environment variable
>
>
> Helped-by: Torsten Bögershausen
> Helped-by: Ramsay Jones
> Helped-by: Junio C
On Fri, 2016-04-15 at 17:04 -0700, Stefan Beller wrote:
> > +static int try_shm(struct index_state *istate)
> > +{
> > + void *new_mmap = NULL;
> > + size_t old_size = istate->mmap_size;
> > + ssize_t new_size;
> > + const unsigned char *sha1;
> > + struct stat st;
> >
On Fri, 2016-04-15 at 17:04 -0700, Stefan Beller wrote:
> > +static int try_shm(struct index_state *istate)
> > +{
> > + void *new_mmap = NULL;
> > + size_t old_size = istate->mmap_size;
> > + ssize_t new_size;
> > + const unsigned char *sha1;
> > + struct stat st;
> >
> By the way, you may or may not have noticed that I've been
> reordering the lines of your message quoted in my responses; around
> here, top-posting is frowned upon.
I haven't noticed. Thanks for pointing out.
As for the submitGit cover letter I wanted to raise at least an issue
(if not create
On Tue, 2016-04-19 at 03:14 -0400, Jeff King wrote:
> On Mon, Apr 18, 2016 at 11:45:54AM -0700, Junio C Hamano wrote:
>
> > David Turner writes:
> >
> > > Add parameters for a list of refspecs to
> > > transport_get_remote_refs and
> > > get_refs_list. These parameters are presently unused -- s
Jan Durovec writes:
> On Tue, Apr 19, 2016 at 11:09 PM, Junio C Hamano wrote:
>
>> For a series this small it does not matter, but anything longer it
>> would be easier to review with a cover letter (i.e. [PATCH 0/N]). I
>> do not know if submitGit lets us do that, though.
>
> There's a comment
tbo...@web.de writes:
> From: Torsten Bögershausen
>
> Add more test cases for the not normalized files ("NNO"). The
> "text" attribute is most important, use it as the first parameter.
> "ident", if set, is the second paramater followed by the eol
> attribute. The eol attribute overrides core.
On Sat, 2016-04-16 at 22:33 -0400, Eric Sunshine wrote:
> On Fri, Apr 15, 2016 at 3:19 PM, David Turner <
> dtur...@twopensource.com> wrote:
> > When fetching over http, send the requested refspec to the server.
> > The server will then only send refs matching that refspec. It is
> > permitted for
There's a comment on PR itself (in addition to individual commits) so
theoretically it could.
It seems that for [PATCH ... n/m] e-mails the commit messages are used,
so there's no reason why the PR comment couldn't be used for a cover
letter.
In this case the PR comment was the same as for one of
On Sat, 2016-04-16 at 22:36 -0400, Eric Sunshine wrote:
> On Fri, Apr 15, 2016 at 3:19 PM, David Turner <
> dtur...@twopensource.com> wrote:
> > For single-branch clones (when we know in advance what the remote
> > branch name will be), send a refspec so that the server doesn't
> > tell us about an
Jan Durovec writes:
> On Tue, Apr 19, 2016 at 8:50 PM, Jan Durovec wrote:
>>> Any submitGit users? I think it lets you throw multiple-patch
>>> series just fine. In this case, you'd prepare a two patch series on
>>> a branch, 1/2 being the clean-up and 2/2 being the new feature, and
>>> if you
Lars Schneider writes:
>> On 19 Apr 2016, at 22:30, Junio C Hamano wrote:
>>
>> larsxschnei...@gmail.com writes:
>>
>>> From: Lars Schneider
>>>
>>> Git LFS 1.2.0 removed a line from the output of the 'git lfs pointer'
>>> command [1] which broke the parsing of this output. Adjust the parser
Jeff King writes:
>> What the code tries to do I am more than halfway happy. It is
>> unfortunate that we cannot do this natively without upgrading the
>> protocol in a fundamental way, but this is a nice way to work it
>> around only for Git-over-HTTP transport without having to break the
>> pr
> On 19 Apr 2016, at 22:30, Junio C Hamano wrote:
>
> larsxschnei...@gmail.com writes:
>
>> From: Lars Schneider
>>
>> Git LFS 1.2.0 removed a line from the output of the 'git lfs pointer'
>> command [1] which broke the parsing of this output. Adjust the parser
>> to the new output and add mi
Duy Nguyen writes:
> On Tue, Apr 19, 2016 at 12:42 AM, Junio C Hamano wrote:
>>> Another option is leave wt_status_get_state() alone, factor out the
>>> rebase-detection code and use that for worktree/checkout. We save a
>>> few syscalls this way too.
>>>
>>> Comments?
>>>
>>> [01/07] path.c:
larsxschnei...@gmail.com writes:
> From: Lars Schneider
>
> Git LFS 1.2.0 removed a line from the output of the 'git lfs pointer'
> command [1] which broke the parsing of this output. Adjust the parser
> to the new output and add minimum Git LFS version to the docs.
Hmph, adjust to operate with
Huh... seems that it works :)
v3 sent in 2 parts
On Tue, Apr 19, 2016 at 8:50 PM, Jan Durovec wrote:
>> Any submitGit users? I think it lets you throw multiple-patch
>> series just fine. In this case, you'd prepare a two patch series on
>> a branch, 1/2 being the clean-up and 2/2 being the new
Elia Pinto writes:
> Implements the GIT_TRACE_CURL environment variable to allow a
> greater degree of detail of GIT_CURL_VERBOSE, in particular
> the complete transport header and all the data payload exchanged.
> It might be useful if a particular situation could require a more
> thorough debug
From: Lars Schneider
Git LFS 1.2.0 removed a line from the output of the 'git lfs pointer'
command [1] which broke the parsing of this output. Adjust the parser
to the new output and add minimum Git LFS version to the docs.
[1] https://github.com/github/git-lfs/pull/1105
Signed-off-by: Lars Sch
From: Lars Schneider
Travis-CI uses 'brew' to always install the latest available version of
Git LFS on the OS X build machines (on Linux the version is sticky).
A change in Git LFS 1.2.0 [1] breaks the git-p4 LFS integration [2].
This mini series updates Travis-CI to the latest Git-LFS and Perf
From: Lars Schneider
Signed-off-by: Lars Schneider
---
.travis.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 78e433b..4acf617 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -22,8 +22,8 @@ addons:
env:
global:
- DEVELOPER=1
-
When migrating from Perforce to git the information about P4 jobs
associated with P4 changelists is lost.
Having these jobs listed on messages of related git commits enables smooth
migration for projects that take advantage of e.g. JIRA integration
(which uses jobs on Perforce side and parses comm
Preliminary clean-up of testing libraries for git-p4.
* spaces added to both sides of () in function definitions in lib-git-p4
* tab indentation added to git-p4 tests when <<- redirection is used
Signed-off-by: Jan Durovec
---
t/lib-git-p4.sh | 24 +++
t/t9826-g
Junio C Hamano writes:
> Hmph, two patches in the previous series seem to be missing. On
> purpose, or by mistake? Their net-effect is shown at the end of
> this message, and I thought they made sense.
>
> Puzzled...
Ah, I see. These two were sent outside the series, but because they
are on t
Eric Sunshine writes:
> I'd have probably called this "display_name", but then I suppose it
> suffers the same issue Junio mentioned previously about it sounding
> like a boolean. Anyhow, as long as Junio is happy with it, that's what
> matters.
No ;-) I am just trying to help people come up wit
On Mon, 2016-04-18 at 11:45 -0700, Junio C Hamano wrote:
> David Turner writes:
>
> > Add parameters for a list of refspecs to transport_get_remote_refs
> > and
> > get_refs_list. These parameters are presently unused -- soon, we
> > will
> > use them to implement fetches which only learn about
On Mon, 2016-04-18 at 11:35 -0700, Junio C Hamano wrote:
> David Turner writes:
>
> > The local variable 'options' was shadowing a global of the same
> > name.
> >
> > Signed-off-by: David Turner
> > ---
>
> OK. In general, giving a longer and more descriptive name to the
> global would be a
On Tue, Apr 19, 2016 at 1:47 PM, wrote:
> The current interface of verify_tag() resolves reference names to SHA1,
> however, the plan is to make this functionality public and the current
> interface is cumbersome for callers: they are expected to supply the
> textual representation of a sha1/refn
On Mon, 2016-04-18 at 11:34 -0700, Junio C Hamano wrote:
> David Turner writes:
>
> > Signed-off-by: David Turner
> > ---
>
> OK (it might be easier to read if you used the pushl form for the
> "fixed initial segment" like these calls, though).
Good idea.
--
To unsubscribe from this list: send
On Tue, Apr 19, 2016 at 1:47 PM, wrote:
> This is a follow up of [1], [2], [3], [4], [5], [6]. patches 1/6, 2/6, are the
> same as the corresponding commits in pu.
>
> v7:
> Mostly style/clarity changes mostly. Thanks Peff, Eric and Junio for the
> feedback! In summary:
>
> * Eric pointed out is
On Tue, Apr 19, 2016 at 1:47 PM, wrote:
> tag -v: verfy directly rather than exec-ing verify-tag
s/verfy/verify:
> Instead of having tag -v fork to run verify-tag, use the
> gpg_verify_tag() function directly.
This description is easy enough to understand. Thanks.
> Signed-off-by: Santiago To
Hmph, two patches in the previous series seem to be missing. On
purpose, or by mistake? Their net-effect is shown at the end of
this message, and I thought they made sense.
Puzzled...
diff --git a/builtin/branch.c b/builtin/branch.c
index 5ab106b..32be954 100644
--- a/builtin/branch.c
+++ b/bui
On 19/04/16 09:42, Adam Dinwoodie wrote:
> On Mon, Apr 18, 2016 at 06:08:15PM +0100, Ramsay Jones wrote:
>> On 18/04/16 16:21, Adam Dinwoodie wrote:
>>> t7008.12 is marked as an expected failure, but building Git on Cygwin
>>> including a `make configure && ./configure` step has the test
>>> unex
On Sat, 2016-04-16 at 21:51 -0400, Eric Sunshine wrote:
> On Fri, Apr 15, 2016 at 3:19 PM, David Turner <
> dtur...@twopensource.com> wrote:
> > + if (refspec) {
> > + struct strbuf interesting_refs =
> > STRBUF_INIT;
> > + strbuf_addstr(&in
On Fri, 2016-04-15 at 17:07 -0700, Stefan Beller wrote:
> > +static void refresh_by_watchman(struct index_state *istate)
> > +{
> > + void *shm = NULL;
> > + int length;
> > + int i;
> > + struct stat st;
> > + int fd = -1;
> > + const char *path = index_helper_p
> Any submitGit users? I think it lets you throw multiple-patch
> series just fine. In this case, you'd prepare a two patch series on
> a branch, 1/2 being the clean-up and 2/2 being the new feature, and
> if you give that branch to submitGit as a whole it should do the
> right thing, I'd imagine
Jan Durovec writes:
> On Tue, Apr 19, 2016 at 7:47 PM, Junio C Hamano wrote:
>>
>> If you really want to know the preference, we prefer a preliminary
>> clean-up patch to correct existing style issues, followed by a new
>> feature patch that builds on the cleaned up codebase.
>
> Would it be acc
Dear Beloved
I am Mrs. Lily KIm from Syria who is dying for a gaseous poisoning exposition
in Syria who has decided to donate her funds to you for charity project, For
More details contact me.
Via e-mail: mrslilyki...@gmail.com
Thank you and God bless you.
Mrs. Lily Kim
--
To unsubscribe from thi
When directories are moved using `git mv` all files in the directory
have been just moved, but no further action was taken on them. This
was done by assigning the mode = WORKING_DIRECTORY to the files
inside a moved directory.
submodules however need to update their link to the git directory as
we
Stefan Beller writes:
> ..., but I am unsure
> if patch 1 is a good idea.
Then let's postpone it for now. I too would like to hear opinion
from other submodule folks, especially Jens, for what 1/2 does
before committing us to the course.
Can you do only the 2/2 on top of maint (or maint-2.6) f
Elia Pinto writes:
> Permit the use of the GIT_TRACE_CURL environment variable calling
> the curl_trace and curl_dump http.c helper routine
s/$/./; the patch itself is very concise and the "dump" thing in 3/4
looked sensible.
>
> Helped-by: Torsten Bögershausen
> Helped-by: Ramsay Jones
> Hel
On Tue, Apr 19, 2016 at 12:14 AM, Jeff King wrote:
> On Mon, Apr 18, 2016 at 11:45:54AM -0700, Junio C Hamano wrote:
>
>> David Turner writes:
>>
>> > Add parameters for a list of refspecs to transport_get_remote_refs and
>> > get_refs_list. These parameters are presently unused -- soon, we will
Would it be acceptable the other way around? I.e. this patch followed
by the one that fixes code style (once this gets merged)?
Reason being that I don't know how to use submitGit to generate a patch
against a state that is not already in git repo (ie. based on another
patch).
In the following pa
Elia Pinto writes:
> Implements the GIT_TRACE_CURL environment variable to allow a
> greater degree of detail of GIT_CURL_VERBOSE, in particular
> the complete transport header and all the data payload exchanged.
> It might be useful if a particular situation could require a more
> thorough debug
Elia Pinto writes:
> Add the debug callback and helper routine prototype used by
> curl_easy_setopt CURLOPT_DEBUGFUNCTION in http.c
> for implementing the GIT_TRACE_CURL environment variable
>
>
> Helped-by: Torsten Bögershausen
> Helped-by: Ramsay Jones
> Helped-by: Junio C Hamano
> Helped-by
Junio C Hamano writes:
> Not a new problem in this script, but we'd prefer to spell this as
>
> p4_add_job () {
>
> i.e. a space on both sides of ().
>
>> +name=$1 &&
>> +p4 job -f -i <<-EOF
>> +Job: $name
>> +Status: open
>> +User: dummy
>> +Description:
>> +EOF
>
Jan Durovec writes:
> given the fact that the rest of the code just follows existing
> source code style, i.e.
>
> * using %s not %d to add number to string (see git-p4.py:2301)
This one I do not care too deeply about, as formatting anything that
can be formatted via '%s' could just be more Pyth
From: Santiago Torres
The verify_signed_buffer() function may trigger a SIGPIPE when the
GPG child process terminates early (due to a bad keyid, for example)
and Git tries to write to it afterwards. Previously, ignoring
SIGPIPE was done in builtin/verify-tag.c to avoid this issue.
However, any
From: Santiago Torres
The current interface of verify_tag() resolves reference names to SHA1,
however, the plan is to make this functionality public and the current
interface is cumbersome for callers: they are expected to supply the
textual representation of a sha1/refname. In many cases, this r
From: Santiago Torres
The PGP verification routine for tags could be accessed by other modules
that require to do so.
Publish the verify_tag function in tag.c and rename it to gpg_verify_tag
so it does not conflict with builtin/mktag's static function.
Helped-by: Junio C Hamano
Signed-off-by:
1 - 100 of 142 matches
Mail list logo