[PATCH] t1410: Fix for case insensitive filesystems

: Brian Gernhardt --- t/t1410-reflog.sh | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh index 976c1d4..ac31e19 100755 --- a/t/t1410-reflog.sh +++ b/t/t1410-reflog.sh @@ -254,36 +254,36

Re: [PATCH] Receive-pack: include entire SHA1 in nonce

ot;, so don't feel too bad. Making the commit message accurate is perfectly fine, and all the patches you've posted look right at first glance (and to make test as well), so I'm fine with a Signed-off-by: Brian Gernhardt attached to whatever commit is actually appropriate ins

[PATCH] Receive-pack: include entire SHA1 in nonce

clang gives the following warning: builtin/receive-pack.c:327:35: error: sizeof on array function parameter will return size of 'unsigned char *' instead of 'unsigned char [20]' [-Werror,-Wsizeof-array-argument] git_SHA1_Update(&ctx, out, sizeof(out));

[PATCH] t7510: Skip all if GPG isn't installed

Since the setup requires the GPG prerequisite, it doesn't make much sense to try and run any tests without it. So rather than using a prereq on each individual test and possibly forgetting it on new ones (as just happened), skip the entire file if GPG isn't found. Signed-off-by: Brian

[PATCH] Use long for timezone in pretty.c:show_ident_date()

The value is parsed with strtol and compared against LONG_MIN and LONG_MAX, which doesn't make much sense for an int. Signed-off-by: Brian Gernhardt --- pretty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pretty.c b/pretty.c index 3b811ed..29ebc4f 100644 --- a/pre

Re: [PATCH] Ensure __BYTE_ORDER is always set

unning `git rev-list --test-bitmap HEAD` (and others if I don't have it die immediately). That seems to me that there is a check to ensure it doesn't run off the end. Perhaps you have assertions disabled so hit an error somewhere else? ~~ Brian Gernhardt -- To unsubscribe fro

[PATCH] Ensure __BYTE_ORDER is always set

e out of a conditional so that either __BYTE_ORDER is defined or we get a compilation error instead of a runtime error in the bitmap code. Signed-off-by: Brian Gernhardt --- compat/bswap.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/compat/bswa

[PATCH 2/2] t5570: Update for clone-progress-to-stderr branch

git clone now reports its progress to standard error, which throws off t5570. Using test_i18ngrep instead of test_cmp allows the test to be more flexible by only looking for the expected error and ignoring any other output from the program. Signed-off-by: Brian Gernhardt --- t/t5570-git

[PATCH 1/2] t5570: Update for symref capability

git-daemon now uses the symref capability to send the correct HEAD reference, so the test for that in t5570 now passes. Signed-off-by: Brian Gernhardt --- t/t5570-git-daemon.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh

t3010 broken by 2eac2a4

28) (based on LLVM 3.2svn)" ~~ Brian Gernhardt -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] OS X: Fix redeclaration of die warning

compat/apple-common-crypto.h uses die() in one of its macros, but was included in git-compat-util.h before the definition of die. Fix by simply moving the relevant block after the die/error/warning declarations. Signed-off-by: Brian Gernhardt --- Not sure if this is the best place to move it

[PATCH 1/3] Makefile: Fix APPLE_COMMON_CRYPTO with BLK_SHA1

It used to be that APPLE_COMMON_CRYPTO did nothing when BLK_SHA1 was set. But APPLE_COMMON_CRYPTO is now used for more than just SHA1 (see 3ef2bca) so make sure that the appropriate libraries are always set. Signed-off-by: Brian Gernhardt --- Makefile | 4 +++- 1 file changed, 3 insertions

[PATCH 3/3] t5551: Remove header from curl cookie file

The URL included in the header appears to vary from curl version to curl version. Since we only care about the final few lines, only test them. However, make sure the blank line after the header is still included to make sure there are no extra cookie lines. Signed-off-by: Brian Gernhardt

[PATCH 0/3] Fixes for OS X

version skew between Dave Borowitz and myself. (see 912b2ac). There are a few notes on the patches indicating where I was less than sure about my solutions. Brian Gernhardt (3): Makefile: Fix APPLE_COMMON_CRYPTO with BLK_SHA1 OS X: Fix redeclaration of die warning t5551: Remove header from

Re: [PATCH] t0008: avoid SIGPIPE race condition on fifo

On Jul 12, 2013, at 6:35 AM, Jeff King wrote: > Subject: [PATCH] t0008: avoid SIGPIPE race condition on fifo Was able to complete a prove run with this patch. Many thanks. ~~ Brian -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.ker

Re: t0008 hang on streaming test (OS X)

On Jul 10, 2013, at 4:35 PM, Antoine Pelisse wrote: > On Wed, Jul 10, 2013 at 6:36 PM, Brian Gernhardt > wrote: >> I am somewhat stuck on how to fix it. Any ideas? > > I don't have anything to reproduce here, but usually I start > investigating this kind of prob

Re: t0008 hang on streaming test (OS X)

On Jul 11, 2013, at 9:34 AM, Jeff King wrote: > On Wed, Jul 10, 2013 at 12:36:40PM -0400, Brian Gernhardt wrote: > >> The newest test in t0008 "streaming support for --stdin", >> Experimentation has led me to find that it is hanging when trying to read >>

t0008 hang on streaming test (OS X)

t stuck on how to fix it. Any ideas? ~~ Brian Gernhardt-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] t4205: replace .\+ with ..* in sed commands

OS X's sed only accepts basic regular expressions, which does not allow the + quantifier. However '..*' (anything, followed by zero or more anything) is the same as '.\+' (one or more anything) and valid in any regular expression language. Signed-off-by: Brian Gernhardt

Re: [PATCH] lib-httpd/apache.conf: check version only after mod_version loads

On Jun 21, 2013, at 2:12 PM, Jeff King wrote: > On Fri, Jun 21, 2013 at 02:08:49PM -0400, Brian Gernhardt wrote: > >> On Jun 21, 2013, at 2:03 PM, Jeff King wrote: >> >>> IfVersion comes from mod_version. I assume that if it were not >>> loaded, apach

Re: HTTP tests fail on OS X

On Jun 21, 2013, at 2:03 PM, Jeff King wrote: > IfVersion comes from mod_version. I assume that if it were not loaded, > apache would complain about the directive entirely. But it's true that > we don't load it until later. Maybe try moving the IfVersion/Lockfile > stanza down below the mod_vers

Re: HTTP tests fail on OS X

On Jun 21, 2013, at 12:49 AM, Jeff King wrote: > I'm not sure what else to look at...I guess try ratcheting up the > debugging/log level on your failing copy and see if it prints anything > useful. I found this error in the error.log: [Fri Jun 21 12:59:59 2013] [emerg] (2)No such file or direc

[PATCH] git-remote-hg: Fix . at end of ref

this problem. Signed-off-by: Brian Gernhardt --- contrib/remote-helpers/git-remote-hg | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 0194c67..7fa6cd7 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b

Re: HTTP tests fail on OS X

On Jun 21, 2013, at 12:42 AM, Jeff King wrote: > I'm not sure if there is something different between 2.2.16 and 2.2.22, > or something with the particular build. Here's my -V output, in case it > helps: > >$ apache2 -V >Server version: Apache/2.2.16 (Debian) >Server built: Mar 3

HTTP tests fail on OS X

, so I can't look at it again for at least several hours. I figured I'd ping the list in case the problem/solution is obvious to someone else. ~~ Brian Gernhardt -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kern

[PATCH 3/3] t5570: do not assume the "matching" push is the default

Signed-off-by: Brian Gernhardt --- t/t5570-git-daemon.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh index a3a4e47..f01edff 100755 --- a/t/t5570-git-daemon.sh +++ b/t/t5570-git-daemon.sh @@ -8,6 +8,7 @@ LIB_GIT_DAEMON_PORT

[PATCH 1/3] t5550: do not assume the "matching" push is the default

Signed-off-by: Brian Gernhardt --- t/t5550-http-fetch.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/t5550-http-fetch.sh b/t/t5550-http-fetch.sh index 80d20c8..f7d0f14 100755 --- a/t/t5550-http-fetch.sh +++ b/t/t5550-http-fetch.sh @@ -13,6 +13,7 @@ LIB_HTTPD_PORT=${LIB_HTTPD_PORT-'

[PATCH 2/3] t5551: do not assume the "matching" push is the default

Signed-off-by: Brian Gernhardt --- t/t5551-http-fetch.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/t5551-http-fetch.sh b/t/t5551-http-fetch.sh index c5cd2e3..1b55086 100755 --- a/t/t5551-http-fetch.sh +++ b/t/t5551-http-fetch.sh @@ -13,6 +13,7 @@ LIB_HTTPD_PORT=${LIB_HTTPD_PORT-'

[PATCH 0/3] Update HTTPD/daemon tests for new push.default

I saw a string of these commits already, but found a few more when running the test suite. Brian Gernhardt (3): t5550: do not assume the "matching" push is the default t5551: do not assume the "matching" push is the default t5570: do not assume the "matching"

Re: [PATCH] Use character class for sed expression instead of \s

On Oct 25, 2012, at 11:58 AM, Ben Walton wrote: > Sed on Mac OS X doesn't handle \s in a sed expressions so use a more > portable character set expression instead. > > Signed-off-by: Ben Walton Acked-by: Brian Gernhardt I have an identical change sitting in my git.git, I

t9401 fails with OS X sed

tions:\s*//p' "${WORKDIR}/status.out")" The problem is that cvs outputs "Sticky Options:\t\t(none)\n", but OS X's sed doesn't recognize the \s shortcut. (According to re_format(5), \s is part of the "enhanced" regex format, which sed doesn

Test failures in t4034

I've been getting a couple of test failures and finally had the time to track them down. t4034-diff-words fails tests "22 diff driver 'bibtex'" and "26 diff driver 'html'". Bisecting shows that the file started giving me errors in commit 8d96e72 "t4034: bulk verify builtin word regex sanity",