Duy Nguyen writes:
> On Tue, Mar 18, 2014 at 12:16 PM, Duy Nguyen wrote:
>> But I think it's orthogonal to gc --aggressive improvement.
>
> There's another reason that improving gc may be a good idea (or not).
> It depends on how other git implementations handle long delta chains.
"Other git im
Cc René; do you have any comments regarding grep --function-context?
Am 3/18/2014 6:24, schrieb Jeff King:
> On Fri, Mar 14, 2014 at 07:56:46AM +0100, Johannes Sixt wrote:
>
>> Consider this code:
>>
>> void above()
>> {}
>> static int Y;
>> static int A;
>> int bar()
>> {
>> retu
Hi,
I am running a Mac 10.6.8 and tried to install git-1.9.0 off of the
installer (git-1.9.0-intel-universal-snow-leopard.dmg). The
installation worked fine and gave no error messages. But whenever I
type in a git command (see below for some I tried), it gives me this
error message:
Illegal instruc
Teach rebase the same shorthand as checkout and merge; that is, that "-"
means "the branch we were previously on".
Reported-by: Tim Chase
Signed-off-by: Brian Gesiak
---
git-rebase.sh | 4
t/t3400-rebase.sh | 6 ++
2 files changed, 10 insertions(+)
diff --git a/git-rebase.sh b/git
Signed-off-by: Benoit Pierre
---
run-command.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/run-command.h b/run-command.h
index 88460f9..3653bfa 100644
--- a/run-command.h
+++ b/run-command.h
@@ -51,6 +51,7 @@ extern int run_hook_le(const char *const *env, const char
*name, ...);
extern
Don't change git environment: move the GIT_EDITOR=":" override to the
hook command subprocess, like it's already done for GIT_INDEX_FILE.
Signed-off-by: Benoit Pierre
---
builtin/checkout.c | 8
builtin/clone.c | 4 ++--
builtin/commit.c| 35 ++
- update 'no editor' hook test and add 'editor' hook test
- make sure the tree is reset to a clean state after running a test
(using test_when_finished) so later tests are not impacted
Signed-off-by: Benoit Pierre
---
t/t7505-prepare-commit-msg-hook.sh | 27 +--
1 file
Signed-off-by: Benoit Pierre
---
t/t7505-prepare-commit-msg-hook.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t7505-prepare-commit-msg-hook.sh
b/t/t7505-prepare-commit-msg-hook.sh
index 1c95652..5531abb 100755
--- a/t/t7505-prepare-commit-msg-hook.sh
+++ b/t/t7505
Add (failing) tests: with commit changing the environment to let hooks
know that no editor will be used (by setting GIT_EDITOR to ":"), the
"edit hunk" functionality does not work (no editor is launched and the
whole hunk is committed).
Signed-off-by: Benoit Pierre
---
t/t7514-commit-patch.sh |
Signed-off-by: Benoit Pierre
---
t/t7505-prepare-commit-msg-hook.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7505-prepare-commit-msg-hook.sh
b/t/t7505-prepare-commit-msg-hook.sh
index 3573751..1c95652 100755
--- a/t/t7505-prepare-commit-msg-hook.sh
+++ b/t/t7505-pre
Don't set GIT_EDITOR to ":" when calling prepare-commit-msg hook if the
editor is going to be called (e.g. with "merge -e").
Signed-off-by: Benoit Pierre
---
builtin/merge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/merge.c b/builtin/merge.c
index bdf6655..e15d0
Junio C Hamano writes:
> Andreas Schwab writes:
>
>> This configuration variable sets the default for the --full-name option.
>>
>> Signed-off-by: Andreas Schwab
>> ---
>
> Would this change break Porcelains (e.g. Emacs modes) and force them
> to be updated to explicitly pass --no-full-name to
On Tue, 18 Mar 2014 01:33:25 -0700
Ray Hengst wrote:
> Hi,
> I am running a Mac 10.6.8 and tried to install git-1.9.0 off of the
> installer (git-1.9.0-intel-universal-snow-leopard.dmg). The
> installation worked fine and gave no error messages. But whenever I
> type in a git command (see below f
Am 18.03.2014 09:02, schrieb Johannes Sixt:
Cc René; do you have any comments regarding grep --function-context?
Am 3/18/2014 6:24, schrieb Jeff King:
On Fri, Mar 14, 2014 at 07:56:46AM +0100, Johannes Sixt wrote:
Consider this code:
void above()
{}
static int Y;
static int A;
On Tue, Mar 18, 2014 at 3:32 AM, Junio C Hamano wrote:
> Nguyễn Thái Ngọc Duy writes:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy
>> ---
>> v2 renames the option name to --nonlinear-barrier and fixes using it
>> with --dense. Best used with --no-merges to see patch series.
>
> I think that the e
This patch replaces if chain that selects the message with
2 dimensional array of format strings and arguments.
Signed-off-by: Aleksey Mokhovikov
---
This patch is unrelated with previous one, but related to GSoC.
So I don't know if I should create new thread for this patch.
Compare with origi
Origin code are code with own realisation argv array editing.
It was changed, and code modified for using unified argv-array
realisation from argv-array.h.
Commit for Google Summer of Code 2014
Signed-off-by: Movchan Pavel
---
builtin/add.c | 21 ++---
1 file changed, 10 insert
Please is your email really active?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear all,
Git won an award in the main category of the English & German Linux
Magazine at CeBIT, this year. Jens Lehmann, Heiko Voigt, and myself
were present to accept the award on behalf of the Git community as a
whole.
You can find a short blurb on my blog[1], including a picture of the
phys
Eric Sunshine sunshineco.com> writes:
> The subject should be concise. Try to keep it at 65-70 characters or
> less. More detailed information can be written following the subject
> (separated from the subject by a blank line).
>
> Write in imperative tone: say "replace X with Y" rather than "X i
On Tue, Mar 18, 2014 at 9:27 PM, Duy Nguyen wrote:
> I thought about "GIT_CAPABILITIES= git-upload-pack ..." (and actually
> added it in pack-protocol.txt then deleted). The thing is, if you want
> to new upload-pack, you would need new git-upload-pack at the remote
> end that must understand "git
On Tue, Mar 18, 2014 at 12:17:39AM -0400, Jeff King wrote:
> On Fri, Mar 14, 2014 at 05:09:45PM -0700, Shawn Pearce wrote:
>
> > On Fri, Mar 14, 2014 at 4:30 PM, Duy Nguyen wrote:
> > > On Fri, Mar 14, 2014 at 11:45 PM, Shawn Pearce
> > > wrote:
> > >>
> > >> You missed the SSH case. It doesn't
This patch replaces if chain with
2 dimensional array of format strings and arguments.
Signed-off-by: Aleksey Mokhovikov
---
This patch is unrelated with previous one, but related to GSoC.
So I don't know if I should create new thread for this patch.
Compare with original construction
Pros:
1)
Matthieu Moy grenoble-inp.fr> writes:
>
> Hi,
>
> Aleksey Mokhovikov gmail.com> writes:
>
> Please, read the threads for other submissions for this microproject.
> Most remarks done there also apply for your case. See for example:
>
> http://thread.gmane.org/gmane.comp.version-control.git/2442
Jagan:
On Fri, Mar 14, 2014 at 1:11 PM, Jagan Teki wrote:
> Don't know what happen, I'm unable to join #git channel
> [23:40] hi
> [23:40] == Cannot send to channel: #git
I'm not sure if this is the problem that you were having, but #git on
freenode is NickServ protected. You need to register w
Jagan:
On Fri, Mar 14, 2014 at 12:39 PM, Jagan Teki wrote:
> Hi,
Hello,
> I have two branch in one repo that I need to maintain for 2 different
> deliveries.
> Say branch1 and branch2 in test.git repo.
>
> test.git
> - branch1
> foo_v1/text.txt
> foo_v2/text.txt
> - branch2
> foo
User config file location now complies with XDG base directory specification
Signed-off-by: Astril Hayato
---
Documentation/gitk.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/gitk.txt b/Documentation/gitk.txt
index 1e9e38a..c2aa514 100644
--- a/Do
What's the general recommendation on rebasing after creating a merge
commit on my branch? I realize rebase has the -p option but it seems
like it does a lot of complicated stuff, and it discourages
interactive rebase with the option.
My situation is simple: I have a topic1 branch that has a few co
Thanks; will replace what has been on 'pu' with the updated series.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Andreas Schwab writes:
> Yes, that would be required. On the other hand, currently it is
> impossible to cut-n-paste a file name without --full-name, since the
> pager is always started in top-level. Perhaps it is better to fix the
> latter?
So far we never cared where the pager runs, but as a
Uwe Storbeck writes:
> In some places we "echo" a string that is supplied by the calling
> test script and may contain backslash sequences. The echo command
> of some shells, most notably "dash", interprets these backslash
> sequences (POSIX.1 allows this) which may scramble the test
> output.
>
Tim Chase writes:
> On 2014-03-16 23:37, Junio C Hamano wrote:
>> Tim Chase writes:
>>
>> > Is this just an interface inconsistency or is there a some
>> > technical reason this doesn't work (or, has it been
>> > addressed/fixed, and just not pulled into Debian Stable's
>> > 1.7.10.4 version of
Duy Nguyen writes:
>> I do not quite understand the "if we do not have previous parents"
>> bit, though. Is it meant to trigger only at the very beginning?
>
> Only at the beginning.
Then I am not sure !revs->previous_parents match that condition.
What happens in a history with more than one r
Eric Sunshine writes:
>>> A patch of this nature doesn't require much more description than
>>> stating what it does ("replace memcmp() with starts_with()") and why
>>> ("improve code clarity"). The following rewrite might be sufficient:
>>>
>>> Subject: replace memcmp() with starts_with()
>>
On 03/18/2014 09:44 AM, Brian Gesiak wrote:
Teach rebase the same shorthand as checkout and merge; that is, that "-"
means "the branch we were previously on".
Reported-by: Tim Chase
Signed-off-by: Brian Gesiak
---
git-rebase.sh | 4
t/t3400-rebase.sh | 6 ++
2 files changed, 1
Jacopo Notarstefano writes:
> It seems to me that the topic of adding the checkpatch.pl script to
> Git's source tree has cropped up several times in the past, as
> recently as a couple of days ago: $gmane/243607.
>
> It should be noted that its usage for its sake has been discouraged by
> Junio
Eric Sunshine writes:
>> 1. Git style guidelines are somewhat different and less strict than
>> their Linux equivalents.
>
> Are checkpatch.pl's customization options, such as --ignore,
> insufficient to make it behave in the desired fashion for git?
If we are to officially encourage the use of
Brian Gesiak writes:
> Teach rebase the same shorthand as checkout and merge; that is, that "-"
> means "the branch we were previously on".
>
> Reported-by: Tim Chase
> Signed-off-by: Brian Gesiak
> ---
> git-rebase.sh | 4
> t/t3400-rebase.sh | 6 ++
> 2 files changed, 10 inserti
Movchan Pavel writes:
> Origin code are code with own realisation argv array editing.
> It was changed, and code modified for using unified argv-array
> realisation from argv-array.h.
> Commit for Google Summer of Code 2014
>
> Signed-off-by: Movchan Pavel
> ---
Thanks. "Commit for ..." is not
Junio C Hamano writes:
> Don't we have the exact same issue for the editor, by the way?
> Shouldn't we be running it in the original subdirectory as well?
It's called with an absolute name, so it shouldn't care.
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7
Richard Hartmann writes:
> Dear all,
>
> Git won an award in the main category of the English & German Linux
> Magazine at CeBIT, this year. Jens Lehmann, Heiko Voigt, and myself
> were present to accept the award on behalf of the Git community as a
> whole.
>
> You can find a short blurb on my b
Andreas Schwab writes:
> Junio C Hamano writes:
>
>> Andreas Schwab writes:
>>
>>> This configuration variable sets the default for the --full-name option.
>>>
>>> Signed-off-by: Andreas Schwab
>>> ---
>>
>> Would this change break Porcelains (e.g. Emacs modes) and force them
>> to be updated
Originally, the code used subshells instead of FOO=BAR command because
the variable would otherwise leak into the surrounding context of the POSIX
shell when 'command' is a shell function. The subshell was used to hold the
context for the test. Using 'env' in the test function sets the temp variabl
Astril Hayato writes:
> User config file location now complies with XDG base directory specification
>
> Signed-off-by: Astril Hayato
> ---
> Documentation/gitk.txt | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/gitk.txt b/Documentation/gitk.txt
Andreas Schwab writes:
> Junio C Hamano writes:
>
>> Don't we have the exact same issue for the editor, by the way?
>> Shouldn't we be running it in the original subdirectory as well?
>
> It's called with an absolute name, so it shouldn't care.
But we should not have to call with absolute paths
David Tran writes:
> Originally, the code used subshells instead of FOO=BAR command
> because the variable would otherwise leak into the surrounding
> context of the POSIX shell when 'command' is a shell function.
> The subshell was used to hold the context for the test. Using
> 'env' in the test
On Tue, Mar 18, 2014 at 8:08 AM, David Tran wrote:
> Originally, the code used subshells instead of FOO=BAR command because
> the variable would otherwise leak into the surrounding context of the POSIX
> shell when 'command' is a shell function. The subshell was used to hold the
> context for the
On Mon, Mar 17, 2014 at 7:46 AM, Dragos Foianu wrote:
> Eric Sunshine sunshineco.com> writes:
>> Matthieu already mentioned [2] that this sort of "lego" string
>> construction is not internationalization-friendly. See section 4.3 [3]
>> of the gettext manual for details.
>
> I was hoping to get a
On Tue, Mar 18, 2014 at 01:37:39PM -0700, Junio C Hamano wrote:
> > diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
> > index c9c426c..3e3f77b 100755
> > --- a/t/t1300-repo-config.sh
> > +++ b/t/t1300-repo-config.sh
> > @@ -974,24 +974,15 @@ test_expect_success SYMLINKS 'symlinked
>
The latest maintenance release Git v1.9.1 is now available at
the usual places.
The release tarballs are found at:
https://www.kernel.org/pub/software/scm/git/
The following public repositories all have a copy of the v1.9.1
tag and the maint branch that the tag points at:
url = https://ke
Junio C Hamano wrote:
>> Uwe Storbeck wrote:
>>> + printf '%s\n' "$@" | sed -e 's/^/# /'
>
> This is wrong, isn't it? Why do we want one line per item here?
Yes, Hannes caught the same, too. Sorry for the sloppiness.
We currently use "echo" all over the place (e.g., 'echo "$path"' in
gi
Jeff King writes:
> On Tue, Mar 18, 2014 at 01:37:39PM -0700, Junio C Hamano wrote:
>
>> > diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
>> > index c9c426c..3e3f77b 100755
>> > --- a/t/t1300-repo-config.sh
>> > +++ b/t/t1300-repo-config.sh
>> > @@ -974,24 +974,15 @@ test_expect_suc
Thanks for the resubmission. Comments below...
On Mon, Mar 17, 2014 at 11:51 AM, Dragos Foianu wrote:
> This patch uses a table to store the different messages that can
> be emitted by the verbose install_branch_config function. It
> computes an index based on the three flags and prints the messa
Michael Haggerty writes:
> I had recently been thinking along the same lines. In many of the
> potential callers that I noticed, ALLOC_GROW() was used immediately
> before making space in the array for a new element. So I suggest
> something more like
>
> +#define MOVE_DOWN(array, nr, at, count
On Tue, Mar 18, 2014 at 5:45 PM, Jeff King wrote:
> On Tue, Mar 18, 2014 at 01:37:39PM -0700, Junio C Hamano wrote:
>
>> > diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
>> > index c9c426c..3e3f77b 100755
>> > --- a/t/t1300-repo-config.sh
>> > +++ b/t/t1300-repo-config.sh
>> > @@ -97
use of starts_with() instead of memcmp()
use of skip_prefix instead of memcmp() and strlen()
Signed-off-by: Othman Darraz
---
I am planning to apply to GSOC 214
fsck.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fsck.c b/fsck.c
index 64bf279..5eae856 100644
---
On Tue, Mar 18, 2014 at 03:16:27PM -0700, Junio C Hamano wrote:
> > Isn't GIT_CONFIG here another way of saying:
> >
> > test_must_fail git config -f doesnotexist --list
> >
> > Perhaps that is shorter and more readable still (and there are a few
> > similar cases in this patch.
>
> Surely, but
Thanks for the submission. Comments below to give you a taste of the
Git review process...
On Tue, Mar 18, 2014 at 6:41 PM, Othman Darraz wrote:
> use of starts_with() instead of memcmp()
>
> use of skip_prefix instead of memcmp() and strlen()
Write proper sentences to explain and justify the ch
On Tue, Mar 18, 2014 at 7:09 PM, Eric Sunshine wrote:
>> diff --git a/fsck.c b/fsck.c
>> index 64bf279..5eae856 100644
>> --- a/fsck.c
>> +++ b/fsck.c
>> @@ -290,7 +290,7 @@ static int fsck_commit(struct commit *commit, fsck_error
>> error_func)
>> int parents = 0;
>> int err;
>>
On 03/19/2014 12:09 AM, Eric Sunshine wrote:
> Thanks for the submission. Comments below to give you a taste of the
> Git review process...
>
> On Tue, Mar 18, 2014 at 6:41 PM, Othman Darraz wrote:
>> use of starts_with() instead of memcmp()
>>
>> use of skip_prefix instead of memcmp() and strlen
On Tue, Mar 18, 2014 at 6:31 PM, Eric Sunshine wrote:
> On Mon, Mar 17, 2014 at 11:51 AM, Dragos Foianu
> wrote:
>> This patch uses a table to store the different messages that can
>> be emitted by the verbose install_branch_config function. It
>> computes an index based on the three flags and p
On Tue, Mar 18, 2014 at 8:29 PM, Junio C Hamano wrote:
>
> I've never said any such thing.
>
> I only said I am not enthused against a proposal to add a build
> target that runs checkpatch or equivalent over *all* existing code,
> which will invite needless churn (read again the part of the messag
this was done in order to implement the GSoC
Micro project for diff-no-index.c this is the
first patch importing dir.h, for the use of
is_dot_or_dotdot(), and renaming
read_directory() to read_directory_contents()
in order to deal with the conflicting function
in dir.h
Signed-off-by: Brian Bourn
Subject: [PATCH] Enable index-pack threading in msysgit.
This adds a Windows implementation of pread. Note that it is NOT
safe to intersperse calls to read() and pread() on a file
descriptor. According to the ReadFile spec, using the 'overlapped'
argument should not affect the implicit position
This adds a Windows implementation of pread. Note that it is NOT
safe to intersperse calls to read() and pread() on a file
descriptor. According to the ReadFile spec, using the 'overlapped'
argument should not affect the implicit position pointer of the
descriptor. Experiments have shown that th
Another version, this time very in line with the review and commentary of
Junio, Eric, and Michael. This version boasts a revamped commit message and
fewer but surer hunks changed.
Thanks again for the guidance.
Quint Guvernator (1):
use starts_with() instead of !memcmp()
builtin/apply.c
When checking if a string begins with a constant string, using
starts_with() indicates the intention of the check more clearly and is
less error-prone than calling !memcmp() with an explicit byte count.
Signed-off-by: Quint Guvernator
---
builtin/apply.c| 4 ++--
builtin/for-each-ref.c
Thanks for the submission. Comments below to give you a taste of the
Git review process...
On Tue, Mar 18, 2014 at 8:35 PM, Brian Bourn wrote:
> Subject: diff: Imported dir.h and renamed read_directory()
Use imperative voice: "import dir.h and rename read_directory()"
> this was done in order t
in accordance with the GSoC Microproject implemented
the call is_dot_or_dotdot() in the code in order to
further universalize the call to the function and
increase code continuity.
Signed-off-by: Brian Bourn
---
diff-no-index.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
Originally, we would use "VAR=VAL command" to execute a test command with
environment variable(s) only for that command. This does not work for commands
that are shell functions (most notably test functions like "test_must_fail");
the result of the assignment is retained and affects later commands.
On Tue, Mar 18, 2014 at 9:30 PM, babourn wrote:
> Subject: diff: used is_dot_or_dotdot() in code
Use imperative voice: "use" rather than "used"
> in accordance with the GSoC Microproject implemented
This commentary will not have much meaning to someone reading the
commit log months or years fro
On Tue, Mar 18, 2014 at 2:54 PM, David Tran wrote:
> Originally, we would use "VAR=VAL command" to execute a test command with
> environment variable(s) only for that command. This does not work for commands
> that are shell functions (most notably test functions like "test_must_fail");
> the resu
On Tue, Mar 18, 2014 at 11:58 PM, Brian Bourn wrote:
> On Tue, Mar 18, 2014 at 11:45 PM, Eric Sunshine
> wrote:
>> On Tue, Mar 18, 2014 at 9:30 PM, babourn wrote:
>> > Subject: diff: used is_dot_or_dotdot() in code
>> > Signed-off-by: Brian Bourn
>> > ---
>> > diff-no-index.c | 2 +-
>> > 1 fi
On Tue, Mar 18, 2014 at 9:18 PM, Quint Guvernator
wrote:
> Another version, this time very in line with the review and commentary of
> Junio, Eric, and Michael. This version boasts a revamped commit message and
> fewer but surer hunks changed.
Explaining what changed in this version is indeed a
Hi,
In need of a loan for any purpose? Look no further, Motichek Loans Agency can
help you with that loan you so seek and @ a 2% interest rate, you have access
to funds between $10,000.00 to $20,000,000.00 If Interested, send your details
via our email below for fast processing of that loan.
Ema
From: Brian Bourn
It is desirable to replace manual checking of "." or ".."
in diff-no-index.c with is_dot_or_dotdot(), which is defined
in dir.h. However, dir.h declares a read_directory which conflicts
with a (different) static read_directory() defined in
in diff-no-index.c. As a preparatory st
From: Brian Bourn
Subject: replace manual "."/".." check with is_dot_or_dotdot()
Signed-off-by: Brian Bourn
---
Part 2 of my GSoC submission where the actual change is made
diff-no-index.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/diff-no-index.c b/diff-no-index.c
i
77 matches
Mail list logo
