[Github-comments] Re: [geany/geany-plugins] Copmiling geangy-plugins appeared errors (Issue #1255)

2023-06-10 Thread Enrico Tröger via Github-comments
@Novak-Zhao contacted me via mail additionally and after updating my MSYS2 environment to the latest packages, I can reproduce the problem. So I assume something has changed which triggers the build errors. I'm not completely sure whether I have read the log correctly, to me it seems it fails

[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)

2023-06-10 Thread Enrico Tröger via Github-comments
> Hmmm, the other CI builds seem to work without a problem. For some reason > this one isn't getting picked up: > > ``` > This request was automatically failed because there were no enabled runners > online to process the request for more than 1 days. > ``` Maybe this is related to the

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-06-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > { + AoTasksUpdateTasksForDocArguments *arguments = data; + AoTasks *t = arguments->t; I think so. The `AoTasks` object exists as long as the Addons plugin is loaded, independently of opened documents and independent of whether the Tasks

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-06-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > { + AoTasksUpdateTasksForDocArguments *arguments = data; + AoTasks *t = arguments->t; + GeanyDocument *doc = arguments->doc; I don't know if there is more than checking `data` for `NULL`. BUt at least I've added this. -- Reply to

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-06-10 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. d975ce3f6c1a8e03d94ceb73bfc635b84bf2a1cc Add more sanity checks -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1257/files/d6cb2c252b314088dd1ae99bacb1a55794098c79..d975ce3f6c1a8e03d94ceb73bfc635b84bf2a1cc You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-06-10 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. d6cb2c252b314088dd1ae99bacb1a55794098c79 Add more sanity checks -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1257/files/e06dced5ccd9aba9af257fb3fca68c3ab13157dd..d6cb2c252b314088dd1ae99bacb1a55794098c79 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)

2023-06-10 Thread Enrico Tröger via Github-comments
>The Windows build doesn't fail (it uses a docker image with >pre-installed deps), but devhelp does not configure, possibly because >that image doesn't have the requisite dependencies. The Docker image is not really relevant here, it only has some dependencies as some sort of cache. The workflow

[Github-comments] Re: [geany/geany-plugins] TODO tasks need the autorefresh button when opening a file to be visible 1.38 kubuntu 22.04, plasma 5.24 (Issue #1254)

2023-06-04 Thread Enrico Tröger via Github-comments
Thank you @elextr for the detailed analysis and for finding that it's us in Geany itself and not (yet) Scintilla. Apart from the upcoming Scintilla change, #1257 should improve the current situation for the Addons task updating by delaying it. In my tests, this worked reliably. -- Reply to

[Github-comments] [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-06-04 Thread Enrico Tröger via Github-comments
Closes #1254. This is not completely perfect but will do the trick to delay the parsing of tasks in the current document until the main loop has triggered the also delayed colourising of the current document which is necessary for parsing the tasks. You can view, comment on, or merge this pull

[Github-comments] [geany/geany] Generate PHP global tags in ctags format (PR #3512)

2023-06-04 Thread Enrico Tröger via Github-comments
This is the follow-up PR for #3488 and #3039 to seperate the code for generating the ctags format into a commonly used helper module and to use the ctags format also for the global PHP tags. Works fine so far. I noticed the return type (`typeref` in ctags speak) for symbols is not parsed

[Github-comments] Re: [geany/geany-plugins] TODO tasks need the autorefresh button when opening a file to be visible 1.38 kubuntu 22.04, plasma 5.24 (Issue #1254)

2023-05-27 Thread Enrico Tröger via Github-comments
I debugged this and the plugin works. But for some reason, when the plugin checks the newly opened file for comments and to look for keywords, there is no styling set yet in the Scintilla object. And since there is no styling set, the plugin finds no comments at all

[Github-comments] Re: [geany/geany-plugins] ProjectOrganizer: Initialise "is_header" variable (PR #1252)

2023-05-23 Thread Enrico Tröger via Github-comments
Yeah, I think too it was safe before. The intention was just to silence cppcheck. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1252#issuecomment-1560087410 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] ProjectOrganizer: Initialise "is_header" variable (PR #1252)

2023-05-22 Thread Enrico Tröger via Github-comments
Older cppcheck versions (e.g. 1.90) complain about this while newer versions (e.g. 2.10) do not. @techee is `FALSE` a proper default here? You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1252 -- Commit Summary -- *

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-05-21 Thread Enrico Tröger via Github-comments
Closed #1239. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#event-9296330950 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-05-21 Thread Enrico Tröger via Github-comments
Done in #1201. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1556234319 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-05-21 Thread Enrico Tröger via Github-comments
Merged #1201 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1201#event-9296327438 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Refs #2615 - Convert create_py_tags.py to Python 3 (#2630)

2023-05-21 Thread Enrico Tröger via Github-comments
Closed #2630. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2630#event-9296320401 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Refs #2615 - Convert create_py_tags.py to Python 3 (#2630)

2023-05-21 Thread Enrico Tröger via Github-comments
Done in #3039 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2630#issuecomment-1556231313 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2023-05-21 Thread Enrico Tröger via Github-comments
Merged #3039 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3039#event-9296319491 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-21 Thread Enrico Tröger via Github-comments
Merged #3488 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3488#event-9296317872 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] TASKS not showing from.txt files geany 1.38 kubuntu 22.04, plasma 5.24.7 (Issue #1251)

2023-05-21 Thread Enrico Tröger via Github-comments
Closed #1251 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1251#event-9296314224 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] TASKS not showing from.txt files geany 1.38 kubuntu 22.04, plasma 5.24.7 (Issue #1251)

2023-05-21 Thread Enrico Tröger via Github-comments
The plugin only considers TODO keywords which are part of a comment. Thus you also need a document with a filetype which supports comments. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1251#issuecomment-1556229940 You are receiving this

[Github-comments] Re: [geany/geany] Why not add a "build and run" button to the toolbar (Issue #3477)

2023-05-21 Thread Enrico Tröger via Github-comments
Oh, sorry. This was a left over from a previous "Build" command result. Unfortunately in this case very misleading, so I recreated the screenshot in the above post. Sorry for the confusion. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Restore startup behavior to focus files from the command line after session files (PR #3267)

2023-05-20 Thread Enrico Tröger via Github-comments
Fine by me to merge. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3267#issuecomment-1555906663 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Why not add a "build and run" button to the toolbar (Issue #3477)

2023-05-20 Thread Enrico Tröger via Github-comments
@elextr is right for a proper implementation and I agree this might be of little use for more than simple single file programs. If needed, you can configure Geany to build your code in the run command. Just tested and works pretty good if you can live to have the compiler output in the

[Github-comments] Re: [geany/geany] Geany 1.33 AutoSave FilesOpenList, using Debian Buster 10 in Oracle VirtualBox inside Windows 10 PC (Issue #3502)

2023-05-15 Thread Enrico Tröger via Github-comments
> 1a) Linux Terminal commands sudo apt update and sudo apt full-upgrade never > update Geany 1.33 to its current version of 1.38. Thus Geany 1.33 remains > apparently the "latest available" version of Geany within a Windows PC > running Oracle Virtual Box Debian Buster 10; and thus a 32-bits OS

[Github-comments] Re: [geany/geany] Geany 1.38 - Opening Large Log Files Appear Empty (Issue #3498)

2023-05-14 Thread Enrico Tröger via Github-comments
Maybe it should. Here, the file is opened without an error if I force "Without encoding". This is probably because the encoding detection code is not used then and so won't fail on NULL bytes. But the file is *not* opened without errors because in Geany, it is loaded until the first NULL byte

[Github-comments] Re: [geany/geany-themes] Fixed markup colors. Final fix. (PR #60)

2023-05-14 Thread Enrico Tröger via Github-comments
Merged #60 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/60#event-9239685299 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Geany 1.38 - Opening Large Log Files Appear Empty (Issue #3498)

2023-05-14 Thread Enrico Tröger via Github-comments
Regarding the file open issue: it's not about encodings in this case but the file contains NULL bytes and Geany does not support that. See also https://github.com/geany/geany/issues/1508 which has even more references to issues like this. To answer the probably upcoming question when it will

[Github-comments] Re: [geany/geany] Remove obsolete helper scripts (PR #3486)

2023-05-12 Thread Enrico Tröger via Github-comments
I removed the others as well. If we need them again, they still can be restored from GIT. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3486#issuecomment-1546324520 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Remove obsolete helper scripts (PR #3486)

2023-05-12 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 6fd7e7eff9ba453c915847757a5d67e4ac02db53 Remove obsolete helper scripts -- View it on GitHub: https://github.com/geany/geany/pull/3486/files/c8718048810da953d2aad32188b9e4e385aa33ce..6fd7e7eff9ba453c915847757a5d67e4ac02db53 You are receiving this because you are

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-12 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > # write tags script_dir = dirname(__file__) tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags') -with open(tags_file_path, 'w') as tags_file: +with open(tags_file_path, 'w', encoding='iso-8859-1') as

[Github-comments] Re: [geany/geany] Port "main.py" template to Python3 (PR #3485)

2023-05-12 Thread Enrico Tröger via Github-comments
Merged #3485 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3485#event-9236621018 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-themes] Fixed mark-up colors in theme evg-ega-dark, reverted a change in mkin… (PR #59)

2023-05-12 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -8,7 +8,7 @@ import os import sys import json -from configparser import ConfigParser +import ConfigParser See #58 where the script is roughly ported to Python3 though there is still way more to do (linting, modernising the code, ...) but it works

[Github-comments] Re: [geany/geany-themes] Fixed mark-up colors in theme evg-ega-dark, reverted a change in mkin… (PR #59)

2023-05-12 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. On index/index.json: Not necessary, master has already an updated index (see #58). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/59#pullrequestreview-1425148898 You are receiving this because you are

[Github-comments] Re: [geany/geany-themes] Fixed mark-up colors in theme evg-ega-dark, reverted a change in mkin… (PR #59)

2023-05-12 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -156,6 +156,67 @@ of the tree. If you don't have GNU make (ex. on Windows), don't worry about doing this step, it's entirely trivial for me to do it. +IMPORTANT NOTE 2023-05-11 by Evgueni Antonov (github: StrayFeral): This file is meant as

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -8,296 +7,368 @@ # # This script should be run in the top source directory. # -# Parses all files given on command line for Python classes or functions and write -# them into data/tags/std.py.tags (internal tagmanager format). +# Parses all files

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > # If called without command line arguments, a preset of common Python libs > is used. # # WARNING -# Be aware that running this script will actually *import* modules in the specified directory +# Be aware that running this script will actually

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 706ee56f0f0b2c09744c380b033b2ff44682a95e Fix doc typos -- View it on GitHub: https://github.com/geany/geany/pull/3039/files/d350dad27a45656cd9c84a0ac9dfb3a0412d6604..706ee56f0f0b2c09744c380b033b2ff44682a95e You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-10 Thread Enrico Tröger via Github-comments
> Is there a reason that Python tags are in ctags format and php tags in > tagmanager? Before #3039, Python tags were also in tagmanager format and so are the PHP tags. As said in https://github.com/geany/geany/pull/3488#issuecomment-1537369732, I would switch the format to ctags for the PHP

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > # write tags script_dir = dirname(__file__) tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags') -with open(tags_file_path, 'w') as tags_file: +with open(tags_file_path, 'w', encoding='iso-8859-1') as

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > (arg_list, TA_ARGLIST), (return_type, TA_VARTYPE), (scope, TA_SCOPE)]: if attr is not None: -tag_line +=

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 721550ca76caa155dc3ea2c7e0edb4710ef6c7e9 Port create_php_tags to Python3 and generate new PHP tags file -- View it on GitHub: https://github.com/geany/geany/pull/3488/files/36ccb38776e6c1439900b39c79b5a20a535c0969..721550ca76caa155dc3ea2c7e0edb4710ef6c7e9 You are

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-05-10 Thread Enrico Tröger via Github-comments
I'm close to give up on this. It's more like that @nrikonomov's comment kills our efforts to find a better solution for most users. Aprt from that, I completely with what @elextr said in https://github.com/geany/geany/issues/3063#issuecomment-1539252949. -- Reply to this email directly or

[Github-comments] [geany/geany-themes] Fix broken theme index (PR #58)

2023-05-10 Thread Enrico Tröger via Github-comments
The first commit roughly ports the `mkindex.py` to work with Python3 and regenerate the broken `index.json` (it got broken in #57 0c0a8c28bcd3479e472f6125f3362c679cfc895b). The broken `index.json` caused an error on the theme index page on the Geany website

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-05-08 Thread Enrico Tröger via Github-comments
> Seriously though, this is the stuff that kills projects. I am already eyeing > out another open source project. What exactly is this referring to? What should kill the project and why? -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Restore startup behavior to focus files from the command line after session files (PR #3267)

2023-05-07 Thread Enrico Tröger via Github-comments
> Haven't looked at this, but it may be affected by #3395. I just tested the latest changes and it seems fine for me now. Had only a minor remark but it is not critical at all. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3267#issuecomment-1537441161

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-05-07 Thread Enrico Tröger via Github-comments
Incorporated the changes from https://github.com/geany/geany/pull/3465 and builds are fine now. I would like to merge this finally in a few days if there are no objections. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Restore startup behavior to focus files from the command line after session files (PR #3267)

2023-05-07 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -4746,8 +4746,12 @@ gboolean editor_goto_pos(GeanyEditor *editor, gint > pos, gboolean mark) sci_goto_pos(editor->sci, pos, TRUE); editor->scroll_percent = 0.25F; - /* finally switch to the page */ -

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-05-07 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. ccce45fba7bcd956edf5e087e8cc34b292fb18f7 CI: Add Windows build -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/a9be6d6ee8c5d59fbd68e1c85e121a756d086347..ccce45fba7bcd956edf5e087e8cc34b292fb18f7 You are receiving this because you are

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-05-07 Thread Enrico Tröger via Github-comments
> We do? I just looked and couldn't find anything? I was referring to the not yet merged addition to the FAQs in https://github.com/geany/www.geany.org/pull/40. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3063#issuecomment-1537432650 You are

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-05-07 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. a9be6d6ee8c5d59fbd68e1c85e121a756d086347 CI: Add Windows build -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/43f1b202b637c81cb5af6a6bf2f1e4728a8fc6c6..a9be6d6ee8c5d59fbd68e1c85e121a756d086347 You are receiving this because you are

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-05-07 Thread Enrico Tröger via Github-comments
Another year later...luckily we got some more feedback even though it doesn't make the decision for a suitable default theme not easier. The new master plan (suggestion): - merge https://github.com/geany/geany-osx/pull/35 to use it in Windows builds - integrate the Prof-Gnome theme from the

[Github-comments] Re: [geany/geany] Python usage in build (#2896)

2023-05-07 Thread Enrico Tröger via Github-comments
@elextr all of the parts mentioned in the OP are already resolved. Can we close this one? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2896#issuecomment-1537374170 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-07 Thread Enrico Tröger via Github-comments
When #3039 is merged, I would adjust the script to generate ctags file format and share the code with the Python tags script. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3488#issuecomment-1537369732 You are receiving this because you are subscribed

[Github-comments] [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-07 Thread Enrico Tröger via Github-comments
Related to #2615. I dont know how good the newly generated tags are, my PHP knowledge is basically non-existent anymore :). At least, the diff looks like some were added, removed and changed, some keep even unchanged. You can view, comment on, or merge this pull request online at:

[Github-comments] [geany/geany] Update NSIS filetype keywords (PR #3487)

2023-05-07 Thread Enrico Tröger via Github-comments
Created by scripts/update-nsis-functions.sh. Changed keywords: ```diff Changed functions: +!assert +!uninstfinalize +getknownfolderpath +getregview +getshellvarcontext +getwinver +ifaltregview +ifrtllanguage +ifshellvarcontextall +manifestappendcustomstring +manifestlongpathaware +readmemory

[Github-comments] [geany/geany] Remove obsolete helper scripts (PR #3486)

2023-05-07 Thread Enrico Tröger via Github-comments
`scripts/changelist.pl`: process ChangeLog which we do not use anymore `scripts/cross-build-mingw.sh`: old cross build script, replaced by #3315 `scripts/rstrip-whitespace.py`: probably unused (as assumed in #2615) There are more candidates: `scripts/fix-alignment.pl`

[Github-comments] [geany/geany] Port "main.py" template to Python3 (PR #3485)

2023-05-07 Thread Enrico Tröger via Github-comments
Related to #2615. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3485 -- Commit Summary -- * Port main.py template to Python3 -- File Changes -- M data/templates/files/main.py (10) -- Patch Links --

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2023-05-07 Thread Enrico Tröger via Github-comments
I just cleaned the commit history and would like to merge this in a few days if there are no objections. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3039#issuecomment-1537346113 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)

2023-05-06 Thread Enrico Tröger via Github-comments
One thing to note: with the new workflow based on the `msys2/setup-msys2` action, we now depend on a proprietary Windows runner in the CI. I didn't make up my mind about this yet. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)

2023-05-06 Thread Enrico Tröger via Github-comments
I guess we are waiting for @kugel- to review. Maybe @eli-schwartz could have a look, for me this would suffice. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3466#issuecomment-1537152304 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Fix Mingw CI build (PR #3465)

2023-05-06 Thread Enrico Tröger via Github-comments
Merged #3465 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3465#event-9182702234 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Mingw-w64 CI fails (Issue #3461)

2023-05-06 Thread Enrico Tröger via Github-comments
Closed #3461 as completed via #3465. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3461#event-9182702272 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Make Python comment-out mark be `#` without space (Issue #3462)

2023-04-29 Thread Enrico Tröger via Github-comments
I thought about this a couple of days and still don't have a strong opinion on it. I think I've seen both variants (without and with space) on colleagues' screens who are using various other IDEs. In the end, it's just a matter of taste and whatever default we choose, it might not match the

[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)

2023-04-23 Thread Enrico Tröger via Github-comments
> I have added a basic mingw64 meson workflow. The CI needs permission to allow > that. Permission granted. Could you rebase on current master, https://github.com/geany/geany/pull/3438 has only just been merged to allow manual start of the workflow :). Thanks for the new workflow, this might

[Github-comments] Re: [geany/geany] Allow Dispatching CI Build Workflow Manually (PR #3438)

2023-04-23 Thread Enrico Tröger via Github-comments
Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3438#issuecomment-1519042573 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Allow Dispatching CI Build Workflow Manually (PR #3438)

2023-04-23 Thread Enrico Tröger via Github-comments
Merged #3438 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3438#event-9074747806 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)

2023-04-22 Thread Enrico Tröger via Github-comments
After a quick shot, the changes look well to me. Tested on native Windows and built fine. > If required, I can try to add the mingw meson build in CI and replace > autotools with meson also. Not sure if the Meson is already ready to be used for CI. Ideally, the CI builds generate full

[Github-comments] Re: [geany/geany] Fix Mingw CI build (PR #3465)

2023-04-20 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -70,19 +70,12 @@ CFLAGS="\ ARCH="x86_64" MINGW_ARCH="mingw64" HOST="x86_64-w64-mingw32" -export CC="/usr/bin/${HOST}-gcc" -export CPP="/usr/bin/${HOST}-cpp" -export CXX="/usr/bin/${HOST}-g++" -export AR="/usr/bin/${HOST}-ar" -export

[Github-comments] Re: [geany/geany] Fix Mingw CI build (PR #3465)

2023-04-20 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -153,7 +153,7 @@ geany_private.res: $(top_srcdir)/geany_private.rc libgeany_la_SOURCES += win32.c win32.h libgeany_la_LIBADD += -lole32 -lwsock32 -lcomdlg32 -libgeany_la_LDFLAGS += -Wl,-luuid -mwindows -mms-bitfields -no-undefined `-luuid` is

[Github-comments] Re: [geany/geany] Fix Mingw CI build (PR #3465)

2023-04-20 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -119,7 +119,6 @@ AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE], ["$PACKAGE"], > [Gettext package.]) AM_COND_IF([MINGW], [pkgdatadir='${prefix}/data'], [pkgdatadir='${datarootdir}/geany']) -AM_COND_IF([MINGW],[LIBS="$LIBS -liconv"]) This came in

[Github-comments] Re: [geany/geany] Fix Mingw CI build (PR #3465)

2023-04-20 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > export NOCONFIGURE=1 export JOBS=${JOBS:-1} +export lt_cv_deplibs_check_method='pass_all' As suggested in https://github.com/geany/geany/issues/3461. This fixes linker errors on `libuuid` with the recent Mingw GTK3 package. -- Reply to this email

[Github-comments] Re: [geany/geany] Fix Mingw CI build (PR #3465)

2023-04-20 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. e465a2b456e7c0aba6aefc1c4b406b8089386d1a Remove unnecessary compiler and linker flags for Mingw builds -- View it on GitHub: https://github.com/geany/geany/pull/3465/files/9a8dd9aea503735ea56040efd66fd5f80b608ff6..e465a2b456e7c0aba6aefc1c4b406b8089386d1a You are

[Github-comments] [geany/geany] Fix Mingw CI build (PR #3465)

2023-04-20 Thread Enrico Tröger via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3465 -- Commit Summary -- * Define lt_cv_deplibs_check_method to fix Mingw linker errors -- File Changes -- M scripts/ci_mingw64_geany.sh (1) -- Patch Links --

[Github-comments] Re: [geany/geany] Mingw-w64 CI fails (Issue #3461)

2023-04-17 Thread Enrico Tröger via Github-comments
See https://github.com/msys2/MINGW-packages/issues/16836 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3461#issuecomment-1512130925 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] [filetypes] Update Kotlin basic types (PR #3456)

2023-04-16 Thread Enrico Tröger via Github-comments
Merged #3456 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3456#event-9018351496 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Mingw-w64 CI fails (Issue #3461)

2023-04-16 Thread Enrico Tröger via Github-comments
Not yet. I debugged it a bit and noticed that some change in MSYS2 in the last few weeks causes that no shared libraries (in this case .dlls) are built anymore. Still the `make` succeeds without error. I'm not sure what's going on. https://github.com/geany/geany/pull/3432 was also my first

[Github-comments] Re: [geany/geany] CI: Define JOBS environment variable and use it for make (PR #3432)

2023-04-16 Thread Enrico Tröger via Github-comments
Merged #3432 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3432#event-9017623265 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/infrastructure] CI: Add workflow to cleanup old untagged CI container image versions (PR #9)

2023-04-16 Thread Enrico Tröger via Github-comments
Merged #9 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/infrastructure/pull/9#event-9017535396 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] MSYS2/MinGW-w64: Missing Header 'alloca.h' (Issue #3437)

2023-04-16 Thread Enrico Tröger via Github-comments
That you are using Meson is an important bit of information. I can reproduce the error when using Meson on Windows/MSYS2. And this is because our Meson setup does *not* `WIN32`. The following patch defines it and the build succeeds: ```diff diff --git a/meson.build b/meson.build index

[Github-comments] Re: [geany/geany] Fold code to certain level only (Issue #3041)

2023-04-16 Thread Enrico Tröger via Github-comments
Not exactly what requested but you can collapse a top-level fold point and expand only the next level when holding the Shift key while expanding a fold point (details at https://www.geany.org/manual/#folding). At least, this makes it easy to expand the first and second level on one fold point

[Github-comments] Re: [geany/geany] [filetypes] Update Kotlin basic types (PR #3456)

2023-04-16 Thread Enrico Tröger via Github-comments
@dolik-rce fine by you? If so, let's merge. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3456#issuecomment-1510377010 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update lexilla to 5.2.4 (PR #3441)

2023-04-16 Thread Enrico Tröger via Github-comments
I wonder if it is OK to just update Lexilla and not Scintilla as well? But probably better than nothing and we can update Scintilla afterwards anyway. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3441#issuecomment-1510374543 You are receiving this

[Github-comments] Re: [geany/geany] Filetype files documenting lexer property settings (Issue #3442)

2023-04-16 Thread Enrico Tröger via Github-comments
Agreed. And obviously I worked on this already before, as mentioned in #3441. What if we use the code to generate an up2date list in https://github.com/geany/geany/issues/2517 and then copy the generated property definitions into the according filetypes files? -- Reply to this email directly

[Github-comments] Re: [geany/www.geany.org] Add AppImage to Third Party packages (PR #42)

2023-04-16 Thread Enrico Tröger via Github-comments
Merged #42 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/42#event-9017302572 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/www.geany.org] Replace flake8 by ruff (PR #47)

2023-04-16 Thread Enrico Tröger via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/www.geany.org/pull/47 -- Commit Summary -- * Replace Flake8 and Isort by Ruff for linting * Move PyLint config to pyproject.toml * Add Python 3.11 for linting jobs, remove Python 3.7 and 3.8 --

[Github-comments] Re: [geany/geany-plugins] Plugin Request: source control gutter indicators (Issue #1244)

2023-03-27 Thread Enrico Tröger via Github-comments
Or just use the existing plugin https://github.com/geany/geany-plugins/tree/master/git-changebar :). This does exactly what you request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1244#issuecomment-1485564709 You are receiving this

[Github-comments] Re: [geany/geany] MSYS2/MinGW-w64: Missing Header 'alloca.h' (Issue #3437)

2023-03-23 Thread Enrico Tröger via Github-comments
My local MSYS2 setup on a native Windows system does *not* have `alloca.h` nor does the CI build image has it (https://github.com/geany/infrastructure/pkgs/container/geany-mingw64-ci) and both cleanly build Geany. How do you start your build? Is the `gcc` command you posted above the same

[Github-comments] [geany/infrastructure] CI: Add workflow to cleanup old untagged CI container image versions (PR #9)

2023-03-19 Thread Enrico Tröger via Github-comments
The weekly rebuild of the CI container image for the Mingw64 builds works fine. But the previous image versions are kept as untagged images in the container registry. This workflow should remove all untagged image versions except that last five ones. It is schedules weekly two hours after the

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-03-19 Thread Enrico Tröger via Github-comments
@eht16 pushed 4 commits. db7b0d8a03e644977b9187489f23c03c760fd53f CI: Add Windows build ad222a5667f6607213e6ada7c0d58832a57bada2 debug... 58baa1d0e89e1aadec067c857622adc3463983fb CI: Use "JOBS" environment variable for make if set 43f1b202b637c81cb5af6a6bf2f1e4728a8fc6c6 CI: Fix copied Geany

[Github-comments] [geany/geany] CI: Define JOBS environment variable and use it for make (PR #3432)

2023-03-19 Thread Enrico Tröger via Github-comments
I just noticed in the CI workflow for the traditional Autotools based jobs, we did not specify -j for parallel job execution for the main make call to build all the sources. We did however for make check and make distcheck. If there is no reason for not using -j 2, this PR adds it and

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-03-16 Thread Enrico Tröger via Github-comments
@eht16 pushed 3 commits. fdbb29d4f8623e3adff69e6668eaab11b04484f3 CI: Add Windows build e0da9a3df7477cb5c878656ee54396ded8604e5f Windows: Update dependency removal cleanup on uninstall 76b11fbbbd7f5ae3f08c325d573e22c6cedbcf75 debug... -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Remove unusable plugins: DevHelp, GeanyPy, Multiterm (PR #1217)

2023-03-16 Thread Enrico Tröger via Github-comments
Merged #1217 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1217#event-8772067041 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-03-12 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 97c38e6bd818c486f922e564626a3765ca723358 debug... -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/682bac9d94de36ca08913bb7ae70360162da6ea4..97c38e6bd818c486f922e564626a3765ca723358 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-03-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 682bac9d94de36ca08913bb7ae70360162da6ea4 Windows: Update dependency removal cleanup on uninstall -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/306f84c4f882e873f1aa68681cc41a3edb9416f0..682bac9d94de36ca08913bb7ae70360162da6ea4 You are

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-03-09 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 306f84c4f882e873f1aa68681cc41a3edb9416f0 CI: Add Windows build -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/0d36c1d2d37cb909bdf118e538cbdfa28fe5f2cb..306f84c4f882e873f1aa68681cc41a3edb9416f0 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-03-09 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 2c7bc518b1866be55d6cf9cd489d6e7f97d93379 Merge branch 'master' into ci_add_windows_build -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/655eeaca7daae67a912c7093fc7fcd28b847c883..2c7bc518b1866be55d6cf9cd489d6e7f97d93379 You are receiving

[Github-comments] Re: [geany/geany-plugins] Remove unusable plugins: DevHelp, GeanyPy, Multiterm (PR #1217)

2023-03-07 Thread Enrico Tröger via Github-comments
@b4n Alright, Webhelper is back in the game. I would like to restart the "merge in about a week counter" to get this done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1217#issuecomment-1459624766 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Remove unusable plugins: DevHelp, GeanyPy, Multiterm (PR #1217)

2023-03-07 Thread Enrico Tröger via Github-comments
@eht16 pushed 2 commits. a7c921ddfa31a0a6847d02b2bacf3698429baaa0 Remove unusable plugins: DevHelp, GeanyPy, Multiterm 819efce62614a8a16f8d27a49e057b95cce2aa4c Re-add WebHelper plugin -- View it on GitHub:

<    1   2   3   4   5   6   7   8   9   10   >