[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-18 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011560#comment-15011560 ] Devaraj Das commented on HBASE-14575: - Hmm.. On the unit test, I am not sure it's goi

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011418#comment-15011418 ] Ted Yu commented on HBASE-14575: bq. with description of logging regime You meant 'locki

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011412#comment-15011412 ] stack commented on HBASE-14575: --- bq. Browsed some region server log but didn't find excepti

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011398#comment-15011398 ] Ted Yu commented on HBASE-14575: Browsed some region server log but didn't find exception

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011388#comment-15011388 ] stack commented on HBASE-14575: --- bq. The explanation is pretty long. How about putting the

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011377#comment-15011377 ] Ted Yu commented on HBASE-14575: The description from 04/Nov/15 09:00 is mostly accurate:

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010625#comment-15010625 ] Hadoop QA commented on HBASE-14575: --- {color:green}+1 overall{color}. Here are the resu

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010379#comment-15010379 ] stack commented on HBASE-14575: --- Can we have more test runs please given weird hanging MR t

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-17 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010325#comment-15010325 ] ramkrishna.s.vasudevan commented on HBASE-14575: bq.However, before compa

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-17 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009708#comment-15009708 ] Jerry He commented on HBASE-14575: -- The v6 patch is clean and bold. Based on the discuss

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007979#comment-15007979 ] Ted Yu commented on HBASE-14575: Patch v6 QA run was clean. The test failure above is to

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-16 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007935#comment-15007935 ] Enis Soztutar commented on HBASE-14575: --- So it the test failure related? Agreed t

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007915#comment-15007915 ] Ted Yu commented on HBASE-14575: >From >https://builds.apache.org/job/PreCommit-HBASE-Bu

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007879#comment-15007879 ] Hadoop QA commented on HBASE-14575: --- {color:green}+1 overall{color}. Here are the resu

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007722#comment-15007722 ] Ted Yu commented on HBASE-14575: Ran ITBLL and IntegrationTestBulkLoad with patch v6 on 6

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007713#comment-15007713 ] Hadoop QA commented on HBASE-14575: --- {color:green}+1 overall{color}. Here are the resu

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007457#comment-15007457 ] Ted Yu commented on HBASE-14575: Fetching https://builds.apache.org/job/PreCommit-HBASE-B

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007323#comment-15007323 ] Hadoop QA commented on HBASE-14575: --- {color:green}+1 overall{color}. Here are the resu

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-13 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003903#comment-15003903 ] ramkrishna.s.vasudevan commented on HBASE-14575: Then it is good. So I do

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003838#comment-15003838 ] Ted Yu commented on HBASE-14575: In HRegion#doClose(): {code} writestate.writesEnab

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-13 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003717#comment-15003717 ] Devaraj Das commented on HBASE-14575: - I am fine with that [~ram_krish] > Reduce sco

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-13 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003711#comment-15003711 ] ramkrishna.s.vasudevan commented on HBASE-14575: Am fine with this patch.

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-13 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003706#comment-15003706 ] Devaraj Das commented on HBASE-14575: - [~jinghe] yeah from my read of things, seems y

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-11 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001204#comment-15001204 ] Jerry He commented on HBASE-14575: -- bulk load and compaction don't conflict with against

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-11 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000966#comment-15000966 ] Devaraj Das commented on HBASE-14575: - Don't we need region level write lock to make

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000902#comment-15000902 ] Ted Yu commented on HBASE-14575: For #4. swap in compacted files, HStore#compact() calls

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-09 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997892#comment-14997892 ] Enis Soztutar commented on HBASE-14575: --- That test scale is pretty small BTW. > R

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997812#comment-14997812 ] Ted Yu commented on HBASE-14575: Thanks for the review, Ram. Let me think about your sugg

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-09 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996404#comment-14996404 ] ramkrishna.s.vasudevan commented on HBASE-14575: Going thro the code and

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989905#comment-14989905 ] Ted Yu commented on HBASE-14575: We are trying to remove / relax the region read lock for

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987797#comment-14987797 ] Hadoop QA commented on HBASE-14575: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987615#comment-14987615 ] Ted Yu commented on HBASE-14575: Yes, I did see the above comment. Preparation of such p

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-03 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987609#comment-14987609 ] stack commented on HBASE-14575: --- You saw my comments [~ted_yu] I repeat main thrust below:

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986635#comment-14986635 ] Ted Yu commented on HBASE-14575: In HRegion#doClose(), we have : {code} synchronized

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-02 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986622#comment-14986622 ] Jerry He commented on HBASE-14575: -- There is a complex logic with the writestate in HReg

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-02 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985149#comment-14985149 ] ramkrishna.s.vasudevan commented on HBASE-14575: bq.readLock.lock(); // h

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-01 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984784#comment-14984784 ] Jerry He commented on HBASE-14575: -- As [~ndimiduk] mentioned, we've been doing a lot of

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-11-01 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984739#comment-14984739 ] ramkrishna.s.vasudevan commented on HBASE-14575: Thanks Ted. My bad. I mi

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-31 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984073#comment-14984073 ] stack commented on HBASE-14575: --- The original author says of the approach "... I'm not sur

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983963#comment-14983963 ] Ted Yu commented on HBASE-14575: bq. this patch should remove the read lock in the HRegio

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-31 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983878#comment-14983878 ] ramkrishna.s.vasudevan commented on HBASE-14575: Just trying to understan

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983719#comment-14983719 ] Hadoop QA commented on HBASE-14575: --- {color:green}+1 overall{color}. Here are the resu

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983449#comment-14983449 ] Ted Yu commented on HBASE-14575: {code} [ERROR] Failed to execute goal org.apache.maven.

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983436#comment-14983436 ] Hadoop QA commented on HBASE-14575: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983101#comment-14983101 ] Ted Yu commented on HBASE-14575: Without the lock scope reduction, the test fails with: {

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975728#comment-14975728 ] Hadoop QA commented on HBASE-14575: --- {color:green}+1 overall{color}. Here are the resu

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958193#comment-14958193 ] Hadoop QA commented on HBASE-14575: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957974#comment-14957974 ] Ted Yu commented on HBASE-14575: Looks like Nick is busy. Patch v1 fixes a few mockito e

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-14 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957943#comment-14957943 ] Devaraj Das commented on HBASE-14575: - [~yuzhih...@gmail.com] what's the patch about?

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-13 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955946#comment-14955946 ] Devaraj Das commented on HBASE-14575: - [~ndimiduk] wondering if you have any update o

[jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock

2015-10-08 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949112#comment-14949112 ] Devaraj Das commented on HBASE-14575: - [~ndimiduk] the change looks easy to reason ab