[GitHub] [kafka] showuon commented on pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

2023-08-04 Thread via GitHub
showuon commented on PR #14116: URL: https://github.com/apache/kafka/pull/14116#issuecomment-1666411942 Please let me know when ready for review. Thanks for the work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] kamalcph commented on pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-04 Thread via GitHub
kamalcph commented on PR #14151: URL: https://github.com/apache/kafka/pull/14151#issuecomment-1666405256 Not clear on this patch, will go another round of review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] kamalcph commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-04 Thread via GitHub
kamalcph commented on code in PR #14151: URL: https://github.com/apache/kafka/pull/14151#discussion_r1284973824 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig {

[jira] [Commented] (KAFKA-12890) Consumer group stuck in `CompletingRebalance`

2023-08-04 Thread Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751269#comment-17751269 ] Yang commented on KAFKA-12890: -- Hi [~dajac]   I know this issue and PR have been closed for

[jira] [Updated] (KAFKA-15309) Add custom error handler to Producer

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15309: Description: The producer collects multiple records into batches, and a single record spe

[jira] [Updated] (KAFKA-15309) Add custom error handler to Producer

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15309: Description: The producer collects multiple records into batches, and a single record spe

[jira] [Updated] (KAFKA-15309) Add custom error handler to Producer

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15309: Description: The producer collects multiple records into batches, and a single record spe

[jira] [Updated] (KAFKA-15309) Add custom error handler to Producer

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15309: Description: The producer batches up multiple records into batches, and a single record s

[jira] [Commented] (KAFKA-15259) Kafka Streams does not continue processing due to rollback despite ProductionExceptionHandlerResponse.CONTINUE if using execute_once

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751267#comment-17751267 ] Matthias J. Sax commented on KAFKA-15259: - I did sync up with [~cegerton] who wo

[jira] [Created] (KAFKA-15309) Add custom error handler to Producer

2023-08-04 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-15309: --- Summary: Add custom error handler to Producer Key: KAFKA-15309 URL: https://issues.apache.org/jira/browse/KAFKA-15309 Project: Kafka Issue Type: New Fe

[GitHub] [kafka] showuon merged pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-04 Thread via GitHub
showuon merged PR #14133: URL: https://github.com/apache/kafka/pull/14133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

2023-08-04 Thread via GitHub
showuon commented on PR #14133: URL: https://github.com/apache/kafka/pull/14133#issuecomment-1666390423 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindR

[GitHub] [kafka] showuon commented on pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-04 Thread via GitHub
showuon commented on PR #14151: URL: https://github.com/apache/kafka/pull/14151#issuecomment-1666390279 > Yeah, okay, this pull request makes sense to me. To summarise, you are saying that configurations starting with `remote.log.metadata` need to be passed to implementations of the RemoteL

[jira] [Commented] (KAFKA-15259) Kafka Streams does not continue processing due to rollback despite ProductionExceptionHandlerResponse.CONTINUE if using execute_once

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751263#comment-17751263 ] Matthias J. Sax commented on KAFKA-15259: - Thanks for digging into it – that's a

[GitHub] [kafka] mjsax merged pull request #14105: MINOR: improve logging for FK-join

2023-08-04 Thread via GitHub
mjsax merged PR #14105: URL: https://github.com/apache/kafka/pull/14105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Assigned] (KAFKA-15202) MM2 OffsetSyncStore clears too many syncs when sync spacing is variable

2023-08-04 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-15202: --- Assignee: Greg Harris > MM2 OffsetSyncStore clears too many syncs when sync spacing is vari

[GitHub] [kafka] gharris1727 opened a new pull request, #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-04 Thread via GitHub
gharris1727 opened a new pull request, #14156: URL: https://github.com/apache/kafka/pull/14156 The new OffsetSyncStore historical translation cache clears more syncs than necessary when the gap between syncs is variable. This is a problem with the replacement promotion logic, which only cov

[jira] [Updated] (KAFKA-15308) Wipe Stores upon OffsetOutOfRangeException in ALOS

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15308: Affects Version/s: (was: 3.4.0) (was: 3.5.0) > Wipe Stores

[jira] [Created] (KAFKA-15308) Wipe Stores upon OffsetOutOfRangeException in ALOS

2023-08-04 Thread Colt McNealy (Jira)
Colt McNealy created KAFKA-15308: Summary: Wipe Stores upon OffsetOutOfRangeException in ALOS Key: KAFKA-15308 URL: https://issues.apache.org/jira/browse/KAFKA-15308 Project: Kafka Issue Type

[jira] [Created] (KAFKA-15307) Kafka Streams configuration docs outdate

2023-08-04 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-15307: --- Summary: Kafka Streams configuration docs outdate Key: KAFKA-15307 URL: https://issues.apache.org/jira/browse/KAFKA-15307 Project: Kafka Issue Type: Ta

[GitHub] [kafka] mehbey commented on pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-04 Thread via GitHub
mehbey commented on PR #14135: URL: https://github.com/apache/kafka/pull/14135#issuecomment-1666331731 Updated PR to address comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-04 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1284932829 ## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ## @@ -642,7 +642,7 @@ class DynamicBrokerReconfigurationTest extends QuorumTest

[GitHub] [kafka] mjsax commented on a diff in pull request #14150: KAFKA-15022: [6/N] add rack aware assignor configs and update standby optimizer

2023-08-04 Thread via GitHub
mjsax commented on code in PR #14150: URL: https://github.com/apache/kafka/pull/14150#discussion_r1284932353 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -890,6 +914,22 @@ public class StreamsConfig extends AbstractConfig { in(

[GitHub] [kafka] mjsax commented on pull request #14155: MINOR: update Kafka Streams state.dir doc

2023-08-04 Thread via GitHub
mjsax commented on PR #14155: URL: https://github.com/apache/kafka/pull/14155#issuecomment-1666311777 `kafka-site.git` PR: https://github.com/apache/kafka-site/pull/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Commented] (KAFKA-15267) Cluster-wide disablement of Tiered Storage

2023-08-04 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751241#comment-17751241 ] Satish Duggana commented on KAFKA-15267: Option 4.1 is the option suggested in

[GitHub] [kafka] lihaosky commented on a diff in pull request #14139: KAFKA-15022: [7/N] use RackAwareTaskAssignor in HAAssignor

2023-08-04 Thread via GitHub
lihaosky commented on code in PR #14139: URL: https://github.com/apache/kafka/pull/14139#discussion_r1284914061 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StickyTaskAssignor.java: ## @@ -57,6 +57,7 @@ public StickyTaskAssignor() { publi

[GitHub] [kafka] lihaosky commented on a diff in pull request #14150: KAFKA-15022: [6/N] add rack aware assignor configs and update standby optimizer

2023-08-04 Thread via GitHub
lihaosky commented on code in PR #14150: URL: https://github.com/apache/kafka/pull/14150#discussion_r1284910264 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -267,25 +267,46 @@ public static class AssignmentCon

[jira] [Commented] (KAFKA-15302) Stale value returned when using store.all() in punctuation function.

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751236#comment-17751236 ] Matthias J. Sax commented on KAFKA-15302: - Thanks for reporting this issue. – Wh

[GitHub] [kafka] lihaosky commented on a diff in pull request #14139: KAFKA-15022: [7/N] use RackAwareTaskAssignor in HAAssignor

2023-08-04 Thread via GitHub
lihaosky commented on code in PR #14139: URL: https://github.com/apache/kafka/pull/14139#discussion_r1284910181 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java: ## @@ -43,21 +43,27 @@ public class HighAvailabi

[GitHub] [kafka] AndrewJSchofield commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

2023-08-04 Thread via GitHub
AndrewJSchofield commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1284873983 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -701,7 +713,9 @@ private long partitionReady(Cluster cluster

[GitHub] [kafka] mjsax commented on a diff in pull request #14139: KAFKA-15022: [7/N] use RackAwareTaskAssignor in HAAssignor

2023-08-04 Thread via GitHub
mjsax commented on code in PR #14139: URL: https://github.com/apache/kafka/pull/14139#discussion_r1284866806 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java: ## @@ -43,21 +43,27 @@ public class HighAvailabilit

[GitHub] [kafka] mjsax commented on a diff in pull request #14150: KAFKA-15022: [6/N] add rack aware assignor configs and update standby optimizer

2023-08-04 Thread via GitHub
mjsax commented on code in PR #14150: URL: https://github.com/apache/kafka/pull/14150#discussion_r1284793025 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -755,6 +756,29 @@ public class StreamsConfig extends AbstractConfig { public static final

[jira] [Updated] (KAFKA-15306) Integrate committed offsets logic when updating fetching positions

2023-08-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15306: --- Description: Integrate refreshCommittedOffsets logic, currently performed by the coordinator

[jira] [Created] (KAFKA-15306) Integrate committed offsets logic when updating fetching positions

2023-08-04 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-15306: -- Summary: Integrate committed offsets logic when updating fetching positions Key: KAFKA-15306 URL: https://issues.apache.org/jira/browse/KAFKA-15306 Project: Kafka

[GitHub] [kafka] ableegoldman commented on pull request #14149: HOTFIX: avoid placement of unnecessary transient standby tasks

2023-08-04 Thread via GitHub
ableegoldman commented on PR #14149: URL: https://github.com/apache/kafka/pull/14149#issuecomment-1666170754 Test failures are unrelated Super small fix, would like to get it into 3.6 though ping also @vvcephei @showuon @wcarlson5 for a review -- This is an automated message

[jira] [Commented] (KAFKA-15090) Source tasks are no longer stopped on a separate thread

2023-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751214#comment-17751214 ] Chris Egerton commented on KAFKA-15090: --- This is a tricky one. First off, although

[jira] [Commented] (KAFKA-15303) Foreign key joins no longer triggered by events on the right side of the join after deployment with a new compatible Avro schema

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751212#comment-17751212 ] Matthias J. Sax commented on KAFKA-15303: - Thanks for filing this ticket. Kafka

[jira] [Updated] (KAFKA-15303) Foreign key joins no longer triggered by events on the right side of the join after deployment with a new compatible Avro schema

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15303: Issue Type: Improvement (was: Bug) > Foreign key joins no longer triggered by events on t

[jira] [Updated] (KAFKA-15303) Foreign key joins no longer triggered by events on the right side of the join after deployment with a new compatible Avro schema

2023-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15303: Priority: Major (was: Critical) > Foreign key joins no longer triggered by events on the

[GitHub] [kafka] gharris1727 commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-04 Thread via GitHub
gharris1727 commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1666104751 @fvaleri That does appear to work, because [server-common is not being excluded from tools-dependant-libs](https://github.com/apache/kafka/blob/b3db905b27ff4133f4018ac922c9ce2beb2d608

[jira] [Updated] (KAFKA-15090) Source tasks are no longer stopped on a separate thread

2023-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15090: -- Description: Before [https://github.com/apache/kafka/pull/9669], in distributed mode, the {{S

[jira] [Created] (KAFKA-15305) The background thread should try to process the remaining task until the shutdown timer is expired

2023-08-04 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15305: -- Summary: The background thread should try to process the remaining task until the shutdown timer is expired Key: KAFKA-15305 URL: https://issues.apache.org/jira/browse/KAFKA-15305

[jira] [Updated] (KAFKA-15020) integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor test is flaky

2023-08-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15020: -- Component/s: unit tests > integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRange

[jira] [Updated] (KAFKA-15101) Improve testRackAwareRangeAssignor test

2023-08-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15101: -- Labels: flaky-test (was: ) > Improve testRackAwareRangeAssignor test > --

[jira] [Updated] (KAFKA-15101) Improve testRackAwareRangeAssignor test

2023-08-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15101: -- Component/s: unit tests > Improve testRackAwareRangeAssignor test > --

[jira] [Commented] (KAFKA-15101) Improve testRackAwareRangeAssignor test

2023-08-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751187#comment-17751187 ] Kirk True commented on KAFKA-15101: --- Looks like a duplicate of KAFKA-15020. > Improve

[jira] [Created] (KAFKA-15304) CompletableApplicationEvents aren't being completed when the consumer is closing

2023-08-04 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15304: -- Summary: CompletableApplicationEvents aren't being completed when the consumer is closing Key: KAFKA-15304 URL: https://issues.apache.org/jira/browse/KAFKA-15304 Project:

[GitHub] [kafka] ruslankrivoshein commented on pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-08-04 Thread via GitHub
ruslankrivoshein commented on PR #13562: URL: https://github.com/apache/kafka/pull/13562#issuecomment-1665982738 @fvaleri I summon thee. Please, take one more look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] lianetm commented on a diff in pull request #14123: MINOR: Fix committed API in the PrototypeAsyncConsumer timeout

2023-08-04 Thread via GitHub
lianetm commented on code in PR #14123: URL: https://github.com/apache/kafka/pull/14123#discussion_r1284689796 ## core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala: ## @@ -35,8 +39,12 @@ class BaseAsyncConsumerTest extends AbstractConsumerTest { consumer

[jira] [Updated] (KAFKA-14682) Unused stubbings are not reported by Mockito during CI builds

2023-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14682: -- Description: We've started using [strict stubbing|https://javadoc.io/static/org.mockito/mocki

[jira] [Commented] (KAFKA-14682) Unused stubbings are not reported by Mockito during CI builds

2023-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751178#comment-17751178 ] Chris Egerton commented on KAFKA-14682: --- I've taken a stab at an upstream Mockito

[jira] [Assigned] (KAFKA-14682) Unused stubbings are not reported by Mockito during CI builds

2023-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14682: - Assignee: Chris Egerton (was: Christo Lolov) > Unused stubbings are not reported by Mo

[jira] [Commented] (KAFKA-15298) Disable DeleteRecords on Tiered Storage topics

2023-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751172#comment-17751172 ] Christo Lolov commented on KAFKA-15298: --- Heya [~ckamal]! Thanks for pointing me to

[GitHub] [kafka] philipnee opened a new pull request, #14154: [TEST] Testing build failures for the commit

2023-08-04 Thread via GitHub
philipnee opened a new pull request, #14154: URL: https://github.com/apache/kafka/pull/14154 There's a lot of random build failure, and we aren't sure why. Starting a fresh build to see if these build failures persist. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [kafka] bachmanity1 commented on pull request #14153: KAFKA-7438: Replace Easymock & Powermock with Mockito in KafkaBasedLogTest

2023-08-04 Thread via GitHub
bachmanity1 commented on PR #14153: URL: https://github.com/apache/kafka/pull/14153#issuecomment-1665858277 @C0urante @mjsax @cadonna could you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] bachmanity1 opened a new pull request, #14153: KAFKA-7438: Replace Easymock & Powermock with Mockito in KafkaBasedLogTest

2023-08-04 Thread via GitHub
bachmanity1 opened a new pull request, #14153: URL: https://github.com/apache/kafka/pull/14153 Replaced Easymock & Powermock with Mockito in KafkaBasedLogTest. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverag

[jira] [Comment Edited] (KAFKA-15239) producerPerformance system test for old client failed after v3.5.0

2023-08-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746622#comment-17746622 ] Federico Valeri edited comment on KAFKA-15239 at 8/4/23 3:58 PM: -

[GitHub] [kafka] fvaleri commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-04 Thread via GitHub
fvaleri commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1665804677 @gharris1727 I tried various things, as I'm also learning how this works. The best solution I found is to move the ThroughputThrottler class from clients to server-common, adding t

[GitHub] [kafka] philipnee commented on pull request #14118: KAFKA-14875: Implement wakeup

2023-08-04 Thread via GitHub
philipnee commented on PR #14118: URL: https://github.com/apache/kafka/pull/14118#issuecomment-1665733961 I've been seeing stream test failures in the recent commits too! This PR needs to be rebased against this PR: https://github.com/apache/kafka/pull/14123 to resolve some of the fai

[jira] [Updated] (KAFKA-14682) Unused stubbings are not reported by Mockito during CI builds

2023-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14682: -- Description: We've started using [strict stubbing|https://javadoc.io/static/org.mockito/mocki

[jira] [Commented] (KAFKA-14682) Unused stubbings are not reported by Mockito during CI builds

2023-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751125#comment-17751125 ] Chris Egerton commented on KAFKA-14682: --- [~christo_lolov] were you still planning

[GitHub] [kafka] satishd merged pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-04 Thread via GitHub
satishd merged PR #13984: URL: https://github.com/apache/kafka/pull/13984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-04 Thread via GitHub
satishd commented on PR #13984: URL: https://github.com/apache/kafka/pull/13984#issuecomment-1665559532 Right, there are a few unrelated test failures, merging it to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Updated] (KAFKA-15303) Foreign key joins no longer triggered by events on the right side of the join after deployment with a new compatible Avro schema

2023-08-04 Thread Charles-Eddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles-Eddy updated KAFKA-15303: - Attachment: image (1).png > Foreign key joins no longer triggered by events on the right side of

[jira] [Commented] (KAFKA-15267) Cluster-wide disablement of Tiered Storage

2023-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751099#comment-17751099 ] Christo Lolov commented on KAFKA-15267: --- Okay, I will send out an email later toda

[GitHub] [kafka] ivanyu commented on pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-04 Thread via GitHub
ivanyu commented on PR #13984: URL: https://github.com/apache/kafka/pull/13984#issuecomment-1665493163 Thank you @satishd Seems the failures aren't related -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Commented] (KAFKA-15267) Cluster-wide disablement of Tiered Storage

2023-08-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751095#comment-17751095 ] Luke Chen commented on KAFKA-15267: --- (1) and (3) are good to me. The only concern is w

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-04 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1284280124 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -667,11 +675,323 @@ public void run() { } } +public void handleLogSt

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-04 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1284278935 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -2207,7 +2267,7 @@ case class RetentionSizeBreach(log: UnifiedLog) extends SegmentDeletionReason { var si

[jira] [Commented] (KAFKA-15195) Regenerate segment-aligned producer snapshots when upgrading to a Kafka version supporting Tiered Storage

2023-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751078#comment-17751078 ] Christo Lolov commented on KAFKA-15195: --- Acknowledged, I will circle-back on this

[jira] [Commented] (KAFKA-15267) Cluster-wide disablement of Tiered Storage

2023-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751077#comment-17751077 ] Christo Lolov commented on KAFKA-15267: --- Heya [~showuon]. Okay, I propose we do th

[jira] [Comment Edited] (KAFKA-14038) Optimize calculation of size for log in remote tier

2023-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751076#comment-17751076 ] Christo Lolov edited comment on KAFKA-14038 at 8/4/23 10:37 AM: --

[jira] [Assigned] (KAFKA-14038) Optimize calculation of size for log in remote tier

2023-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-14038: - Assignee: Christo Lolov (was: Divij Vaidya) > Optimize calculation of size for log in

[jira] [Commented] (KAFKA-14038) Optimize calculation of size for log in remote tier

2023-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751076#comment-17751076 ] Christo Lolov commented on KAFKA-14038: --- The remaining part of this ticket is bloc

[GitHub] [kafka] fvaleri commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-04 Thread via GitHub
fvaleri commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1665393332 > So for example, if the node.version is 1.0.0, this condition will be true, and the script will add DEV jars to CLASSPATH. kafka-run-class.sh then finds the 1.0.0 jars and adds them to C

[jira] [Updated] (KAFKA-15303) Foreign key joins no longer triggered by events on the right side of the join after deployment with a new compatible Avro schema

2023-08-04 Thread Charles-Eddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles-Eddy updated KAFKA-15303: - Description: Hello everyone, I am currently working on a project that uses Kafka Streams (versi

[GitHub] [kafka] hudeqi commented on pull request #13929: KAFKA-15129;[3/N] Remove metrics in AbstractFetcherManager when fetcher manager instance shutdown

2023-08-04 Thread via GitHub
hudeqi commented on PR #13929: URL: https://github.com/apache/kafka/pull/13929#issuecomment-1665378793 > I still need to get 3.5.1 out and focus on KIP-405 PRs (targeting 3.6 release) before I get some more time @hudeqi! Hi, do you have time to review this PR now? I want to combine al

[jira] [Created] (KAFKA-15303) Foreign key joins no longer triggered by events on the right side of the join after deployment with a new compatible Avro schema

2023-08-04 Thread Charles-Eddy (Jira)
Charles-Eddy created KAFKA-15303: Summary: Foreign key joins no longer triggered by events on the right side of the join after deployment with a new compatible Avro schema Key: KAFKA-15303 URL: https://issues.apac

[GitHub] [kafka] yashmayya commented on pull request #14152: KAFKA-7438: Migrate WindowStoreBuilderTest from EasyMock to Mockito

2023-08-04 Thread via GitHub
yashmayya commented on PR #14152: URL: https://github.com/apache/kafka/pull/14152#issuecomment-1665377020 @cadonna @mjsax would you be able to take a look at this whenever you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] yashmayya commented on a diff in pull request #14152: KAFKA-7438: Migrate WindowStoreBuilderTest from EasyMock to Mockito

2023-08-04 Thread via GitHub
yashmayya commented on code in PR #14152: URL: https://github.com/apache/kafka/pull/14152#discussion_r1284245654 ## streams/src/test/java/org/apache/kafka/streams/state/internals/WindowStoreBuilderTest.java: ## @@ -164,17 +160,6 @@ public void shouldThrowNullPointerIfInnerIsNull

[GitHub] [kafka] yashmayya commented on a diff in pull request #14152: KAFKA-7438: Migrate WindowStoreBuilderTest from EasyMock to Mockito

2023-08-04 Thread via GitHub
yashmayya commented on code in PR #14152: URL: https://github.com/apache/kafka/pull/14152#discussion_r1284245654 ## streams/src/test/java/org/apache/kafka/streams/state/internals/WindowStoreBuilderTest.java: ## @@ -164,17 +160,6 @@ public void shouldThrowNullPointerIfInnerIsNull

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-04 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1284241897 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -152,16 +152,42 @@ class UnifiedLog(@volatile var logStartOffset: Long, locally { initializePartitionMe

[GitHub] [kafka] yashmayya opened a new pull request, #14152: KAFKA-7438: Migrate WindowStoreBuilderTest from EasyMock to Mockito

2023-08-04 Thread via GitHub
yashmayya opened a new pull request, #14152: URL: https://github.com/apache/kafka/pull/14152 - Part of the larger effort to replace the usage of `EasyMock` and `PowerMock` with `Mockito` across the project that has been underway for the last few years (see https://issues.apache.org/jira/bro

[GitHub] [kafka] showuon opened a new pull request, #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-04 Thread via GitHub
showuon opened a new pull request, #14151: URL: https://github.com/apache/kafka/pull/14151 When configuring RLMM, the configs passed into `configure` method is the `RemoteLogManagerConfig`. But in `RemoteLogManagerConfig`, there's no configs related to `remote.log.metadata.*`, ex: `remote.

[GitHub] [kafka] satishd commented on pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-04 Thread via GitHub
satishd commented on PR #13984: URL: https://github.com/apache/kafka/pull/13984#issuecomment-1665334207 Will merge if the Jenkins jobs do not fail with any related tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Assigned] (KAFKA-15295) Add config validation when remote storage is enabled on a topic

2023-08-04 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-15295: Assignee: Luke Chen (was: Kamal Chandraprakash) > Add config validation

[jira] [Commented] (KAFKA-15295) Add config validation when remote storage is enabled on a topic

2023-08-04 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751054#comment-17751054 ] Kamal Chandraprakash commented on KAFKA-15295: -- [~showuon]  I'm not workin

[jira] [Resolved] (KAFKA-14598) Fix flaky ConnectRestApiTest

2023-08-04 Thread Ashwin Pankaj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashwin Pankaj resolved KAFKA-14598. --- Resolution: Fixed Did not observe this recently > Fix flaky ConnectRestApiTest > --

[jira] [Commented] (KAFKA-14598) Fix flaky ConnectRestApiTest

2023-08-04 Thread Ashwin Pankaj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751051#comment-17751051 ] Ashwin Pankaj commented on KAFKA-14598: --- Did not see this occuring recently - clos

[jira] [Commented] (KAFKA-15083) Passing "remote.log.metadata.*" configs into RLMM

2023-08-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751036#comment-17751036 ] Luke Chen commented on KAFKA-15083: --- [~satish.duggana] , sorry that I didn't get the p

[jira] [Commented] (KAFKA-15267) Cluster-wide disablement of Tiered Storage

2023-08-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751033#comment-17751033 ] Luke Chen commented on KAFKA-15267: --- Do we have any update on this issue? I think this

[GitHub] [kafka] satishd commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-04 Thread via GitHub
satishd commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1284146317 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -623,10 +632,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long nextSegment

[jira] [Commented] (KAFKA-15295) Add config validation when remote storage is enabled on a topic

2023-08-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751031#comment-17751031 ] Luke Chen commented on KAFKA-15295: --- [~ckamal] , are you still working on this? If you

[GitHub] [kafka] ivanyu commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-04 Thread via GitHub
ivanyu commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1284145024 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -66,6 +68,11 @@ public class RemoteLogSegmentMetadata extend

[GitHub] [kafka] showuon commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-04 Thread via GitHub
showuon commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1284105567 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -81,6 +81,13 @@ public final class RemoteLogManagerConfig {

[GitHub] [kafka] cadonna merged pull request #14145: KAFKA-10199: Change to RUNNING if no pending task to recycle exist

2023-08-04 Thread via GitHub
cadonna merged PR #14145: URL: https://github.com/apache/kafka/pull/14145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #14145: KAFKA-10199: Change to RUNNING if no pending task to recycle exist

2023-08-04 Thread via GitHub
cadonna commented on PR #14145: URL: https://github.com/apache/kafka/pull/14145#issuecomment-1665114431 Build failures are unrelated: ``` Build / JDK 17 and Scala 2.13 / integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor() Build / JDK 11 and

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-04 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1284009383 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable, Closea