smjn commented on code in PR #17149:
URL: https://github.com/apache/kafka/pull/17149#discussion_r1771835934
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java:
##
@@ -537,38 +539,322 @@ private static ShareGroupOffset merge(ShareGrou
AndrewJSchofield commented on code in PR #17149:
URL: https://github.com/apache/kafka/pull/17149#discussion_r1771822574
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java:
##
@@ -537,38 +539,322 @@ private static ShareGroupOffset mer
kumarpritam863 commented on PR #17255:
URL: https://github.com/apache/kafka/pull/17255#issuecomment-2368913632
@C0urante Can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kumarpritam863 opened a new pull request, #17255:
URL: https://github.com/apache/kafka/pull/17255
Summary:
Ensure that the Kafka consumer subscription object is updated with the
current partition assignment before partition revocation, so that close()
method of the sink connector's has t
jsancio commented on PR #17235:
URL: https://github.com/apache/kafka/pull/17235#issuecomment-2368903179
Thanks @chia7712 . I fixed those encoding issues.
> https://github.com/apache/kafka/blob/trunk/docs/ops.html#L4249
I couldn't find anything wrong with that line. Did you mean to l
lianetm commented on code in PR #17244:
URL: https://github.com/apache/kafka/pull/17244#discussion_r1771804938
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1471,6 +1487,7 @@ public void unsubscribe() {
fetchBuf
lianetm commented on code in PR #17244:
URL: https://github.com/apache/kafka/pull/17244#discussion_r1771804938
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1471,6 +1487,7 @@ public void unsubscribe() {
fetchBuf
m1a2st commented on PR #16381:
URL: https://github.com/apache/kafka/pull/16381#issuecomment-2368834415
rebase on the trunk, and fix the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dimitarndimitrov commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1771776869
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +177,39 @@ public void testHistogramDataRes
fonsdant commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2368771036
@mumrah, thanks for the explanation. I really appreciate it! :)
I will proceed modifying the script to use ref.
--
This is an automated message from the Apache Git Service.
To re
rreddy-22 commented on code in PR #17093:
URL: https://github.com/apache/kafka/pull/17093#discussion_r1771746899
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -260,6 +325,21 @@ object StorageTool extends Logging {
s"${MetadataVersion.IBP_3_0_IV0}; the defa
fonsdant commented on PR #17198:
URL: https://github.com/apache/kafka/pull/17198#issuecomment-2368758343
I have removed the references to `transform` from docs. I am wondering if it
would be better to replace `transform` with `process`, instead of removing it.
I have started to think about
dajac commented on PR #17233:
URL: https://github.com/apache/kafka/pull/17233#issuecomment-2368724037
@FrankYang0529 There are a few conflicts. Could you please address them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
frankvicky commented on code in PR #17250:
URL: https://github.com/apache/kafka/pull/17250#discussion_r1771647091
##
tests/kafkatest/tests/core/reassign_partitions_test.py:
##
@@ -176,7 +176,10 @@ def test_reassign_partitions(self, bounce_brokers,
reassign_from_offset_zero, me
chia7712 commented on code in PR #17250:
URL: https://github.com/apache/kafka/pull/17250#discussion_r1771641828
##
tests/kafkatest/tests/core/reassign_partitions_test.py:
##
@@ -176,7 +176,10 @@ def test_reassign_partitions(self, bounce_brokers,
reassign_from_offset_zero, me
m1a2st opened a new pull request, #17254:
URL: https://github.com/apache/kafka/pull/17254
In this test, I think is the
[max.block.ms](https://kafka.apache.org/documentation/#producerconfigs_max.block.ms)
is so short for `initTransactions()`, however this test should test that
commit fail,
dajac merged PR #17133:
URL: https://github.com/apache/kafka/pull/17133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mumrah commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2368526553
@fonsdant, just updating the ref on the remote (GitHub) would indeed work.
In Git, a ref is simply a text file with a SHA in it. Conventionally, tags
are immutable since they are typ
srdo commented on code in PR #17225:
URL: https://github.com/apache/kafka/pull/17225#discussion_r1771535619
##
core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java:
##
@@ -122,4 +126,25 @@ public void
testCreateClusterAndCloseWithMultipleLogDirs(boolean combined) {
chia7712 commented on code in PR #17225:
URL: https://github.com/apache/kafka/pull/17225#discussion_r1771528836
##
core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java:
##
@@ -122,4 +126,25 @@ public void
testCreateClusterAndCloseWithMultipleLogDirs(boolean combined) {
srdo commented on code in PR #17225:
URL: https://github.com/apache/kafka/pull/17225#discussion_r1771522261
##
core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java:
##
@@ -122,4 +126,25 @@ public void
testCreateClusterAndCloseWithMultipleLogDirs(boolean combined) {
olegbonar commented on PR #17253:
URL: https://github.com/apache/kafka/pull/17253#issuecomment-2368206551
@jlprat done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
FrankYang0529 commented on code in PR #17244:
URL: https://github.com/apache/kafka/pull/17244#discussion_r1771374443
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1471,6 +1487,7 @@ public void unsubscribe() {
fe
xijiu commented on PR #17231:
URL: https://github.com/apache/kafka/pull/17231#issuecomment-2368132282
@chia7712I have modified the code and remove some getter methods from
`KafkaConfig`,PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, p
chia7712 commented on code in PR #17240:
URL: https://github.com/apache/kafka/pull/17240#discussion_r1771316645
##
tests/setup.py:
##
@@ -51,7 +51,7 @@ def run_tests(self):
license="apache2.0",
packages=find_packages(),
include_package_data=True,
- inst
chia7712 merged PR #17226:
URL: https://github.com/apache/kafka/pull/17226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
FrankYang0529 commented on PR #17224:
URL: https://github.com/apache/kafka/pull/17224#issuecomment-2368057658
> @FrankYang0529 please fix the conflicts
Fixed it. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
aliehsaeedii commented on PR #17091:
URL: https://github.com/apache/kafka/pull/17091#issuecomment-2368049415
> Hi @aliehsaeedii . I left some comments
Thanks. I think most of them must be applied in KIP's PR.
--
This is an automated message from the Apache Git Service.
To respond t
aliehsaeedii commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1771295666
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1232,47 +1231,51 @@ public void
shouldRespectPunctuateCancellati
aliehsaeedii commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1771294976
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1820,6 +1820,9 @@ void addRecordsToTasks(final ConsumerRecords recor
aliehsaeedii commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1771288861
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##
@@ -462,23 +463,29 @@ public Map
prepareCommit() {
}
}
-
jlprat commented on PR #17253:
URL: https://github.com/apache/kafka/pull/17253#issuecomment-2368003779
I think this is the best we can have for this project.
https://github.com/luben/zstd-jni/compare/v1.5.6-4...v1.5.6-5
You can edit your PR description with this link.
--
This is an
olegbonar commented on PR #17253:
URL: https://github.com/apache/kafka/pull/17253#issuecomment-2367995668
@jlprat, I would happily do it. Could you point me out to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
chia7712 commented on code in PR #17225:
URL: https://github.com/apache/kafka/pull/17225#discussion_r1771247357
##
core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java:
##
@@ -122,4 +126,25 @@ public void
testCreateClusterAndCloseWithMultipleLogDirs(boolean combined) {
lianetm commented on PR #17165:
URL: https://github.com/apache/kafka/pull/17165#issuecomment-2367970018
Hey @FrankYang0529 , sorry for the late reply, I was traveling last week but
I'm back, so will be taking another look at this. You can mark it as ready, we
can leave the fix for the flaky
chia7712 commented on PR #17222:
URL: https://github.com/apache/kafka/pull/17222#issuecomment-2367957438
@frankvicky please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chia7712 commented on PR #17224:
URL: https://github.com/apache/kafka/pull/17224#issuecomment-2367956458
@FrankYang0529 please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
lianetm commented on code in PR #17244:
URL: https://github.com/apache/kafka/pull/17244#discussion_r1771230669
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -246,6 +246,7 @@ private void process(final Subscripti
chia7712 commented on code in PR #17248:
URL: https://github.com/apache/kafka/pull/17248#discussion_r1771227003
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -709,6 +709,29 @@ && isRemoteSegmentWithinLeaderEpochs(rlsMetadata,
unifiedLog.logEndOffset(), epo
xijiu commented on PR #17252:
URL: https://github.com/apache/kafka/pull/17252#issuecomment-2367923953
@chia7712 Sure, I have removed it, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
chia7712 commented on code in PR #17252:
URL: https://github.com/apache/kafka/pull/17252#discussion_r1771216149
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcherUtils.java:
##
@@ -234,9 +234,8 @@ Map getOffsetResetTimestamp() {
Set parti
jlprat commented on PR #17253:
URL: https://github.com/apache/kafka/pull/17253#issuecomment-2367860893
hi @olegbonar, can you add the release notes for this version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
olegbonar commented on PR #17253:
URL: https://github.com/apache/kafka/pull/17253#issuecomment-2367840044
@mimaison may I ask you to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
olegbonar opened a new pull request, #17253:
URL: https://github.com/apache/kafka/pull/17253
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
lucasbru commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1771051009
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##
@@ -462,23 +463,29 @@ public Map
prepareCommit() {
}
}
-
lucasbru commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1771058136
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1820,6 +1820,9 @@ void addRecordsToTasks(final ConsumerRecords records)
lucasbru commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1771058136
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1820,6 +1820,9 @@ void addRecordsToTasks(final ConsumerRecords records)
lucasbru commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1771053314
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##
@@ -462,23 +463,29 @@ public Map
prepareCommit() {
}
}
-
lucasbru commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1771051009
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##
@@ -462,23 +463,29 @@ public Map
prepareCommit() {
}
}
-
lucasbru commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1771041249
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetch.java:
##
@@ -57,6 +75,22 @@ private Fetch(
this.records = records;
this.po
xijiu opened a new pull request, #17252:
URL: https://github.com/apache/kafka/pull/17252
As title
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
xijiu commented on PR #17223:
URL: https://github.com/apache/kafka/pull/17223#issuecomment-2367394834
> > Maybe we can use ApiKeys instead?
>
> Yes that's also an option. I'd really prefer this or pattern matching over
the current code.
@mimaison @chia7712 Thanks very much fo
chia7712 commented on code in PR #17249:
URL: https://github.com/apache/kafka/pull/17249#discussion_r1770840515
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/log/StressTestLog.java:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
frankvicky commented on code in PR #17250:
URL: https://github.com/apache/kafka/pull/17250#discussion_r1770804334
##
tests/kafkatest/tests/core/reassign_partitions_test.py:
##
@@ -176,7 +176,7 @@ def test_reassign_partitions(self, bounce_brokers,
reassign_from_offset_zero, me
frankvicky commented on PR #17250:
URL: https://github.com/apache/kafka/pull/17250#issuecomment-2367291581
Hello @chia7712
Following is the test result on branch 3.8:
```
SESSION REPORT (ALL TESTS)
TaiJuWu commented on PR #17237:
URL: https://github.com/apache/kafka/pull/17237#issuecomment-2367247213
> @TaiJuWu Could you please fix conflicts?
Done. Thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chia7712 commented on PR #17237:
URL: https://github.com/apache/kafka/pull/17237#issuecomment-2367182725
@TaiJuWu Could you please fix conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 merged PR #17207:
URL: https://github.com/apache/kafka/pull/17207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #17212:
URL: https://github.com/apache/kafka/pull/17212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #17250:
URL: https://github.com/apache/kafka/pull/17250#discussion_r1770737046
##
tests/kafkatest/tests/core/reassign_partitions_test.py:
##
@@ -176,7 +176,7 @@ def test_reassign_partitions(self, bounce_brokers,
reassign_from_offset_zero, me
chia7712 merged PR #17179:
URL: https://github.com/apache/kafka/pull/17179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #17202:
URL: https://github.com/apache/kafka/pull/17202#discussion_r1770733451
##
docs/upgrade.html:
##
@@ -51,6 +51,18 @@ Notable changes in 4
The --whitelist option was removed from the
kafka-console-consumer command line tool
xijiu commented on PR #17174:
URL: https://github.com/apache/kafka/pull/17174#issuecomment-2367091855
@chia7712
Inlining does make the code more cleaner. I have fixed it, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
fonsdant commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2366967094
How about using only a ref to point to the cached commit instead?
A tag isn't the best option, as described in the GitHub REST API
documentation: _"A Git tag is similar to a Git re
mjsax closed pull request #17167: KAFKA-17524: Add timeout to
StreamThreadTest.shouldReturnErrorIfProducerInstanceIdNotInitialized
URL: https://github.com/apache/kafka/pull/17167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
frankvicky commented on PR #17250:
URL: https://github.com/apache/kafka/pull/17250#issuecomment-2366844405
Test result on my local machine
```
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.4
s
brandboat opened a new pull request, #17251:
URL: https://github.com/apache/kafka/pull/17251
related to https://issues.apache.org/jira/browse/KAFKA-16974?filter=12353520
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify te
frankvicky opened a new pull request, #17250:
URL: https://github.com/apache/kafka/pull/17250
JIRA: [KAFKA-17459](https://issues.apache.org/jira/browse/KAFKA-17459)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test co
frankvicky opened a new pull request, #17249:
URL: https://github.com/apache/kafka/pull/17249
JIRA: [KAFKA-17570](https://issues.apache.org/jira/browse/KAFKA-17570)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test co
TaiJuWu commented on code in PR #17247:
URL: https://github.com/apache/kafka/pull/17247#discussion_r1770233963
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java:
##
@@ -78,6 +79,10 @@ interface ConfigName {
.define(ConfigName.
m1a2st commented on code in PR #17247:
URL: https://github.com/apache/kafka/pull/17247#discussion_r1770153629
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java:
##
@@ -95,6 +100,9 @@ public String version() {
@Override
public v
FrankYang0529 opened a new pull request, #17248:
URL: https://github.com/apache/kafka/pull/17248
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summ
TaiJuWu opened a new pull request, #17247:
URL: https://github.com/apache/kafka/pull/17247
There is no validation of ReplaceField, we should add it.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI bu
TaiJuWu commented on code in PR #17168:
URL: https://github.com/apache/kafka/pull/17168#discussion_r1759638418
##
server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsConfigs.java:
##
@@ -131,9 +131,11 @@ private static void validateProperties(Properties
properties
unknowntpo commented on code in PR #17240:
URL: https://github.com/apache/kafka/pull/17240#discussion_r1769708462
##
tests/docker/Dockerfile:
##
@@ -63,7 +63,7 @@ LABEL ducker.creator=$ducker_creator
# we have to install git since it is included in openjdk:8 but not openjdk:11
unknowntpo commented on code in PR #17240:
URL: https://github.com/apache/kafka/pull/17240#discussion_r1769708276
##
tests/setup.py:
##
@@ -51,7 +51,7 @@ def run_tests(self):
license="apache2.0",
packages=find_packages(),
include_package_data=True,
- in
mjsax commented on code in PR #17212:
URL: https://github.com/apache/kafka/pull/17212#discussion_r1769694361
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java:
##
@@ -318,14 +314,7 @@ Map producerMetrics() {
}
Set producerCl
mjsax commented on code in PR #17212:
URL: https://github.com/apache/kafka/pull/17212#discussion_r1769694361
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java:
##
@@ -318,14 +314,7 @@ Map producerMetrics() {
}
Set producerCl
fonsdant commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2365398034
> Can we do: fetch, merge --ff-only, push instead?
It seems this approach is not so out-of-the-box. In my tests, Git fails with
fatal: refusing to merge unrelated histories:
[here
TaiJuWu commented on code in PR #17230:
URL: https://github.com/apache/kafka/pull/17230#discussion_r1769625701
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -863,9 +865,14 @@ public long position(TopicPartition partition, Dur
TaiJuWu commented on PR #17237:
URL: https://github.com/apache/kafka/pull/17237#issuecomment-2365263862
> @TaiJuWu could you please update `upgrade.html`?
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
m1a2st opened a new pull request, #17246:
URL: https://github.com/apache/kafka/pull/17246
Jira: https://issues.apache.org/jira/browse/KAFKA-17568
Move TestPurgatoryPerformance from Scala to Java, and transfer to use
benchmark.
### Committer Checklist (excluded from commit message)
chia7712 merged PR #17206:
URL: https://github.com/apache/kafka/pull/17206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
fonsdant commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1769568062
##
.github/workflows/ci-complete.yml:
##
@@ -118,3 +118,16 @@ jobs:
description: 'The build scan was successfully published'
context: 'Gradle Bui
dajac commented on PR #17233:
URL: https://github.com/apache/kafka/pull/17233#issuecomment-2365186575
@FrankYang0529 Thanks for the update. I am travelling today so I will review
it on Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
chia7712 commented on code in PR #17240:
URL: https://github.com/apache/kafka/pull/17240#discussion_r1769554254
##
tests/docker/Dockerfile:
##
@@ -63,7 +63,7 @@ LABEL ducker.creator=$ducker_creator
# we have to install git since it is included in openjdk:8 but not openjdk:11
R
sjhajharia commented on PR #16050:
URL: https://github.com/apache/kafka/pull/16050#issuecomment-2365167257
Hey @mjsax
Sorry, I was swamped a bit. Getting back to this, thanks for the review. I
have updated the PR.
Could you pls help review again.
Thanks
--
This is an automated
FrankYang0529 commented on PR #17224:
URL: https://github.com/apache/kafka/pull/17224#issuecomment-2365165916
> @FrankYang0529 Could you please update `upgrade.html`?
Added it. Thanks for the reminder.
--
This is an automated message from the Apache Git Service.
To respond to the me
mumrah commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1769545365
##
.github/workflows/ci-complete.yml:
##
@@ -118,3 +118,16 @@ jobs:
description: 'The build scan was successfully published'
context: 'Gradle Build
fonsdant commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1769544347
##
.github/workflows/ci-complete.yml:
##
@@ -118,3 +118,16 @@ jobs:
description: 'The build scan was successfully published'
context: 'Gradle Bui
fonsdant commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1769544347
##
.github/workflows/ci-complete.yml:
##
@@ -118,3 +118,16 @@ jobs:
description: 'The build scan was successfully published'
context: 'Gradle Bui
fonsdant commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1769544347
##
.github/workflows/ci-complete.yml:
##
@@ -118,3 +118,16 @@ jobs:
description: 'The build scan was successfully published'
context: 'Gradle Bui
FrankYang0529 commented on PR #16912:
URL: https://github.com/apache/kafka/pull/16912#issuecomment-2365162969
Hi @chia7712, thanks for the suggestion. I addressed all comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
fonsdant commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1769544347
##
.github/workflows/ci-complete.yml:
##
@@ -118,3 +118,16 @@ jobs:
description: 'The build scan was successfully published'
context: 'Gradle Bui
fonsdant commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1769544347
##
.github/workflows/ci-complete.yml:
##
@@ -118,3 +118,16 @@ jobs:
description: 'The build scan was successfully published'
context: 'Gradle Bui
fonsdant commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1769544347
##
.github/workflows/ci-complete.yml:
##
@@ -118,3 +118,16 @@ jobs:
description: 'The build scan was successfully published'
context: 'Gradle Bui
FrankYang0529 commented on code in PR #17230:
URL: https://github.com/apache/kafka/pull/17230#discussion_r1769499444
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -863,9 +865,14 @@ public long position(TopicPartition partitio
FrankYang0529 commented on PR #17233:
URL: https://github.com/apache/kafka/pull/17233#issuecomment-2365030214
Hi @dajac, I fixed both `testGroupEpochBumpWhenNewStaticMemberJoins` and
`testNewJoiningMemberTriggersNewTargetAssignment`. Originally, different
`partitionRacks` triggers subscript
TaiJuWu commented on code in PR #17080:
URL: https://github.com/apache/kafka/pull/17080#discussion_r1769485396
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4143,19 +4140,27 @@ public RemoveMembersFromConsumerGroupResult
removeMembersFrom
frankvicky commented on code in PR #17080:
URL: https://github.com/apache/kafka/pull/17080#discussion_r1769459881
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4143,19 +4140,27 @@ public RemoveMembersFromConsumerGroupResult
removeMembersF
1 - 100 of 10258 matches
Mail list logo
