Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Alexander Potashev
> On Июнь 20, 2015, 7:10 п.п., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124138: Install kconfig_compiler into libexec

2015-06-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124138/ --- (Updated June 21, 2015, 6:15 a.m.) Review request for KDE Frameworks, Mat

Re: Review Request 124138: Install kconfig_compiler into libexec

2015-06-20 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124138/#review81608 --- +1 on moving it from me. I don't think anyone will mind as it

Review Request 124138: Install kconfig_compiler into libexec

2015-06-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124138/ --- Review request for KDE Frameworks, Matthew Dawson and Harald Sitter. Repo

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/ --- (Updated June 21, 2015, 12:16 a.m.) Status -- This change has been m

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Martin Gräßlin
> On June 20, 2015, 9:10 p.m., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Martin Klapetek
> On June 20, 2015, 9:10 p.m., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Sebastian Kügler
> On June 20, 2015, 7:10 p.m., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81603 --- +1 for adding all that info -1 for putting it into its own tab

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Martin Gräßlin
> On June 20, 2015, 8:02 p.m., Alexander Potashev wrote: > > typo: "build against [...]" -> "built against [...]" thanks, fixed locally. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kd

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Martin Gräßlin
> On June 20, 2015, 7:20 p.m., Christoph Cullmann wrote: > > +1 for the additional information. > > Btw., is there any way we would get that info submitted for bugs, too? > > (which is a different thingy, I know, just came to mind) probably needs to be added to KCrash for that. And yes that sou

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81599 --- typo: "build against [...]" -> "built against [...]" - Alexan

Re: Review Request 124134: Fixing KDED string references

2015-06-20 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124134/#review81598 --- Ship it! Looks good. - Vishesh Handa On June 20, 2015, 5:2

Re: Review Request 124129: Fix KAuthorized config file loading

2015-06-20 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124129/#review81597 --- +1 from me, just one change below. It's more semantically cor

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81596 --- +1 for the additional information. Btw., is there any way we w

Re: Review Request 123890: Don't show "KDE Frameworks version" in the About KDE dialog

2015-06-20 Thread Martin Gräßlin
> On June 20, 2015, 6:08 p.m., Martin Gräßlin wrote: > > Different approach: https://git.reviewboard.kde.org/r/124133/ oh sorry, my comment doesn't make sense. +1 for removing it from about kde. - Martin --- This is an automatically ge

Re: Review Request 123890: Don't show "KDE Frameworks version" in the About KDE dialog

2015-06-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123890/#review81592 --- Different approach: https://git.reviewboard.kde.org/r/124133/

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » OSX,clang - Build # 10 - Failure!

2015-06-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/10/ Project: PLATFORM=OSX,compiler=clang Date of build: Sat, 20 Jun 2015 07:11:37 + Build duration: 47 sec CHANGE SET No changes ___