On 2019/12/16 下午6:12, Daniel P. Berrangé wrote:
On Sun, Dec 15, 2019 at 02:39:20AM +, Wang, Huaqiang wrote:
Hi Daniel,
Thanks for your review.
About patch 1/5, I understand we should be very cautious when we changes the
determined
interface.
I'd like to reserved the old 32bit
On 12/16/19 9:48 PM, Alex Williamson wrote:
On Mon, 16 Dec 2019 21:09:20 -0300
Yes, but libvirt should not assume that it can manipulate the bindings
of adjacent devices without being explicitly directed to do so. The
error may be a hindrance to you, but it might also prevent, for
example,
On Mon, 16 Dec 2019 21:09:20 -0300
Daniel Henrique Barboza wrote:
> On 12/16/19 8:43 PM, Alex Williamson wrote:
> > On Mon, 16 Dec 2019 20:24:56 -0300
> > Daniel Henrique Barboza wrote:
> >
> >>
> >> The code isn't forcing a device to be assigned to the guest. It is forcing
> >> all the
On 12/16/19 8:43 PM, Alex Williamson wrote:
On Mon, 16 Dec 2019 20:24:56 -0300
Daniel Henrique Barboza wrote:
The code isn't forcing a device to be assigned to the guest. It is forcing
all the IOMMU devices to be declared in the domain XML to be detached from
the host.
Detached from the
On Mon, 16 Dec 2019 20:24:56 -0300
Daniel Henrique Barboza wrote:
> On 12/16/19 8:06 PM, Alex Williamson wrote:
> > On Mon, 16 Dec 2019 17:28:28 -0500
> > Cole Robinson wrote:
> >
> >> On 12/16/19 8:36 AM, Daniel Henrique Barboza wrote:
> >>> changes from version 3 [1]:
> >
> > Thanks
On 12/9/19 6:15 PM, Daniel Henrique Barboza wrote:
> (series based on master commit 97cafa610ecf5)
>
> This work was proposed by Cole in [1]. This is Cole's reasoning for
> it, copy/pasted from [1]:
>
> ---
> The benefits of moving to validate time is that XML is rejected by
> 'virsh define'
On 12/16/19 8:06 PM, Alex Williamson wrote:
On Mon, 16 Dec 2019 17:28:28 -0500
Cole Robinson wrote:
On 12/16/19 8:36 AM, Daniel Henrique Barboza wrote:
changes from version 3 [1]:
Thanks for catching this! PCIe root ports or bridges being part of an
IOMMU group is part of the nature of
On 12/16/19 7:28 PM, Cole Robinson wrote:
On 12/16/19 8:36 AM, Daniel Henrique Barboza wrote:
I've attached the nodedev XML for the three devices with iommuGroup 1.
Only the two nvidia devices are assigned to my VM, but not the PCIe
controller device.
Just noticed the attached file. This
On Mon, 16 Dec 2019 17:28:28 -0500
Cole Robinson wrote:
> On 12/16/19 8:36 AM, Daniel Henrique Barboza wrote:
> > changes from version 3 [1]:
> > - removed last 2 patches that made function 0 of
> > PCI multifunction devices mandatory
> > - new patch: news.xml update
> > - changed 'since'
On 12/16/19 7:28 PM, Cole Robinson wrote:
On 12/16/19 8:36 AM, Daniel Henrique Barboza wrote:
changes from version 3 [1]:
- removed last 2 patches that made function 0 of
PCI multifunction devices mandatory
- new patch: news.xml update
- changed 'since' version to 6.0.0 in patch 4
-
On 12/16/19 5:46 PM, Cole Robinson wrote:
> On 12/9/19 6:15 PM, Daniel Henrique Barboza wrote:
>> Move smartcard validation being done by qemuBuildSmartcardCommandLine()
>> to the existing qemuDomainSmartcardDefValidate() function. This
>> function is called by qemuDomainDeviceDefValidate(),
On 12/9/19 6:15 PM, Daniel Henrique Barboza wrote:
> Move smartcard validation being done by qemuBuildSmartcardCommandLine()
> to the existing qemuDomainSmartcardDefValidate() function. This
> function is called by qemuDomainDeviceDefValidate(), allowing smartcard
> validation in domain define
On 12/9/19 6:15 PM, Daniel Henrique Barboza wrote:
> Move EGL Headless validation from qemuBuildGraphicsEGLHeadlessCommandLine()
> to qemuDomainDeviceDefValidateGraphics(). This function is called by
> qemuDomainDefValidate(), validating the graphics parameters in domain
> define time.
>
> Tests
On 12/9/19 6:15 PM, Daniel Henrique Barboza wrote:
> QEMU_CAPS_DEVICE_NVDIMM validation is now being done inside
> qemuDomainDefValidateMemory().
>
> Signed-off-by: Daniel Henrique Barboza
> ---
> src/qemu/qemu_command.c | 5 -
> src/qemu/qemu_domain.c | 10 ++
>
On 12/16/19 8:36 AM, Daniel Henrique Barboza wrote:
> changes from version 3 [1]:
> - removed last 2 patches that made function 0 of
> PCI multifunction devices mandatory
> - new patch: news.xml update
> - changed 'since' version to 6.0.0 in patch 4
> - unassigned hostdevs are now getting qemu
On 12/9/19 12:14 PM, Daniel P. Berrangé wrote:
> This series is an effort to reduce the number of different
> languages we use by eliminating most use of perl in favour
> of python.
>
Reviewed-by: Cole Robinson
- Cole
--
libvir-list mailing list
libvir-list@redhat.com
On 12/13/19 11:51 AM, Daniel P. Berrangé wrote:
i386 was dropped even as a secondary arch in F31 so must remain
on F30
Signed-off-by: Daniel P. Berrangé
I did that locally a couple weeks ago, then forgot to send it. (except
that I missed the part to update the kernel images. I guess when
Hi all, I added a 'Ongoing code transitions' section to the
BiteSizedTasks page on the wiki:
https://wiki.libvirt.org/page/BiteSizedTasks#Ongoing_code_transitions
BiteSizedTasks might not be the best location for it, but I wanted to
start a list and that page already exists.
I added 3 sections:
virHostdevPreparePCIDevices verifies if a PCI hostdev "A" is
in use by another domain by checking the 'activePCIHostdevs'
list. It also verifies if other domains are using any other
hostdev that belongs to the same IOMMU of "A".
This is not enough to cover all the cases. Suppose a PCI hostdev
"B"
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 14 ++
1 file changed, 14 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index bfcdc026e6..281de89b10 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@
Signed-off-by: Daniel Henrique Barboza
---
docs/news.xml | 19 +++
1 file changed, 19 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 2a25b6ca49..e77cd743c8 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -54,6 +54,25 @@
written in the RST as an
Previous patch made it possible for the QEMU driver to check if
a given PCI hostdev is unassigned, by checking if dev->info->type is
VIR_DOMAIN_DEVICE_ADDRESS_TYPE_UNASSIGNED, meaning that this device
shouldn't be part of the actual guest launch.
Signed-off-by: Daniel Henrique Barboza
---
Today, to use a PCI hostdev "A" in a domain, all PCI devices
that belongs to the same IOMMU group must also be declared in
the domain XML, meaning that all IOMMU devices are detached
from the host and all of them are visible to the guest.
The result is that the guest will have access to all
changes from version 3 [1]:
- removed last 2 patches that made function 0 of
PCI multifunction devices mandatory
- new patch: news.xml update
- changed 'since' version to 6.0.0 in patch 4
- unassigned hostdevs are now getting qemu aliases
[1]
Thanks Sahid.
Vineeth
On Mon, Dec 16, 2019 at 5:59 AM Sahid Orentino Ferdjaoui
wrote:
>
> On Sat, Dec 14, 2019 at 01:38:56PM +, Vineeth Remanan Pillai wrote:
> > Implement the following:
> > - virDomainGetSchedulerType
> > - virDomainSetSchedulerParameters
> > -
Zanata is dead upstream, and Fedora is replacing it with Weblate
https://fedoraproject.org/wiki/L10N_Move_to_Weblate
Libvirt has outsourced its translations to the Fedora translation
team, so we must follow this move.
Daniel P. Berrangé (2):
po: delete empty translation files
po: change
Historically we stored all translation languages known to Zanata, even
if there were no translated strings present, because every language was
created in Zanata. With the move to Weblate we are only going to store
non-empty translations because languages won't be created in Weblate
until someone
The Zanata project is dead and so Fedora is transitioning over to using
Weblate for managing translations. With Weblate, languages are only
created on the server when the first translation is started, so we must
check to see if any new languages exist during download, so that they
can be added to
On Tue, Dec 03, 2019 at 03:19:39 -0800, Ani Sinha wrote:
> Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR")
> adds support for CLZERO CPUID bit. This commit extends support for this
> bit in libvirt.
>
> This patch is based off of libvirt-4.5 tree.
Thanks, but we are
On Tue, Dec 03, 2019 at 03:09:12 -0800, Ani Sinha wrote:
> Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR")
> adds support for CLZERO CPUID bit.
> This commit extends support for this CPUID bit into libvirt.
>
> Signed-off-by: Ani Sinha
> ---
>
OpenVZ has been added as part of commit 0a7993d3ed30ae. However, it's
wrongly set to be installed on any supported CentOS.
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/update/tasks/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/playbooks/update/tasks/base.yml
This series consists in two simple patches:
- Mention CentOS8 as a valid OS version;
- Only install OpenVZ on CentOS 7;
Fabiano Fidêncio (2):
guests: Mention CentOS8 as a valid OS version
guests: Only install OpenVZ on CentOS 7
guests/playbooks/update/tasks/base.yml | 1 +
CentOS8 has been added as part of 03fd3a8ef16a3c4. However, it was not
mentioned as a valid OS version.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index
On Mon, Dec 16, 2019 at 10:36:40 +, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> include/libvirt/libvirt-host.h | 4
> src/libvirt-host.c | 16
> 2 files changed, 20 insertions(+)
Reviewed-by: Jiri Denemark
--
libvir-list mailing
On Sat, Dec 14, 2019 at 01:38:56PM +, Vineeth Remanan Pillai wrote:
> Implement the following:
> - virDomainGetSchedulerType
> - virDomainSetSchedulerParameters
> - virDomainSetSchedulerParametersFlags
> - virDomainGetSchedulerParameters
> - virDomainGetSchedulerParametersFlags
>
>
Signed-off-by: Daniel P. Berrangé
---
include/libvirt/libvirt-host.h | 4
src/libvirt-host.c | 16
2 files changed, 20 insertions(+)
diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h
index be65b4686b..b87d634813 100644
---
On Sun, Dec 15, 2019 at 02:39:20AM +, Wang, Huaqiang wrote:
> Hi Daniel,
>
> Thanks for your review.
>
> About patch 1/5, I understand we should be very cautious when we changes the
> determined
> interface.
>
> I'd like to reserved the old 32bit interface and propose a new 64bit
>
On Mon, Dec 16, 2019 at 08:20:59AM +0100, Christian Ehrhardt wrote:
> These days libvirt is pretty reliable and even remote connections
> (not the default for libvirt-guests anyway) either work or fail but are
> uncommon to be flaky.
>
> On the other hand users might have disabled the service and
Implement the following:
- virDomainGetSchedulerType
- virDomainSetSchedulerParameters
- virDomainSetSchedulerParametersFlags
- virDomainGetSchedulerParameters
- virDomainGetSchedulerParametersFlags
Signed-off-by: Vineeth Remanan Pillai
---
examples/hello.rs | 38 +++
src/domain.rs |
On Fri, Dec 13, 2019 at 03:00 PM -0500, Cole Robinson
wrote:
> On 12/12/19 9:13 AM, Marc Hartmayer wrote:
>> On Wed, Dec 11, 2019 at 07:48 PM -0500, Cole Robinson
>> wrote:
>>> On 11/14/19 12:44 PM, Marc Hartmayer wrote:
To free the structs and save the error, it is not necessary to hold
40 matches
Mail list logo
