Re: [PATCH v2 09/18] iio: afe: iio-rescale: Simplify with dev_err_probe()

2020-08-27 Thread Peter Rosin
On 2020-08-28 08:24, Krzysztof Kozlowski wrote: > On Thu, Aug 27, 2020 at 11:46:40PM +0200, Peter Rosin wrote: >> On 2020-08-27 21:26, Krzysztof Kozlowski wrote: >>> Common pattern of handling deferred probe can be simplified with >>> dev_err_probe(). Less code and also it prints the error valu

Re: [PATCH] Remove unneeded variable t1

2020-08-27 Thread Herbert Xu
Xu Wang wrote: > Remove unneeded variable t1 seed_encrypt() and > seed_decrypt(). > > Signed-off-by: Xu Wang > --- > crypto/seed.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/crypto/seed.c b/crypto/seed.c > index 5e3bef3a617d..69b3058d6a32 100644 > --- a/crypto/s

Re: [PATCH v3] mm: Fix kthread_use_mm() vs TLB invalidate

2020-08-27 Thread Nicholas Piggin
Excerpts from Nicholas Piggin's message of August 28, 2020 1:26 pm: > Excerpts from pet...@infradead.org's message of August 21, 2020 11:04 pm: >> On Fri, Aug 21, 2020 at 11:09:51AM +0530, Aneesh Kumar K.V wrote: >>> Peter Zijlstra writes: >>> >>> > For SMP systems using IPI based TLB invalidatio

[PATCH] clk: imx: fix i.MX7D peripheral clk mux flags

2020-08-27 Thread peng . fan
From: Peng Fan According to RM, Page 574, Chapter 5.2.6.4.3 Peripheral clock slice, "IP clock slices must be stopped to change the clock source.". So we must have CLK_SET_PARENT_GATE flag to avoid glitch. Signed-off-by: Peng Fan --- drivers/clk/imx/clk-imx7d.c | 131 ++

Re: [PATCH 1/7] soundwire: bus: use property to set interrupt masks

2020-08-27 Thread Vinod Koul
Hi Mark, On 18-08-20, 22:06, Bard Liao wrote: > From: Pierre-Louis Bossart > > Add a slave-level property and program the SCP_INT1_MASK as desired by > the codec driver. Since there is no DisCo property this has to be an > implementation-specific firmware property or hard-coded in the driver. >

Re: [PATCH v5 02/18] crypto: sun8i-ss: Add support for the PRNG

2020-08-27 Thread Herbert Xu
On Fri, Aug 21, 2020 at 01:43:19PM +, Corentin Labbe wrote: > > + err = pm_runtime_get_sync(ss->dev); > + if (err < 0) > + goto err_pm; > + err = 0; The error case needs to do this: https://patchwork.kernel.org/patch/11728595/ Cheers, -- Email: Herbert Xu Home Page:

Re: [PATCH 2/2] ASoC: wm8994: Ensure the device is resumed in wm89xx_mic_detect functions

2020-08-27 Thread Krzysztof Kozlowski
On Thu, Aug 27, 2020 at 07:33:57PM +0200, Sylwester Nawrocki wrote: > When the wm8958_mic_detect, wm8994_mic_detect functions get called from > the machine driver, e.g. from the card's late_probe() callback, the CODEC > device may be PM runtime suspended and any regmap writes have no effect. > Add

Re: [PATCH] sched/numa: use runnable_avg to classify node

2020-08-27 Thread Vincent Guittot
On Thu, 27 Aug 2020 at 20:22, Mel Gorman wrote: > > On Thu, Aug 27, 2020 at 05:43:11PM +0200, Vincent Guittot wrote: > > > The testing was a mixed bag of wins and losses but wins more than it > > > loses. Biggest loss was a 9.04% regression on nas-SP using openmp for > > > parallelisation on Zen1.

Re: [PATCH v5 03/18] crypto: sun8i-ss: support hash algorithms

2020-08-27 Thread Herbert Xu
On Fri, Aug 21, 2020 at 01:43:20PM +, Corentin Labbe wrote: > > + err = pm_runtime_get_sync(op->ss->dev); > + if (err < 0) > + goto error_pm; > + return 0; You need to handle the error case like this: https://patchwork.kernel.org/patch/11728595/ Cheers, -- Email: Her

Re: [PATCH 1/2] ASoC: wm8994: Skip setting of the WM8994_MICBIAS register for WM1811

2020-08-27 Thread Krzysztof Kozlowski
On Thu, Aug 27, 2020 at 07:33:56PM +0200, Sylwester Nawrocki wrote: > The WM8994_MICBIAS register is not available in the WM1811 CODEC so skip > initialization of that register for that device. > This suppresses an error during boot: > "wm8994-codec: ASoC: error at snd_soc_component_update_bits on

Re: [PATCH 3/3] clk: samsung: Use cached clk_hws instead of __clk_lookup() calls

2020-08-27 Thread Krzysztof Kozlowski
On Wed, Aug 26, 2020 at 07:15:29PM +0200, Sylwester Nawrocki wrote: > For the CPU clock registration two parent clocks are required, these > are now being passed as struct clk_hw pointers, rather than by the > global scope names. That allows us to avoid __clk_lookup() calls > and simplifies a bit

Re: [PATCH v2] x86: Use xorl %0,%0 in __get_user_asm

2020-08-27 Thread Uros Bizjak
On Thu, Aug 27, 2020 at 10:14 PM Al Viro wrote: > > On Thu, Aug 27, 2020 at 08:09:04PM +0200, Uros Bizjak wrote: > > xorl %0,%0 is equivalent to xorq %0,%0 as both will zero the > > entire register. Use xorl %0,%0 for all operand sizes to avoid > > REX prefix byte when legacy registers are used a

[PATCH] In the device tree file openbmc-flash-layout.dtsi, rofs partition offset is defined as 0x4c0000, while its node name is "rofs@c0000" which is a typo. It should be "rofs@4c0000".

2020-08-27 Thread Kun Zhao
ARM: dts: openbmc-flash-layout: Fix a typo of rofs offset Signed-off-by: Kun Zhao --- arch/arm/boot/dts/openbmc-flash-layout.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/openbmc-flash-layout.dtsi b/arch/arm/boot/dts/openbmc-flash-layout.dtsi index 6

Re: [PATCH v2 3/5] fpga manager: xilinx-spi: rework write_complete loop implementation

2020-08-27 Thread Luca Ceresoli
Hi Tom, On 27/08/20 21:34, Tom Rix wrote: > > On 8/27/20 12:26 PM, Luca Ceresoli wrote: >> Hi Tom, >> >> thanks for the prompt feedback! >> >> On 27/08/20 20:59, Tom Rix wrote: >>> On 8/27/20 7:32 AM, Luca Ceresoli wrote: In preparation to add error checking for gpiod_get_value(), rework >>>

[PATCH 2/2] pci: fix memleak when calling pci_iomap/unmap()

2020-08-27 Thread Yang Yingliang
config GENERIC_IOMAP is disabled on some archs(e.g. arm64), so pci_iounmap() does nothing, when we using pci_iomap/pci_iounmap(), it will lead to memory leak. Move pci_iounmap() to lib/pci_map.c to fix this. Signed-off-by: Yang Yingliang --- include/asm-generic/pci_iomap.h | 2 ++ lib/iomap.c

[PATCH 0/2] fix memleak when using pci_iounmap()

2020-08-27 Thread Yang Yingliang
config GENERIC_IOMAP is not selected on some arch, pci_iounmap() don't implement, when we using pci_iomap/pci_iounmap, it will lead to memory leak. This patch set moves the implemention of pci_iounmap() to lib/pci_iomap.c to fix this. Yang Yingliang (2): iomap: move some definitions to include/l

[PATCH 1/2] iomap: move some definitions to include/linux/io.h

2020-08-27 Thread Yang Yingliang
Move some IO macros and bad_io_access() to include/linux/io.h This prepares for moving pci_iounmap() to lib/pci_iomap.c. Signed-off-by: Yang Yingliang --- include/linux/io.h | 36 lib/iomap.c| 36 2 files changed,

Re: [PATCH v2] opp: Power on (virtual) power domains managed by the OPP core

2020-08-27 Thread Viresh Kumar
On 27-08-20, 13:44, Stephan Gerhold wrote: > Hmm. Actually I was using this parameter for initial testing, and forced > on the power domains from the qcom-cpufreq-nvmem driver. For my v1 patch > I wanted to enable the power domains in dev_pm_opp_set_rate(), so there > using the virt_devs parameter

Re: [PATCH 2/3] clk: samsung: exynos5420/5250: Add IDs to the CPU parent clk definitions

2020-08-27 Thread Krzysztof Kozlowski
On Wed, Aug 26, 2020 at 07:15:28PM +0200, Sylwester Nawrocki wrote: > Use non-zero clock IDs in definitions of the CPU parent clocks > for exynos5420, exynos5250 SoCs. This will allow us to reference > the parent clocks directly in the driver by cached struct clk_hw > pointers, rather than doing cl

Re: [PATCH 1/3] clk: samsung: Add clk ID definitions for the CPU parent clocks

2020-08-27 Thread Krzysztof Kozlowski
On Wed, Aug 26, 2020 at 07:15:27PM +0200, Sylwester Nawrocki wrote: > Add clock ID definitions for the CPU parent clocks for SoCs > which don't have such definitions yet. This will allow us to > reference the parent clocks directly by cached struct clk_hw > pointers in the clock provider, rather th

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-27 Thread Hoegeun Kwon
On 8/27/20 6:49 PM, Stefan Wahren wrote: > Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: >> Hi Stefan, >> >> Thank you for your review. >> >> >> On 8/26/20 7:04 PM, Stefan Wahren wrote: >>> Hi Hoeguen, >>> >>> Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: There is a problem that the output does not

Re: [PATCH v2 09/18] iio: afe: iio-rescale: Simplify with dev_err_probe()

2020-08-27 Thread Krzysztof Kozlowski
On Thu, Aug 27, 2020 at 11:46:40PM +0200, Peter Rosin wrote: > On 2020-08-27 21:26, Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and also it prints the error value. > > > > Signed-off-by: Krzysztof Kozlowski > > >

Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack

2020-08-27 Thread Florian Weimer
* H. J. Lu: > Can you think of ANY issues of passing more arguments to arch_prctl? On x32, the glibc arch_prctl system call wrapper only passes two arguments to the kernel, and applications have no way of detecting that. musl only passes two arguments on all architectures. It happens to work any

Re: Some questions about the patching process

2020-08-27 Thread Greg Kroah-Hartman
On Thu, Aug 27, 2020 at 02:17:20PM -0500, Qiushi Wu wrote: > Hi Greg, > Thanks for your response! You responded in html format which got rejected by the public list, please resend in text-only and I will be glad to reply. thanks, greg k-h

Re: [PATCH 1/4] drivers: hv: dxgkrnl: core code

2020-08-27 Thread Greg KH
On Thu, Aug 27, 2020 at 05:25:23PM -0700, Iouri Tarassov wrote: > > > +bool dxghwqueue_acquire_reference(struct dxghwqueue *hwqueue) > > > +{ > > > + return refcount_inc_not_zero(&hwqueue->refcount); > > > +} > > > > Midlayers are evil. > I strongly agree in general, but think that in our case the

Re: [PATCH 1/4] drivers: hv: dxgkrnl: core code

2020-08-27 Thread Greg KH
On Thu, Aug 27, 2020 at 05:25:23PM -0700, Iouri Tarassov wrote: > > > +{ > > > + struct dxgprocess_adapter *adapter_info = dxgmem_alloc(process, > > > + > > > DXGMEM_PROCESS_ADAPTER, > > > +

[PATCH] aio: make aio wait path to account iowait time

2020-08-27 Thread Xianting Tian
As the normal aio wait path(read_events() -> wait_event_interruptible_hrtimeout()) doesn't account iowait time, so use this patch to make it to account iowait time, which can truely reflect the system io situation when using a tool like 'top'. The test result as below. Test environment: A

Re: [PATCH 1/4] drivers: hv: dxgkrnl: core code

2020-08-27 Thread Greg KH
On Thu, Aug 27, 2020 at 04:45:55PM -0700, Iouri Tarassov wrote: > > On 8/14/2020 5:57 AM, Greg KH wrote: > > On Fri, Aug 14, 2020 at 08:38:53AM -0400, Sasha Levin wrote: > > > Add support for a Hyper-V based vGPU implementation that exposes the > > > DirectX API to Linux userspace. > > > > Api qu

Re: [PATCH 1/4] drivers: hv: dxgkrnl: core code

2020-08-27 Thread Greg KH
On Thu, Aug 27, 2020 at 05:05:44PM -0700, Iouri Tarassov wrote: > > On 8/14/2020 6:04 AM, Greg KH wrote: > > On Fri, Aug 14, 2020 at 08:38:53AM -0400, Sasha Levin wrote: > > > Add support for a Hyper-V based vGPU implementation that exposes the > > > DirectX API to Linux userspace. > > > > Signed-

[PATCH V2 5/8] spi: spi-geni-qcom: Unconditionally call dev_pm_opp_of_remove_table()

2020-08-27 Thread Viresh Kumar
dev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here. While at it, create a new label and put clkname on errors. Signed-off-by: V

[PATCH V2 1/8] cpufreq: imx6q: Unconditionally call dev_pm_opp_of_remove_table()

2020-08-27 Thread Viresh Kumar
dev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here. Signed-off-by: Viresh Kumar --- V2: No changes. --- drivers/cpufreq/imx6q

[PATCH V2 7/8] tty: serial: qcom_geni_serial: Unconditionally call dev_pm_opp_of_remove_table()

2020-08-27 Thread Viresh Kumar
dev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here. While at it, create a new label to put clkname on errors. Signed-off-by: Vi

[PATCH V2 8/8] qcom-geni-se: remove has_opp_table

2020-08-27 Thread Viresh Kumar
has_opp_table isn't used anymore, remove it. Signed-off-by: Viresh Kumar --- V2: No changes. --- include/linux/qcom-geni-se.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/qcom-geni-se.h b/include/linux/qcom-geni-se.h index 8f385fbe5a0e..02d1417c8ecf 100644 --- a/include/li

[PATCH V2 2/8] drm/lima: Unconditionally call dev_pm_opp_of_remove_table()

2020-08-27 Thread Viresh Kumar
dev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here. Reviewed-by: Qiang Yu Signed-off-by: Viresh Kumar --- V2: Applied Reviewe

[PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()

2020-08-27 Thread Viresh Kumar
dev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here. Signed-off-by: Viresh Kumar --- V2: - Compare with -ENODEV only for failur

[PATCH V2 6/8] spi: spi-qcom-qspi: Unconditionally call dev_pm_opp_of_remove_table()

2020-08-27 Thread Viresh Kumar
dev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here. While at it, create a new label and put clkname on errors. Signed-off-by: V

[PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()

2020-08-27 Thread Viresh Kumar
dev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here. While at it, also create a label to put clkname. Signed-off-by: Viresh Kuma

[PATCH V2 0/8] opp: Unconditionally call dev_pm_opp_of_remove_table()

2020-08-27 Thread Viresh Kumar
Hello, This cleans up some of the user code around calls to dev_pm_opp_of_remove_table(). All the patches can be picked by respective maintainers directly except for the last patch, which needs the previous two to get merged first. These are based for 5.9-rc1. Rajendra, Since most of these chan

Re: [PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread kernel test robot
Hi Chunguang, Thank you for the patch! Yet something to improve: [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on scsi/for-next block/for-next linus/master asm-generic/master v5.9-rc2 next-20200827] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'

2020-08-27 Thread Kalle Valo
Tony Chuang writes: >> + linux-wireless >> >> kernel test robot writes: >> >> > Hi Zong-Zhe, >> > >> > FYI, the error/warning still remains. >> > >> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> > head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7 >> >

Re: [PATCH 1/4] drivers: hv: dxgkrnl: core code

2020-08-27 Thread Greg KH
On Thu, Aug 27, 2020 at 04:29:59PM -0700, Iouri Tarassov wrote: > On 8/14/2020 5:55 AM, Greg KH wrote: > > On Fri, Aug 14, 2020 at 08:38:53AM -0400, Sasha Levin wrote: > > > Add support for a Hyper-V based vGPU implementation that exposes the > > > DirectX API to Linux userspace. > > > > Signed-off

Re: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-27 Thread Xu Yilun
On Wed, Aug 19, 2020 at 09:14:31PM -0700, Moritz Fischer wrote: > On Thu, Aug 13, 2020 at 05:04:09PM +0800, Xu Yilun wrote: > > On Thu, Aug 13, 2020 at 08:28:05AM +, David Laight wrote: > > > From: Xu Yilun > > > > Sent: 13 August 2020 08:59 > > > > On Wed, Aug 12, 2020 at 08:52:39AM +, Dav

[PATCH v2 5/5] powerpc/vdso: Declare vdso_patches[] as __initdata

2020-08-27 Thread Christophe Leroy
vdso_patches[] table is used only at init time. Mark it __initdata. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/vdso.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c index 4ad042995ccc..dfa08a7b4e7c 100644

[PATCH v2 2/5] powerpc/vdso: Don't rely on vdso_pages being 0 for failure

2020-08-27 Thread Christophe Leroy
If vdso initialisation failed, vdso_ready is not set. Otherwise, vdso_pages is only 0 when it is a 32 bits task and CONFIG_VDSO32 is not selected. As arch_setup_additional_pages() now bails out directly in that case, we don't need to set vdso_pages to 0. Signed-off-by: Christophe Leroy --- arch

[PATCH v2 4/5] powerpc/vdso: Declare constant vars as __ro_after_init

2020-08-27 Thread Christophe Leroy
To avoid any risk of modification of vital VDSO variables, declare them __ro_after_init. vdso32_kbase and vdso64_kbase could be made 'const', but it would have high impact on all functions using them as the compiler doesn't expect const property to be discarded. Signed-off-by: Christophe Leroy -

[PATCH v2 1/5] powerpc/vdso: Remove DBG()

2020-08-27 Thread Christophe Leroy
DBG() is defined as void when DEBUG is not defined, and DEBUG is explicitly undefined. It means there is no other way than modifying source code to get the messages printed. It was most likely useful in the first days of VDSO, but today the only 3 DBG() calls don't deserve a special handling. Ju

[PATCH v2 3/5] powerpc/vdso: Initialise vdso32_kbase at compile time

2020-08-27 Thread Christophe Leroy
Initialise vdso32_kbase at compile time like vdso64_kbase. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/vdso.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c index 8f245e988a8a..fb393266b9cb 100644 ---

Re: [PATCH v3 2/3] usb typec: mt6360: Rename driver/Kconfig/Makefile from mt6360 to mt636x

2020-08-27 Thread ChiYuan Huang
Guenter Roeck 於 2020年8月28日 週五 上午12:41寫道: > > On Thu, Aug 27, 2020 at 07:18:56PM +0800, cy_huang wrote: > > From: ChiYuan Huang > > > > 1. Rename file form tcpci_mt6360.c to tcpci_mt636x.c > > 2. Rename internal function from mt6360 to mt636x, except the register > > definition. > > 3. Change Kcon

[PATCH] f2fs: prevent compressed file from being disabled after releasing cblocks

2020-08-27 Thread Daeho Jeong
From: Daeho Jeong After releasing cblocks, the compressed file can be accidentally disabled in compression mode, since it has zero cblocks. As we are using IMMUTABLE flag to present released cblocks state, we can add IMMUTABLE state check when considering the compressed file disabling. Signed-of

Re: [PATCH v1 4/9] powerpc/vdso: Remove unnecessary ifdefs in vdso_pagelist initialization

2020-08-27 Thread Christophe Leroy
Le 28/08/2020 à 07:40, Christophe Leroy a écrit : Le 27/08/2020 à 15:19, Michael Ellerman a écrit : Christophe Leroy writes: On 08/26/2020 02:58 PM, Michael Ellerman wrote: Christophe Leroy writes: diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c index daef14a284a3.

[PATCH 0/1] Remove redundant condition for MTK_TIMER

2020-08-27 Thread Freddy Hsin
Remove the redundant condition of MTK_TIMER because the driver can work on MTK platform normally, so COMPILE_TEST is no longer needed for development purpose Freddy Hsin (1): timer: mt6873: remove COMPILE_TEST condition for MTK timer drivers/clocksource/Kconfig | 2 +- 1 file changed, 1 insert

[PATCH v1 1/1] timer: mt6873: remove COMPILE_TEST condition for MTK timer

2020-08-27 Thread Freddy Hsin
MTK timer driver can work on MTK platform normally, so remove the redundant condition for MTK_TIMER Signed-off-by: Freddy Hsin --- drivers/clocksource/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 91

Re: [PATCH v1 4/9] powerpc/vdso: Remove unnecessary ifdefs in vdso_pagelist initialization

2020-08-27 Thread Christophe Leroy
Le 27/08/2020 à 15:19, Michael Ellerman a écrit : Christophe Leroy writes: On 08/26/2020 02:58 PM, Michael Ellerman wrote: Christophe Leroy writes: diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c index daef14a284a3..bbb69832fd46 100644 --- a/arch/powerpc/kernel/vdso.c

Re: [PATCH 09/23] cachefiles: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread kernel test robot
Hi Chunguang, Thank you for the patch! Yet something to improve: [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on scsi/for-next block/for-next linus/master asm-generic/master v5.9-rc2 next-20200827] [If your patch is applied to the wrong git tree, kindly drop us a note

linux-next: Tree for Aug 28

2020-08-27 Thread Stephen Rothwell
Hi all, News: There will be no linux-next releases next Monday or Tuesday. Changes since 20200827: The net-next tree gained a conflict against the net tree. Non-merge commits (relative to Linus' tree): 3122 3668 files changed, 104159 insertions(+), 39605 dele

Re: [PATCH v18 00/32] per memcg lru_lock

2020-08-27 Thread Alex Shi
在 2020/8/28 上午9:40, Daniel Jordan 写道: > I went back to your v1 post to see what motivated you originally, and you had > some results from aim9 but nothing about where this reared its head in the > first place. How did you discover the bottleneck? I'm just curious about how > lru_lock hurts in p

Re: Aw: Re: [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701

2020-08-27 Thread Frank Wunderlich
Without this patch i have flickering/horizontal distortion (looks line every second line has different x position as one above approx. 5 px) on my 1280x1024 tft. Fbcon is unreadable with this problem. Hard to describe by words only :( Am 28. August 2020 01:46:07 MESZ schrieb Chun-Kuang Hu : >

Re: [PATCH 6/6] gpio: zynq: Simplify with dev_err_probe()

2020-08-27 Thread Michal Simek
On 27. 08. 20 22:08, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpio/gpio-zynq.c | 8 +++- > 1 file changed, 3 insert

Re: [PATCH] mmc: sdhci-msm: When dev_pm_opp_of_add_table() returns 0 it's not an error

2020-08-27 Thread Viresh Kumar
On 27-08-20, 08:33, Douglas Anderson wrote: > The commit d05a7238fe1c ("mmc: sdhci-msm: Unconditionally call > dev_pm_opp_of_remove_table()") works fine in the case where there is > no OPP table. However, if there is an OPP table then > dev_pm_opp_of_add_table() will return 0. Since 0 != -ENODEV

Re: Printing bitfields in the kernel (Re: [PATCH] drm: Parse Colorimetry data block from EDID)

2020-08-27 Thread Joe Perches
On Thu, 2020-08-27 at 10:34 +0300, Pekka Paalanen wrote: > On Wed, 26 Aug 2020 22:23:28 +0800 > Algea Cao wrote: > > > CEA 861.3 spec adds colorimetry data block for HDMI. > > Parsing the block to get the colorimetry data from > > panel. If flags are int, I could imagine another %p extension whe

Re: [RFC 0/2] Add risc-v vhost-net support

2020-08-27 Thread Anup Patel
On Fri, Jul 24, 2020 at 2:25 PM Yifei Jiang wrote: > > Hi, > > These two patches enable support for vhost-net on RISC-V architecture. They > are developed > based on the Linux source in this repo: https://github.com/avpatel/linux, > the branch is riscv_kvm_v13. > > The accompanying QEMU is from t

possible deadlock in proc_pid_syscall (2)

2020-08-27 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:15bc20c6 Merge tag 'tty-5.9-rc3' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15349f9690 kernel config: https://syzkaller.appspot.com/x/.config?x=978db74cb30aa994 das

Re: [PATCH RFC 2/2] target/kvm: Add interfaces needed for log dirty

2020-08-27 Thread Anup Patel
On Thu, Aug 27, 2020 at 1:54 PM Yifei Jiang wrote: > > Add two interfaces of log dirty for kvm_main.c, and detele the interface > kvm_vm_ioctl_get_dirty_log which is redundantly defined. > > CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT is added in defconfig. > > Signed-off-by: Yifei Jiang > Signed-of

Re: WARNING: at drivers/opp/core.c:678 dev_pm_opp_set_rate+0x4cc/0x5d4 - on arm x15

2020-08-27 Thread Viresh Kumar
On 27-08-20, 21:18, Stephen Rothwell wrote: > Hi Viresh, > > On Thu, 27 Aug 2020 15:16:51 +0530 Viresh Kumar > wrote: > > > > On 27-08-20, 15:04, Naresh Kamboju wrote: > > > While boot testing arm x15 devices the Kernel warning noticed with linux > > > next > > > tag 20200825. > > > > > > BAD:

Loan

2020-08-27 Thread mendes . maia
Hello, You can review your loan agreements immediately and you never need to visit a branch. We offer a loan with an interest rate of 2% per annul. Quick payout, apply now within 48 hours, the offer covers all types of loans and the offer is open to blacklisted people. This can elevate your b

Re: [PATCH RFC 1/2] riscv/kvm: Fix use VSIP_VALID_MASK mask HIP register

2020-08-27 Thread Anup Patel
On Thu, Aug 27, 2020 at 1:53 PM Yifei Jiang wrote: > > The correct sip/sie 0x222 could mask wrong 0x000 by VSIP_VALID_MASK, > This patch fix it. > > Signed-off-by: Yifei Jiang > Signed-off-by: Yipeng Yin > --- > arch/riscv/kvm/vcpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [PATCH v2 3/3] riscv: Add cache information in AUX vector

2020-08-27 Thread kernel test robot
Hi Zong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.9-rc2 next-20200827] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [RFC][PATCH 3/7] kprobes: Remove kretprobe hash

2020-08-27 Thread Masami Hiramatsu
On Thu, 27 Aug 2020 18:12:40 +0200 Peter Zijlstra wrote: > @@ -1313,25 +1261,28 @@ void kprobe_busy_end(void) > void kprobe_flush_task(struct task_struct *tk) > { > struct kretprobe_instance *ri; > - struct hlist_head *head, empty_rp; > + struct hlist_head empty_rp; > + struct

[PATCH v4] power: supply: sbs-battery: don't assume i2c errors as battery disconnect

2020-08-27 Thread Ikjoon Jang
Current sbs-battery considers all smbus errors as disconnection events when battery-detect pin isn't supplied, and restored to present state back when any successful transaction is made. This can lead to unwanted state changes between present and !present when there's one i2c error and other follo

Re: [PATCH 17/19] z2ram: reindent

2020-08-27 Thread Christoph Hellwig
On Fri, Aug 28, 2020 at 10:57:46AM +1000, Finn Thain wrote: > On Thu, 27 Aug 2020, Joe Perches wrote: > > > > > checkpatch already does this. > > > > Did you use checkpatch to generate this patch? I used scripts/Lindent.

Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-08-27 Thread Christoph Hellwig
On Thu, Aug 27, 2020 at 10:11:53PM -0400, Rich Felker wrote: > > This change broke SD card support on J2 because MMC_SPI spuriously > > depends on HAS_DMA. It looks like it can be fixed just by removing > > that dependency from drivers/mmc/host/Kconfig. > > It can't. mmp_spi_probe fails with ENOME

RE: [PATCH 1/2] dt-bindings: pwm: renesas,pwm-rcar: Add r8a774e1 support

2020-08-27 Thread Yoshihiro Shimoda
Hi Lad-san, > From: Lad Prabhakar, Sent: Tuesday, August 25, 2020 7:45 PM > > From: Marian-Cristian Rotariu > > Document RZ/G2H (R8A774E1) SoC bindings. > > No driver change is needed due to the fallback compatible value > "renesas,pwm-rcar". > > Signed-off-by: Marian-Cristian Rotariu > > S

Re: [Cocci] [PATCH] usb: atm: don't use snprintf() for sysfs attrs

2020-08-27 Thread Joe Perches
On Thu, 2020-08-27 at 15:45 -0700, Joe Perches wrote: > On Thu, 2020-08-27 at 15:20 -0700, Kees Cook wrote: > > On Fri, Aug 28, 2020 at 12:01:34AM +0300, Denis Efremov wrote: > > > Just FYI, I've send an addition to the device_attr_show.cocci script[1] > > > to turn > > > simple cases of snprintf

Re: [RFC][PATCH 6/7] freelist: Lock less freelist

2020-08-27 Thread Lai Jiangshan
On Fri, Aug 28, 2020 at 12:23 AM Peter Zijlstra wrote: > +static inline void __freelist_add(struct freelist_node *node, struct > freelist_head *list) > +{ > + /* > +* Since the refcount is zero, and nobody can increase it once it's > +* zero (except us, and we run only one

[PATCH] f2fs: make fibmap consistent with fiemap for compression chunk

2020-08-27 Thread Daeho Jeong
From: Daeho Jeong Currently fibmap returns zero address for compression chunk. But it is not consistent with the output of fiemap, since fiemap returns real pysical block address related to the compression chunk. Therefore I suggest fibmap returns the same output with fiemap. Signed-off-by: Daeh

Re: [Patch v2 0/4] tracing: trivial cleanup

2020-08-27 Thread Wei Yang
Steven, Would you like to pick this up? On Sun, Jul 12, 2020 at 09:10:32AM +0800, Wei Yang wrote: >Some trivial cleanup for tracing. > >v2: > * drop patch 1 > * merge patch 4 & 5 > * introduce a new patch change the return value of tracing_init_dentry() > >Wei Yang (4): > tracing: simplify th

Re: [PATCH bpf-next v1 8/8] bpf/selftests: Test for bpf_per_cpu_ptr()

2020-08-27 Thread Hao Luo
Thanks for taking a look! On Fri, Aug 21, 2020 at 8:30 PM Andrii Nakryiko wrote: > > On Wed, Aug 19, 2020 at 3:42 PM Hao Luo wrote: > > > > Test bpf_per_cpu_ptr(). Test two paths in the kernel. If the base > > pointer points to a struct, the returned reg is of type PTR_TO_BTF_ID. > > Direct poin

[PATCH net-next v2 3/3] hinic: add support to query function table

2020-08-27 Thread Luo bin
add debugfs node for querying function table, for example: cat /sys/kernel/debug/hinic/:15:00.0/func_table/valid Signed-off-by: Luo bin --- V0~V1: - remove command interfaces to the read only files - split addition of each object into a separate patch V1~V2: - remove vlan_id and vlan_mode fr

[PATCH net-next v2 2/3] hinic: add support to query rq info

2020-08-27 Thread Luo bin
add debugfs node for querying rq info, for example: cat /sys/kernel/debug/hinic/:15:00.0/RQs/0x0/rq_hw_pi Signed-off-by: Luo bin --- V0~V1: - remove command interfaces to the read only files - split addition of each object into a separate patch .../net/ethernet/huawei/hinic/hinic_debugfs.c

[PATCH net-next v2 1/3] hinic: add support to query sq info

2020-08-27 Thread Luo bin
add debugfs node for querying sq info, for example: cat /sys/kernel/debug/hinic/:15:00.0/SQs/0x0/sq_pi Signed-off-by: Luo bin --- V0~V1: - remove command interfaces to the read only files - split addition of each object into a separate patch drivers/net/ethernet/huawei/hinic/Makefile|

[PATCH net-next v2 0/3] hinic: add debugfs support

2020-08-27 Thread Luo bin
add debugfs node for querying sq/rq info and function table Luo bin (3): hinic: add support to query sq info hinic: add support to query rq info hinic: add support to query function table drivers/net/ethernet/huawei/hinic/Makefile| 3 +- .../net/ethernet/huawei/hinic/hinic_debugfs.c

[Patch v2 4/7] mm/hugetlb: count file_region to be added when regions_needed != NULL

2020-08-27 Thread Wei Yang
There are only two cases of function add_reservation_in_range() * count file_region and return the number in regions_needed * do the real list operation without counting This means it is not necessary to have two parameters to classify these two cases. Just use regions_needed to separate

[PATCH] ubifs: setflags: Don't show error message when vfs_ioc_setflags_prepare() fails

2020-08-27 Thread Zhihao Cheng
Following process will trigger ubifs_err: 1. useradd -m freg(Under root) 2. cd /home/freg && mkdir mp (Under freg) 3. mount -t ubifs /dev/ubi0_0 /home/freg/mp (Under root) 4. cd /home/freg && echo 123 > mp/a

[Patch v2 5/7] mm/hugetlb: a page from buddy is not on any list

2020-08-27 Thread Wei Yang
The page allocated from buddy is not on any list, so just use list_add() is enough. Signed-off-by: Wei Yang Reviewed-by: Baoquan He Reviewed-by: Mike Kravetz --- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index bbccbfeb8601..5a7

[Patch v2 0/7] mm/hugetlb: code refine and simplification

2020-08-27 Thread Wei Yang
Following are some cleanup for hugetlb. Simple test with tools/testing/selftests/vm/map_hugetlb pass. v2: * drop 5/6/10 since similar patches are merged or under review. * adjust 2 based on comment from Mike Kravetz Wei Yang (7): mm/hugetlb: not necessary to coalesce regions recursively

[Patch v2 7/7] mm/hugetlb: narrow the hugetlb_lock protection area during preparing huge page

2020-08-27 Thread Wei Yang
set_hugetlb_cgroup_[rsvd] just manipulate page local data, which is not necessary to be protected by hugetlb_lock. Let's take this out. Signed-off-by: Wei Yang Reviewed-by: Baoquan He Reviewed-by: Mike Kravetz --- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Patch v2 3/7] mm/hugetlb: use list_splice to merge two list at once

2020-08-27 Thread Wei Yang
Instead of add allocated file_region one by one to region_cache, we could use list_splice to merge two list at once. Also we know the number of entries in the list, increase the number directly. Signed-off-by: Wei Yang Reviewed-by: Baoquan He Reviewed-by: Mike Kravetz --- mm/hugetlb.c | 7 ++-

[Patch v2 6/7] mm/hugetlb: return non-isolated page in the loop instead of break and check

2020-08-27 Thread Wei Yang
Function dequeue_huge_page_node_exact() iterates the free list and return the first non-isolated one. Instead of break and check the loop variant, we could return in the loop directly. This could reduce some redundant check. Signed-off-by: Wei Yang Reviewed-by: Mike Kravetz --- mm/hugetlb.c |

[Patch v2 1/7] mm/hugetlb: not necessary to coalesce regions recursively

2020-08-27 Thread Wei Yang
Per my understanding, we keep the regions ordered and would always coalesce regions properly. So the task to keep this property is just to coalesce its neighbour. Let's simplify this. Signed-off-by: Wei Yang Reviewed-by: Baoquan He Reviewed-by: Mike Kravetz --- mm/hugetlb.c | 6 +- 1 file

[Patch v2 2/7] mm/hugetlb: remove VM_BUG_ON(!nrg) in get_file_region_entry_from_cache()

2020-08-27 Thread Wei Yang
We are sure to get a valid file_region, otherwise the VM_BUG_ON(resv->region_cache_count <= 0) at the very beginning would be triggered. Let's remove the redundant one. Signed-off-by: Wei Yang --- mm/hugetlb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index

[PATCH v2] media: uvcvideo: Convey full colorspace information to V4L2

2020-08-27 Thread Adam Goode
The Color Matching Descriptor has been present in USB cameras since the original version of UVC, but it has never been fully exposed in Linux. This change informs V4L2 of all of the UVC colorspace parameters: color primaries, transfer characteristics, and YCbCr encoding. videodev2.h doesn't have v

Re: [PATCH v3] mm: Fix kthread_use_mm() vs TLB invalidate

2020-08-27 Thread Nicholas Piggin
Excerpts from pet...@infradead.org's message of August 21, 2020 11:04 pm: > On Fri, Aug 21, 2020 at 11:09:51AM +0530, Aneesh Kumar K.V wrote: >> Peter Zijlstra writes: >> >> > For SMP systems using IPI based TLB invalidation, looking at >> > current->active_mm is entirely reasonable. This then pr

Re: [PATCH net-next v1 3/3] hinic: add support to query function table

2020-08-27 Thread luobin (L)
On 2020/8/28 3:44, Jakub Kicinski wrote: > On Thu, 27 Aug 2020 19:13:21 +0800 Luo bin wrote: >> +switch (idx) { >> +case VALID: >> +return funcfg_table_elem->dw0.bs.valid; >> +case RX_MODE: >> +return funcfg_table_elem->dw0.bs.nic_rx_mode; >> +case MTU: >> +

[PATCH v2] stackleak: Fix a race between stack erasing sysctl handlers

2020-08-27 Thread Muchun Song
There is a race between the assignment of `table->data` and write value to the pointer of `table->data` in the __do_proc_doulongvec_minmax() on the other thread. CPU0: CPU1: proc_sys_write stack_erasing_sysctl

Re: [PATCH] coresight: cti: write regsiters directly in cti_enable_hw()

2020-08-27 Thread Tingwei Zhang
On Fri, Aug 28, 2020 at 02:12:53AM +0800, Mathieu Poirier wrote: > Hi Tingwei, > > On Tue, Aug 18, 2020 at 07:10:57PM +0800, Tingwei Zhang wrote: > > Deadlock as below is triggered by one CPU holds drvdata->spinlock > > and calls cti_enable_hw(). Smp_call_function_single() is called > > in cti_ena

[PATCH] arm64: fix some spelling mistakes in the comments by codespell

2020-08-27 Thread Xiaoming Ni
arch/arm64/include/asm/cpu_ops.h:24: necesary ==> necessary arch/arm64/include/asm/kvm_arm.h:69: maintainance ==> maintenance arch/arm64/include/asm/cpufeature.h:361: capabilties ==> capabilities arch/arm64/kernel/perf_regs.c:19: compatability ==> compatibility arch/arm64/kernel/smp_spin_table.c:86

Re: [PATCH] net: dsa: mt7530: fix advertising unsupported

2020-08-27 Thread Florian Fainelli
On 8/27/2020 2:15 AM, Landen Chao wrote: 1000baseT_Half Looks like this part of the commit subject spilled into the commit message. Remove 1000baseT_Half to advertise correct hardware capability in phylink_validate() callback function. Fixes: 38f790a80560 ("net: dsa: mt7530: Add support

possible deadlock in proc_pid_stack (2)

2020-08-27 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:494d311a Add linux-next specific files for 20200821 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1644d50e90 kernel config: https://syzkaller.appspot.com/x/.config?x=a61d44f28687f508 dashboard

Results from the 2020 Linux Foundation Technical Advisory Board election

2020-08-27 Thread Jonathan Corbet
This year's election for the Linux Foundation Technical Advisory Board had 955 authorized voters; 235 of them cast ballots. The results were: 1: Laura Abbott 2: Kees Cook 3: Dan Williams 4: Christian Brauner 5: Chris Mason 6: Olof Johan

[PATCH v2] mm/hugetlb: Fix a race between hugetlb sysctl handlers

2020-08-27 Thread Muchun Song
There is a race between the assignment of `table->data` and write value to the pointer of `table->data` in the __do_proc_doulongvec_minmax() on the other thread. CPU0: CPU1: proc_sys_write hugetlb_sysctl_handler

  1   2   3   4   5   6   7   8   9   10   >