...@goodmis.org/
- Rebased on mainline and some minor clean ups.
- Fixed kprobe selftest
Steven Rostedt (Google) (3):
tracefs: Add show_events_dentries
eventfs: Remove eventfs_file and just use eventfs_inode
tracing/selftests: Update kprobe args char/string to match new functions
fs
From: "Steven Rostedt (Google)"
Add a file in tracefs that shows the "events" allocated entries and the
dentries that are attached to them. This is used to see what dentries have
been dynamically allocated as well as their current ref counts.
~# cat /sys/kernel/
On Tue, 12 Sep 2023 21:47:52 +0800
Jinjie Ruan wrote:
> v5:
> - Move the ef below dir to keep the "upside-down x-mas tree" format.
That was quick!
I'll add it to my queue and start testing it.
Thanks Ruan!
-- Steve
On Tue, 12 Sep 2023 10:58:08 +0800
Jinjie Ruan wrote:
This looks good. But I have a small nit.
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index ed367d713be0..8e0593d4c6a6 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -2296,6
On Mon, 11 Sep 2023 09:26:12 +0900
Masami Hiramatsu (Google) wrote:
> > Fix this and just to be safe also add "__packed".
> >
> > Link:
> > https://lore.kernel.org/all/20230908154417.5172e...@gandalf.local.home/
>
> Good catch! I'm not sure why this worked. Maybe we don't have any testcase
On Mon, 11 Sep 2023 12:00:53 +0900
Masami Hiramatsu (Google) wrote:
> But it seems correctly taking srcu_read_lock().
>
> 452
> 453 ei = ti->private;
> 454 idx = srcu_read_lock(_srcu);
> 455 list_for_each_entry_rcu(ef, >e_top_files, list) {
> 456
On Mon, 11 Sep 2023 20:36:42 +
SeongJae Park wrote:
> > Then tracing is fully enabled here, and now we enter:
> >
> > if (trace_damos_before_apply_enabled()) {
> > trace_damos_before_apply(cidx, sidx, tidx, r,
> > damon_nr_regions(t));
> > }
>
On Tue, 12 Sep 2023 01:43:08 +
SeongJae Park wrote:
> Nevertheless, since the variable is unsigned int, I would need to use UINT_MAX
> instead. To make the code easier to understand, I'd prefer to add a third
> parameter, as you suggested as another option at the original reply, like
>
On Mon, 11 Sep 2023 20:51:25 +0900
Masami Hiramatsu (Google) wrote:
> Instead,
>
> ef = eventfs_add_subsystem_dir(name, parent);
> if (IS_ERR(ef)) {
> ...
> } else
> dir->ef = ef;
Note, as the error has a goto out_free, it just needs to be:
From: "Steven Rostedt (Google)"
The eventfs files list is protected by SRCU. In earlier iterations it was
protected with just RCU, but because it needed to also call sleepable
code, it had to be switch to SRCU. The dcache_dir_open_wrapper()
list_for_each_rcu() was missed and d
From: "Steven Rostedt (Google)"
The eventfs files list is protected by SRCU. In earlier iterations it was
protected with just RCU, but because it needed to also call sleepable
code, it had to be switch to SRCU. The dcache_dir_open_wrapper()
list_for_each_rcu() was missed and d
On Mon, 11 Sep 2023 04:59:07 +
SeongJae Park wrote:
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -950,6 +950,28 @@ static void damos_apply_scheme(struct damon_ctx *c,
> struct damon_target *t,
> struct timespec64 begin, end;
> unsigned long sz_applied = 0;
> int
On Mon, 11 Sep 2023 19:05:04 +
SeongJae Park wrote:
> > Also, this if statement is only done when the trace event is enabled, so
> > it's equivalent to:
> >
> > if (trace_damos_before_apply_enabled()) {
> > if (sdx >= 0)
> > trace_damos_before_apply(cidx,
On Sat, 9 Sep 2023 18:36:39 +0900
"Masami Hiramatsu (Google)" wrote:
> From: Masami Hiramatsu (Google)
>
> Fix to unmount the tracefs if the ftracetest mounted it for recovering
> system environment. If the tracefs is already mounted, this does nothing.
>
> Suggested-by: Mark Brown
> Link:
Added the Perf folks as this is a perf event probe. From the call trace:
[ 59.695946] [ cut here ]
[ 59.696788] WARNING: CPU: 0 PID: 1199 at kernel/tracepoint.c:143
tracepoint_probe_register_prio+0x2f0/0x360
[ 59.698385] Modules linked in: rapl input_leds
On Tue, 20 Apr 2021 12:54:39 -0700
Dan Williams wrote:
> On Tue, Apr 20, 2021 at 5:55 AM Steven Rostedt wrote:
> > >
> > > The dev_dbg() filter language is attractive, it's too bad
> >
> > Not sure what you mean by that. What filter language. Tracepoints do
: 39ed1af76146f9f995c224de1987f14babc9aa28
Head SHA1: 0e1e71d34901a633825cd5ae78efaf8abd9215c6
Steven Rostedt (VMware) (1):
tracing: Fix checking event hash pointer logic when tp_printk is enabled
kernel/trace/trace.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions
On Tue, 20 Apr 2021 11:15:10 -0400 (EDT)
Mathieu Desnoyers wrote:
> That sounds fine. So that would be within the "trace_event" (and not
> tracepoint)
> namespace for module load parameters as well ?
Right, it would be "trace_event=" not "tracepoint=..."
-- Steve
On Tue, 20 Apr 2021 09:29:27 -0400 (EDT)
Mathieu Desnoyers wrote:
> - On Apr 20, 2021, at 8:55 AM, rostedt rost...@goodmis.org wrote:
> [...]
> >
> > Would adding automatic module parameters be an issue? That is, you can add
> > in the insmod command line a parameter that will enable
On Mon, 19 Apr 2021 18:25:54 -0700
Dan Williams wrote:
> On Mon, Apr 19, 2021 at 3:11 PM Steven Rostedt wrote:
> >
> > On Mon, 19 Apr 2021 21:54:13 +
> > "Williams, Dan J" wrote:
> >
> > > [ drop Rusty, add Jessica and Emmanuel ]
> &
Dear RT Folks,
I'm pleased to announce the 5.10.30-rt37 stable release.
This release is just an update to the new stable 5.10.30 version
and no RT specific changes have been made.
You can get this release via the git tree at:
On Mon, 19 Apr 2021 21:54:13 +
"Williams, Dan J" wrote:
> [ drop Rusty, add Jessica and Emmanuel ]
Probably could have kept Jessica on as she's the module maintainer.
>
> On Wed, 2013-08-14 at 23:32 -0400, Steven Rostedt wrote:
> > On Thu, 15 Aug 2013 11:32:10 +
On Mon, 19 Apr 2021 14:08:14 +0100
Jon Hunter wrote:
> I have encountered the following crash on a couple of our ARM64 Jetson
> platforms and bisect is pointing to this change. The crash I am seeing
> is on boot when I am directing the trace prints to the console by adding
> 'tp_printk
From: "Steven Rostedt (VMware)"
The func_repeats event shows the output of the function tracer followed by
a count of the number of repeats the previous function had made, as well
as the timestamp of the last function that was repeated.
The printing of the function should b
following by event showing the number of repeats.
Link: https://lkml.kernel.org/r/20210415181854.147448-7-y.kar...@gmail.com
Signed-off-by: Yordan Karadzhov (VMware)
Signed-off-by: Steven Rostedt (VMware)
---
kernel/trace/trace_functions.c | 162 -
1 file ch
that new
options can be easily added.
Link: https://lkml.kernel.org/r/20210415181854.147448-6-y.kar...@gmail.com
Signed-off-by: Yordan Karadzhov (VMware)
Signed-off-by: Steven Rostedt (VMware)
---
kernel/trace/trace_functions.c | 65 --
1 file changed, 38 insert
ov (VMware)
Signed-off-by: Steven Rostedt (VMware)
---
kernel/trace/trace.c | 34 ++
kernel/trace/trace.h | 4
2 files changed, 38 insertions(+)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 82833be07c1e..66a4ad93b5e9 100644
--- a/kernel/trace/tra
ink: https://lkml.kernel.org/r/20210415181854.147448-4-y.kar...@gmail.com
Signed-off-by: Yordan Karadzhov (VMware)
Signed-off-by: Steven Rostedt (VMware)
---
kernel/trace/trace.c | 1 +
kernel/trace/trace.h | 12
2 files changed, 13 insertions(+)
diff --git a/kernel/trace/trace.c b/ke
ot;func_repeats". The new static method,
defined here, will be used by this new event to print the time of the
last repeat of a function that is consecutively called number of times.
Link: https://lkml.kernel.org/r/20210415181854.147448-2-y.kar...@gmail.com
Signed-off-by: Yordan Karadzhov (VMware)
).
The new ftrace event can be used to show repeated function events with
a single event and save space on the ring buffer
Link: https://lkml.kernel.org/r/20210415181854.147448-3-y.kar...@gmail.com
Signed-off-by: Yordan Karadzhov (VMware)
Signed-off-by: Steven Rostedt (VMware)
---
kernel/tra
Steven Rostedt (VMware) , Yordan Karadzhov (VMware)
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
for-next
Head SHA1: e1db6338d6fa0d409e45cf20ab5aeaca704f68e7
Steven Rostedt (VMware) (1):
ftrace: Reuse the output of the function tracer for func_repeats
Yordan
On Fri, 16 Apr 2021 10:12:58 -0500
Josh Poimboeuf wrote:
> Adding Steven Rostedt (ftrace maintainer).
Thanks.
>
> On Fri, Apr 16, 2021 at 01:39:28PM +0800, zhaoxiao wrote:
> > In preparation for x86 supporting ftrace built on other compiler
> > options, let's have the
On Fri, 16 Apr 2021 09:51:45 +0200
Dmitry Vyukov wrote:
>
> If you look at substantial base of bisection logs, you will find lots
> of cases where bug types, functions don't match. Kernel crashes
> differently even on the same revision. And obviously things change if
> you change revisions. Also
On Thu, 15 Apr 2021 15:22:52 +0200
Daniel Bristot de Oliveira wrote:
> >> --- a/kernel/trace/trace_hwlat.c
> >> +++ b/kernel/trace/trace_hwlat.c
> >> @@ -34,7 +34,7 @@
> >> * Copyright (C) 2008-2009 Jon Masters, Red Hat, Inc.
> >> * Copyrig
On Thu, 15 Apr 2021 15:16:04 +0200
Daniel Bristot de Oliveira wrote:
> That was my initial intention with the NONE mode, but I feared breaking
> something by removing the "migrate_disable" logic. If you do not think it is
> a problem, I will remove the migrate disable and just change the mode.
On Thu, 15 Apr 2021 15:09:50 +0200
Daniel Bristot de Oliveira wrote:
> But for the osnoise tracer the cpus file is really useful. For instance, on a
> system with the CPU 7 isolated:
>
> - %< -
> # echo 7 > osnoise/cpus
> # echo target_cpu == 7 > events/sched/sched_wakeup/filter
>
sample_threshold. The reason roots in the tracing overhead and in
> the overhead of the entry and exit code that happens before and after
> any interference execution. This justifies the dual approach: measuring
> thread and tracing.
I'm not sure the tracing overhead had much to do
running on multiple CPUs at the same time.
And totally slow down the entire system in the process ;-)
>
> Cc: Jonathan Corbet
> Cc: Steven Rostedt
> Cc: Ingo Molnar
> Cc: Peter Zijlstra
> Cc: Thomas Gleixner
> Cc: Alexandre Chartre
> Cc: Clark Willaims
> Cc: John Kacu
On Thu, 8 Apr 2021 16:13:20 +0200
Daniel Bristot de Oliveira wrote:
> +/**
> + * hwlat_mode_write - Write function for "mode" entry
> + * @filp: The active open file structure
> + * @ubuf: The user buffer that contains the value to write
> + * @cnt: The maximum number of bytes to write to
On Thu, 8 Apr 2021 16:13:19 +0200
Daniel Bristot de Oliveira wrote:
> Provides a "cpus" interface to the hardware latency detector. By
> default, it lists all CPUs, allowing hwlatd threads to run on any online
> CPU of the system.
>
> It serves to restrict the execution of hwlatd to the set of
by: Masami Hiramatsu
Signed-off-by: Christophe JAILLET
Signed-off-by: Steven Rostedt (VMware)
diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
index dc971a68dda4..e57cc0870892 100644
--- a/kernel/trace/trace_dynevent.c
+++ b/kernel/trace/trace_dynevent.c
@@
On Tue, 13 Apr 2021 15:17:36 -0400
Steven Rostedt wrote:
> Running this with trace-cmd record, this displays:
>
> -0 [001] 261.848848: function:
> next_zone
> -0 [001] 261.848849: func_repeats: next_zone
On Tue, 13 Apr 2021 15:17:36 -0400
Steven Rostedt wrote:
> Running this with trace-cmd record, this displays:
>
> -0 [001] 261.848848: function:
> next_zone
> -0 [001] 261.848849: func_repeats: next_zone
On Fri, 9 Apr 2021 21:10:27 +0300
"Yordan Karadzhov (VMware)" wrote:
> ---
> kernel/trace/trace.h | 3 +++
> kernel/trace/trace_entries.h | 22 +
> kernel/trace/trace_output.c | 47
> 3 files changed, 72 insertions(+)
>
> diff
On Tue, 13 Apr 2021 14:40:09 -0400
Steven Rostedt wrote:
> [ cut here ]
> raw_local_irq_restore() called with IRQs enabled
> WARNING: CPU: 0 PID: 8777 at kernel/locking/irqflag-debug.c:9
> warn_bogus_irq_restore kernel/locking/irqflag-debug.c:9 [inline]
>
On Tue, 13 Apr 2021 20:24:00 +0200
Dmitry Vyukov wrote:
> On Tue, Apr 13, 2021 at 7:43 PM Steven Rostedt wrote:
> >
> > On Tue, 13 Apr 2021 13:41:47 -0400
> > Steven Rostedt wrote:
> >
> > > As the below splats look like it has nothing to do with this
On Fri, 9 Apr 2021 21:10:28 +0300
"Yordan Karadzhov (VMware)" wrote:
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -262,6 +262,17 @@ struct cond_snapshot {
> cond_update_fn_tupdate;
> };
>
> +/*
> + * struct trace_func_repeats - used to keep track of
On Fri, 9 Apr 2021 21:10:29 +0300
"Yordan Karadzhov (VMware)" wrote:
> @@ -342,6 +342,12 @@ FTRACE_ENTRY(hwlat, hwlat_entry,
> #define FUNC_REPEATS_GET_DELTA_TS(entry) \
> (((u64)entry->top_delta_ts << 32) | entry->bottom_delta_ts) \
>
> +#define
On Fri, 9 Apr 2021 21:10:27 +0300
"Yordan Karadzhov (VMware)" wrote:
> The event aims to consolidate the function tracing record in the cases
> when a single function is called number of times consecutively.
>
> while (cond)
> do_func();
>
> This may happen in various
On Tue, 13 Apr 2021 13:41:47 -0400
Steven Rostedt wrote:
> As the below splats look like it has nothing to do with this patch, and
> this patch will add a WARN() if there's broken logic somewhere, I bet the
> bisect got confused (if it is automated and does a panic_on_warning),
On Tue, 13 Apr 2021 10:33:19 -0700
syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:e99d8a84 Add linux-next specific files for 20210409
> git tree: linux-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=13b01681d0
> kernel config:
On Tue, 13 Apr 2021 10:36:07 +0200
Dietmar Eggemann wrote:
> > @@ -897,11 +897,6 @@ DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> > struct rq {
> > /* runqueue lock: */
> > raw_spinlock_t lock;
> > -
> > - /*
> > -* nr_running and cpu_load should be in the same cacheline
On Tue, 13 Apr 2021 09:56:40 +0200
Dmitry Vyukov wrote:
> Thanks for looking into this.
> If this is not a kernel bug, then it must not use WARN_ON[_ONCE]. It
> makes the kernel untestable for both automated systems and humans:
>
> https://lwn.net/Articles/769365/
>
>
> Greg Kroah-Hartman
This is the initial official release of libtracecmd 1.0.0. This is
needed by KernelShark in order to be in a stand alone repository:
https://git.kernel.org/pub/scm/utils/trace-cmd/kernel-shark.git/
All new development for KernelShark now takes place in the above
repository, which will depend
I'm pleased to announce the new version of libtracefs library has been
released:
libtracefs: 1.1.0
https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/snapshot/libtracefs-1.1.0.tar.gz
https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
Changes since 1.0.2:
- Depends on
I'm pleased to announce the new version of libtraceevent library has been
released:
libtraceevent: 1.2.0
https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/snapshot/libtraceevent-1.2.0.tar.gz
https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
Changes since 1.1.3:
On Thu, 8 Apr 2021 08:18:21 +0200
Greg KH wrote:
> And I would love a taint for rmmod, but what is that going to help out
> with?
Just like any other taint. If a rmmod can cause the system to lose
integrity, the rmmod could cause a subtle issue that manifests itself into
something more serious
Dear RT Folks,
I'm pleased to announce the 5.10.27-rt36 stable release.
This release is just an update to the new stable 5.10.27 version
and no RT specific changes have been made.
You can get this release via the git tree at:
On Tue, 6 Apr 2021 18:23:51 +0800
Zhang Jianhua wrote:
> If CONFIG_FUNCTION_GRAPH_TRACER=y, the following errors will be seen
> while compiling patch.c
>
> arch/arm/kernel/patch.c: In function ‘__patch_text_real’:
> arch/arm/kernel/patch.c:94:11: error: implicit declaration of function
>
On Tue, 6 Apr 2021 14:51:45 +0800
Jiapeng Chong wrote:
> It is possible that on error pg->size can be zero when getting its
> order,which would return a -1 value. It is dangerous to pass in an
> order of -1 to free_pages(). Check if order is greater than or equal
> to zero before calling
On Mon, 5 Apr 2021 19:42:03 -0400
Waiman Long wrote:
> +/*
> + * All the print_cpu() callers from sched_debug_show() will be allowed
> + * to contend for sched_debug_lock and use group_path[] as their SEQ_printf()
> + * calls will be much faster. However only one print_cpu() caller from
> + *
On Mon, 29 Mar 2021 16:05:33 +0300
"Yordan Karadzhov (VMware)" wrote:
> If the option is activated the function tracing record gets
> consolidated in the cases when a single function is called number
> of times consecutively. Instead of having an identical record for
> each call of the function
On Mon, 29 Mar 2021 16:05:32 +0300
"Yordan Karadzhov (VMware)" wrote:
> Currently the logic for dealing with the options for function tracing
> has two different implementations. One is used when we set the flags
> (in "static int func_set_flag()") and another used when we initialize
> the
On Mon, 29 Mar 2021 16:05:29 +0300
"Yordan Karadzhov (VMware)" wrote:
> The event aims to consolidate the function tracing record in the cases
> when a single function is called number of times consecutively.
>
> while (cond)
> do_func();
>
> This may happen in various
On Sun, 4 Apr 2021 21:27:00 -0400
Waiman Long wrote:
> Thanks for the suggestion, but it also sound complicated.
It's not that complicated. Similar tricks have been used elsewhere in the
kernel.
>
> I think we can fix this lockup problem if we are willing to lose some
It's not a lockup
On Fri, 2 Apr 2021 23:09:09 -0400
Waiman Long wrote:
> The main problem with sched_debug_lock is that under certain
> circumstances, a lock waiter may wait a long time to acquire the lock
> (in seconds). We can't insert touch_nmi_watchdog() while the cpu is
> waiting for the spinlock.
The
From: "Steven Rostedt (VMware)"
Commit b40c6eabfcd40 ("ftrace: Simplify the calculation of page number for
ftrace_page->records") simplified the calculation of the number of pages
needed for each page group without having any empty pages, but it can be
simplified even
-=whyMxheOqXAORt9a7JK9gc9eHTgCJ55Pgs4p=x3rrq...@mail.gmail.com/
Signed-off-by: Linus Torvalds
[ change log written by Steven Rostedt ]
Signed-off-by: Steven Rostedt (VMware)
---
kernel/trace/ftrace.c | 35 +--
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/kernel/trace/ftrace.c
From: Wan Jiabing
struct trace_array is declared twice. One has been declared
at forward declaration. Remove the duplicate.
Link: https://lkml.kernel.org/r/20210330034056.2266969-1-wanjiab...@vivo.com
Signed-off-by: Wan Jiabing
Signed-off-by: Steven Rostedt (VMware)
---
include/linux
From: "Yordan Karadzhov (VMware)"
The "cpu" parameter is not being used by the function.
Link: https://lkml.kernel.org/r/20210329130331.199402-1-y.kar...@gmail.com
Signed-off-by: Yordan Karadzhov (VMware)
Signed-off-by: Steven Rostedt (VMware)
---
include/linux/ring_buf
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
for-next
Head SHA1: ceaaa12904df07d07ea8975abbf04c4d60e46956
Linus Torvalds (1):
ftrace: Store the order of pages allocated in ftrace_page
Steven Rostedt (VMware) (1):
ftrace: Simplify the calculation of page
On Thu, 1 Apr 2021 14:10:30 -0400
Waiman Long wrote:
> The handling of sysrq key can be activated by echoing the key to
> /proc/sysrq-trigger or via the magic key sequence typed into a terminal
> that is connected to the system in some way (serial, USB or other mean).
> In the former case, the
which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
trace-v5.12-rc5-2
Tag SHA1: cb39aeb904fb1dc0fff7e13799d9ad287fb4697f
Head SHA1: 9deb193af69d3fd6dd8e47f292b67c805a787010
Steven Rostedt (VMware) (1):
tracing: Fix stack trace event size
ke
On Thu, 1 Apr 2021 13:18:59 -0700
Linus Torvalds wrote:
> On Thu, Apr 1, 2021 at 1:07 PM Steven Rostedt wrote:
> >
> > On Wed, 31 Mar 2021 11:03:21 -0700
> > Linus Torvalds wrote:
> >
> > > @@ -6231,7 +6231,8 @@ static int ftrace_process_locs(struct module
On Thu, 1 Apr 2021 16:07:10 -0400
Steven Rostedt wrote:
> > @@ -6231,7 +6231,8 @@ static int ftrace_process_locs(struct module *mod,
> > if (!addr)
> > continue;
> >
> > - if (pg->index == pg->size) {
> > +
On Wed, 31 Mar 2021 11:03:21 -0700
Linus Torvalds wrote:
> @@ -6231,7 +6231,8 @@ static int ftrace_process_locs(struct module *mod,
> if (!addr)
> continue;
>
> - if (pg->index == pg->size) {
> + end_offset = (pg->index+1) *
nd_next_bit() accesses uninitialized cpu mask variable. Fix this
> problem by replacing alloc_cpumask_var() with zalloc_cpumask_var().
>
> Signed-off-by: Tetsuo Handa
> ---
> kernel/irq/proc.c| 4 ++--
> kernel/profile.c | 2 +-
> kernel/trace/trace.c | 2 +-
Acked-by: Steven Rostedt (VMware)
-- Steve
On Thu, 1 Apr 2021 00:02:57 +0200
Vasily Gorbik wrote:
> I only tested it on s390 (manually + ftrace selftest), quite frankly.
> If it qualifies:
You reported the bug, thus tested-by from the reporter always
qualifies ;-)
>
> Tested-by: Vasily Gorbik # s390 only
Thanks,
-- Steve
On Wed, 31 Mar 2021 22:51:15 +0200
Vasily Gorbik wrote:
> It does! Thanks for the explanation and for the fix. I wonder why nobody
> noticed and complained about that since v5.6.
Because it didn't lose data, just added extra junk.
>
> Acked-by: Vasily Gorbik
Want to give a "tested-by" too?
On Wed, 31 Mar 2021 11:03:21 -0700
Linus Torvalds wrote:
> I found another bug in there, for example:
>
> ftrace_number_of_pages -= 1 << order;
>
> is also wrong if order is negative.
True, but ftrace_number_of_pages is only used for accounting (used to
display the number of
On Wed, 31 Mar 2021 10:45:01 -0700
Linus Torvalds wrote:
> On Wed, Mar 31, 2021 at 6:27 AM Steven Rostedt wrote:
> >
> > order = get_count_order(pg->size / ENTRIES_PER_PAGE);
> > - free_pages((unsigned long)pg->records, order);
> &g
On Wed, 31 Mar 2021 13:52:45 +0200
Vasily Gorbik wrote:
> Hi Steven,
>
> At least on s390 since commit cbc3b92ce037 ("tracing: Set kernel_stack's
> caller size properly") kernel stack trace contains 8 garbage values in the
> end.
> I assume those are supposed to be filled by
On Wed, 31 Mar 2021 11:31:03 +0200
Geert Uytterhoeven wrote:
> This reduces kernel size by ca. 0.5 KiB.
If you are worried about size, disable tracing and it will go away
entirely. 0.5KiB is a drop in the bucket compared to what tracing adds in
size overhead.
Sorry, but NAK.
This has been
pub/scm/linux/kernel/git/rostedt/linux-trace.git
trace-v5.12-rc5
Tag SHA1: 30ee29d701d2b6848cfa1c7a163745fb68aabd36
Head SHA1: 59300b36f85f254260c81d9dd09195fa49eb0f98
Steven Rostedt (VMware) (1):
ftrace: Check if pages were allocated before calling free_pages()
kernel/trace/ftrace.c
recursion protection to the
> ftrace callback"), so do similar modifications as the commit does.
>
> Fixes: 829adda597fe ("riscv: Add KPROBES_ON_FTRACE supported")
> Signed-off-by: Jisheng Zhang
Looks fine to me.
Reviewed-by: Steven Rostedt (VMware)
-- Steve
On Tue, 30 Mar 2021 18:02:26 +0800
Jiapeng Chong wrote:
> Fix the following whitescan warning:
>
> "order" is passed to a parameter that cannot be negative.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
> ---
> kernel/trace/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On Tue, 30 Mar 2021 09:55:17 +0800
Wan Jiabing wrote:
> struct trace_array is declared twice. One has been declared
> at forward struct declaration. Remove the duplicate.
> And sort these forward declarations alphabetically.
Um, no that's not how we sort things.
>
> Signed-off-by: Wan Jiabing
On Sat, 27 Mar 2021 22:24:45 +
Al Viro wrote:
> On Fri, Mar 26, 2021 at 11:33:58AM +0100, Peter Zijlstra wrote:
>
> > +again:
> > + rcu_read_lock();
> > + str = rcu_dereference(*(char **)file->private_data);
> > + len = strlen(str) + 1;
> > +
> > + if (!copy || copy_len < len) {
> >
-by: Ingo Molnar
Signed-off-by: Steven Rostedt (VMware)
---
arch/microblaze/include/asm/ftrace.h | 2 +-
arch/nds32/kernel/ftrace.c | 2 +-
arch/powerpc/include/asm/ftrace.h| 4 ++--
arch/sh/kernel/ftrace.c | 2 +-
arch/sparc/include/asm/ftrace.h | 2 +-
fs/tracefs
Qiujun Huang (2):
tracing: A minor cleanup for create_system_filter()
tracing: Update create_system_filter() kernel-doc comment
Steven Rostedt (VMware) (2):
scripts/recordmcount.pl: Make indent spacing consistent
scripts/recordmcount.pl: Make vim and emacs indent the same
From: "Steven Rostedt (VMware)"
Emacs by default will have perl files have 4 space indents, where 8 spaces
are represented with a single tab. There are some places in
recordmcount.pl that has 8 spaces where a tab should be used. Replace them
to make the file consistent.
No function
From: "Steven Rostedt (VMware)"
By default, emacs indents Perl files with 4 spaces, but will use tabs
where 8 spaces are used. Add a vim command of softtabstop=4, to make vim
behave the same. This should remove the issue of developers using vim
having causing different indentati
From: Bhaskar Chowdhury
s/callin/calling/
Link: https://lkml.kernel.org/r/20210317095401.1854544-1-unixbhas...@gmail.com
Acked-by: Randy Dunlap
Signed-off-by: Bhaskar Chowdhury
[ Other fixes already done by Ingo Molnar ]
Signed-off-by: Steven Rostedt (VMware)
---
kernel/trace
From: Qiujun Huang
The first two parameters should be reduced to one, as @tr is simply
@dir->tr.
Link: https://lkml.kernel.org/r/20210324205642.65e03...@oasis.local.home
Link: https://lkml.kernel.org/r/20210325163752.128407-1-hqjag...@gmail.com
Suggested-by: Steven Rostedt (VMware)
Signed-
er from @system to @dir.
Link: https://lkml.kernel.org/r/20210325161911.123452-1-hqjag...@gmail.com
Signed-off-by: Qiujun Huang
Signed-off-by: Steven Rostedt (VMware)
---
kernel/trace/trace_events_filter.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_ev
On Fri, 26 Mar 2021 21:03:49 +0900
Masami Hiramatsu wrote:
> I confirmed this is not related to this series, but occurs when I build
> kernels with different
> configs without cleanup.
>
> Once I build kernel with CONFIG_UNWIND_GUESS=y (for testing), and after that,
> I build kernel again with
I'm happy to announce KernelShark Version 1.3
*** NOTICE ***
KernelShark is now in its own repository (and will depend on libtracecmd).
This is the last version that will home KernelShark in the trace-cmd.git
repo.
New development of KernelShark now lives here:
I'm happy to announce trace-cmd version 2.9.2!
*** NOTICE ***
This is the last version that is self contained for interacting
with the tracefs directory and parsing the events.
The parsing of events is now a separate repository:
https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
On Thu, 25 Mar 2021 19:11:37 +0100
Peter Zijlstra wrote:
> diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c
> b/drivers/net/ethernet/qualcomm/qca_spi.c
> index 5a3b65a6eb4f..17ee771e0051 100644
> --- a/drivers/net/ethernet/qualcomm/qca_spi.c
> +++ b/drivers/net/ethernet/qualcomm/qca_spi.c
>
On Thu, 25 Mar 2021 23:09:38 +0900
Masahiro Yamada wrote:
> > > Not all people use vim.
> >
> > I don't use it either. I was trying to make vim match emacs. Of course for
> > those that use something else, it wont help. I'm curious, what's your main
> > editor that you use?
>
>
> I use
901 - 1000 of 34189 matches
Mail list logo
