Re: [PATCH v3] eventfs: Fix the NULL pointer dereference bug in eventfs_remove_rec()

[Steven Rostedt]

On Mon, 11 Sep 2023 20:51:25 +0900
Masami Hiramatsu (Google) <mhira...@kernel.org> wrote:

> Instead,
> 
>       ef = eventfs_add_subsystem_dir(name, parent);
>       if (IS_ERR(ef)) {
>               ...
>       } else
>               dir->ef = ef;


Note, as the error has a goto out_free, it just needs to be:

        if (IS_ERR(ef)) {
                ...
                goto out_free;
        }

        dir->ef = ef;

And for event_create_dir()

        ef = eventfs_add_dir(name, ef_subsystem);
        if (IS_ERR(ef)) {
                ...
                return -1;
        }

        file->ef = ef;

-- Steve