[MediaWiki-commits] [Gerrit] (bug 17168) Support interwiki articles when loading collecti... - change (mediawiki...Collection[master])

2013-01-19 Thread Adamw (Code Review)
Adamw has uploaded a new change for review. Change subject: (bug 17168) Support interwiki articles when loading collection .. (bug 17168) Support interwiki articles when loading collection Note that there is no UI to support thi

[MediaWiki-commits] [Gerrit] (bug 44024) ObjectCache changes break XCache 3.x support - change (mediawiki/core[REL1_20])

2013-01-19 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: (bug 44024) ObjectCache changes break XCache 3.x support .. (bug 44024) ObjectCache changes break XCache 3.x support Changes in the 1.20.x branch altered

[MediaWiki-commits] [Gerrit] EQIAD MIGRATION: turn OFF $wgReadOnly in eqiad - change (operations/mediawiki-config[master])

2013-01-19 Thread Asher (Code Review)
Asher has uploaded a new change for review. Change subject: EQIAD MIGRATION: turn OFF $wgReadOnly in eqiad .. EQIAD MIGRATION: turn OFF $wgReadOnly in eqiad Change-Id: I5e994d35af3276bd59cf9e683a384a9890c53aa0 --- M wmf-config/d

[MediaWiki-commits] [Gerrit] (bug 44024) ObjectCache changes break XCache 3.x support - change (mediawiki/core[REL1_20])

2013-01-19 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. Change subject: (bug 44024) ObjectCache changes break XCache 3.x support .. (bug 44024) ObjectCache changes break XCache 3.x support Changes in the 1.20.x branch altered the add

[MediaWiki-commits] [Gerrit] EQIAD SWITCH: set $wgReadOnly in pmtpa - change (operations/mediawiki-config[master])

2013-01-19 Thread Asher (Code Review)
Asher has uploaded a new change for review. Change subject: EQIAD SWITCH: set $wgReadOnly in pmtpa .. EQIAD SWITCH: set $wgReadOnly in pmtpa Change-Id: I063494bdefafc77a0f711f3677d377998f60be45 --- M wmf-config/db-pmtpa.php 1 fi

[MediaWiki-commits] [Gerrit] mediawiki.jqueryMsg: Fix regression and add tests. - change (mediawiki/core[master])

2013-01-19 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: mediawiki.jqueryMsg: Fix regression and add tests. .. mediawiki.jqueryMsg: Fix regression and add tests. >From If060b75f. Thanks to jshint and us using C

[MediaWiki-commits] [Gerrit] select api backend certain mobile requests are routed to bas... - change (operations/puppet[production])

2013-01-19 Thread Asher (Code Review)
Asher has uploaded a new change for review. Change subject: select api backend certain mobile requests are routed to based on $::mw_primary .. select api backend certain mobile requests are routed to based on $::mw_primary Chan

[MediaWiki-commits] [Gerrit] mediawiki.jqueryMsg: Fix regression and add tests. - change (mediawiki/core[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. Change subject: mediawiki.jqueryMsg: Fix regression and add tests. .. mediawiki.jqueryMsg: Fix regression and add tests. >From If060b75f. Thanks to jshint and us using Checkstyle re

[MediaWiki-commits] [Gerrit] git macro to fetch mw ext at root of $WORKSPACE - change (integration/jenkins-job-builder-config[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: git macro to fetch mw ext at root of $WORKSPACE .. git macro to fetch mw ext at root of $WORKSPACE Sometime we do not want to fetch the extensions under a sub

[MediaWiki-commits] [Gerrit] little python script that reads stdin and calculates some pe... - change (operations/puppet[production])

2013-01-19 Thread Asher (Code Review)
Asher has submitted this change and it was merged. Change subject: little python script that reads stdin and calculates some percentiles .. little python script that reads stdin and calculates some percentiles Change-Id: I2017

[MediaWiki-commits] [Gerrit] little python script that reads stdin and calculates some pe... - change (operations/puppet[production])

2013-01-19 Thread Asher (Code Review)
Asher has uploaded a new change for review. Change subject: little python script that reads stdin and calculates some percentiles .. little python script that reads stdin and calculates some percentiles Change-Id: I20175a19dd93

[MediaWiki-commits] [Gerrit] Provide configurable parser for varnish log lines. - change (mediawiki...EventLogging[master])

2013-01-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. Change subject: Provide configurable parser for varnish log lines. .. Provide configurable parser for varnish log lines. varnishncsa (which emits the log lines we get from the bit

[MediaWiki-commits] [Gerrit] (bug 43751) Allow '+' in MySQL database names. - change (mediawiki/core[master])

2013-01-19 Thread Victor Vasiliev (Code Review)
Victor Vasiliev has uploaded a new change for review. Change subject: (bug 43751) Allow '+' in MySQL database names. .. (bug 43751) Allow '+' in MySQL database names. Change-Id: I0196af1989a09d941bfcc8e52c6c9f97ea5abe95 --- M in

[MediaWiki-commits] [Gerrit] Add wikivoyage to captcha whitelist - change (operations/mediawiki-config[master])

2013-01-19 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. Change subject: Add wikivoyage to captcha whitelist .. Add wikivoyage to captcha whitelist External links to Wikivoyage should be whitelisted, just as links to other WMF projects alre

[MediaWiki-commits] [Gerrit] Jenkins test (DO NOT SUBMIT) - change (mediawiki/core[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. Change subject: Jenkins test (DO NOT SUBMIT) .. Jenkins test (DO NOT SUBMIT) Change-Id: I906ea3ac4fe8ee642893bf13acd95cb697d26cd7 --- A example.js 1 file changed, 9 insertions(+), 0

[MediaWiki-commits] [Gerrit] Gitignore: Add 'output' directory. - change (integration/jenkins-job-builder[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Gitignore: Add 'output' directory. .. Gitignore: Add 'output' directory. Change-Id: I922141803f304af95ebaede707f74ddcff3943ed --- M .gitignore 1 file changed,

[MediaWiki-commits] [Gerrit] Gitignore: Add 'output' directory. - change (integration/jenkins-job-builder[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. Change subject: Gitignore: Add 'output' directory. .. Gitignore: Add 'output' directory. Change-Id: I922141803f304af95ebaede707f74ddcff3943ed --- M .gitignore 1 file changed, 1 inser

[MediaWiki-commits] [Gerrit] (minor) fix for calling options in Widgets based on Template... - change (mediawiki...Wikibase[master])

2013-01-19 Thread Daniel Werner (Code Review)
Daniel Werner has uploaded a new change for review. Change subject: (minor) fix for calling options in Widgets based on TemplatedWidget .. (minor) fix for calling options in Widgets based on TemplatedWidget Change-Id: Ia27d7203

[MediaWiki-commits] [Gerrit] (minor) stick closer to jQuery.Widget implementation of snak... - change (mediawiki...Wikibase[master])

2013-01-19 Thread Daniel Werner (Code Review)
Daniel Werner has uploaded a new change for review. Change subject: (minor) stick closer to jQuery.Widget implementation of snakview disable/enable .. (minor) stick closer to jQuery.Widget implementation of snakview disable/enab

[MediaWiki-commits] [Gerrit] (bug 43006) Simpler implementation of disable for SnakTypeSe... - change (mediawiki...Wikibase[master])

2013-01-19 Thread Daniel Werner (Code Review)
Daniel Werner has uploaded a new change for review. Change subject: (bug 43006) Simpler implementation of disable for SnakTypeSelector .. (bug 43006) Simpler implementation of disable for SnakTypeSelector This basically reverts

[MediaWiki-commits] [Gerrit] Bug 44157 - The return value of realpath should be tested - change (mediawiki/core[master])

2013-01-19 Thread MarkAHershberger (Code Review)
MarkAHershberger has uploaded a new change for review. Change subject: Bug 44157 - The return value of realpath should be tested .. Bug 44157 - The return value of realpath should be tested Take the realpath wrapper from Sqlit

[MediaWiki-commits] [Gerrit] Fixed incorrect use of DOM.insertBefore API. - change (mediawiki...Parsoid[master])

2013-01-19 Thread GWicke (Code Review)
GWicke has submitted this change and it was merged. Change subject: Fixed incorrect use of DOM.insertBefore API. .. Fixed incorrect use of DOM.insertBefore API. * When I wanted to add an element in the first child position, I

[MediaWiki-commits] [Gerrit] Fixed incorrect use of DOM.insertBefore API. - change (mediawiki...Parsoid[master])

2013-01-19 Thread Subramanya Sastry (Code Review)
Subramanya Sastry has uploaded a new change for review. Change subject: Fixed incorrect use of DOM.insertBefore API. .. Fixed incorrect use of DOM.insertBefore API. * When I wanted to add an element in the first child position,

[MediaWiki-commits] [Gerrit] (bug 43006) Disable input element and toolbar on saving/remo... - change (mediawiki...Wikibase[master])

2013-01-19 Thread Daniel Werner (Code Review)
Daniel Werner has submitted this change and it was merged. Change subject: (bug 43006) Disable input element and toolbar on saving/removing .. (bug 43006) Disable input element and toolbar on saving/removing Replacing the toolb

[MediaWiki-commits] [Gerrit] (bug 44158) Improve localization in flyout of curation tool. - change (mediawiki...PageTriage[master])

2013-01-19 Thread Nischayn22 (Code Review)
Nischayn22 has uploaded a new change for review. Change subject: (bug 44158) Improve localization in flyout of curation tool. .. (bug 44158) Improve localization in flyout of curation tool. * Adds localization for 'close flyout'

[MediaWiki-commits] [Gerrit] (bug 42513) mediawiki.Uri: Fix parsing of URIs with @ in pat... - change (mediawiki/core[master])

2013-01-19 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: (bug 42513) mediawiki.Uri: Fix parsing of URIs with @ in path. .. (bug 42513) mediawiki.Uri: Fix parsing of URIs with @ in path. The regexes for URI parsi

[MediaWiki-commits] [Gerrit] Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini - change (integration/jenkins-job-builder[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini .. Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini Also fix broken gitreview file. Ch

[MediaWiki-commits] [Gerrit] Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini - change (integration/jenkins-job-builder[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. Change subject: Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini .. Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini Also fix broken gitreview file. Change-Id:

[MediaWiki-commits] [Gerrit] Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini - change (integration/jenkins[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. Change subject: Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini .. Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini Also fix broken gitreview file. Change-Id:

[MediaWiki-commits] [Gerrit] Revert "Gitignore: Reset to upstream, and add /etc/jenkins_j... - change (integration/jenkins[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Revert "Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini" .. Revert "Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini" This reverts com

[MediaWiki-commits] [Gerrit] Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini - change (integration/jenkins[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini .. Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini Change-Id: Iaefe10ed2b54d68e7cec741

[MediaWiki-commits] [Gerrit] Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini - change (integration/jenkins[master])

2013-01-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. Change subject: Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini .. Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini Change-Id: Iaefe10ed2b54d68e7cec74112fa1165

[MediaWiki-commits] [Gerrit] (bug 44141) Clean up usage of one-pixel images in Vector's C... - change (mediawiki/core[master])

2013-01-19 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 44141) Clean up usage of one-pixel images in Vector's CSS .. (bug 44141) Clean up usage of one-pixel images in Vector's CSS Removed appropriate background-image

[MediaWiki-commits] [Gerrit] Default protwords.txt is useless - change (mediawiki...Translate[master])

2013-01-19 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review. Change subject: Default protwords.txt is useless .. Default protwords.txt is useless Change-Id: If0bc66eb994b3e6163e83de46616583bef8b359a --- M ttmserver/schema.xml 1 file changed

[MediaWiki-commits] [Gerrit] fix messed up i18n method usage and added TODO - change (mediawiki...Validator[master])

2013-01-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. Change subject: fix messed up i18n method usage and added TODO .. fix messed up i18n method usage and added TODO Change-Id: I573ba086e3ce5999a20d3fd08b8eb83aec9f41bd --- M uti

[MediaWiki-commits] [Gerrit] JSHint: raise max errors to 10000 - change (mediawiki...LiquidThreads[master])

2013-01-19 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged. Change subject: JSHint: raise max errors to 1 .. JSHint: raise max errors to 1 We have lot of JavaScript errors in this extension so raise the maxerr to 1 so we

[MediaWiki-commits] [Gerrit] JSHint: ignore jquery/jquery.autogrow.js 3rd party - change (mediawiki...LiquidThreads[master])

2013-01-19 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged. Change subject: JSHint: ignore jquery/jquery.autogrow.js 3rd party .. JSHint: ignore jquery/jquery.autogrow.js 3rd party We do not want to report JavaScript errors that com

[MediaWiki-commits] [Gerrit] JSHint: .jshintrc from MediaWiki core - change (mediawiki...LiquidThreads[master])

2013-01-19 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged. Change subject: JSHint: .jshintrc from MediaWiki core .. JSHint: .jshintrc from MediaWiki core Change-Id: I43c07030837830956e2ae130125d19dcc453f94c --- A .jshintrc 1 file c

[MediaWiki-commits] [Gerrit] Use displaytitle for pages in category - change (mediawiki/core[master])

2013-01-19 Thread Eranroz (Code Review)
Eranroz has uploaded a new change for review. Change subject: Use displaytitle for pages in category .. Use displaytitle for pages in category Fix for bug 28411: categories should use displaytitle if such exist (from page_props

[MediaWiki-commits] [Gerrit] [TwitterCards] Register extension - change (translatewiki[master])

2013-01-19 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged. Change subject: [TwitterCards] Register extension .. [TwitterCards] Register extension Change-Id: I83243ae72ef7db633f12bf65928da428c529c69f --- M groups/MediaWiki/me

[MediaWiki-commits] [Gerrit] [TwitterCards] Register extension - change (translatewiki[master])

2013-01-19 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review. Change subject: [TwitterCards] Register extension .. [TwitterCards] Register extension Change-Id: I83243ae72ef7db633f12bf65928da428c529c69f --- M groups/MediaWiki/mediawiki-

[MediaWiki-commits] [Gerrit] Some consistency tweaks in preparation for adding extension ... - change (mediawiki...TwitterCards[master])

2013-01-19 Thread Harshkothari410 (Code Review)
Harshkothari410 has submitted this change and it was merged. Change subject: Some consistency tweaks in preparation for adding extension to Translatewiki.net .. Some consistency tweaks in preparation for adding extension to Tra

[MediaWiki-commits] [Gerrit] Some consistency tweaks in preparation for adding extension ... - change (mediawiki...TwitterCards[master])

2013-01-19 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review. Change subject: Some consistency tweaks in preparation for adding extension to Translatewiki.net .. Some consistency tweaks in preparation for adding extension to Translatew

[MediaWiki-commits] [Gerrit] fixed: revision does not show in user contribs if rev_parent... - change (mediawiki...WikiLexicalData[master])

2013-01-19 Thread Kipcool (Code Review)
Kipcool has submitted this change and it was merged. Change subject: fixed: revision does not show in user contribs if rev_parent_id is null (default value), but works with 0. .. fixed: revision does not show in user contribs i

[MediaWiki-commits] [Gerrit] fixed: revision does not show in user contribs if rev_parent... - change (mediawiki...WikiLexicalData[master])

2013-01-19 Thread Kipcool (Code Review)
Kipcool has uploaded a new change for review. Change subject: fixed: revision does not show in user contribs if rev_parent_id is null (default value), but works with 0. .. fixed: revision does not show in user contribs if rev_pa

[MediaWiki-commits] [Gerrit] Use array for fields in join condition - change (mediawiki/core[master])

2013-01-19 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. Change subject: Use array for fields in join condition .. Use array for fields in join condition Change-Id: I52875ebd5fc67e74439faf703b8119fedd70bfc9 --- M includes/CategoryVie

[MediaWiki-commits] [Gerrit] fixed bug database error when userLanguageId is null - change (mediawiki...WikiLexicalData[master])

2013-01-19 Thread Kipcool (Code Review)
Kipcool has submitted this change and it was merged. Change subject: fixed bug database error when userLanguageId is null .. fixed bug database error when userLanguageId is null Change-Id: I53428c7f319dbe51b5e061686314565b36793

[MediaWiki-commits] [Gerrit] Updated extension credits - change (mediawiki...WikiLexicalData[master])

2013-01-19 Thread Kipcool (Code Review)
Kipcool has submitted this change and it was merged. Change subject: Updated extension credits .. Updated extension credits Change-Id: I7c2975d5091937d5fefb71a42f3a7729e88a7954 --- M App.php 1 file changed, 4 insertions(+), 3 d

[MediaWiki-commits] [Gerrit] Updated extension credits - change (mediawiki...WikiLexicalData[master])

2013-01-19 Thread Kipcool (Code Review)
Kipcool has uploaded a new change for review. Change subject: Updated extension credits .. Updated extension credits Change-Id: I7c2975d5091937d5fefb71a42f3a7729e88a7954 --- M App.php 1 file changed, 4 insertions(+), 3 deletions

[MediaWiki-commits] [Gerrit] fixed bug database error when userLanguageId is null - change (mediawiki...WikiLexicalData[master])

2013-01-19 Thread Kipcool (Code Review)
Kipcool has uploaded a new change for review. Change subject: fixed bug database error when userLanguageId is null .. fixed bug database error when userLanguageId is null Change-Id: I53428c7f319dbe51b5e061686314565b3679397f ---

[MediaWiki-commits] [Gerrit] (bug 44024) ObjectCache changes break XCache 3.x support - change (mediawiki/core[master])

2013-01-19 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: (bug 44024) ObjectCache changes break XCache 3.x support .. (bug 44024) ObjectCache changes break XCache 3.x support Changes in the 1.20.x branch altered

[MediaWiki-commits] [Gerrit] Revert "Follow-up Ibb9d4c9a: Ignore 'abusefilter-message'" - change (translatewiki[master])

2013-01-19 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged. Change subject: Revert "Follow-up Ibb9d4c9a: Ignore 'abusefilter-message'" .. Revert "Follow-up Ibb9d4c9a: Ignore 'abusefilter-message'" Was removed with I72e1a6dd

[MediaWiki-commits] [Gerrit] Revert "Revert "[GuidedTour] Ignore messages for now"" - change (translatewiki[master])

2013-01-19 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged. Change subject: Revert "Revert "[GuidedTour] Ignore messages for now"" .. Revert "Revert "[GuidedTour] Ignore messages for now"" Barebone messages come back with Iac

[MediaWiki-commits] [Gerrit] Log isNew field for gettingstarted-clicks as well. - change (mediawiki...E3Experiments[master])

2013-01-19 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged. Change subject: Log isNew field for gettingstarted-clicks as well. .. Log isNew field for gettingstarted-clicks as well. Prior to this I was only logging it for gettingsta

[MediaWiki-commits] [Gerrit] Clean-up exception messages; use more concise idioms - change (mediawiki...EventLogging[master])

2013-01-19 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Clean-up exception messages; use more concise idioms .. Clean-up exception messages; use more concise idioms Change-Id: I3acc97057cae9d06d374615a7551ce081

[MediaWiki-commits] [Gerrit] Clean-up exception messages; use more concise idioms - change (mediawiki...EventLogging[master])

2013-01-19 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review. Change subject: Clean-up exception messages; use more concise idioms .. Clean-up exception messages; use more concise idioms Change-Id: I3acc97057cae9d06d374615a7551ce08123626d5 -

[MediaWiki-commits] [Gerrit] Fix change 44582 so events log again. - change (mediawiki...EventLogging[master])

2013-01-19 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix change 44582 so events log again. .. Fix change 44582 so events log again. Validate the event combined with defaults, restore baseUri of beacon image,