On Thu, 2017-04-27 at 09:31 -0700, Jason Ekstrand wrote:
> Shader hashing is very closely related to shader
> compilation. Putting
> them right next to each other in anv_pipeline makes it easier to
> verify
> that we're actually hashing everything we need to be hashing.
Maybe add that this versio
The application might not give an output structure.
CID: 1405765 (Null pointer dereferences)
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_formats.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
This will allows us to create no error versions of functions
noted by a _no_error suffix. We also need to set a no_error
attribute equal to "true" in the xml.
V3: stop the no_error attribute being overwritten when functions
alias another.
V2: tidy up suggested by Nicolai.
---
src/mapi/glapi/g
On 03.05.2017 00:50, Constantine Kharlamov wrote:
> On 28.04.2017 10:57, Marc Dietrich wrote:
>> Hi Constantine,
>>
>>
>> Am Donnerstag, 27. April 2017, 21:04:37 CEST schrieb Constantine Kharlamov:
>>> Please, could you try this patch. The change is: I'm setting dirty_zsbuf in
>>> r600_bind_blend_s
These were unused.
---
src/mesa/main/accum.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/main/accum.h b/src/mesa/main/accum.h
index a5665c7..ede2ecc 100644
--- a/src/mesa/main/accum.h
+++ b/src/mesa/main/accum.h
@@ -32,23 +32,21 @@
* OTHER DEALINGS IN THE SOFTWARE.
*/
---
src/mesa/main/accum.c | 104 +-
src/mesa/main/accum.h | 3 --
2 files changed, 52 insertions(+), 55 deletions(-)
diff --git a/src/mesa/main/accum.c b/src/mesa/main/accum.c
index ef74468..919c441 100644
--- a/src/mesa/main/accum.c
+++ b/src/mes
The matrix used for YCbCr to RGB is listed in:
https://en.wikipedia.org/wiki/YCbCr
There was an error in converting the offsets from integers to unorm
values: 0.0625=16/256 should be 16.0/255,and 0.5=128.0/256 should be
128.0/255. With this fix, the CSC result is bit aligned with wikipedia's
con
Thanks for the comments and have updated the patch!
-Original Message-
From: Matt Turner [mailto:matts...@gmail.com]
Sent: Wednesday, May 3, 2017 2:37 AM
To: Lin, Johnson
Cc: mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader
On 17 March 2017 at 18:24, Bas Nieuwenhuizen wrote:
> Where do you see that they are required to flush denormals to 0? I
> can't find it in the GLSL extensions for SPIR-V, and the vulkan spec
> has the following note:
>
> "Any denormalized value input into a shader or potentially generated
> by an
This is already set for the instruction at initialisation.
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index ce4a2cb..1e606d5 100644
--- a
On 02/05/17 20:43, Nicolai Hähnle wrote:
On 27.04.2017 07:33, Timothy Arceri wrote:
This will allows us to create no error versions of functions
noted by a _no_error suffix. We also need to set a no_error
attribute equal to "true" in the xml.
---
src/mapi/glapi/gen/gl_XML.py | 5 +
s
This will allows us to create no error versions of functions
noted by a _no_error suffix. We also need to set a no_error
attribute equal to "true" in the xml.
V2: tidy up suggested by Nicolai
---
src/mapi/glapi/gen/gl_XML.py | 5 +
src/mapi/glapi/gen/gl_genexec.py | 12 ++--
2 fi
Having it in the winsys didn't work when multiple devices use
the same winsys, as we then have multiple contexts per queue,
and each context counts separately.
Signed-off-by: Bas Nieuwenhuizen
Fixes: 7b9963a28f4 "radv: Enable userspace fence checking."
---
src/amd/vulkan/winsys/amdgpu/radv_amdgp
On Tue, May 2, 2017 at 4:37 PM, Nanley Chery wrote:
> On Tue, May 02, 2017 at 04:25:42PM -0700, Jason Ekstrand wrote:
> > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
> > wrote:
> >
> > > Signed-off-by: Nanley Chery
> > > ---
> > > src/intel/vulkan/genX_cmd_buffer.c | 18 +++---
>
I'm stopping here for today and will resume tomorrow.
On Fri 14 Apr 2017, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_batch_chain.c | 96
> --
> src/intel/vulkan/anv_device.c | 25 ++
> src/intel/vulkan/anv_gem.c | 36 ++
On Fri 14 Apr 2017, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_gem.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c
> index 185086f..1392bf4 100644
> --- a/src/intel/vulkan/anv_gem.c
> +++ b/src/intel/vu
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> Make the function take in an image instead of an image view. This
> enables us to record relocations for surfaces states created outside of
> the anv_CreateImageView path.
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/genX_cmd_b
Patches 10-15 are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri 14 Apr 2017, Jason Ekstrand wrote:
> This implementation allocates a 4k BO for each semaphore that can be
> exported using OPAQUE_FD and uses the kernel's already-existing
> synchronization mechanism on BOs.
> ---
> src/intel/vulkan/anv_batch_chain.c | 53 ++--
> src/intel/vul
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> This will be used in conjunction with the buffer of clear values.
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/anv_blorp.c | 41 ++
> +++
> src/intel/vulkan/anv_private.h | 6 ++
> 2 f
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> Signed-off-by: Nanley Chery
> ---
> src/intel/blorp/blorp.h | 9 ++
> src/intel/blorp/blorp_clear.c | 64 ++
> ++---
> 2 files changed, 57 insertions(+), 16 deletions(-)
>
> diff --git a/src/i
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> We're now performing a GPU memcpy in more places to copy small amounts
> of data. Add a path to thrash less state.
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/genX_gpu_memcpy.c | 38 ++
>
>
On Tue, May 02, 2017 at 04:54:55PM -0700, Jason Ekstrand wrote:
> On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
> wrote:
>
> > Signed-off-by: Nanley Chery
> > ---
> > src/intel/vulkan/genX_cmd_buffer.c | 76 ++
> >
> > 1 file changed, 76 insertions(+)
> >
>
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 76 ++
>
> 1 file changed, 76 insertions(+)
>
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buf
On Tue, May 02, 2017 at 04:44:49PM -0700, Jason Ekstrand wrote:
> On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
> wrote:
>
> > Signed-off-by: Nanley Chery
> > ---
> > src/intel/vulkan/anv_pass.c| 22 ++
> > src/intel/vulkan/anv_private.h | 1 +
> > src/intel/vu
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/anv_pass.c| 22 ++
> src/intel/vulkan/anv_private.h | 1 +
> src/intel/vulkan/genX_cmd_buffer.c | 20 ++--
> 3 files changed, 37 insertio
On Wed, May 3, 2017 at 1:23 AM, Eric Anholt wrote:
> Erik Faye-Lund writes:
>
>> On Tue, May 2, 2017 at 7:36 PM, Eric Anholt wrote:
>>> Fixes deqp_gles2 undefine_invalid_object_* failures.
>>> ---
>>> src/compiler/glsl/glcpp/glcpp-parse.y | 7 ++-
>>> 1 file changed, 2 insertions(+), 5 dele
On Tue, May 2, 2017 at 4:28 PM, Nanley Chery wrote:
> On Tue, May 02, 2017 at 04:15:42PM -0700, Jason Ekstrand wrote:
> > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
> > wrote:
> >
> > > The lifespan of the fast-clear data will surpass the render pass scope.
> > > We need CCS_D to be enabled
On Tue, May 02, 2017 at 04:25:42PM -0700, Jason Ekstrand wrote:
> On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
> wrote:
>
> > Signed-off-by: Nanley Chery
> > ---
> > src/intel/vulkan/genX_cmd_buffer.c | 18 +++---
> > 1 file changed, 15 insertions(+), 3 deletions(-)
> >
> > diff -
On Tue, May 02, 2017 at 04:15:42PM -0700, Jason Ekstrand wrote:
> On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
> wrote:
>
> > The lifespan of the fast-clear data will surpass the render pass scope.
> > We need CCS_D to be enabled in order to invalidate blocks previously
> > marked as cleared an
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 18 +++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
>
Erik Faye-Lund writes:
> On Tue, May 2, 2017 at 7:36 PM, Eric Anholt wrote:
>> Fixes deqp_gles2 undefine_invalid_object_* failures.
>> ---
>> src/compiler/glsl/glcpp/glcpp-parse.y | 7 ++-
>> 1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/src/compiler/glsl/glcpp/glcpp-pa
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> The lifespan of the fast-clear data will surpass the render pass scope.
> We need CCS_D to be enabled in order to invalidate blocks previously
> marked as cleared and to sample cleared data correctly.
>
> Signed-off-by: Nanley Chery
> ---
>
On Tue, May 2, 2017 at 7:36 PM, Eric Anholt wrote:
> Fixes deqp_gles2 undefine_invalid_object_* failures.
> ---
> src/compiler/glsl/glcpp/glcpp-parse.y | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y
> b/src/compiler/glsl/glcp
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/anv_image.c | 75 ++
> +---
> src/intel/vulkan/anv_private.h | 5 +++
> 2 files changed, 69 insertions(+), 11 deletions(-)
>
> diff --git a/src/int
From: Dave Airlie
Loop unroll asserts if it hits a sub, we don't really want
to lower subs as llvm handles these things, but do this for
now, until we can fix loop unroll to work with subs.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_pipeline.c | 1 +
1 file changed, 1 insertion(+)
dif
On Thu, Apr 27, 2017 at 11:32:17AM -0700, Nanley Chery wrote:
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 65
> ++
> 1 file changed, 52 insertions(+), 13 deletions(-)
>
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> According to the Linux kernel sources, the ioctl in anv_gem_mmap() will
> not fail if the size isn't a multiple of 4KB.
>
I skimmed through the mmap code and I believe you are correct
Reviewed-by: Jason Ekstrand
> Signed-off-by: Nanley
From: Dave Airlie
This moves the structs from the data segment to the rodata segment,
which seems like the more correct place for them.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/radeon/r600_perfcounter.c | 2 +-
src/gallium/drivers/radeon/r600_query.h | 4 +-
src/gallium/drive
On Tue, May 2, 2017 at 10:36 AM, Eric Anholt wrote:
> Fixes DEQP's scoping.invalid.redeclare_function_fragment/vertex.
> ---
> src/compiler/glsl/ast_to_hir.cpp | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/src/compiler/glsl/ast_to_hir.cpp
> b/src/compiler/glsl/ast_to_hir.c
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/anv_image.c | 67 ++
> ++
> 1 file changed, 67 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
> index
On Wed, May 3, 2017 at 12:18 AM, Cherniak, Bruce
wrote:
>
> On May 2, 2017, at 4:11 PM, Cherniak, Bruce
> wrote:
>
>
> On May 2, 2017, at 3:41 PM, Cherniak, Bruce
> wrote:
>
> PART 2: Call for testing
>
> These drivers have been tested:
> - ddebug
> - llvmpipe
> - r300 (also with SWTCL)
> - r600
>From f097509a17a6ddf6a0f40fb1b73f289227a9539a Mon Sep 17 00:00:00 2001
From: Samuel Li
Date: Thu, 27 Apr 2017 13:45:24 -0400
Subject: [PATCH 1/1] radeonsi: Use libdrm to get chipset name
Change-Id: I614ea71424f9e5c97e4ae68654315d28c89eaa5f
Signed-off-by: Samuel Li
---
src/gallium/drivers/radeon
On May 2, 2017, at 4:11 PM, Cherniak, Bruce
mailto:bruce.chern...@intel.com>> wrote:
On May 2, 2017, at 3:41 PM, Cherniak, Bruce
mailto:bruce.chern...@intel.com>> wrote:
PART 2: Call for testing
These drivers have been tested:
- ddebug
- llvmpipe
- r300 (also with SWTCL)
- r600
- radeonsi
-
radv_bind_descriptor_set cannot be used to bind a push descriptor set
since a push descriptor set does not have a buffer list. However,
there is no need to add the buffers again when restoring a set, so
this fix is also an optimization.
Cc: "17.1"
Signed-off-by: Fredrik Höglund
---
src/amd/vulk
Reviewed-by: Rafael Antognolli
On Mon, May 01, 2017 at 01:54:52PM -0700, Matt Turner wrote:
> ---
> src/intel/common/gen_decoder.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c
> index 15bba32..04
Patch is
Reviewed-by: Rafael Antognolli
On Mon, May 01, 2017 at 01:54:49PM -0700, Matt Turner wrote:
> Newer Gens' names don't have the brackets. Having common names will make
> some later patches simpler.
> ---
> src/intel/genxml/gen4.xml | 2 +-
> src/intel/genxml/gen45.xml | 2 +-
> src/inte
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/anv_private.h | 42 ++
>
> 1 file changed, 42 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_
> private.h
>
This isn't entirely precise because you could create an E5B9G9R9 image and
then only render to it using a R8G8B8A8_UNORM view and fast-clear with it.
That said, neither API lets you do that and it's kind-of pointless for just
one format.
Reviewed-by: Jason Ekstrand
On Thu, Apr 27, 2017 at 11:32
On 28.04.2017 10:57, Marc Dietrich wrote:
> Hi Constantine,
>
>
> Am Donnerstag, 27. April 2017, 21:04:37 CEST schrieb Constantine Kharlamov:
>> Please, could you try this patch. The change is: I'm setting dirty_zsbuf in
>> r600_bind_blend_state_internal() as well. It was the difference between
>
On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
wrote:
> Signed-off-by: Nanley Chery
> ---
> src/intel/isl/isl.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index f89f351c15..ce5b35c47c 100644
> --- a/src/intel/isl
All of the dynamic states apply to rasterization & fragment processing,
so we don't need to set them if we don't rasterize.
We don't clear the dirty flags for them though, so we don't miss any
updates for the next pipeline with rasterization.
Signed-off-by: Bas Nieuwenhuizen
Fixes: 76603aa90b8 "
From: Dave Airlie
This still doesn't give us complete pWaitDstStageMask support,
but it should provide enough to be correct if not as efficent as
possible.
If we have wait semaphores we must flush between submits and
flush the shaders as well.
This fixes the remaining fails in:
dEQP-VK.synchron
> On May 2, 2017, at 3:41 PM, Cherniak, Bruce wrote:
>
>> PART 2: Call for testing
>>
>> These drivers have been tested:
>> - ddebug
>> - llvmpipe
>> - r300 (also with SWTCL)
>> - r600
>> - radeonsi
>> - softpipe
>> - trace
>>
>> These drivers need testing:
>> - etnaviv
>> - freedreno
>> - nv3
On Tue, May 2, 2017 at 10:36 AM, Eric Anholt wrote:
> Here's a little set of changes for dEQP fixes for GLES2 contexts. I
> haven't done a full run to confirm no regressions, as full runs on
> hardware take a day or so. I'm hoping the Intel CI system might be
> able to test these for me.
This c
From: Nicolai Hähnle
v2: - use is_sampler()/is_image() instead (Samuel Pitoiset)
Reviewed-by: Samuel Pitoiset
---
src/compiler/glsl/opt_tree_grafting.cpp | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/compiler/glsl/opt_tree_grafting.cpp
b/src/compiler/glsl/opt_tree_graft
From section 2.14.8 of the ARB_bindless_texture spec:
"(modify second paragraph, p. 126) ... against the
MAX_COMBINED_TEXTURE_IMAGE_UNITS limit. Samplers accessed
using texture handles (section 3.9.X) are not counted against
this limit."
Signed-off-by: Samuel Pitoiset
Reviewe
Yes, this is a bit hacky but we don't really have the choice.
Plain GLSL doesn't accept bindless samplers/images as l-values
while it's allowed when ARB_bindless_texture is enabled.
The default NULL parameter is because we can't access the
_mesa_glsl_parse_state object in few places in the compile
From section 4.4.6 of the ARB_bindless_texture spec:
"If both bindless_sampler and bound_sampler, or bindless_image
and bound_image, are declared at global scope in any
compilation unit, a link- time error will be generated."
Signed-off-by: Samuel Pitoiset
Reviewed-by: Timothy Arceri
v3: - rebase (and remove (sampler) ? 1 : vector_elements)
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/lower_packed_varyings.cpp | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/compiler/glsl/lower_packed_varyings.cpp
b/src/compiler/glsl/lower_packed_varyings.cpp
Plain GLSL doesn't allow sampler/image types to be l-values
while ARB_bindless_texture allows the opposite. Unfortunately,
at this point we can't have access to _mesa_glsl_parse_state.
This is not ideal, but in order to avoid a crash in debug build,
just skip the IR validation when out/inout funct
For the explicit pack/unpack conversions.
Signed-off-by: Samuel Pitoiset
Reviewed-by: Timothy Arceri
Reviewed-by: Nicolai Hähnle
---
src/compiler/glsl/ir_expression_operation.py | 6 ++
src/compiler/glsl/ir_validate.cpp| 20
src/mesa/program/ir_to_mesa.cpp
From section 4.1.7 of the ARB_bindless_texture spec:
"Samplers can be used as l-values, so can be assigned into and
used as "out" and "inout" function parameters."
From section 4.1.X of the ARB_bindless_texture spec:
"Images can be used as l-values, so can be assigned into and
used
In a situation like:
(tex vec4 (record_ref (var_ref f) tex) (constant vec2 (0.00 0.00)) 0
1 () )
The sampler needs to be lowered, otherwise this ends up with
"ir_dereference_variable @ 0x229a100 specifies undeclared variable
`ubo_load_temp' @ 0x2290440"
Signed-off-by: Samuel Pitoiset
From section 5.4.1 of the ARB_bindless_texture spec:
"In the following four constructors, the low 32 bits of the
sampler type correspond to the .x component of the uvec2 and
the high 32 bits correspond to the .y component."
uvec2(any sampler type) // Converts a sampler type to
From section 4.3.4 of the ARB_bindless_texture spec
"(modify last paragraph, p. 35, allowing samplers and images as
fragment shader inputs) ... Fragment inputs can only be signed
and unsigned integers and integer vectors, floating point scalars,
floating-point vectors, matrices, sam
From section 4.1.7 of the ARB_bindless_texture spec:
"Samplers may be declared as shader inputs and outputs, as uniform
variables, as temporary variables, and as function parameters."
From section 4.1.X of the ARB_bindless_texture spec:
"Images may be declared as shader inputs and outp
This will help for the explicit conversions for sampler and
image types as specified by ARB_bindless_texture.
Signed-off-by: Samuel Pitoiset
Reviewed-by: Timothy Arceri
Reviewed-by: Nicolai Hähnle
---
src/compiler/glsl/ast_function.cpp | 10 --
1 file changed, 8 insertions(+), 2 deleti
For the explicit conversions.
From section 4.1.7 of the ARB_bindless_texture spec:
"Samplers are represented using 64-bit integer handles, and
may be converted to and from 64-bit integers using constructors."
From section 4.1.X of the ARB_bindless_texture spec:
"Images are represented
From section 4.1.7 of the ARB_bindless_texture spec:
"Samplers aggregated into arrays within a shader (using square
brackets []) can be indexed with arbitrary integer expressions."
v3: - update spec comment formatting
Signed-off-by: Samuel Pitoiset
Reviewed-by: Timothy Arceri (v2)
Revie
From section 4.3.4 of the ARB_bindless_texture spec:
"(modify third paragraph of the section to allow sampler and
image types) ... Vertex shader inputs can only be float,
single-precision floating-point scalars, single-precision
floating-point vectors, matrices, signed and unsigned
The spec doesn't clearly state this, but I have got clarification
from the spec authors.
Signed-off-by: Samuel Pitoiset
Reviewed-by: Timothy Arceri
Reviewed-by: Nicolai Hähnle
---
src/compiler/glsl/ast_to_hir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/
From section 4.3.4 of the ARB_bindless_texture spec:
"(modify third paragraph of the section to allow sampler and image
types) ... Vertex shader inputs can only be float,
single-precision floating-point scalars, single-precision
floating-point vectors, matrices, signed and unsigned
ARB_bindless_texture spec allows images to be declared as
shader inputs.
v2: - put the */ on the following line (Timothy Arceri)
Signed-off-by: Samuel Pitoiset
Reviewed-by: Timothy Arceri
Reviewed-by: Nicolai Hähnle
---
src/compiler/glsl/ast_type.cpp | 10 ++
1 file changed, 10 insert
ARB_bindless_texture allows to declare images inside structures
which means that qualifiers like writeonly should be allowed.
I have a got a confirmation from Jeff Bolz (one author of the spec),
because the spec doesn't clearly explain this.
Signed-off-by: Samuel Pitoiset
Reviewed-by: Timothy Ar
From section 4.1.7 of the ARB_bindless_texture spec:
"Samplers can be used as l-values, so can be assigned into and used
as "out" and "inout" function parameters."
From section 4.1.X of the ARB_bindless_texture spec:
"Images can be used as l-values, so can be assigned into and used as
The ARB_bindless_texture spec doesn't clearly state this, but as
it says "Replace Section 4.1.7 (Samplers), p. 25" and,
"Replace Section 4.1.X, (Images)", this should be allowed.
v3: - add spec comment
- update the glsl error message
Signed-off-by: Samuel Pitoiset
Reviewed-by: Timothy Arceri
This adds bindless_sampler and bound_sampler (and respectively
bindless_image and bound_image) to the parser.
v3: - add an extra space in apply_bindless_qualifier_to_variable()
- fix indentation in merge_qualifier()
Signed-off-by: Samuel Pitoiset
Reviewed-by: Timothy Arceri (v2)
Reviewed-by
From section 4.3.7 of the ARB_bindless_texture spec:
"(remove the following bullet from the last list on p. 39, thereby
permitting sampler types in interface blocks; image types are also
permitted in blocks by this extension)"
* sampler types are not allowed
v3: - update the spec
In plain GLSL, sampler and image types can only be declared
uniform-qualified global variables or 'in' function parameters.
Setting the read_only flag seems quite useless because other
checks will prevent sampler/image variables to be assigned and
also because the flag is not set for atomic_uint t
From section 4.1.7 of the ARB_bindless_texture spec:
"Samplers may be declared as shader inputs and outputs, as uniform
variables, as temporary variables, and as function parameters."
From section 4.1.X of the ARB_bindless_texture spec:
"Images may be declared as shader inputs and outp
For packed varyings.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl_types.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp
index 89f611d0cb..23f45630af 100644
--- a/src/compiler/glsl_types.cpp
+++ b/src/co
As a side effect, this will magically fix std140/std430 interfaces
for bindless samplers/images and will help for implementing the
explicit conversions with constructors.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
This also adds the extension to the standalone GLSL compiler.
Signed-off-by: Samuel Pitoiset
Reviewed-by: Ilia Mirkin
Reviewed-by: Timothy Arceri
Reviewed-by: Nicolai Hähnle
---
src/compiler/glsl/glsl_parser_extras.cpp | 1 +
src/compiler/glsl/glsl_parser_extras.h | 7 +++
src/c
Bindless samplers/images are 64-bit unsigned integers, which
means they consume two components as specified by
ARB_bindless_texture.
It looks like we are not wasting uniform storage by changing
this because default-block uniforms are not packed. So, if
we use N uint uniforms, they occupy N * 16 by
This is required for the following GLSL bits.
Signed-off-by: Samuel Pitoiset
Reviewed-by: Nicolai Hähnle
---
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/mtypes.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions
Hi,
The latest revision (and hopefully the last one) which should address
all previous/feedbacks.
No regressions with a full piglit run (including compiler tests), and
my private shader-db doesn't report anything bad (RadeonSI).
The Intel CI system doesn't report any failures now.
Please review
The ARB_bindless_texture spec says:
"Samplers are represented using 64-bit integer handles."
and,
"Images are represented using 64-bit integer handles."
It seems simpler to always consider sampler and image types
as 64-bit unsigned integer.
This introduces a temporary workaround in _mesa
Reviewed-by: Bas Nieuwenhuizen
On Tue, May 2, 2017 at 7:17 PM, Grazvydas Ignotas wrote:
> After successful drmGetDevices2() call, drmFreeDevices() needs to be
> called.
>
> Fixes: 743315f2 "radv: do not open random render node(s)"
> Signed-off-by: Grazvydas Ignotas
> ---
> src/amd/vulkan/radv_
Some defensive programming can't hurt.
Reviewed-by: Bas Nieuwenhuizen
On Tue, May 2, 2017 at 7:17 PM, Grazvydas Ignotas wrote:
> drmGetDevices2 takes count and not size. Probably hasn't caused problems
> yet in practice and was missed as setups with more than 8 DRM devices
> are not very common
> PART 2: Call for testing
>
> These drivers have been tested:
> - ddebug
> - llvmpipe
> - r300 (also with SWTCL)
> - r600
> - radeonsi
> - softpipe
> - trace
>
> These drivers need testing:
> - etnaviv
> - freedreno
> - nv30
> - nv50
> - nvc0
> - svga
> - swr
> - vc4
> - virgl
Tested on swr. N
Except a nitpick on patch 1, patches 1-4 are:
Reviewed-by: Samuel Pitoiset
On 05/02/2017 07:36 PM, Eric Anholt wrote:
The spec text cited above says you can't, but only the GLSL 3.00 (redefine
or overload) case was implemented.
Fixes dEQP scoping.invalid.redefine_builtin_fragment/vertex.
---
On 05/02/2017 07:36 PM, Eric Anholt wrote:
From the spec,
Arrays are allowed as arguments, but not as the return type. [...] The
return type can also be a structure if the structure does not contain
an array.
Fixes DEQP shaders.functions.invalid.return_array_in_struct_fragment
Am 02.05.2017 um 21:33 schrieb Eric Anholt:
> ---
>
> Do I have the swizzles right here? It's a bit complicated because I
> have a reswizzle in vc4, so I may have just massaged things to work
> out in my case. I tried a lot of combinations trying to specify BE
> swizzles in a way that wouldn't a
Marek Olšák writes:
> PART 2: Call for testing
>
> These drivers have been tested:
> - ddebug
> - llvmpipe
> - r300 (also with SWTCL)
> - r600
> - radeonsi
> - softpipe
> - trace
>
> These drivers need testing:
> - etnaviv
> - freedreno
> - nv30
> - nv50
> - nvc0
> - svga
> - swr
> - vc4
> - virgl
No piglit regressions.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_format.c
b/src/gallium/drivers/etnaviv/etnaviv_format.c
index 0794603..7c24386 100644
--- a/src/gall
valgrind reports them as leaked, and I could not find anything making a
copy of the nir pointer. Also, radv_device_init_meta_blit_color() is
already freeing them unconditionally like this.
Signed-off-by: Grazvydas Ignotas
---
src/amd/vulkan/radv_meta_blit.c | 6 ++
src/amd/vulkan/radv_query.
Series is
Reviewed-by: Bas Nieuwenhuizen
Fee free to disregard my comment on patch 1, given that its
implementation is almost immediately overwritten.
On Tue, May 2, 2017 at 2:22 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/radv_radeon_wi
On Fri, Apr 28, 2017 at 6:06 AM, Emil Velikov
wrote:
> On 28 April 2017 at 13:55, Eric Engestrom
> wrote:
> > On Friday, 2017-04-28 13:14:20 +0200, Philipp Zabel wrote:
> >> To restart interrupted system calls, use drmIoctl.
> >>
> >> Suggested-by: Emil Velikov
> >> Signed-off-by: Philipp Zabel
On Tue, May 2, 2017 at 2:22 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This just makes it easier to do the follow in cleanups of the surface.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/radv_meta_clear.c | 4 ++--
> src/amd/vulkan/radv_private.h| 9 +
> 2 files changed
1 - 100 of 213 matches
Mail list logo