Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: My feeling about this is that we should recommend that version identifiers be limited to ASCII letters, digits, dots, and underscore, but assume that extension authors are adults and can grasp the risks of using other characters. We should not be in the

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Actually, I was having second thoughts about that while at dinner. What is the value of separating the bootstrap-an-extension-from-old-objects operation into two steps? It's certainly not convenient for users, and I don't see that the intermediate state

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: First off, I don't much care for the name CREATE WRAPPER EXTENSION. WRAPPER is a misnomer in this case --- it's not wrapping anything. I think Dimitri stated that he chose WRAPPER just because it was an already existing keyword, but that isn't much of an

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-11 Thread Jan Urbański
On 10/02/11 22:26, Steve Singer wrote: On 11-02-10 03:13 PM, Jan Urbański wrote: On 10/02/11 20:24, Peter Eisentraut wrote: Here is the rest of my review. Thanks! Ideally char * members of ExceptionMap would be const, but since many versions of python take a non-const value to

Re: [HACKERS] Sorting. When?

2011-02-11 Thread mac_man2...@yahoo.it
Thank you all for your replies. So, is there any precise way to discover when sorting is invoked? Thanks. Regards. Fava Il 11/02/2011 01:17, Robert Haas ha scritto: On Thu, Feb 10, 2011 at 6:21 PM, Nicolas Barbier nicolas.barb...@gmail.com wrote: 2011/2/10

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Anssi Kääriäinen
On 02/11/2011 05:05 AM, Tom Lane wrote: Actually, I was having second thoughts about that while at dinner. What is the value of separating the bootstrap-an-extension-from-old-objects operation into two steps? It's certainly not convenient for users, and I don't see that the intermediate state

Re: [HACKERS] Sorting. When?

2011-02-11 Thread Nicolas Barbier
[ Please don't top-post. URL:http://en.wikipedia.org/wiki/Posting_style ] 2011/2/11 mac_man2...@yahoo.it mac_man2...@yahoo.it: So, is there any precise way to discover when sorting is invoked? EXPLAIN shows how a query would be executed; explicit sorts should be mostly obvious.

[HACKERS] spam (http://wiki.openssi.org/go/PostgreSQL_on_OpenSSI_enabled_Knoppix)

2011-02-11 Thread Oleg Bartunov
I just checked subj. and wondering what does it means and how many spam we may have on wiki ? PostgreSQL on OpenSSI enabled Knoppix From OpenSSI Jump to: navigation, search Acai Berry - The Best Protection For the economy today that are getting down its very important that you can have such

Re: [HACKERS] spam (http://wiki.openssi.org/go/PostgreSQL_on_OpenSSI_enabled_Knoppix)

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 7:14 AM, Oleg Bartunov o...@sai.msu.su wrote: I just checked subj. and wondering what does it means and how many spam we may have on wiki ? Hmm, that's not our wiki, it's on www.openssi.org. But I hit the undo link for them. -- Robert Haas EnterpriseDB:

Re: [HACKERS] spam (http://wiki.openssi.org/go/PostgreSQL_on_OpenSSI_enabled_Knoppix)

2011-02-11 Thread Peter Geoghegan
I think that Acai berry supplements are used as part of various pyramid schemes. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 12:15 AM, Tom Lane t...@sss.pgh.pa.us wrote: David E. Wheeler da...@kineticode.com writes: On Feb 10, 2011, at 7:05 PM, Tom Lane wrote: (I'm not wedded to the phrase FROM OLD in particular, but it does reuse already existing keywords.  Also, maybe it'd be better to

Re: [HACKERS] [PERFORM] pgbench to the MAXINT

2011-02-11 Thread Stephen Frost
Greg, * Tom Lane (t...@sss.pgh.pa.us) wrote: Greg Smith g...@2ndquadrant.com writes: Poking around a bit more, I just discovered another possible approach is to use erand48 instead of rand in pgbench, which is either provided by the OS or emulated in src/port/erand48.c That's way more

Re: [HACKERS] Debian readline/libedit breakage

2011-02-11 Thread Michael Banck
On Thu, Feb 10, 2011 at 06:04:46PM -0500, Tom Lane wrote: Less narrow-minded interpretation of GPL requirements, perhaps. (And yes, we have real lawyers on staff considering these issues.) Is their opinion public/can be made public? This might possibly lead to a re-evaluation of the situation

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: I still think you might be over-designing this. Upgrading from the pre-extension world doesn't need to be elegant; it just has to work. Allow me to disagree here. The main use case is not supporting users that upgrade with extensions to 9.1, but to

Re: [HACKERS] Range Types: -|- ops vs empty range

2011-02-11 Thread Erik Rijkers
On Wed, February 9, 2011 09:35, Jeff Davis wrote: Updated patch. The operators and -|- have the following behavior with empty ranges: testdb=# select '-'::int4range range(200,300); ERROR: empty range testdb=# select '-'::int4range range(200,300); ERROR: empty range testdb=# select

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 9:00 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Robert Haas robertmh...@gmail.com writes: I still think you might be over-designing this.  Upgrading from the pre-extension world doesn't need to be elegant; it just has to work. Allow me to disagree here.  The

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: I don't think it's entirely stupid to worry about this completely screwing up the output of SHOW ALL on people using 80-character terminal windows. I haven't checked, but if it renders the output totally unreadable then I think we should try to

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Feb 11, 2011 at 9:00 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Robert Haas robertmh...@gmail.com writes: I still think you might be over-designing this.  Upgrading from the pre-extension world doesn't need to be elegant; it just has

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-11 Thread Robert Haas
On Thu, Jan 27, 2011 at 2:48 PM, Noah Misch n...@leadboat.com wrote: On Wed, Jan 26, 2011 at 07:31:40AM -0500, Robert Haas wrote: I'd also suggest that this big if-block you changed to a case statement could just as well stay as an if-block.  There are only three cases, and we want to avoid

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Kevin Grittner
Stephen Frost sfr...@snowman.net wrote: That, plus the length of max_predicate_locks_per_transaction, would make 'show all;' go beyond 80 characters even if we took out the description Should we abbreviate something there? max_pred_locks_per_tran, maybe? -Kevin -- Sent via

Re: [HACKERS] multiset patch review

2011-02-11 Thread Robert Haas
On Fri, Feb 4, 2011 at 9:11 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Sat, Feb 5, 2011 at 04:24, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: In math class, maybe.  But in programming, no.  Multiset is a datatype.  Array is a different datatype.  There is no reason why we

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 10:34 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Stephen Frost sfr...@snowman.net wrote: That, plus the length of max_predicate_locks_per_transaction, would make 'show all;' go beyond 80 characters even if we took out the description Should we abbreviate

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Tom Lane
=?ISO-8859-1?Q?Anssi_K=E4=E4ri=E4inen?= anssi.kaariai...@thl.fi writes: The above command assumes there is only one unpackaged version from which users might update from. Is that what is wanted? I am wondering if FROM OLD should be FROM OLD VERSION version (or better: FROM UNPACKAGED

Re: [HACKERS] REVIEW: Determining client_encoding from client locale

2011-02-11 Thread Robert Haas
On Tue, Feb 8, 2011 at 5:05 AM, Ibrar Ahmed ibrar.ah...@gmail.com wrote: Stephen Frost! I have modified the code to use ADD_STARTUP_OPTION instead of writing code again. And  tried the patch on Windows  and Linux and it works for me. Does this need more review, or should it be marked Ready

Re: [HACKERS] pl/python custom datatype parsers

2011-02-11 Thread Robert Haas
On Sun, Feb 6, 2011 at 1:01 PM, Jan Urbański wulc...@wulczer.org wrote: That's it for now. It is an exciting feature and plpython will be the first language to think of when you're building object database if this feature is in. The design here will affect following pl/perl and other so it is

Re: [HACKERS] REVIEW: Determining client_encoding from client locale

2011-02-11 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: On Tue, Feb 8, 2011 at 5:05 AM, Ibrar Ahmed ibrar.ah...@gmail.com wrote: And  tried the patch on Windows  and Linux and it works for me. Does this need more review, or should it be marked Ready for Committer? I think it can be marked ready for

Re: [HACKERS] pl/python tracebacks

2011-02-11 Thread Robert Haas
On Wed, Feb 9, 2011 at 4:10 AM, Jan Urbański wulc...@wulczer.org wrote: On 06/02/11 20:12, Jan Urbański wrote: On 27/01/11 22:58, Jan Urbański wrote: On 23/12/10 14:56, Jan Urbański wrote: Here's a patch implementing traceback support for PL/Python mentioned in

Re: [HACKERS] pl/python invalidate functions with composite arguments

2011-02-11 Thread Robert Haas
On Thu, Feb 10, 2011 at 9:06 PM, Alex Hunsaker bada...@gmail.com wrote: On Wed, Feb 9, 2011 at 02:09, Jan Urbański wulc...@wulczer.org wrote: On 27/01/11 22:42, Jan Urbański wrote: On 23/12/10 14:50, Jan Urbański wrote: Here's a patch implementing properly invalidating functions that have

Re: [HACKERS] pl/python custom datatype parsers

2011-02-11 Thread Jan Urbański
On 11/02/11 16:43, Robert Haas wrote: On Sun, Feb 6, 2011 at 1:01 PM, Jan Urbański wulc...@wulczer.org wrote: That's it for now. It is an exciting feature and plpython will be the first language to think of when you're building object database if this feature is in. The design here will affect

Re: [HACKERS] SSI bug?

2011-02-11 Thread Kevin Grittner
YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: it seems that PredicateLockTupleRowVersionLink sometimes create a loop of targets (it founds an existing 'newtarget' whose nextVersionOfRow chain points to the 'oldtarget') and it later causes CheckTargetForConflictsIn loop forever. Is this a

Re: [HACKERS] multiset patch review

2011-02-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Right, but making the parser slower has a cost, too. ScanKeywordLookup() is already a hotspot in some workloads, and there's overhead buried in the bison parser, too. Yeah. Keep in mind that a bison parser fundamentally runs off a two-dimensional

Re: [HACKERS] pl/python invalidate functions with composite arguments

2011-02-11 Thread Jan Urbański
On 11/02/11 16:47, Robert Haas wrote: On Thu, Feb 10, 2011 at 9:06 PM, Alex Hunsaker bada...@gmail.com wrote: On Wed, Feb 9, 2011 at 02:09, Jan Urbański wulc...@wulczer.org wrote: It seems a bit heavy handed to invalidate and remake the entire plpython function whenever we hit this case. I

Re: [HACKERS] REVIEW: Determining client_encoding from client locale

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 10:45 AM, Stephen Frost sfr...@snowman.net wrote: * Robert Haas (robertmh...@gmail.com) wrote: On Tue, Feb 8, 2011 at 5:05 AM, Ibrar Ahmed ibrar.ah...@gmail.com wrote: And  tried the patch on Windows  and Linux and it works for me. Does this need more review, or

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: On Fri, Feb 11, 2011 at 10:34 AM, Kevin Grittner Should we abbreviate something there?  max_pred_locks_per_tran, maybe? If we're going to abbreviate transaction, I'd vote for txn over tran, but I think Stephen's point that this is already a

Re: [HACKERS] pl/python invalidate functions with composite arguments

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 10:51 AM, Jan Urbański wulc...@wulczer.org wrote: On 11/02/11 16:47, Robert Haas wrote: On Thu, Feb 10, 2011 at 9:06 PM, Alex Hunsaker bada...@gmail.com wrote: On Wed, Feb 9, 2011 at 02:09, Jan Urbański wulc...@wulczer.org wrote: It seems a bit heavy handed to

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 10:52 AM, Stephen Frost sfr...@snowman.net wrote: * Robert Haas (robertmh...@gmail.com) wrote: On Fri, Feb 11, 2011 at 10:34 AM, Kevin Grittner Should we abbreviate something there?  max_pred_locks_per_tran, maybe? If we're going to abbreviate transaction, I'd vote

Re: [HACKERS] pl/python invalidate functions with composite arguments

2011-02-11 Thread Alex Hunsaker
On Fri, Feb 11, 2011 at 08:47, Robert Haas robertmh...@gmail.com wrote: On Thu, Feb 10, 2011 at 9:06 PM, Alex Hunsaker bada...@gmail.com wrote: On Wed, Feb 9, 2011 at 02:09, Jan Urbański wulc...@wulczer.org wrote: On 27/01/11 22:42, Jan Urbański wrote: On 23/12/10 14:50, Jan Urbański wrote:

Re: [HACKERS] pl/python custom datatype parsers

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 10:49 AM, Jan Urbański wulc...@wulczer.org wrote: On 11/02/11 16:43, Robert Haas wrote: On Sun, Feb 6, 2011 at 1:01 PM, Jan Urbański wulc...@wulczer.org wrote: That's it for now. It is an exciting feature and plpython will be the first language to think of when you're

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: Yeah. The root cause of this problem is that the way psql handles tabular output with a few very wide rows stinks. True, but it would be kinda nice to support multi-line configuration variables. I still vote for that being not required to get this

Re: [HACKERS] SQL/MED - file_fdw

2011-02-11 Thread Robert Haas
On Wed, Feb 9, 2011 at 2:03 AM, Noah Misch n...@leadboat.com wrote: From a functional and code structure perspective, I find this ready to commit. (I assume you'll drop the XXX: indent only comments on commit.)  Kevin, did you want to do that performance testing you spoke of? OK, so is this

Re: [HACKERS] multiset patch review

2011-02-11 Thread Itagaki Takahiro
On Sat, Feb 12, 2011 at 00:50, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Right, but making the parser slower has a cost, too. ScanKeywordLookup() is already a hotspot in some workloads, and there's overhead buried in the bison parser, too. Yeah.  Keep in

Re: [HACKERS] pl/python explicit subtransactions

2011-02-11 Thread Steve Singer
On 11-02-10 05:20 AM, Jan Urbański wrote: D'oh, I was thinking about whether it's safe to skip the internal subxact if you're in an implicit one and somehow I always convinced myself that since you eventually close the explicit one, it is. Obviously my testing wasn't enough :( Attaching an

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: CREATE EXTENSION foo [ VERSION targetversion ] [ FROM oldversion ] I came to the same conclusion but added my version aliases idea in there so that it could maybe be easy for the user not to confuse things. I still think that free form version

Re: [HACKERS] pl/python tracebacks

2011-02-11 Thread Alex Hunsaker
On Fri, Feb 11, 2011 at 08:45, Robert Haas robertmh...@gmail.com wrote: On Wed, Feb 9, 2011 at 4:10 AM, Jan Urbański wulc...@wulczer.org wrote: On 06/02/11 20:12, Jan Urbański wrote: On 27/01/11 22:58, Jan Urbański wrote: On 23/12/10 14:56, Jan Urbański wrote: Here's a patch implementing

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Stephen Frost
* Itagaki Takahiro (itagaki.takah...@gmail.com) wrote: On Mon, Feb 7, 2011 at 04:10, Stephen Frost sfr...@snowman.net wrote: Yeah, doesn't seem to work for me (missing '/bin/collateindex.pl', apparently..). You might need yum install openjade stylesheets or similar packages and

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Feb 11, 2011 at 10:34 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Should we abbreviate something there?  max_pred_locks_per_tran, maybe? If we're going to abbreviate transaction, I'd vote for txn over tran, but I think Stephen's

Re: [HACKERS] multiset patch review

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 11:17 AM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: Did you measure the actual cost in the real world? If we are using such a sensitive parser, it should be a problem even without the patch. It *is* a problem without the patch! Adding unnecessary keywords is

Re: [HACKERS] SQL/MED - file_fdw

2011-02-11 Thread Itagaki Takahiro
On Sat, Feb 12, 2011 at 01:12, Robert Haas robertmh...@gmail.com wrote: On Wed, Feb 9, 2011 at 2:03 AM, Noah Misch n...@leadboat.com wrote: From a functional and code structure perspective, I find this ready to commit. (I assume you'll drop the XXX: indent only comments on commit.)  Kevin,

Re: [HACKERS] SQL/MED - file_fdw

2011-02-11 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: Noah Misch n...@leadboat.com wrote: From a functional and code structure perspective, I find this ready to commit. (I assume you'll drop the XXX: indent only comments on commit.) Kevin, did you want to do that performance testing you spoke of? OK,

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: Robert Haas robertmh...@gmail.com writes: If we're going to abbreviate transaction, I'd vote for txn over tran, but I think Stephen's point that this is already a lost cause may have some validity. Not sure what other people think. I agree w/

Re: [HACKERS] SQL/MED - file_fdw

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 11:31 AM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Sat, Feb 12, 2011 at 01:12, Robert Haas robertmh...@gmail.com wrote: On Wed, Feb 9, 2011 at 2:03 AM, Noah Misch n...@leadboat.com wrote: From a functional and code structure perspective, I find this ready to

Re: [HACKERS] pl/python tracebacks

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 11:22 AM, Alex Hunsaker bada...@gmail.com wrote: On Fri, Feb 11, 2011 at 08:45, Robert Haas robertmh...@gmail.com wrote: On Wed, Feb 9, 2011 at 4:10 AM, Jan Urbański wulc...@wulczer.org wrote: On 06/02/11 20:12, Jan Urbański wrote: On 27/01/11 22:58, Jan Urbański wrote:

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: I can already hear people wanting version aliases instead. We could support e.g. 4 or 5 aliases like 'stable', 'support', 'alpha', 'beta' and maybe 'experimental'. Then rather than defining current_version

Re: [HACKERS] SQL/MED - file_fdw

2011-02-11 Thread Kevin Grittner
Itagaki Takahiro itagaki.takah...@gmail.com wrote: Basically, we have no more tasks until the FDW core API is applied. COPY API and file_fdw patches are waiting for it. This is something I've found confusing about this patch set, to the point of not knowing what to test, exactly. The COPY

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Is there a test somewhere that when CREATE OR REPLACE FUNCTION runs from an extension's script at upgrade, the function must already be attached to the extension if it exists in the system? Ditto for views etc? IIRC, the current behavior is

Re: [HACKERS] SQL/MED - file_fdw

2011-02-11 Thread Noah Misch
On Fri, Feb 11, 2011 at 10:31:08AM -0600, Kevin Grittner wrote: Robert Haas robertmh...@gmail.com wrote: Noah Misch n...@leadboat.com wrote: From a functional and code structure perspective, I find this ready to commit. (I assume you'll drop the XXX: indent only comments on commit.)

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: * Itagaki Takahiro (itagaki.takah...@gmail.com) wrote: You might need yum install openjade stylesheets or similar packages and re-configure. I've got openjade, etc, installed, but I'm on Debian and it doesn't appear to include that collateindex.pl

Re: [HACKERS] Change pg_last_xlog_receive_location not to move backwards

2011-02-11 Thread Stephen Frost
Fujii, all, * Fujii Masao (masao.fu...@gmail.com) wrote: That logic exists because we'd like to check that newly-received WAL data is consistent with previous one by validating the header of new WAL file. So since we need the header of new WAL file, we retreat the replication starting

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Alvaro Herrera
Excerpts from Tom Lane's message of vie feb 11 13:49:33 -0300 2011: Stephen Frost sfr...@snowman.net writes: * Itagaki Takahiro (itagaki.takah...@gmail.com) wrote: You might need yum install openjade stylesheets or similar packages and re-configure. I've got openjade, etc, installed,

Re: [HACKERS] Range Types: -|- ops vs empty range

2011-02-11 Thread Jeff Davis
On Fri, 2011-02-11 at 15:09 +0100, Erik Rijkers wrote: On Wed, February 9, 2011 09:35, Jeff Davis wrote: Updated patch. The operators and -|- have the following behavior with empty ranges: testdb=# select '-'::int4range range(200,300); ERROR: empty range testdb=# select

Re: [HACKERS] Add support for logging the current role

2011-02-11 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: $ which collateindex.pl /usr/bin/collateindex.pl $ rpm -qf /usr/bin/collateindex.pl docbook-style-dsssl-1.79-11.fc13.noarch Ah-hah, thanks for that! Apparently on Debian it's docbook-dsssl that contains it, and yes, it gets installed into /usr/bin (not

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: After a bit of reflection I think we should stick with default_version as the parameter name in 9.1. If we want to open it up to allowing arbitrary version aliases later, we can let it accept xxx_version as defining an alias xxx. That seems a lot safer

Re: [HACKERS] SQL/MED - file_fdw

2011-02-11 Thread Kevin Grittner
Noah Misch n...@leadboat.com wrote: I'd say, run them with this patch alone. The important thing is to not penalize existing COPY users. Sounds good. Incidentally, the did you want ... ? was a genuine question. I see very little performance risk here, so the tests could be quite

Re: [HACKERS] Range Types: -|- ops vs empty range

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 11:55 AM, Jeff Davis pg...@j-davis.com wrote: On Fri, 2011-02-11 at 15:09 +0100, Erik Rijkers wrote: On Wed, February 9, 2011 09:35, Jeff Davis wrote: Updated patch. The operators      and -|-  have the following behavior with empty ranges: testdb=# select

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: 1. If you pick the wrong FROM version, the upgrade script will almost certainly fail, because the objects won't exist or won't be in the state it expects (ie, not already members of the extension). IIRC, the current behavior is that C.O.R.F. on an existing

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: Uh, not sure how you're envisioning that working? If it fails to find an upgrade script path from the current version to whatever is default, it will still fail to find any path after you explicitly tell it

Re: [HACKERS] pl/python tracebacks

2011-02-11 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: Goodness... I picked up this patch the day before yesterday because no-one was listed. That being said, if anyone else wants to beat me to the punch of reviewing this, have at it! The more eyes the merrier! Sorry, I didn't see when you'd picked it

Re: [HACKERS] FOR KEY LOCK foreign keys

2011-02-11 Thread Alvaro Herrera
Excerpts from Noah Misch's message of vie feb 11 04:13:22 -0300 2011: Hello, First, thanks for the very thorough review. On Thu, Jan 13, 2011 at 06:58:09PM -0300, Alvaro Herrera wrote: Incidentally, HeapTupleSatisfiesMVCC has some bits of code like this (not new): /* MultiXacts

Re: [HACKERS] Careful PL/Perl Release Not Required

2011-02-11 Thread David E. Wheeler
On Feb 10, 2011, at 11:43 PM, Alex Hunsaker wrote: I'd like to quibble with you over this point if I may. :-) Per perldoc: JSON::XS utf8 flag disabled When utf8 is disabled (the default), then encode/decode generate and expect Unicode strings ... So - If you are on 9.1 and a

Re: [HACKERS] Change pg_last_xlog_receive_location not to move backwards

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 11:52 AM, Stephen Frost sfr...@snowman.net wrote: Fujii, all, * Fujii Masao (masao.fu...@gmail.com) wrote: That logic exists because we'd like to check that newly-received WAL data is consistent with previous one by validating the header of new WAL file. So since we

Re: [HACKERS] Range Types: -|- ops vs empty range

2011-02-11 Thread Jeff Davis
On Fri, 2011-02-11 at 12:03 -0500, Robert Haas wrote: For what it's worth, my completely uninformed opinion is that comparison operators shouldn't error out. I haven't read the patch so I'm not sure what those operators are defined to do, though. means strictly right of means strictly left

Re: [HACKERS] Change pg_last_xlog_receive_location not to move backwards

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 12:25 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Feb 11, 2011 at 11:52 AM, Stephen Frost sfr...@snowman.net wrote: Fujii, all, * Fujii Masao (masao.fu...@gmail.com) wrote: That logic exists because we'd like to check that newly-received WAL data is

Re: [HACKERS] Careful PL/Perl Release Not Required

2011-02-11 Thread Andrew Dunstan
On 02/11/2011 12:16 PM, David E. Wheeler wrote: [long discussion elided] Is there an action item here? Is the documentation inadequate or inaccurate? If so, please make a suggestion for improved wording. I certainly expect the change to be covered in the release notes. You can check on

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: That's not exactly what happens here. There would be no support version alias in the control file, so no way to upgrade to it, and support would happen to be what ALTER EXTENSION foo UPDATE would consider when you don't mention explicitly the target

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Tom Lane
OK, let me see if I can summarize what I think we've agreed to: CREATE syntax is extended to CREATE EXTENSION extname [WITH] [SCHEMA s] [VERSION v] [FROM oldv] If VERSION is not specified, v is taken from default_version in the control file, or fail if that's not given either. We

Re: [HACKERS] Range Types: -|- ops vs empty range

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 12:26 PM, Jeff Davis pg...@j-davis.com wrote: On Fri, 2011-02-11 at 12:03 -0500, Robert Haas wrote: For what it's worth, my completely uninformed opinion is that comparison operators shouldn't error out.  I haven't read the patch so I'm not sure what those operators are

Re: [HACKERS] Careful PL/Perl Release Not Required

2011-02-11 Thread Alex Hunsaker
On Fri, Feb 11, 2011 at 10:16, David E. Wheeler da...@kineticode.com wrote: On Feb 10, 2011, at 11:43 PM, Alex Hunsaker wrote: Like I said, the terminology is awful. Yeah I use encode and decode to mean the same thing frequently :-(. In the the cited case he was passing %C3%A9 to

Re: [HACKERS] Range Types: -|- ops vs empty range

2011-02-11 Thread Kevin Grittner
Jeff Davis pg...@j-davis.com wrote: means strictly right of means strictly left of -|- means adjacent (touching but not overlapping) I'm open to suggestion about how those behave with empty ranges. OK, that still leaves a lot to the imagination, though. To try to clarify in *my* mind:

Re: [HACKERS] Debian readline/libedit breakage

2011-02-11 Thread Greg Smith
Michael Banck wrote: On Thu, Feb 10, 2011 at 06:04:46PM -0500, Tom Lane wrote: Less narrow-minded interpretation of GPL requirements, perhaps. (And yes, we have real lawyers on staff considering these issues.) Is their opinion public/can be made public? This might possibly lead to a

Re: [HACKERS] Change pg_last_xlog_receive_location not to move backwards

2011-02-11 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: Actually... wait a minute. Now that I'm thinking about this a little more, I'm not so convinced. If we leave this the way is, and just paper over the problem using the method Stephen and I both had in mind, then we could be streaming from a

Re: [HACKERS] Range Types: -|- ops vs empty range

2011-02-11 Thread Andrew Dunstan
On 02/11/2011 12:36 PM, Robert Haas wrote: On Fri, Feb 11, 2011 at 12:26 PM, Jeff Davispg...@j-davis.com wrote: On Fri, 2011-02-11 at 12:03 -0500, Robert Haas wrote: For what it's worth, my completely uninformed opinion is that comparison operators shouldn't error out. I haven't read the

Re: [HACKERS] Careful PL/Perl Release Not Required

2011-02-11 Thread Alex Hunsaker
On Fri, Feb 11, 2011 at 10:44, Alex Hunsaker bada...@gmail.com wrote: On Fri, Feb 11, 2011 at 10:16, David E. Wheeler da...@kineticode.com wrote: That *looks* like it is decoding the input string, which it is, but actually that will double utf8 encode your string. It does not seem to in this

Re: [HACKERS] Range Types: -|- ops vs empty range

2011-02-11 Thread Josh Berkus
empty range = Zero length? If so, is it fixed at some point, but empty? '(x,x)'? '[x,x)'? Neither of the above should be possible, I think. The expression (x logically excludes the expression x). However, [x,x] would be valid, and would be a zero-length interval at

Re: [HACKERS] Careful PL/Perl Release Not Required

2011-02-11 Thread David E. Wheeler
On Feb 11, 2011, at 9:44 AM, Alex Hunsaker wrote: It is decoded... the input string %C3%A9 actually is the _same_ string utf-8, latin1 and SQL_ASCII decoded or not. Those are all ascii characters. Calling utf8::decode(%C3%A9) is essentially a noop. No, it's not decoded. It doesn't matter

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: Hmm. To make that work, we'd have to have ALTER EXTENSION UPDATE use a different default version name from what CREATE EXTENSION uses (unless Yes. I see that as a good feature to have. stable and support

Re: [HACKERS] Careful PL/Perl Release Not Required

2011-02-11 Thread David E. Wheeler
On Feb 11, 2011, at 9:34 AM, Andrew Dunstan wrote: Is there an action item here? Is the documentation inadequate or inaccurate? If so, please make a suggestion for improved wording. I certainly expect the change to be covered in the release notes. You can check on the prominence given the

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 12:35 PM, Tom Lane t...@sss.pgh.pa.us wrote: OK, let me see if I can summarize what I think we've agreed to: CREATE syntax is extended to        CREATE EXTENSION extname [WITH] [SCHEMA s] [VERSION v] [FROM oldv] It strikes me that if you used the same options syntax

Re: [HACKERS] Careful PL/Perl Release Not Required

2011-02-11 Thread David E. Wheeler
On Feb 11, 2011, at 10:01 AM, Alex Hunsaker wrote: That *looks* like it is decoding the input string, which it is, but actually that will double utf8 encode your string. It does not seem to in this case because we are dealing with all ascii input. The trick here is its also telling perl to

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-11 Thread Noah Misch
Hi Robert, On Fri, Feb 11, 2011 at 10:27:11AM -0500, Robert Haas wrote: On Thu, Jan 27, 2011 at 2:48 PM, Noah Misch n...@leadboat.com wrote: Done as attached. ?This preserves compatibility with our current handling of composite type dependencies. ?The rest you've seen before. OK, I

Re: [HACKERS] Range Types: -|- ops vs empty range

2011-02-11 Thread Erik Rijkers
On Fri, February 11, 2011 19:02, Josh Berkus wrote: empty range = Zero length? If so, is it fixed at some point, but empty? '(x,x)'? '[x,x)'? Neither of the above should be possible, I think. The expression (x logically excludes the expression x). However, [x,x]

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Robert Haas
On Fri, Feb 11, 2011 at 1:06 PM, Tom Lane t...@sss.pgh.pa.us wrote: Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: Hmm.  To make that work, we'd have to have ALTER EXTENSION UPDATE use a different default version name from what CREATE EXTENSION uses (unless

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread David E. Wheeler
On Feb 11, 2011, at 10:06 AM, Tom Lane wrote: Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: Hmm. To make that work, we'd have to have ALTER EXTENSION UPDATE use a different default version name from what CREATE EXTENSION uses (unless Yes. I see that

Re: [HACKERS] Range Types: -|- ops vs empty range

2011-02-11 Thread Kevin Grittner
Josh Berkus j...@agliodbs.com wrote: I can imagine using all of these constructs in actual applications. But which of them, if any, is an empty range? -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Josh Berkus
CREATE EXTENSION extname [ ( option [ , ... ] ) ] where option can be one of: SCHEMA blah VERSION blah FROM blah +1 This also means that users don't have to remember the specific ordering of the syntax, which is a big plus. -- -- Josh Berkus

[HACKERS] Range Types: empty ranges

2011-02-11 Thread Jeff Davis
Do we want empty ranges? The philosophy is that they are essentially the zero value of any range type. Like the number zero, it allows closure over operations that would otherwise return an error. For instance, the number zero is useful because you can do things like: f(x) = 5x + 3; And even

Re: [HACKERS] Debian readline/libedit breakage

2011-02-11 Thread Stephen Frost
* Greg Smith (g...@2ndquadrant.com) wrote: -GNU libreadine is certainly never going to add an OpenSSL exemption I really wish they would, that's just them being obnoxious- it's already LGPL, after all.. -If the OpenSSL project was going to switch to a reasonable license, they'd have done it

Re: [HACKERS] Debian readline/libedit breakage

2011-02-11 Thread Magnus Hagander
On Fri, Feb 11, 2011 at 19:13, Stephen Frost sfr...@snowman.net wrote: * Greg Smith (g...@2ndquadrant.com) wrote: -Adding GnuTLS support to PostgreSQL would require solving several code quality issues I'm curious about this, but I don't know that I've got time to dive into it and solve it.

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread David E. Wheeler
On Feb 11, 2011, at 9:35 AM, Tom Lane wrote: OK, let me see if I can summarize what I think we've agreed to: CREATE syntax is extended to CREATE EXTENSION extname [WITH] [SCHEMA s] [VERSION v] [FROM oldv] If VERSION is not specified, v is taken from default_version in the control

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Feb 11, 2011 at 12:35 PM, Tom Lane t...@sss.pgh.pa.us wrote: OK, let me see if I can summarize what I think we've agreed to: CREATE syntax is extended to CREATE EXTENSION extname [WITH] [SCHEMA s] [VERSION v] [FROM oldv] It strikes

Re: [HACKERS] Debian readline/libedit breakage

2011-02-11 Thread Stephen Frost
* Magnus Hagander (mag...@hagander.net) wrote: We may also have a problem in that libpq exposes OpenSSL structs, though. We actually return it as a void *, to make it possible to change, but there's no API in libpq to tell you what it is... Ugh, yeah, that probably wasn't the best decision in

  1   2   3   >