Re: Gamepad KCM

2023-08-01 Thread Jeremy Whiting
On Sun, Jul 30, 2023 at 1:30 AM David Edmundson wrote: > b) merge it into the gamepad-kcm repo itself > > I would suggest doing this. It'll be easiest for future gamepad-kcm > devs to find than any other repo, and means it'll be obvious if it > ever becomes obsoleted. > Ok, I've copied it into g

Gamepad KCM

2023-08-01 Thread Jeremy Whiting
Hello, For the past while Josh and I have spent some time working on a new gamepad kcm. It currently lives here [1] but we'd like to move it to plasma after a review period. It also uses an inkscape plugin to export parts of an svg file to svg images and a qml file for a given gamepad type. The in

D24276: Add text to speech functionality to klipper.

2019-10-16 Thread Jeremy Whiting
whiting added a comment. In D24276#548330 , @mart wrote: > this only affects the old standalone executable, right? Um, I guess so. I didn't realize there was something else... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://

D24276: Add text to speech functionality to klipper.

2019-10-09 Thread Jeremy Whiting
whiting updated this revision to Diff 67585. whiting added a comment. - Add speech synthesis engine selection combobox to general klipper settings page. Rebased on master. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24276?vs=66980&id=67585

D24276: Add text to speech functionality to klipper.

2019-10-03 Thread Jeremy Whiting
whiting added a comment. Does anyone have any opinion on this change? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24276 To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampal

D24276: Add text to speech functionality to klipper.

2019-09-27 Thread Jeremy Whiting
whiting updated this revision to Diff 66980. whiting added a comment. - Add speech synthesis engine selection combobox to general klipper settings page. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24276?vs=66978&id=66980 BRANCH speech REVIS

D24276: Add text to speech functionality to klipper.

2019-09-27 Thread Jeremy Whiting
whiting created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. whiting requested review of this revision. REVISION SUMMARY Add action with global shortcut to speak text selection and another to speak clipboard contents. Add another action to stop spea

D24224: Start of the accessibility KCM

2019-09-25 Thread Jeremy Whiting
whiting added a comment. Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard Filters and Activation Gestures) T

Re: Review Request 128856: Adds a check for kauthorized ghns so administrators can disable ghns if wanted

2016-09-08 Thread Jeremy Whiting
----- On Sept. 7, 2016, 3:43 p.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128856/ > ---

Re: Review Request 128856: Adds a check for kauthorized ghns so administrators can disable ghns if wanted

2016-09-07 Thread Jeremy Whiting
marked as submitted. Review request for Plasma, Aleix Pol Gonzalez, Kai Uwe Broulik, and David Faure. Changes --- Submitted with commit 2a7ac6f0753427f865fc9013868990cb3b530ecf by Jeremy Whiting to branch master. Bugs: 368240 https://bugs.kde.org/show_bug.cgi?id=368240 Repository

Review Request 128856: Adds a check for kauthorized ghns so administrators can disable ghns if wanted

2016-09-07 Thread Jeremy Whiting
e and somehow goes around these checks. Need to figure out why it's doing that and if it's still neeeded there or how to catch those calls to show also. Thanks, Jeremy Whiting

[Differential] [Commented On] D2409: Update Color KCM

2016-08-11 Thread whiting (Jeremy Whiting)
whiting added a comment. I like it. Nice work. I agree I would change Config Scheme to Edit Scheme. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud,

Re: Review Request 127828: Remove .desktop file, it is unused and unhelpful as the app is called by ssh-add not run directly

2016-05-04 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127828/#review95162 --- Ship it! Ship It! - Jeremy Whiting On May 4, 2016, 6

Re: remove khelpcenter from next Plasma release?

2016-03-15 Thread Jeremy Whiting
As an application developer I agree it makes sense to have khelpcenter released with KDE Applications. I also agree with Albert's point that having online documentation isn't the best since it could be newer than what's actually running. People using LTS distributions or "stable" variants of less o

Re: Review Request 125622: Use better guard against recursion when changing volume with sliders

2015-10-30 Thread Jeremy Whiting
- Jeremy Whiting On Oct. 15, 2015, 8:12 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

2015-10-30 Thread Jeremy Whiting
ttachments screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/10/16/2f8f36d8-dea2-4679-8826-96ebbaa8c8e9__mangonel.png Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.o

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

2015-10-16 Thread Jeremy Whiting
something. - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/#review86929 --- On Oct. 16, 2015, 9:42 a.m., Jeremy Whit

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

2015-10-16 Thread Jeremy Whiting
t https://git.reviewboard.kde.org/media/uploaded/files/2015/10/16/2f8f36d8-dea2-4679-8826-96ebbaa8c8e9__mangonel.png Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125662: mangonel: Initial port to Qt5/KF5

2015-10-16 Thread Jeremy Whiting
/r/125662/diff/ Testing --- It builds and runs, but looks a bit strange since it's a plani QWidget. (Maybe we could say it's using Material design and call it good, dunno :p) Thanks, Jeremy Whiting ___ Plasma-devel mailing list Pl

Re: new mobile image, oh it's gorgeous

2015-09-21 Thread Jeremy Whiting
neon.png seems to be missing. Just FYI. On Mon, Sep 21, 2015 at 5:09 PM, Jonathan Riddell wrote: > I rebuilt all the packages in mobile kci to give a new image, > 20150921.213107,version=3 > > http://kubuntu.plasma-mobile.org/ > > with mirror up at > http://mobile.edinburghlinux.co.uk/ > > Jonath

Re: Adding further modules to api.kde.org

2015-09-10 Thread Jeremy Whiting
Allen, Those are both KDE4 versions of workspace stuff. I don't see any place where kf5 versions are. BR, Jeremy On Thu, Sep 10, 2015 at 1:50 PM, Allen Winter wrote: > On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote: >> Hi all, >> >> back in KDE4 days the workspace libraries

Re: Adding further modules to api.kde.org

2015-09-10 Thread Jeremy Whiting
eremy On Thu, Sep 10, 2015 at 11:05 AM, Adriaan de Groot wrote: > On Thursday 10 September 2015 06:07:40 Jeremy Whiting wrote: >> It would be awesome to have what used to be in KDE SC on api.kde.org >> again. We have many libraries that aren't frameworks that are Qt5/KF5

Re: Adding further modules to api.kde.org

2015-09-10 Thread Jeremy Whiting
Martin, I took a look at this as part of the gardening documentation websites, but I didn't get very far. The code that runs this and ebn is in kde:websites/quality-kde-org and is pretty outdated unfortunately. Actually now that Allen Winter is back maybe he could add it (Added him to cc)? What I

Re: Review Request 125060: Added .gitignore

2015-09-05 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125060/#review84884 --- Ship it! Ship It! - Jeremy Whiting On Sept. 5, 2015, 2:01

Re: Review Request 125041: Move kaccess into separate source directory

2015-09-03 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125041/#review84804 --- Ship it! Ship It! - Jeremy Whiting On Sept. 3, 2015, 4:53

Re: Review Request 124114: Add "Lock Screen" to desktop toolbox

2015-08-31 Thread Jeremy Whiting
> On June 16, 2015, 9:29 p.m., David Edmundson wrote: > > > This does not check KAuthorized before to hide the entry but neither does > > > the context menu. > > > > Well that's a bit rubbish. > > Ship this, but lets remember to fix both, poke me if it gets near release > > and I haven't. > >

[Breeze] [Bug 351875] Some drop-down menus don't inherit the correct color value from Breeze-Dark theme.

2015-08-31 Thread Jeremy Whiting
https://bugs.kde.org/show_bug.cgi?id=351875 --- Comment #5 from Jeremy Whiting --- Yes, I've rebooted twice or more since I switched to Breeze Dark theme. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-

[Breeze] [Bug 351875] Some drop-down menus don't inherit the correct color value from Breeze-Dark theme.

2015-08-31 Thread Jeremy Whiting
https://bugs.kde.org/show_bug.cgi?id=351875 Jeremy Whiting changed: What|Removed |Added CC||jpwhit...@kde.org --- Comment #3 from Jeremy

Re: Review Request 124959: Shorten labels of QCheckBox so the accessibility kcm won't need a scrollbar.

2015-08-28 Thread Jeremy Whiting
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 78644357249af839cecc421f25b557e32ea2345b by Jeremy Whiting to branch master. Bugs: 339407 https://bugs.kde.org/show_bug.cgi?id=339407 Repository: plasma-desktop Description --- BUG:339407

Re: Review Request 124799: Add look and feel package for Breeze Dark theme.

2015-08-27 Thread Jeremy Whiting
. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124959: Shorten labels of QCheckBox so the accessibility kcm won't need a scrollbar.

2015-08-27 Thread Jeremy Whiting
scrollbars are gone. We should probably think about shortening the wording even more though or simplifying this kcm a bit. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124872: Default to Breeze colors

2015-08-24 Thread Jeremy Whiting
> On Aug. 24, 2015, 12:13 a.m., Martin Gräßlin wrote: > > I must say I'm rather shocked at how this is implemented. Would it be > > possible to move the defaults into our QPT plugin, so that these defaults > > are only applied if running on a platform with our plugin, otherwise it > > picks Qt

Re: Review Request 124885: Fix issues in translation control module

2015-08-22 Thread Jeremy Whiting
> On Aug. 22, 2015, 7:47 p.m., Jeremy Whiting wrote: > > Ship It! Incidentally, the pt issue sounds like a QLocale bug, do we need to find one or file a new one for that probably? - Jeremy --- This is an automatically generat

Re: Review Request 124885: Fix issues in translation control module

2015-08-22 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124885/#review84202 --- Ship it! Ship It! - Jeremy Whiting On Aug. 22, 2015, 6:34

Re: Review Request 124872: Default to Breeze colors

2015-08-21 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/#review84166 --- Ship it! Ship It! - Jeremy Whiting On Aug. 21, 2015, 3:35

Re: Review Request 124799: Add look and feel package for Breeze Dark theme.

2015-08-20 Thread Jeremy Whiting
kiconthemes. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: Add look and feel package for Breeze Dark theme.

2015-08-20 Thread Jeremy Whiting
On Aug. 20, 2015, 7:15 p.m., Jeremy Whiting wrote: > > The main Breeze l&f is in plasma-workspace. > > Do we want them together? Sebas suggested it go into breeze since that's where the other breeze dark stuff lives. I'm fine

Re: Review Request 124799: Add look and feel package for Breeze Dark theme.

2015-08-18 Thread Jeremy Whiting
been fixed today by dfaure in kiconthemes. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

2015-08-18 Thread Jeremy Whiting
c/main.cpp:160 Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

2015-08-18 Thread Jeremy Whiting
) () from /usr/lib/libQt5Core.so.5 #24 0x004cbb35 in main (argc=1, argv=) at /home/jeremy/devel/kde/src/extragear/network/konversation/src/main.cpp:160 Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.o

Re: Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

2015-08-18 Thread Jeremy Whiting
Heh, no, probably not. - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124799/#review83990 --- On Aug. 18, 2015

Re: Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

2015-08-18 Thread Jeremy Whiting
Flags) () from /usr/lib/libQt5Core.so.5 #23 0x7f76d9bbe20c in QCoreApplication::exec() () from /usr/lib/libQt5Core.so.5 #24 0x004cbb35 in main (argc=1, argv=) at /home/jeremy/devel/kde/src/extragear/network/konversation/src/main.cpp:160 Thanks,

Re: Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

2015-08-17 Thread Jeremy Whiting
g the "Icon" theme, some backtraces show some things in KIconLoader also. Seems the icon theme changing is what's causing these crashes. - Jeremy Whiting On Aug. 17, 2015, 6:55 p.m., Jeremy Whiting wrote: > > ---

Review Request 124799: WIP: Add look and feel package for Breeze Dark theme.

2015-08-17 Thread Jeremy Whiting
p::exec(QFlags) () from /usr/lib/libQt5Core.so.5 #23 0x7f76d9bbe20c in QCoreApplication::exec() () from /usr/lib/libQt5Core.so.5 #24 0x004cbb35 in main (argc=1, argv=) at /home/jeremy/devel/kde/src/extragear/network/konversation/src/main.cpp:160 Thanks,

Re: Minutes Monday Plasma Hangout

2015-08-17 Thread Jeremy Whiting
On Mon, Aug 17, 2015 at 4:42 AM, Sebastian Kügler wrote: > Present: Bhushan, David, Jens, Kai Uwe, Martin G, Ozark, Sebastian > Date: 17 August, 2015 > > Bhushan: > - working on apps, first off comic book reader > - Looked into Plasma Moible on Archlinux: > https://github.com/bhush9/plasma-arch >

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

2015-07-31 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124534/#review83236 --- Ship it! Ship It! - Jeremy Whiting On July 31, 2015, 7:03

Re: Review Request 121097: Add a FileDialog to choose the image for fifteenpuzzle.

2015-04-03 Thread Jeremy Whiting
ontents/ui/configAppearance.qml 5dfd2317bdc26849d1705e8826510bd05176b963 Diff: https://git.reviewboard.kde.org/r/121097/diff/ Testing --- Doesn't work here, but I'm hoping it's just a local problem. Thanks, Jeremy Whiting ___ Plasma-devel

Re: Review Request 123079: digitalclock: Don't reverse js timezone offset when using to generate utc from local time.

2015-03-20 Thread Jeremy Whiting
marked as submitted. Review request for Plasma and Martin Klapetek. Changes --- Submitted with commit 0b82fc7e455bdc2c4b419c26e1f5349205c25a65 by Jeremy Whiting to branch Plasma/5.2. Repository: plasma-workspace Description --- digitalclock: Don't reverse js timezone offset

Review Request 123079: digitalclock: Don't reverse js timezone offset when using to generate utc from local time.

2015-03-19 Thread Jeremy Whiting
ectly. My local time in the tooltip has the right time now. All others are also calculated correctly now. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Plasma Workspace Wallpapers] [Bug 344586] No download and setting of new wallpapers, themes and so on possible.

2015-03-16 Thread Jeremy Whiting
https://bugs.kde.org/show_bug.cgi?id=344586 Jeremy Whiting changed: What|Removed |Added Resolution|--- |DUPLICATE CC

Re: Review Request 122823: Avoid KDE4 lingo in colors kcm

2015-03-04 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122823/#review77038 --- Ship it! Ship It! - Jeremy Whiting On March 4, 2015, 6:49

Re: Review Request 122467: Add "open wallpaper" action

2015-02-07 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122467/#review75575 --- Ship it! Ship It! - Jeremy Whiting On Feb. 7, 2015, 1:19

Re: Review Request 122464: Remove bell kcm

2015-02-07 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122464/#review75561 --- Ship it! Ship It! - Jeremy Whiting On Feb. 7, 2015, 5:55

Re: Review Request 121833: add reviewboardrc, targets kdeframeworks and plasma groups

2015-01-04 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121833/#review73077 --- Ship it! Ship It! - Jeremy Whiting On Jan. 4, 2015, 8:19

Re: Review Request 121453: Cache QTimeZone for the lifespan of the TimeSource don't recreate every minute

2014-12-11 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121453/#review71827 --- Ship it! Ship It! - Jeremy Whiting On Dec. 11, 2014, 2:30

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

2014-12-11 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71826 --- Ship it! Ship It! - Jeremy Whiting On Dec. 11, 2014, 1:52

Re: Plasma 5.2 parts

2014-12-11 Thread Jeremy Whiting
Also possibly ksshaskpass, which has been in kdereview since early november. On Thu, Dec 11, 2014 at 7:11 AM, Jonathan Riddell wrote: > On Thu, Dec 11, 2014 at 03:09:10PM +0100, Daniel Vrátil wrote: > > Yes. I'll submit kscreen and libkscreen for review and move it to > workspace, > > as we disc

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

2014-12-10 Thread Jeremy Whiting
does is the same thing as the original configChanged. kcms/access/kcmaccess.cpp <https://git.reviewboard.kde.org/r/121424/#comment50030> This should just be removed, you created a QLabel with this text, no need for a commented out line from the old KNumInput api. - Jeremy Whiting

Re: Review Request 121357: Don't allow changing the volume when playing a notification

2014-12-04 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121357/#review71371 --- Ship it! I agree. - Jeremy Whiting On Dec. 4, 2014, 2:23

Re: Review Request 121298: Remove KGlobal check and KComponentData object that overrode applications KAboutData when showing dialogs.

2014-11-30 Thread Jeremy Whiting
). With this change it correctly shows the application name there instead. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121298: Remove KGlobal check and KComponentData object that overrode applications KAboutData when showing dialogs.

2014-11-30 Thread Jeremy Whiting
this change any application that used knewstuff (and thus this plugin) showing a dialog would get -- attica_kde in the titlebar of the dialog. (run kanagram or blinken and show the about dialog to see). With this change it correctly shows the application name there instead. Thanks, Jeremy

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Jeremy Whiting
489c03b18b7bb940007ab51cb197105fbc25de9f Diff: https://git.reviewboard.kde.org/r/121161/diff/ Testing --- knewstuff tests no longer crash on close. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Jeremy Whiting
the same? > > Thomas Lübking wrote: > Depends on whether KdePlatformDependent is ever deleted in a running > application (where the leak would really matter) > If not, then yes: superfluous complication. > > Jeremy Whiting wrote: > Did I hear a "Ship it!&

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/#review70542 --- On Nov. 17, 2014, 2:11 p.m., Jeremy Whiting wrote: > >

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/121161/diff/ Testing --- knewstuff tests no longer crash on close. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
489c03b18b7bb940007ab51cb197105fbc25de9f Diff: https://git.reviewboard.kde.org/r/121161/diff/ Testing --- knewstuff tests no longer crash on close. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
/ Testing --- knewstuff tests no longer crash on close. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121114: Add Q_PLUGIN_METADATA so the attica_kde.so plugin can be loaded by QPluginLoader.

2014-11-13 Thread Jeremy Whiting
ttica patch) Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121114: Add Q_PLUGIN_METADATA so the attica_kde.so plugin can be loaded by QPluginLoader.

2014-11-13 Thread Jeremy Whiting
load the plugin (if it was installed in the right place, I've another attica patch to fix that) but failed because QPluginLoader::instance() would return null without this. Now it works (with my attica patch) Thanks, Jeremy Whiting ___ Plasma-

Review Request 121097: Add a FileDialog to choose the image for fifteenpuzzle.

2014-11-10 Thread Jeremy Whiting
iff: https://git.reviewboard.kde.org/r/121097/diff/ Testing --- Doesn't work here, but I'm hoping it's just a local problem. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-10 Thread Jeremy Whiting
d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 Diff: https://git.reviewboard.kde.org/r/120949/diff/ Testing --- It builds and runs, currently doesn't shuffle, to test the result image works and appears. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kd

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-08 Thread Jeremy Whiting
iff: https://git.reviewboard.kde.org/r/121058/diff/ Testing --- an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in the kcm here anymore. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/m

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
.kde.org/r/121058/diff/ Testing --- an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in the kcm here anymore. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121058/#review70020 --- On Nov. 7, 2014, 3:31 p.m., Jeremy Whiting wrote: > >

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
outer loop Good idea. - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121058/#review70018 --- On Nov. 7, 2014

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
.kde.org/r/121058/diff/ Testing --- an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in the kcm here anymore. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/

Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
~/.config/autostart/ doesn't appear in the kcm here anymore. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Autostart scripts (ksmserver problem)

2014-11-07 Thread Jeremy Whiting
aren't launching them, so shouldn't show those in the kcm in my opinion. BR, Jeremy On Fri, Nov 7, 2014 at 3:02 AM, Martin Yrjölä wrote: > On Fri, Nov 7, 2014 at 8:48 AM, Jeremy Whiting wrote: >> IMO we have two problems here. >> >> 1. the autostart kcm is

Re: Autostart scripts (ksmserver problem)

2014-11-06 Thread Jeremy Whiting
IMO we have two problems here. 1. the autostart kcm is showing scripts from ~/.config/autostart which kinit doesn't start. since ~/.config/autostart is an xdg path that is only meant to start .desktop files we probably shouldn't be showing scripts in the kcm that we don't start. 2. Users with scri

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-05 Thread Jeremy Whiting
--- It builds and runs, currently doesn't shuffle, to test the result image works and appears. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-04 Thread Jeremy Whiting
it: https://git.reviewboard.kde.org/r/120949/#review69718 --- On Nov. 2, 2014, 3:09 p.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-03 Thread Jeremy Whiting
tically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/#review69707 --- On Nov. 2, 2014, 3:09 p.m., Jeremy Whiting wrote: > > --- > This is an au

Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-02 Thread Jeremy Whiting
runs, currently doesn't shuffle, to test the result image works and appears. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

2014-10-29 Thread Jeremy Whiting
dviewer -a org.kde.plasma.fifteenpuzzle. The icon is not working in the widget adder, not sure where to install that to for it to work. Images not supported yet, though they are in the config, maybe should remove from config until they are supported? Thanks, Jeremy Whiting

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

2014-10-28 Thread Jeremy Whiting
I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. The icon is not working in the widget adder, not sure where to install that to for it to work. Images not supported yet, though they are in the config, maybe should remove from config until they are supported? Thanks, Jere

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

2014-10-28 Thread Jeremy Whiting
ve from config until they are supported? Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

2014-10-27 Thread Jeremy Whiting
ed it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. The icon is not working in the widget adder, not sure where to install that to for it to work. Images not supported yet, though they are in the config, maybe should remove from config until they are supported? Thanks, Jere

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

2014-10-27 Thread Jeremy Whiting
rom config until they are supported? Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

2014-10-27 Thread Jeremy Whiting
ed it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. The icon is not working in the widget adder, not sure where to install that to for it to work. Images not supported yet, though they are in the config, maybe should remove from config until they are supported? Thanks, Jere

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

2014-10-27 Thread Jeremy Whiting
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120806/#review69173 ------- On Oct. 25, 2014, 11:48 p.m., Jeremy Whiting wrote: > > --

Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

2014-10-25 Thread Jeremy Whiting
nfig until they are supported? Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120584/#review68402 --- Ship it! Ship It! - Jeremy Whiting On Oct. 14, 2014, 10

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-14 Thread Jeremy Whiting
experiencing before. Nice. - Jeremy Whiting On Oct. 14, 2014, 10:15 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-05 Thread Jeremy Whiting
On Sun, Oct 5, 2014 at 12:30 PM, Albert Astals Cid wrote: > El Divendres, 3 d'octubre de 2014, a les 03:28:44, Aleix Pol va escriure: >> On Fri, Oct 3, 2014 at 1:52 AM, Albert Astals Cid wrote: >> > El Divendres, 3 d'octubre de 2014, a les 00:04:42, Aleix Pol va escriure: >> > > On Thu, Oct 2, 20

Re: SDDM KCM In Plasma

2014-09-29 Thread Jeremy Whiting
David, Is the plan to release it for every plasma release? if not I'd say extragear is fine, no ? BR, Jeremy On Mon, Sep 29, 2014 at 6:45 PM, David Edmundson wrote: > - SDDM KCM's is in github > - Translations won't work whilst it's in github > - I asked if I could move it to plasma > - 3/4

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-29 Thread Jeremy Whiting
t was that way before anyway. The date next to each timezone is the date for that timezone if dates are shown. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120411: Set title on wallpaper kns dialog. BUG:336737

2014-09-28 Thread Jeremy Whiting
Diff: https://git.reviewboard.kde.org/r/120411/diff/ Testing --- The wallpaper kns dialog shows "Download Wallpapers" instead of "Plasma Add-On Installer" Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma

Review Request 120411: Set title on wallpaper kns dialog. BUG:336737

2014-09-28 Thread Jeremy Whiting
shows "Download Wallpapers" instead of "Plasma Add-On Installer" Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-27 Thread Jeremy Whiting
> things (besides the order, but I guess we could live with that for a while). > > Jeremy Whiting wrote: > I'm not sure what you are suggesting here? Remove the i18nc from the new > string altogether? String freeze except

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-27 Thread Jeremy Whiting
e with two timezones selected (Local and London). The date is local date, but it was that way before anyway. The date next to each timezone is the date for that timezone if dates are shown. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Pl

  1   2   >