Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38085 --- src/main/python/apache/aurora/client/cli/quota.py

Re: Review Request 19313: added killall command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19313/#review38086 --- docs/README.md

Re: Review Request 19505: Die, underscores, die!

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19505/ --- (Updated March 21, 2014, 10:28 a.m.) Review request for Aurora, David Robinson

Re: Review Request 19519: Allow override of default RB server in shipits tool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19519/#review38099 --- Ship it! Ship It! - Maxim Khutornenko On March 21, 2014, 2:48 a.

Re: Review Request 16710: Support multiple simulataneous auth mechanisms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16710/#review38100 --- Kevin - mind discarding this review until you're ready to follow up?

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review38101 --- Jake - do you agree with discarding this in favor of https://review

Re: Review Request 16062: fixed structdump usage message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16062/#review38103 --- Sorry for the delay, this is now on master as 4c91787. - Bill Farne

Re: Review Request 18746: fix rollback on failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18746/#review38104 --- Where does this diff stand? Looks like it's getting stale. - Bill

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/#review38105 --- Kevin — are you happy with the updated diff? - Bill Farner On Mar

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated March 21, 2014, 2:59 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 18746: fix rollback on failure

> On March 21, 2014, 2:57 p.m., Bill Farner wrote: > > Where does this diff stand? Looks like it's getting stale. This has been superseded by https://reviews.apache.org/r/18819/. - Maxim --- This is an automatically generated e-mail.

Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17293/#review38107 --- Looks like committers neglected to put this on master. It's now on

Re: Review Request 17056: fix dependencies for setup_py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review38108 --- Update or discard? - Bill Farner On Jan. 17, 2014, 6:37 p.m., Bri

Re: Review Request 16630: Minor Constraint/order() correction 2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16630/#review38109 --- Is this review still relevant? If so, can you add some target revie

Re: Review Request 19207: Removed content about null-op {{#x}}

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19207/#review38110 --- The summary and description don't seem to match the diff here. Can

Re: Review Request 19313: added killall command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19313/#review38112 --- docs/clientcommands.md

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

> On March 21, 2014, 2:52 p.m., Bill Farner wrote: > > Jake - do you agree with discarding this in favor of > > https://reviews.apache.org/r/17750/? Was waiting on Kevin to commit that and then was going to rebase the other changes that I did for this against his https://reviews.apache.org/r/1

Re: Review Request 19436: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/#review38113 --- Ping, Bill? - Maxim Khutornenko On March 20, 2014, 12:20 a.m., Ma

Re: Review Request 19362: Changing from STARTING to RUNNING in job uptime calculations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19362/#review38114 --- Ping. - Maxim Khutornenko On March 18, 2014, 6:16 p.m., Maxim Khu

Review Request 19534: Fix line exceeding 100 cols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19534/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 19534: Fix line exceeding 100 cols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19534/#review38116 --- Ship it! Ship It! - Maxim Khutornenko On March 21, 2014, 4:20 p.

Re: Review Request 19436: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/#review38118 --- Partial review, sorry for the delay — given the sensitive nature of

Re: Review Request 19436: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/#review38123 --- Just to make things clear, this changelist is not addressing the ref

Re: Review Request 19436: Preserving sandbox deleted task history.

> On March 21, 2014, 5:16 p.m., Maxim Khutornenko wrote: > > Just to make things clear, this changelist is not addressing the > > refactoring required to actually fix the problem. It's just the first > > atomic change that sets us up for the following: > > - Persisting SANDBOX_DELETED when tran

Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/ --- (Updated March 21, 2014, 1:58 p.m.) Review request for Aurora, Dave Lester and

Re: Review Request 19243: Adding min retention interval for task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19243/#review38133 --- Ship it! Ship It! - Kevin Sweeney On March 19, 2014, 2:38 p.m.,

Re: Review Request 18658: GZIP HTTP thrift API responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18658/#review38135 --- Ship it! Ship It! - Suman Karumuri On March 20, 2014, 6:29 p.m.,

Re: Review Request 19436: Preserving sandbox deleted task history.

> On March 21, 2014, 5:16 p.m., Maxim Khutornenko wrote: > > Just to make things clear, this changelist is not addressing the > > refactoring required to actually fix the problem. It's just the first > > atomic change that sets us up for the following: > > - Persisting SANDBOX_DELETED when tran

Re: Review Request 19411: Add support for global hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review38139 --- src/main/python/apache/aurora/client/options.py

Re: Review Request 19519: Allow override of default RB server in shipits tool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19519/#review38144 --- Ship it! Ship It! - Suman Karumuri On March 21, 2014, 2:48 a.m.,

Re: Review Request 19411: Add support for global hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/ --- (Updated March 21, 2014, 2:21 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 19466: Add batching to the kill and killall commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38140 --- src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38147 --- Just FYI: the client unit tests weren't intended to detect stuff lik

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38148 --- Please update the end-to-end test - it will cheaply and expressively

Re: Review Request 19466: Add batching to the kill and killall commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38150 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19466: Add batching to the kill and killall commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38154 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 16630: Minor Constraint/order() correction 2

No, this one got shipped a while back. Tom On Fri, Mar 21, 2014 at 8:13 AM, Bill Farner wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16630/ > > Is this review still relevant? If so, can you add some target reviewer > People so it hits

Re: Review Request 19466: Add batching to the kill and killall commands.

> On March 21, 2014, 2:44 p.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/client/cli/test_restart.py, line 43 > > > > > > Right, my comment was about the method in this class that still uses > > the ol

Re: Review Request 19396: Implement client command logging with a unique token.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38155 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 19078: Part 2 of converting from Packages to Metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19078/#review38159 --- Ship it! src/test/python/apache/aurora/client/cli/test_status.py <

Re: Review Request 19466: Add batching to the kill and killall commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/ --- (Updated March 21, 2014, 2:58 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 19396: Implement client command logging with a unique token.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38160 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 19396: Implement client command logging with a unique token.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/ --- (Updated March 21, 2014, 3:06 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 19466: Add batching to the kill and killall commands.

> On March 21, 2014, 6:44 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, line 317 > > > > > > I hear your point. However, it would be a departure from other places > > where we us

Re: Review Request 19431: Add instance specifier syntax to clientv2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38162 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 16710: Support multiple simulataneous auth mechanisms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16710/#review38166 --- you can pull me off this review as I think you have all bases covere

Re: Review Request 19362: Changing from STARTING to RUNNING in job uptime calculations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19362/#review38167 --- Ship it! Ship It! - Brian Wickman On March 18, 2014, 6:16 p.m.,

Re: Review Request 19411: Add support for global hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review38169 --- Ship it! Ship It! - Brian Wickman On March 21, 2014, 6:21 p.m.,

Re: Review Request 19411: Add support for global hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review38171 --- Ship it! - Maxim Khutornenko On March 21, 2014, 6:21 p.m., Mark C

Re: Review Request 19436: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/ --- (Updated March 21, 2014, 7:42 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 19431: Add instance specifier syntax to clientv2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 21, 2014, 3:56 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 19431: Add instance specifier syntax to clientv2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38196 --- src/main/python/apache/aurora/client/cli/options.py

Re: Review Request 19396: Implement client command logging with a unique token.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38198 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 19396: Implement client command logging with a unique token.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38202 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

> On March 21, 2014, 11:58 a.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/quota.py, line 71 > > > > > > Maybe I just read weird stuff, but this wording is uncomfortable: > > "consumption" is

Review Request 19550: Filtering out non-prod tasks for domain sla calculations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19550/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-287 https://issue

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38205 --- Ship it! Ship It! - Mark Chu-Carroll On March 20, 2014, 10:39 p.

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

> On March 21, 2014, 6:27 p.m., Mark Chu-Carroll wrote: > > Just FYI: the client unit tests weren't intended to detect stuff like this. > > The intention of those tests is just to verify that the client logic works > > - meaning that the client sends the API calls that we expect it to. If an

Re: Review Request 19078: Part 2 of converting from Packages to Metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19078/ --- (Updated March 21, 2014, 9:39 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 21, 2014, 10:14 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 19078: Part 2 of converting from Packages to Metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19078/#review38232 --- Ship it! Ship It! - Bill Farner On March 21, 2014, 9:39 p.m., Ma

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38235 --- src/test/python/apache/aurora/client/cli/test_quota.py

Re: Review Request 19436: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/#review38237 --- Ship it! src/main/java/org/apache/aurora/scheduler/state/TaskState

Re: Review Request 19436: Preserving sandbox deleted task history.

> On March 22, 2014, 12:10 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line > > 573 > > > > > > return previousState.getStatus().orNull() Ah, another good featu

Re: Review Request 19436: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/#review38240 --- src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.ja

Re: Review Request 19436: Preserving sandbox deleted task history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/ --- (Updated March 22, 2014, 12:30 a.m.) Review request for Aurora, Kevin Sweeney a