[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-11-13 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 5: (2 comments) Do you have

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-11-03 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-10-30 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-10-30 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8419 ) Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536 .. Patch Set 1: 65K should be fine for experimentation. -- To

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-10-24 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 7: TPCDS is a better workload for min/max filtering than

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-10-22 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 7: I noticed that - BloomFilterBytes is always 0 in the

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-20 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 18: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-12 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 11: (5 comments)

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-11 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-11 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-10-11 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-09 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 14: @Tim, Can you try rerunning

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-04 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 4: Did you the test the case

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-04 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 12: Tim, Please remove all the

[Impala-ASF-CR] IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown

2017-10-03 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8165 ) Change subject: IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-09-26 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-19 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5926 : Avoid printing expensive stack when closing a session

2017-09-13 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has abandoned this change. Change subject: IMPALA-5926 : Avoid printing expensive stack when closing a session .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/8060 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5926 : Avoid printing expensive stack when closing a session

2017-09-13 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has uploaded a new change for review. http://gerrit.cloudera.org:8080/8060 Change subject: IMPALA-5926 : Avoid printing expensive stack when closing a session .. IMPALA-5926 : Avoid printing expensive stack

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-20 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7449/3//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-14 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 4: Can you extend the Sort metrics in the query profile to include Avg, Min and Max run size? This will

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-10 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 4: (1 comment)

[Impala-ASF-CR] [DOCS] Advise setting vm.overcommit memory=1 in various places

2017-07-10 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: [DOCS] Advise setting vm.overcommit_memory=1 in various places .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7349 To

[Impala-ASF-CR] IMPALA-5605: [DOCS] New known issue for upping thread resource limits

2017-07-10 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5605: [DOCS] New known issue for upping thread resource limits .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7348

[Impala-ASF-CR] IMPALA-5605: [DOCS] New known issue for upping thread resource limits

2017-07-10 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5605: [DOCS] New known issue for upping thread resource limits .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5583: [DOCS] Document default join distribution mode query option

2017-07-06 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5583: [DOCS] Document default_join_distribution_mode query option .. Patch Set 2: (3 comments)

[Impala-ASF-CR] Loads all TPC-DS tables

2017-05-23 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Loads all TPC-DS tables .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Loads all TPC-DS tables

2017-05-22 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Loads all TPC-DS tables .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6877 To unsubscribe, visit

[Impala-ASF-CR] Loads all TPC-DS tables

2017-05-16 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Loads all TPC-DS tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6877/2/testdata/datasets/tpcds/tpcds_schema_template.sql File

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-11 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 29: Code-Review+1 (1 comment) Thanks for adding the test cases.

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-11 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 27: (1 comment)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-08 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6812/1/be/src/exec/hdfs-parquet-scanner.cc File

[Impala-ASF-CR] IMPALA-4624: Implement Parquet dictionary filtering

2017-02-21 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4624: Implement Parquet dictionary filtering .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-21 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4624: Implement Parquet dictionary filtering

2017-02-19 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4624: Implement Parquet dictionary filtering .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4624: Implement Parquet dictionary filtering

2017-02-19 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4624: Implement Parquet dictionary filtering .. Patch Set 8: Please add a query option to enabled/disable filtering. -- To view, visit

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-18 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc

[Impala-ASF-CR] Add doc for MT DOP query option.

2017-01-17 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Add doc for MT_DOP query option. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xml File

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-08 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe,

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-07 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 1: How about? - TotalThreadsInvoluntaryContextSwitches: 53 (53) -

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-28 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-26 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 4: Just tried out the latest patch and metadata loading is 5.4x faster. With

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-22 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-18 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 3: (3 comments)