[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2834/ -- To view,

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3956 to review the following change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2835/ -- To view,

[kudu-CR] KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1553: Crash when specifying multiple unbounded range predicates on a column .. Patch Set 3: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/28

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. Patch Set 4: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2826/ -- To view, visit

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Abandoned Abandoning this in favor of http://gerrit.cloudera.org:8080/3868 which has been merged already. -- To

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Abandoned Abandoned in favor of https://gerrit.cloudera.org/#/c/3952/ The new approach uses RPC messenger thread p

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: fs_tool: improve format for dumping a rowset .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2830/ -- To view, visit http://gerrit

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. KUDU-564 (part 1): log a 'diff' when tablet config changes This adds some code to 'diff' two

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3955 to review the following change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 6: (2 comments) TFTR mpercy/dan, I have posted the new diffs under https://ge

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2836/ -- To view,

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3957 to review the following change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Will Berkeley (Code Review)
Hello Chris George, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3871 to look at the new patch set (#4). Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. KUDU-

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#6). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement tab

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: fs_tool: improve format for dumping a rowset .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3946 To unsubscribe, visit http://ger

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3939 to look at the new patch set (#4). Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes ...

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. Patch Set 1: Code-Review+2 (1 comment) Nice. Looks good except for one thing I was wondering about h

[kudu-CR] KUDU-1555. PBC Flush() method should be async

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1555. PBC Flush() method should be async .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2824/ -- To view, visit http://gerrit.cloudera

[kudu-CR](gh-pages) www: Add Spark Summit EU talk

2016-08-12 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/3949 Change subject: www: Add Spark Summit EU talk .. www: Add Spark Summit EU talk Change-Id: I575c1ee7219a96a3c019cb2fe0899dfeef66 --- M c

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 4: Changes and the documentation looks good. -- To view, visit http://gerrit.cloudera.org:8080/3871 To unsub

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#2). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2837/ -- To view, visit http://gerrit.cl

[kudu-CR] KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1553: Crash when specifying multiple unbounded range predicates on a column .. Patch Set 3: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/28

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 4: (3 comments) Looking really good now, sorry I sent you down a rabbit hole with the CreatableRelation st

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2839/ -- To view, visit http://gerrit.cloudera.org

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Will Berkeley (Code Review)
Hello Chris George, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3871 to look at the new patch set (#5). Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. KUDU-

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3871/4/java/kudu-spark/src/main/scala/org/apache/kudu

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3871 To unsubscribe, visit http://gerrit

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. KUDU-1533 Spark Kudu Rdd/Dataframe upsert This patch improves the Kudu SparkSQL integration in two ways: 1)

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 6: Thanks, Will! -- To view, visit http://gerrit.cloudera.org:8080/3871 To unsubscribe, visit http://gerri

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2840/ -- To view, vis

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#7). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has abandoned this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Abandoned abandoning due to duplicate links. original review is under http://gerrit.cloudera.

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has abandoned this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Abandoned abandoning due to duplicate links. original review is under http://gerrit.cloudera.

[kudu-CR] [java-client] Reorganize range partition client API

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/3958 Change subject: [java-client] Reorganize range partition client API .. [java-client] Reorganize range partition client API Equivalient to

[kudu-CR] Reorganize range partition client API

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Reorganize range partition client API .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2841/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] Reorganize range partition client API

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Reorganize range partition client API .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/3882/3/src/kudu/client/client-test.cc File src/kudu/client

[kudu-CR] [java-client] Reorganize range partition client API

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] Reorganize range partition client API .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2842/ -- To view, visit http://gerrit.cl

[kudu-CR] Reorganize range partition client API

2016-08-12 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3882 to look at the new patch set (#4). Change subject: Reorganize range partition client API .. Reorganize range partit

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has abandoned this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Abandoned abandoning due to duplicate links. original review is under http://gerrit.cloudera.

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3823/7/src/kudu/integratio

[kudu-CR] client/sample.cc: fixed a couple of crashes

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: client/sample.cc: fixed a couple of crashes .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3685 To unsubscribe, visit http://gerr

[kudu-CR] client/sample.cc: fixed a couple of crashes

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: client/sample.cc: fixed a couple of crashes .. client/sample.cc: fixed a couple of crashes Fixed 'pure virtual method called' error with subsequent SIGABR

[kudu-CR] KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1553: Crash when specifying multiple unbounded range predicates on a column .. KUDU-1553: Crash when specifying multiple unbounded range predicates o

[kudu-CR] KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1553: Crash when specifying multiple unbounded range predicates on a column .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Reorganize range partition client API

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Reorganize range partition client API .. Patch Set 4: Code-Review+1 (2 comments) basically just looked at the API, rather than the impl, since it looks like Adar

[kudu-CR] [java-client] Reorganize range partition client API

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java-client] Reorganize range partition client API .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3958 To unsubscribe, visit htt

[kudu-CR] Reorganize range partition client API

2016-08-12 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3882 to look at the new patch set (#5). Change subject: Reorganize range partition client API .. Reorganize

[kudu-CR] Reorganize range partition client API

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Reorganize range partition client API .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3882/4/src/kudu/client/client.h File src/kudu/client/client

[kudu-CR] [java-client] Reorganize range partition client API

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] Reorganize range partition client API .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2844/ -- To view, visit http://gerrit.cl

[kudu-CR] Reorganize range partition client API

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Reorganize range partition client API .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2843/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] Add Apache Kudu logo to the source tree

2016-08-12 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Add Apache Kudu logo to the source tree .. Abandoned We'll try to find another place for this. -- To view, visit http://gerrit.cloudera.org:8080/3701 To unsubscribe, visit

[kudu-CR] Memory tracking for result tracker

2016-08-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#20). Change subject: Memory tracking for result tracker .. Memory

[kudu-CR] Memory tracking for result tracker

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 20: Build Started http://104.196.14.100/job/kudu-gerrit/2845/ -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] env posix: improve error message on short writes

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: env_posix: improve error message on short writes .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2846/ -- To view, visit http://gerrit.cloud

[kudu-CR] env posix: improve error message on short writes

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3959 to review the following change. Change subject: env_posix: improve error message on short writes .. env_po

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 13: (11 comments) http://gerrit.cloudera.org:8080/#/c/3628/13/src/kudu/rpc/exactly_once_

[kudu-CR] Memory tracking for result tracker

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 20: Verified+1 known flake -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://ge

[kudu-CR] [util/stopwatch.h] fixed integer overflow

2016-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3960 Change subject: [util/stopwatch.h] fixed integer overflow .. [util/stopwatch.h] fixed integer overflow Fixed integer overflow reported b

[kudu-CR] [util/stopwatch.h] fixed integer overflow

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [util/stopwatch.h] fixed integer overflow .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2847/ -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [util/stopwatch.h] fixed integer overflow

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util/stopwatch.h] fixed integer overflow .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3960 To unsubscribe, visit http://gerrit

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#14). Change subject: Add time/watermark based garbage collection to ResultTracker ..

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/2848/ -- To view, visit http:/

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2849/ -- To view, visit http://gerrit.clou

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3961 Change subject: Start a background thread to run ResultTracker GC .. Start a background thread to run ResultTracker GC Change-Id: Ia34ce95

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 8: Code-Review+1 Looks good to me. Mike, any comments on this? -- To view, visit http://

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/3962 Change subject: Add regex string match assert helper macros .. Add regex string match assert helper macros Change-Id: I05d869479f4032d584a8

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add regex string match assert helper macros .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2851/ -- To view, visit http://gerrit.cloudera.o

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 6: (11 comments) Posting partially addressed feedback except for 2 comments in compaction.cc and 2 comments in

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#8). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement tab

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2850/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add regex string match assert helper macros .. Patch Set 1: I think this same functionality is already available using the ContainsRegex or MatchesRegex matcher f

[kudu-CR] env posix: improve error message on short writes

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: env_posix: improve error message on short writes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3959 To unsubscribe, visit http:/

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3962 to look at the new patch set (#2). Change subject: Add regex string match assert helper macros .. Add regex string

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add regex string match assert helper macros .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2852/ -- To view, visit http://gerrit.cloudera.o

[kudu-CR] env posix: improve error message on short writes

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: env_posix: improve error message on short writes .. env_posix: improve error message on short writes System calls like write() and pwritev() can sometimes

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#9). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement tab

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2853/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3962 to look at the new patch set (#3). Change subject: Add regex string match assert helper macros .. Add regex string

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add regex string match assert helper macros .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2854/ -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [util/stopwatch.h] fixed integer overflow

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [util/stopwatch.h] fixed integer overflow .. [util/stopwatch.h] fixed integer overflow Fixed integer overflow reported by ASAN on MacOS X. The error repor

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2855/ -- To view, visit http://gerrit.clou

[kudu-CR] monotime: use a signed integer for the value

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: monotime: use a signed integer for the value .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2856/ -- To view, visit http://gerrit.cloudera.

[kudu-CR] monotime: use a signed integer for the value

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3963 to review the following change. Change subject: monotime: use a signed integer for the value .. monotime: u

[kudu-CR] KUDU-1559. Fix block manager metric for aborted blocks

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1559. Fix block manager metric for aborted blocks .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2857/ -- To view, visit http://gerrit

[kudu-CR] KUDU-1559. Fix block manager metric for aborted blocks

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3964 to review the following change. Change subject: KUDU-1559. Fix block manager metric for aborted blocks .. KUDU-1559. Fi

[kudu-CR] log block manager: replace custom RAII class with ScopedCleanup

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: log_block_manager: replace custom RAII class with ScopedCleanup .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2858/ -- To view, visit http

[kudu-CR] log block manager: replace custom RAII class with ScopedCleanup

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3965 to review the following change. Change subject: log_block_manager: replace custom RAII class with ScopedCleanup .. log_

[kudu-CR] monotime: remove granularity argument

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Mike Percy, Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3966 to review the following change. Change subject: monotime: remove granularity argument ..

[kudu-CR] monotime: remove granularity argument

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: monotime: remove granularity argument .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2859/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] monotime: use a signed integer for the value

2016-08-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: monotime: use a signed integer for the value .. Patch Set 1: Code-Review+2 lgtm, assuming you did the napkin math and we have plenty of bits to go around -- To vi

[kudu-CR] monotime: use a signed integer for the value

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: monotime: use a signed integer for the value .. Patch Set 1: yea, 2^63 microseconds is 292,277.266 years, so I dont think we're in danger of a system's uptime cro

[kudu-CR] monotime: use a signed integer for the value

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: monotime: use a signed integer for the value .. monotime: use a signed integer for the value MonoTime previously used a uint64_t to store its value. This

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 2: I looped exactly_once_writes-itest with this patch 1000 times (100% pass): http://dist-test.clou

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add regex string match assert helper macros .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3962 To unsubscribe, visit http://gerr

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2860/ -- To view, visit http://gerrit.cl

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#3). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] monotime: remove granularity argument

2016-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: monotime: remove granularity argument .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3966/1//COMMIT_MSG Commit Message: Line 13: