Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107477 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245, 4

Re: Review Request 40559: Added a wait() function to Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/#review107475 --- Patch looks great! Reviews applied: [40250, 40251, 40252, 40274, 4

Re: Review Request 40570: Modified stateUpdate(...) function to get the TaskStatus object by constant reference instead of copy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40570/#review107473 --- Ship it! Ship It! - Guangya Liu On 十一月 21, 2015, 12:21 a.m., An

Re: Review Request 39597: Add Newbie guide.

> On Nov. 6, 2015, 5:18 p.m., Vaibhav Khanduja wrote: > > docs/NewbieQuickStart.md, line 108 > > > > > > I am a "newbie" so was referring to your wip guide. I tried to run this > > command, but looks like it did not

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- (Updated Nov. 21, 2015, 11:47 a.m.) Review request for mesos, Guangya Liu, Arte

Re: Review Request 39456: Documentation: added containerizer internals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review107467 --- Are you still working on this? This doesn't look complete to me? -

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review107466 --- Ship it! Ship It! - Timothy Chen On Nov. 4, 2015, 5:13 p.m., ha

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40114/ --- (Updated Nov. 21, 2015, 1:47 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/ --- (Updated Nov. 21, 2015, 1:45 a.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

> On Nov. 21, 2015, 12:58 a.m., Vinod Kone wrote: > > src/slave/http.cpp, lines 318-322 > > > > > > indent by 4 spaces. > > > > also, it's hard to tell that None() is the argument for statusUpdate() > > and

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40114/ --- (Updated Nov. 21, 2015, 1:18 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 39597: Add Newbie guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review107462 --- Diana are you still able to finish the comments? - Timothy Chen

Re: Review Request 39597: Add Newbie guide.

> On Nov. 6, 2015, 5:18 p.m., Vaibhav Khanduja wrote: > > docs/NewbieQuickStart.md, line 108 > > > > > > I am a "newbie" so was referring to your wip guide. I tried to run this > > command, but looks like it did not

Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40367/#review107459 --- Ship it! Ship It! - Timothy Chen On Nov. 16, 2015, 9:31 p.m., G

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 53-75 > > > > > > What's the motivation of storing this? Should the caller already have > > those informati

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/#review107452 --- src/slave/http.cpp (lines 318 - 322)

Re: Review Request 39490: Always create non-IP egress filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/#review107455 --- I'll fix this for you. - Jie Yu On Nov. 20, 2015, 11:36 p.m., Co

Re: Review Request 40570: Modified stateUpdate(...) function to get the TaskStatus object by constant reference instead of copy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40570/#review107454 --- Ship it! Ship It! - Vinod Kone On Nov. 21, 2015, 12:21 a.m., An

Re: Review Request 39490: Always create non-IP egress filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/#review107453 --- Ship it! src/slave/containerizer/mesos/isolators/network/port_map

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/ --- (Updated Nov. 21, 2015, 12:21 a.m.) Review request for mesos, Ben Mahler, Isabe

Review Request 40570: Modified stateUpdate(...) function to get the TaskStatus object by constant reference instead of copy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40570/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3476 https://issues.ap

Re: Review Request 40562: Added validation for 'uuid' field being present

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40562/#review107451 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 10:47 p.m., An

Re: Review Request 40561: Added an overload for createStatusUpdate(...) function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40561/#review107450 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 10:47 p.m., An

Re: Review Request 40560: Removed redundant fields from Update message in Executor API Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40560/#review107448 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 10:47 p.m., An

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107446 --- Thanks Jojy, I'll fix these myself and merge. - Timothy Chen On

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107444 --- src/cli/execute.cpp (line 237)

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107445 --- Ship it! Ship It! - Timothy Chen On Nov. 20, 2015, 7:45 a.m., J

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107443 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (

Re: Review Request 39490: Always create non-IP egress filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/ --- (Updated Nov. 20, 2015, 11:36 p.m.) Review request for mesos, Ian Downes and Ji

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 336-343 > > > > > > Why introduce this method? I think the caller should be responsible for > > killing th

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 119-130 > > > > > > Why not just use a single `int status` field here. The users can use > > WEXITSTATUS .

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Nov. 20, 2015, 11:25 p.m.) Review request for mesos, Jie Yu, Paul Bret

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 53-75 > > > > > > What's the motivation of storing this? Should the caller already have > > those informati

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 328 > > > > > > I don't like the name 'execute'. When you create the Subprocess > > instance, the subprocss

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 328 > > > > > > I don't like the name 'execute'. When you create the Subprocess > > instance, the subprocss

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 53-75 > > > > > > What's the motivation of storing this? Should the caller already have > > those informati

Re: Review Request 40378: Added link to upgrade guide to documentation page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40378/ --- (Updated Nov. 20, 2015, 10:54 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 40378: Added link to upgrade guide to documentation page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40378/#review107435 --- Looks good, but we should find a better place to put that link. d

Re: Review Request 40403: Added streaming and construction methods for URI.

> On Nov. 18, 2015, 7:54 p.m., Vinod Kone wrote: > > src/uri/schemes/http.hpp, line 38 > > > > > > consider merging `uri/schemes/*` and `src/uri/utils.cpp` into a single > > `src/uri.cpp` file. I thought about that

Re: Review Request 40305: Added URI fetcher interface.

> On Nov. 18, 2015, 7:39 p.m., Vinod Kone wrote: > > include/mesos/uri/fetcher.hpp, line 49 > > > > > > Plugin might be confusing with Module. > > > > Not sure what's a better alternative name is, Downloader?

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote: > > src/master/http.cpp, line 612 > > > > > > The `volumes.flatten()` here looks incorrect to me. For `/reserve`, we > > call `flatten` since the `required` resourc

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 20, 2015, 10:32 p.m.) Review request for mesos, Greg Mann and Mic

Re: Review Request 40245: Fixed typos in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40245/ --- (Updated Nov. 20, 2015, 10:31 p.m.) Review request for mesos, Greg Mann and Mic

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40242/ --- (Updated Nov. 20, 2015, 10:32 p.m.) Review request for mesos, Greg Mann and Mic

Re: Review Request 40246: Removed unused "using" statement from test code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40246/ --- (Updated Nov. 20, 2015, 10:32 p.m.) Review request for mesos, Greg Mann and Mic

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40243/ --- (Updated Nov. 20, 2015, 10:31 p.m.) Review request for mesos, Greg Mann and Mic

Re: Review Request 40553: Enable mesos tests installation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review107429 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 40506: Add stdout/tests/numify_tests.cpp into Makefile.am

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40506/ --- (Updated Nov. 20, 2015, 10:27 p.m.) Review request for mesos, Ben Mahler and Ia

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Nov. 20, 2015, 10:27 p.m.) Review request for mesos, Ian Downes and Ji

Re: Review Request 40497: Add hex number support to numify()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/ --- (Updated Nov. 20, 2015, 10:26 p.m.) Review request for mesos, Ben Mahler and Ia

Re: Review Request 40497: Add hex number support to numify()

> On Nov. 20, 2015, 3:23 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp, line 26 > > > > > > Would be nice to add a couple more positives here, e.g., to catch > > `hex_cas

Re: Review Request 37336: Added `execute()` method to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review107421 --- 3rdparty/libprocess/include/process/subprocess.hpp (lines 53 - 75)

Review Request 40562: Added validation for 'uuid' field being present

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40562/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs: MES

Review Request 40560: Removed redundant fields from Update message in Executor API Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40560/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs: MES

Review Request 40561: Added an overload for createStatusUpdate(...) function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40561/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs: MES

Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs: MES

Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40367/#review107423 --- Ship it! Ship It! - Joerg Schad On Nov. 16, 2015, 9:31 p.m., Gr

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review107420 --- src/common/resources.cpp (lines 879 - 881)

Re: Review Request 40497: Add hex number support to numify()

> On Nov. 20, 2015, 3:23 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp, line 30 > > > > > > I believe giving these proper names would make e.g., the ordering here > > m

Re: Review Request 40293: Applied consistent number style in c++ styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40293/#review107419 --- Ship it! Ship It! - Till Toenshoff On Nov. 20, 2015, 8:42 p.m.,

Re: Review Request 40559: Added a wait() function to Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/ --- (Updated Nov. 20, 2015, 9:06 p.m.) Review request for mesos, Ben Mahler and Vin

Review Request 40559: Added a wait() function to Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3035 https

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40501/#review107415 --- Patch looks great! Reviews applied: [40501] Passed command: expor

Re: Review Request 40293: Applied consistent number syle in c++ styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40293/ --- (Updated Nov. 20, 2015, 8:42 p.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 40293: Applied consistent number style in c++ styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40293/ --- (Updated Nov. 20, 2015, 8:42 p.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 40498: Used factory method to create HDFS client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40498/#review107410 --- Ship it! Ship It! - Vinod Kone On Nov. 19, 2015, 8:22 p.m., Jie

Re: Review Request 40464: Fixed a few style issues in HDFS wrapper code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40464/#review107409 --- Ship it! Ship It! - Vinod Kone On Nov. 19, 2015, 10:16 p.m., Ji

Re: Review Request 40463: Moved HDFS wrapper implementation to a cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40463/#review107407 --- Ship it! Ship It! - Vinod Kone On Nov. 19, 2015, 12:27 a.m., Ji

Re: Review Request 40557: Add documentation about using terminate/wait on Processes when deallocating them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40557/ --- (Updated Nov. 20, 2015, 11:52 a.m.) Review request for mesos, Bernd Mathiske, A

Review Request 40513: [DO NOT COMMIT] Parameterizes existing scheduler tests to run with varieties of SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40513/ --- Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Joris Van Remoo

Re: Review Request 40546: MESOS-3972: fix framework cpu counters on slave page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40546/#review107405 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 40462: Fixed the license header in hdfs.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40462/#review107403 --- Ship it! Ship It! - Vinod Kone On Nov. 19, 2015, 12:26 a.m., Ji

Re: Review Request 40461: Changed HDFS wrapper from a struct to a class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40461/#review107402 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 7:23 p.m., Jie

Re: Review Request 40418: Added curl based URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40418/#review107398 --- Ship it! src/uri/fetcher.cpp (line 40)

Re: Review Request 40268: Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/ --- (Updated Nov. 20, 2015, 11:29 a.m.) Review request for mesos, Artem Harutyunyan

Review Request 40512: Libprocess Reinitialization: Add a test-only method to reinitialize libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs: MES

Review Request 40413: Libprocess Reinitialization: Move ReaperProcess instantiation into process::intialize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs: MES

Review Request 40411: Libprocess Reinitialization: Modify test to use PID instead of a process pointer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40411/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs: MES

Review Request 40410: Libprocess Reinitialization: Move MetricsProcess instantiation into process::initialize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs: MES

Re: Review Request 40556: Added a test filter for CURL tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40556/#review107397 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 7:01 p.m., Jie

Re: Review Request 40461: Changed HDFS wrapper from a struct to a class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40461/ --- (Updated Nov. 20, 2015, 7:23 p.m.) Review request for mesos, Bernd Mathiske, Be

Review Request 40266: Libprocess Reinitialization: Cleanup SocketManager along side ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs: MES

Re: Review Request 40268: Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/ --- (Updated Nov. 20, 2015, 11:19 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/ --- (Updated Nov. 20, 2015, 11:16 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 40264: Libprocess Reinitialization: Implement Clock::finalize for cleaning up timers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40264/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs: MES

Re: Review Request 39948: Remove some undocumented, commented-out code within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39948/ --- (Updated Nov. 20, 2015, 11:16 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40557: Add documentation about using terminate/wait on Processes when deallocating them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40557/#review107395 --- Ship it! 3rdparty/libprocess/README.md (line 139)

Review Request 40557: Add documentation about using terminate/wait on Processes when deallocating them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40557/ --- Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Neil Conway. R

Review Request 40556: Added a test filter for CURL tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40556/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3924 https

Re: Review Request 40532: WIP: Added notion of evictable task to RunTaskMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/#review107393 --- Patch looks great! Reviews applied: [40339, 40524, 40529, 40532]

Review Request 40553: Enable mesos tests installation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-3608 https://issue

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

> On Nov. 19, 2015, 6:16 p.m., Neil Conway wrote: > > Good find. I wonder: > > > > (a) is there some general advice we should give to people implementing > > Processes (e.g., "always provide a destructor that does terminate/wait" -- > > that is probably too broad though). Would be nice to add

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

> On Nov. 17, 2015, 8:18 a.m., Alexander Rukletsov wrote: > > What is the motivation for this? Are there any studies proving it > > facilitates preception? > > Joerg Schad wrote: > Motivation is the current inconsistent writing of numbers e.g. in the c++ > styleguide. > > Alexander Ruklet

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review107389 --- src/master/master.cpp (line 3498)

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote: > > docs/persistent-volume.md, lines 255-280 > > > > > > This looks to be formatted weird, could you double check? Here and below I previewed with mesos-website-con

Re: Review Request 39449: Documented order of includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review107387 --- Patch looks great! Reviews applied: [39449] Passed command: expor

Re: Review Request 40339: WIP: Added a flag to master to enable oversubscription for reservations.

> On Nov. 19, 2015, 9:59 a.m., Joseph Wu wrote: > > Overall notes: > > * Looks like everything is in place (to my knowledge) for this change :) > > * (Mentioned in the last working group sync) We **may** want to rename the > > feature to something else, like "oversubscription for reservations".

Re: Review Request 40507: Cleanup leaked containerizer and potentially orphaned process in SlaveTest.LaunchTaskInfoWithContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40507/#review107383 --- Ship it! Ship It! - Gilbert Song On Nov. 19, 2015, 3:38 p.m., J

Review Request 40456: MESOS-3950: show running task count in web ui

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40456/ --- Review request for mesos. Repository: mesos Description --- MESOS-3950:

Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40545/ --- Review request for mesos. Repository: mesos Description --- MESOS-3970:

  1   2   >