Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/15807
For wholestage codegen, I think that a life time of sub-expressions is
within an iteration for a row. Thus, `isInitialized` and `subExpr1` should be
initialized at the beginning of each iteration. For
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15822
yeah, as per the discussion at
https://github.com/apache/spark/pull/15659#issuecomment-259157516.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #68396 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68396/consoleFull)**
for PR 13909 at commit
[`990d6c8`](https://github.com/apache/spark/commit/9
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15822
Thanks - did this come from a discussion somewhere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15816
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15816
I'm surprised too that we haven't caught this earlier ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15816
Merging in master/branch-2.1/branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15823
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68391/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15823
**[Test build #68391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68391/consoleFull)**
for PR 15823 at commit
[`4e79c37`](https://github.com/apache/spark/commit/
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15627
@kishorvpatil Thank you for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15807
even we modify it to hold the results of subexpressions in member
variables, the above code example should not work under wholestage codegen.
The above code example is similar to non wholesta
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15807
why whole stage codegen can't use member variables to keep the result of
subexpression?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15799
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/15823
LGTM. Not at my laptop, would be great if you can merge @rxin, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15799
merging to master/2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15825
**[Test build #68395 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68395/consoleFull)**
for PR 15825 at commit
[`1200e2d`](https://github.com/apache/spark/commit/1
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15807
> isn't the result of subexpression kept in member variables?
For non-wholestage codegen, yes. For wholestage codegen, no.
---
If your project is set up for it, you can reply to this email a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r87141007
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -810,13 +825,44 @@ private[spark] class HiveExternalCatalog(c
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15799
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15233
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15825
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15807
isn't the result of subexpression kept in member variables? What I am
talking about is something like:
```
private boolean isInitialized = false;
private Int subExpr1 = 0;
priv
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15807
E.g.,
if (isNull(subexpr)) {
...
} else {
AssertNotNull(subexpr) // subexpr2, first used.
SomeExpr(AssertNotNull(subexpr)) // SomeExpr
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15807
> we can't access the subexpression outside later
I don't quite understand it, can you give an example?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15824
**[Test build #68394 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68394/consoleFull)**
for PR 15824 at commit
[`548e45f`](https://github.com/apache/spark/commit/5
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15824
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15824
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15824
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68393/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15824
**[Test build #68393 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68393/consoleFull)**
for PR 15824 at commit
[`548e45f`](https://github.com/apache/spark/commit/
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87138232
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
---
@@ -87,25 +120,40 @@ class HadoopMapReduceCommitProtocol(job
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87138139
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
---
@@ -87,25 +120,40 @@ class HadoopMapReduceCommitProtocol(j
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/spark/pull/15803
I agree with showing the timezone with date string.
But always using GMT/UTC time is not a good choice, logs of
application(using log4j) usually are printed using local timezone(like
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15807
@cloud-fan Then once the first expression to use the subexpression is in a
if/else branch, we can't access the subexpression outside later. Evaluate it
again?
---
If your project is set up for it,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15824
**[Test build #68393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68393/consoleFull)**
for PR 15824 at commit
[`548e45f`](https://github.com/apache/spark/commit/5
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15824
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15825
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68390/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15825
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15825
**[Test build #68390 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68390/consoleFull)**
for PR 15825 at commit
[`1200e2d`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15814
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68388/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15814
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15814
**[Test build #68388 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68388/consoleFull)**
for PR 15814 at commit
[`91f87de`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15814
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15814
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68387/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15814
**[Test build #68387 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68387/consoleFull)**
for PR 15814 at commit
[`4296612`](https://github.com/apache/spark/commit/
Github user zhengruifeng closed the pull request at:
https://github.com/apache/spark/pull/15748
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68386/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15233
**[Test build #68386 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68386/consoleFull)**
for PR 15233 at commit
[`c6d3acd`](https://github.com/apache/spark/commit/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87135950
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -226,6 +238,34 @@ case class DataSourceAnalys
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68384/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15823
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15823
**[Test build #68384 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68384/consoleFull)**
for PR 15823 at commit
[`51d1fbe`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15814
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68385/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15814
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15814
**[Test build #68385 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68385/consoleFull)**
for PR 15814 at commit
[`fbd7b42`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15797
**[Test build #68392 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68392/consoleFull)**
for PR 15797 at commit
[`9dbc3f1`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15823
**[Test build #68391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68391/consoleFull)**
for PR 15823 at commit
[`4e79c37`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15824
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68389/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15824
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15824
**[Test build #68389 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68389/consoleFull)**
for PR 15824 at commit
[`548e45f`](https://github.com/apache/spark/commit/
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15819
Can you add some documentation? The current code is very difficult to
follow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15823
LGTM otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15823#discussion_r87134013
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
---
@@ -42,7 +43,13 @@ class HadoopMapReduceCommitProtocol(jobId
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13758
@cloud-fan yes, we could take the same approach as #15044. When I have just
implement it in my local environment, it can achieve similar performance
improvement.
I will submit that approach to #13
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15807
can we just evaluate subexpression like a scala lazy val?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15825
CC @yhuai @rxin @srown @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15825
**[Test build #68390 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68390/consoleFull)**
for PR 15825 at commit
[`1200e2d`](https://github.com/apache/spark/commit/1
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/15825
[SPARK-18377][SQL] warehouse path should be a static conf
## What changes were proposed in this pull request?
it's weird that every session can set its own warehouse path at runtime, we
Github user ScrapCodes closed the pull request at:
https://github.com/apache/spark/pull/15262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/15262
I was going to close this for now.
@srowen Those deps should not have changed, I have not added anything to
the compile scope. I have not analyzed the working of those deps generation, do
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15824
**[Test build #68389 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68389/consoleFull)**
for PR 15824 at commit
[`548e45f`](https://github.com/apache/spark/commit/5
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15824
cc @cloud-fan @kiszk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/15824
[SQL] Skip subexpression elimination for conditional expressions
## What changes were proposed in this pull request?
As per discussion at #15807, we should disallow subexpression elimination
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/15807
@viirya @cloud-fan It looks reasonable to me that to skip subexpression
elimination for the expressions wrapped in condition expressions such as `if`.
This is because we have only a place at top level
Github user weiqingy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15563#discussion_r87131269
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2587,17 +2589,16 @@ private[spark] class CallerContext(
taskId: Option[Long]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15814
**[Test build #68388 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68388/consoleFull)**
for PR 15814 at commit
[`91f87de`](https://github.com/apache/spark/commit/9
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87109861
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
@@ -86,6 +86,16 @@ abstract class FileCommitProtocol {
def newTa
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87111922
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
---
@@ -42,17 +44,21 @@ class HadoopMapReduceCommitProtocol(job
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87112095
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -350,13 +350,15 @@ case class BroadcastHi
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87113460
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -182,41 +182,53 @@ case class DataSourceAnalysis(
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87129853
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
@@ -86,6 +86,16 @@ abstract class FileCommitProtocol {
def newTa
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87112188
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -418,6 +418,8 @@ case class DataSource(
val
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87111758
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
---
@@ -42,17 +44,21 @@ class HadoopMapReduceCommitProtocol(job
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15814#discussion_r87112037
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -178,18 +178,13 @@ class AstBuilder extends SqlBaseBaseVisi
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15814
**[Test build #68387 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68387/consoleFull)**
for PR 15814 at commit
[`4296612`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15233
**[Test build #68386 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68386/consoleFull)**
for PR 15233 at commit
[`c6d3acd`](https://github.com/apache/spark/commit/c
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/15820
Wow, looks like the new github comment interface did all kinds of weird
things, apologies about that.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15820#discussion_r87129126
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -83,6 +86,113 @@ private[kafka010] case cl
GitHub user gatorsmile reopened a pull request:
https://github.com/apache/spark/pull/15233
[SPARK-17659] [SQL] Partitioned View is Not Supported By SHOW CREATE TABLE
### What changes were proposed in this pull request?
`Partitioned View` is not supported by SPARK SQL. For Hi
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15820#discussion_r87129981
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -83,6 +86,113 @@ private[kafka010] case cl
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15820#discussion_r87129817
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -83,6 +86,113 @@ private[kafka010] case cl
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15820#discussion_r87129927
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -83,6 +86,113 @@ private[kafka010] case cl
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15233
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15233
Sure, let me reopen it. : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15820#discussion_r87127811
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -83,6 +86,113 @@ private[kafka010] case cl
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15820#discussion_r87130059
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -83,6 +86,113 @@ private[kafka010] case cl
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15820#discussion_r87128373
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -83,6 +86,113 @@ private[kafka010] case cl
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15820#discussion_r87129204
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -83,6 +86,113 @@ private[kafka010] case cl
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15814
**[Test build #68385 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68385/consoleFull)**
for PR 15814 at commit
[`fbd7b42`](https://github.com/apache/spark/commit/f
1 - 100 of 560 matches
Mail list logo