[GitHub] spark pull request #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recomm...

2017-04-27 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/17742#discussion_r113862880 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -276,44 +277,53 @@ object MatrixFactorizationModel

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17742 **[Test build #76260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76260/testReport)** for PR 17742 at commit [`a5261b7`](https://github.com/apache/spark/commit/a5

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17795 **[Test build #76259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76259/testReport)** for PR 17795 at commit [`3fdba11`](https://github.com/apache/spark/commit/3f

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-27 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17795 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17795 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17795 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76253/ Test FAILed. ---

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17795 **[Test build #76253 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76253/testReport)** for PR 17795 at commit [`3fdba11`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17742 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76258/ Test PASSed. ---

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17742 **[Test build #76258 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76258/testReport)** for PR 17742 at commit [`8eab55b`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17742 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17191: [SPARK-14471][SQL] Aliases in SELECT could be used in GR...

2017-04-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17191 thanks, mering to master/2.2! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r113860946 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -998,6 +998,27 @@ class Analyzer( } /

[GitHub] spark pull request #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recomm...

2017-04-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17742#discussion_r113860816 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -276,44 +277,53 @@ object MatrixFactorizationMode

[GitHub] spark issue #17736: [SPARK-20399][SQL] Can't use same regex pattern between ...

2017-04-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17736 I don't know why we have `unescapeSQLString` to unescape the string input which causes this inconsistency. Maybe @hvanhovell knows more. --- If your project is set up for it, you can reply to this e

[GitHub] spark pull request #17711: [SPARK-19951][SQL] Add string concatenate operato...

2017-04-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17711#discussion_r113860019 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -547,6 +547,10 @@ valueExpression | left=valueExpressi

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r113859742 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -998,6 +998,27 @@ class Analyzer( }

[GitHub] spark issue #17736: [SPARK-20399][SQL] Can't use same regex pattern between ...

2017-04-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17736 shall we fix this inconsistency too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request #17781: [SPARK-20476] [SQL] Block users to create a table...

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17781 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #16609: [SPARK-8480] [CORE] [PYSPARK] [SPARKR] Add setName for D...

2017-04-27 Thread ivanko2000
Github user ivanko2000 commented on the issue: https://github.com/apache/spark/pull/16609 I am a Spark newbie so I might not be aware of some obvious features, but nonetheless: I consider the usefulness of a metadata field like "name" (not necessarily unique on a global/session level)

[GitHub] spark issue #17781: [SPARK-20476] [SQL] Block users to create a table that u...

2017-04-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17781 LGTM, merging to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark pull request #17711: [SPARK-19951][SQL] Add string concatenate operato...

2017-04-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17711#discussion_r113858362 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -547,6 +547,10 @@ valueExpression | left=valueExpr

[GitHub] spark issue #17785: [SPARK-20493][R] De-deuplicate parse logics for DDL-like...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17785 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76255/ Test PASSed. ---

[GitHub] spark issue #17785: [SPARK-20493][R] De-deuplicate parse logics for DDL-like...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17785 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17785: [SPARK-20493][R] De-deuplicate parse logics for DDL-like...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17785 **[Test build #76255 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76255/testReport)** for PR 17785 at commit [`257e625`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-04-27 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15435 ping @yanboliang @jkbradley This LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-04-27 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r113857158 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1231,6 +1295,109 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-04-27 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r113857182 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1231,6 +1295,109 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

2017-04-27 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r113856908 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1070,90 +1096,128 @@ private[classification] class MultiC

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17742 **[Test build #76258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76258/testReport)** for PR 17742 at commit [`8eab55b`](https://github.com/apache/spark/commit/8e

[GitHub] spark issue #17793: [SPARK-20484][MLLIB] Add documentation to ALS code

2017-04-27 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/17793 +1 for this change. I'll try to take a look sometime, but maybe after the QA period. Also cc @MLnick. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #17556: [SPARK-16957][MLlib] Use weighted midpoints for split va...

2017-04-27 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/17556 I don't mind the weighted midpoints. However, if for a continuous feature we find that many points have the exact same value, we are assuming we may find data points in the test set that are close to

[GitHub] spark issue #17540: [SPARK-20213][SQL][UI] Fix DataFrameWriter operations in...

2017-04-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17540 Personally, I'm fine with this patch, the only concern is we should have a follow up for nested query execution ASAP. And we should revert https://github.com/apache/spark/pull/17540#discussion_r11

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-27 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r113855186 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -1009,10 +1009,24 @@ private[spark] object RandomForest extends Loggin

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-27 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r113855243 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -138,9 +169,10 @@ class RandomForestSuite extends SparkFunSuite w

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-27 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r113854473 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -112,9 +138,11 @@ class RandomForestSuite extends SparkFunSuite w

[GitHub] spark pull request #17556: [SPARK-16957][MLlib] Use weighted midpoints for s...

2017-04-27 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17556#discussion_r113855209 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -1037,7 +1051,10 @@ private[spark] object RandomForest extends Logging

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113855222 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17797: [SparkR][DOC]:Document LinearSVC in R programming...

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17797 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17797: [SparkR][DOC]:Document LinearSVC in R programming guide

2017-04-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17797 merged to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113854501 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark issue #17797: [SparkR][DOC]:Document LinearSVC in R programming guide

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17797 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76257/ Test PASSed. ---

[GitHub] spark issue #17797: [SparkR][DOC]:Document LinearSVC in R programming guide

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17797 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17797: [SparkR][DOC]:Document LinearSVC in R programming guide

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17797 **[Test build #76257 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76257/testReport)** for PR 17797 at commit [`3a59cc2`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #17503: [SPARK-3159][MLlib] Check for reducible DecisionTree

2017-04-27 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/17503 I think the benefit of this would be for speed at predict time or for model storage. @srowen the nodes don't have to be equal to be merged, they just have to output the same prediction. Since this a

[GitHub] spark pull request #17640: [SPARK-17608][SPARKR]:Long type has incorrect ser...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17640#discussion_r113853971 --- Diff: R/pkg/R/serialize.R --- @@ -83,6 +83,7 @@ writeObject <- function(con, object, writeType = TRUE) { Date = writeDate(con, object),

[GitHub] spark issue #17797: [SparkR][DOC]:Document LinearSVC in R programming guide

2017-04-27 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/17797 @felixcheung As I checked the SparkR programming guide, it seems that all machine learning parts are links to existing documents. So I just add the link to Linear SVM document and tested it. T

[GitHub] spark pull request #17640: [SPARK-17608][SPARKR]:Long type has incorrect ser...

2017-04-27 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/17640#discussion_r113853483 --- Diff: R/pkg/R/serialize.R --- @@ -83,6 +83,7 @@ writeObject <- function(con, object, writeType = TRUE) { Date = writeDate(con, object)

[GitHub] spark issue #17797: [SparkR][DOC]:Document LinearSVC in R programming guide

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17797 **[Test build #76257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76257/testReport)** for PR 17797 at commit [`3a59cc2`](https://github.com/apache/spark/commit/3a

[GitHub] spark pull request #17797: [SparkR][DOC]:Document LinearSVC in R programming...

2017-04-27 Thread wangmiao1981
GitHub user wangmiao1981 opened a pull request: https://github.com/apache/spark/pull/17797 [SparkR][DOC]:Document LinearSVC in R programming guide ## What changes were proposed in this pull request? add link to svmLinear in the SparkR programming document. ## How wa

[GitHub] spark issue #16609: [SPARK-8480] [CORE] [PYSPARK] [SPARKR] Add setName for D...

2017-04-27 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/16609 @gatorsmile sure. I will give a PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark issue #17303: [SPARK-19112][CORE] add codec for ZStandard

2017-04-27 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17303 I did quick benchmarks by using a TPCDS query (Q4) (I just referred the previous work in #10342) Based on the result, it seems it's a bit earlier to implement this; ``` scaleFactor: 4

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113851957 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113851718 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17640: [SPARK-17608][SPARKR]:Long type has incorrect ser...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17640#discussion_r113851363 --- Diff: R/pkg/R/serialize.R --- @@ -83,6 +83,7 @@ writeObject <- function(con, object, writeType = TRUE) { Date = writeDate(con, object),

[GitHub] spark issue #17781: [SPARK-20476] [SQL] Block users to create a table that u...

2017-04-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17781 cc @cloud-fan @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark issue #17774: [SPARK-18371][Streaming] Spark Streaming backpressure ge...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17774 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76256/ Test PASSed. ---

[GitHub] spark issue #17774: [SPARK-18371][Streaming] Spark Streaming backpressure ge...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17774 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17774: [SPARK-18371][Streaming] Spark Streaming backpressure ge...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17774 **[Test build #76256 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76256/testReport)** for PR 17774 at commit [`d4a7867`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113849536 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1478,6 +1481,13 @@ test_that("column functions", { lapply( list(list(x =

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113849200 --- Diff: R/pkg/R/column.R --- @@ -67,8 +67,7 @@ operators <- list( "+" = "plus", "-" = "minus", "*" = "multiply", "/" = "divide", "%%" = "mod",

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113849582 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1965,6 +1975,16 @@ test_that("filter() on a DataFrame", { # Test stats::filter i

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113849285 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,65 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value)

[GitHub] spark issue #17786: [SPARK-20483] Mesos Coarse mode may starve other Mesos f...

2017-04-27 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/17786 @mgummelt We tested this in our production env, and it solves our issue. Since it seems to be a trivial change, I made my judgement. Gonna wait for more feedback. Thanks. --- If your project is se

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113849107 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,65 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value)

[GitHub] spark issue #17786: [SPARK-20483] Mesos Coarse mode may starve other Mesos f...

2017-04-27 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/17786 @mgummelt We tested this in our production env, and it solves our issue. Since it seems to be a trivial change, I made my judgement. Gonna wait for more feedback. --- If your project is set up fo

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113847972 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark issue #17774: [SPARK-18371][Streaming] Spark Streaming backpressure ge...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17774 **[Test build #76256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76256/testReport)** for PR 17774 at commit [`d4a7867`](https://github.com/apache/spark/commit/d4

[GitHub] spark issue #17774: [SPARK-18371][Streaming] Spark Streaming backpressure ge...

2017-04-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17774 Jenkins, ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17774: [SPARK-18371][Streaming] Spark Streaming backpressure ge...

2017-04-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17774 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark issue #17785: [SPARK-20493][R] De-deuplicate parse logics for DDL-like...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17785 **[Test build #76255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76255/testReport)** for PR 17785 at commit [`257e625`](https://github.com/apache/spark/commit/25

[GitHub] spark issue #17786: [SPARK-20483] Mesos Coarse mode may starve other Mesos f...

2017-04-27 Thread dgshep
Github user dgshep commented on the issue: https://github.com/apache/spark/pull/17786 Fair point. This felt like a succinct way to handle this corner case, but if it makes sense to harden the offer refusal code instead, I can update. --- If your project is set up for it, you can rep

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113847076 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113846935 --- Diff: R/pkg/R/utils.R --- @@ -864,6 +864,14 @@ captureJVMException <- function(e, method) { # Extract the first message of JVM exception.

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17742 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76254/ Test PASSed. ---

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17742 **[Test build #76254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76254/testReport)** for PR 17742 at commit [`206a023`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17742 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r113846602 --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala --- @@ -82,8 +81,8 @@ private[fpm] trait FPGrowthParams extends Params with HasPre

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r113846530 --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala --- @@ -268,12 +269,8 @@ class FPGrowthModel private[ml] ( val predictUDF

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r113846563 --- Diff: docs/ml-frequent-pattern-mining.md --- @@ -0,0 +1,87 @@ +--- +layout: global +title: Frequent Pattern Mining +displayTitle: Fre

[GitHub] spark issue #17796: [SPARK-20519][SQL][CORE]Modify to prevent some possible ...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17796 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #17796: [SPARK-20519][SQL][CORE]Modify to prevent some po...

2017-04-27 Thread 10110346
GitHub user 10110346 opened a pull request: https://github.com/apache/spark/pull/17796 [SPARK-20519][SQL][CORE]Modify to prevent some possible runtime exceptions Signed-off-by: liuxian ## What changes were proposed in this pull request? For some functions,when the

[GitHub] spark issue #17765: [SPARK-20464][SS] Add a job group and description for st...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17765 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76251/ Test PASSed. ---

[GitHub] spark issue #17765: [SPARK-20464][SS] Add a job group and description for st...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17765 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17765: [SPARK-20464][SS] Add a job group and description for st...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17765 **[Test build #76251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76251/testReport)** for PR 17765 at commit [`6e66638`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #17459: [SPARK-20109][MLlib] Rewrote toBlockMatrix method on Ind...

2017-04-27 Thread johnc1231
Github user johnc1231 commented on the issue: https://github.com/apache/spark/pull/17459 @viirya Any more feedback on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17742 **[Test build #76254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76254/testReport)** for PR 17742 at commit [`206a023`](https://github.com/apache/spark/commit/20

[GitHub] spark issue #17781: [SPARK-20476] [SQL] Block users to create a table that u...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17781 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17781: [SPARK-20476] [SQL] Block users to create a table that u...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76252/ Test PASSed. ---

[GitHub] spark issue #17781: [SPARK-20476] [SQL] Block users to create a table that u...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17781 **[Test build #76252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76252/testReport)** for PR 17781 at commit [`7839a1b`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #17596: [SPARK-12837][CORE] Do not send the name of inter...

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17596 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17596: [SPARK-12837][CORE] Do not send the name of internal acc...

2017-04-27 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17596 LGTM - merging to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17795: [SPARK-20517][UI] Fix broken history UI download ...

2017-04-27 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/17795 [SPARK-20517][UI] Fix broken history UI download link ## What changes were proposed in this pull request? The download link in history server UI is concatenated with: ```

[GitHub] spark issue #17795: [SPARK-20517][UI] Fix broken history UI download link

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17795 **[Test build #76253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76253/testReport)** for PR 17795 at commit [`3fdba11`](https://github.com/apache/spark/commit/3f

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2017-04-27 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/17702 @HyukjinKwon Can you help me to find a appropriate reviewer about this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark issue #17794: Supplement the new blockidsuite unit tests

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17794 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #17765: [SPARK-20464][SS] Add a job group and description for st...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17765 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17765: [SPARK-20464][SS] Add a job group and description for st...

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17765 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76250/ Test PASSed. ---

[GitHub] spark pull request #17794: Supplement the new blockidsuite unit tests

2017-04-27 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/17794 Supplement the new blockidsuite unit tests ## What changes were proposed in this pull request? This PR adds the new unit tests to support ShuffleDataBlockId , ShuffleIndexBlockId , TempS

[GitHub] spark issue #17765: [SPARK-20464][SS] Add a job group and description for st...

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17765 **[Test build #76250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76250/testReport)** for PR 17765 at commit [`f9342c9`](https://github.com/apache/spark/commit/f

  1   2   3   4   5   >